alesapin
9d0c28d96c
Add missing methods
2020-05-26 17:14:08 +03:00
alesapin
8614487a5a
Fix primary key check
2020-05-26 16:46:19 +03:00
Nikolai Kochetov
12384551da
Fix totals and extremes header for views.
2020-05-26 16:19:24 +03:00
alesapin
6626ef08e8
Fix PVS studio errors
2020-05-26 15:14:50 +03:00
Vitaly Baranov
e27ded8798
Merge pull request #11172 from vitlibar/grpc-improve-build-scripts
...
Improve build scripts for protobuf & gRPC
2020-05-26 13:27:54 +03:00
alesapin
5780240e88
Fix primry key check
2020-05-26 12:46:04 +03:00
alesapin
7bbb064b34
Fix metadata update
2020-05-26 11:58:32 +03:00
Alexey Milovidov
c858f4d89c
Clarifications
2020-05-26 02:47:21 +03:00
alexey-milovidov
d4acd1af3a
Merge pull request #11179 from excitoon-favorites/s3globfix
...
Fixed S3 globbing which could fail in case of more than 1000 keys and some backends
2020-05-26 02:45:42 +03:00
Alexey Milovidov
4bb3381bc9
Fix build after merge
2020-05-26 00:53:29 +03:00
filimonov
73a0ef6c0e
Fix for the hang during deletion of engine=Kafka (one more time) ( #11145 )
...
* Added flag for safer rdkafka destruction, but more testing detected another hang case, which has no straigt solutions and can be workarounded currenly only by draining the consumer queue, so destructor is back
* After review fixes
* After review fixes2
* After review fixes3
2020-05-26 00:13:10 +03:00
bobrovskij artemij
27c6eefc85
Merge branch 'master' into mongo
2020-05-25 23:33:38 +03:00
alesapin
355fbadb31
Fix style
2020-05-25 22:18:01 +03:00
alesapin
211d7e229f
Better using
2020-05-25 21:03:04 +03:00
alesapin
adc7439a4c
Comments and refactoring
2020-05-25 20:57:08 +03:00
alesapin
c3a6571036
Compilable code
2020-05-25 20:22:20 +03:00
alesapin
9b3cc9e525
Almost working ttl in IStorage
2020-05-25 20:07:14 +03:00
Vitaly Baranov
58a2172154
Improve build scripts related to protobuf and gRPC.
2020-05-25 18:46:57 +03:00
Vladimir Chebotarev
7f9a257c31
Fixed S3 globbing which could fail in case of more than 1000 keys and some backends.
2020-05-25 15:57:32 +03:00
alesapin
6281dd6893
Merge pull request #11115 from ClickHouse/consistent_metadata
...
Refactoring in storage metadata (more consistent keys)
2020-05-25 13:09:56 +03:00
bobrovskij artemij
a4d74601a6
build warnings fix
2020-05-25 00:42:05 +03:00
Alexey Milovidov
4ebf63fb23
Fixed error
2020-05-24 22:17:15 +03:00
Azat Khuzhin
c36708caf9
Split data skipping indexes from the order by to evaluate order by before merge
2020-05-24 16:12:08 +03:00
Azat Khuzhin
71731b2e99
Fix data skipping indexes for columns with additional actions during merge
...
For example for AggregatingMergeTree if the column in the data skipping
index is under some aggregate function, then data skipping index will be
incorrect.
Fix this by calculating data skipping indexes after aggregation has been
done.
2020-05-24 16:12:08 +03:00
Alexey Milovidov
7e1813825b
Return old names of macros
2020-05-24 01:24:01 +03:00
Alexey Milovidov
af2a59e49b
Progress on task
2020-05-24 00:50:34 +03:00
Alexey Milovidov
c87fb91532
Progress on task
2020-05-24 00:41:35 +03:00
Alexey Milovidov
ce0619dabf
Progress on task
2020-05-24 00:26:45 +03:00
Alexey Milovidov
2d7d5a1547
Apply all transformations again
2020-05-24 00:16:27 +03:00
Alexey Milovidov
bab24879e9
Progress on task
2020-05-24 00:16:05 +03:00
Alexey Milovidov
e1695feb7f
Apply all transformations again
2020-05-23 23:40:32 +03:00
Alexey Milovidov
85f84550ba
Progress on task
2020-05-23 23:37:37 +03:00
Alexey Milovidov
f75587e562
Progress on task
2020-05-23 23:13:34 +03:00
Alexey Milovidov
18febd7b97
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_[^\_(]+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+"\);' | while read file; do perl -pne 's/(LOG_[^\_(]+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)"\);/${1}_FORMATTED(${2}, "${3}{}${5}{}${7}{}${9}{}${11}", ${4}, ${6}, ${8}, ${10});/' $file > ${file}.tmp; mv ${file}.tmp $file; done
2020-05-23 22:56:05 +03:00
Alexey Milovidov
cd6d3c7509
Progress on task
2020-05-23 22:55:06 +03:00
Alexey Milovidov
d5b7883451
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_[^\_(]+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_[^\_(]+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5{}\7{}\9", \4, \6, \8);/'
2020-05-23 22:41:08 +03:00
Alexey Milovidov
7e2fb9ad65
Apply all transformations again
2020-05-23 22:38:30 +03:00
Alexey Milovidov
eacff92d0e
Progress on task
2020-05-23 22:35:08 +03:00
Alexey Milovidov
29762240de
Remove duplicate whitespaces (preparation)
2020-05-23 22:31:54 +03:00
Alexey Milovidov
7fed65cbe2
Remove duplicate whitespaces (preparation)
2020-05-23 22:14:58 +03:00
Alexey Milovidov
86b4d5a86f
Remove duplicate whitespaces (preparation)
2020-05-23 22:09:06 +03:00
Alexey Milovidov
ab0562a574
Make all LOG in single line (preparation)
2020-05-23 22:05:41 +03:00
Alexey Milovidov
9d2a0d2dd7
Apply all transformations again
2020-05-23 21:59:49 +03:00
Alexey Milovidov
a2ad11897f
Remove duplicate whitespaces (preparation)
2020-05-23 21:53:58 +03:00
Alexey Milovidov
1f13515a65
Make all LOG in single line (preparation)
2020-05-23 21:31:37 +03:00
Alexey Milovidov
3384f3b77e
Progress on task
2020-05-23 21:07:38 +03:00
Alexey Milovidov
fc412f2d9d
Progress on task
2020-05-23 20:59:03 +03:00
Alexey Milovidov
9d24908e53
Progress on task
2020-05-23 20:52:11 +03:00
Alexey Milovidov
3a09f9ca1c
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_[^\W_]+\([^,]+, [^<+)"]+\);' | xargs sed -i -r -e 's/(LOG_[^\W_]+)\(([^,]+), ([^<+)"]+)\);/\1_FORMATTED(\2, \3);/'
2020-05-23 20:29:56 +03:00
Alexey Milovidov
b3f4fe12dd
Progress on task
2020-05-23 20:25:19 +03:00
Alexey Milovidov
d6bc4d2bd0
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, [^<]+ << "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), ([^<]+) << "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "{}\4{}", \3, \5);/'
2020-05-23 20:14:57 +03:00
Alexey Milovidov
241f8c5431
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" \+ [^+]+ \+ "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" \+ ([^+]+) \+ "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5", \4);/'
2020-05-23 20:10:21 +03:00
Alexey Milovidov
f69cbdcbfc
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" \+ [^+]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" \+ ([^+]+)\);/\1_FORMATTED(\2, "\3{}", \4);/'
2020-05-23 20:09:37 +03:00
Alexey Milovidov
f68d1ceb4f
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}\5{}\7{}", \4, \6, \8);/'
2020-05-23 20:02:09 +03:00
Alexey Milovidov
533f86278a
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5{}\7", \4, \6);/'
2020-05-23 20:00:41 +03:00
Alexey Milovidov
8042e5febe
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}\5{}", \4, \6);/'
2020-05-23 19:58:15 +03:00
Alexey Milovidov
e391b77d81
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+ << "[^"]+"\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+) << "([^"]+)"\);/\1_FORMATTED(\2, "\3{}\5", \4);/'
2020-05-23 19:56:05 +03:00
Alexey Milovidov
ee4ffbc332
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+" << [^<]+\);' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+), "([^"]+)" << ([^<]+)\);/\1_FORMATTED(\2, "\3{}", \4);/'
2020-05-23 19:47:56 +03:00
Alexey Milovidov
8d2e80a5e2
find {base,src,programs} -name '*.h' -or -name '*.cpp' | xargs grep -l -P 'LOG_\w+\([^,]+, "[^"]+"\)' | xargs sed -i -r -e 's/(LOG_\w+)\(([^,]+, "[^"]+")\)/\1_FORMATTED(\2)/'
2020-05-23 19:42:39 +03:00
Alexey Milovidov
35d79e1252
fmt-style logging, part 1
2020-05-23 19:33:07 +03:00
alexey-milovidov
ac6deaf8ec
Merge pull request #11036 from excitoon-favorites/s3fixes
...
Fixed parsing of S3 URL
2020-05-23 17:06:59 +03:00
Azat Khuzhin
bc4b75dead
Add table name into logs for StorageDistributed
2020-05-23 11:57:14 +03:00
alesapin
cd83ebc599
Merge pull request #11106 from ClickHouse/fix_deadlock_system_logs_startup
...
Fix deadlock in system tables during server startup
2020-05-22 20:53:07 +03:00
alesapin
e812fa15d1
Merge branch 'consistent_metadata' into consistent_metadata2
2020-05-22 17:41:53 +03:00
alesapin
e971ff627e
Fix gcc-9 build
2020-05-22 17:39:49 +03:00
alesapin
f026fa7de1
Rename PartDestinationType to DataDestionationType, because there is no part-specific information
2020-05-22 16:29:33 +03:00
alesapin
a935db4169
boop CI
2020-05-22 15:34:26 +03:00
alexey-milovidov
b82c633716
Merge pull request #11048 from filimonov/kafka_missed_data_during_drop
...
Fixes the potential missed data during termination of Kafka engine table
2020-05-22 14:11:10 +03:00
alesapin
f4b0d475af
Fix system.tables output
2020-05-22 14:04:15 +03:00
alesapin
98ffefd90c
Fix bug with return type
2020-05-22 13:09:24 +03:00
Vladimir Chebotarev
98f31374d5
Added improved S3 URL parsing to DiskS3
.
2020-05-22 11:18:34 +03:00
alesapin
cbcdb6219e
Slighty more verbose comment
2020-05-22 11:17:57 +03:00
Vladimir Chebotarev
02cb08ea2f
Fixed parsing of S3 URL.
2020-05-22 11:17:10 +03:00
alesapin
b9dfa61774
Merge pull request #11042 from CurtizJ/modify-ttl
...
Apply TTL for old data, after ALTER MODIFY TTL query
2020-05-22 11:12:14 +03:00
Dmitry
47778c0259
Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization
2020-05-21 23:45:12 +03:00
alesapin
59b3bc0c05
Merge branch 'master' into fix_deadlock_system_logs_startup
2020-05-21 22:57:52 +03:00
alesapin
09034157cd
Remove comments
2020-05-21 22:53:46 +03:00
alesapin
327d17ac6a
Better
2020-05-21 22:46:03 +03:00
alesapin
41914588fd
More clear
2020-05-21 22:07:18 +03:00
alesapin
1906762119
Merge pull request #11109 from ClickHouse/less_verbose_logging
...
Less verbose logging in mutation finalization task
2020-05-21 21:53:08 +03:00
Alexander Kuzmenkov
f98ffdbc4c
Merge pull request #11087 from azat/context-fwd-decl
...
[RFC] Forward declaration for Context as much as possible.
2020-05-21 19:43:29 +03:00
alesapin
87eab514fb
Merge branch 'master' into consistent_metadata
2020-05-21 18:54:52 +03:00
alesapin
5676340f6b
Less verbose logging in mutation finalization task
2020-05-21 18:52:11 +03:00
alesapin
c036af0261
Fix deadlock after clickhouse-server update (with changes in one of system log tables structure) during startup between concurrent merge and table rename.
2020-05-21 17:11:56 +03:00
alexey-milovidov
765510d5c3
Merge pull request #10991 from ClickHouse/enable-clang-tidy-for-programs-and-utils
...
Enable clang-tidy for programs and utils
2020-05-21 15:12:07 +03:00
Alexey Milovidov
2fa264d83e
Fix style #10591
2020-05-21 12:46:00 +03:00
alexey-milovidov
b6b62dbdbc
Merge pull request #10591 from excitoon-favorites/ttl_introspection
...
Added `move_ttl_info` to `system.parts`
2020-05-21 12:43:49 +03:00
BohuTANG
c9d315654c
Fix Storages/MergeTree typo
2020-05-21 17:00:44 +08:00
Azat Khuzhin
d93b9a57f6
Forward declaration for Context as much as possible.
...
Now after changing Context.h 488 modules will be recompiled instead of 582.
2020-05-21 01:53:18 +03:00
Anton Popov
6d8749b100
in-memory parts: faster computation of checksums
2020-05-21 01:16:08 +03:00
kssenii
4dc659b763
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into add-storage-rabbitmq-read-only
2020-05-20 18:17:41 +00:00
alesapin
616902a995
Sorting and primary key (broken)
2020-05-20 21:11:38 +03:00
alesapin
9fb28f5ac0
Add sampling key
2020-05-20 18:16:39 +03:00
Anton Popov
d62fe980ef
Merge remote-tracking branch 'upstream/master' into modify-ttl
2020-05-20 16:52:30 +03:00
alesapin
8bc527eecd
Compile partition key
2020-05-20 15:16:55 +03:00
Anton Popov
4fb6492b08
in-memory parts: delay merges
2020-05-20 15:02:02 +03:00
alexey-milovidov
da33858d39
Update StorageSystemParts.cpp
2020-05-20 14:07:31 +03:00
Vladimir Chebotarev
02b52df86d
Added delete_ttl_info_min
and delete_ttl_info_max
to system.parts
.
2020-05-20 14:07:31 +03:00
Vladimir Chebotarev
6f68979662
Switched system.parts.move_ttl_info
to separate arrays.
2020-05-20 14:07:31 +03:00
Vladimir Chebotarev
3ed5d9434a
Added move_ttl_info
to system.parts
.
2020-05-20 14:07:31 +03:00
kssenii
aeffab3fdb
Enable SELECT and CREATE MV queries with engine RabbitMQ
2020-05-20 09:40:49 +00:00
Mikhail Filimonov
e8a13842af
Better fix, previous fix was wrong (was leaving the cycle by eof condition)
2020-05-20 11:02:02 +02:00
alesapin
dc330ca7cb
Merge pull request #11037 from ClickHouse/alter_rename_and_modify
...
Fix alter rename with different types of alter
2020-05-20 11:28:13 +03:00
kssenii
3b75f214c5
Register RabbitMQ storage
2020-05-20 09:09:20 +03:00
Mikhail Filimonov
34198336ed
Style
2020-05-19 19:02:37 +02:00
Mikhail Filimonov
b50480cbde
Fixes the potential missed data during termination of Kafka engine table
2020-05-19 18:55:37 +02:00
alesapin
7d382cc7b5
Return missed command
2020-05-19 19:03:10 +03:00
alesapin
4906dbef41
Remove redundant logs
2020-05-19 13:46:56 +03:00
alesapin
2b37a418f2
More clear logic
2020-05-19 13:44:53 +03:00
alesapin
111c576579
Slightly less garbage
2020-05-19 13:03:05 +03:00
alesapin
70e5553204
At least something works
2020-05-19 12:54:56 +03:00
Anton Popov
58ed04dc24
materialize TTL after its modifying
2020-05-19 04:53:01 +03:00
alesapin
07cb21ccb7
Merge branch 'master' into refactor-reservations
2020-05-18 11:43:48 +03:00
Alexey Milovidov
f54435e7fd
Fix clang-tidy
2020-05-18 11:08:55 +03:00
alexey-milovidov
7efd2a825f
Merge pull request #10463 from ClickHouse/parallel-final
...
Parallel final
2020-05-18 05:20:18 +03:00
alexey-milovidov
073dc2e1e3
Merge pull request #10986 from ClickHouse/try-fix-use-after-free-mergetree
...
Try to fix use-after-free error in MergeTree
2020-05-18 03:41:53 +03:00
alexey-milovidov
3820075813
Merge pull request #10983 from azat/configure-librdkafka
...
Configure librdkafka (logging and thread names)
2020-05-17 23:25:18 +03:00
Alexey Milovidov
70c31cbdc4
Fix error
2020-05-17 22:44:31 +03:00
Alexey Milovidov
81a7930c3e
Merge branch 'master' of github.com:yandex/ClickHouse into try-fix-use-after-free-mergetree
2020-05-17 22:42:34 +03:00
Alexey Milovidov
20dbd6c3ef
Fix error
2020-05-17 22:41:49 +03:00
alexey-milovidov
ca1a9b890d
Revert "Try to fix use-after-free error in MergeTree"
2020-05-17 22:36:27 +03:00
alexey-milovidov
8d3c37992a
Merge pull request #10533 from ClickHouse/alter-key-column-better-exception-message
...
Better exception message and error code for ALTER of key column #9078
2020-05-17 22:21:14 +03:00
Azat Khuzhin
e3d69eea88
Configure thread names for librdkafka
...
First of all it is nice to have part of the table name in it.
And secondly, librdkafka uses pthread_setname_np(), but due to
glibc-compatibility it is a noop in clickhouse sources:
# librdkafka uses rdk: prefix for thread names by default
$ grep rdk /proc/$(pgrep clickhouse-serv)/task/*/comm
# just in case:
$ grep rdk /proc/*/task/*/comm
$ grep rdk /proc/*/comm
(gdb) disas pthread_setname_np
Dump of assembler code for function pthread_setname_np:
0x000000000c603250 <+0>: xor %eax,%eax
0x000000000c603252 <+2>: retq
End of assembler dump.
2020-05-17 20:40:18 +03:00
Azat Khuzhin
dbe781451a
Redirect librdkafka logs from stderr to clickhouse logger
2020-05-17 20:27:36 +03:00
alexey-milovidov
7cf3538840
Merge pull request #10270 from ClickHouse/quota-key-in-client
...
Support quota_key for Native client
2020-05-17 14:09:40 +03:00
alexey-milovidov
7ee35f102d
Merge pull request #10867 from azat/dist-INSERT-load-balancing
...
Respect prefer_localhost_replica/load_balancing on INSERT into Distributed
2020-05-17 11:11:35 +03:00
Alexey Milovidov
7971f62776
Fix test
2020-05-17 10:47:53 +03:00
alexey-milovidov
421eb6df8f
Merge pull request #10970 from ClickHouse/try-fix-use-after-free-mergetree
...
Try to fix use-after-free error in MergeTree
2020-05-17 09:09:45 +03:00
alexey-milovidov
a3346e9331
Merge pull request #10912 from ClickHouse/static-mutate
...
Static mutate
2020-05-17 09:05:35 +03:00
Alexey Milovidov
397859ccb8
Fix error
2020-05-17 08:45:20 +03:00
Alexey Milovidov
9fcfe5fb14
Better exception message and error code for ALTER of key column #9078
2020-05-17 07:46:25 +03:00
alexey-milovidov
0fd0711b51
Merge pull request #10910 from filimonov/kafka_drop_hang_fix
...
Fix for the hang during deletion of engine=Kafka
2020-05-17 07:13:54 +03:00
Alexey Milovidov
88ee76186b
Try to fix use-after-free error in MergeTree
2020-05-17 07:12:33 +03:00
alexey-milovidov
0d76091fd9
Merge pull request #10940 from azat/dist-send-partially-written-read-fix
...
Avoid sending partially written files by the DistributedBlockOutputStream
2020-05-17 06:53:51 +03:00
Gleb Novikov
1a25ac6e1f
Merge branch 'master' into refactor-reservations
2020-05-16 23:34:45 +03:00
Gleb Novikov
45b84d491e
small fixes of review remarks
2020-05-16 23:31:17 +03:00
alesapin
d0b56a4c7d
Merge pull request #10887 from ClickHouse/vzakaznikov-add_alter_rename_column_to_distributed
...
Vzakaznikov add alter rename column to distributed
2020-05-16 12:54:32 +03:00
alesapin
be4037abb5
Merge pull request #10895 from ClickHouse/fix_multiple_renames
...
Fix error in multiple rename commands in a single query.
2020-05-16 12:54:04 +03:00
ageraab
cb24d47472
Merge branch 'master' into mongo
2020-05-16 02:56:22 +03:00
bobrovskij artemij
8c6f687010
build/style fix
2020-05-16 02:55:27 +03:00
Azat Khuzhin
2498041cc1
Avoid sending partially written files by the DistributedBlockOutputStream
2020-05-16 01:00:42 +03:00
tavplubix
cc4ddfd89e
Merge pull request #10901 from ClickHouse/merging_10554
...
Merging #10554
2020-05-15 23:23:02 +03:00
Mikhail Filimonov
405cce2c53
Another variant of fix. It looks like we do not need destructor at all
2020-05-15 22:19:21 +02:00
alesapin
a504db3451
Fix typo
2020-05-15 18:11:13 +03:00
alesapin
97c2e549be
Merge pull request #10865 from azat/dist-dir-mon-fix
...
Fix ENOENT exception on current_batch.txt in DirectoryMonitor
2020-05-15 18:05:48 +03:00
Anton Popov
c61f1dbac8
Merge remote-tracking branch 'upstream/master' into polymorphic-parts
2020-05-15 16:19:39 +03:00
Vitaly Baranov
d92ac9ea47
Merge branch 'master' into RBAC-10
2020-05-15 14:12:43 +03:00
alesapin
26606dd640
Fix polymorphic parts
2020-05-15 13:36:35 +03:00
Anton Popov
14e1a46a8c
Merge remote-tracking branch 'upstream/master' into polymorphic-parts
2020-05-15 03:48:27 +03:00
Anton Popov
4c03f48703
in-memory parts: better restoring
2020-05-15 03:39:15 +03:00
bobrovskij artemij
95677432e5
MongoDB engine (read-only)
2020-05-14 23:59:03 +03:00
alesapin
8eb27f6f13
Fix rename with compact parts
2020-05-14 19:56:13 +03:00
tavplubix
a47bf09337
Merge pull request #10859 from ClickHouse/fix_watch_livelock_with_database_atomic
...
Fix livelock with WATCH queries and DatabaseAtomic
2020-05-14 15:11:41 +03:00
Vitaly Baranov
c30587196a
Add system tables for users, roles and grants.
2020-05-14 14:12:20 +03:00
Vitaly Baranov
b1f362b2dc
Add system table for access types.
2020-05-14 14:12:20 +03:00
Vitaly Baranov
a14f322723
Add system tables for settings profiles.
2020-05-14 14:12:15 +03:00
alesapin
316773d853
Better comment
2020-05-14 13:30:53 +03:00
Mikhail Filimonov
6499d702f9
After review fixes
2020-05-14 12:15:38 +02:00
Nikolai Kochetov
4d22374f24
Merged with master.
2020-05-14 12:06:15 +03:00
Mikhail Filimonov
a1013f1e71
Fix for the hang during deletion of engine=Kafka
2020-05-14 10:38:02 +02:00
Nikolai Kochetov
4d0503f021
Make IColumn::mutate() static.
2020-05-14 11:30:18 +03:00
Azat Khuzhin
52d73c7f45
Fix prefer_localhost_replica=0 and load_balancing for Distributed INSERT
2020-05-14 03:29:03 +03:00
Azat Khuzhin
e1d4837753
Fix list of possible nodes for Distributed INSERT for internal_replication=0
2020-05-14 03:28:08 +03:00
Azat Khuzhin
cdf3845e43
Respect load_balancing in DirectoryMonitor, to fix w/o internal_replication
2020-05-14 01:33:25 +03:00
alexey-milovidov
623b2e5a43
Merge pull request #10849 from ClickHouse/fix_optimize_and_alter_hangs
...
Fix mutations and OPTIMIZE hangs when replica becomes inactive
2020-05-13 23:41:13 +03:00
Nikolai Kochetov
496d90b613
Merge pull request #10860 from CurtizJ/pk-function
...
Fix sample with final (addition to #10715 )
2020-05-13 23:04:25 +03:00
Alexander Tokmakov
ef52acdbde
Merge branch 'master' into merging_10554
2020-05-13 21:30:26 +03:00
alesapin
ab760846c2
Fix some rename cases
2020-05-13 20:43:30 +03:00
Vitaly Baranov
5b84121d81
Improve system tables for quotas. Remove function currentQuota().
2020-05-13 19:40:48 +03:00
Vitaly Baranov
e64e2ebdf6
Improve system table for row policies. Remove function currentRowPolicies().
2020-05-13 19:40:48 +03:00
Vitaly Baranov
b6fe726777
Rename row policy's 'name' to 'short_name', 'full_name' to 'name'.
...
This change simplifies the interface of IAccesEntity.
2020-05-13 19:40:48 +03:00
Vitaly Baranov
6f15a0d443
Improve the function range() to allow iterating through enum values.
2020-05-13 19:40:48 +03:00
Anton Popov
84d4ad4315
add some comments
2020-05-13 19:00:06 +03:00
Dmitry
bbe0245b9d
changes after review #1
2020-05-13 16:49:10 +03:00
alesapin
2316851be6
Merge pull request #10855 from ClickHouse/get_rid_of_strange_fields
...
Better comments in IStorage interface
2020-05-13 15:59:50 +03:00
alesapin
352c402cf2
Merge branch 'add_alter_rename_column_to_distributed' of https://github.com/vzakaznikov/ClickHouse into vzakaznikov-add_alter_rename_column_to_distributed
2020-05-13 14:14:23 +03:00
alesapin
f209052519
Better comments
2020-05-13 14:04:27 +03:00
alesapin
377ef6535d
Merge pull request #10847 from ClickHouse/fix_alter_rename_and_constraints
...
Fix constraints after column rename
2020-05-13 11:09:55 +03:00
Alexander Tokmakov
032197b015
fix alter and optimize hangs when replica becomes inactive
2020-05-13 10:06:57 +03:00
alesapin
13c8ffc0c9
Fix exception message after server shutdown ( #10841 )
...
* After shutdown cancel background logs pulling after task were deleted from pool
* Fix comment
* Cancel with lock
* Remove whitspace
2020-05-13 06:35:43 +03:00
Dmitry
152a636c23
fix bad merge
2020-05-13 03:13:01 +03:00
Azat Khuzhin
085bafad05
Handle prefer_localhost_replica on INSERT into Distributed
...
Right now it will issue remote send even if finally the local replica
will be selected - not good I guess.
This should also fix load_balancing.
2020-05-13 01:38:03 +03:00
Azat Khuzhin
889f54b549
Fix ENOENT exception on current_batch.txt in DirectoryMonitor
...
current_batch.txt will not exist if there was no send, this is the case
when all batches that was pending has been marked as pending.
2020-05-13 01:23:18 +03:00
Anton Popov
67213b8ad4
fix sample with final
2020-05-12 21:23:40 +03:00
Alexander Tokmakov
5ffb7372af
fix livelock with watch queries and database atomic
2020-05-12 21:10:10 +03:00
alesapin
262b6287ab
Fix clang-tidy warnings
2020-05-12 19:38:11 +03:00
Dmitry
c4295d97f9
Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization
2020-05-12 17:57:32 +03:00
Nikolai Kochetov
0ef9b20823
Try fix sample final.
2020-05-12 17:37:19 +03:00
alesapin
2b51b7aa2a
Remove redundant using
2020-05-12 14:47:59 +03:00
alesapin
979779e06f
Fix constraints after column rename
2020-05-12 14:26:44 +03:00
Nikolai Kochetov
5d13327ad8
Try fix merge with master.
2020-05-12 12:22:01 +03:00
Anton Popov
a1333895eb
Merge pull request #10791 from oandrew/key-condition-source-type
...
Use src_type for conversion in KeyCondition
2020-05-12 03:29:43 +03:00
Alexey Milovidov
25cf842491
Fix the issue with ODBC bridge and identifier_quoting_style = None #7984
2020-05-11 23:05:08 +03:00
Gleb Novikov
d255bb998a
VolumePtr instead of DiskPtr in IMergedBlockOutputStream and inherited classes
2020-05-11 20:20:26 +03:00
alexey-milovidov
33d491edf3
Merge pull request #10516 from azat/dist-GROUP_BY-sharding_key-fixes
...
Disable GROUP BY sharding_key optimization by default (and fix for WITH ROLLUP/CUBE/TOTALS)
2020-05-11 12:03:27 +03:00
alexey-milovidov
06ba85fdf2
Merge pull request #10795 from ClickHouse/list-licenses
...
Added "system.licenses" table
2020-05-11 09:00:55 +03:00
Alexey Milovidov
3fcbb06cab
Fix MSan report in MergeTreeIndexFullText
2020-05-11 08:04:59 +03:00
Alexey Milovidov
141218d44a
Fix Arcadia
2020-05-11 07:36:32 +03:00
Alexey Milovidov
c5e78d12e7
Merge branch 'master' into list-licenses
2020-05-11 07:35:35 +03:00
alexey-milovidov
40ef113503
Merge branch 'master' into parallel-final
2020-05-11 06:47:44 +03:00
alexey-milovidov
ddc84163a7
Merge pull request #10486 from azat/dist-send-on-INSERT
...
Fix distributed send that are scheduled by INSERT query
2020-05-11 06:28:35 +03:00
Alexey Milovidov
da583760c4
Added "system.licenses" table
2020-05-11 05:39:01 +03:00
Andrew Onyshchuk
330f06328f
Use src_type for convertion in KeyCondition
2020-05-10 18:17:54 -05:00
Gleb Novikov
1235c36f3e
data_part instead of volume in IMergeTreeDataPartWriter (as it done in IMergeTreeReader)
2020-05-10 16:33:27 +03:00
Gleb Novikov
57b6fb6d80
Merge branch 'master' into refactor-reservations
2020-05-10 13:01:45 +03:00
Azat Khuzhin
5c89cdbe61
Fix distributed send retries on distributed_directory_monitor_{max_,}sleep_time_ms > 5min
...
In this case error_count can be decreased before checking it for
rescheduling send.
And actually this can be a problem not only when
distributed_directory_monitor_{max_,}sleep_time_ms > 5min, because all
threads can be occupated and the real timeout between sends will be > 5min.
2020-05-10 12:37:38 +03:00
Alexey Milovidov
36d9d646a9
Fix race condition in ReplicatedMergeTreeQueue
2020-05-10 05:18:10 +03:00
alexey-milovidov
992e58923a
Merge pull request #10588 from excitoon-favorites/fixmutations
...
Fixed handling condition variable for synchronous mutations
2020-05-10 03:20:41 +03:00
alexey-milovidov
63c4a7661f
Merge pull request #10715 from CurtizJ/pk-function
...
Fix usage of primary key wrapped into a function.
2020-05-10 02:08:59 +03:00
Gleb Novikov
390b39b272
VolumePtr instead of DiskPtr in MergeTreeData*
2020-05-10 00:24:15 +03:00
Dmitry
0286b60ed6
return multiple blocks
2020-05-08 22:46:52 +03:00
Ivan
85d783c247
Poco contrib refactoring ( #10396 )
...
* Remove config_common.h
* Refactor libcpuid contrib
* Remove support for libcpuinfo
* Define USE_CPUID in Arcadia
* Refactor Poco libraries
2020-05-08 17:11:19 +03:00
Dmitry
e7b747b0b7
limit fixes + func(primary_key) group by works
2020-05-08 16:13:50 +03:00
Vladimir Chebotarev
28631f461e
Fixed handling of condition variable for synchronous mutations.
2020-05-08 12:01:06 +03:00
Nikolai Kochetov
c22f7a0864
Try fix header for GenerateRandom.
2020-05-07 17:14:56 +03:00
Vitaliy Zakaznikov
90e52e7fea
Adding support for ALTER RENAME COLUMN query to Distributed table engine.
2020-05-07 14:54:35 +02:00
Anton Popov
cbbd8e521c
fix usage of primary key wrapped into a function with 'FINAL' modifier and 'ORDER BY' optimization
2020-05-07 01:27:35 +03:00
Anton Popov
4a396090f8
fix build
2020-05-07 01:24:00 +03:00
alexey-milovidov
4df7dd8c2b
Merge pull request #10656 from azat/kafka-consumer-hang
...
Kafka cleanup
2020-05-07 00:20:31 +03:00
Anton Popov
387041a97e
Merge remote-tracking branch 'upstream/master' into polymorphic-parts
2020-05-06 19:22:07 +03:00
Anton Popov
4878c91d07
in-memory parts: better restore from wal
2020-05-06 14:57:38 +03:00
bobrovskij artemij
a2916c23a5
fixes/style
2020-05-06 02:42:44 +03:00
Dmitry
e98c23a8cf
read in order enabled
2020-05-05 17:35:23 +03:00
alexey-milovidov
114f09cfca
Merge pull request #10666 from NanoBjorn/refactor-volume
...
Volumes and storages refactoring
2020-05-05 16:25:26 +03:00
alexey-milovidov
c54f6d5a66
Merge pull request #10546 from kyprizel/master
...
Lexer, ast, checksum and column specs fuzzers added
2020-05-05 14:50:55 +03:00
Anton Popov
14e8592e47
in-memory parts: send checksums
2020-05-05 04:27:31 +03:00
alexey-milovidov
09756a036a
Merge pull request #10645 from ClickHouse/check-suspicious-codecs
...
Check for suspicious codecs #4966
2020-05-04 23:33:59 +03:00
Gleb Novikov
c637d99e07
Volumes and storages refactoring:
...
1. Moved Volume to separate file
2. Created IVolume interface and implemented current behaviour in implementation of new interface — VolumeJBOD
3. Replaced all old volume usages with new VolumeJBOD. Where it is unnecessary to have JBOD — left just IVolume.
4. Removed old Volume completely
5. Moved StoragePolicy to separated files
6. Moved DiskSelector to separated files
7. Removed DiskSpaceMonitor file
2020-05-04 23:15:38 +03:00
alesapin
d47d28d51f
Fix mutations assignment
2020-05-04 19:30:39 +03:00
Azat Khuzhin
61c5df5662
Drop claimed from the KafkaBlockInputStream
2020-05-04 17:23:09 +03:00
Azat Khuzhin
a10cfc3ae5
Pass stream_cancelled to the copyData as stub in StorageKafka
2020-05-04 17:23:09 +03:00
Azat Khuzhin
c69217e9f3
Force destrying of kafka buffers from the shutdown in StorageKafka
2020-05-04 17:23:09 +03:00
Azat Khuzhin
9e14db2091
Add missing kafka settings into docs
2020-05-04 17:23:05 +03:00
Alexey Milovidov
99c18c5a09
Check for suspicious codecs #4966
2020-05-04 03:11:49 +03:00
alexey-milovidov
884c2aa631
Merge pull request #10641 from ClickHouse/storage-buffer-nullptr-dereference
...
Fix nullptr dereference in StorageBuffer
2020-05-04 02:01:57 +03:00
Alexey Milovidov
a5bdc375ca
Fix Arcadia #10569
2020-05-04 00:36:11 +03:00
Alexey Milovidov
f8866af0c1
Fix nullptr dereference in StorageBuffer
2020-05-03 23:53:54 +03:00
Azat Khuzhin
6ffdd53b6a
Share auto-increment for first batch and tmp file in DistributedBlockOutputStream
2020-05-03 14:47:59 +03:00
Azat Khuzhin
53c470cab4
Fix directory monitor initialization from INSERT into Distributed
...
This also fixes hardlink code (when one file should be sent to multiple
servers, i.e. internal_replication == false) of writeToShard() with
distributed_storage_policy (i.e. when StorageDistributed::getPath() will
path to different filesystems).
Plus also cleanup DistributedBlockOutputStream::writeToShard() a little.
2020-05-03 14:47:51 +03:00
Azat Khuzhin
e97e1f06db
Do not schedule distributed send if there were no error
...
Since in this case it will be scheduled from the
DistributedBlockOutputStream with the
distributed_directory_monitor_max_sleep_time_ms, and this will overwrite
timer that was set by the DistributedBlockOutputStream, not good.
2020-05-03 14:46:44 +03:00
Azat Khuzhin
947b3942dd
Schedule distributed sends after the file has been written
2020-05-03 14:46:43 +03:00
Azat Khuzhin
0157fd5d93
Fix distributed send that are scheduled by INSERT query
...
Before this patch each INSERT query re-schedule distributed send, thus
each time it resets the timer, while this is not the expected behaviour,
since in on frequent INSERT distributed sends will not be triggered at
all.
Fix this by not resetting the timer.
2020-05-03 14:46:42 +03:00
Azat Khuzhin
6bb39dafc3
Drop decreated code (cond var and note for thread) in DirectoryMonitor
2020-05-03 14:46:41 +03:00
alexey-milovidov
db4c2352e1
Merge pull request #10569 from zhang2014/fix/ISSUES-10551
...
ISSUES-10551 add backward compatibility for create bloom filter index
2020-05-02 22:25:29 +03:00
alexey-milovidov
229f666dea
Merge pull request #10611 from azat/optimize_skip_unused_shards-LowCardinality
...
Fix optimize_skip_unused_shards with LowCardinality
2020-05-02 22:14:33 +03:00
alexey-milovidov
4f1b115e76
Merge pull request #10610 from azat/optimize_skip_unused_shards-fixes
...
Fix logging for optimize_skip_unused_shards
2020-05-02 22:13:01 +03:00
tavplubix
a073cd6c79
Fix segfault in StorageBuffer when exception on server startup ( #10609 )
...
* fix segfault in StorageBuffer when exception on server startup
* Trigger CI
Co-authored-by: alexey-milovidov <milovidov@yandex-team.ru>
2020-05-02 19:54:20 +03:00
Alexey Milovidov
81adcc9058
Remove obsolete records from system.build_options
2020-05-02 17:00:03 +03:00
alexey-milovidov
404452bad3
Update MergeTreeIndices.cpp
2020-05-01 21:40:56 +03:00
alesapin
4d8660f270
Remove obsolete comment
2020-05-01 13:05:37 +03:00
Azat Khuzhin
63d8ab8f03
Make createSelector() static (in storage) and const (in stream)
2020-05-01 11:31:05 +03:00
Azat Khuzhin
f22ba15b4a
Reduce copy-paste of DistributedBlockOutputStream::createSelector
...
This will make it less error prone.
2020-05-01 02:59:40 +03:00
Azat Khuzhin
cdd7013438
Drop superfluous "Skipping irrelevant shards" messages
...
Before this patch it printed 3 times:
- from StorageDistributed::getProcessingStageImpl()
- from StorageDistributed::read()
- from StorageDistributed::getProcessingStageImpl() (from StorageDistributed::read() -> getSampleBlock())
(But this should be optimized)
2020-05-01 02:56:13 +03:00
Azat Khuzhin
c648c300bf
Fix optimize_skip_unused_shards with LowCardinality
2020-05-01 02:39:58 +03:00
Azat Khuzhin
4cbe625567
Fix shard numbers output in logs (full cluster had been printed over optimized)
2020-05-01 02:13:07 +03:00
Anton Popov
aa723d245f
Merge remote-tracking branch 'upstream/master' into polymorphic-parts
2020-04-30 18:27:39 +03:00
Nikolai Kochetov
19dadb8c2d
Add parallel final.
2020-04-30 12:59:08 +03:00
alesapin
15e8f37839
Merge pull request #10531 from CurtizJ/polymorphic-parts-2
...
Fix index corruption in merges with compact parts.
2020-04-30 12:15:25 +03:00
alesapin
5e2afad549
Merge pull request #10477 from ClickHouse/refactor_istorage
...
Remove getColumn and hasColumn from IStorage, better virtuals.
2020-04-30 10:42:52 +03:00
Anton Popov
6ed3092c8a
make fillIndexGranularity less complicated
2020-04-30 00:57:58 +03:00
Anton Popov
42997bce86
im-memory parts: replication
2020-04-29 20:14:49 +03:00
alesapin
69fdf2a6a3
Review fixes and better test
2020-04-29 15:15:23 +03:00
zhang2014
8ac709b5d3
ISSUES-10551 add backward compatibility for create bloom filter index
2020-04-29 11:57:28 +08:00
Azat Khuzhin
038235684d
Add optimize_distributed_group_by_sharding_key and disable it by default
...
I know at least one way to fool that optimization, by using as sharding
key something like `if(col1>0, col1, col2)` (although this is not common
sharding key I would say, but can be useful if this will work
correctly), so let's disable it by default.
2020-04-29 00:09:25 +03:00
robot-clickhouse
de4e88ff97
Auto version update to [20.5.1.1] [54435]
2020-04-28 20:12:16 +03:00
bobrovskij artemij
0cc3d780b3
Support write for XDBCStorage
2020-04-28 14:03:24 +03:00
alesapin
f981649213
Fix pushing to views stream and refactor virtuals
2020-04-28 13:38:57 +03:00
bobrovskij artemij
1bcd077fbf
Support write for XDBCStorage
2020-04-28 03:56:44 +03:00
Eldar Zaitov
670ed4bf1b
lexer, ast, checksum and column specs fuzzers added
2020-04-28 02:12:18 +03:00
Anton Popov
032a0aa282
fix clang-tidy
2020-04-27 21:12:17 +03:00
alesapin
7c2f4d121a
Fix func
2020-04-27 20:48:53 +03:00
alesapin
4badd0fd28
Better code
2020-04-27 20:46:51 +03:00
alesapin
228dbf475e
Finalize mutations in background ( #10526 )
2020-04-27 19:19:04 +03:00
alesapin
01db4877f6
Fix style check
2020-04-27 18:44:33 +03:00
alesapin
c24ab563d7
Fix several wrong usages
2020-04-27 18:38:35 +03:00
alesapin
b0c5c1d685
Fix style
2020-04-27 18:21:37 +03:00
alesapin
6cfe0f7046
Fix after refactoring
2020-04-27 18:20:03 +03:00
alesapin
cefc58e77c
Fix style
2020-04-27 18:17:08 +03:00
alesapin
5c6316afbc
Fix bug
2020-04-27 18:10:50 +03:00
alesapin
4c1ac83112
Fix in IStorage
2020-04-27 17:44:32 +03:00
alesapin
e85b50c911
Revert "Strange fix, how it was possible earlier?"
...
This reverts commit 8d20644c99
.
2020-04-27 17:17:12 +03:00
alesapin
8d20644c99
Strange fix, how it was possible earlier?
2020-04-27 17:12:54 +03:00
alesapin
18c550df15
Better virtuals logic
2020-04-27 16:55:30 +03:00
Anton Popov
bee343dae1
fix writing of index in compact parts
2020-04-27 16:36:50 +03:00
alesapin
2829774105
Merge branch 'master' into refactor_istorage
2020-04-27 15:34:21 +03:00
Azat Khuzhin
20b4eed9a1
Disable GROUP BY sharding_key optimization for WITH ROLLUP/CUBE/TOTALS
2020-04-27 01:30:54 +03:00
Dmitry
d9ac0e8fef
Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization
2020-04-26 14:44:06 +03:00
alexey-milovidov
c9334d3fde
Merge pull request #10491 from azat/dist-shutdown
...
Proper Distributed shutdown (fixes UAF, avoid waiting for sending all batches)
2020-04-25 23:47:59 +03:00
Azat Khuzhin
747a74215f
Avoid processing all batches before Distributed shutdown
2020-04-25 02:03:27 +03:00
Azat Khuzhin
8ad6b37913
Proper StorageDistributed shutdown to avoid UAF in DistributedMonitor
...
StorageDistributed::shutdown() does not acquire the lock, that controls
access to the cluster_nodes_data, thus it does not synced with the
requireDirectoryMonitor(), hence some monitors can be untracked that
will trigger UAF (use-after-free) after DROP TABLE dist:
This is for the SIGSEGV from the DirectoryMonitor (with already destroyed storage):
0 0x0000000008e9f760 in std::__1::__cxx_atomic_load<int> (__order=std::__1::memory_order::seq_cst, __a=0x0)
1 std::__1::__atomic_base<int, false>::load (__m=std::__1::memory_order::seq_cst, this=0x0) <-- this is nullptr
2 std::__1::__atomic_base<int, false>::operator int (this=0x0)
3 DB::ActionBlocker::isCancelled (this=0x7f85e31c9bb8) at ../src/Common/ActionBlocker.h:18
4 DB::StorageDistributedDirectoryMonitor::run (this=0x7f85f93b2a00) at ../src/Storages/Distributed/DirectoryMonitor.cpp:140
2020-04-25 02:03:26 +03:00
tavplubix
7928f2eaa1
Merge pull request #7512 from ClickHouse/database_atomic
...
DatabaseAtomic
2020-04-24 22:28:18 +03:00
alesapin
793f4b734a
Remove obsolete comment
2020-04-24 13:31:03 +03:00
alesapin
b4425c2dc4
Remove getColumn and hasColumn methods from IStorage
2020-04-24 13:20:03 +03:00
alesapin
0c622370c5
Better
2020-04-24 12:21:38 +03:00
alesapin
dc2dd77d2e
Remove redundant overrides from IStorage
2020-04-24 12:20:09 +03:00
Alexander Tokmakov
f413061e0d
remove Context from some IDatabase methods
2020-04-23 19:51:48 +03:00
alesapin
5ae25b68e4
Remove redundant virtual from function
2020-04-23 18:18:33 +03:00
alesapin
b0a73589b0
Remove virtual columns as separate field from IStorage
2020-04-23 18:09:00 +03:00
Alexander Tokmakov
04d6b59ac0
Merge branch 'master' into database_atomic
2020-04-23 17:31:37 +03:00
Nikita Mikhaylov
3520755ab5
fix c++20 usage
2020-04-23 12:00:43 +03:00
alexey-milovidov
4f6bb00424
Merge pull request #10420 from ClickHouse/clang-tidy-8
...
Fixes for clang-tidy on clang-10
2020-04-23 00:33:41 +03:00
Nikita Mikhaylov
3cf2016867
Merge pull request #10188 from nikitamikhaylov/quorum_bug
...
insert_quorum vs drop partition or ttl
2020-04-23 00:11:57 +04:00
Alexey Milovidov
73dd78bac1
Merge branch 'master' into clang-tidy-8
2020-04-22 21:04:47 +03:00
Alexander Tokmakov
fefbbd37df
Merge branch 'master' into database_atomic
2020-04-22 17:02:30 +03:00
zhang2014
0a0555d4d7
ISSUES-9623 fix failure test case
2020-04-22 18:34:42 +08:00
zhang2014
bfb87f0eab
ISSUES-9623 check the number and type of arguments when creating BloomFilter index
2020-04-22 16:17:09 +08:00
Alexey Milovidov
03e17405cd
Checkpoint
2020-04-22 10:03:43 +03:00
Alexey Milovidov
603d132d45
Checkpoint
2020-04-22 09:34:20 +03:00
Alexey Milovidov
1e325a9fd9
Checkpoint
2020-04-22 09:22:14 +03:00
Alexey Milovidov
be22a4b94e
Checkpoint
2020-04-22 08:39:31 +03:00
Ivan
555488a458
Fix build in Arcadia ( #10413 )
2020-04-21 23:23:44 +03:00
Nikita Mikhaylov
2173bcf28e
Merge branch 'master' of github.com:ClickHouse/ClickHouse into quorum_bug
2020-04-21 14:35:06 +03:00
Alexey Milovidov
4cc0269de0
Fix flattening of Array(Tuple(...)) #10259
2020-04-21 02:44:51 +03:00
alexey-milovidov
8c2839d3c9
Merge pull request #10308 from ClickHouse/shared-context-lifetime
...
Shared context lifetime
2020-04-21 00:12:45 +03:00
alexey-milovidov
ab922d44d5
Merge pull request #10379 from ClickHouse/only_fetch_repliac
...
Add setting always_fetch_merged_part
2020-04-21 00:07:00 +03:00
alexey-milovidov
69b6f135e7
Merge pull request #10382 from excitoon-favorites/altercodec
...
Allowed to alter column in non-modifying data mode when the same type is specified
2020-04-20 22:54:53 +03:00
alexey-milovidov
f6de9c6ffd
Update AlterCommands.cpp
2020-04-20 22:54:08 +03:00
alexey-milovidov
1eca5088ec
Update AlterCommands.cpp
2020-04-20 22:53:19 +03:00
Vladimir Chebotarev
82985ff594
Allowed to alter column in non-modifying data mode when the same type is specified.
2020-04-20 14:15:06 +03:00
Alexander Tokmakov
b29bddac12
Merge branch 'master' into database_atomic
2020-04-20 14:09:09 +03:00
Nikita Mikhaylov
05206df88c
better
2020-04-20 13:56:59 +03:00
alesapin
1bc84ec8b4
Fix comments
2020-04-20 13:56:23 +03:00
alesapin
8767ea7efa
Add setting which restrict replica to merge parts by itself and always prefer dowloading from other replicas.
2020-04-20 13:53:29 +03:00
Nikolai Kochetov
052598534a
Try fix unit tests.
2020-04-20 12:42:56 +03:00
Alexey Milovidov
d7264b292d
Merge branch 'master' into sorting-processors
2020-04-20 09:29:41 +03:00
Alexey Milovidov
47e4d14ece
Whitespace
2020-04-20 09:13:04 +03:00
alexey-milovidov
1577d771df
Merge pull request #10341 from azat/auto_distributed_group_by_no_merge
...
Auto distributed_group_by_no_merge on GROUP BY sharding key
2020-04-20 08:30:27 +03:00
Alexey Milovidov
a3195d56ae
Fix translation
2020-04-20 07:19:50 +03:00
Alexey Milovidov
7023e096ec
Check for error code in part check #6269
2020-04-20 04:44:24 +03:00
Anton Popov
4069dbcc58
in-memory parts: add waiting for insert
2020-04-20 04:38:38 +03:00
Azat Khuzhin
e44d5c5749
Fix clang readability-container-size-empty warning in StorageDistributed::canForceGroupByNoMerge()
2020-04-20 01:12:22 +03:00
Alexey Milovidov
25f3184dbe
Merge branch 'master' into async-metric-memory-usage
2020-04-19 23:18:12 +03:00
Azat Khuzhin
be1dec9239
Fix distributed_group_by_no_merge optimization for Distributed-over-Distributed
2020-04-19 21:11:14 +03:00
Azat Khuzhin
93d049fe64
Allow auto distributed_group_by_no_merge for DISTINCT of sharding key
2020-04-19 18:53:37 +03:00
Azat Khuzhin
de4a723264
Auto distributed_group_by_no_merge on GROUP BY injective function of sharding key
2020-04-19 18:33:49 +03:00
Azat Khuzhin
5d11118cc9
Use thread pool (background_distributed_schedule_pool_size) for distributed sends
...
After #8756 the problem with 1 thread for each (distributed table, disk)
for distributed sends became even worse (since there can be multiple
disks), so use predefined thread pool for this tasks, that can be
controlled with background_distributed_schedule_pool_size knob.
2020-04-19 12:01:56 +03:00
Azat Khuzhin
673ddc9d77
Drop superfluous locking for atomic in DirectoryMonitor
2020-04-19 00:22:48 +03:00
alexey-milovidov
aac7cc7330
Merge pull request #10126 from Jokser/replicated-merge-tree-s3
...
Support ReplicatedMergeTree over S3
2020-04-18 16:13:04 +03:00
alexey-milovidov
46a5c75beb
Update MergeTreeData.h
2020-04-18 16:11:57 +03:00
alexey-milovidov
8cea45315f
Merge pull request #10133 from 4ertus2/joins
...
JOIN with Dictionary
2020-04-18 16:08:15 +03:00
alexey-milovidov
959e6cd032
Merge pull request #10221 from ClickHouse/remove-part-special-case
...
Support for one special case of removing incompletely written parts
2020-04-18 15:58:58 +03:00
alexey-milovidov
72dd453c3f
Merge pull request #10234 from vitlibar/show-columns-of-not-loaded-dictionary
...
Show information about not loaded dictionaries in system tables.
2020-04-18 15:06:08 +03:00
alexey-milovidov
17b6e0b3e5
Merge pull request #10315 from azat/buffer-flush-bg-pool
...
Use background thread pool for background buffer flushes
2020-04-18 15:04:35 +03:00
Dmitry
25cd4ce132
Merge branch 'master' of github.com:yandex/ClickHouse into group_by_in_order_optimization
2020-04-18 12:56:34 +03:00
Vitaly Baranov
d62345bbaa
Show information about not loaded dictionaries in system.columns, system.tables
...
and in "SHOW TABLES" executed in any database with the "Dictionary" engine.
2020-04-18 12:50:54 +03:00
Anton Popov
391f7c34be
in memory parts: basic read/write
2020-04-17 20:30:46 +03:00
Nikolai Kochetov
84faa9af26
Merge branch 'master' into shared-context-lifetime
2020-04-17 19:13:13 +03:00
Anton Popov
ee4eb97c3f
in-memory parts: preparation
2020-04-17 15:15:20 +03:00
Anton Popov
9a2855fae7
in-memory parts: preparation
2020-04-17 15:15:20 +03:00
Anton Popov
f7b7b5eb74
remove unused flags
2020-04-17 14:59:10 +03:00
Nikolai Kochetov
d51a9c551b
Remove shared_ptr to SharedContext from Context.
2020-04-17 12:47:40 +03:00
Alexey Milovidov
fdc5688d2d
Added memory usage to AsynchronousMetrics
2020-04-17 07:09:41 +03:00
Alexey Milovidov
fb095ad787
Merge branch 'master' into remove-part-special-case
2020-04-17 06:14:15 +03:00
Alexey Milovidov
b16ee538ab
Merge branch 'master' into sorting-processors
2020-04-17 05:31:55 +03:00
alexey-milovidov
17e7d4d88a
Merge pull request #10307 from abyss7/arcadia-4
...
Changes for auto-sync with Arcadia
2020-04-17 05:08:34 +03:00
Nikita Mikhaylov
6b58998a36
better
2020-04-16 22:57:39 +03:00
Nikita Mikhaylov
c153cc8fe5
fixed :)
2020-04-16 22:54:11 +03:00
Nikita Mikhaylov
9a80eb6e47
Merge branch 'master' of github.com:ClickHouse/ClickHouse into quorum_bug
2020-04-16 21:47:34 +03:00
Nikita Mikhaylov
85fbf413c1
server crashes, just to save
2020-04-16 21:47:20 +03:00
Azat Khuzhin
a9b1b36907
Use separate pool for buffer flushes (background_buffer_flush_schedule_pool_size)
2020-04-16 20:14:28 +03:00
Artem Zuikov
47cb670213
Merge branch 'master' into joins
2020-04-16 19:06:13 +03:00
Alexander Tokmakov
605f3b2119
fix DROP vs OPTIMIZE race in ReplicatedMergeTree
2020-04-16 18:30:18 +03:00
Ivan Lezhankin
e230632645
Changes required for auto-sync with Arcadia
2020-04-16 15:31:57 +03:00
Alexey Milovidov
cdeda4ab91
Fix usage of max_parser_depth setting; remove harmful default function arguments
2020-04-16 04:06:10 +03:00
Alexey Milovidov
f704c465a7
Make aware of one special case of imcompletely written parts #9940
2020-04-16 00:52:21 +03:00
Nikolai Kochetov
153f795ebe
Merge branch 'master' into sorting-processors
2020-04-15 12:07:05 +03:00
Alexey Milovidov
8ad04d4fec
Remove useless code
2020-04-15 00:05:45 +03:00
Nikolai Kochetov
12f4cfb2c7
Use processors for final.
2020-04-14 13:04:49 +03:00
Nikolai Kochetov
434a13a8bd
Move algorithm to separate files.
2020-04-14 12:21:24 +03:00
alexey-milovidov
9de981d8d3
Merge pull request #10052 from Vxider/mv_parallel_insert
...
Enable parallel INSERT for materialized view
2020-04-14 01:30:44 +03:00
alexey-milovidov
2219f05139
Merge pull request #10235 from ClickHouse/fix_range_hashed_ddl_dictionaries
...
Fix 'Cannot add column' in DDL dictionary
2020-04-14 01:28:24 +03:00
Nikita Mikhaylov
89f80a6353
Merge branch 'master' into quorum_bug
2020-04-13 23:25:55 +04:00
Alexander Tokmakov
b7d4bccc77
fix build
2020-04-13 22:02:13 +03:00
Artem Zuikov
6106b2bfc7
Merge branch 'master' into joins
2020-04-13 20:37:27 +03:00
Nikita Mikhaylov
68e82c11e0
fix build
2020-04-13 18:58:29 +03:00
Alexander Tokmakov
6c0d9723e0
Merge branch 'master' into database_atomic
2020-04-13 18:47:47 +03:00
Nikita Mikhaylov
441bb13d4a
better
2020-04-13 18:21:05 +03:00
alesapin
9cc7d0f06a
Fix 'Cannot add column' error while creating range_hashed dictionary using DDL queries
2020-04-13 17:34:01 +03:00
alexey-milovidov
396360cd90
Merge pull request #10209 from ClickHouse/akz/fix_segfault_in_system_tables
...
Fix N.P. segfault in StorageSystemTables for database engine "Lazy"
2020-04-13 16:33:27 +03:00
alexey-milovidov
eedb5a3e3d
Merge pull request #10218 from ClickHouse/fix-generate-random-date
...
Fixed "generateRandom" function for Date type
2020-04-13 16:26:08 +03:00
Nikita Mikhaylov
d5c055ab03
remove logs
2020-04-13 15:13:13 +03:00
Alexey Milovidov
8ad89a82d4
Support Nested types in "generateRandom"
2020-04-13 02:08:32 +03:00
Alexey Milovidov
860e9092f1
Fixed another inconsistency in partition names
2020-04-13 01:25:41 +03:00
Alexey Milovidov
4788eb3423
Make the assertion in code consistent with the real partition expression
2020-04-13 01:00:03 +03:00
Alexey Milovidov
3215257a90
Fixed "generateRandom" function for Date type #9973
2020-04-13 00:27:11 +03:00
Alexey Milovidov
983950d4ec
Convert types in Views
2020-04-13 00:07:11 +03:00
Alexander Tokmakov
20e6593f96
disable by default
2020-04-12 21:52:59 +03:00
Alexander Kazakov
2eb2e4cf41
Added proper nullptr check
2020-04-12 20:17:41 +03:00
Alexander Tokmakov
5e6d4b9449
Merge branch 'master' into database_atomic
2020-04-12 16:35:44 +03:00
alexey-milovidov
b888c867b3
Merge pull request #10026 from CurtizJ/speedup-index
...
Improve performance of index analysis with monotonic functions [2].
2020-04-12 06:37:26 +03:00
alexey-milovidov
78316f027a
Merge pull request #10195 from ClickHouse/fix-array-join-prewhere
...
Fix move-to-prewhere optimization in presense of arrayJoin functions.
2020-04-12 03:53:55 +03:00
alexey-milovidov
f5fc3b1e71
Merge pull request #10085 from achimbab/transform_null_in
...
transform_null_in option to test NULL values at the IN-Operator.
2020-04-12 02:01:54 +03:00
Alexey Milovidov
cf9f00644e
Fix the issue with arrayJoin and PREWHERE optimization #10092
2020-04-12 01:13:06 +03:00
Alexey Milovidov
121bf7b8c2
Whitespace #9968
2020-04-12 00:37:19 +03:00
alexey-milovidov
f472535f54
Merge pull request #9968 from Enmk/SIMD_tokenization
...
Splitting string into Alpha-Num tokens with SIMD intrinsics.
2020-04-12 00:33:29 +03:00
alexey-milovidov
00d8e7eefb
Merge branch 'master' into transform_null_in
2020-04-11 23:15:54 +03:00
alexey-milovidov
cd979d7997
Merge pull request #10130 from CurtizJ/polymorphic-parts
...
Fix some kinds of alters with compact parts
2020-04-11 23:02:48 +03:00
Vitaly Baranov
18fbd968ba
Merge pull request #10165 from azat/drop-dictionary-as-table
...
Do not break DROP DICTIONARY with DROP TABLE
2020-04-11 14:49:41 +03:00
Nikita Mikhaylov
a8d72d01c3
mvp fix
2020-04-11 00:29:54 +03:00
Azat Khuzhin
5b3c635200
Do not break DROP DICTIONARY after DROP TABLE executed on dictionary
2020-04-10 21:10:32 +03:00
Alexey Milovidov
39bbc1071b
Fix typo
2020-04-10 20:23:51 +03:00
Alexander Tokmakov
033d7f9b32
Merge branch 'master' into database_atomic
2020-04-10 17:12:09 +03:00
Anton Popov
d018977f4b
fix 'ALTER CLEAR INDEX/COLUMN' queries with compact parts
2020-04-10 16:36:51 +03:00
Nikolai Kochetov
978576d0c5
Move Graphite params to separate file.
2020-04-10 12:25:52 +03:00
Nikolai Kochetov
71c72a75d7
Move Graphite params to separate file.
2020-04-10 12:24:16 +03:00
Nikolai Kochetov
868f7e9aea
Move Graphite params to separate file.
2020-04-10 12:16:23 +03:00
Nikolai Kochetov
1b6d80bfae
Merge branch 'master' into sorting-processors
2020-04-10 12:07:21 +03:00
Nikolai Kochetov
d3acce8afa
Fix build.
2020-04-10 12:04:28 +03:00
Alexander Kazakov
497df3086f
Merge branch 'master' into timed_rwlock
...
Change-Id: I620bfde2121ff013773b001d514b40b1e796a58b
2020-04-10 11:38:20 +03:00
philip.han
7fa5afecb4
Support transform_null_in option for StorageSet
2020-04-10 14:42:36 +09:00
Alexander Tokmakov
50decc755d
fix rename materialized view
2020-04-10 04:35:37 +03:00
Alexander Kazakov
0accd2908c
Fix up styler's grudge
2020-04-09 23:11:20 +03:00
Alexander Kazakov
26dd6140b2
Added new config settings to control timeouts
...
* "lock_acquire_timeout" controls for how long a query will continue to
acquire each lock on its argument tables
* "lock_acquire_timeout_for_background_operations" is a per-table
setting for storages of *MergeTree family
2020-04-09 21:10:27 +03:00
Anton Popov
76cf9b7f03
Merge remote-tracking branch 'upstream/master' into polymorphic-parts
2020-04-09 20:16:45 +03:00
Vxider
a8cd174fc4
merged with master
2020-04-09 22:34:02 +08:00
Artem Zuikov
9f0db4dfef
Merge branch 'master' into joins
2020-04-09 11:53:18 +03:00
philip.han
3149f75430
Replace a reference for Context with a copied bool value.
2020-04-09 17:27:55 +09:00
alexey-milovidov
6ff4c3aa16
Merge pull request #10135 from azat/distributed-insert-converting
...
Convert blocks if structure does not match on INSERT into Distributed()
2020-04-09 05:51:36 +03:00
Alexander Tokmakov
140cd88c20
fixes
2020-04-09 02:59:39 +03:00
Alexey Milovidov
540e9f7d0d
Fix logged number of inserted rows into ReplicatedMergeTree
2020-04-09 01:58:15 +03:00
Azat Khuzhin
6d85207bfb
Convert blocks if structure does not match on INSERT into Distributed()
...
Follow-up for: #10105
2020-04-08 23:46:01 +03:00
alexey-milovidov
c389fee7e7
Update StorageReplicatedMergeTree.cpp
2020-04-08 22:48:01 +03:00
Alexander Tokmakov
dd1590830b
Merge branch 'master' into database_atomic
2020-04-08 22:00:46 +03:00
Artem Zuikov
8d6f641796
join over dictionary concept
2020-04-08 21:59:52 +03:00
Anton Popov
c8c4dc8104
fix 'ALTER MODIFY COLUMN' with compact parts
2020-04-08 19:20:52 +03:00
Pavel Kovalenko
89fe81ed62
Integration test for ReplicatedMergeTree over S3 fixes.
2020-04-08 14:56:31 +03:00
Pavel Kovalenko
bc349a563a
Merge branch 'master' into replicated-merge-tree-s3
2020-04-08 13:53:30 +03:00
alesapin
ded306f016
Fix adaptive granularity compatibility
2020-04-08 12:51:04 +03:00
Pavel Kovalenko
5b2b8d38fa
Download part trough disk interface.
2020-04-08 11:41:13 +03:00
alexey-milovidov
a46a61c970
Update KeyCondition.h
2020-04-08 05:56:25 +03:00
alexey-milovidov
a42d875a68
Update KeyCondition.h
2020-04-08 05:55:39 +03:00
alexey-milovidov
723a1f41e2
Update KeyCondition.h
2020-04-08 05:55:22 +03:00
alexey-milovidov
94a621060d
Update KeyCondition.h
2020-04-08 05:55:03 +03:00
alexey-milovidov
a6194364ea
Update MergeTreeDataSelectExecutor.cpp
2020-04-08 05:54:08 +03:00
alexey-milovidov
6d80ab1eed
Merge pull request #9811 from vitlibar/RBAC-8
...
RBAC-8
2020-04-08 05:47:55 +03:00
alexey-milovidov
dd333460d6
Merge pull request #10068 from ClickHouse/fix_check_table_with_index
...
Fix bug with uncompressed checksums in CHECK TABLE query
2020-04-08 05:37:18 +03:00
alexey-milovidov
dad892e9d4
Merge pull request #10105 from azat/distributed-insert-types-differs
...
Fix SIGSEGV on INSERT into Distributed on different struct with underlying
2020-04-08 05:36:02 +03:00
Anton Popov
cbdc3ef214
Merge remote-tracking branch 'upstream/master' into speedup-index
2020-04-08 04:15:48 +03:00
Alexander Tokmakov
135197aa75
fixes
2020-04-08 04:02:00 +03:00
alexey-milovidov
09a397a68f
Merge pull request #9997 from azat/dist-on-dist-fixes
...
Fix Distributed-over-Distributed with one only shard in nested table
2020-04-08 03:45:29 +03:00
alexey-milovidov
ebe9ae4fab
Update StorageMerge.cpp
2020-04-08 03:45:11 +03:00
alexey-milovidov
1b704425b6
Update StorageBuffer.cpp
2020-04-08 03:42:47 +03:00
Azat Khuzhin
b2fa9d8750
Fix SIGSEGV on INSERT into Distributed on different struct with underlying
2020-04-08 02:35:31 +03:00
alexey-milovidov
7bef5a6edb
Update checkDataPart.cpp
2020-04-08 02:13:53 +03:00
Vitaly Baranov
e573549945
Rework access rights for table functions.
2020-04-07 23:31:59 +03:00
Vitaly Baranov
423fa5087a
Add SHOW_USERS(SHOW ROLES, etc.) privileges.
2020-04-07 23:20:38 +03:00
alexey-milovidov
ead277b717
Update StorageReplicatedMergeTree.cpp
2020-04-07 20:23:26 +03:00
alexey-milovidov
2654f131cc
Update checkDataPart.cpp
2020-04-07 20:08:46 +03:00
alesapin
27777c1d2b
Better comment
2020-04-07 18:55:23 +03:00
Alexander Tokmakov
4c48b7dd80
better rename
2020-04-07 18:31:33 +03:00
alesapin
82a87bc0d2
Fix replicated tables startup when updating from old version
2020-04-07 18:28:29 +03:00
alesapin
0d7cff2b25
Merge branch 'master' into fix_check_table_with_index
2020-04-07 16:36:09 +03:00
alesapin
f1e0f15556
Merge pull request #9948 from ClickHouse/alter_rename_column
...
Alter rename column
2020-04-07 15:28:00 +03:00
Alexander Kazakov
621d26bcf7
Better timeout diagnostics message
2020-04-07 14:34:35 +03:00
philip.han
53b5dade5e
Implement transform_null_in
2020-04-07 20:08:13 +09:00
Artem Zuikov
8297683972
renames: AnalyzedJoin -> TableJoin, Join -> HashJoin ( #10065 )
2020-04-07 12:48:47 +03:00
Vasily Nemkov
ef07c6d06f
Merge remote-tracking branch 'upstream/master' into SIMD_tokenization
2020-04-07 11:25:52 +03:00
Alexander Kazakov
2e76e4d1ed
Made clang happy - fixed build
2020-04-07 10:15:59 +03:00
Alexander Kazakov
09ce548376
All locks in IStorage have timeouts now
2020-04-07 02:45:51 +03:00
Alexander Tokmakov
a2101c9b1c
better code
2020-04-07 02:22:44 +03:00
Vasily Nemkov
738e8a7ef8
Minor test refactoring
...
* using string literal for binary strings
* sorted includes
2020-04-06 21:41:11 +03:00
Vasily Nemkov
3d471556fb
Merge commit '73b0f8db8c327a1d63cc7ebcc56087a3f9866dae' into SIMD_tokenization
2020-04-06 20:05:02 +03:00
alesapin
c17fa34fa5
Fix bug with uncompressed checksums in CHECK TABLE query
2020-04-06 20:00:29 +03:00
Anton Popov
2dc1eddfab
fix FieldRef
2020-04-06 16:35:11 +03:00
Alexander Tokmakov
08bae4668d
Merge branch 'master' into database_atomic
2020-04-06 16:18:07 +03:00
Anton Popov
5ada959853
improve performance of index analysis with monotonic functions
2020-04-06 13:37:34 +03:00
Anton Popov
79024d73a2
improve performance of index analysis with monotonic functions
2020-04-06 13:37:34 +03:00
Vxider
2fb9138505
merged with master
2020-04-06 17:36:44 +08:00
alesapin
1cb072d58a
Merge branch 'master' into alter_rename_column
2020-04-06 11:40:27 +03:00
Alexey Milovidov
110eb599c1
Fix "check style" tool
2020-04-06 02:57:24 +03:00
Vxider
21532f6a6d
parallel insert for materialized view
2020-04-05 01:33:51 +08:00
Nikolai Kochetov
e23fda80aa
Merge with master
2020-04-04 19:02:17 +03:00
Azat Khuzhin
1232760f78
Fix Distributed-over-Distributed when nested table has only one shard
2020-04-04 13:47:35 +03:00
Azat Khuzhin
8d372b0be7
Call getQueryProcessingStage() once, since it is heavy for StorageDistributed
...
Refs: #9808
2020-04-04 13:47:34 +03:00
Ivan Lezhankin
06446b4f08
dbms/ → src/
2020-04-03 18:14:31 +03:00
Azat Khuzhin
f53c9a6b25
Fix "Block structure mismatch" for INSERT into Distributed
...
Add missing conversion (via ConvertingBlockInputStream) for INSERT into
remote nodes (for sync insert, async insert and async batch insert),
like for local nodes (in DistributedBlockOutputStream::writeBlockConverted).
This is required when the structure of the Distributed table differs
from the structure of the local table.
And also add a warning message, to highlight this in logs (since this
works slower).
Fixes : #19888
2021-02-02 10:16:41 +03:00