Commit Graph

124377 Commits

Author SHA1 Message Date
Antonio Andelic
cf33674738
Merge pull request #54385 from ClickHouse/fix-overflow-in-anova
Check for overflow before addition in `analysisOfVariance` function
2023-09-07 16:15:44 +02:00
serxa
a94ae9a7ab review fixes 2023-09-07 14:02:58 +00:00
Sergei Trifonov
958f102daa
Update src/IO/IResourceManager.h
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2023-09-07 15:58:31 +02:00
Sergei Trifonov
c9635ddacd
Update src/IO/ISchedulerNode.h
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2023-09-07 15:48:49 +02:00
robot-ch-test-poll2
f28ad1e136
Merge pull request #54368 from ClickHouse/fix_replacing_final_error
Fix logical error in vertical merge + replacing merge tree + optimize cleanup
2023-09-07 15:45:43 +02:00
robot-clickhouse
fd4ddc49f2
Merge pull request #54332 from rschu1ze/consolidate-tests-53149
Consolidate GCD codec tests (Follow up to #53149)
2023-09-07 15:29:22 +02:00
Robert Schulze
e761532d7a
Fix style 2023-09-07 15:00:06 +02:00
Joe Lynch
a5b508d6c5
Fix json in header 2023-09-07 14:59:33 +02:00
Alex Cheng
75dc6d9708 small fine-tune for using ColumnNullable pointer 2023-09-07 20:41:32 +08:00
yariks5s
5afca8a903 optimized toString() 2023-09-07 12:41:01 +00:00
Nikolay Degterinsky
e821cd4511 Fix formatting of column declaration 2023-09-07 12:01:07 +00:00
Robert Schulze
fc105aa442
Fix another test 2023-09-07 10:59:19 +00:00
Robert Schulze
cd3c121a62
Various fixups 2023-09-07 10:32:49 +00:00
Igor Nikonov
ce8e72e464
Merge pull request #54377 from ClickHouse/pr-distributed-tests-disable-plr
Disable prefer_localhost_replica in test for parallel replicas
2023-09-07 11:59:42 +02:00
Fern
25c06c9764
Update sampling-query-profiler.md
Adding a note to clarify that the sample query provided, in CH Cloud, might return empty information as it cycles through nodes of the cluster. You need to add clusterAllReplicas.
2023-09-07 10:47:42 +01:00
Alexander Sapin
05446d8377 Rename test 2023-09-07 11:46:28 +02:00
serxa
d11a9b4175 update spell dict 2023-09-07 08:51:35 +00:00
Han Fei
60b0df9245 Merge branch 'master' into regexptree-flags 2023-09-07 10:46:43 +02:00
Han Fei
fd76bc6412 try to fix build for freeBSD 2023-09-07 10:12:39 +02:00
Mikhail Koviazin
b067213c5a
aklomp-base64: fix the submodule name 2023-09-07 08:08:02 +00:00
Antonio Andelic
c795b9c32f Check for overflow before addition in anova function 2023-09-07 07:54:06 +00:00
Nikolay Degterinsky
14f77a00d4 Add test 2023-09-07 07:48:08 +00:00
Alexey Milovidov
d072100a00
Merge pull request #54375 from ClibMouse/ppc_abi_fix
Use abiv2 when generating OpenSSL .s files for powerpc64le
2023-09-07 10:17:22 +03:00
Igor Nikonov
2c85c28113 Cleanup 2023-09-07 07:15:42 +00:00
Han Fei
750b6219a5 Merge branch 'master' into test-libunwind-changes 2023-09-07 08:50:07 +02:00
Alexey Milovidov
1b30f91e7a
Merge pull request #51304 from ClickHouse/alter-table-add-comment
Add support for ALTER TABLE MODIFY COMMENT
2023-09-07 07:30:57 +03:00
Alexey Milovidov
ce8ab5c9dd
Update comment.md 2023-09-07 07:30:46 +03:00
Nikolay Degterinsky
d95c29227f Add STD alias to stddevPop function for MySQL compatibility 2023-09-07 03:46:27 +00:00
Nikolay Degterinsky
9918a85e78 Better 2023-09-07 02:35:21 +00:00
Nikolay Degterinsky
4b764f7b65 Fix segfault in arrayExists AST optimization 2023-09-07 02:10:14 +00:00
robot-clickhouse-ci-1
de59c52a51
Merge pull request #54331 from ClickHouse/fix-test-02841
Fixed flaky test `02841_parallel_replicas_summary`
2023-09-07 01:02:41 +02:00
Alexey Milovidov
539394b463
Merge pull request #54371 from Avogar/try-fix-async-query-sending-test
Enable hedged requests integration tests with tsan, use max_distributed_connections=1 to fix possible flakiness
2023-09-07 01:57:24 +03:00
Alexey Milovidov
dc127f2572
Merge pull request #54321 from azat/tests/01051_system_stack_trace
Increase timeout for system.stack_trace in 01051_system_stack_trace
2023-09-07 01:54:53 +03:00
robot-clickhouse
6404768aa4 Automatic style fix 2023-09-06 22:45:17 +00:00
Igor Nikonov
724e2ee4f7 Disable prefer_localhost_replica in tests 2023-09-06 22:27:41 +00:00
Boris Kuschel
3d4ab810b0
User correct target tripget triple 2023-09-06 13:45:35 -07:00
Boris Kuschel
91a0f5349c
Use abiv2 for generated asm 2023-09-06 13:40:59 -07:00
Robert Schulze
d372776de6
Fix more tests 2023-09-06 19:46:52 +00:00
serxa
2fe9a25954 Merge branch 'disks-and-io-sheduler' of github.com:ClickHouse/ClickHouse into disks-and-io-sheduler 2023-09-06 19:30:49 +00:00
serxa
77697211cd add docs for system.scheduler + small fix 2023-09-06 19:30:39 +00:00
Azat Khuzhin
33a681bb3f Fix 01051_system_stack_trace flakiness
This should fix possible flakiness [1] due to "Cannot obtain a stack trace for thread":

<details>

    $ zstd -cdq clickhouse-server.log.zst | grep -a 2a66d71f-1340-44c8-9d0f-0779b0218ae4
    2023.09.05 12:04:55.906701 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> executeQuery: (from [::1]:52620) (comment: 01051_system_stack_trace.sql) -- { echo }
    2023.09.05 12:04:55.907041 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> ContextAccess (default): Access granted: SELECT(query_id) ON system.stack_trace
    2023.09.05 12:04:58.858695 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 617
    2023.09.05 12:05:01.858508 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 812
    2023.09.05 12:05:04.858698 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> StorageSystemStackTrace: Cannot obtain a stack trace for thread 1707
    2023.09.05 12:05:05.194543 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> InterpreterSelectQuery: FetchColumns -> Complete
    2023.09.05 12:05:05.195960 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> Aggregator: Aggregation method: without_key
    2023.09.05 12:05:05.195997 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> AggregatingTransform: Aggregated. 0 to 1 rows (from 0.00 B) in 0.001220809 sec. (0.000 rows/sec., 0.00 B/sec.)
    2023.09.05 12:05:05.196008 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> Aggregator: Merging aggregated data
    2023.09.05 12:05:05.196020 [ 2835 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Trace> Aggregator: Statistics updated for key=5518594236514924310: new sum_of_sizes=1, median_size=1
    2023.09.05 12:05:05.197646 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> executeQuery: Read 1937 rows, 158.08 KiB in 9.291003 sec., 208.48125869725797 rows/sec., 17.01 KiB/sec.
    2023.09.05 12:05:05.197748 [ 617 ] {2a66d71f-1340-44c8-9d0f-0779b0218ae4} <Debug> TCPHandler: Processed in 9.291633143 sec.

</details>

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/5da7133c9421873c86bf7d5d71e699267fcefbff/stateless_tests__aarch64_.html

v0: increase timeout
v2: revert timeout change and add no-parallel
v3: add filter by thread_name to avoid sending signals to other threads and increase timeout
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-09-06 21:11:07 +02:00
robot-clickhouse
cd7c57f5d4 Automatic style fix 2023-09-06 19:00:05 +00:00
serxa
664efaf3fa add test 2023-09-06 18:35:40 +00:00
SmitaRKulkarni
f0146c0ff0
Increase retries for test_merge_tree_azure_blob_storage (#54069)
* Increase max_single_download_retries & max_single_read_retries for test_merge_tree_azure_blob_storage

* Updated logs to log exception leading to detaching part

* Updated to catch RequestFailedException azure exception as its the base exception

* Updated isRetryableExcepion to take std::exception_ptr as input

* Fixed style check fails

* Fix build issue & moved NetException & TimeoutException to retryable exceptions

* Fixed style check with catch
2023-09-06 19:57:59 +02:00
Kruglov Pavel
c3fb0ef5d4
Fix style 2023-09-06 19:42:14 +02:00
robot-ch-test-poll3
7f756ed613
Merge pull request #54354 from ClickHouse/parallel-replicas-cleanup
Parallel replicas: remove unused code
2023-09-06 19:38:14 +02:00
avogar
e44580fa47 Enable hedged requests integration tests with tsan, use max_distributed_connections=1 to fix possible flakiness 2023-09-06 17:15:23 +00:00
Alexander Sapin
4368c00052 Fix logical error in vertical merge + replacing merge tree + optimize cleanup 2023-09-06 18:43:56 +02:00
avogar
76acc77e66 Fix flaky test test_storage_azure_blob_storage/test.py::test_schema_inference_cache 2023-09-06 16:39:45 +00:00
johanngan
bcb058f999 Add case insensitive and dot-all modes to RegExpTree dictionary
The new per-dictionary settings control regex match semantics around
case sensitivity and the '.' wildcard with newlines. They must be set at
the dictionary level since they're applied to regex engines at
pattern-compile-time.

- regexp_dict_flag_case_insensitive: case insensitive matching
- regexp_dict_flag_dotall: '.' matches all characters including newlines

They correspond to HS_FLAG_CASELESS and HS_FLAG_DOTALL in Vectorscan
and case_sensitive and dot_nl in RE2. These are the most useful options
compatible with the internal behavior of RegExpTreeDictionary around
splitting up simple and complex patterns between Vectorscan and RE2.

The alternative is to use (?i) and/or (?s) for all patterns. However,
(?s) isn't handled properly by OptimizedRegularExpression::analyze().
And while (?i) is, it still causes the dictionary to treat the pattern
as "complex" for sequential scanning with RE2 rather than multi-matching
with Vectorscan, even though Vectorscan supports case insensitive
literal matching. Setting dictionary-wide flags is both more convenient,
and circumvents these problems.
2023-09-06 11:28:53 -05:00