Nikolai Kochetov
b92efed350
Merge pull request #34219 from ClickHouse/revert-34212-revert-33291-add-pool-to-s3-write-buffer
...
Revert "Revert "Add pool to WriteBufferFromS3""
2022-02-04 11:00:29 +03:00
alexey-milovidov
a089f9918c
Update ThreadPool.cpp
2022-02-04 03:54:33 +03:00
Alexey Milovidov
78eebd5c7c
Fix parallel loading of data parts
2022-02-04 02:29:46 +03:00
Alexey Milovidov
e20aec6866
Fix linkage
2022-02-04 01:44:43 +03:00
alexey-milovidov
665fdc9187
Merge pull request #31257 from FArthur-cmd/merge_15765
...
Merge #15765
2022-02-04 00:39:57 +03:00
Alexey Milovidov
4a83dbc514
Fix linkage
2022-02-04 00:26:44 +03:00
Alexey Milovidov
c426f11096
Maybe better
2022-02-04 00:20:16 +03:00
Alexey Milovidov
7c12f5f37a
Fix terribly low performance of LineAsString
format
2022-02-04 00:07:31 +03:00
Alexander Tokmakov
3e700e854d
cancel merges before acquiring lock for truncate
2022-02-03 23:44:53 +03:00
Alexander Tokmakov
897e94c16c
make restarting thread less bad
2022-02-03 23:29:24 +03:00
Maksim Kita
a01a74e415
Merge pull request #34287 from danlark1/master
...
Optimize quantilesExact{Low,High} to use nth_element instead of sort
2022-02-03 18:51:42 +01:00
Anton Popov
9b844c6b42
Merge pull request #32748 from CurtizJ/read-in-order-fixed-prefix
...
Support `optimize_read_in_order` if prefix of sorting key is already sorted
2022-02-03 18:17:08 +03:00
Danila Kutenin
c90b1f7794
Optimize quantilesExact{Low,High} to use nth_element instead of sort
2022-02-03 12:24:33 +00:00
Nikolai Kochetov
244bb984e6
Wait for pipeline to be destroyed in case of exception
2022-02-03 12:14:33 +00:00
Anton Popov
0755cfa584
minor fixes
2022-02-03 15:04:13 +03:00
Nikolai Kochetov
8f49f62a3c
Just a tiny fix.
2022-02-03 13:53:00 +03:00
mergify[bot]
587a090ab4
Merge branch 'master' into ttest_confidence_intervals
2022-02-03 10:36:31 +00:00
Maksim Kita
f4423937bd
Merge pull request #34275 from ClickHouse/fix-progress-bar
...
Fix progress bar width
2022-02-03 11:21:08 +01:00
Nikolai Kochetov
a2a9c10617
Merge pull request #34221 from ClickHouse/revert-34201-revert-34189-less-logging-for-remote_fs_execute_merges_on_single_replica_time_threshold
...
Revert "Revert "Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue""
2022-02-03 13:09:44 +03:00
alexey-milovidov
14811a357e
Merge pull request #34263 from azat/interserver-mode-fix
...
Fix current_user/current_address for interserver mode
2022-02-03 05:28:56 +03:00
alexey-milovidov
a6d1fcadcb
Merge pull request #34267 from CurtizJ/async-insert-in-client
...
Support async inserts in clickhouse-client for queries with inlined data
2022-02-03 05:14:47 +03:00
alexey-milovidov
768c71c1ac
Update ClientBase.cpp
2022-02-03 05:13:48 +03:00
Alexey Milovidov
f047a28ed8
Fix progress bar width
2022-02-03 04:48:52 +03:00
alexey-milovidov
4742cf3074
Update CertificateReloader.cpp
2022-02-03 03:03:46 +03:00
Maksim Kita
57d16bae04
Merge pull request #34243 from azat/use_skip_indexes_if_final
...
Disable data skipping indexes by default for queries with FINAL
2022-02-02 23:06:05 +01:00
Maksim Kita
bbf2174f2f
Merge pull request #34167 from azat/cmake-cleanup
...
Cmake leftovers cleanup
2022-02-02 22:55:14 +01:00
Maksim Kita
02c6cfba6a
Merge pull request #34225 from vitlibar/fix-checking-grants-for-show-grants
...
Fix checking grants for SHOW GRANTS
2022-02-02 22:51:51 +01:00
Anton Popov
5bb1b3ce77
support async inserts in clickhouse-client for queries with inlined data
2022-02-02 20:59:37 +03:00
Nikolai Kochetov
2003a96b58
Probably fix something
2022-02-02 17:48:41 +00:00
Nikolai Kochetov
ea044fc6b2
Merge branch 'master' into revert-34212-revert-33291-add-pool-to-s3-write-buffer
2022-02-02 19:40:41 +03:00
Nikolai Kochetov
1117e6095d
Update src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
...
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2022-02-02 18:34:05 +03:00
Vitaly Baranov
30557aebfb
Add helper class to cache the result of checking access.
2022-02-02 22:22:41 +07:00
kssenii
eae0bc7c04
add query id for delayed interactive
2022-02-02 18:20:59 +03:00
Azat Khuzhin
5472aef084
Fix current_user/current_address for interserver mode
...
Before this patch current_user/current_address will be preserved from
the previous query.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-02 17:44:19 +03:00
Nikolay Degterinsky
29c15f8c65
Merge pull request #33723 from FrankChen021/trace_id_order
...
Parse and store opentelemetry trace-id in big-endian order
2022-02-02 14:59:46 +03:00
tavplubix
7304fd654a
Merge pull request #34224 from CurtizJ/fix-query-metric
...
Fix metric `Query`
2022-02-02 13:39:07 +03:00
Azat Khuzhin
1d19851590
Disable data skipping indexes by default for queries with FINAL
...
This patch adds use_skip_indexes_if_final setting, that is OFF by
default. Since skipping data for queries with FINAL may produce
incorrect result.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-02 13:31:50 +03:00
Azat Khuzhin
15993cb13b
Add missing fmt::runtime() in MergeTreeBackgroundExecutor
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-02 11:37:53 +03:00
alesapin
47d538b52f
Merge pull request #34232 from ClickHouse/cancelled-merging-parts-error-message
...
Change severity of the "Cancelled merging parts" message in logs
2022-02-02 10:29:07 +03:00
achimbab
954a778a14
Merge branch 'ClickHouse:master' into ttest_confidence_intervals
2022-02-02 11:02:48 +09:00
alexey-milovidov
eeae89388b
Merge pull request #34230 from aaronstephenkatz/patch-1
...
adding # as a recognized start of single line comment
2022-02-02 03:03:01 +03:00
Sergei Trifonov
68bc456830
Merge pull request #34223 from azat/bump-fmt
...
Bump fmtlib from 7.0.0 to 8.1.1
2022-02-02 00:03:25 +03:00
Aaron Katz
0cac4b4a6e
adding # as a recognized start of single line comment
2022-02-01 09:40:17 -08:00
Nikolai Kochetov
dd81eff301
Fix tests.
2022-02-01 15:28:22 +00:00
Anton Popov
a4aa1f37ce
remove unused code
2022-02-01 17:44:23 +03:00
alexey-milovidov
cafb19d7fb
Merge pull request #34114 from amosbird/replxxwithlexer
...
Combining our lexer with replxx for better multiple line editing
2022-02-01 16:32:25 +03:00
alexey-milovidov
4236ae8835
Merge pull request #34192 from devcrafter/deduplication_token_7461_cleanup
...
Clean up: insert_deduplication_token setting for INSERT statement
2022-02-01 16:31:34 +03:00
alexey-milovidov
c3a68561dc
Merge pull request #34222 from ClickHouse/add-const-in-grpc-server
...
Add const to make clang-tidy happy
2022-02-01 16:25:15 +03:00
achimbab
b3f63965cc
Merge branch 'ClickHouse:master' into ttest_confidence_intervals
2022-02-01 22:24:56 +09:00
alexey-milovidov
2b1d1a9a6f
Merge pull request #34208 from ClickHouse/parse-date-time-best-effort-more-cases
...
More cases for `parseDateTimeBestEffort`
2022-02-01 16:22:52 +03:00
alexey-milovidov
798e0e8242
Merge pull request #34205 from ClickHouse/format-regexp-allow-cr-in-the-middle
...
Format `Regexp`: allow `\r` in the middle
2022-02-01 16:22:02 +03:00
Vitaly Baranov
1f81e43f1e
Fix checking grants for SHOW GRANTS.
2022-02-01 19:55:24 +07:00
Anton Popov
c28255850a
fix metric Query
2022-02-01 15:06:49 +03:00
Azat Khuzhin
d0d71180dd
Add fmt::runtime in gtest_log
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:44:47 +03:00
Vitaly Baranov
2ef2479ddc
Add const to make clang-tidy happy
2022-02-01 18:38:52 +07:00
Azat Khuzhin
de80014eb5
Use fmt::format over Poco::format in PostgreSQLHandler
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
5dfafd68a7
ReplicatedMergeTreeQueue: Fix fmt:: and reduce copy-paste of logging and out reason
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
5be76bc969
Use proper fmt-like logging
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
3b3635c6d5
Fix formatting error in logging messages
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
743096a883
Use proper fmt:: like Exception ctor in DataPartsExchange
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Azat Khuzhin
cf93732de9
DatabaseSQLite: fix fmt error in DatabaseSQLite::checkSQLiteTable()
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Azat Khuzhin
bedf208cbd
Use fmt::runtime() for LOG_* for non constexpr
...
Here is oneliner:
$ gg 'LOG_\(DEBUG\|TRACE\|INFO\|TEST\|WARNING\|ERROR\|FATAL\)([^,]*, [a-zA-Z]' -- :*.cpp :*.h | cut -d: -f1 | sort -u | xargs -r sed -E -i 's#(LOG_[A-Z]*)\(([^,]*), ([A-Za-z][^,)]*)#\1(\2, fmt::runtime(\3)#'
Note, that I tried to do this with coccinelle (tool for semantic
patchin), but it cannot parse C++:
$ cat fmt.cocci
@@
expression log;
expression var;
@@
-LOG_DEBUG(log, var)
+LOG_DEBUG(log, fmt::runtime(var))
I've also tried to use some macros/templates magic to do this implicitly
in logger_useful.h, but I failed to do so, and apparently it is not
possible for now.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: manual fixes
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Azat Khuzhin
a09bc1d72e
Add fmt::runtime() in Exception ctor
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Nikolai Kochetov
a6cc61bd14
Revert "Revert "Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue""
2022-02-01 14:17:46 +03:00
Amos Bird
e29c77f793
Fix link order issue of WriteBufferFromS3
...
(cherry picked from commit f22b09f4fc
)
2022-02-01 10:42:06 +00:00
Nikolai Kochetov
2a6eb593be
Revert "Revert "Add pool to WriteBufferFromS3""
2022-02-01 13:36:51 +03:00
alexey-milovidov
06477c2a7e
Update ReplicatedMergeTreeSink.cpp
2022-02-01 09:22:40 +01:00
Igor Nikonov
f4c0b64420
Clean up: insert_deduplication_token setting for INSERT statement
...
+ reduce number of allocations on replication merge tree path
+ bash test: move insert block settings into variable
Issue: ClickHouse#7461
2022-02-01 09:22:33 +01:00
Vitaly Baranov
bc6802f815
Merge pull request #34064 from andremarianiello/propagate-grpc-tracing-context
...
Propagate trace context from GRPC calls
2022-02-01 14:11:43 +07:00
alexey-milovidov
99392b5ca7
Merge pull request #13544 from amosbird/mdha
...
Multi-Disk auto-recovery.
2022-02-01 06:13:26 +03:00
Alexey Milovidov
7dbf0dede5
Change severity of the "Cancelled merging parts" message in logs
2022-02-01 05:55:07 +03:00
alexey-milovidov
095d9bfa43
Revert "Add pool to WriteBufferFromS3"
2022-02-01 05:49:40 +03:00
alexey-milovidov
c9571c6086
Merge pull request #34202 from ClickHouse/speedup-format-regexp
...
Improve performance of format Regexp
2022-02-01 05:46:52 +03:00
alexey-milovidov
cbfcd45be3
Revert "Add func tests run with s3"
2022-02-01 05:46:13 +03:00
alexey-milovidov
a2aa147ce0
Merge pull request #34153 from ClickHouse/add_func_tests_over_s3
...
Add func tests run with s3
2022-02-01 05:46:09 +03:00
mergify[bot]
e229487817
Merge branch 'master' into mdha
2022-02-01 01:22:16 +00:00
Alexey Milovidov
989a5ad35e
More cases for parseDateTimeBestEffort
2022-02-01 03:29:27 +03:00
Alexey Milovidov
e4e7169277
Remove some strange code
2022-02-01 02:52:36 +03:00
Alexey Milovidov
83136f3515
Allow \r in the middle of the line in format Regexp
2022-02-01 02:49:26 +03:00
Dmitry Novik
3a0ed0f8f5
Merge pull request #33324 from azat/buffer-different-structure
...
Simplify different block structure (i.e. after ALTER) support for Buffer
2022-02-01 02:19:49 +03:00
Alexey Milovidov
872d0a0fbe
Improve performance of format Regexp
2022-02-01 02:07:48 +03:00
alexey-milovidov
15e4fe5c78
Revert "Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue"
2022-02-01 01:51:39 +03:00
Amos Bird
ec7d367814
DiskLocal checker
...
Add DiskLocal checker so that ReplicatedMergeTree can recover data when some of its disks are broken.
2022-02-01 05:55:27 +08:00
alesapin
dd61d1c2de
Merge pull request #34172 from ClickHouse/fix_race_in_some_engines
...
Fix benign race condition for storage HDFS, S3, URL
2022-01-31 22:41:54 +03:00
alesapin
75d73d2785
Merge pull request #34139 from ClickHouse/fix_buf_s3_low_cardinality
...
Fix bug with bounded S3 reads and LowCardinality
2022-01-31 22:41:14 +03:00
Nikolai Kochetov
348d72266a
Merge pull request #34189 from ClickHouse/less-logging-for-remote_fs_execute_merges_on_single_replica_time_threshold
...
Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue
2022-01-31 21:39:04 +03:00
Nikolai Kochetov
a207cdf28f
Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue.
2022-01-31 17:53:28 +00:00
avogar
058ef356ac
Fix schema inference for table runction s3
2022-01-31 19:39:20 +03:00
Nikolai Kochetov
321fa4a9e8
Merge pull request #33291 from ClickHouse/add-pool-to-s3-write-buffer
...
Add pool to WriteBufferFromS3
2022-01-31 19:37:40 +03:00
tavplubix
d0ea72f878
Merge pull request #34005 from nicelulu/system_on_cluster
...
Supports all types of SYSTEM query ON CLUSTER clause.
2022-01-31 19:26:32 +03:00
alesapin
93c0700c4c
Fix typo
2022-01-31 16:46:58 +03:00
alesapin
056b9e335f
Fix comment
2022-01-31 16:39:42 +03:00
alesapin
31753afb7e
Fix cancel logic in parallel parsing
2022-01-31 16:38:15 +03:00
Azat Khuzhin
9b8ee0fabe
Cleanup cassandra contrib linking (linking with dictionraies is enough)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-31 16:01:11 +03:00
FArthur-cmd
3dc64f031a
correct code style
2022-01-31 12:21:22 +00:00
FArthur-cmd
891411a2be
add try catch to avoid errors on start
2022-01-31 12:13:28 +00:00
Maksim Kita
8513f20cfd
Merge pull request #34145 from kitaisreal/bitset-sort-performance-check
...
pdqsort performance check
2022-01-31 12:35:13 +01:00
alesapin
5230c59f05
Smaller scope
2022-01-31 14:03:06 +03:00
alesapin
cbf4790ea4
More clear error
2022-01-31 13:59:16 +03:00
alesapin
1adc7538fe
Fix benign race condition for storage HDFS, S3, URL
2022-01-31 13:50:28 +03:00