Commit Graph

49625 Commits

Author SHA1 Message Date
Azat Khuzhin
bba44d0f0e Add IF EXISTS for removing inner table of the materialized view
Instead of playing with has_inner_table flag, which looks a bit icky.
2020-10-12 21:46:07 +03:00
Azat Khuzhin
d16adddb41 Fix drop of materialized view with inner table in Atomic database
Materialized view drop the inner table (if any) drop the drop() method,
and this will lead to essure recursive drop() from the drop worker
thread, which will hang:

    3  std::__1::condition_variable::wait<> ()
    4  DB::DatabaseCatalog::waitTableFinallyDropped (this=0x7ffff7831500, uuid=...) at ../src/Interpreters/DatabaseCatalog.cpp:828
    5  DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7fff16ff88a0, table_id_=..., query=...) at ../src/Interpreters/InterpreterDropQuery.cpp:135
    6  DB::InterpreterDropQuery::execute (this=this@entry=0x7fff16ff88a0) at ../contrib/libcxx/include/string:1474
    7  DB::executeDropQuery (kind=kind@entry=DB::ASTDropQuery::Drop, global_context=..., target_table_id=...) at ../src/Storages/StorageMaterializedView.cpp:156
    8  DB::StorageMaterializedView::drop (this=0x7ffefc348f40) at ../src/Storages/StorageMaterializedView.cpp:169
    9  DB::DatabaseCatalog::dropTableFinally (this=this@entry=0x7ffff7831500, table=...) at ../src/Interpreters/DatabaseCatalog.cpp:775
    10 DB::DatabaseCatalog::dropTableDataTask (this=0x7ffff7831500) at ../src/Interpreters/DatabaseCatalog.cpp:745

Fix this by dropping the inner table just before scheduling job the the
drop worker thread.
2020-10-12 21:46:07 +03:00
Azat Khuzhin
91787e6a7e Add a test with recursive DROP TABLE (mv w/o explicit inner table) 2020-10-12 21:46:07 +03:00
Azat Khuzhin
ea12ca42c7 Add a stress test for DROP TABLE 2020-10-12 21:46:07 +03:00
Vitaly Baranov
b8019f2bc7 Fix deadlocks in RoleCache. 2020-10-12 21:40:05 +03:00
robot-clickhouse
a21b42f1f8 Update version_date.tsv after release 20.6.8.5 2020-10-12 19:37:10 +03:00
Denis Zhuravlev
f4b681fbcc test for bug from #14053 2020-10-12 13:07:22 -03:00
Mikhail Filimonov
87a8ba63f7
Few more CR fixes 2020-10-12 15:05:40 +02:00
tavplubix
748b75ab1b
Merge pull request #15767 from ClickHouse/fix_materialize_mysql_count_v2
Try fix select count() for MaterializeMySQL (another way)
2020-10-12 14:41:38 +03:00
Nikolai Kochetov
2a62a91af4
Merge pull request #15662 from ClickHouse/fix-15529
Fix read from Buffer table with empty nested table with different types.
2020-10-12 14:12:11 +03:00
alesapin
6732e5c217 Fix alter default validation 2020-10-12 14:02:35 +03:00
Amos Bird
47fcd8bffb
Fix some problems introduced by refactoring. 2020-10-12 17:58:09 +08:00
Amos Bird
d2dcfc3f0d
Refactor processors. 2020-10-12 17:30:05 +08:00
hexiaoting
39367be57a Add Support for OFFSET_FETCH_CLAUSE 2020-10-12 16:46:49 +08:00
Denis Glazachev
23460ddaab Trigger CI 2020-10-12 12:39:10 +04:00
alesapin
5b5dd4fb28 Fix order by desc after alter 2020-10-12 11:28:47 +03:00
alesapin
38c7132c0f
Merge pull request #15850 from ClickHouse/disable_rbac_tests_with_tsan
Disable some RBAC tests with thread sanitizer
2020-10-12 10:06:21 +03:00
alesapin
106040a720 Disable rbac tests with thread sanitizer 2020-10-12 10:04:46 +03:00
Mikhail Filimonov
7fb329713a
Avoid shadowing class member, set first_row flag after write 2020-10-12 07:52:38 +02:00
Mikhail Filimonov
f6b00f2cb6
After CR fixes 2020-10-12 07:52:09 +02:00
Mikhail Filimonov
c37a456c49
Refactoring WriteCallback->RowOutputFormatParams 2020-10-12 07:52:06 +02:00
Mikhail Filimonov
e17d4e1eeb
Tests and some docs 2020-10-12 07:51:46 +02:00
Mikhail Filimonov
6df42c580b
ProtobufSingle output format 2020-10-12 07:51:45 +02:00
Mikhail Filimonov
b602d18dd8
ProtobufSingle input format
Allows to read Single protobuf message at once (w/o length-delemeters).
2020-10-12 07:51:36 +02:00
Nikolai Kochetov
190fd88af9
Merge pull request #15785 from amosbird/e1
Code refactor.
2020-10-12 00:36:36 +03:00
Nikolai Kochetov
9b42bfdc36
Merge pull request #15817 from ClickHouse/new-block-for-functions-2
Use `ColumnsWithTypeAndName` instead of `Block` for function calls [part 2]
2020-10-12 00:32:58 +03:00
Nikolai Kochetov
23aec1f954 Fix build. 2020-10-11 22:44:20 +03:00
alexey-milovidov
760e2ca29c
Update formatReadableTimeDelta.cpp 2020-10-11 22:43:04 +03:00
Nikolai Kochetov
3a17c2a7ac Rename FunctionArguments to ColumnsWithTypeAndName 2020-10-11 22:20:20 +03:00
Azat Khuzhin
0f5ba33be8 Exclude zero-as-null-pointer-constant for libstdc++ under WEVERYTHING 2020-10-11 22:11:18 +03:00
Nikolai Kochetov
0df08dcb36 Rename columns() to size(). 2020-10-11 21:11:39 +03:00
alexey-milovidov
557002262f
Merge pull request #15828 from azat/unbundled-INTERFACE_COMPILE_DEFINITIONS
Fix INTERFACE_COMPILE_DEFINITIONS for IMPORTED targets
2020-10-11 19:28:18 +03:00
Alexey Milovidov
c23c7e3bba Check for executable bit on non-executable files 2020-10-11 19:26:11 +03:00
Alexey Milovidov
78c42d5dcd Remove executable bit from non-executable files 2020-10-11 19:21:29 +03:00
alexey-milovidov
4721c764ea
Merge pull request #15842 from amosbird/betterinput
Prettify clickhouse-client's query_id output
2020-10-11 19:19:38 +03:00
Amos Bird
e2643d881e
Prettify 2020-10-12 00:12:36 +08:00
Alexey Milovidov
b9c3b4c79e More tests 2020-10-11 19:00:50 +03:00
Alexey Milovidov
a171af157e Remove seven years old trash 2020-10-11 18:52:33 +03:00
Alexey Milovidov
4428ece196 Update reference 2020-10-11 18:32:34 +03:00
Alexey Milovidov
fa3b257579 Remove tabs from test 2020-10-11 18:32:03 +03:00
Alexey Milovidov
2b90472869 Remove executable bit from non-executable files 2020-10-11 18:30:20 +03:00
Alexey Milovidov
905bb859a5 Add performance test 2020-10-11 18:25:29 +03:00
Alexey Milovidov
c8ae1d097a Add comments 2020-10-11 18:24:20 +03:00
Alexey Milovidov
8a252ebef8 Merge remote-tracking branch 'origin/master' into filipecaixeta-master 2020-10-11 17:29:50 +03:00
alexey-milovidov
2e3046991b
Merge pull request #15757 from filimonov/fix-kafka-no-holes-flap
fix flap in no_holes_when_write_suffix_failed
2020-10-11 14:38:45 +03:00
alexey-milovidov
a8708338f2
Merge pull request #15809 from amosbird/c1
add print_query_id support for native client
2020-10-11 13:29:35 +03:00
alexey-milovidov
1aafa19146
Update Client.cpp 2020-10-11 13:27:09 +03:00
alexey-milovidov
f143eded67
Merge pull request #15711 from ClickHouse/zookeeper-dump-tree-reconnects
Add reconnects to zookeeper-dump-tree tool
2020-10-11 13:19:14 +03:00
alexey-milovidov
82fcc06987
Merge pull request #15819 from azat/Wzero-as-null-pointer-constant
Enable Wzero-as-null-pointer-constant only for libcxx
2020-10-11 13:17:00 +03:00
alexey-milovidov
10e9d14466
Merge pull request #15818 from ClickHouse/style-pragma-once
Check for #pragma once in headers
2020-10-11 13:14:09 +03:00