Commit Graph

13015 Commits

Author SHA1 Message Date
Alexey Milovidov
2581d88f0e Better error message: avoid confusion when column is named a [#CLICKHOUSE-3] 2018-08-28 23:39:18 +03:00
proller
18044995ba Fix includes 2018-08-28 22:36:27 +03:00
chertus
6a02b18b93 field visitors for UUID CLICKHOUSE-3249 2018-08-28 21:36:41 +03:00
Alexey Milovidov
f45afa37a8 Miscellaneous [#CLICKHOUSE-3] 2018-08-28 21:25:40 +03:00
Vadim
2bab5f941d
Update 00701_join_default_strictness.sql 2018-08-28 17:58:08 +03:00
Vadim
6a3d398a26
Update 00701_join_default_strictness.reference 2018-08-28 17:57:44 +03:00
Vadim
9a0802f5bd
fix documentation 2018-08-28 17:52:27 +03:00
Vadim
98abde8480
Update ExpressionAnalyzer.cpp 2018-08-28 17:41:15 +03:00
Vadim
096b5e6a9d
Update ExpressionAnalyzer.cpp 2018-08-28 17:40:07 +03:00
Vadim
564ddbf8d8
Update ExpressionAnalyzer.cpp 2018-08-28 17:33:57 +03:00
VadimPE
139f855230 CLICKHOUSE-3934 add tests 2018-08-28 17:26:12 +03:00
Vadim
a8c1199ad4
Merge branch 'master' into CLICKHOUSE-3934 2018-08-28 17:06:17 +03:00
chertus
86dd83d012 fix use of broken context in decimal arithm/comparison 2018-08-28 16:59:52 +03:00
VadimPE
398d38eead CLICKHOUSE-3934 add join_default_strictness 2018-08-28 16:57:31 +03:00
Amos Bird
4ae8721a82
ill formated #else breaks client history 2018-08-28 20:05:27 +08:00
proller
c219562b32 Better clickhouse-test-server 2018-08-28 14:57:35 +03:00
Amos Bird
8d6a26b8df Enable sse2 for CSV parsing.
Testing data

```
select 'aaaaaaaa,bbbbbbbb,cccccccc,dddddddd,eeeeeeee,ffffffff,gggg,hhh' from numbers(3000000) into outfile '/tmp/test.csv'
```

Testing command
```
echo "select count() from file('/tmp/test.csv', CSV, 'a String, b String, c String, d String, e String, f String, g String, h String') where not ignore(e)" | clickhouse-benchmark

```

Before
```
QPS: 1.317, RPS: 3949749.687, MiB/s: 478.380, result RPS: 1.317, result MiB/s: 0.000.
0.000%  0.704 sec.
10.000% 0.712 sec.
20.000% 0.718 sec.
30.000% 0.726 sec.
40.000% 0.739 sec.
50.000% 0.754 sec.
60.000% 0.770 sec.
70.000% 0.788 sec.
80.000% 0.798 sec.
90.000% 0.815 sec.
95.000% 0.826 sec.
99.000% 0.850 sec.
99.900% 0.857 sec.
99.990% 0.858 sec.
```

After
```
QPS: 1.533, RPS: 4598308.336, MiB/s: 556.932, result RPS: 1.533, result MiB/s: 0.000.
0.000%  0.626 sec.
10.000% 0.635 sec.
20.000% 0.639 sec.
30.000% 0.642 sec.
40.000% 0.643 sec.
50.000% 0.645 sec.
60.000% 0.649 sec.
70.000% 0.652 sec.
80.000% 0.658 sec.
90.000% 0.682 sec.
95.000% 0.710 sec.
99.000% 0.727 sec.
99.900% 0.733 sec.
99.990% 0.734 sec.
```
2018-08-28 19:46:11 +08:00
alexey-milovidov
9ff0edc203
Merge pull request #2971 from urykhy/zk-operation-timeout
Make ZK operation timeout configurable
2018-08-28 14:23:09 +03:00
Alexey Milovidov
3e216f055c Miscellaneous #2758 2018-08-28 03:44:42 +03:00
Alexey Milovidov
9a4b4fbccd Miscellaneous #2758 2018-08-28 03:23:52 +03:00
Alexey Milovidov
236c3872b8 Miscellaneous #2758 2018-08-28 03:23:38 +03:00
Alexey Milovidov
32286484cd Miscellaneous #2758 2018-08-28 03:22:32 +03:00
Alexey Milovidov
52379be265 Miscellaneous #2758 2018-08-28 03:21:02 +03:00
Alexey Milovidov
4f8d324fa7 Miscellaneous #2758 2018-08-28 03:18:32 +03:00
Alexey Milovidov
fa0ffcf8dc Miscellaneous #2758 2018-08-28 03:17:27 +03:00
Alexey Milovidov
2a4b4eefd6 Miscellaneous #2758 2018-08-28 03:10:05 +03:00
Alexey Milovidov
ea643eeff9 Miscellaneous #2758 2018-08-28 03:03:10 +03:00
Alexey Milovidov
7c777c48d7 Miscellaneous #2758 2018-08-28 03:01:03 +03:00
Alexey Milovidov
0a7e288d70 Miscellaneous #2758 2018-08-28 02:59:49 +03:00
Alexey Milovidov
bab6cd504d Miscellaneous #2758 2018-08-27 22:16:38 +03:00
Alexey Milovidov
24bd803c07 Whitespaces #2758 2018-08-27 22:06:32 +03:00
Alexey Milovidov
f5cc5ef877 Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into VadimPE-CLICKHOUSE-3847 2018-08-27 22:04:14 +03:00
proller
cc86cb503e clickhouse-test-server with temporary data dir 2018-08-27 21:32:50 +03:00
Yury Stankevich
f3024d2fba Make ZK operation timeout configurable 2018-08-27 20:26:19 +03:00
chertus
d6a85d9d63 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-27 20:17:26 +03:00
chertus
220909eb39 minor fix CLICKHOUSE-3765 2018-08-27 20:17:12 +03:00
alexey-milovidov
98148d914c
Merge pull request #2958 from blahgeek/skip-json-object
Skip object fields on json input
2018-08-27 20:07:32 +03:00
alexey-milovidov
95b2bcbc6b
Merge pull request #2970 from 4ertus2/decimal
Some more Decimal
2018-08-27 19:59:26 +03:00
alexey-milovidov
3328fb456a
Merge pull request #2966 from amosbird/nrvo
Get rid of useless std::move to get NRVO
2018-08-27 19:56:03 +03:00
chertus
9dbaa5f4a9 remove strange code CLICKHOUSE-3765 2018-08-27 19:46:42 +03:00
Vadim
2d8bffafa3
Update MergeTreeSettings.h 2018-08-27 19:38:54 +03:00
Vadim
4d9d80b271
Update MergeTreeSettings.h 2018-08-27 19:38:36 +03:00
alesapin
4ecf3ce8ef
Merge pull request #2969 from alesapin/master
CLICKHOUSE-3894: Fix Kafka test
2018-08-27 19:24:39 +03:00
VadimPE
418375aa1d Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into CLICKHOUSE-3847 2018-08-27 19:23:08 +03:00
VadimPE
70ebb6a47d CLICKHOUSE-3847 fix code-style 2018-08-27 19:22:39 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
alesapin
1f0f1ecad3 CLICKHOUSE-3894: Fix Kafka test 2018-08-27 19:15:39 +03:00
Vadim
64a27e592b
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 19:00:40 +03:00
VadimPE
4d198f2bfe CLICKHOUSE-3847 fix build 2018-08-27 18:54:07 +03:00
VadimPE
0281678c3e CLICKHOUSE-3847 fix code style 2018-08-27 18:44:51 +03:00
Alexey Milovidov
303cc7242f Addition to prev. revision #2956 2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030 Removed code with duplicate semantics [#CLICKHOUSE-2] 2018-08-27 18:01:33 +03:00
alexey-milovidov
7de0549879
Update ReadHelpers.h 2018-08-27 18:00:08 +03:00
alexey-milovidov
01f01b1ee1
Update ReadHelpers.cpp 2018-08-27 17:54:58 +03:00
alesapin
a2a623d228
Merge pull request #2967 from alesapin/master
Small fixes in testing framework
2018-08-27 17:53:56 +03:00
alesapin
716c8016d7 CLICKHOUSE-3894: Print stack trace 2018-08-27 17:45:37 +03:00
alesapin
06d091580d CLICKHOUSE-3894: Increase MySQL timeout and add logging 2018-08-27 17:43:59 +03:00
proller
3acce3bff9 Build fix (#2944)
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
VadimPE
a8974f8786 CLICKHOUSE-3847 add Coordinator 2018-08-27 16:51:22 +03:00
alesapin
3913a6ef4e
Merge pull request #2965 from alesapin/master
CLICKHOUSE-3894: Wait zookeeper before clickhouse start
2018-08-27 16:51:05 +03:00
alesapin
570343fdb3 CLICKHOUSE-3894: Wait zookeeper before clickhouse start 2018-08-27 16:42:39 +03:00
alexey-milovidov
806316511f
Merge pull request #2960 from zhang2014/fix/on_cluster_crash
ISSUES-2482 fix crash when on cluster
2018-08-27 16:25:26 +03:00
Vadim
be2d821669
Merge branch 'master' into CLICKHOUSE-3847 2018-08-27 15:26:41 +03:00
Alexey Milovidov
eb165a0616 Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916] 2018-08-27 15:19:29 +03:00
Vadim
c4e90d89f0
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 15:16:52 +03:00
VadimPE
22aa521884 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:14:48 +03:00
VadimPE
cf0a7c1529 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:09:22 +03:00
alesapin
d5dd32f4fe CLICKHOUSE-3894: Fix test_config_substs test 2018-08-27 14:40:01 +03:00
zhang2014
f8d7cf17a7 ISSUES-2482 fix crash when on cluster 2018-08-27 19:03:22 +08:00
BlahGeek
739119d355 skip object fields on json input 2018-08-27 12:01:47 +08:00
Alexey Milovidov
c193d15ef2 Merge branch 'master' into generalize-zookeeper 2018-08-26 03:32:15 +03:00
alexey-milovidov
f92bae33f8
Merge pull request #2949 from yandex/distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper
ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed.
2018-08-26 03:12:20 +03:00
Alexey Milovidov
2ce783e016 Merge branch 'read' of https://github.com/amosbird/ClickHouse into amosbird-read 2018-08-26 02:55:22 +03:00
alexey-milovidov
35806a4d27
Merge pull request #2955 from amosbird/varint
Fast path for varint read.
2018-08-26 02:47:04 +03:00
alexey-milovidov
00404a911c
Update VarInt.h 2018-08-26 02:46:18 +03:00
Amos Bird
a589230249 Faster path for varint read.
clickhouse-benchmark <<< 'select count() from s where not ignore(s);'

before this patch:

```

QPS: 0.732, RPS: 2346562049.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000.
0.000%  1.310 sec.
10.000% 1.321 sec.
20.000% 1.327 sec.
30.000% 1.337 sec.
40.000% 1.343 sec.
50.000% 1.359 sec.
60.000% 1.366 sec.
70.000% 1.381 sec.
80.000% 1.400 sec.
90.000% 1.434 sec.
95.000% 1.448 sec.
99.000% 1.489 sec.
99.900% 1.499 sec.
99.990% 1.500 sec.

```

after this patch:

```
QPS: 0.787, RPS: 2524560389.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000.
0.000%  1.228 sec.
10.000% 1.232 sec.
20.000% 1.235 sec.
30.000% 1.241 sec.
40.000% 1.246 sec.
50.000% 1.256 sec.
60.000% 1.265 sec.
70.000% 1.278 sec.
80.000% 1.296 sec.
90.000% 1.321 sec.
95.000% 1.354 sec.
99.000% 1.421 sec.
99.900% 1.453 sec.
99.990% 1.456 sec.
```

I also tried a SSE2 implementation and it's much slower (50%)
2018-08-26 02:23:26 +08:00
alexey-milovidov
732afd27cf
Merge pull request #2953 from yandex/max-block-size-in-system-tables-columns
Support for max_block_size in system.tables and system.columns tables
2018-08-25 20:36:54 +03:00
Amos Bird
9623e59870 Simplify read helpers.
Use similar APIs like https://en.cppreference.com/w/cpp/string/byte/strstr
2018-08-26 01:27:28 +08:00
Alexey Milovidov
0ef5b19436 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-25 19:50:14 +03:00
Alexey Milovidov
17818fa54f Merge branch 'Tezd-feature/suggestions' 2018-08-25 19:49:48 +03:00
Alexey Milovidov
aa936b09f9 Added check for max_block_size = 0 #2447 2018-08-25 19:32:44 +03:00
Alexey Milovidov
9c79c5f8ab Added test #2447 2018-08-25 19:26:55 +03:00
Alexey Milovidov
93b44fb17c Made suggest case sensitive again. Otherwise there is a glitch when you type SELECT DIS<TAB> #2447 2018-08-25 19:19:00 +03:00
Alexey Milovidov
068e50329e Support for max_block_size in system.tables and system.columns tables #2447 2018-08-25 19:07:48 +03:00
Alexey Milovidov
417cc1ab4d Additions #2447 2018-08-25 19:05:01 +03:00
Alexey Milovidov
24083e3088 Separate files #2447 2018-08-25 16:55:18 +03:00
Alexey Milovidov
9293882206 Allow to disable suggestion; check server revision #2447 2018-08-25 16:41:50 +03:00
Alexey Milovidov
32eb1a7942 Merge branch 'feature/suggestions' of https://github.com/Tezd/ClickHouse into Tezd-feature/suggestions 2018-08-25 16:15:30 +03:00
Amos Bird
5f03082af9 Make sure BufferBase is fully swapped. 2018-08-25 19:58:16 +08:00
alexey-milovidov
046137f9c5
Merge pull request #2946 from amosbird/locking
Better locking for StorageBuffer
2018-08-25 13:47:29 +03:00
Amos Bird
2602177525 Better locking for StorageBuffer 2018-08-25 13:52:06 +08:00
Alexey Milovidov
8cc3501c04 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 05:00:36 +03:00
Alexey Milovidov
3475ef5304 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:58:14 +03:00
Alexey Milovidov
4d343a441c Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:14:02 +03:00
Alexey Milovidov
01082d03d2 Adopted logic in ReplicatedMergeTreeBlockOutputStream #2949 2018-08-25 01:55:02 +03:00
Alexey Milovidov
cc56235ad9 Merge remote-tracking branch 'origin/master' into distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper 2018-08-25 01:53:58 +03:00
Alexey Milovidov
2530561086 ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed #2939 2018-08-25 01:50:20 +03:00
alexey-milovidov
7ba62c2e25
Merge pull request #2939 from yandex/fix-potential-data-loss-in-case-of-zk-errors
Fixed potential data loss in case of ZK errors [#CLICKHOUSE-3916]
2018-08-25 01:08:31 +03:00