Commit Graph

38709 Commits

Author SHA1 Message Date
Robert Schulze
02a2c73bae
Merge pull request #47607 from save-my-heart/inverted_index
checksum: do not check inverted index files
2023-03-16 21:34:17 +01:00
Alexander Tokmakov
d621b2c4ad fix intersecting parts, better fault injections 2023-03-16 21:28:07 +01:00
Igor Nikonov
34e9b07854 - remove debug logging
+ init columns method
2023-03-16 19:33:53 +00:00
alesapin
92eb6685c6 Fix lock check 2023-03-16 20:17:29 +01:00
Sema Checherinda
3c6deddd1d work with comments on PR 2023-03-16 19:55:58 +01:00
Alexey Milovidov
704cb54afe Merge branch 'master' of github.com:ClickHouse/ClickHouse into fuzzer-of-data-formats 2023-03-16 19:50:33 +01:00
Igor Nikonov
f7da3821b8 Make lambdas ordinary functions 2023-03-16 18:46:42 +00:00
robot-ch-test-poll
ff56d49ce2
Merge pull request #47647 from jorisgio/fix_quadratic_debug_code
fix typo in HashJoin insertion that enables debug code in release build #46726
2023-03-16 19:39:51 +01:00
Igor Nikonov
288cc0843a some polishing 2023-03-16 18:09:08 +00:00
Alexander Tokmakov
a72f0cae07
Merge pull request #46071 from arenadata/ADQM-639
Add support of arbitrary engines for temporary tables
2023-03-16 20:56:25 +03:00
Igor Nikonov
4904a9fb7a Create result columns as MutableColumns at the begining
Use IColumn* to manipulate columns on specific positions in result columns
2023-03-16 17:44:29 +00:00
serxa
3ad7194e31 add pool size metrics 2023-03-16 17:31:41 +00:00
Robert Schulze
eb206bbe25
Fix clang-tidy build 2023-03-16 16:08:24 +00:00
Azat Khuzhin
8495deb7e3 Remove unused removePartFromZooKeeper()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit dbdb46e906)
2023-03-16 16:43:23 +01:00
Alexander Tokmakov
8b8215f91a fix some other tests, add logs for further debugging 2023-03-16 16:40:08 +01:00
Kruglov Pavel
ffa8af2861
Merge pull request #47540 from Avogar/fix-bson-bug
Fix BSONEachRow parallel parsing when document size is invalid
2023-03-16 16:25:25 +01:00
Alexander Tokmakov
8e36f883d3 add 'strict' mode for sync replica, fix 00993 2023-03-16 16:04:42 +01:00
avogar
2cc47b5bb6 Allow reading/writing nested arrays in Protobuf with only root field name as column name 2023-03-16 14:43:37 +00:00
Joris Giovannangeli
6c8fc4cd11
fix hashjoin debug code condition 2023-03-16 14:06:37 +01:00
Kruglov Pavel
a3510a2ffe
Merge pull request #47271 from Avogar/codecs-better
Add optional parameters to some codecs, fix aborts in clickhouse-compressor with some codecs.
2023-03-16 12:20:23 +01:00
Robert Schulze
7d7052350c
Merge branch 'master' into rs/qc-cachebase 2023-03-16 10:42:17 +01:00
Igor Nikonov
3a3cb703d4
Merge pull request #47399 from ClickHouse/improve-remove-redundant-distinct
Remove distinct on top of MergingAggregatedStep
2023-03-16 10:36:32 +01:00
Maksim Kita
558aa6c164
Merge pull request #47583 from kitaisreal/merge-tree-explain-prewhere-and-row-policy
ReadFromMergeTree explain prewhere and row policy actions
2023-03-16 12:31:34 +03:00
Roman Vasin
46d683fbf6 Apply patch to fix grants hierarchy 2023-03-16 08:17:33 +00:00
robot-clickhouse-ci-1
1223b8959b
Merge pull request #47626 from ClickHouse/rs/follow-up-to-47614
Follow-up to #47614
2023-03-16 00:31:51 +01:00
Alexey Milovidov
92a5b81222 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fuzzer-of-data-formats 2023-03-15 23:59:16 +01:00
Igor Nikonov
b369366b19 Some refactoring
+ result_columns
+ move interpolate to method from lambda
2023-03-15 22:13:16 +00:00
alesapin
fc913649cf Check only for interactive moves 2023-03-15 22:51:53 +01:00
pufit
f4d9b4a888
Merge pull request #47086 from pkit/pkit/insert_http_body
use http request body in predefined http handlers
2023-03-15 17:41:05 -04:00
alesapin
ef7508469c Fix wait for zero-copy replication move during manual move 2023-03-15 22:29:24 +01:00
Sema Checherinda
67ac858a52 remove counters for threads, fix negative counters 2023-03-15 22:22:22 +01:00
Igor Nikonov
7d8e5533f3
Merge pull request #47385 from ClickHouse/fix-distinct-in-order-analyzer
Fix: apply reading in order for distinct
2023-03-15 21:48:33 +01:00
Maksim Kita
5329041479
Merge pull request #47539 from ClickHouse/interpolate-const-fix
Support constants in INTERPOLATE clause (new analyzer)
2023-03-15 22:06:49 +03:00
Robert Schulze
785ade7c39
Follow-up to #47614 2023-03-15 18:05:53 +00:00
Robert Schulze
1f9c84e747
Revert "Un-friend system view (no longer necessary)"
This reverts commit b2aa9324ac.
2023-03-15 16:53:01 +00:00
alesapin
8974ba1fad
Update ASTDeleteQuery.cpp
Remove format clause because we do it in ASTQueryWithOutput::formatImpl.
2023-03-15 17:37:26 +01:00
alesapin
e3dd7d79b0 Update src/Parsers/ASTDeleteQuery.cpp 2023-03-15 16:35:56 +01:00
Vladimir C
045960f1a1
Merge pull request #47108 from ClickHouse/vdimir/http_wait_end_of_query_settings 2023-03-15 15:31:12 +01:00
Maksim Kita
7b108c9788 Fixed tests 2023-03-15 15:21:49 +01:00
Maksim Kita
87f8138c55 Analyzer support row policy 2023-03-15 15:21:49 +01:00
Maksim Kita
6c2084052c Fixed tests 2023-03-15 15:21:49 +01:00
Maksim Kita
c102adb728 Analyzer added PREWHERE support 2023-03-15 15:21:49 +01:00
Alexander Tokmakov
6a653060ff
Merge pull request #47213 from azat/interserver-mode-v2
Reimplement interserver mode to avoid replay attacks
2023-03-15 16:26:50 +03:00
avogar
c4ac4c596f Fix comments 2023-03-15 13:17:13 +00:00
avogar
0005517cee Fix comments 2023-03-15 13:08:01 +00:00
Maksim Kita
4337a3161a
Merge pull request #47370 from ClickHouse/fix-grouping-for-grouping-sets
Fix GROUPING function initialization for grouping sets
2023-03-15 16:06:49 +03:00
save-my-heart
b7d9d721fb add test 2023-03-15 21:01:12 +08:00
Igor Nikonov
d69fb0c396 Merge remote-tracking branch 'origin/master' into improve-remove-redundant-distinct 2023-03-15 12:45:20 +00:00
robot-ch-test-poll1
43db7c59d9
Merge pull request #47260 from ClickHouse/vdimir/storage_join_insert_select_deadlock
Forbid insert select for the same StorageJoin
2023-03-15 12:52:29 +01:00
Alexey Milovidov
bb6b775884 Merge branch 'master' into fuzzer-of-data-formats 2023-03-15 12:42:00 +01:00
Alexey Milovidov
0631381161 Merge branch 'fix-bson-2' of github.com:Avogar/ClickHouse into fuzzer-of-data-formats 2023-03-15 12:41:54 +01:00
avogar
26e15b288b Check for duplicate column in BSONEachRow format 2023-03-15 11:37:25 +00:00
Robert Schulze
b2aa9324ac
Un-friend system view (no longer necessary) 2023-03-15 11:03:42 +00:00
Robert Schulze
2f75a6da61
Merge remote-tracking branch 'origin/master' into rs/qc-cachebase 2023-03-15 11:00:53 +00:00
Robert Schulze
75ca2dd0e2
Merge remote-tracking branch 'origin/master' into rs/qc-cachebase 2023-03-15 10:55:53 +00:00
Vitaly Baranov
00c05f7f8b
Merge pull request #47546 from vitlibar/use-server-side-copy-for-restore
Use server-side copy for restore from S3 to S3.
2023-03-15 11:28:29 +01:00
Robert Schulze
5cee479f0c
Merge pull request #47424 from ClickHouse/rs/compile-with-cpp23
Compile with C++23
2023-03-15 10:55:42 +01:00
save-my-heart
d70c352313 checksum: do not check inverted index files 2023-03-15 16:43:59 +08:00
Azat Khuzhin
bcf381c5ae Reimplement interserver mode to avoid replay attacks
Prevous implementation (DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET)
accepts the salt from the client, which make it useless.

Reimplement the protocol to send the salt by the server and use it in
the client instead.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-15 08:28:43 +01:00
Nikolay Degterinsky
398978e0bc Fix build 2023-03-15 00:09:29 +00:00
Nikolay Degterinsky
f3908a9e84 Fix style 2023-03-14 22:49:10 +00:00
Vitaly Baranov
c9f4143514 Fix build. 2023-03-14 23:34:48 +01:00
Vitaly Baranov
25356786ea Simplify the implementation, create new utility function copyS3FileToDisk(). 2023-03-14 23:34:44 +01:00
robot-clickhouse-ci-1
e8c6d55c22
Merge pull request #47582 from CurtizJ/fix-perf-regression
Fix performance regression in aggregation
2023-03-14 23:17:53 +01:00
Nikolay Degterinsky
eddda2eb73 Add SSL authentication to the native protocol 2023-03-14 22:10:08 +00:00
Ilya Yatsishin
82a6d75050
Merge pull request #47535 from ucasfl/insrt
Add INSTR as alias of positionCaseInsensitive for MySQL compatibility
2023-03-14 22:00:40 +01:00
Alexey Milovidov
e443c4e682
Merge pull request #47538 from Avogar/proper-parquet-fix
Proper fix for bug in parquet, revert reverted #45878
2023-03-14 22:29:39 +03:00
Han Fei
6cdd3ffb31
Merge pull request #47541 from azat/dist/preserve-error-on-flush
Preserve error in system.distribution_queue on SYSTEM FLUSH DISTRIBUTED
2023-03-14 20:25:01 +01:00
Antonio Andelic
b611ae5f02
Merge pull request #47526 from ClickHouse/fix-monotonicity-check
Fix monotonicity check for DateTime64
2023-03-14 20:20:52 +01:00
Maksim Kita
26ba62bb9e ReadFromMergeTree explain prewhere and row policy actions 2023-03-14 18:02:56 +01:00
Alexander Tokmakov
773cd5a686
Revert "Backup_Restore_concurrency_check_node" 2023-03-14 18:55:08 +03:00
Anton Popov
d2a8cd3ed4 fix performance regression 2023-03-14 14:51:28 +00:00
robot-ch-test-poll4
8bbfba39d5
Merge pull request #47542 from ClickHouse/totals-in-fill-transform
Remove TOTALS handling in FillingTransform
2023-03-14 15:05:32 +01:00
SmitaRKulkarni
52b6976822
Merge pull request #47495 from ClickHouse/Parameterized_view_bug_fix_47287_47247
Parameterized view bug fix 47287 47247
2023-03-14 14:33:44 +01:00
Sema Checherinda
95e994a9cd
Merge pull request #47304 from arthurpassos/fix_find_first_not_symbols
Modify find_first_symbols so it works as expected for find_first_not_symbols
2023-03-14 14:24:05 +01:00
Nikolay Degterinsky
cfb4267cfc
Merge pull request #47565 from aerosol/fix-typo
Fix typo
2023-03-14 13:51:20 +01:00
Dmitry Novik
802a3d8ed2 Fix style 2023-03-14 12:46:59 +00:00
Vitaly Baranov
859082c4b7
Merge pull request #47216 from ClickHouse/Backup_Restore_concurrency_check_node
Backup_Restore_concurrency_check_node
2023-03-14 13:36:43 +01:00
Dmitry Novik
cced9cf613 Fix build 2023-03-14 12:04:39 +00:00
Dmitry Novik
ae3d30a736 Merge remote-tracking branch 'origin/master' into fix-grouping-for-grouping-sets 2023-03-14 12:01:51 +00:00
Adam Rutkowski
694ba01c78 Fix typo 2023-03-14 12:48:00 +01:00
alesapin
d9b9d6c9ef
Merge branch 'master' into small-enhancements 2023-03-14 12:13:09 +01:00
Alexander Tokmakov
5a1ee881f8
Merge pull request #47547 from ClickHouse/filter_too_frequent_logs
Hide too noisy log messages, fix some tests
2023-03-14 13:53:21 +03:00
Nikolai Kochetov
396e1b45a4
Merge pull request #47433 from ClickHouse/apply-settings-for-explain-earlier
Apply settings for EXPLAIN earlier (in the same way we do for SELECT).
2023-03-14 11:52:20 +01:00
Nikolai Kochetov
0298a96d81
Merge pull request #47451 from ClickHouse/disable-logical-expression-optimizer-with-aliases
Disable logical expression optimizer for expression with aliases.
2023-03-14 11:51:24 +01:00
Nikolai Kochetov
be0ae6a238
Merge pull request #47537 from ClickHouse/lc_null_as_default
Fix block structure mismatch for nullable LowCardinality column
2023-03-14 11:45:39 +01:00
Robert Schulze
73afae2d3f
Introduce TTLCachePolicy 2023-03-14 09:45:20 +00:00
Robert Schulze
eed365c8c8
Cleanup: Slightly more naming consistency (probably rolls back earlier changes) 2023-03-14 09:11:36 +00:00
Robert Schulze
b985795593
Cleanup: Group ICachePolicy methods 2023-03-14 08:38:22 +00:00
Robert Schulze
e1fb25a004
Extend CacheBase with getWithKey() method 2023-03-14 08:38:22 +00:00
Robert Schulze
f1450923cb
Extend CacheBase with dump() method 2023-03-14 08:38:22 +00:00
Robert Schulze
e03618357e
Cleanup: Acquire lock in CacheBase::maxSize()
The upcoming TTLPolicy will likely have a runtime-configurable cache
size.
2023-03-14 08:38:22 +00:00
Smita Kulkarni
8a7bc3250d Added space to if expression of replaceQueryParameterWithValue function 2023-03-14 09:26:53 +01:00
Smita Kulkarni
4deeb13c6d Addressed review comments for parameterized view bug fix 2023-03-14 09:23:12 +01:00
Dmitry Novik
49b0bc21ad Resolve as FunctionGrouping 2023-03-14 03:33:31 +00:00
Alexey Milovidov
8d92649d00 Fix style 2023-03-14 02:31:04 +01:00
Michael Kolupaev
d3a514d221 Compress marks in memory 2023-03-13 16:29:00 -07:00
Alexander Tokmakov
ba6c6255a3 hide too noisy log messages, fix some tests 2023-03-14 00:23:36 +01:00
Vitaly Baranov
1cf1ce07fe Use server-side copy during restore from S3 to S3. 2023-03-13 23:50:13 +01:00
Alexey Milovidov
f331b9b398 Fix errors and add tests 2023-03-13 23:49:28 +01:00
Igor Nikonov
e82f7b9622 Polishing 2023-03-13 21:47:21 +00:00
Igor Nikonov
4239bfb586 FillingNoopTransform for totals stream 2023-03-13 21:47:21 +00:00
Igor Nikonov
85b0c5a1a4 Remove TOTALS handling in FillTransform 2023-03-13 21:47:21 +00:00
Alexey Milovidov
14647525f8 Merge branch 'fix-bson-bug' of github.com:Avogar/ClickHouse into fuzzer-of-data-formats 2023-03-13 22:45:00 +01:00
Azat Khuzhin
3d247b8635 Preserve error in system.distribution_queue on SYSTEM FLUSH DISTRIBUTED
After refactoring in #45491 this behaviour had been changed, hence
01555_system_distribution_queue_mask became flaky, since if the flush
had not happened before SYSTEM FLUSH DISTRIBUTED the error was not saved
into the system.distribution_queue.

v2: Improve 01555_system_distribution_queue_mask test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-13 20:07:55 +01:00
avogar
637d8d0f09 Fix BSONEachRow parallel parsing when document size is invalid 2023-03-13 18:52:29 +00:00
Alexey Milovidov
741acf18c3
Merge branch 'master' into disable-logical-expression-optimizer-with-aliases 2023-03-13 21:41:55 +03:00
Dmitry Novik
6f99adcdaa Support constants in INTERPOLATE clause (new analyzer) 2023-03-13 18:41:14 +00:00
Alexey Milovidov
a411ae10b5
Merge pull request #47486 from ClickHouse/revert_25674
Remove "asynchronous connection drain"
2023-03-13 21:40:39 +03:00
avogar
278c76f85a Fix 2023-03-13 18:23:51 +00:00
avogar
4213ec609f Proper fix for bug in parquet, revert reverted #45878 2023-03-13 18:22:09 +00:00
Nikolai Kochetov
650427614f Fix block structure mismatch for nullable LowCardinality column with default expression. 2023-03-13 17:57:07 +00:00
Roman Vasin
36c639ed2f Fix grants hierarchy for temporary tables and comment about default engine 2023-03-13 16:39:15 +00:00
Antonio Andelic
914e0fbb0a Fix monotonic check with DateTime64 2023-03-13 16:30:32 +00:00
Alexander Tokmakov
ee6c18cbc6
Better error after failed Ordinary-to-Atomic conversion (#47487)
* better error on failed Ordinary-to-Atomic conversion

* fix test

* Update loadMetadata.cpp
2023-03-13 19:13:49 +03:00
flynn
81b04977fd Add INSTR as alias of posionCaseInsensitive for MySQL compatibility 2023-03-13 15:44:38 +00:00
Robert Schulze
1d8004756a
Cleanup: Reuse aliases instead of redeclaring it 2023-03-13 15:11:12 +00:00
Robert Schulze
657aa65446
Cleanup: Untangle CacheBase's constructors
This prepares for the custom TTLCachePolicy which users should not be
able to configure explicitly.
2023-03-13 15:11:12 +00:00
Nikita Mikhaylov
f0b514acae Better 2023-03-13 15:20:01 +01:00
Nikolai Kochetov
ceeb36b596
Merge branch 'master' into disable-logical-expression-optimizer-with-aliases 2023-03-13 15:12:02 +01:00
Nikolai Kochetov
67424edbf0
Merge pull request #47180 from k-morozov/indices-storage-memory/update-read
Update read in StorageMemory
2023-03-13 14:40:35 +01:00
Anton Popov
739c8988dd
Merge pull request #46830 from ClickHouse/fix-url-progress-bar
Fix progress bar with URL
2023-03-13 13:53:40 +01:00
vdimir
9f220054c8
Fix build 2023-03-13 10:49:51 +00:00
Vladimir C
9cb018545c
Merge pull request #47499 from FrankChen021/span_kind 2023-03-13 11:35:03 +01:00
Antonio Andelic
04ba321ebd Fix unit test build 2023-03-13 10:28:40 +00:00
Antonio Andelic
4013bc9255 Merge branch 'master' into add-expiration-window-s3 2023-03-13 10:21:39 +00:00
Robert Schulze
475415e421
Cleanup: Move on_weight_loss_function into concrete cache policies
Makes ICachePolicy a pure abstract interface
2023-03-13 09:20:07 +00:00
Robert Schulze
d165a15c58
Cleanup: Simplify some typedefs 2023-03-13 09:20:02 +00:00
Robert Schulze
614810e471
Cleanup: Fix file name typo 2023-03-13 09:19:58 +00:00
Robert Schulze
9f6cb98c61
Cleanup: Remove default parameters from (S)LRUCachePolicy
Allows to add new mandatory parameters without accidentally breaking
something.
2023-03-13 09:19:55 +00:00
Robert Schulze
39898fbe64
Cleanup: max_elements_size --> max_entries
To disambiguate the maximum number of entries from the maximum byte size
of an entry.
2023-03-13 09:19:51 +00:00
Robert Schulze
7d5bc0d8c9
Cleanup: TrivialWeightFunction --> EqualWeightFunction
A true "trival" weight function would return .size() of the cache entry.
2023-03-13 09:19:45 +00:00
Robert Schulze
c300f5e68f
Cleanup: max_size --> max_size_in_bytes
To disambiguate the threshold from the maximum number of cache entries.
2023-03-13 09:19:39 +00:00
SmitaRKulkarni
9a35a434f8
Merge branch 'master' into Backup_Restore_concurrency_check_node 2023-03-13 10:04:32 +01:00
Smita Kulkarni
0d45443cb0 Fix for clang-tidy build 2023-03-13 09:18:44 +01:00
Alexey Milovidov
1fd24c212b Update comment 2023-03-13 07:42:58 +01:00
Alexey Milovidov
38d5635bf2 Fix too large size in quantiles 2023-03-13 07:40:56 +01:00
Alexey Milovidov
2e3aa98535 Add a test, fix logical errors 2023-03-13 06:46:19 +01:00
Alexey Milovidov
02f7ef4723 Update comment 2023-03-13 05:28:06 +01:00
Alexey Milovidov
43b938d303 Update the fuzzer 2023-03-13 05:21:48 +01:00
Alexey Milovidov
f33b651686 Add fuzzer for data formats 2023-03-13 04:51:50 +01:00
Frank Chen
868756ea76 Fix style 2023-03-13 09:40:55 +08:00
Konstantin Morozov
b287e4ae07
Merge branch 'master' into indices-storage-memory/update-read 2023-03-12 22:13:19 +01:00
Alexey Milovidov
278b8f74c2
Merge pull request #47492 from ClickHouse/revert-45878
Revert #45878 and add a test
2023-03-12 23:43:06 +03:00
Alexey Milovidov
f445649845
Merge branch 'master' into rs/compile-with-cpp23 2023-03-12 21:33:20 +03:00
Alexey Milovidov
b6169552b0 Merge branch 'master' into fix-query-parameters 2023-03-12 18:59:25 +01:00
Alexey Milovidov
389bc86875
Merge pull request #47498 from kitaisreal/planner-join-tree-build-fix
Planner JOIN TREE build fix
2023-03-12 20:54:20 +03:00
Alexey Milovidov
38612635b0
Update StorageView.cpp 2023-03-12 20:43:47 +03:00
Alexander Gololobov
e0e89066a4
Merge branch 'master' into fix-test-extra-seek 2023-03-12 16:24:33 +01:00
Frank Chen
f5d5950a67 Set SpanKind for internal queries 2023-03-12 21:31:50 +08:00