Alexander Gololobov
856f83caa1
Removed unnecessary commas
2022-08-26 10:00:20 +02:00
Frank Chen
cf1081eada
Exception safe from destructor
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-26 11:18:16 +08:00
Alexey Milovidov
a029116fe3
Add a comment
2022-08-26 04:01:34 +02:00
Alexey Milovidov
8afbfebd25
A prototype for embedded documentation
2022-08-26 03:41:52 +02:00
Alexey Milovidov
91bd6f1d46
Write the documentation for all ProfileEvents. Enforce that documentation exists.
2022-08-26 01:35:03 +02:00
Kseniia Sumarokova
a8abf58f13
Update FileSegment.cpp
2022-08-25 23:15:24 +02:00
Alexander Tokmakov
eae2667a1c
Merge pull request #40148 from ClickHouse/replicate-tables-readonly
...
`ReplicatedMergeTree` tables as readonly until attach is finished
2022-08-25 19:39:19 +03:00
zvonand
3b164f0b12
style fix
2022-08-25 17:07:41 +03:00
Vladimir C
ddde5096ef
Merge branch 'master' into vdimir/tmp-file-metrics
2022-08-25 15:23:35 +02:00
zvonand
b3360c169d
Fix handling zeros/'1's at the beginning of input
2022-08-25 15:35:39 +03:00
Frank Chen
92f7ca3616
Move TracingContextOnThread::current() out of class for simplicity
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-25 20:23:56 +08:00
Frank Chen
bb00dcc19b
Remove using namespace from header
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-25 20:20:13 +08:00
Kseniia Sumarokova
fac87d9c4d
Update FileSegment.cpp
2022-08-25 13:18:03 +02:00
Kseniia Sumarokova
2089ce14dd
Merge branch 'master' into fix-race
2022-08-25 13:03:29 +02:00
Kseniia Sumarokova
44577ea8f6
Update FileSegment.cpp
2022-08-25 13:02:41 +02:00
Kseniia Sumarokova
7e0ff0dfaf
Update FileSegment.cpp
2022-08-25 12:53:51 +02:00
Kseniia Sumarokova
b0f5fd9bf6
Update FileSegment.cpp
2022-08-25 12:41:31 +02:00
alesapin
c4f8811701
Merge pull request #40395 from ClickHouse/data_source_description
...
Add copy shortcut for backups if dest and source support it
2022-08-25 12:36:30 +02:00
Kseniia Sumarokova
f6eea03120
Merge pull request #40569 from kssenii/add-comments
...
Add some logs to fs cache
2022-08-25 12:06:48 +02:00
Frank Chen
221a71f801
Fix typo
2022-08-25 15:05:07 +08:00
Frank Chen
558b179cb1
Fix typo
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-25 10:14:18 +08:00
Frank Chen
99c37ce6c6
Merge branch 'master' into tracing_context_propagation
2022-08-25 10:07:16 +08:00
Antonio Andelic
da0d6056f4
Merge branch 'master' into replicate-tables-readonly
2022-08-24 17:29:33 +00:00
kssenii
ee2f9caa16
Fix
2022-08-24 18:50:22 +02:00
vdimir
7194df1184
Move back TemporaryFile -> TemporaryFileOnDisk
2022-08-24 16:14:11 +00:00
vdimir
1e24a731f7
Move Disks/TemporaryFileOnDisk -> Common/TemporaryFile
2022-08-24 16:14:10 +00:00
vdimir
8701a909a2
enoughSpaceInDirectory works if file is not created yet
2022-08-24 16:14:09 +00:00
vdimir
51c44424cc
More metrics for temp files
2022-08-24 16:14:09 +00:00
vdimir
cd4038d511
Use TemporaryFileOnDisk instead of Poco::TemporaryFile
2022-08-24 16:14:08 +00:00
vdimir
7e0c9062c7
Add ProfileEvents::ExternalSort(Un)CompressedBytes
2022-08-24 16:14:07 +00:00
Kseniia Sumarokova
3b982f6b8b
Update FileCache.cpp
2022-08-24 17:29:43 +02:00
Kseniia Sumarokova
aa0ed28a0b
Update FileSegment.cpp
2022-08-24 16:43:44 +02:00
Kseniia Sumarokova
985276f8e6
Merge branch 'master' into add-comments
2022-08-24 16:33:35 +02:00
Kseniia Sumarokova
6d0907ebef
Update FileSegment.cpp
2022-08-24 15:55:07 +02:00
Kseniia Sumarokova
2cea295a7a
More logs
2022-08-24 15:53:54 +02:00
alesapin
eeb0a3584e
Merge branch 'master' into data_source_description
2022-08-24 15:26:18 +02:00
Kseniia Sumarokova
3e8a2d9093
Update FileSegment.cpp
2022-08-24 14:16:53 +02:00
kssenii
2b792a2bdd
Add more logs
2022-08-24 12:40:44 +02:00
Frank Chen
1cf3659f26
Fix style checking
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-24 18:03:14 +08:00
Frank Chen
dd0f2cbe6b
Fix style checking
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-24 17:04:02 +08:00
Frank Chen
03007606ba
Fix format
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-24 17:01:31 +08:00
Frank Chen
cd19366b44
Move classes into DB::OpenTelemetry namespace
2022-08-24 16:41:40 +08:00
Frank Chen
efc6a60a60
Clean code
2022-08-24 15:59:44 +08:00
Kseniia Sumarokova
d814a56277
Merge pull request #40420 from kssenii/fix-cache-bug
...
Fix incorrect fallback to skip cache in case of very high concurrency level
2022-08-23 14:18:38 +02:00
Robert Schulze
635cc7617e
Merge pull request #40464 from ClickHouse/less-string-ref
...
Reduce some usage of StringRef
2022-08-23 12:16:00 +02:00
Maksim Kita
11ba15dde6
Merge branch 'master' into dns-resolver-remove-hints
2022-08-22 22:23:35 +02:00
Alexey Milovidov
0252695c6e
Merge pull request #40224 from ClickHouse/alexey-milovidov-patch-4
...
Check what will be if I enable `concurrency-mt-unsafe` in `clang-tidy`
2022-08-22 23:12:01 +03:00
Maksim Kita
191f39ae8d
DNSResolver remove AI_V4MAPPED, AI_ALL hints
2022-08-22 21:03:25 +02:00
Robert Schulze
ec9ef741fc
Merge branch 'master' into less-string-ref
2022-08-22 20:48:16 +02:00
Kseniia Sumarokova
f85e5f8808
Merge branch 'master' into fix-cache-bug
2022-08-22 16:54:07 +02:00
Azat Khuzhin
ec2e671d20
Remove ThreadStatus::untracked_memory_limit_increase
...
It looks useless nowadays, because operator new cannot throw
MEMORY_LIMIT_EXCEEDED today, and so any code that works on Exception is
likely safe.
Refs: #40249
Refs: #24483
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-22 13:26:18 +03:00
kssenii
74087d57c4
Less notify
2022-08-22 12:00:14 +02:00
kssenii
26384b2543
Fix
2022-08-22 00:02:05 +02:00
Alexey Milovidov
996aa2d126
Remove some trash
2022-08-21 20:46:33 +02:00
Robert Schulze
e8b3f56733
Limit suppression to a specific warning
2022-08-21 18:24:17 +00:00
Robert Schulze
4caf2c4c33
Reduce some usage of StringRef
...
See #39535 and #39300
2022-08-21 18:10:32 +00:00
alesapin
78ba732b31
Merge branch 'master' into data_source_description
2022-08-21 12:11:21 +02:00
Alexey Milovidov
0db45afb08
Merge branch 'master' into alexey-milovidov-patch-4
2022-08-20 19:58:31 +03:00
Alexey Milovidov
3649aac593
Fix style
2022-08-20 17:59:51 +02:00
Alexey Milovidov
74e1f4dc61
Fix clang-tidy
2022-08-20 17:09:20 +02:00
Frank Chen
54a530a4e0
Make sure right toString is linked
2022-08-20 14:22:33 +08:00
Frank Chen
0569608192
Use toString
2022-08-20 12:30:39 +08:00
Azat Khuzhin
28f2607d50
Fix rare race in updating peak of memory tracker
...
Previously it was possible that allocation, that had been done with
locked MEMORY_LIMIT_EXCEEDED (LockMemoryExceptionInThread), will update
the peak to the amount that will include some other allocations.
Consider the following example (T1/T2 - different threads):
Initial state:
MemoryTracker::amount = 0
Possible race:
LockMemoryExceptionInThread locker;
T1: MemoryTracker::allocImpl(1MiB) T2: MemoryTracker::allocImpl(1PiB)
will_be = 1T, amount = 1T
will_be = 1T+1MiB, amount=1T+1MiB
peak = will_be
amount = 0 // revert due to exceeding limit
throw(MEMORY_LIMIT_EXCEEDED)
So as you can see T1 includes allocations from T2 into the peak.
Note, that almost every place that has memory_usage column uses
MemoryTracker::peak (not MemoryTracker::amount), this is true for
query_log (for part_log column name is peak_memory_usage, and obviously
it uses MemoryTracker::peak).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-19 20:57:12 +02:00
kssenii
e641664115
Refactor
2022-08-19 18:15:18 +02:00
alesapin
d8664c3227
Add shortcut for backups
2022-08-19 16:58:30 +02:00
Antonio Andelic
5e2c8869a9
Merge branch 'master' into replicate-tables-readonly
2022-08-19 09:41:11 +00:00
Frank Chen
a3b6ad2a65
Merge branch 'master' into tracing_context_propagation
2022-08-18 20:59:07 +08:00
Nikolai Kochetov
5a85531ef7
Merge pull request #38286 from Avogar/schema-inference-cache
...
Add schema inference cache for s3/hdfs/file/url
2022-08-18 13:07:50 +02:00
Kseniia Sumarokova
d8fd1f9c37
Merge pull request #36171 from kssenii/make-cache-composable
...
Make cache composable, allow not to evict certain files (regarding .idx, .mrk, ..), delete old cache version
2022-08-18 12:37:34 +02:00
Vladimir C
7ac0eb1af1
Merge pull request #40035 from ClickHouse/vdimir/cluster-discovery-observer
...
Add observer mode to (zoo)keeper cluster discovery feature
2022-08-18 10:53:49 +02:00
kssenii
d63d34f7bb
Merge master
2022-08-17 15:49:32 +02:00
avogar
8dd54c043d
Merge branch 'master' of github.com:ClickHouse/ClickHouse into schema-inference-cache
2022-08-17 11:47:40 +00:00
Nikolai Kochetov
8ec3f0821c
Merge pull request #40249 from azat/fix-memory-account-on-error
...
Fix memory accounting in case of MEMORY_LIMIT_EXCEEDED errors
2022-08-17 12:51:40 +02:00
Alexander Tokmakov
4482465ce3
Merge pull request #40134 from arthurpassos/fix_cares_reverse_dns_race_condition
...
Fix CaresPTRResolver race condition
2022-08-16 21:06:17 +03:00
Nikolai Kochetov
feab1eb0a3
Update CurrentMemoryTracker.cpp
2022-08-16 18:40:06 +02:00
Nikolai Kochetov
8e4c967fc9
Try to account untracked memory (per thread) more correctly.
2022-08-16 18:09:05 +02:00
Azat Khuzhin
ded70fbd53
Fix memory accounting in case of MEMORY_LIMIT_EXCEEDED errors
...
In case of memory allocation had been failed, it should not be take into
account anywhere, otherwise it will report incorrect memory usage for
query and in logs.
I found this while was digging into OOM in stress tests, and saw memory
allocations that had been significantly greater the memory limit (even
with overcommit).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-16 18:08:56 +02:00
kssenii
43991729ef
Fix
2022-08-16 17:08:12 +02:00
kssenii
93816e7366
Review fixes
2022-08-16 15:11:55 +02:00
kssenii
3901778d49
Add more current metrics for cache
2022-08-16 11:32:23 +02:00
Antonio Andelic
2ed42bca7e
Merge branch 'master' into replicate-tables-readonly
2022-08-16 08:17:53 +00:00
kssenii
eb26b219b9
Merge master
2022-08-16 00:56:27 +02:00
Alexander Tokmakov
c9bb91c31f
Merge pull request #40232 from ClickHouse/fix_a_bug_with_symlinks_detection
...
Fix a bug with symlinks detection
2022-08-15 20:28:30 +03:00
Robert Schulze
70f63d2aae
Merge pull request #40033 from ClickHouse/reenable-avx512-vbmi-columnvector-filter
...
Revert the revert of "ColumnVector: optimize filter with AVX512 VBMI2 compress store"
2022-08-15 18:39:57 +02:00
Alexander Tokmakov
0e22b4b800
Update src/Common/filesystemHelpers.cpp
...
Co-authored-by: alesapin <alesapin@clickhouse.com>
2022-08-15 14:25:25 +03:00
Alexander Tokmakov
6f5a7c3bf7
fix a bug with symlinks detection
2022-08-15 12:30:47 +02:00
Alexey Milovidov
903021f35a
Merge branch 'master' into profile-events-incomplete-result
2022-08-14 11:04:19 +03:00
Alexey Milovidov
1a8ddf2956
Addition to prev. revision
2022-08-14 09:35:22 +02:00
Alexey Milovidov
001aca3b47
ProfileEvents for incomplete data due to query complexity settings
2022-08-14 09:17:02 +02:00
Alexey Milovidov
216c1d8efa
Revert "Use separate counter for RSS in global memory tracker."
2022-08-14 09:50:12 +03:00
Alexey Milovidov
6b8f4f1d59
Merge branch 'master' into server-side-time
2022-08-12 21:36:40 +02:00
Maksim Kita
098436f012
Merge pull request #40129 from kitaisreal/pod-array-assign-empty-array-fix
...
PODArray assign empty array fix
2022-08-12 18:34:19 +02:00
Kseniia Sumarokova
a6cfc7bc3b
Merge pull request #34651 from alexX512/master
...
New caching strategies
2022-08-12 17:23:37 +02:00
Alexey Milovidov
8c3d1f2b5b
Merge branch 'master' into server-side-time
2022-08-12 17:40:02 +03:00
Arthur Passos
07163eb79a
Remove c-ares lib de-initialization
2022-08-12 10:49:39 -03:00
vdimir
cef6c4f8ce
Add observer mode to (zoo)keeper cluster discovery feature
2022-08-12 13:26:12 +00:00
Kruglov Pavel
4c7222d938
Merge pull request #40020 from canhld94/ch_canh_fix_hash
...
fix HashMethodOneNumber with const column
2022-08-12 14:40:24 +02:00
Antonio Andelic
1c0f85ccdb
Attach table in background
2022-08-12 09:32:13 +00:00
kssenii
fd6362d2f2
Merge master
2022-08-12 11:22:39 +02:00
Kseniia Sumarokova
09ad1115d7
Merge pull request #40138 from ClickHouse/kssenii-patch-4
...
fs cache: minor change
2022-08-12 11:18:03 +02:00