Commit Graph

1762 Commits

Author SHA1 Message Date
Raúl Marín
5b27b82da5
Merge pull request #60740 from bigo-sg/rm_wrong_quantilegk_check
Remove wrong sanitize checking in aggregate function quantileGK
2024-03-13 17:25:41 +01:00
Anton Popov
ccc6df0e43 fix aggregate function uniqExact 2024-03-12 16:48:19 +00:00
Raúl Marín
c9c73378eb Fix problem detected by ubsan 2024-03-12 11:52:17 +01:00
Raúl Marín
563df9bdcb Fix multiple bugs in groupArraySorted 2024-03-11 22:49:18 +01:00
李扬
f50b8cc5ae
Merge branch 'ClickHouse:master' into rm_wrong_quantilegk_check 2024-03-05 16:49:37 +08:00
taiyang-li
c435d5894f remove wrong assertion n quantileGK 2024-03-04 14:23:59 +08:00
UnamedRus
912b8baf57
Merge branch 'ClickHouse:master' into topk-statistics-count-errors 2024-03-02 00:43:29 +09:00
Raúl Marín
885952a03b
Merge pull request #58640 from Algunenano/argmin_optimization
ArgMin / ArgMax / any / anyLast / anyHeavy optimization
2024-03-01 12:45:58 +01:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Raúl Marín
7e2b5efb29 Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-02-29 14:13:07 +01:00
Raúl Marín
2a644c8b08 Improvements based on PR review 2024-02-28 18:28:38 +01:00
Alexey Milovidov
0f3c9963d1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into revert-60216-revert-59697-check-stack-size-in-parser 2024-02-27 17:30:32 +01:00
Raúl Marín
52b14c3f0a Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-02-27 16:40:59 +01:00
Raúl Marín
c1c4a8c02a Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-02-27 12:49:18 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Yarik Briukhovetskyi
e04a89349d
Merge branch 'ClickHouse:master' into group_array_intersect 2024-02-26 12:29:22 +01:00
yariks5s
a69243e104 Merge branch 'group_array_intersect' of github.com:yariks5s/ClickHouse into group_array_intersect 2024-02-21 15:05:31 +00:00
yariks5s
434ca081bd fix fuzzer 2024-02-21 15:05:22 +00:00
Yarik Briukhovetskyi
ac7c40c4a3
style 2024-02-21 14:34:27 +01:00
yariks5s
7234edd4d0 merge 2024-02-21 13:16:23 +00:00
yariks5s
626eab073c review 2024-02-21 13:15:19 +00:00
Antonio Andelic
fee1565780
Revert "Check stack size in Parser" 2024-02-21 11:33:08 +01:00
Yarik Briukhovetskyi
c6db8c2caf
style fix 2024-02-20 20:12:00 +01:00
yariks5s
8bede17058 hashmap -> hashset / review changes 2024-02-20 18:57:36 +00:00
Raúl Marín
e09113f10b
Merge pull request #59504 from bigo-sg/opt_sum_decimal
Optimize performance of sum/avg conditionally for bigint and big decimal types by reducing branch miss
2024-02-20 11:32:02 +01:00
taiyang-li
2d6b4b400c Merge remote-tracking branch 'origin/master' into opt_sum_decimal 2024-02-19 12:25:22 +08:00
Alexey Milovidov
6fd563df52 Miscellaneous 2024-02-19 02:58:51 +01:00
yariks5s
4d0996ed90 code optimization + tests 2024-02-16 17:16:47 +00:00
Yarik Briukhovetskyi
a41edd8646
Merge branch 'master' into group_array_intersect 2024-02-15 19:50:57 +01:00
yariks5s
89314ac0e8 [mid] optimization 2024-02-15 18:50:23 +00:00
yariks5s
2df794a354 Merge branch 'group_array_intersect' of github.com:yariks5s/ClickHouse into group_array_intersect 2024-02-13 16:35:19 +00:00
yariks5s
3d495ba001 fast tests 2024-02-13 16:35:08 +00:00
Yarik Briukhovetskyi
b79ecd6b56
style check 2024-02-13 17:11:34 +01:00
yariks5s
a6c6c2df07 implement for datetime64 (doesn't work correctly for all functions) 2024-02-13 15:57:46 +00:00
Maksim Kita
ddf0f22819 UniqExactSet read crash fix 2024-02-13 14:36:46 +03:00
Raúl Marín
a680fcb1f7 Recover a hack 2024-02-12 20:41:18 +01:00
yariks5s
f8f8663c50 fix tests/ put comment on bug with datetime64/ added impl for date32 2024-02-12 18:33:51 +00:00
yariks5s
bba0fdee97 fix style 2024-02-12 11:57:11 +00:00
Raúl Marín
d17b0867e6 Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-02-09 13:08:23 +01:00
Raúl Marín
d782c9bde6 Fix crash in topK when merging empty states 2024-02-05 20:52:54 +01:00
yariks5s
ad6dcfed81 init 2024-02-05 17:50:05 +00:00
taiyang-li
be19fb9935 change as request 2024-02-04 14:39:55 +08:00
李扬
d68a0e7b3e
Update src/AggregateFunctions/AggregateFunctionSum.h
Co-authored-by: Raúl Marín <git@rmr.ninja>
2024-02-04 14:25:14 +08:00
李扬
9e1a3c7c24
Update src/AggregateFunctions/AggregateFunctionSum.h
Co-authored-by: Raúl Marín <git@rmr.ninja>
2024-02-04 14:25:04 +08:00
taiyang-li
eba094e228 optimize sum decimal and bitint conditionally 2024-02-02 16:48:30 +08:00
Raúl Marín
a40be3ea11 Make MAX use the same rules as permutation for complex types 2024-02-01 20:22:33 +01:00
Raúl Marín
b93f003b3e
Merge pull request #58216 from bigo-sg/fix_quantiles_gk_state
Fix quantilesGK bug
2024-02-01 11:58:02 +01:00
Nikolai Kochetov
7e722b52a9
Merge pull request #59003 from kitaisreal/revert-57519-revert-53562-group_sorted_array_function
Revert "Revert "Add new aggregation function groupArraySorted()""
2024-01-31 12:31:26 +01:00
taiyang-li
a89890babe fix bug of quantileGK 2024-01-31 12:14:04 +08:00
Maksim Kita
600eae00cc Fixed code review issues 2024-01-30 19:50:18 +03:00
Maksim Kita
1c5b377b3a Fixed code review issues 2024-01-30 19:36:40 +03:00
Maksim Kita
948f3f1f62 Fixed style check 2024-01-30 17:15:29 +03:00
Maksim Kita
86a542b5c4 Updated implementation 2024-01-30 17:15:29 +03:00
Maksim Kita
20c1f0c18f Revert "Revert "Add new aggregation function groupArraySorted()"" 2024-01-30 17:15:29 +03:00
Alexey Milovidov
798f655276 Rename quantileDDSketch to quantileDD 2024-01-30 11:49:56 +01:00
UnamedRus
94770f8d8a
Merge branch 'master' into topk-statistics-count-errors 2024-01-28 20:50:45 +03:00
Nikolai Kochetov
75edbdd39c
Merge pull request #59147 from ClickHouse/vdimir/fix_agg_nothing_2
Fix AggregateFunctionNothing result type issues introducing it with different names
2024-01-26 14:33:38 +01:00
Raúl Marín
f9d218ec52 Fix a bug 2024-01-24 21:03:46 +01:00
vdimir
bcfe691954
Use different names for nothing function with different result types 2024-01-24 09:55:09 +00:00
Raúl Marín
96eb5f2fbb Fix old JIT bug and improve code 2024-01-23 17:02:37 +01:00
Nikita Taranov
c7be7363cf fix 2024-01-23 14:46:33 +01:00
Raúl Marín
eb3cfcc300 Tidy 2024-01-23 10:43:00 +01:00
Raúl Marín
e1bd77fa31 Introduce one template level to argMin to recover some perf 2024-01-22 17:31:34 +01:00
Raúl Marín
1e00dec997 Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-01-22 14:56:55 +01:00
Raúl Marín
a2d23ab78e Micro opt 2024-01-22 14:56:17 +01:00
Raúl Marín
a38ca3bca2 Optimize SingleValueDataNumeric getIndexNotNullIf 2024-01-22 14:55:52 +01:00
Dmitry Novik
a18a8d8ea3
Merge pull request #59009 from nickitat/uniq_optimisation_for_distributed
`uniqExact` state parallel merging for distributed queries
2024-01-22 14:05:02 +01:00
Nikita Taranov
60a910e94f better 2024-01-19 18:47:21 +01:00
Nikita Taranov
f1efb29a66 better 2024-01-19 18:13:03 +01:00
Nikita Taranov
a47d15ab62 impl 2024-01-19 16:59:01 +01:00
Raúl Marín
8d30feec98 Initialize to false 2024-01-18 15:04:08 +01:00
Raúl Marín
bcc67735b9 Tidy 2024-01-18 13:16:08 +01:00
Raúl Marín
6aa5ac4cc6 Merge remote-tracking branch 'blessed/master' into argmin_optimization 2024-01-18 12:04:19 +01:00
Raúl Marín
1105be0e73 Recover lost JIT performance 2024-01-18 12:01:52 +01:00
Srikanth Chekuri
c23c7e0b6f
feat: add DDSketch quantile (#56342)
* feat: add DDSketch quantile

* Fix StyleCheck

* Move quantileddsketch.md under right dir

* Update stateless test number and add stateful test

* Throw exception when relative accuracy is too low

* Update test number

* Fix undefined behaviour for empty store

* Fix quantileGK test

* Update test numbers

* Update src/AggregateFunctions/

* Throw exception on out of range values

* Update relative accuracy docs and add encoding details

* Address review comments and suggestions

* Remove unused function

* Address alexey review comments

* Remove unused function isFloat64FieldType

* Throw error on invalid relative accuracy

* Simplify mapping

* Address remaining review comments

* Add effective memory usage suggestions

* Fix Stylecheck

* Fix fast test

* Incorporate bins capacity suggestion

* Fix fuzzer

* Remove inheritance in Mapping, Store and DDSketch

* Add checks for bin resizing

* Add note about the binary compatible implementation
2024-01-17 19:51:32 -08:00
Raúl Marín
849ac1fe99 Implement findExtremeMinIndex / findExtremeMaxIndex 2024-01-17 16:22:40 +01:00
Raúl Marín
6daaf3dc72 Self review to improve style and bug in ArgMax combinator 2024-01-17 14:21:25 +01:00
Raúl Marín
9cffb9bfeb Do not use a stack variable 2024-01-16 13:20:39 +01:00
Raúl Marín
428f69c57d Tidy 2024-01-16 10:17:05 +01:00
Raúl Marín
56a8368db7 Make sure compileCreate initializes the vtable pointer 2024-01-16 00:47:58 +01:00
Raúl Marín
7b62ad2156 Tidy 2024-01-16 00:46:03 +01:00
Raúl Marín
4acda2222e Better readability 2024-01-16 00:46:03 +01:00
UnamedRus
6910cdbac4 Added test, bumped to master 2024-01-14 01:33:17 +03:00
Raúl Marín
5dfa6799a5 Style 2024-01-13 13:30:53 +01:00
Raúl Marín
6e5965b4cc Reintroduce JIT in any, anyLast, min and max 2024-01-12 19:42:57 +01:00
Raúl Marín
c1d52b9771 Proper check order 2024-01-12 14:13:34 +01:00
Raúl Marín
99f3ac5a0c Implement missing destructors 2024-01-12 13:49:25 +01:00
Raúl Marín
13c2b6ab60 Clang tidy is just unhappy and making me unhappy too 2024-01-12 12:33:31 +01:00
Raúl Marín
50bc69aae8 Try to make clang-tidy happy 2024-01-12 11:13:25 +01:00
Raúl Marín
75b394bd0e Full revert of changes to IAggregateFunction.h 2024-01-12 10:07:15 +01:00
Raúl Marín
ebd6fee431 Some fixes 2024-01-11 19:44:19 +01:00
Raúl Marín
7a84418493 Revert incorrect change
Constructor should be called by init. Let's verify
2024-01-11 18:25:43 +01:00
Raúl Marín
260c2f7e97 Clang tidy 2024-01-11 17:06:26 +01:00
Raúl Marín
54093f9496 Fix some bugs in ArgMin/ArgMax combinator 2024-01-11 16:58:53 +01:00
Raúl Marín
5791ebb74c Fix some problems 2024-01-11 12:18:52 +01:00
Raúl Marín
58891e15b5 Bug and sanity 2024-01-10 18:57:06 +01:00
Raúl Marín
4321abec5b Reimplement ArgMin and ArgMax combinators 2024-01-10 17:18:07 +01:00
Raúl Marín
05247f5e41 Smaller vs greater 2024-01-10 14:32:46 +01:00
Raúl Marín
7ab7f10ed6 Remove more templates 2024-01-10 14:29:07 +01:00
Raúl Marín
19dd7bb14a Unify min/max and argMin/argMax 2024-01-10 14:07:39 +01:00