Commit Graph

1814 Commits

Author SHA1 Message Date
robot-clickhouse-ci-2
8af7d1687b
Merge pull request #72954 from ClickHouse/backport/24.10/72454
Backport #72454 to 24.10: Don't allow creating empty Variant
2024-12-16 19:43:04 +01:00
robot-clickhouse
413800627c Backport #73082 to 24.10: Check for duplicate JSON keys during Tuple parsing 2024-12-11 12:10:56 +00:00
robot-clickhouse
8857128a9b Backport #72454 to 24.10: Don't allow creating empty Variant 2024-12-09 14:09:53 +00:00
robot-clickhouse
3d01456b42 Backport #71923 to 24.10: Fix Dynamic serialization in Pretty JSON formats 2024-11-22 13:14:36 +00:00
robot-clickhouse
6ac05a9809 Backport #71369 to 24.10: Check suspicious and experimental types in JSON type hints 2024-11-11 14:09:42 +00:00
Pavel Kruglov
9a9190f31e
Merge pull request #71363 from ClickHouse/backport/24.10/71182
Backport #71182 to 24.10: Escape special symbols in files for JSON subcolumns
2024-11-06 13:53:27 +01:00
robot-clickhouse
b021025333 Backport #71182 to 24.10: Escape special symbols in files for JSON subcolumns 2024-11-01 12:12:20 +00:00
robot-clickhouse
58fa91eb09 Backport #71299 to 24.10: Fix reading of LowCardinality dictionary in Dynamic column 2024-11-01 12:10:44 +00:00
Amos Bird
2393d2fc4b
Extend comment and re-enable setting 2024-10-22 09:09:42 +08:00
Amos Bird
82615d87e6
Normalize named tuple arguments in agg states 2024-10-22 08:57:26 +08:00
Daniil Ivanik
877e27245e
Merge branch 'master' into master 2024-10-16 11:23:39 +02:00
Robert Schulze
1f1a9c8508
Merge pull request #70134 from rschu1ze/libcxx-debug-mode
(Re?)-enable libcxx asserts for debug builds
2024-10-16 07:50:52 +00:00
Robert Schulze
b9b7a1091b
(Re)-enable libcxx debug mode
- We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx
  versions, this (surprisingly) enabled the basic debug mode [1].

- In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0
  does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1.

- The debug mode is only enabled in Debug builds. Their docs say the
  extra check change complexity guarantees + the asserts crash which we
  don't want in Release builds. The debug mode detects issues like in
  [3]. Crashes look like this (for example)

  ```
  /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped)
  ```

- I had to mute some new clang-tidy warnings in places that deal with
  container iterators. They got heavier and copy-by-value now yields a
  warning, e.g.

     for (auto it : iterators) /// <-- warning
         [...]

[1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-10-15 13:46:07 +00:00
Arthur Passos
9b6979b286
Merge branch 'master' into add_parquet_bloom_filters_support 2024-10-11 09:46:19 -03:00
lwz9103
31dd409d28 Improve compatibility of cast(timestamp as string) with spark
remove trailing zeros with the configuration date_time_64_output_format_cut_trailing_zeros_align_to_groups_of_thousands, which defaults to false to maintain consistency with previous behavior.
If config is true, output scale will be dynamic set in (0, 3, 6) according to tailing zeros. See changes in following examples.

- 2012-01-01 00:11:22.000000 -> 2012-01-01 00:11:22
- 2012-01-01 00:11:22.120000 -> 2012-01-01 00:11:22.120
- 2012-01-01 00:11:22.123400 -> 2012-01-01 00:11:22.123400
2024-10-11 14:11:16 +08:00
Pavel Kruglov
82aeaac984
Merge branch 'master' into native-json-as-string 2024-10-09 12:40:33 +08:00
avogar
24c5b0aa68 Fix builds 2024-10-09 03:30:07 +00:00
avogar
2b735896ea Better comments 2024-10-09 03:28:46 +00:00
Pavel Kruglov
26f9aec1a5
Merge pull request #70288 from Avogar/json-as-string-row-binary
Allow to read/write JSON type as binary string in RowBinary format
2024-10-09 03:15:38 +00:00
vdimir
a23e8071db
Merge pull request #70374 from Avogar/fix-json-sub-object-subcolumn-group-by
Fix crash during GROUP BY JSON sub-object subcolumn
2024-10-08 17:02:48 +00:00
Arthur Passos
ce74e317a2 Merge branch 'master' into add_parquet_bloom_filters_support 2024-10-07 16:56:37 -03:00
Pavel Kruglov
291cd824cd
Merge branch 'master' into json-as-string-row-binary 2024-10-07 06:29:51 +02:00
Pavel Kruglov
4ee78ee4f4
Merge branch 'master' into native-json-as-string 2024-10-07 06:06:57 +02:00
Konstantin Bogdanov
67c1e89d90
Apply linter changes 2024-10-06 12:29:20 +02:00
Konstantin Bogdanov
f0ae77edb0
Fix build with clang-19 2024-10-05 14:47:23 +02:00
Raúl Marín
73a9de30a6 Remove some nested IAST.h includes in favor of forward declarations 2024-10-04 18:47:13 +02:00
avogar
31c1720086 Fix crash during GROUP BY JSON sub-object subcolumn 2024-10-04 13:12:04 +00:00
Pavel Kruglov
a4cd3b326a
Merge branch 'master' into native-json-as-string 2024-10-04 14:14:39 +02:00
avogar
766458aa0f Allow to serialize JSON column as single String column in Native format 2024-10-03 11:44:47 +00:00
Pavel Kruglov
f0194a7fde
Merge branch 'master' into json-as-string-row-binary 2024-10-03 00:02:31 +02:00
avogar
b218e7e853 Allow to read/write JSON type as binary string in RowBinary format 2024-10-02 19:50:47 +00:00
Pavel Kruglov
321980f650
Merge pull request #70218 from Avogar/respect-simdjson-setting
Respect setting allow_simdjson in JSON type parser
2024-10-02 09:48:42 +00:00
avogar
b40af9c460 Respect setting allow_simdjson in JSON type parser 2024-10-01 17:13:18 +00:00
avogar
cf8f2f6293 Fix Dynamic type creation of JSON subcolumn 2024-09-30 20:18:01 +00:00
vdimir
24c5548aa6
Merge pull request #69828 from CurtizJ/insert-sparse-columns
Allow to parse directly into sparse columns
2024-09-30 16:04:19 +00:00
Anton Popov
b27207ea27 better serialization hints 2024-09-26 17:38:07 +00:00
Raúl Marín
e1d684007c
Merge pull request #69914 from Algunenano/dbms_functionless
Remove dbms dependency on clickhouse_functions
2024-09-25 20:42:32 +00:00
Anton Popov
5f2c511f27 Merge remote-tracking branch 'upstream/master' into HEAD 2024-09-25 14:47:06 +00:00
Raúl Marín
a90790ce5b Remove dbms dependency on clickhouse_functions 2024-09-24 19:48:23 +02:00
Anton Popov
ccb18ff3e0 fix reset of serialization hints 2024-09-23 13:47:42 +00:00
Alexey Milovidov
48b6e5b58e Simplification 2024-09-23 03:34:06 +02:00
Alexey Milovidov
9624fb27e5 Remove garbage 2024-09-22 21:29:12 +02:00
Alexey Milovidov
54cf7e3148 Remove garbage 2024-09-22 21:27:22 +02:00
Alexey Milovidov
f5defdba4a Merge branch 'master' into enum_json 2024-09-22 21:26:52 +02:00
Alexey Milovidov
937728d1f5
Merge pull request #69291 from Avogar/fix-dynamic-incomplete-type-insert
Fix insertion of incomplete type into Dynamic during deserialization
2024-09-21 16:53:22 +00:00
Anton Popov
3c2d6fa820 fix and add tests 2024-09-21 13:49:06 +00:00
Anton Popov
a2d3ff49e9 allow to parse directly into sparse columns 2024-09-20 16:15:52 +00:00
Arthur Passos
10b3a0e4c8 Merge branch 'master' into add_parquet_bloom_filters_support 2024-09-19 19:56:55 -03:00
Arthur Passos
d017738a28 progress 2024-09-19 19:54:12 -03:00
Raúl Marín
f3df7bd171 Hide Settings implementation 2024-09-18 15:48:02 +02:00