Commit Graph

43615 Commits

Author SHA1 Message Date
Azat Khuzhin
8508200020 kafka: improve logging during engine shutdown
This will help with tracking possible issues, when you need to know was
buffer released or not.
2020-07-03 09:23:39 +03:00
Azat Khuzhin
e7179c402c kafka: check that the data is still usable after parsing 2020-07-03 09:23:38 +03:00
Azat Khuzhin
6104872cae kafka: fix SIGSEGV on DROP TABLE
After #11599 it is possible that messages of the
ReadBufferFromKafkaConsumer will be cleaned-up right in
read_kafka_message callback (from KafkaBlockInputStream) if the stop
flag isset (i.e. DROP TABLE is waiting the consumer), and if
read_kafka_message already processed some rows it will not return 0 and
the loop after will try to get current topic from the buffer, which uses
messages in the underlying and this will got SIGSEGV:

    12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue
    12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup
    12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11
    12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ########################################
    12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11)
    12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object.
    12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace:
    12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse

55421 thread (shows that it still waiting for deactivation):

    5  std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90
    6  DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59
    7  DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821

And just in case thread where read_kafka_message is called:

    0  DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491
    1  DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59
    2  DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81
    3  DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945
    4  DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222
    5  DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218
    6  DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64
    7  DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48
    8  DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826
    9  DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340

Cc: @filimonov
2020-07-03 09:22:44 +03:00
manmitya
457f56be0c
(typo) in doc (#12099) 2020-07-03 08:04:42 +03:00
Alexey Milovidov
4c751bf8be Added results for AWS Lightsail 2020-07-03 03:58:57 +03:00
BayoNet
3435328465
DOCS-522: max_parser_depth (#12097)
* asiana21-DOCSUP-925-max_parser_depth (#132)

* docs(max_parser_depth): added the setting description

* docs(max_parser_depth): some changes

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* docs(max_parser_depth): added ru translation

* docs(max_parser_depth): removed quotation marks

Co-authored-by: asiana21 <asiana21@yandex-team.ru>
Co-authored-by: BayoNet <da-daos@yandex.ru>

* CLICKHOUSEDOCS-522: Fixed the link.

Co-authored-by: AsiaKorushkina <43650329+AsiaKorushkina@users.noreply.github.com>
Co-authored-by: asiana21 <asiana21@yandex-team.ru>
Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
2020-07-03 00:26:55 +03:00
Ivan Blinkov
b81c66a031
[docker] install ca-certificates before the first apt-get update (#12095)
* [docker] install ca-certificates before first apt-get update

* Update Dockerfile
2020-07-02 22:16:21 +03:00
Ivan Blinkov
8513e1ec74
improve breadcrumbs markup 2020-07-02 18:17:50 +03:00
Alexander Kuzmenkov
9e02a0d879
Merge pull request #11991 from ClickHouse/aku/perf-partial
perf test: report queries with new functions separately
2020-07-02 17:12:46 +03:00
alexey-milovidov
82061da77c
Merge pull request #12040 from azat/dist-fixes
Tiny fixes for distributed queries
2020-07-02 17:02:56 +03:00
alesapin
923c7e7c2d
Remove pvs studio from images list 2020-07-02 16:19:25 +03:00
alexey-milovidov
4d01fb3cbc
Update tips.md 2020-07-02 15:54:32 +03:00
Anton Popov
71059e4dff
Merge pull request #12062 from nvartolomei/nv/set-index-tuple-types
Try fix pk in tuple performance
2020-07-02 15:51:03 +03:00
alesapin
1fb90f3811
Merge pull request #12052 from ClickHouse/test_image_changes
Test image changes
2020-07-02 15:01:06 +03:00
alesapin
f87c3af097
Merge pull request #12055 from ClickHouse/fix-9766
Fix arrayMap with Tuple(LowCardinality) argument
2020-07-02 13:40:05 +03:00
alesapin
65dae99c12
Merge pull request #12056 from ClickHouse/fix-11808
Fix defaultValueOfArgumentType
2020-07-02 13:35:38 +03:00
alesapin
cec02d15ed
Merge pull request #12067 from excitoon-favorites/betters3logs
Moved useless S3 logging to TRACE level
2020-07-02 13:21:55 +03:00
Ivan Blinkov
b4492bc5d4
[blog] 'Package Repository Behind CDN' post (#12082)
* support iframes from DataLens

* initial blog post text
2020-07-02 12:45:27 +03:00
Ivan Blinkov
b9b7abe816
revert e9d3c48f56 2020-07-02 12:31:18 +03:00
Ivan Blinkov
e9d3c48f56
Update Dockerfile 2020-07-02 12:28:23 +03:00
BayoNet
e79be9b1ed
DOCS-605: Description for the always_fetch_merged_part setting (#11921)
* Revolg DOCSUP-998 Document the always_fetch_merged_part setting (#123)

* Add always_fetch_merged_part setting

* revolg-DOCSUP-998-add_always_fetch_merged_part_setting link fixed

* Apply suggestions from code review

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Add always_fetch_merged_part setting. Updates.

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Add always_fetch_merged_part setting. Updates.

Co-authored-by: Olga Revyakina <revolg@yandex-team.ru>
Co-authored-by: BayoNet <da-daos@yandex.ru>

* CLICKHOUSEDOCS-605: Minor fixes.

* CLICKHOUSEDOCS-605: Added Plausible to Adopters.

* Update docs/ru/operations/settings/settings.md

Co-authored-by: alesapin <alesapin@gmail.com>

* Update docs/en/operations/settings/settings.md

Co-authored-by: alesapin <alesapin@gmail.com>

* CLICKHOUSEDOCS-605: Fixed access rights description.

Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: Olga Revyakina <revolg@yandex-team.ru>
Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
Co-authored-by: alesapin <alesapin@gmail.com>
2020-07-02 12:04:40 +03:00
alesapin
4c3ae82273 Better PVS image 2020-07-02 12:02:15 +03:00
Alexander Kazakov
cc2cadb7f5
Merge pull request #11893 from excitoon-favorites/autostartmoves
In *MergeTree: Parts moving task shall be started if new storage policy needs them
2020-07-02 10:44:38 +03:00
BayoNet
c7d8bf68b8
DOCS-635: Translated the EN version of the AvroConfluent format description (#11930)
* DOCSUP-1350 (#128)

* edited EN version

* add EN and RU translation

* minor changes

* CLICKHOUSEDOCS-635: Updated the description.

Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
Co-authored-by: Evgenia Sudarikova <56156889+otrazhenia@users.noreply.github.com>
2020-07-02 10:25:06 +03:00
Alexander Kuzmenkov
41088c3416 Merge remote-tracking branch 'origin/master' into HEAD 2020-07-02 10:13:11 +03:00
Alexander Kuzmenkov
99514a7e24 fixup 2020-07-02 10:13:02 +03:00
Alexander Kuzmenkov
f90a7c03bd
Merge pull request #12063 from ClickHouse/aku/changelog-20.3.11
Changelog for 20.3.11, 12
2020-07-02 09:20:08 +03:00
alesapin
cf306c5be1 bump ci 2020-07-01 23:29:39 +03:00
alesapin
f0b012c94b Remove garbage from images 2020-07-01 23:07:11 +03:00
alesapin
29178a1df4 Don't download image twice 2020-07-01 21:51:11 +03:00
alesapin
faaf3536ea Update deb image 2020-07-01 18:00:07 +03:00
Vitaly Baranov
811d124a82
Merge pull request #12002 from vitlibar/fix-partial-revokes
Fix partial revokes
2020-07-01 17:15:01 +03:00
BohuTANG
f0e715ade1
[docs] Sync zh/development/build-osx.md from EN (#12071) 2020-07-01 17:08:01 +03:00
Nicolae Vartolomei
3854ce6d84 Rewrite Set lookup to make it more readable 2020-07-01 15:05:54 +01:00
Nicolae Vartolomei
f8ceca6942 Remove const specifier to allow auto-move (clangtidy) 2020-07-01 15:04:08 +01:00
BayoNet
41fed28403
DOCS-510: runningAccumulate (#12061)
* asiana21-DOCSUP-797 (#117)

* docs(runningAccumulate): the function description is added

* docs(runningAccumulate): the function description is modified

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* docs(runningAccumulate): some changes

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* docs(runningAccumulate): added ru translation

Co-authored-by: asiana21 <asiana21@yandex-team.ru>
Co-authored-by: BayoNet <da-daos@yandex.ru>

* CLICKHOUSEDOCS-510: Minor fix.

* Update docs/en/sql-reference/functions/other-functions.md

Co-authored-by: Ivan Blinkov <github@blinkov.ru>

* CLICKHOUSEDOCS-510: Fixed links.

Co-authored-by: AsiaKorushkina <43650329+AsiaKorushkina@users.noreply.github.com>
Co-authored-by: asiana21 <asiana21@yandex-team.ru>
Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
Co-authored-by: Ivan Blinkov <github@blinkov.ru>
2020-07-01 16:36:41 +03:00
Nicolae Vartolomei
64bbccb42e Add force_primary_key to a pk in tuple test 2020-07-01 14:25:14 +01:00
BayoNet
03a643e9d3
DOCS-609: max_server_memory_usage (#11771)
* Revolg DOCSUP-1000 add max server memory usage setting (#125)

* Add max_server_memory_usage setting, delete max_memory_usage_for_all_queries setting.

* Syntax fixed

* Apply suggestions from code review

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Doc for the max_server_memory_usage setting. Updates.

Co-authored-by: Olga Revyakina <revolg@yandex-team.ru>
Co-authored-by: BayoNet <da-daos@yandex.ru>

* CLICKHOUSEDOCS-609: Minor fixes.

* CLICKHOUSEDOCS-609: Actualized position of the setting.

Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: Olga Revyakina <revolg@yandex-team.ru>
Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
2020-07-01 16:08:16 +03:00
alesapin
5ef3c95628 Bump 2020-07-01 13:15:39 +03:00
Nicolae Vartolomei
c95d09aed0 Add a test to cover non-const tuple elemenets (just in case) 2020-07-01 11:01:47 +01:00
Vladimir Chebotarev
a541683efa Moved useless S3 logging to TRACE level. 2020-07-01 01:04:30 +03:00
alesapin
4d300abe24 bump ci 2020-06-30 23:43:22 +03:00
Alexander Kuzmenkov
baec4093dd
Merge pull request #11993 from ClickHouse/aku/more-jemalloc-tweaks
jemalloc: set muzzy_decay_ms = 10s
2020-06-30 22:51:21 +03:00
Alexander Kuzmenkov
594fc9247b
Update CHANGELOG.md
Co-authored-by: Ivan Blinkov <github@blinkov.ru>
2020-06-30 22:38:29 +03:00
Ivan Blinkov
e48b6b8f84
[blog] add RSS feed (#12064)
* [blog] add rss feed

* better title
2020-06-30 21:22:07 +03:00
alexey-milovidov
948af0bfc5
Merge pull request #12045 from ClickHouse/fix_loading_of_tables
Parse metadata in parallel when loading tables
2020-06-30 21:16:40 +03:00
Nicolae Vartolomei
b1d2d55cba Add explicit test for a case where AST hashes collide for different prepared sets 2020-06-30 18:19:20 +01:00
alesapin
67d03b6b75 bump CI 2020-06-30 19:35:07 +03:00
Alexander Kuzmenkov
444a869d78 simple changelog script 2020-06-30 19:08:23 +03:00
Alexander Kuzmenkov
af3716f305 Changelog for 20.3.11, 12 2020-06-30 19:04:15 +03:00