Commit Graph

16 Commits

Author SHA1 Message Date
Robert Schulze
fc4288d3ac
Fix FreeBSD build 2023-05-07 06:55:24 +00:00
Robert Schulze
6848eafb39
Cleanup utils build 2023-05-06 17:11:06 +00:00
Antonio Andelic
5de6f86c27 Fix clang-tidy error 2023-02-01 12:28:44 +00:00
Alexander Tokmakov
d8b3a2af84 fix race between INSERT and DROP 2022-11-02 19:26:50 +01:00
Antonio Andelic
540728ab96 Simplify logic a bit 2022-10-18 10:58:25 +00:00
Azat Khuzhin
83dfbe3b9a Fix building keeper-data-dumper
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-29 11:36:51 +03:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_"
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.

As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.

In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).

(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
2022-07-11 19:36:18 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Antonio Andelic
bf1f34ddb3 Fix unit tests 2022-04-06 07:43:48 +00:00
alesapin
8d2750a92a Fix keeper data dumper build 2022-01-24 13:23:58 +03:00
Yuriy Chernyshov
14e7ea6685 Remove remaining usages of Y_IGNORE 2021-11-02 14:41:30 +03:00
Maksim Kita
04047f76c7 Fixed tests 2021-10-14 00:33:18 +03:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
万康
3ef5d13a4a add parameter 2021-09-26 10:12:54 +08:00
Alexander Tokmakov
517ee6f142 rename 2021-03-30 10:45:51 +03:00
alesapin
828e76adb9 Fix keeper util 2021-03-30 10:36:50 +03:00