thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-18 05:32:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
61,058 Commits 9,136 Branches 1,774 Tags 2 GiB
860ed20368
Commit Graph

12008 Commits

Author SHA1 Message Date
Anton Popov
860ed20368 ColumnSparse: more fixes 2021-04-15 05:16:09 +03:00
Anton Popov
236ab68724 ColumnSparse: several fixes 2021-04-14 16:20:05 +03:00
Anton Popov
fac54e9ccc ColumnSparse: unit tests and several fixes 2021-04-13 15:08:24 +03:00
Anton Popov
298251e55d fix merges with sparse columns and disable sparse for some data types 2021-04-12 02:33:53 +03:00
Anton Popov
1df3e26d15 temporarily make all columns sparse 2021-04-08 05:09:41 +03:00
Anton Popov
4b8e90338d ColumnSparse: fixes 2021-04-08 05:08:37 +03:00
Anton Popov
d7ca6ecc50 ColumnSparse: sorting and dummy aggregation 2021-04-06 03:02:48 +03:00
Anton Popov
d46958a8d2 Merge remote-tracking branch 'upstream/master' into HEAD 2021-04-06 00:54:49 +03:00
Anton Popov
c5354885a6
Merge pull request #22654 from azat/log-nested-fix 
[RFC] Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause
 2021-04-06 00:34:58 +03:00
Maksim Kita
de71553c9d
Merge pull request #22593 from zlobober/introduce_distributed_write 
Introduce IStorage::distributedWrite method for distributed INSERT SELECTS
 2021-04-05 22:59:57 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause 
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
 2021-04-05 08:48:04 +03:00
alexey-milovidov
6cefb8e620
Merge pull request #22583 from azat/log-rwlock-ub-fix 
Avoid UB in *Log engines for rwlock unlock due to unlock from another thread
 2021-04-05 05:20:16 +03:00
alexey-milovidov
f78c846bdf
Merge pull request #22591 from nvartolomei/nv/out-init-check 
Try flush write buffer only if it is initialized
 2021-04-05 04:32:54 +03:00
Maxim Akhmedov
725fa17961 Introduce IStorage::distributedWrite method for distributed INSERT SELECT. 2021-04-05 02:14:27 +03:00
Alexey Milovidov
e50d82ab45 Merge branch 'master' into change-accurate-comparison 2021-04-05 01:38:55 +03:00
Alexey Milovidov
6e93d936d3 Highlight potential bugs in code 2021-04-05 01:38:47 +03:00
alexey-milovidov
b1e7624b3f
Merge pull request #22589 from ClickHouse/fix-comments 
Fix comments
 2021-04-05 00:22:27 +03:00
alexey-milovidov
c0a13bb5d2
Merge pull request #22586 from ClickHouse/minor-improvement-deserialize-index 
Minor improvement in index deserialization
 2021-04-05 00:20:29 +03:00
alesapin
caaa19edb8
Merge pull request #22373 from ClickHouse/jepsen_for_ci 
Add image to run jepsen tests
 2021-04-04 18:35:21 +03:00
Anton Popov
0d03b8c0c4
Merge pull request #21889 from CurtizJ/fix-aggregation-in-order-1 
Fix bugs in aggregation by primary key
 2021-04-04 18:17:04 +03:00
alesapin
76d0e60e26 Merge branch 'master' into jepsen_for_ci 2021-04-04 16:07:53 +03:00
alexey-milovidov
0e1035735c
Merge pull request #22565 from ClickHouse/fix-assert-arena 
Fix assert in Arena when doing GROUP BY Array of Nothing of non-zero size.
 2021-04-04 15:38:17 +03:00
alexey-milovidov
72cf7b01e8
Merge pull request #22571 from mastertheknife/allow_unbundled_xz_lzma 
Allow building with unbundled xz
 2021-04-04 15:36:45 +03:00
Alexey Milovidov
32f9a407ff More precise and safe accurate comparison of int vs. float 2021-04-04 14:49:48 +03:00
Maksim Kita
0bfb429c42
Merge pull request #22479 from kitaisreal/clickhouse-dictionary-source-loop-fix 
ClickHouseDictionarySource loop fix
 2021-04-04 13:29:17 +03:00
Azat Khuzhin
44abb7588a StorageStripeLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
89a96cf14d StorageLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5d795661ed StorageTinyLog: add regression test for UB due to unlock from different thread 
Refs: #22560
 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5ced6e2e9a StorageStripeLog: drop mutable qualifier for rwlock 2021-04-04 13:25:43 +03:00
Azat Khuzhin
5ef845af40 StorageLog: drop mutable qualifier for rwlock 2021-04-04 13:25:43 +03:00
Alexey Milovidov
d67ced585a Fix engrish 2021-04-04 13:09:39 +03:00
Nicolae Vartolomei
49abdeb967 Try flush write buffer only if it is initialized 
Fixes #22579
 2021-04-04 12:59:51 +03:00
Alexey Milovidov
54caa61af5 Fix comments 2021-04-04 12:33:06 +03:00
Alexey Milovidov
8b5d0a598f Minor improvement in index deserialization 2021-04-04 12:17:54 +03:00
Alexey Milovidov
a0f2b85cd3 Make round function to behave consistently on non-x86_64 2021-04-04 05:21:56 +03:00
alexey-milovidov
b35ba1152f
Update IColumnDummy.h 2021-04-04 05:04:11 +03:00
Maksim Kita
b9e8ff137a Fixed build 2021-04-04 01:19:57 +03:00
mastertheknife
65ca073f42 Allow unbundled xz (lzma) using USE_INTERNAL_XZ_LIBRARY=OFF 2021-04-04 01:05:07 +03:00
alexey-milovidov
cb4e119c3d
Merge pull request #22561 from traceon/apple-clang-compilation-fix 
AppleClang compilation fix
 2021-04-04 00:25:58 +03:00
Alexey Milovidov
3050486308 Fix assert in Arena 2021-04-03 22:50:49 +03:00
alexey-milovidov
67fdfd4b89
Merge pull request #22560 from azat/tiny-log-rwlock-ub-fix 
Fix UB by unlocking the rwlock of the TinyLog from the same thread
 2021-04-03 21:59:01 +03:00
Denis Glazachev
36b03b2740 Compilation fix 2021-04-03 22:17:51 +04:00
Azat Khuzhin
6cebd3ee1f Fix UB by unlocking the rwlock of the TinyLog from the same thread 
Before this patch the build with libstdc++ hangs for
00967_insert_into_distributed_different_types test (and I guess some
others), this is because the rwlock is acquired from different thread as
it was unlocked which causes UB [1], fix this by moving unlock into
writeSuffix().

  [1]: The pthread_rwlock_unlock() function shall release a lock held on
       the read-write lock object referenced by rwlock. Results are undefined
       if the read-write lock rwlock is not held by the **calling thread**.
 2021-04-03 16:04:39 +03:00
Azat Khuzhin
10d35867e3 Drop mutable qualifier for StorageTinyLog::rwlock 2021-04-03 16:03:17 +03:00
alexey-milovidov
30ece2c28f
Merge pull request #22510 from vdimir/merge-join-lc-bug-fix 
Convert right block to full in MergeJoin
 2021-04-03 12:54:34 +03:00
alexey-milovidov
143f4b59a0
Merge pull request #22527 from ClickHouse/fix-missing-nl-parse-tsv 
Fix deserialization of empty string without newline at end of TSV format
 2021-04-03 12:51:10 +03:00
alexey-milovidov
2de808ec5a
Update SerializationNullable.cpp 2021-04-03 12:50:57 +03:00
alexey-milovidov
687d1e9b54
Merge pull request #22528 from kitaisreal/format-settings-null-as-default-default-value-fix 
FormatSettings null_as_default default value fix
 2021-04-03 12:49:08 +03:00
Anton Popov
0d1ac1fec3 ColumnSparse: sorting 2021-04-03 05:40:30 +03:00
Anton Popov
a78f531597 ColumnSparse: fixes 2021-04-03 03:04:48 +03:00