thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-13 18:02:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
115,133 Commits 9,328 Branches 1,783 Tags 2.1 GiB
86e14547d4
Commit Graph

1366 Commits

Author SHA1 Message Date
Alexey Milovidov
9e46abc560
Merge pull request #39420 from amosbird/better-projection1-fix1 
Normalize AggregateFunction types and state representations
 2022-08-04 03:06:55 +03:00
Amos Bird
b98e645ff7
Revert "test what will be wrong if state returns norm type" 
This reverts commit 55802099bc.
 2022-08-02 11:33:45 +08:00
Amos Bird
c8aaa32f9c
Revert "Another test" 
This reverts commit 69347028c5.
 2022-08-02 10:43:48 +08:00
Amos Bird
69347028c5
Another test 2022-08-02 03:08:25 +08:00
Amos Bird
55802099bc
test what will be wrong if state returns norm type 2022-08-01 21:04:16 +08:00
Amos Bird
09c99d8440
Fix tests 2022-08-01 21:04:14 +08:00
Amos Bird
0e746c1afa
More format refactor 2022-08-01 21:04:13 +08:00
Amos Bird
f11d0484f3
Normalize everything else 2022-08-01 21:04:11 +08:00
BiteTheDDDDt
cb68180cdf fix align of AggregateFunctionDistinct 2022-07-29 15:22:03 +08:00
Bharat Nallan
a48f181d21
Update src/AggregateFunctions/AggregateFunctionQuantile.cpp 
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
 2022-07-28 08:55:57 -07:00
Nikolai Kochetov
91043351aa Fixing build. 2022-07-20 20:30:16 +00:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef 
- to be replaced by std::string_view
- suggested in #39262
 2022-07-17 17:26:02 +00:00
Robert Schulze
deda29b46b
Pass const StringRef by value, not by reference 
See #39224
 2022-07-15 11:34:56 +00:00
bharatnc
46129a9bcd try simplifying limit checks 2022-07-13 17:52:50 -07:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_" 
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.

As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.

In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).

(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
 2022-07-11 19:36:18 +02:00
Bharat Nallan Chakravarthy
054ce6f712 rename func to quantileInterpolatedWeighted 2022-07-09 14:02:39 +05:30
Bharat Nallan Chakravarthy
f4488dfee1 Merge remote-tracking branch 'upstream/master' into ncb/weighted-quantile-approx 2022-07-09 13:45:00 +05:30
Nikolai Kochetov
b262ca7dd6 Refactoring 2022-07-08 22:04:56 +00:00
Nikolai Kochetov
8b56695073 Review fixes. 2022-07-08 14:46:11 +00:00
Nikolai Kochetov
19c7a70dcb Check args. 2022-07-07 20:45:46 +00:00
Nikolai Kochetov
3788122f43 Update AggregateFunctionFlameGraph 2022-07-07 14:33:20 +00:00
Nikolai Kochetov
dcdf2e4527 Track allocation ptr in system.trace_log. Add aggregate function for flamegraph. 2022-07-07 11:54:41 +00:00
Alexey Milovidov
bfc9ed6172
Merge pull request #38722 from ClickHouse/fix-rank-corr-functions 
Fix a bug in `rankCorr` function
 2022-07-03 20:30:32 +03:00
Azat Khuzhin
4375a336fd Fix use-after-free for Map combinator that leads to incorrect result 
This use-after-free can be reproduced with distributed queries.

Also note, that this is not sumMappedArray() and friends (that
previously called sumMap()) but Map combinator.

You will find ASan report in details.

<details>

    READ of size 8 at 0x62d00012d218 thread T186 (QueryPipelineEx)
    2022.07.03 05:09:40.000234 [ 31956 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 1.23 GiB, peak 1.23 GiB, will set to 1.25 GiB (RSS), difference: 19.51 MiB
    2022.07.03 05:09:41.000137 [ 31956 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 1.25 GiB, peak 1.25 GiB, will set to 1.26 GiB (RSS), difference: 3.76 MiB
        #0 0x1233a0d8 in DB::AggregateFunctionSumData<>::get() const build_docker/../src/AggregateFunctions/AggregateFunctionSum.h:245:16
        #1 0x1233a0d8 in DB::AggregateFunctionSum<>::insertResultInto(char*, DB::IColumn&, DB::Arena*) const build_docker/../src/AggregateFunctions/AggregateFunctionSum.h:536:70
        #2 0x1470f910 in DB::AggregateFunctionMap<char8_t>::insertResultInto() const build_docker/../src/AggregateFunctions/AggregateFunctionMap.h:236:26
        #3 0x147110ce in DB::IAggregateFunctionHelper<>::insertResultIntoBatch() const build_docker/../src/AggregateFunctions/IAggregateFunction.h:618:53
        #4 0x2c4269d7 in void DB::Aggregator::convertToBlockImplFinal<>() const build_docker/../src/Interpreters/Aggregator.cpp:1878:49
        #5 0x2c403b9f in void DB::Aggregator::convertToBlockImpl<>() const build_docker/../src/Interpreters/Aggregator.cpp:1714:13
        #6 0x2be09b53 in DB::Aggregator::prepareBlockAndFillSingleLevel() const::$_2::operator()() const build_docker/../src/Interpreters/Aggregator.cpp:2144:9
        #7 0x2be09b53 in DB::Block DB::Aggregator::prepareBlockAndFill<>() const build_docker/../src/Interpreters/Aggregator.cpp:2000:5
        #8 0x2be09b53 in DB::Aggregator::prepareBlockAndFillSingleLevel() const build_docker/../src/Interpreters/Aggregator.cpp:2150:12
        #9 0x2be37de3 in DB::Aggregator::mergeBlocks() build_docker/../src/Interpreters/Aggregator.cpp:3032:17
        #10 0x308c27f8 in DB::MergingAggregatedBucketTransform::transform() build_docker/../src/Processors/Transforms/MergingAggregatedMemoryEfficientTransform.cpp:360:37

    0x62d00012d218 is located 3608 bytes inside of 32768-byte region [0x62d00012c400,0x62d000134400)
    freed by thread T186 (QueryPipelineEx) here:
        #0 0xd701312 in free (/work1/azat/tmp/upstream/clickhouse-asan+0xd701312) (BuildId: b7977aef37e9f720)
        ...
        #8 0x2e3c22eb in DB::ColumnAggregateFunction::~ColumnAggregateFunction() build_docker/../src/Columns/ColumnAggregateFunction.cpp:89:1
        ...
        #18 0xd9fcdd4 in std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> >::~vector() build_docker/../contrib/libcxx/include/vector:401:9
        #19 0x2be373f4 in DB::Aggregator::mergeBlocks() build_docker/../contrib/libcxx/include/__memory/unique_ptr.h
        #20 0x308c27f8 in DB::MergingAggregatedBucketTransform::transform() build_docker/../src/Processors/Transforms/MergingAggregatedMemoryEfficientTransform.cpp:360:37

    previously allocated by thread T186 (QueryPipelineEx) here:
        #0 0xd7015be in malloc (/work1/azat/tmp/upstream/clickhouse-asan+0xd7015be) (BuildId: b7977aef37e9f720)
        #1 0xd85190a in Allocator<false, false>::allocNoTrack(unsigned long, unsigned long) build_docker/../src/Common/Allocator.h:227:27
        #2 0xd988d45 in Allocator<false, false>::alloc(unsigned long, unsigned long) build_docker/../src/Common/Allocator.h:96:16
        #3 0xd988d45 in DB::Arena::MemoryChunk::MemoryChunk(unsigned long, DB::Arena::MemoryChunk*) build_docker/../src/Common/Arena.h:54:64
        #4 0xd98904b in DB::Arena::addMemoryChunk(unsigned long) build_docker/../src/Common/Arena.h:122:20
        #5 0xec9542c in DB::Arena::alignedAlloc(unsigned long, unsigned long) build_docker/../src/Common/Arena.h:171:13
        #6 0x1470f123 in DB::AggregateFunctionMap<char8_t>::deserialize() const build_docker/../src/AggregateFunctions/AggregateFunctionMap.h:205:35

</details>

P.S. Thanks to @den-crane for the reproducer.

Fixes: #35359 (cc @den-crane @dongxiao-yang)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-07-03 12:36:30 +03:00
Alexey Milovidov
7adc87a37d
Merge pull request #38413 from nickitat/cache_values_inside_hash_table_grower 
Precalculate values inside `HashTableGrower`
 2022-07-02 23:30:24 +03:00
Alexey Milovidov
668f06b2db Fix error 2022-07-02 03:40:20 +02:00
Anton Popov
7c721578c7
Merge pull request #38320 from CurtizJ/dynamic-columns-16 
Improve performace of insertion to columns of type JSON
 2022-06-30 14:18:20 +02:00
Nikita Taranov
986ead7358 use old HashTableGrower with *WithStackMemory data structures 2022-06-27 20:34:18 +02:00
Nikita Taranov
abcefeeb41 cleanup 2022-06-25 23:15:59 +02:00
Nikita Taranov
c476427422 stash 2022-06-25 01:27:24 +02:00
Bharat Nallan Chakravarthy
d0bfb4e1f5 handle nan 2022-06-23 23:31:54 +05:30
Bharat Nallan Chakravarthy
33704888e5 try add some numeric limits checks 2022-06-23 20:21:50 +05:30
Bharat Nallan Chakravarthy
4e7f8b0935 try fix fuzzer error 2022-06-23 11:51:19 +05:30
Anton Popov
52db1b35a1 improve performace of insertion to columns of type JSON 2022-06-22 17:45:51 +00:00
Bharat Nallan Chakravarthy
4b727e812c fix tests 2022-06-22 08:23:15 +05:30
Bharat Nallan Chakravarthy
5c878d0ef9 add comments 2022-06-21 19:23:16 +05:30
Bharat Nallan Chakravarthy
ff5a30a1f8 fix tests 2022-06-21 17:51:17 +05:30
Bharat Nallan Chakravarthy
578fd9e60b implement quantileApproximateWeighted 2022-06-21 07:24:30 +05:30
mergify[bot]
670a63865e
Merge branch 'master' into window-function-expression 2022-06-19 22:14:54 +00:00
Maksim Kita
bf6d155170 Aggregate functions added restrict into batch methods 2022-06-15 14:11:10 +02:00
mergify[bot]
9e0d16f21d
Merge branch 'master' into window-function-expression 2022-06-10 15:31:53 +00:00
Nikita Mikhaylov
85a1204e95
Do not calculate integrals in statistical tests (#36953) 2022-06-07 15:39:39 +02:00
zhao zhou
ab131af843 fix format issue 2022-06-06 10:02:21 +08:00
zhao zhou
cd2911d635 Add avx512 support for Aggregate Sum, function unary arithmetic, function comparison 2022-06-06 09:29:47 +08:00
Dmitry Novik
58d79f8eed Support expressions with window functions 2022-06-04 02:01:49 +00:00
Alexey Milovidov
9e3242f186
Merge pull request #37617 from CurtizJ/aggregation-sparse-columns 
Better performance with sparse columns in aggregate functions
 2022-05-29 09:36:07 +03:00
Anton Popov
c39d95e2e6 add perf test 2022-05-28 12:56:38 +00:00
Anton Popov
b2cff26ecf better performace with sparse columns in aggregate functions 2022-05-28 02:22:20 +00:00
Maksim Kita
e6e4b2826d Dynamic dispatch infrastructure style fixes 2022-05-24 14:25:29 +02:00
Robert Schulze
b475fbc9a7
Merge pull request #37300 from ClickHouse/cmake-cleanup-pt3 
Various cmake cleanups
 2022-05-20 10:02:36 +02:00
Maksim Kita
20380fa87b
Merge pull request #37257 from kitaisreal/dynamic-dispatch-infrastructure-for-class-members 
Dynamic dispatch infrastructure for class member functions
 2022-05-16 22:15:10 +02:00
Robert Schulze
43945cea1b
Fixing some warnings 2022-05-16 20:59:27 +02:00
Dmitry Novik
dd1e7b55b8
Merge pull request #37050 from azat/fix-optimize_aggregation_in_order-prefix-Array 
Fix optimize_aggregation_in_order with prefix GROUP BY and *Array aggregate functions
 2022-05-16 17:17:56 +02:00
Maksim Kita
032b5d3fc3 Dynamic dispatch infrastructure for class member functions 2022-05-16 17:05:16 +02:00
Kruglov Pavel
5e34f48a18
Merge pull request #37021 from excitoon-favorites/fixtdigest 
Fixed problem with infs in `quantileTDigest`
 2022-05-16 15:21:59 +02:00
Vladimir Chebotarev
5bbab401c4 Added test. 2022-05-15 22:49:52 +03:00
Vladimir Chebotarev
a114ab7223 Fixed the bug and supported old states. 2022-05-13 22:38:35 +03:00
Vladimir Chebotarev
d519e83a4c Proper work with infinities. 2022-05-13 22:25:57 +03:00
Vladimir Chebotarev
009dd618a6 Draft. 2022-05-12 01:49:08 +03:00
Vladimir Chebotarev
825fc0f30a Fixed TDigest even better. 2022-05-11 20:13:36 +03:00
Azat Khuzhin
323ae98202 Fix optimize_aggregation_in_order with prefix GROUP BY and *Array aggregate functions 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Fixes: #35111
See-also: #37046
 2022-05-09 21:32:40 +03:00
Vladimir Chebotarev
1ec330b80e Fixed problem with infs in quantileTDigest. 2022-05-08 20:31:03 +03:00
Alexey Milovidov
5a750d3305 Merge branch 'master' into revert-group-array-sorted 2022-05-05 00:51:01 +02:00
Dmitry Novik
9be17ef50c
Merge pull request #35111 from azat/optimize_aggregation_in_order-prefix 
Implement partial GROUP BY key for optimize_aggregation_in_order
 2022-05-02 17:49:48 +02:00
Anton Popov
d90caf76bb
Merge pull request #36739 from zhangyifan27/fix_groupBitmapState 
fix `groupBitmapAndState` function on distributed table
 2022-05-02 14:00:24 +02:00
mergify[bot]
7f7d78b001
Merge branch 'master' into revert-group-array-sorted 2022-05-01 10:46:44 +00:00
Alexey Milovidov
d6c0de0d40 Revert "Merge pull request #34055 from palegre-tiny/groupSortedArray" 
This reverts commit f055d7b692, reversing
changes made to 4ec3c35e14.
 2022-04-30 12:29:23 +02:00
Azat Khuzhin
767acd53fb Add ability to pass range of rows to Aggregator 
v2: fix compiled aggregate functions (seek result to row_start)
v3: fix compiled aggregate functions (seek args to row_start)
v4: change signatures for JIT
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-04-29 06:57:55 +03:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
zhangyifan27
2257e57aa5 fix groupBitmapAndState on distributed table 2022-04-29 08:09:00 +08:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes 
Clang tidy fixes
 2022-04-21 16:11:27 +02:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings 
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
 2022-04-20 10:29:05 +02:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains" 
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
 2022-04-18 23:53:11 +02:00
Alexey Milovidov
f6ab2bd523
Merge pull request #36312 from ClickHouse/remove-arcadia 
Remove remaining parts of Arcadia
 2022-04-18 07:02:54 +03:00
Alexey Milovidov
36595e4206
Merge pull request #36320 from ClickHouse/fix-clang-tidy-14 
Fix clang-tidy-14 (part 1)
 2022-04-18 07:02:10 +03:00
Alexey Milovidov
242919eddd Remove abbreviation 2022-04-18 01:02:49 +02:00
Alexey Milovidov
294efeccfe Fix clang-tidy-14 (part 1) 2022-04-16 04:54:04 +02:00
Alexey Milovidov
cbeeb7ec4f Remove Arcadia 2022-04-16 00:20:47 +02:00
Nikolay Degterinsky
f055d7b692
Merge pull request #34055 from palegre-tiny/groupSortedArray 
Add groupSortedArray() function
 2022-03-31 01:20:15 +03:00
Azat Khuzhin
bf4df5c6bb Fix SIGSEGV for build under gcc-11 (due to auto deduction) 
During building with gcc-11 you will got SIGSEGV for building
InterpretersMySQLDDLQuery (and some others), and it is due to endless
recursion:

    (gdb) bt 5
    0  0x00000000010978f2 in structural_comptypes (t1=0x7fde028c7dc8, t2=0x7fde028d1e70, strict=0) at ../../src/gcc/cp/typeck.c:1274
    1  0x00000000011c3f9d in comp_template_parms (parms1=<optimized out>, parms2=<optimized out>) at ../../src/gcc/cp/pt.c:3369
    2  0x0000000001097bd9 in structural_comptypes (t1=0x7fde028c7dc8, t2=0x7fde028d1e70, strict=<optimized out>) at ../../src/gcc/cp/typeck.c:1361
    3  0x00000000011c3f9d in comp_template_parms (parms1=<optimized out>, parms2=<optimized out>) at ../../src/gcc/cp/pt.c:3369
    4  0x0000000001097bd9 in structural_comptypes (t1=0x7fde028c7dc8, t2=0x7fde028d1e70, strict=<optimized out>) at ../../src/gcc/cp/typeck.c:1361
    (gdb) bt -X
    1397454 0x0000000001097bd9 in structural_comptypes (t1=0x7fde028d1540, t2=0x7fde028d27e0, strict=<optimized out>) at ../../src/gcc/cp/typeck.c:1361
    1397455 0x0000000000f2d8b5 in cp_tree_equal (t1=<optimized out>, t2=<optimized out>) at ../../src/gcc/cp/tree.c:4144
    1397456 0x00000000010909cb in template_args_equal (ot=0x7fde028cf578, nt=0x7fde028cfc58, partial_order=<optimized out>) at ../../src/gcc/cp/pt.c:9256
    1397457 0x0000000001090422 in template_args_equal (partial_order=false, nt=0x7fde028cfc58, ot=0x7fde028cf578) at ../../src/gcc/cp/pt.c:9295
    1397458 comp_template_args (oldargs=0x7fde028cf550, newargs=0x7fde028cfc30, oldarg_ptr=0x0, newarg_ptr=0x0, partial_order=false) at ../../src/gcc/cp/pt.c:9285
    1397459 0x00000000010a08f4 in spec_hasher::equal (e1=0x7fde028c95d0, e2=0x7ffd1194e8c0) at ../../src/gcc/cp/pt.c:1726
    1397460 0x0000000001085965 in hash_table<spec_hasher, false, xcallocator>::find_with_hash (this=0x7fde36b7f450, comparable=@0x7ffd1194e8b8: 0x7ffd1194e8c0, hash=<optimized out>) at ../../src/gcc/hash-table.h:936
    1397461 0x0000000001079698 in lookup_template_class_1 (d1=<optimized out>, arglist=0x7fde028cfc30, in_decl=0x0, context=<optimized out>, entering_scope=<optimized out>, complain=3) at ../../src/gcc/cp/pt.c:9896
    1397462 0x000000000109f8ef in lookup_template_class (complain=3, entering_scope=1, context=0x7fde27558e40, in_decl=0x0, arglist=0x7fde028cfc08, d1=0x7fde269bcd20) at ../../src/gcc/cp/pt.c:10251
    1397463 tsubst_aggr_type (t=0x7fde269bcd20, args=<optimized out>, complain=3, in_decl=0x0, entering_scope=1) at ../../src/gcc/cp/pt.c:13646
    1397464 0x000000000108f797 in tsubst (t=0x7fde269bcdc8, args=0x7fde028cf7a8, complain=3, in_decl=<optimized out>) at ../../src/gcc/cp/pt.c:16108
    1397465 0x0000000000e61bf2 in rewrite_template_parm (level=1, complain=3, tsubst_args=0x7fde028cf7a8, index=5, olddecl=0x7fde269b5600) at ../../src/gcc/cp/pt.c:28556
    1397466 rewrite_tparm_list(tree_node*, unsigned int, unsigned int, tree_node*, unsigned int, int) [clone .constprop.0] (oldelt=0x7fde269bd190, index=5, targs=0x7fde028cf7a8, targs_index=4, complain=3, level=1) at ../../src/gcc/cp/pt.c:28640
    1397467 0x00000000009f3748 in build_deduction_guide (type=type@entry=0x7fde26e13dc8, ctor=0x7fde269ac300, outer_args=outer_args@entry=0x0, complain=complain@entry=3) at ../../src/gcc/cp/pt.c:28769
    1397468 0x00000000009f444f in ctor_deduction_guides_for (complain=3, tmpl=<optimized out>) at ../../src/gcc/cp/cp-tree.h:842
    1397469 deduction_guides_for (tmpl=<optimized out>, any_dguides_p=<optimized out>, complain=3) at ../../src/gcc/cp/pt.c:29282
    1397470 0x00000000008507a8 in do_class_deduction (complain=3, flags=1, init=<optimized out>, tmpl=0x7fde26e0f980, ptype=0x7fde028c7b28) at ../../src/gcc/cp/pt.c:29402
    1397471 do_auto_deduction (type=0x7fde028c7b28, init=<optimized out>, auto_node=<optimized out>, complain=3, context=<optimized out>, outer_targs=<optimized out>, flags=1) at ../../src/gcc/cp/pt.c:29572
    1397472 0x00000000007c9569 in finish_compound_literal (type=<optimized out>, compound_literal=0x7fde028c95b8, complain=3, fcl_context=fcl_functional) at ../../src/gcc/cp/semantics.c:3060
    1397473 0x0000000001123a79 in cp_parser_functional_cast (parser=0x7fde27558da8, type=0x7fde028c7b28) at ../../src/gcc/cp/parser.c:30670
    1397474 0x0000000000fd7873 in cp_parser_postfix_expression (parser=0x7fde27558da8, address_p=<optimized out>, cast_p=<optimized out>, member_access_only_p=<optimized out>, decltype_p=false, pidk_return=0x0) at ../../src/gcc/cp/parser.c:7437
    1397475 0x0000000000fd4ddf in cp_parser_binary_expression (parser=0x7fde27558da8, cast_p=<optimized out>, no_toplevel_fold_p=false, decltype_p=<optimized out>, prec=PREC_NOT_OPERATOR, pidk=<optimized out>) at ../../src/gcc/cp/parser.c:9842
    1397476 0x0000000000fd4595 in cp_parser_assignment_expression (parser=0x7fde27558da8, pidk=<optimized out>, cast_p=<optimized out>, decltype_p=<optimized out>) at ../../src/gcc/cp/parser.c:10146
    1397477 0x0000000000fd3b90 in cp_parser_constant_expression (parser=0x7fde27558da8, allow_non_constant_p=2, non_constant_p=0x7ffd1194f1d7, strict_p=<optimized out>) at ../../src/gcc/cp/parser.c:10449
    1397478 0x0000000000fcfdd5 in cp_parser_initializer_clause (non_constant_p=<optimized out>, parser=0x7fde27558da8) at ../../src/gcc/cp/parser.c:24253
    1397479 cp_parser_initializer (parser=0x7fde27558da8, is_direct_init=<optimized out>, non_constant_p=<optimized out>, subexpression_p=<optimized out>) at ../../src/gcc/cp/parser.c:24193
    1397480 0x000000000062e5d8 in cp_parser_decomposition_declaration (init_loc=0x7ffd1194f1d8, maybe_range_for_decl=0x7ffd1194f498, decl_specifiers=0x7ffd1194f1f0, parser=0x7fde27558da8) at ../../src/gcc/cp/parser.c:14734
    1397481 cp_parser_simple_declaration (parser=0x7fde27558da8, function_definition_allowed_p=<optimized out>, maybe_range_for_decl=0x7ffd1194f498) at ../../src/gcc/cp/parser.c:14393
    1397482 0x000000000109b870 in cp_parser_init_statement (parser=0x7fde27558da8, decl=0x7ffd1194f498) at ../../src/gcc/cp/parser.c:13420
    1397483 0x00000000010996f0 in cp_parser_for (unroll=0, ivdep=false, parser=0x7fde27558da8) at ../../src/gcc/cp/parser.c:12708
    1397484 cp_parser_iteration_statement (parser=0x7fde27558da8, if_p=0x0, ivdep=<optimized out>, unroll=<optimized out>) at ../../src/gcc/cp/parser.c:13343
    1397485 0x0000000000fe5c46 in cp_parser_statement (parser=0x7fde27558da8, in_statement_expr=0x0, in_compound=<optimized out>, if_p=0x0, chain=0x0, loc_after_labels=0x0) at ../../src/gcc/cp/parser.c:11718
    1397486 0x0000000000fe15ac in cp_parser_statement_seq_opt (in_statement_expr=<optimized out>, parser=<optimized out>) at ../../src/gcc/cp/parser.c:12201
    1397487 cp_parser_compound_statement (parser=0x7fde27558da8, in_statement_expr=0x0, bcs_flags=<optimized out>, function_body=<optimized out>) at ../../src/gcc/cp/parser.c:12150

Interesting frame is 1397471, from which we can extract location:

    (gdb) p line_table[0].info_ordinary.maps[line_table[0].info_ordinary.cache]
    $54 = {
      <line_map> = {
        start_location = 1396581280
      },
      members of line_map_ordinary:
      reason = LC_RENAME,
      sysp = 0 '\000',
      m_column_and_range_bits = 8,
      m_range_bits = 0,
      to_file = 0x3eb4bb0 "/ch/src/Interpreters/MySQL/InterpretersMySQLDDLQuery.cpp",
      to_line = 46,
      included_from = 0
    }

By replicating SOURCE_LINE() macro from gcc-11 (libcpp/include/line-map.h):

    /* Converts a map and a location_t to source line.  */
    inline linenum_type
    SOURCE_LINE (const line_map_ordinary *ord_map, location_t loc)
    {
      return ((loc - ord_map->start_location)
          >> ord_map->m_column_and_range_bits) + ord_map->to_line;
    }

We got line 154:

    (gdb) p ((input_location-1396581280) >> 8) + 46
    $61 = 154

And this is:

    auto [column_name_and_type, declare_column_ast] = std::tuple{columns_name_and_type.begin(), columns_definition->children.begin()};

After rewriting it, everything works correctly.

Also here is a reproducer for gcc-11 (and no failures for gcc-12, but
gcc-12 has other issues, like [1] and one more for hash table):

    # cat /tmp/test.cpp
    #include <tuple>

    auto multi()
    {
            return std::tuple{1, 1};
    }
    double foo()
    {
            auto [a, b] = multi();
            return a - b;
    }

    # g++-11 -std=gnu++20 -c -o /dev/null -isystem /ch/contrib/libcxx/include -nostdinc++ /tmp/test.cpp
    g++-11: internal compiler error: Segmentation fault signal terminated program cc1plus
    Please submit a full bug report,
    with preprocessed source if appropriate.
    See <file:///usr/share/doc/gcc-11/README.Bugs> for instructions.
    # g++-12 -std=gnu++20 -c -o /dev/null -isystem /ch/contrib/libcxx/include -nostdinc++ /tmp/test.cpp

  [1]: https://reviews.llvm.org/D122598

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-03-28 22:21:45 +03:00
mergify[bot]
5df84df596
Merge branch 'master' into groupSortedArray 2022-03-21 13:35:06 +00:00
Robert Schulze
b56c28d841
Replace a few uses of enable_if for SFINAE by concepts 
- enable_if is usually regarded as fragile and unreadable

- C++20 concepts are much easier to read and produce more expressive
  error messages
 2022-03-16 19:51:38 +01:00
Maksim Kita
3ca40d5d2e Fixed style check 2022-03-14 18:17:35 +00:00
Maksim Kita
5cf0e0c0f3 Fixed build 2022-03-14 18:17:35 +00:00
Maksim Kita
5147da3355 Fix clang-tidy warnings in AggregateFunction folder 2022-03-14 18:17:35 +00:00
Robert Schulze
6fc6d3d452
Remove runtime conditional using constexpr if 2022-03-12 10:41:15 +01:00
Robert Schulze
85ce4a9bea
Use C++14 aliases for some type traits 2022-03-11 15:54:29 +01:00
Hongbin
99bd56e2de
Fix some code comments style 2022-02-28 08:15:37 +08:00
mergify[bot]
cd6f1d8fa4
Merge branch 'master' into groupSortedArray 2022-02-25 11:45:48 +00:00
Pablo Alegre
74f99f7365 fixup! fixup! Add groupSortedArray() function 2022-02-24 16:16:56 +01:00
Raúl Marín
8137f13fcd Improve ANY performance by acting over batches 2022-02-20 02:43:28 +01:00
Pablo Alegre
9466aafb3c fixup! Add groupSortedArray() function 2022-02-15 14:48:20 +01:00
mergify[bot]
aab54f4c83
Merge branch 'master' into groupSortedArray 2022-02-14 12:47:48 +00:00
Pablo Alegre
3e537a7118 fixup! Evolve to TinySum 2022-02-11 18:33:01 +01:00
Pablo Alegre
c65eaa5c09 fixup! Evolve to TinySum 2022-02-11 10:28:35 +01:00
Pablo Alegre
1e4b504ae2 fixup! Add groupSortedArray() function 2022-02-10 16:49:28 +01:00
Pablo Alegre
de7bbc720c fixup! Add groupSortedArray() function 
fixup! Add groupSortedArray() function

fixup! Add groupSortedArray() function
 2022-02-10 16:24:41 +01:00
Rajkumar
45d903b3b5 clang-tidy reported divide by zero exception 2022-02-09 11:28:08 -08:00
Pablo Alegre
9c38b1a031 fixup! Add groupSortedArray() function 2022-02-08 01:52:08 +01:00
Maksim Kita
f301e50b23 Fixed tests 2022-02-04 19:52:18 +00:00
Pablo Alegre
7f553d55ae fixup! Add groupSortedArray() function 
- Fix memory access
- Support any type as sorting parameter
- Fix tests
- Rewrite/simplify function addBatchSinglePlace
 2022-02-04 15:53:42 +01:00
Nikolai Kochetov
cf8c76f859
Merge pull request #33260 from achimbab/ttest_confidence_intervals 
Add confidence intervals to ttests
 2022-02-04 11:02:47 +03:00
Danila Kutenin
c90b1f7794 Optimize quantilesExact{Low,High} to use nth_element instead of sort 2022-02-03 12:24:33 +00:00
Nikolai Kochetov
8f49f62a3c Just a tiny fix. 2022-02-03 13:53:00 +03:00
achimbab
b3f63965cc
Merge branch 'ClickHouse:master' into ttest_confidence_intervals 2022-02-01 22:24:56 +09:00
Maksim Kita
5ef83deaa6 Update sort to pdqsort 2022-01-30 19:49:48 +00:00
achimbab
9822b7dfc9 Handle exceptional case where data are essentially constant. 2022-01-31 02:25:51 +09:00
achimbab
3f878b9cf6 Fix floating point comparison 2022-01-30 22:57:30 +09:00
Maksim Kita
b618febdec
Merge pull request #33970 from amosbird/fixwerror 
Fix missing -Werror flag
 2022-01-28 16:53:09 +01:00
Maksim Kita
60129aaecb
Merge pull request #34052 from kitaisreal/remove-decimal-padded-pod-array 
Remove DecimalPaddedPODArray
 2022-01-28 15:54:41 +01:00
Azat Khuzhin
bfef9663ca Tiny cleanup of AggregateFunctionSimpleState/AggregateFunctionState 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-28 08:10:08 +03:00
mergify[bot]
ebbfc0fd2f
Merge branch 'master' into remove-decimal-padded-pod-array 2022-01-27 20:12:41 +00:00
Raúl Marín
91878b97e4
Address AggregateFunctionIf.cpp warnings 
/mnt/ch/ClickHouse/src/AggregateFunctions/AggregateFunctionIf.cpp:75:79: warning: declaration shadows a field of 'AggregateFunctionIfNullUnary<result_is_nullable, serialize_flag>' [-Wshadow]
    inline bool singleFilter(const IColumn ** columns, size_t row_num, size_t num_arguments) const
                                                                              ^
/mnt/ch/ClickHouse/src/AggregateFunctions/AggregateFunctionIf.cpp:53:12: note: previous declaration is here
    size_t num_arguments;
           ^
 2022-01-28 02:07:42 +08:00
Azat Khuzhin
4e4e70ec6e Fix leak in SimpleState function (due to recrusive reference) 
CI reports [1]:

    Indirect leak of 648 byte(s) in 9 object(s) allocated from:
    ...
        2 0x12b96503 in DB::AggregateFunctionSimpleState::getReturnType() const obj-x86_64-linux-gnu/../src/AggregateFunctions/AggregateFunctionSimpleState.h:47:15
    ...

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/33957/08f4f45fd9da923ae3e3fdd8a527c297d35247eb/stress_test__address__actions_.html

After we can get this query by using query_log artifact:

    $ wget https://s3.amazonaws.com/clickhouse-test-reports/33957/08f4f45fd9da923ae3e3fdd8a527c297d35247eb/stress_test__address__actions_/query_log_dump.tar
    $ tar -xf query_log_dump.tar
    $ clickhouse-local --path var/lib/clickhouse/
    SELECT query
    FROM system.query_log
    ARRAY JOIN used_aggregate_function_combinators AS func
    WHERE has(used_aggregate_functions, 'groupBitOr') AND has(used_aggregate_function_combinators, 'SimpleState') AND (type != 'QueryStart')

    Query id: 5b7722b3-f77e-4e7e-bd0b-586d6d32a899

    ┌─query────────────────────────────────────────────────────────────────────────────┐
    │ with groupBitOrSimpleState(number) as c select toTypeName(c), c from numbers(1); │
    └──────────────────────────────────────────────────────────────────────────────────┘

Fixes: 01570_aggregator_combinator_simple_state.sql
Fixes: #16853
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-27 15:23:04 +03:00
Pablo Alegre
e813f6413f Add groupSortedArray() function 2022-01-27 12:22:59 +01:00
Maksim Kita
af5ad2f370 Remove DecimalPaddedPODArray 2022-01-27 10:07:53 +00:00
achimbab
8c52b45482
Merge branch 'ClickHouse:master' into ttest_confidence_intervals 2022-01-24 22:56:05 +09:00
Alexey Milovidov
58bb1ffecf Shortcut 2022-01-24 08:29:17 +03:00
achimbab
5d70734132
Merge branch 'master' into ttest_confidence_intervals 2022-01-24 11:57:56 +09:00
Alexey Milovidov
4d30e6eab6 Fix aggregate function combinator -If with Nullable filter argument 2022-01-23 08:27:29 +03:00
achimbab
779538bd89
Implemented meanZTest (#33354) 2022-01-20 16:57:37 +03:00
Azat Khuzhin
f1cc63d900 Remove unbundled cityhash support 2022-01-20 10:01:12 +03:00
achimbab
9761b7ead2 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into ttest_confidence_intervals 2022-01-18 19:46:11 +09:00
achimbab
5bad86a2f4 Validation of the number of observations in the t-test 2022-01-15 19:33:27 +09:00
achimbab
57441fdb96 Minor fixes 2022-01-06 13:32:09 +09:00
alexey-milovidov
48eec3d8f8
Merge pull request #33366 from ClickHouse/aggregate-dependencies 
Aggregate functions to calculate dependencies between columns
 2022-01-05 02:50:25 +03:00
mergify[bot]
a30c10a235
Merge branch 'master' into interval-length-sum-allow-negative 2022-01-03 20:53:55 +00:00
Alexey Milovidov
7bd4d1a8d8 Fix UBSan 2022-01-03 22:24:03 +03:00
Alexey Milovidov
8aa26fd04a Fix UBSan 2022-01-03 22:23:34 +03:00
Alexey Milovidov
ac84015f01 Make at least some sense 2022-01-03 22:18:57 +03:00
Alexey Milovidov
04a39317c1 Add check 2022-01-03 21:39:04 +03:00
alexey-milovidov
6efe73fc1b
Merge pull request #26559 from nikitamikhaylov/merging-dev-sum-bug 
Merging #26074
 2022-01-03 19:46:54 +03:00
alexey-milovidov
0c5485fd3a
Update AggregateFunctionContingencyCoefficient.cpp 2022-01-03 16:45:15 +03:00
alexey-milovidov
8608dbb8e7
Fix CLion 2022-01-03 16:45:02 +03:00
alexey-milovidov
bc1ac93d4d
Update AggregateFunctionNothing.cpp 2022-01-03 14:19:16 +03:00
achimbab
eae38c0ac0 Remove virtual dispatch in constructor 2022-01-03 10:48:47 +09:00
alexey-milovidov
7feed04c9a
Update AggregateFunctionNothing.h 2022-01-03 03:59:45 +03:00
alexey-milovidov
fbadbc8cba
Update AggregateFunctionNothing.h 2022-01-03 03:59:29 +03:00
alexey-milovidov
bd002a6d50
Update AggregateFunctionNothing.cpp 2022-01-03 03:58:18 +03:00
alexey-milovidov
141696e146
Update AggregateFunctionNothing.cpp 2022-01-03 03:53:39 +03:00
alexey-milovidov
f0d2838a5b
Update AggregateFunctionNothing.h 2022-01-03 03:52:39 +03:00
Alexey Milovidov
4ebc8918a4 Fix style 2022-01-03 02:11:47 +03:00
Alexey Milovidov
cd08a7ced0 Fix error 2022-01-03 01:36:55 +03:00
Alexey Milovidov
93bd1771cc Fix error 2022-01-02 23:52:55 +03:00
Alexey Milovidov
cf66716cd6 Make it less wrong 2022-01-02 22:42:56 +03:00
Alexey Milovidov
4a094c2efd Merging contingency coefficients 2022-01-02 21:50:41 +03:00
Alexey Milovidov
9dc66e1e72 Merge branch 'CramersV' of github.com:antikvist/ClickHouse into aggregate-dependencies 2022-01-02 20:29:47 +03:00
Alexey Milovidov
c409c8a361 Change my mind 2022-01-02 20:20:12 +03:00
Alexey Milovidov
6de989f5fa Allow negative intervals in function intervalLengthSum 2022-01-02 20:19:56 +03:00
achimbab
9359a4abd4 Validate the parameter 2022-01-01 19:45:55 +09:00
achimbab
316f6986cf Replaced the stat library with the boost library. 2021-12-30 07:24:07 +09:00
achimbab
760288590b Add confidence intervals to ttests 2021-12-28 23:49:51 +09:00
Nikita Mikhaylov
6d0881ead6 Fix 2021-12-24 14:00:36 +00:00
freedomDR
fbddbebca8 fix bitmapData rb_contain rb_remove 2021-12-24 06:21:13 +00:00
Nikita Mikhaylov
0d463ffc2d Fix build 2021-12-23 15:59:00 +00:00
Nikita Mikhaylov
768c746fe4
Merge branch 'master' into merging-dev-sum-bug 2021-12-23 11:52:06 +03:00
Maksim Kita
51477adf1b Updated additional cases 2021-12-20 15:55:07 +03:00
alexey-milovidov
d3a1ffd05d
Merge pull request #32529 from dmthuc/fix_groupBitmapAnd_function_distributed_table 
fix groupBitmapAnd function on distributed table
 2021-12-19 08:28:26 +03:00
Vladimir C
778cd76987
Merge pull request #32914 from vdimir/issue_32487 2021-12-18 10:18:51 +03:00
alexey-milovidov
8571501cf7
Update AggregateFunctionTopK.cpp 2021-12-18 07:49:35 +03:00
Dao
2fb554c61f increase version to resolve conflict with master branch 2021-12-17 23:09:08 +08:00
vdimir
1eb032ac83
Style AggregateFunctionTopK.cpp 2021-12-17 18:04:59 +03:00
minhthucdao
001900655e
Merge branch 'master' into fix_groupBitmapAnd_function_distributed_table 2021-12-17 23:03:47 +08:00
Dao
52af96627c introduce new version and add test 2021-12-17 22:59:02 +08:00
vdimir
5c487b3bdc
Fix types for topKWeightedState 2021-12-17 17:54:12 +03:00
Anton Popov
16312e7e4a Merge remote-tracking branch 'upstream/master' into HEAD 2021-12-14 18:58:17 +03:00
mergify[bot]
f5e2c38452
Merge branch 'master' into fix_groupBitmapAnd_function_distributed_table 2021-12-13 09:18:45 +00:00
Azat Khuzhin
837ff82312 Suppress UBSan errors for avg() function 
CI: https://s3.amazonaws.com/clickhouse-test-reports/0/dd2ccd3b17e7c59ed9c8184f00f8dae85ee87d1f/fuzzer_astfuzzerubsan,actions//report.html
 2021-12-10 22:23:39 +03:00
Dao
505fbc78c7 fix groupBitmapAnd function on distributed table 2021-12-11 00:18:11 +08:00
Anton Popov
d8367334a3 Merge remote-tracking branch 'upstream/master' into HEAD 2021-12-08 18:26:19 +03:00
tavplubix
6c16348faa
Fix division by zero in avgWeighted with Decimal argument (#32303) 
* fix division by zero

* Update src/AggregateFunctions/AggregateFunctionAvg.h

Co-authored-by: Dmitry Novik <n0vik@clickhouse.com>

* remove trash

* Update AggregateFunctionAvg.h

Co-authored-by: Dmitry Novik <n0vik@clickhouse.com>
 2021-12-07 13:32:26 +03:00
kssenii
5a273d4dda Update version 2021-12-02 08:02:07 +00:00
kssenii
8edf146687 Merge branch 'master' of github.com:ClickHouse/ClickHouse into versioning 2021-12-02 07:57:14 +00:00
kssenii
95f0cd47eb Fixes 2021-12-01 21:34:32 +00:00
Anton Popov
54f51444c0 Merge remote-tracking branch 'upstream/master' into HEAD 2021-12-01 15:49:02 +03:00
kssenii
71bfc72e37 Fix 2021-11-30 14:42:37 +00:00
Raúl Marín
f3a22166a1 Merge remote-tracking branch 'blessed/master' into speedup_avg_sumcount 2021-11-29 19:50:28 +01:00
kssenii
d81fd72895 Fix 2021-11-29 09:35:38 +00:00
Vladimir C
7a356bee44
Merge pull request #31806 from Algunenano/speedup_count 2021-11-29 10:48:40 +03:00
kssenii
be3b4ca8fe Merge branch 'master' of github.com:ClickHouse/ClickHouse into versioning 2021-11-27 09:44:31 +00:00
kssenii
515261f5dd Better 2021-11-27 09:40:46 +00:00
alexey-milovidov
d51cf591ed
Merge branch 'master' into CramersV 2021-11-27 00:47:40 +03:00
Raúl Marín
91bf938075 Reduce dependencies on ASTLiteral.h 
590 -> 537
 2021-11-26 17:54:57 +01:00
Raúl Marín
a22f7c159e Implement AggregateFunctionCountNotNullUnary::addBatchSinglePlace 2021-11-25 16:41:48 +01:00
Raúl Marín
b398a7bab6 Avg: Use countBytesInFilter 2021-11-25 13:50:04 +01:00
Vladimir C
e835671c88
Merge pull request #31624 from nicelulu/fix_sparkbar 2021-11-25 11:01:25 +03:00
zhangxiao871
f8190b7074 Fix min_x max_x and AST Fuzzer check 2021-11-24 23:25:30 +08:00
Raúl Marín
5dd3cc6595 Share code between Avg and SumCount 2021-11-24 13:13:54 +01:00
Raúl Marín
dde264cd53 Implement batching for SumCount 2021-11-24 11:14:31 +01:00
Raúl Marín
d2dcbdd1ee Implement batch operators for avg 2021-11-24 11:14:31 +01:00
tavplubix
7a43a87f5b
Use shard and replica name from Replicated database arguments (#31488) 
* fix another issue

* use shard and replica name from Replicated database

* fix

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-11-23 12:41:54 +03:00
zhangxiao871
5f10159a7d Fix sparkbars are not aligned. 2021-11-22 18:07:08 +08:00
kssenii
1a9817f872 Correct merge 2021-11-18 07:56:10 +00:00
kssenii
37f482d478 Merge branch 'master' of github.com:ClickHouse/ClickHouse into versioning 2021-11-15 07:31:11 +00:00
Anton Popov
66973a2a28 Merge remote-tracking branch 'upstream/master' into HEAD 2021-11-08 21:27:45 +03:00
Yuriy Chernyshov
479ebc0652 Do not include unnecessary experimental/type_traits 2021-11-08 14:16:19 +03:00
Anton Popov
d50137013c Merge remote-tracking branch 'upstream/master' into HEAD 2021-11-01 16:55:53 +03:00
Kruglov Pavel
9f6af8501e
Fix build 2021-11-01 11:58:49 +03:00
mergify[bot]
00b1024d75
Merge branch 'master' into map_combinator 2021-10-29 13:36:47 +00:00
Alexey Milovidov
8b4a6a2416 Remove cruft 2021-10-28 02:10:39 +03:00
Anton Popov
7aa6068fb2 Merge remote-tracking branch 'upstream/master' into HEAD 2021-10-14 19:44:08 +03:00
Mike Kot
8c8bada56e Non-recursive implementation for TL and its functions 2021-10-03 18:02:04 +02:00
Anton Popov
b64bbb54aa
Merge pull request #29203 from CurtizJ/fix-ubsan 
Fix integer underflow in function `quantile`
 2021-10-02 20:36:53 +03:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
Anton Popov
914781052e Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-29 17:37:07 +03:00
bharatnc
0e9af142df Fix one more comment 2021-09-25 18:21:47 -07:00
bharatnc
23b6ac82a7 Fix comments in AggregateFunctionFactory 2021-09-25 18:21:06 -07:00
Alexey Milovidov
cd7f9d981c Remove ya.make 2021-09-25 04:22:54 +03:00
vdimir
db5477e634
Fix style in QuantileTDigest.h 2021-09-24 13:08:46 +03:00
vdimir
58a756da9e
Handle overflow in quantileTDigest 2021-09-24 13:08:45 +03:00
万康
7201b2476e fix spell error 2021-09-22 13:26:05 +08:00
Anton Popov
c48a93a62f fix integer underflow in function 'quantile' 2021-09-20 21:21:40 +03:00
Alexey Milovidov
edb4c58ecc Fix build 2021-09-19 21:13:00 +03:00
Alexey Milovidov
7d24e110e4 Make something with more sense 2021-09-19 20:23:06 +03:00
Anton Popov
eef436fe22 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-16 18:07:42 +03:00
mergify[bot]
a8e9450d91
Merge branch 'master' into exp-smooth 2021-09-15 20:55:32 +00:00
Nikita Mikhaylov
58f2504a56 Update ya.make 2021-09-14 12:00:32 +00:00
alexey-milovidov
b73f71fc06
Merge pull request #28906 from Algunenano/sum_fp 
Improve the performance of SUM of nullable floating point numbers
 2021-09-13 10:55:51 +03:00
alexey-milovidov
1add234900
Update registerAggregateFunctions.cpp 2021-09-13 08:46:12 +03:00
alexey-milovidov
ad997cf51e
Merge branch 'master' into exp-smooth 2021-09-13 07:29:49 +03:00
Nikolay Degterinsky
b02c807346
Merge pull request #27481 from nicelulu/add_sparkbar 
Add sparkbar aggregate function.
 2021-09-12 21:29:24 +03:00
alexey-milovidov
ea13a8b562
Merge pull request #28659 from myrrc/improvement/tostring_to_magic_enum 
Improving CH type system with concepts
 2021-09-12 15:26:29 +03:00
Raúl Marín
893faa8425 Unroll the loop manually 2021-09-12 13:24:25 +02:00
Alexey Milovidov
9ea1d443ba Add exponentialMovingSum aggregate function 2021-09-12 12:26:13 +03:00
Alexey Milovidov
0745631bf7 Add aggregate function for exp smoothing 2021-09-12 08:26:07 +03:00
Raúl Marín
9fb8eeaea3 Use project types 2021-09-11 22:54:30 +02:00
Raúl Marín
940e075941 Remove notNull changes 2021-09-11 22:36:22 +02:00
Raúl Marín
46eb305eec T != Value 2021-09-11 20:46:16 +02:00
Mike Kot
3401b32e37 Adapted usage of is_decimal concept 2021-09-11 19:35:12 +02:00
Raúl Marín
a13b6f2a09 WIP: Speed up sum(floating point) 2021-09-11 15:37:52 +02:00
Mike Kot
bce011cb33 Replacing IsDecimalNumber 2021-09-11 00:40:18 +02:00
Azat Khuzhin
017dc9fa2a Remove unused ILLEGAL_AGGREGATION from AggregateFunctionIf 2021-09-11 00:48:17 +03:00
Azat Khuzhin
c362e7c541 Introduce IAggregateFunctionCombinator::supportsNesting() 2021-09-10 22:41:38 +03:00
Azat Khuzhin
d8bf2f81ec Allow Array/OrNull combinators regardless nesting 2021-09-10 22:35:25 +03:00
Azat Khuzhin
1e7714d56d Forbid nested identical (only) combinators 
Nested identical combinators (i.e. uniqCombinedIfIf) is not
supported (since they even don't work -- silently).

But non-identical does supported and works, for example
uniqCombinedIfMergeIf, it is useful in case when the underlying
storage stores AggregateFunction(uniqCombinedIf) and in SELECT you
need to filter aggregation result based on another column for
example.
 2021-09-10 21:03:24 +03:00
Azat Khuzhin
60df1e8800 Relax nested function for If-combinator check 
Second If combinator can be useful to add condition based on another
column, when Merge combinator is applied for example (i.e.
uniqCombinedIfMergeIf(state_of_merge_that_is_stored_in_table, event_date = today())).
 2021-09-10 21:03:24 +03:00
mergify[bot]
95be9c3571
Merge branch 'master' into add_sparkbar 2021-09-10 10:19:27 +00:00
Anton Popov
8203bd1ac6 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-09 14:04:37 +03:00
alexey-milovidov
4cc0b0298c
Merge pull request #28269 from amosbird/fixweirdcode 
Better nullable primary key implementation
 2021-09-01 00:48:45 +03:00
Anton Popov
268550cc4b
Merge pull request #28272 from Algunenano/faster_sumIF 
Speed up sumIf/countIf
 2021-08-31 15:00:46 +03:00
Raúl Marín
d3d8d4eae6 PVS Studio 2021-08-30 19:37:54 +02:00
Raúl Marín
92799f6cff Make gcc happy 2021-08-30 19:09:04 +02:00
Raúl Marín
11d242cf7d If: Check if work is necessary and combine flags 2021-08-30 14:28:09 +02:00
Raúl Marín
d0f8e2d063 Remove memcpy and use the heap 2021-08-30 13:31:51 +02:00
Kruglov Pavel
95fd6197dc
Merge pull request #27729 from ContentSquare/sequenceMatchQuickCheck 
Sequence match quick check
 2021-08-30 13:04:23 +03:00
zhangxiao871
0cf6506156 reserve for newPoints. 2021-08-30 17:29:25 +08:00
Raúl Marín
5ad8e93458 Speedup sumIf with Nullable types 2021-08-30 10:54:49 +02:00
Raúl Marín
a5c8af1e1b Speed up sumIf 2021-08-30 10:54:49 +02:00
zhangxiao871
a672c63225 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yandex-master 2021-08-30 16:26:24 +08:00
Dmitrii Kovalkov
9871ad70ff Exclude fuzzers 2021-08-30 11:12:25 +03:00
Dmitrii Kovalkov
8acf0fa16a run generate-ya-make 2021-08-30 10:57:40 +03:00
Amos Bird
f2374a6916
Better nullable primary key implementation. 2021-08-28 17:48:28 +08:00
Jakub Kuklis
c60e935830 Adding Format Null to performance test queries, style improvement for the test, additional comments in the code 2021-08-26 16:42:39 +02:00
Vladimir C
0858fdf113
Merge pull request #27036 from nickitat/nickitat_select_filter 2021-08-24 10:18:55 +03:00
RedClusive
1b7fe54f45 Merge branch 'master' of github.com:ClickHouse/ClickHouse into feature-quantileBfloat16 2021-08-22 12:41:11 +00:00
RedClusive
fd7002fcd5 fix weighted 2021-08-21 18:09:42 +00:00
zhangxiao871
3a8199c21e Try fix AST fuzzer (UBSan) check. 2021-08-22 00:28:17 +08:00
achimbab
e4aaa5c52d
Update src/AggregateFunctions/AggregateFunctionWindowFunnel.h 
Co-authored-by: Alexey Boykov <33257111+mathalex@users.noreply.github.com>
 2021-08-21 02:38:27 +09:00
achimbab
a516b8e843
Merge branch 'master' into bugfix_wf_strict 2021-08-21 00:00:13 +09:00
achimbab
f371151e18 Fix docs and comments for windowFunnel and remove strict option 2021-08-20 23:56:28 +09:00
zhangxiao871
4d59e0c8f9 Maybe fix AST fuzzer (UBSan) check. 2021-08-20 20:48:23 +08:00
zhangxiao871
9aadba98cf Better newPoints data struct and rename test. 2021-08-20 18:27:14 +08:00
zhangxiao871
2d47804af3 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yandex-master 2021-08-20 17:25:52 +08:00
Anton Popov
c3c3a06078 Merge remote-tracking branch 'upstream/master' into HEAD 2021-08-20 01:45:38 +03:00
Nikolai Kochetov
3e44ef437e
Merge pull request #26639 from ClickHouse/fix-bad-cast 
Fix bad cast
 2021-08-19 11:17:26 +03:00
zhangxiao871
644a268963 sparkbar map instead of HashMap and some optimize. 2021-08-17 17:28:54 +08:00
Nickita Taranov
3b13b79d65 throw in AggregateFunctionCombinatorIf instead 2021-08-16 12:10:51 +03:00
jkuklis
27e5001e89
Merge branch 'ClickHouse:master' into sequenceMatchQuickCheck 2021-08-16 10:00:52 +02:00
Kseniia Sumarokova
b024c215af
Merge pull request #24757 from zdikov/subquery-operators 
Subquery operators
 2021-08-15 21:33:59 +03:00
zhangxiao871
c7dbd0c297 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yandex-master 2021-08-15 19:53:09 +08:00
zhangxiao871
72ba479b26 Add tests. 2021-08-15 19:50:32 +08:00
kssenii
f125fb3fef Some fixes around any/all 2021-08-14 20:33:03 +03:00
kssenii
47fb923975 Some fixes, more tests 2021-08-13 15:07:44 +03:00
achimbab
9a7cce83b3 Bugfix for windowFunnel's "strict" mode. 2021-08-11 21:08:09 +09:00
Alexey Milovidov
c590a239d5 Merge branch 'master' into fix-bad-cast 2021-08-11 05:48:37 +03:00
Maksim Kita
12149d1ebb
Merge pull request #27234 from DHBin/add_bitmapSubsetOffsetLimit 
add bitmapSubsetOffsetLimit function
 2021-08-10 12:09:56 +03:00
zhangxiao871
deb2c4569f Avoid division by 0 problem. 2021-08-10 16:59:36 +08:00
zhangxiao871
e0f967dde8 Add sparkbar aggregate function. 2021-08-09 23:19:44 +08:00
mergify[bot]
316c254536
Merge branch 'master' into fix-bad-cast 2021-08-08 23:45:19 +00:00
Alexey Milovidov
24cef99065 Merge branch 'master' into fix-bad-cast 2021-08-08 04:00:29 +03:00
kssenii
729eba52ea Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into zdikov-subquery-operators 2021-08-07 15:59:58 +00:00
董海镔
3dcff2124c rename bitmapSubsetOffsetLimit to subBitmap and modify the rb_offset_limit function logic 2021-08-07 18:47:33 +08:00
董海镔
c5beecd0aa update code style 2021-08-06 09:59:18 +08:00
Alexey Milovidov
638b229e27 Remove debug headers 2021-08-05 23:50:09 +03:00
Alexey Milovidov
9a5533a088 Improve performance 2021-08-05 23:44:14 +03:00
Alexey Milovidov
7fa700de00 Merge branch 'master' into roaring-memory-tracker 2021-08-05 22:17:10 +03:00
董海镔
e8b6c0a227 add bitmapSubsetOffsetLimit function 2021-08-06 00:44:07 +08:00
Ildus Kurbangaliev
fd15fc5e4a Fix style errors, disable heterogeneous comparison lookup where it's not supported 2021-08-05 21:10:51 +05:00
Ildus Kurbangaliev
95f5a4d0fa Optimize string keys and fix string serialization in map combinator 2021-08-05 21:10:51 +05:00
Ildus Kurbangaliev
5a5cb238d8 Map combinator: add more arguments checks, fix memory align errors, support more key types, add some docs and tests 2021-08-05 21:10:51 +05:00
Ildus Kurbangaliev
715766d7ec Move validations to transformArguments 2021-08-05 21:10:51 +05:00
Ildus Kurbangaliev
c85aa0a4d6 Fix offsets in insertResultInto for map combinator 2021-08-05 21:10:51 +05:00
Ildus Kurbangaliev
0570c9db3f Fix allocation in Map combinator 2021-08-05 21:10:51 +05:00
Ildus Kurbangaliev
03be2c3133 *MappedArrays will return old name for backwards compability 2021-08-05 21:10:50 +05:00
Ildus Kurbangaliev
030e5e625e add Map combinator 2021-08-05 21:10:50 +05:00
Jakub Kuklis
b9bb2b577b Simplifying couldMatchDeterministicParts 2021-08-05 11:34:39 +02:00
Jakub Kuklis
edac57b08d Correction for style guidelines 2021-08-05 09:34:30 +02:00
Nikita Mikhaylov
8920f98dd4 Added a state to AggregateFunctionNothing 2021-08-04 17:34:02 +00:00
Nikita Mikhaylov
3a00a7f56e Style 2021-08-04 17:34:02 +00:00
Nikita Mikhaylov
276fec96d1 Better code 2021-08-04 17:34:02 +00:00
hexiaoting
1b3fc31904 fix error 2021-08-04 17:34:02 +00:00
hexiaoting
2c7eeea55c Fix bug when using null-AggregateFunction 2021-08-04 17:34:02 +00:00
Jakub Kuklis
3f813e700d Code clearance 2021-08-04 11:03:58 +02:00
Jakub Kuklis
5abf24df9e No sorting if unnecessary 2021-08-04 11:03:58 +02:00
Jakub Kuklis
24db6494de Events conditions met using bitsets 2021-08-04 11:03:58 +02:00
Jakub Kuklis
6a39546e5b Removing default placed after an exhaustive sweep through enum values 2021-08-04 11:03:58 +02:00
Jakub Kuklis
2fad1dd8c5 Adding a break before default in switch 2021-08-04 11:03:58 +02:00
Jakub Kuklis
e3a96cc870 Checking whether all deterministic parts can be matched in the right order in sequenceMatch 2021-08-04 11:03:58 +02:00
Anton Popov
16ed0f6ed4 Merge remote-tracking branch 'upstream/master' into HEAD 2021-08-02 17:55:17 +03:00
kssenii
58b3a3f3fc Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into versioning 2021-07-29 19:56:27 +00:00
tavplubix
4a3ade1aa5
Merge pull request #26814 from ClickHouse/fix_lost_aggregate_function_parameters 
Fix lost parameters of aggregate functions
 2021-07-29 13:43:05 +03:00
Alexander Tokmakov
764701c3f3 allow mismatching parameters for some functions 2021-07-28 20:55:13 +03:00
Alexander Tokmakov
a5d27ba6ad fix another bug 2021-07-27 20:16:40 +03:00
Alexander Tokmakov
304c367912 fix groupUniqArray 2021-07-26 17:57:49 +03:00
Alexander Tokmakov
5c9f69ea17 fix parameters with combinators 2021-07-26 17:37:47 +03:00
Alexey Milovidov
16eba6f0e7 Miscellaneous 2021-07-23 02:22:01 +03:00
Alexey Milovidov
2df3e14559 Attempt to add memory tracking to RoaringBitmaps 2021-07-22 02:56:17 +03:00
Alexander Kuzmenkov
6ae4031723
Merge pull request #26521 from ClickHouse/aku/lag-in-frame-nullable 
fix lagInFrame for nullable types
 2021-07-21 14:10:16 +03:00
Alexander Kuzmenkov
dadf1e192e fix whitespace 2021-07-21 12:38:56 +03:00
Alexander Kuzmenkov
a197511a96 fixes 2021-07-21 01:36:15 +03:00
Amos Bird
9fdae29421
Fix groupBitmapAnd/Or/Xor name 2021-07-20 20:55:18 +08:00
Anton Popov
c4b454494f Merge remote-tracking branch 'upstream/master' into HEAD 2021-07-20 15:41:01 +03:00
Alexander Kuzmenkov
61a01782a6 fix lagInFrame for nullable types 2021-07-19 19:31:57 +03:00
Kseniia Sumarokova
b0ddc4fb30
Merge pull request #26364 from kssenii/fixing-date32 
Continuation of #25774
 2021-07-18 21:44:45 +03:00
alexey-milovidov
b52411a715
Merge pull request #12455 from amosbird/npc 
Nullable primary key with correct KeyCondition
 2021-07-18 17:52:20 +03:00
kssenii
3ba2d114d5 Revert "Merge pull request #26352 from ClickHouse/revert-25774-datatype-date32" 
This reverts commit 94a210650f, reversing
changes made to 0893b9ff8e.
 2021-07-15 11:41:52 +00:00
alexey-milovidov
9ba4064c86
Revert "Datatype Date32, support range 1925 to 2283" 2021-07-15 10:53:35 +03:00
Maksim Kita
e6c8100f63
Merge pull request #26248 from Algunenano/fast_nullable 
Speed up addition of nullable integers with native representation
 2021-07-12 21:20:45 +03:00
Kseniia Sumarokova
4a6b4d6c26
Merge pull request #25774 from liuneng1994/datatype-date32 
Datatype Date32, support range 1925 to 2283
 2021-07-12 20:33:39 +03:00
Raúl Marín
36bc22df98 Speed up addition of nullable native integers 2021-07-12 13:38:54 +02:00
Maksim Kita
dc81ae7c6e Compile AggregateFunctionBitwise 2021-07-10 01:51:34 +03:00
neng.liu
e47aadfdef Merge branch 'datatype-date32' of https://github.com/liuneng1994/ClickHouse into datatype-date32 2021-07-08 00:09:48 -07:00
neng.liu
100d30a5ba fix pr comment 2021-07-08 00:06:36 -07:00
Anton Popov
14168b11f2 Merge remote-tracking branch 'upstream/master' into HEAD 2021-07-07 17:05:11 +03:00
Maksim Kita
577e69898a Compile aggregate functions perf tests fix 2021-07-05 12:17:01 +03:00
NengLiu
8b88988618 Merge branch 'master' into datatype-date32 
# Conflicts:
#	src/DataStreams/PostgreSQLBlockInputStream.cpp
 2021-07-05 10:18:38 +08:00
NengLiu
dc0c65ef4f Merge remote-tracking branch 'origin/master' into datatype-date32 2021-07-05 10:15:08 +08:00
alexey-milovidov
fef7c557f6
Merge pull request #24789 from kitaisreal/compile-aggregation-functions 
Compile aggregate functions
 2021-07-05 02:57:49 +03:00
Maksim Kita
55220d49f9 Fixed code review issues 2021-07-03 16:29:32 +03:00
Alexey Milovidov
132edc9e22 Allow quantiles* functions to work with aggregate_functions_null_for_empty 2021-07-02 22:47:43 +03:00
Maksim Kita
b3e3a3cde0 Fixed tests 2021-07-02 16:36:02 +03:00
Alexey Milovidov
0e621788c7 Allow constexpr parameters for aggregate functions 2021-07-02 03:53:08 +03:00
Maksim Kita
97e1ddbe94 Fix before merge 2021-07-01 22:56:36 +03:00
Maksim Kita
39ca0ceb81 Fixed tests 2021-07-01 22:56:36 +03:00
Maksim Kita
31fe3dad7a Fixed tests 2021-07-01 22:56:36 +03:00
Maksim Kita
f33a38381d Fixed tests 2021-07-01 22:56:36 +03:00
Maksim Kita
92a36e38f1 AggregateFunctionAvgWeighted fix accuracy 2021-07-01 22:56:36 +03:00
Maksim Kita
22491c8adc Compile AggregateFunctionCount 2021-07-01 22:56:36 +03:00
Maksim Kita
61a5c4f493 Fix min, max aggregate functions merge 2021-07-01 22:56:36 +03:00
Maksim Kita
f17e212a72 Fixed build 2021-07-01 22:56:36 +03:00