Commit Graph

88 Commits

Author SHA1 Message Date
Sema Checherinda
f1ab911910 cancel or finalize write buffer 2024-11-11 11:37:12 +01:00
Antonio Andelic
ab05f8b6e8 Fix Keeper entry serialization compatibility 2024-10-23 16:41:16 +02:00
Raúl Marín
786c2bc575 Move CoordinationSettings to pImpl 2024-10-16 14:38:46 +02:00
Raúl Marín
ea5ab73da1 Remove slow poll() logs in keeper 2024-10-09 14:40:22 +08:00
Konstantin Bogdanov
67c1e89d90
Apply linter changes 2024-10-06 12:29:20 +02:00
Antonio Andelic
932a5639a2 Merge branch 'master' into keeper-xid-64 2024-09-30 09:57:37 +02:00
Antonio Andelic
2419e3c579 Support 64bit XID in Keeper 2024-09-24 18:06:37 +02:00
Konstantin Bogdanov
c35c20a481
Make clang-tidy happy 2024-09-19 12:51:42 +02:00
Han Fei
dec5931262 log session id 2024-07-15 16:43:41 +02:00
Han Fei
e346535641 fix log in keeper tcp handler 2024-07-15 16:27:53 +02:00
Raúl Marín
1b75b8f4eb Merge remote-tracking branch 'blessed/master' into mergetree_private 2024-07-11 19:58:54 +02:00
Raúl Marín
d2f89a044a Reduce dependencies on CoordinationSettings.h 2024-07-10 18:20:39 +02:00
Antonio Andelic
bf0b782960 Correctly print long processing requests in Keeper 2024-07-05 15:16:08 +02:00
Antonio Andelic
1a95259182 Add extra profiling helpers for Keeper 2024-07-01 15:17:41 +02:00
kssenii
fb32a99578 Initialize global trace collector for Poco::ThreadPool 2024-06-13 19:20:58 +02:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Raúl Marín
65728f14ce Review error codes 2023-12-18 10:40:02 +01:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Smita Kulkarni
9a9efdcf7d Updated compression to LZ4 as its better in performance 2023-11-09 10:10:22 +01:00
Smita Kulkarni
a716e12ec0 Addressed review comments 2023-11-02 14:52:10 +01:00
Smita Kulkarni
374545f4e2 Removed unwanted flush & updated to use optional for buffers 2023-11-02 09:38:53 +01:00
Smita Kulkarni
3361c5d973 Updated using read write buffer into modules 2023-11-01 12:05:41 +01:00
Smita Kulkarni
ede91f42e6 Addressed review comments 2023-10-23 16:42:08 +02:00
Smita Kulkarni
9c8815386a Fixed tryExecuteFourLetterWordCmd 2023-09-25 14:48:09 +02:00
Smita Kulkarni
c11aa4515b Merge branch 'master' into 49507_Support_compression_for_keeper_protocol 2023-09-24 11:52:57 +02:00
Smita Kulkarni
ca07275143 Support compression for keeper protocol 2023-09-24 11:38:08 +02:00
Robert Schulze
a0862531cb
Fix clang-17 build 2023-09-21 09:53:52 +00:00
Antonio Andelic
1a94675350 Don't capture this in callback 2023-09-20 13:32:01 +00:00
Antonio Andelic
0374b3de3e
Update src/Server/KeeperTCPHandler.cpp
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2023-08-01 09:04:55 +02:00
Andy Fiddaman
f9e0a202a7 clickhouse-keeper: fix implementation of server with poll() 2023-07-31 18:02:15 +01:00
Sema Checherinda
f2ad1122a1 fix convertation 2023-05-10 17:50:42 +00:00
Mike Kot
9920a52c51 use std::lerp, constexpr hex.h 2023-03-07 22:50:17 +00:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages (#45449)
* save format string for NetException

* format exceptions

* format exceptions 2

* format exceptions 3

* format exceptions 4

* format exceptions 5

* format exceptions 6

* fix

* format exceptions 7

* format exceptions 8

* Update MergeTreeIndexGin.cpp

* Update AggregateFunctionMap.cpp

* Update AggregateFunctionMap.cpp

* fix
2023-01-24 00:13:58 +03:00
Antonio Andelic
e363e27eef
Merge pull request #42532 from ClickHouse/fix-data-race
Fix `KeeperTCPHandler` data race
2022-10-24 09:14:34 +02:00
Azat Khuzhin
15bcd6250a Fix -Wshorten-64-to-32 for darwin builds
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:42 +02:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Antonio Andelic
13480f940b Handle 4LW correctly 2022-10-21 07:29:00 +00:00
Antonio Andelic
73e16ad55a Fix KeeperTCPHandler data race 2022-10-21 07:29:00 +00:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Antonio Andelic
cd548aeb30 Refactor test for multiple cluster size 2022-04-19 08:08:36 +00:00
Antonio Andelic
6c3bf0a5d3 Format files 2022-04-19 08:08:36 +00:00
Antonio Andelic
ff2ebe113c WIP 2022-04-19 08:08:35 +00:00
Azat Khuzhin
ff0e46c394 clickhouse-keeper: finish session on client EOF (fixes heap-use-after-free)
CI founds [1]:

    WARNING: ThreadSanitizer: heap-use-after-free (pid=1)
      Read of size 8 at 0x7b48001e0088 by thread T7 (mutexes: write M2588):
        ...
        1 DB::KeeperTCPHandler::runImpl()::$_0::operator()() const build_docker/../src/Server/KeeperTCPHandler.cpp:384:14 (clickhouse+0x194f974f)
        ...
        8 DB::KeeperDispatcher::setResponse() build_docker/../src/Coordination/KeeperDispatcher.cpp:222:9 (clickhouse+0x1999de82)
        9 DB::KeeperDispatcher::responseThread() build_docker/../src/Coordination/KeeperDispatcher.cpp:161:18 (clickhouse+0x1999d7a7)
        10 DB::KeeperDispatcher::initialize()::$_1::operator()() const build_docker/../src/Coordination/KeeperDispatcher.cpp:273:54 (clickhouse+0x199a55d1)

      Previous write of size 8 at 0x7b48001e0088 by thread T3:
        0 operator delete(void*, unsigned long) <null> (clickhouse+0xa0dad50)
        1 DB::KeeperTCPHandler::~KeeperTCPHandler() build_docker/../src/Server/KeeperTCPHandler.cpp:648:1 (clickhouse+0x194f8ee6)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35772/38873d726d22b15d4c5a284410956927b2e2f95f/integration_tests__thread__actions__[4/4].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-31 09:31:34 +03:00
Azat Khuzhin
38873d726d clickhouse-keeper: fix implementation of server with poll()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-30 21:30:12 +03:00
Azat Khuzhin
9820230e95 clickhouse-keeper: correctly handle closed client connection
This will avoid noisy message like:

    DB::Exception: Cannot read all data. Bytes read: 0. Bytes expected: 4.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-30 20:29:04 +03:00
alesapin
33ff2f76e5 Merge branch 'master' into standalone_keeper_build 2022-03-11 13:58:44 +01:00
alesapin
0eb7d28192 Building small keeper binary 2022-03-03 21:27:46 +01:00
zhanglistar
9ee0d2c8a0 keeper atomic stat 2022-03-03 14:30:22 +08:00
alesapin
3d325aacf6 Merge branch 'master' into better_hashmap 2022-01-19 12:31:23 +03:00