Commit Graph

110368 Commits

Author SHA1 Message Date
robot-clickhouse-ci-2
c28ab44ce5
Merge pull request #47044 from ClickHouse/DanRoscigno-patch-4
add comment info to create table
2023-03-01 02:31:51 +01:00
Dmitry Novik
54680b1a0a Merge remote-tracking branch 'origin/master' into analyzer-group-by-use-nulls 2023-03-01 01:08:17 +00:00
Dan Roscigno
980680096e
Merge pull request #47043 from ClickHouse/DanRoscigno-patch-5
Add exaple of intDiv
2023-02-28 17:37:44 -05:00
Dan Roscigno
fa5b65a702
add comment info to create table
closes https://github.com/ClickHouse/ClickHouse/issues/37088
2023-02-28 17:35:52 -05:00
AVMusorin
99329d8682 Improve tests for Distributed INSERT
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 23:17:37 +01:00
Azat Khuzhin
d06a4b50d6 Latest review fixes (variable naming: s/monitor/queue)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:48:07 +01:00
Dan Roscigno
4c2efa8dde
Merge pull request #47039 from ClickHouse/DanRoscigno-patch-4
docs: sample settings profile and assign to a user
2023-02-28 16:40:55 -05:00
Dan Roscigno
97c8c21741
Add exaple of intDiv
closes https://github.com/ClickHouse/ClickHouse/issues/25703
2023-02-28 16:38:00 -05:00
Azat Khuzhin
591fca57f3 Fix function names for opentelemetry spans in StorageDistributed
Fixes: 02417_opentelemetry_insert_on_distributed_table
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
7063c20b3c Change noisy "Skipping send data over distributed table." message to test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
16bfef3c8a Fix processing current_batch.txt on init
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
752d27d663 Fix lossing files during distributed batch send
v2: do not suppress exceptions in case of errors
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
572dd76eae Extend ConcurrentBoundedQueue to deque
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
263c042c6a Fix opentelemetry for distributed batch sends
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
00115c6615 Rename readDistributedAsyncInsertHeader()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
a76d7b22c1 Use existing public methods of StorageDistributed in DistributedSink
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
e83699a8d3 Improve comment for DistributedAsyncInsertDirectoryQueue::initializeFilesFromDisk()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
e10fb142fd Fix race for distributed sends from disk
Before it was initialized from disk only on startup, but if some INSERT
can create the object before, then, it will lead to the situation when
it will not be initialized.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
b5434eac3b Rename StorageDistributedDirectoryMonitor to DistributedAsyncInsertDirectoryQueue
Since #44922 it is not a directory monitor anymore.

v2: Remove unused error codes
v3: Contains some header fixes due to conflicts with master
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
1c4659b8e7 Separate out Batch as DistributedAsyncInsertBatch (and also some helpers)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
33b13549ad Separate out DirectoryMonitorSource as DistributedAsyncInsertSource
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
325a7b2305 Separate out DistributedHeader as DistributedAsyncInsertHeader
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
22a39e29f7 Add a comment for StorageDistributedDirectoryMonitor::Batch::recovered
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
0c19a75a1c Add log message for batch restore
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
13a3e03f19 Introduce StorageDistributedDirectoryMonitor::Batch::{de,}serialize()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
f0a2efa630 Always manipulate with absolute file paths in DirectoryMonitor
Otherwise on batch restore we can get the difference in file paths.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
ef1e642e05 Add log message to StorageDistributedDirectoryMonitor::addAndSchedule()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
16646c0923 Rename DirectoryMonitor::current_batch_file to current_file
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
Azat Khuzhin
3f892e52ab Revert "Revert "Merge pull request #44922 from azat/dist/async-INSERT-metrics""
This is the revert of revert since there will be follow up patches to
address the issues.

This reverts commit a55798626a.
2023-02-28 22:33:36 +01:00
Dan Roscigno
7c6e7622d8
docs: sample settings profile and assign to a user
closes https://github.com/ClickHouse/ClickHouse/issues/12311
2023-02-28 15:38:31 -05:00
Antonio Andelic
6e28406751 Merge branch 'master' into fix-data-size 2023-02-28 20:09:29 +00:00
Antonio Andelic
a6ba6f2cd6 Update tests 2023-02-28 20:08:29 +00:00
Kruglov Pavel
66634cfd7c
Merge pull request #46618 from kitaisreal/map-field-to-string-fix
Map field to string fix
2023-02-28 20:29:40 +01:00
Kruglov Pavel
75a9dc82d5
Merge pull request #47031 from ClickHouse/Avogar-patch-1
Add upgrade check to stateful dependent field
2023-02-28 20:26:27 +01:00
Mikhail f. Shiryaev
9a48539fbe
Rebuild stateful tests image 2023-02-28 20:20:04 +01:00
Dan Roscigno
357415f4f5
Merge pull request #47034 from ClickHouse/DanRoscigno-patch-6
Correct return vals
2023-02-28 14:10:52 -05:00
robot-ch-test-poll3
afac2801a2
Merge pull request #47029 from ClickHouse/DanRoscigno-patch-5
Remove extra `]`
2023-02-28 19:59:07 +01:00
Dan Roscigno
0a32bac97b
Merge pull request #47025 from ClickHouse/DanRoscigno-patch-4
Fix 404 on approx nearest neighbor page
2023-02-28 13:56:07 -05:00
artem-yadr
f53b65a7cc
small fix 2023-02-28 21:01:03 +03:00
Dan Roscigno
8c55ce8d72
Correct return vals
closes #43145
2023-02-28 12:07:11 -05:00
Mike Kot
3bc2e84a2a Test tags section stub 2023-02-28 20:01:48 +03:00
alesapin
c0f28ace51 Better 2023-02-28 17:52:21 +01:00
alesapin
abd6500ee3 Better exception message when move was unseccessful 2023-02-28 17:49:16 +01:00
Kruglov Pavel
4e0a4e56c9
Add upgrade check to stateful dependent field 2023-02-28 17:45:04 +01:00
pufit
29296cb004
Merge pull request #46550 from ClickHouse/46231-systerm-server-settings
Implement `system.server_settings`
2023-02-28 11:23:15 -05:00
Dmitry Novik
d953baa7e3 Review improvements + fixup 2023-02-28 16:12:51 +00:00
Dan Roscigno
7099e76cc3
Remove extra ]
closes #46172
2023-02-28 10:47:51 -05:00
Dan Roscigno
476942ae83
Merge pull request #47026 from ClickHouse/DanRoscigno-patch-5
Remove table from intro page
2023-02-28 10:27:09 -05:00
Antonio Andelic
45dc5dc25d No progress bar if no size 2023-02-28 15:25:28 +00:00
Dan Roscigno
57f451ad2d
Remove table from intro page
The table was not kept up to date, removing as the list of table functions is in the nav.  In the future the list will be auto generated below the intro material.

Closes #46944
2023-02-28 09:47:32 -05:00