Commit Graph

110368 Commits

Author SHA1 Message Date
Igor Nikonov
b369366b19 Some refactoring
+ result_columns
+ move interpolate to method from lambda
2023-03-15 22:13:16 +00:00
Alexander Gololobov
f515e35001
Merge pull request #47615 from HarryLeeIBM/hlee-s390x-siphash-tests
Fix siphash128 related tests for s390x
2023-03-15 22:57:55 +01:00
alesapin
fc913649cf Check only for interactive moves 2023-03-15 22:51:53 +01:00
pufit
f4d9b4a888
Merge pull request #47086 from pkit/pkit/insert_http_body
use http request body in predefined http handlers
2023-03-15 17:41:05 -04:00
alesapin
586b8a4733 Add test 2023-03-15 22:38:42 +01:00
alesapin
ef7508469c Fix wait for zero-copy replication move during manual move 2023-03-15 22:29:24 +01:00
Igor Nikonov
7d8e5533f3
Merge pull request #47385 from ClickHouse/fix-distinct-in-order-analyzer
Fix: apply reading in order for distinct
2023-03-15 21:48:33 +01:00
Maksim Kita
5329041479
Merge pull request #47539 from ClickHouse/interpolate-const-fix
Support constants in INTERPOLATE clause (new analyzer)
2023-03-15 22:06:49 +03:00
Alexander Tokmakov
a05f48d4b2
Merge pull request #47625 from ClickHouse/evillique-patch-2
Fix exception message in clickhouse-test
2023-03-15 21:09:42 +03:00
Robert Schulze
785ade7c39
Follow-up to #47614 2023-03-15 18:05:53 +00:00
Nikolay Degterinsky
5bdbb7670d
Fix exception message in clickhouse-test 2023-03-15 18:42:26 +01:00
alesapin
8974ba1fad
Update ASTDeleteQuery.cpp
Remove format clause because we do it in ASTQueryWithOutput::formatImpl.
2023-03-15 17:37:26 +01:00
robot-clickhouse
b96ab51f94
Merge pull request #47619 from ClickHouse/devcrafter-patch-1
Warning regarding SETTINGS and FORMAT
2023-03-15 17:10:37 +01:00
alesapin
e3dd7d79b0 Update src/Parsers/ASTDeleteQuery.cpp 2023-03-15 16:35:56 +01:00
Igor Nikonov
109ef9232c
Warning regarding SETTINGS and FORMAT 2023-03-15 16:30:31 +01:00
Vladimir C
045960f1a1
Merge pull request #47108 from ClickHouse/vdimir/http_wait_end_of_query_settings 2023-03-15 15:31:12 +01:00
HarryLeeIBM
50a5422110 Fix siphash128 related tests for s390x 2023-03-15 07:18:28 -07:00
robot-ch-test-poll2
c8583398ca
Merge pull request #47614 from ClickHouse/rs/docs-max_query_size
Docs: Fix unit for setting "max_query_size"
2023-03-15 14:57:48 +01:00
Robert Schulze
3bcfe02312
Docs: Fix unit for setting "max_query_size" 2023-03-15 13:29:25 +00:00
Alexander Tokmakov
6a653060ff
Merge pull request #47213 from azat/interserver-mode-v2
Reimplement interserver mode to avoid replay attacks
2023-03-15 16:26:50 +03:00
avogar
0005517cee Fix comments 2023-03-15 13:08:01 +00:00
Maksim Kita
4337a3161a
Merge pull request #47370 from ClickHouse/fix-grouping-for-grouping-sets
Fix GROUPING function initialization for grouping sets
2023-03-15 16:06:49 +03:00
save-my-heart
b7d9d721fb add test 2023-03-15 21:01:12 +08:00
Igor Nikonov
d69fb0c396 Merge remote-tracking branch 'origin/master' into improve-remove-redundant-distinct 2023-03-15 12:45:20 +00:00
Igor Nikonov
cc3c8a4e30 Add test 2023-03-15 12:44:22 +00:00
robot-ch-test-poll1
43db7c59d9
Merge pull request #47260 from ClickHouse/vdimir/storage_join_insert_select_deadlock
Forbid insert select for the same StorageJoin
2023-03-15 12:52:29 +01:00
Alexey Milovidov
1d63945604
Merge pull request #47578 from Enmk/patch-2
Simplify clickhouse-test usage with -b
2023-03-15 14:51:05 +03:00
Alexey Milovidov
e42238a4e7
Merge pull request #47606 from azat/tests/flakiness-v2
Fix possible failures of 01300_client_save_history_when_terminated_long
2023-03-15 14:49:34 +03:00
robot-ch-test-poll3
9d14c14a54
Merge pull request #47573 from azat/odbc-fix
Change error code in case of columns definitions was empty in ODBC
2023-03-15 12:31:54 +01:00
Kruglov Pavel
8456e5721d
Merge pull request #47585 from den-crane/patch-68
Doc. Fix link
2023-03-15 12:25:42 +01:00
Kruglov Pavel
a200ad9b99
Fix test flakiness 2023-03-15 12:20:14 +01:00
Jordi Villar
649fa8337b
Merge branch 'master' into analyzer-bitmap-has-any 2023-03-15 12:13:15 +01:00
Vitaly Baranov
00c05f7f8b
Merge pull request #47546 from vitlibar/use-server-side-copy-for-restore
Use server-side copy for restore from S3 to S3.
2023-03-15 11:28:29 +01:00
Robert Schulze
145eed9455
Merge pull request #46485 from ClibMouse/KRB_CVE_Fix
Update krb5 to 1.20.1-final to mitigate CVE-2022-42898
2023-03-15 11:00:06 +01:00
Robert Schulze
5cee479f0c
Merge pull request #47424 from ClickHouse/rs/compile-with-cpp23
Compile with C++23
2023-03-15 10:55:42 +01:00
save-my-heart
d70c352313 checksum: do not check inverted index files 2023-03-15 16:43:59 +08:00
Jordi Villar
2f8772131e Add test to prevent regressions when using bitmapHasAny 2023-03-15 09:16:09 +01:00
Azat Khuzhin
c0d7c826b8 Fix possible failures of 01300_client_save_history_when_terminated_long
The problem is that completion request can takes too much time,
especially with S3 storage, and because of this it fails sometimes after
client writes "Bye.", like here [1]:

    2023-03-07 22:20:22 send: sending "\u0004" to { exp7 }
    2023-03-07 22:20:22 Bye.
    2023-03-07 22:20:22  [?2004lexpect: timed out

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/47295/946dff2d04e7f7af8d3541ed7de11f195b521b6c/stateless_tests__release__s3_storage__[2/2].html

And from server logs:

    2023.03.07 22:19:21.885151 [ 41723 ] {00cb66fe-d01f-40ca-a6ef-b7dbd9f69d9e} <Trace> ContextAccess (default): Access granted: CREATE DATABASE ON test_4xqrwzwv.*
    ...
    2023.03.07 22:19:22.286606 [ 5806 ] {} <Debug> TCPHandler: Connected ClickHouse client version 23.3.0, revision: 54461, database: test_4xqrwzwv, user: default.
    2023.03.07 22:19:22.287361 [ 5806 ] {1493527c-8b85-4080-be82-a1c78829a104} <Debug> executeQuery: (from [::1]:40978) SELECT DISTINCT arrayJoin(extractAll(name, '[\\w_]{2,}')) AS res FROM (SELECT * FROM viewIfPermitted(SELECT name FROM system.functions ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.table_engines ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.formats ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.table_functions ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.data_type_families ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.merge_tree_settings ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.settings ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT cluster FROM system.clusters ELSE null('cluster String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT macro FROM system.macros ELSE null('macro String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT policy_name FROM system.storage_policies ELSE null('policy_name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT concat(func.name, comb.name) AS x FROM system.functions AS func CROSS JOIN system.aggregate_function_combinators AS comb WHERE is_aggregate ELSE null('x String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT name FROM system.databases LIMIT 10000 ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT DISTINCT name FROM system.tables LIMIT 10000 ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT DISTINCT name FROM system.dictionaries LIMIT 10000 ELSE null('name String')) UNION ALL SELECT * FROM viewIfPermitted(SELECT DISTINCT name FROM system.columns LIMIT 10000 ELSE null('name String'))) WHERE notEmpty(res) (stage: Complete)
    ...
    2023.03.07 22:20:22.316230 [ 58563 ] {} <Trace> DynamicQueryHandler: Request URI: /?query=DROP+DATABASE+IF+EXISTS+test_4xqrwzwv&database=system&connect_timeout=539&receive_timeout=539&send_timeout=539&http_connection_timeout=539&http_receive_timeout=539&http_send_timeout=539&log_comment=01300_client_save_history_when_terminated_long.expect
    ...
    2023.03.07 22:20:45.575830 [ 5806 ] {1493527c-8b85-4080-be82-a1c78829a104} <Warning> TCPHandler: Client has gone away.
    2023.03.07 22:20:45.575843 [ 5806 ] {1493527c-8b85-4080-be82-a1c78829a104} <Debug> TCPHandler: Processed in 83.289128886 sec.

So query for autocomplete takes 83 seconds!

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-15 08:56:57 +01:00
Azat Khuzhin
bcf381c5ae Reimplement interserver mode to avoid replay attacks
Prevous implementation (DBMS_MIN_REVISION_WITH_INTERSERVER_SECRET)
accepts the salt from the client, which make it useless.

Reimplement the protocol to send the salt by the server and use it in
the client instead.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-15 08:28:43 +01:00
Alexey Milovidov
8e0a2a3a27
Merge pull request #47598 from ClickHouse/fix-wording
Update storing-data.md
2023-03-15 04:26:09 +03:00
San
b6de44e0e3
Update storing-data.md
Just a small update I spotted when discussing encryption at rest with others
2023-03-15 11:37:42 +11:00
Alexey Milovidov
f4f7e110b6
Merge branch 'master' into patch-2 2023-03-15 02:03:52 +03:00
Alexey Milovidov
a0663e00cb
Merge pull request #47553 from azat/tests/flakiness-v1
Fix some flaky tests
2023-03-15 02:02:45 +03:00
Vitaly Baranov
c9f4143514 Fix build. 2023-03-14 23:34:48 +01:00
Vitaly Baranov
25356786ea Simplify the implementation, create new utility function copyS3FileToDisk(). 2023-03-14 23:34:44 +01:00
Robert Schulze
b91a537096
Address clang-tidy slowness 2023-03-14 22:24:20 +00:00
robot-clickhouse-ci-1
e8c6d55c22
Merge pull request #47582 from CurtizJ/fix-perf-regression
Fix performance regression in aggregation
2023-03-14 23:17:53 +01:00
Ilya Yatsishin
82a6d75050
Merge pull request #47535 from ucasfl/insrt
Add INSTR as alias of positionCaseInsensitive for MySQL compatibility
2023-03-14 22:00:40 +01:00
Alexey Milovidov
e443c4e682
Merge pull request #47538 from Avogar/proper-parquet-fix
Proper fix for bug in parquet, revert reverted #45878
2023-03-14 22:29:39 +03:00
Han Fei
6cdd3ffb31
Merge pull request #47541 from azat/dist/preserve-error-on-flush
Preserve error in system.distribution_queue on SYSTEM FLUSH DISTRIBUTED
2023-03-14 20:25:01 +01:00