Commit Graph

1993 Commits

Author SHA1 Message Date
Azat Khuzhin
42af45b2ba rocksdb: fix race condition during multiple DB opening
This should fix the following SIGSEGV, that was found on CI [1]:

    <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Unknown si_code.
    <Fatal> BaseDaemon: 4.4. inlined from ../contrib/rocksdb/utilities/object_registry.cc:19: rocksdb::ObjectLibrary::FindEntry() const
    ...
    <Fatal> BaseDaemon: 7.3. inlined from ../contrib/rocksdb/options/cf_options.cc:678: rocksdb::$_7::operator()()

  [1]: https://clickhouse-test-reports.s3.yandex.net/29341/2b2bec3679df7965af908ce3f1e8e17e39bd12fe/integration_tests_flaky_check_(asan).html#fail1

And also I checked manually with TSan binary, and here is a data race
reported by TSan:

    WARNING: ThreadSanitizer: data race (pid=3356)
      Read of size 8 at 0x7b0c0008cca8 by thread T40:
        2 rocksdb::ObjectLibrary::FindEntry() const obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:18:27 (clickhouse-tsan+0x1b839a6c)
        ...
        6 rocksdb::$_7::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/options/cf_options.cc:676:32 (clickhouse-tsan+0x1b6bfa63)
        ...
        28 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        29 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)
        ...

      Previous write of size 8 at 0x7b0c0008cca8 by thread T41:
        ...
        9 rocksdb::ObjectLibrary::AddEntry() obj-x86_64-linux-gnu/../contrib/rocksdb/utilities/object_registry.cc:31:19 (clickhouse-tsan+0x1b8392fc)
        ...
        11 rocksdb::RegisterTableFactories()::$_0::operator()() const obj-x86_64-linux-gnu/../contrib/rocksdb/table/table_factory.cc:23:14 (clickhouse-tsan+0x1b7ea94c)
        ...
        43 rocksdb::GetColumnFamilyOptionsFromMap() obj-x86_64-linux-gnu/../contrib/rocksdb/options/options_helper.cc:727:10 (clickhouse-tsan+0x1b6fffd2)
        44 DB::StorageEmbeddedRocksDB::initDb() obj-x86_64-linux-gnu/../src/Storages/RocksDB/StorageEmbeddedRocksDB.cpp:359:26 (clickhouse-tsan+0x14195e31)

Refs: https://github.com/ClickHouse-Extras/rocksdb/pull/13
Fixes: #29341
2021-09-26 23:41:43 +03:00
Alexey Milovidov
6f65029daf Update libhdfs3 2021-09-25 02:54:18 +03:00
alexey-milovidov
60f76d9254
Merge pull request #28759 from nikitamikhaylov/enable-gcc-11
Switch CI to GCC-11
2021-09-12 15:56:57 +03:00
alexey-milovidov
ea13a8b562
Merge pull request #28659 from myrrc/improvement/tostring_to_magic_enum
Improving CH type system with concepts
2021-09-12 15:26:29 +03:00
Mike Kot
c4385a2c40 Simplifying exception messages 2021-09-11 00:40:18 +02:00
Nikita Mikhaylov
d7dafd6d2f Switch performance and merge contrib 2021-09-10 11:10:45 +00:00
mergify[bot]
937eeb9fed
Merge branch 'master' into enable-gcc-11 2021-09-09 22:44:10 +00:00
Maksim Kita
31766575e0
Merge pull request #28820 from azat/llvm-shared
Fix shared build with ENABLE_EMBEDDED_COMPILER
2021-09-10 00:49:18 +03:00
Nikita Mikhaylov
a796b9f039 Fix build 2021-09-09 21:17:22 +00:00
Azat Khuzhin
0d0c19c617 Fix RPATH for llvm in shared build
Before this patch:

    $ readelf -d contrib/llvm/llvm/bin/llvm-tblgen  | fgrep -i runpath
     0x000000000000001d (RUNPATH)            Library runpath: [$ORIGIN/../lib]

After:

    $ readelf -d contrib/llvm/llvm/bin/llvm-tblgen  | fgrep -i runpath
     0x000000000000001d (RUNPATH)            Library runpath: [/src/ch/clickhouse/.cmake/contrib/llvm/llvm/lib:/src/ch/clickhouse/.cmake/contrib/libcxx-cmake:/src/ch/clickhouse/.cmake/contrib/libcxxabi-cmake:/src/ch/clickhouse/.cmake/contrib/libunwind-cmake]
2021-09-09 22:41:27 +03:00
Azat Khuzhin
784d468f4b Include llvm from function to guard CMAKE_CXX_STANDARD scope 2021-09-09 22:41:26 +03:00
Nikita Mikhaylov
dcf7cb4a5c Done 2021-09-08 17:33:40 +00:00
Nikita Mikhaylov
474f34e78c Move back 2021-09-06 16:41:49 +00:00
Nikita Mikhaylov
a327144d40 Better 2021-09-06 16:39:46 +00:00
Nikita Mikhaylov
29a18d8d10 Try to fix unbundled 2021-09-06 15:58:08 +00:00
Nikita Mikhaylov
7c39f84a5e Merge upstream/master into global-merge-executor (using imerge) 2021-09-06 15:37:18 +00:00
Mike Kot
8e9aacadd1 Initial: replacing hardcoded toString for enums with magic_enum 2021-09-06 16:24:03 +02:00
Nikita Mikhaylov
0249015515 added priority queue 2021-09-06 11:37:51 +00:00
alesapin
36a11af351 Merge branch 'master' into add_test_logs_level 2021-09-04 15:48:47 +03:00
Nikita Mikhaylov
3eec8a3c2f Use boost::circular_buffer 2021-09-03 22:15:20 +00:00
Maksim Kita
5112b6e00d
Merge pull request #28537 from azat/bump-poco-remove-getpid
Bump poco to remove getpid() calls
2021-09-03 22:03:12 +03:00
Kseniia Sumarokova
8c5acc371a
Merge pull request #28365 from kssenii/rabbitmq-ssl
Allow ssl connection for rabbitmq
2021-09-03 16:53:28 +03:00
alesapin
497c225203 Test log level for CI 2021-09-03 13:07:40 +03:00
Azat Khuzhin
5bab06ed90 Bump poco to remove getpid() calls
Refs: https://github.com/ClickHouse-Extras/poco/pull/46
2021-09-03 07:45:58 +03:00
Nikita Mikhaylov
7e936c248f contrib/aws/ 2021-08-31 12:54:45 +00:00
kssenii
335b6f12fd Fix 2021-08-30 20:59:03 +03:00
Kseniia Sumarokova
31afd7d09c
Merge pull request #28081 from kssenii/pg-conflict
Support `on conflict` for postgres engine
2021-08-26 16:30:30 +03:00
mergify[bot]
9520ceba7e
Merge branch 'master' into update-libunwind-protect-from-wrong-cfa-expressions 2021-08-24 20:45:38 +00:00
Maksim Kita
0486d1bd37
Merge pull request #28084 from kssenii/nanodbc-update
Update nanodbc
2021-08-24 21:39:10 +03:00
Maksim Kita
027728a7a5 Updated libunwind to protect from wrong CFA expressions 2021-08-24 21:36:45 +03:00
kssenii
c467178a93 Update nanodbc 2021-08-24 12:50:07 +00:00
kssenii
0ec716292c Postgres ON CONFLICT 2021-08-24 12:37:32 +00:00
Azat Khuzhin
67a3ce1891 Bump replxx
Refs: https://github.com/ClickHouse-Extras/replxx/pull/17
2021-08-23 22:27:54 +03:00
alexey-milovidov
fa2a2817c9
Merge pull request #27883 from azat/bump-librdkafka-to-fix-TSan
Bump librdkafka (fixes use of an invalid/destroyed mutex)
2021-08-20 09:03:02 +03:00
Azat Khuzhin
941eba908c Bump librdkafka (to fix metadata cache destroying)
This should fix CI under TSan [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/9292869c4f92664a28b8c9ddef1e62ddfd13b285/integration_tests_(thread).html

Refs: edenhill/librdkafka#3279
2021-08-19 21:38:06 +03:00
Azat Khuzhin
6a600e5f6f jemalloc: fix under osx (zone_register() had been optimized out again)
v2: use ld -u
v3: move -u to executable
2021-08-18 09:47:59 +03:00
Azat Khuzhin
342c3fae3a Revert "Disable jemalloc under OSX" (only jemalloc hunk)
This reverts commit f062aa8574.
2021-08-18 09:47:59 +03:00
alexey-milovidov
67b2f49c8a
Merge pull request #27751 from Algunenano/osx_jemalloc
Disable jemalloc under OSX
2021-08-17 04:45:43 +03:00
Raúl Marín
f062aa8574 Disable jemalloc under OSX 2021-08-16 18:04:46 +02:00
taiyang-li
d417bd3247 remove duplicated source files in arrow-cmake 2021-08-16 18:56:14 +08:00
alexey-milovidov
135a5a2453
Merge pull request #27683 from ClickHouse/unbundled-sse2
Use only SSE2 in "unbundled" build
2021-08-15 13:25:44 +03:00
Alexey Milovidov
ba0ba988ba Fix build 2021-08-15 11:21:46 +03:00
Alexey Milovidov
cf87dacd4e Disable memory tracking for roaring bitmaps on Mac OS 2021-08-15 09:01:04 +03:00
Raúl Marín
61c4d94f1e Add explicit dependency between roaring and clickhouse_common_io
Fixes roaring memory tracker for split builds
2021-08-11 11:21:39 +02:00
Alexey Milovidov
3449e611fd Allow to build with AVX2 2021-08-10 03:46:03 +03:00
mergify[bot]
8d05b7c5e5
Merge branch 'master' into roaring-memory-tracker 2021-08-08 15:19:57 +00:00
alexey-milovidov
e6e9a27d8f
Merge pull request #27377 from evillique/bz2
Add support for bzip2 compression method
2021-08-08 04:40:13 +03:00
Alexey Milovidov
e7afb7e159 Merge branch 'master' into roaring-memory-tracker 2021-08-08 04:33:33 +03:00
alexey-milovidov
b8f4d480a3
Merge pull request #27081 from ClickHouse/fix_logs_in_nuraft
Fix excessive logging in NuRaft on server shutdown
2021-08-07 19:48:53 +03:00
Alexey Milovidov
161aa40206 Fix build; add comments 2021-08-07 19:30:59 +03:00