Commit Graph

155468 Commits

Author SHA1 Message Date
Blargian
5703b5409a review changes and fix style-heck 2024-10-08 17:23:30 +02:00
robot-clickhouse
f920f957d6 Update version_date.tsv and changelogs after v24.3.12.75-lts 2024-10-08 15:03:12 +00:00
Alexander Gololobov
a261c0a77e
Merge pull request #70453 from ClickHouse/fix_flaky_03249_dynamic_alter_consistency
Fix order in 03249_dynamic_alter_consistency
2024-10-08 14:36:42 +00:00
Alexey Milovidov
3ab6b8b621
Merge pull request #70473 from azat/tests/00913_many_threads
Decrease probability of "Server died" due to 00913_many_threads
2024-10-08 14:28:54 +00:00
Blargian
78e57ebe04 update aspell-ignore 2024-10-08 16:25:26 +02:00
Blargian
fce6df5e93 review changes 2024-10-08 16:17:26 +02:00
Antonio Andelic
2e6bd082a6
Merge pull request #70452 from ClickHouse/fix-vertical-merge-prefetch
Don't prefetch parts with no rows
2024-10-08 13:28:31 +00:00
Azat Khuzhin
8d4036760c Decrease probability of "Server died" due to 00913_many_threads
This test creates too much threads (1500), and sometimes there are some
stalls on arm64 [1]:

    2024.10.07 21:06:38.768974 [ 4479 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Debug> executeQuery: (from [::1]:52210) (comment: 00913_many_threads.sql) SELECT count() FROM t; (stage: Complete)
    ...
    2024.10.07 21:07:37.028725 [ 15271 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Trace> AggregatingTransform: Aggregated. 1 to 1 rows (from 0.00 B) in 58.247881431 sec. (0.017 rows/sec., 0.00 B/sec.)
    2024.10.07 21:11:20.662232 [ 15270 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Trace> AggregatingTransform: Aggregating
    ...

As you can see there are zero logs for almost 4 minutes, and trace_log
contains zero records for the interval event_time between '2024.10.07
21:07:37' and '2024.10.07 21:11:20'.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

At first I thought about adding some new metrics like
GlobalThreadPoolThreadSlowCreationMicroseconds, but it will unlikely
help with understading the root cause.

Then I thought about exposing CPU steal metric, but the problem is that
AWS uses Nitro instead of Xen for this instances (r6g.2xlarge), and
Nitro does not expose this metric.

So let's just disable parallel execution of this test to stabilize the
CI.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:20:57 +02:00
Robert Schulze
6f88ada7a9
Merge pull request #70467 from rschu1ze/docs-grammar
[Docs] Fix grammar and consistency
2024-10-08 10:11:49 +00:00
Raúl Marín
d57f0a9d37 More consistent error codes 2024-10-08 16:35:08 +08:00
Pavel Kruglov
30991f29ac
Merge pull request #69691 from Avogar/default-implementation-for-dynamic
Support Dynamic type in most functions
2024-10-08 08:22:26 +00:00
Michael Kolupaev
53f78b2e49
Merge pull request #70462 from ClickHouse/waitwice
Fix flaky test_refreshable_mv_in_replicated_db
2024-10-08 08:11:20 +00:00
Robert Schulze
c9fdeb5174
[Docs] Fix grammar and consistency
Cf. #70219, #70220, #70221, #70255, #70279
2024-10-08 08:05:41 +00:00
Michael Kolupaev
dfd74322b1 Make the test work when ran multiple times with the same fixture 2024-10-08 07:44:03 +00:00
Antonio Andelic
9a3f76a9a5 Add test 2024-10-08 09:38:15 +02:00
János Benjamin Antal
f3071fb01c Fix build 2024-10-08 06:49:57 +00:00
pufit
c901c74a2e
Merge pull request #70293 from ClickHouse/pufit/fix-implicit-grants
`SHOW GRANTS WITH IMPLICIT`, fix error with implicit grants
2024-10-08 06:29:41 +00:00
Raúl Marín
6824b31c4f Fix crash in WHERE with lambda functions 2024-10-08 14:14:55 +08:00
Pablo Marcos
e1f40bc4d9 WIP 2024-10-08 06:05:15 +00:00
robot-clickhouse
1d70ca4848
Merge pull request #70463 from ClickHouse/auto/v24.8.5.115-lts
Update version_date.tsv and changelog after v24.8.5.115-lts
2024-10-08 05:49:02 +00:00
János Benjamin Antal
2bd0d0cf11
Merge branch 'master' into validate-create-query-after-alter 2024-10-08 07:45:55 +02:00
Robert Schulze
1337f66cd0
Merge pull request #70360 from azat/vector-similarity-comments
Update comments in VectorSimilarityCondition (WHERE is not supported)
2024-10-08 05:30:14 +00:00
robot-clickhouse
9966eea716 Automatic style fix 2024-10-08 05:05:51 +00:00
robot-clickhouse
e54eabde84 Update version_date.tsv and changelogs after v24.8.5.115-lts 2024-10-08 05:00:26 +00:00
Michael Kolupaev
f78b298f61 Fix flaky test_refreshable_mv_in_replicated_db 2024-10-08 04:56:53 +00:00
David Tsukernik
2b94fba674 Style fixes 2024-10-08 04:15:38 +00:00
David Tsukernik
5ecd654ec0 Fix tests 2024-10-08 04:12:14 +00:00
robot-clickhouse
518be41439 Automatic style fix 2024-10-08 04:09:53 +00:00
Michael Kolupaev
f7d9c3a9b1 Fix refreshable MV in system database breaking server startup 2024-10-08 04:00:19 +00:00
David Tsukernik
c876b17702 Add ad test 2024-10-08 02:24:24 +00:00
David Tsukernik
34fe797e02 Use an implicit true value for bool settings 2024-10-08 01:56:06 +00:00
pufit
a89b81852c
Merge branch 'master' into pufit/fix-implicit-grants 2024-10-08 09:45:02 +08:00
Shichao
e78ad9d5e6
Merge pull request #70456 from kylhuk/fix-documentation-reference-to-users-config
fix: fixed filename reference in documentation
2024-10-07 23:08:03 +00:00
kylhuk
97b596123d fix: fixed filename reference in documentation 2024-10-07 23:19:47 +02:00
johnnyfish
92d7b11eef Update gui.md 2024-10-08 00:09:22 +03:00
Shichao
8e5781e68b
Merge pull request #70455 from pdruley/pdruley/intersect-doc
minor typo fix for example intersect SQL
2024-10-07 19:28:05 +00:00
Patrick Druley
b9b905089d minor typo fix for example intersect SQL 2024-10-07 14:42:20 -04:00
Alexander Gololobov
4138ec4d72
Merge pull request #70444 from ClickHouse/make_explain_methods_const
Make QueryPlan explain methods const
2024-10-07 15:38:50 +00:00
Alexander Gololobov
1a2cd1d58f Fix order in 03249_dynamic_alter_consistency 2024-10-07 23:35:00 +08:00
vdimir
925a7f4a61
Merge pull request #70357 from ClickHouse/vdimir/fix_02346_fulltext_index_bug52019
Fix 02346_fulltext_index_bug52019
2024-10-07 15:18:21 +00:00
Antonio Andelic
57fa4239e5 Don't prefetch parts with no rows 2024-10-07 16:56:13 +02:00
Konstantin Bogdanov
2f8d15bcaa
Merge pull request #69768 from ClickHouse/tidy-redability-else-after-return
Prepare to enable `clang-tidy` `readability-else-after-return`
2024-10-07 07:53:18 +00:00
Alexander Gololobov
25e798e04e Make QueryPlan explain methods const 2024-10-07 15:17:31 +08:00
Azat Khuzhin
3f873f1508 Fix 0.1 second delay for interactive queries (due to keystroke interceptor)
Introduced in #63689, improved from 0.3 to 0.1 in #70423 with condvar.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-07 09:17:19 +02:00
Julia Kartseva
a98fca0637
Merge pull request #70423 from ClickHouse/realtime-metrics-followup
Follow-up on clickhouse-client realtime metrics display #63689
2024-10-07 05:07:13 +00:00
Pavel Kruglov
093633bf6a
Merge pull request #69584 from Avogar/fix-postgresql-fixed-string-issue
Fix inserting into FixedString column in PostgreSQL engine
2024-10-07 04:48:14 +00:00
Pavel Kruglov
8348670099
Merge pull request #70172 from Avogar/fix-column-object-copy
Fix crash in JSON column
2024-10-07 04:44:20 +00:00
Pavel Kruglov
819ceaaf4e
Update FormatFactorySettingsDeclaration.h 2024-10-07 12:36:43 +08:00
Pavel Kruglov
addd648393
Update settings-formats.md 2024-10-07 12:32:10 +08:00
Pavel Kruglov
7345fb593c
Update settings-formats.md 2024-10-07 12:31:47 +08:00