Commit Graph

95715 Commits

Author SHA1 Message Date
Nikita Taranov
c67b554789
Update 02354_distributed_with_external_aggregation_memory_usage.sql (#39979) 2022-08-08 22:22:00 +02:00
Robert Schulze
e0d5020a92
Add simple versioning to the *-bridge-to-server protocol
- In general, it is expected that clickhouse-*-bridges and
  clickhouse-server were build from the same source version (e.g. are
  upgraded "atomically"). If that is not the case, we should at least
  be able to detect the mismatch and abort.

- This commit adds a URL parameter "version", defined in a header shared
  by the server and bridges. The bridge returns an error in case of
  mismatch.

- The version is *not* send and checked for "ping" requests (used for
  handshake), only for regular requests send after handshake. This is
  because the internally thrown server-side exception due to HTTP
  failure does not propagate the exact HTTP error (it only stores the
  error as text), and as a result, the server-side handshake code
  simply retries in case of error with exponential backoff and finally
  fails with a "timeout error". This is reasonable as pings typically
  fail due to time out. However, without a rework of HTTP exceptions,
  version mismatch during ping would also appear as "timeout" which is
  too misleading. The behavior may be changed later if needed.

- Note that introducing a version parameter does not represent a
  protocol upgrade itself. Bridges older than the server will simply
  ignore the field. Only servers older than the bridges receive an error
  but such a situation should never occur in practice.
2022-08-08 19:40:37 +00:00
vdimir
29efed0c77
Project input for rename joined columns step 2022-08-08 19:11:53 +00:00
HeenaBansal2009
d2bdf6fc3e Added tests 2022-08-08 11:51:05 -07:00
HarryLeeIBM
d609da182b Fix Endian issue in Codec for s390x 2022-08-08 11:28:35 -07:00
HarryLeeIBM
42323cfb92 Use constexpr char array as magic number 2022-08-08 10:59:09 -07:00
Robert Schulze
9952ab1099
Prefix class names "LibraryBridge*Handler" with "ExternalDictionary"
- necessary to disambiguate the names from "CatBoost"-"LibraryBridgeHandler"
  which will be added in a next step
2022-08-08 17:16:46 +00:00
Robert Schulze
e584d1276b
Factorize generic code from ExternalDictLibBridgeHelper into base class
- When catboost will be added into library-bridge later on, a lot of
  code will need to be duplicated.

- Avoid that by factorizing stuff which is not specific to external
  dictionaries for reuse into a common base class.

- This is a refactoring without semantic change.
2022-08-08 17:16:46 +00:00
Alexander Tokmakov
5d507c593b
Merge pull request #40005 from ClickHouse/revert-39617-ci-self-extracting-s3-deployment
Revert "copy self-extracting to output"
2022-08-08 20:15:56 +03:00
Alexander Tokmakov
3bc583c22b
Revert "copy self-extracting to output" 2022-08-08 20:13:40 +03:00
Alexander Gololobov
4c86130796 More generic check for MergeTree table family 2022-08-08 19:04:35 +02:00
Nikolai Kochetov
8a4c57f641 Added __init__.py 2022-08-08 16:41:11 +00:00
Raúl Marín
c8f8ceea8d Fix hashId crash and salt not applying 2022-08-08 18:25:34 +02:00
Alexander Tokmakov
664b4355bf
Merge pull request #39941 from azat/tests-rwlock-fix
tests: fix 02352_rwlock flakiness
2022-08-08 19:24:08 +03:00
Alexander Tokmakov
95645d7491 try to avoid timeouts when checking for replication consistency 2022-08-08 18:01:48 +02:00
Maksim Kita
c030fd05e7 ActionsDAG rename index to outputs 2022-08-08 18:01:32 +02:00
HeenaBansal2009
17f04a6e6e Added H literal for Hour IntervalKind 2022-08-08 08:54:53 -07:00
Yakov Olkhovskiy
d39e9f65de
Merge branch 'master' into fix-quota-key 2022-08-08 11:54:21 -04:00
Yakov Olkhovskiy
1ef9c30e82
enable fast test for http 2022-08-08 11:49:27 -04:00
Robert Schulze
4c3153b2ba
Merge pull request #39988 from ClickHouse/document-disable-self-extracting-binary
Mention how the build can be speed up by disabling self-extraction
2022-08-08 16:57:40 +02:00
Igor Nikonov
15bdeba074 Fix review comments 2022-08-08 14:43:03 +00:00
Maksim Kita
c67378124f
Merge branch 'master' into ast-destructor-intrusive-list 2022-08-08 16:28:00 +02:00
Antonio Andelic
5cd3558d07 Use different root path for counter test 2022-08-08 14:10:13 +00:00
Alexander Tokmakov
2c5da1466d Merge branch 'master' into replicated_database_improvements 2022-08-08 16:08:27 +02:00
Alexander Tokmakov
848511affb take permanently detached tables into account 2022-08-08 16:06:08 +02:00
Kruglov Pavel
704bdd08ec
Merge branch 'master' into revert-39804-revert-39510-update-arrow 2022-08-08 15:51:29 +02:00
robot-clickhouse
f10d4f6c61 Automatic style fix 2022-08-08 13:46:38 +00:00
avogar
1304e3487c Add comments, remove unneded stuff 2022-08-08 13:43:14 +00:00
Nikolai Kochetov
540ae64f37 Fix big memory usage for fetch. 2022-08-08 13:32:49 +00:00
Yakov Olkhovskiy
eb4913e4c5
fix user and quota_key 2022-08-08 09:07:38 -04:00
Robert Schulze
5a434577f6
Mention how the build can be speed up by disabling self-extraction 2022-08-08 13:01:32 +00:00
Alexander Tokmakov
2a62910fb5
Merge pull request #39985 from ClickHouse/tavplubix-patch-3
Disable 02380_insert_mv_race.sh with Ordinary
2022-08-08 15:55:05 +03:00
Maksim Kita
a9c8e13344 Fixed code review issues 2022-08-08 14:54:11 +02:00
Alexander Tokmakov
0ba6751849
Update 02380_insert_mv_race.sh 2022-08-08 15:53:37 +03:00
kssenii
ece37d2bd9 Debug checks 2022-08-08 14:43:37 +02:00
Igor Nikonov
86c5280db3 Merge remote-tracking branch 'origin/master' into skipping_sorting_step 2022-08-08 12:43:06 +00:00
Igor Nikonov
6572a447fa Check if sorting order is preserved for FilterStep 2022-08-08 12:42:10 +00:00
avogar
2f95726b06 Fix comments 2022-08-08 12:41:00 +00:00
vdimir
708747ca0b
Merge branch 'master' into refactor-prepared-sets 2022-08-08 14:27:18 +02:00
avogar
1cfb5b7cf1 Fix build 2022-08-08 12:17:18 +00:00
Vladimir C
6bd4821656
Merge pull request #39575 from vdimir/join_pushdown_column_not_found
Fix column not found for push down with join
2022-08-08 14:04:42 +02:00
Yakov Olkhovskiy
8fe8208133
Merge pull request #39967 from ClickHouse/ci-mergeable-add
Add Stateful tests (release), Stateless tests (release) to Mergeable Check
2022-08-08 07:58:20 -04:00
Robert Schulze
ad0d060dc1
Merge pull request #39904 from ClickHouse/library-bridge-refactoring
Prepare library-bridge for catboost integration
2022-08-08 12:15:01 +02:00
Kseniia Sumarokova
d1b436597f
Merge pull request #39940 from azat/file-log-fix
Create metadata directory on CREATE for FileLog engine
2022-08-08 11:39:17 +02:00
Kseniia Sumarokova
ec4a4d31ea
Fix style check 2022-08-08 11:23:57 +02:00
alexX512
c1a8c615f3 Restart GH 2022-08-08 07:50:04 +00:00
Alexey Milovidov
0921548a37
Merge pull request #39527 from pkit/pkit/fix_nats_tls
fix nats-io TLS support
2022-08-08 08:28:14 +03:00
Alexey Milovidov
0349d9da96 Change font in CI reports just in case (might be worse) 2022-08-08 07:25:29 +02:00
Alexey Milovidov
cb7f072fe8
Merge pull request #39617 from ClickHouse/ci-self-extracting-s3-deployment
copy self-extracting to output
2022-08-08 08:19:15 +03:00
Alexey Milovidov
855e52a7c9 Send final ProfileEvents just in case 2022-08-08 07:12:08 +02:00