Commit Graph

39998 Commits

Author SHA1 Message Date
Robert Schulze
05606a8835
Clean up GCC warning pragmas 2023-04-11 18:21:08 +00:00
Azat Khuzhin
d7f8650372 Remove lock for duplicated parts UUIDs (allow_experimental_query_deduplication=1)
It looks redundant, since sendQuery() cannot be executed in parallel
with processPacket() (hence RemoteQueryExecutor::setPartUUIDs())

This likely will fix the lock-order-inversion in RemoteQueryExecutor,
since I think it is false-positive.

Fixes: #48534
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-11 20:19:32 +02:00
alesapin
a72ee0b85e Merge remote-tracking branch 'origin/master' into revert-46909-revert-45911-mutations_rename_hang 2023-04-11 20:14:43 +02:00
Robert Schulze
dcfd843b2d
Merge pull request #48489 from ClickHouse/rs/date_time-alias
Register datediff and trim aliases in system.functions
2023-04-11 19:53:44 +02:00
alesapin
165edd332e Remove strange code from MutateTask 2023-04-11 18:31:53 +02:00
Robert Schulze
1477887259
Initial removal of logic under COMPILER_GCC 2023-04-11 16:27:32 +00:00
Dmitry Novik
52f3406bbb Fix CurrentMetrics::MergesMutationsMemoryTracking value 2023-04-11 16:10:59 +00:00
Sergei Trifonov
7c309a0134
Merge branch 'master' into mburdukov_multi_settings 2023-04-11 17:53:43 +02:00
Dmitry Novik
06e6794fc0 Merge remote-tracking branch 'origin/master' into background-memory-tracker 2023-04-11 15:29:35 +00:00
Alexander Tokmakov
1982e2e040
Merge pull request #48662 from hanfei1991/hanfei/refine-expmsg1
fix 02504_regexp_dictionary_table_source
2023-04-11 18:20:10 +03:00
Anton Popov
09c66c3879 fix async inserts with empty data 2023-04-11 15:13:46 +00:00
Han Fei
bf28be8837 fix 02504_regexp_dictionary_table_source 2023-04-11 17:07:44 +02:00
Mikhail f. Shiryaev
89e4509e68
Merge branch 'master' into fix-memory-compressed-tables 2023-04-11 16:38:51 +02:00
Anton Popov
3896375247 fix getting subcolumn from in-memory data 2023-04-11 14:26:31 +00:00
Dmitry Novik
0e417b1a6f Cleanup the code 2023-04-11 14:08:28 +00:00
Yakov Olkhovskiy
6232d17876
Merge pull request #48611 from ClickHouse/fix-ip4-uint-compare
Fix IPv4 comparable with UInt
2023-04-11 09:53:33 -04:00
Anton Popov
5b8db57fe8
Merge branch 'master' into retry-loading-of-parts 2023-04-11 15:51:40 +02:00
Robert Schulze
1fc5d92ae2
Merge pull request #48627 from ClickHouse/rs/formatdatetime-refactoring
Minor refactoring of formatDateTime()
2023-04-11 15:29:47 +02:00
Kseniia Sumarokova
10bb328d7d
Merge branch 'master' into fix-error-in-cache 2023-04-11 15:25:38 +02:00
Anton Popov
5a77a2aa4c
Merge branch 'master' into CurtizJ-patch-7 2023-04-11 15:06:07 +02:00
FriendLey
e327371297
Merge branch 'master' into test_soundex 2023-04-11 21:02:01 +08:00
Han Fei
7210b50551
Merge pull request #48632 from hanfei1991/hanfei/refine-expmsg
refine some messages of exception in regexp tree
2023-04-11 14:45:35 +02:00
Antonio Andelic
b30aff06d8
Merge pull request #48595 from aalexfvk/alexfvk/fix_create_not_auth_problem
Fix bug in Keeper when a node is not created with scheme `auth` in ACL sometimes.
2023-04-11 14:41:37 +02:00
Kruglov Pavel
c3482a104f
Merge pull request #48472 from ClickHouse/Avogar-patch-2
Avoid operation on uninitialised data in readDateTimeTextImpl
2023-04-11 14:30:26 +02:00
robot-ch-test-poll1
028ccfdc87
Merge pull request #48438 from evillique/add-trailing-commas
Allow trailing commas in expression list of SELECT query
2023-04-11 14:21:28 +02:00
Robert Schulze
e08b7c8a53
Merge pull request #48422 from ClickHouse/rs/better-f-in-formatdatetime
MySQL compat: Align behavior of %f in formatDateTime() with parseDateTime()
2023-04-11 14:12:16 +02:00
Robert Schulze
4e52dc672e
Merge pull request #48420 from ClickHouse/rs/f
MySQL compat: Implement %f in parseDateTime()
2023-04-11 14:12:02 +02:00
SmitaRKulkarni
e2010c0257
Merge branch 'master' into zk_retry_timeout 2023-04-11 14:05:52 +02:00
Han Fei
c857f767fa
Merge branch 'master' into hanfei/refine-expmsg 2023-04-11 14:03:27 +02:00
Robert Schulze
ba67626992
Add comment about used exception code 2023-04-11 11:59:04 +00:00
vdimir
30659c5b48
Fix build ThreadGroupPtr 2023-04-11 11:46:53 +00:00
Kseniia Sumarokova
f4aa62ebc8
Merge branch 'master' into fix-error-in-cache 2023-04-11 13:40:46 +02:00
Sema Checherinda
4b9eff7dab
Merge pull request #48638 from ClickHouse/vdimir/fix-build-48543
Fix build src/Interpreters/InterpreterInsertQuery.h
2023-04-11 13:27:51 +02:00
Han Fei
6c33180ac8
Merge branch 'master' into hanfei/refine-expmsg 2023-04-11 13:19:38 +02:00
FriendLey
8aa17dbffe remove return in void function. 2023-04-11 19:18:27 +08:00
vdimir
4605d71947
Fix build src/Interpreters/InterpreterInsertQuery.h 2023-04-11 11:17:02 +00:00
FriendLey
c527347736
Merge branch 'master' into test_soundex 2023-04-11 19:16:10 +08:00
Sergei Trifonov
ca6e253fa6
Merge pull request #48526 from ClickHouse/lost-part-count 2023-04-11 13:11:42 +02:00
FriendLey
48463f79fd
Merge branch 'master' into test_soundex 2023-04-11 19:00:51 +08:00
kssenii
6717eab355 Fix 2023-04-11 12:35:59 +02:00
Kruglov Pavel
a0d11fdf53
Merge pull request #48436 from Avogar/fix-generate-random
Generate valid Decimals and Bools in generateRandom function
2023-04-11 12:06:08 +02:00
FriendLey
ffa1a75fb5 Merge branch 'master' into test_soundex 2023-04-11 17:52:32 +08:00
Sema Checherinda
4dd86a406a
Merge pull request #48543 from azat/mv-uniq-thread-group
Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup)
2023-04-11 11:47:46 +02:00
Han Fei
363b97fab8 refine some messages of exception in regexp tree 2023-04-11 11:45:29 +02:00
Robert Schulze
bbbb55cd50
Better handling of values too large for VarInt encoding
PR #48154 introduced a sanity check in the form of a debug assertion
that the input values for VarInt encoding are not too big. Such values
should be exceptionally rare in practice but the AST fuzzer managed to
trigger the assertion regardless. The strategy to deal with such values
until now was to bypass the check by limiting the value to the maximum
allowed value (see #48412). Because a new AST Fuzzer failure appeared
(#48497) and there may be more failures in future, this PR changes the
sanity check from an assert to an exception.

Fixes: #48497
2023-04-11 07:47:33 +00:00
Aleksei Filatov
dd2364361c
Update src/Coordination/tests/gtest_coordination.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2023-04-11 10:45:30 +03:00
Robert Schulze
4b61685c64
Minor refactoring of formatDateTime()
Don't explicitly specify literal length when the called functions can
compute it.
2023-04-11 07:43:24 +00:00
Robert Schulze
c3f976c58a
Move space check out of loop 2023-04-11 06:19:10 +00:00
Robert Schulze
b7d5df7aa1
Merge branch 'master' into rs/better-f-in-formatdatetime 2023-04-11 08:11:04 +02:00
FriendLey
910bd8a15f bugfix: fix access illegal address bugs. 2023-04-11 13:01:53 +08:00
Alexey Milovidov
9e1db557e0
Merge pull request #48612 from ClickHouse/remove-strange-code-2
Remove strange code
2023-04-11 06:17:45 +03:00
FriendLey
6a3eb19821
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-11 09:49:52 +08:00
FriendLey
3d4c6e5a48
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-11 09:49:42 +08:00
FriendLey
baa29a5a2c
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-11 09:49:34 +08:00
FriendLey
0ac9f78c43
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-11 09:49:16 +08:00
FriendLey
a5d4a2065e
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-11 09:49:06 +08:00
Alexey Milovidov
d259217cf3
Merge pull request #48570 from azat/build/logger_useful
Remove superfluous includes of logger_userful.h from headers
2023-04-11 03:56:39 +03:00
Alexey Milovidov
93b8fc74ef
Merge pull request #48571 from azat/dict/hashed/uncaught-exception-fix
Fix uncaught exception in case of parallel loader for hashed dictionaries
2023-04-10 23:11:01 +03:00
Alexey Milovidov
f4d6596eaa
Merge pull request #48577 from ClickHouse/evillique-patch-2
Don't use type conversion with String query parameters
2023-04-10 22:18:39 +03:00
Alexey Milovidov
23a0879452 Remove strange code 2023-04-10 21:17:08 +02:00
Yakov Olkhovskiy
e6d96c27f2 unnecessary include 2023-04-10 19:16:02 +00:00
Yakov Olkhovskiy
a6c99e8e84 add IPv4 to supertype calculation 2023-04-10 18:59:50 +00:00
Azat Khuzhin
013a3ed269 Fix possible lock order inversion in Context::setTemporaryStorageInCache()
TSan report [1]:

    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=1)
      Cycle in lock order graph: M0 (0x7b9000000008) => M1 (0x7b90000000a8) => M0

      Mutex M1 acquired here while holding mutex M0 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ccb3a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getDisk() const build_docker/./src/Interpreters/Context.cpp:3281:21 (clickhouse+0x1d0ccb3a)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:927:21 (clickhouse+0x1d0cc188) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Mutex M0 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0cc148) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0cc148)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:922:17 (clickhouse+0x1d0cc148)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Muex M0 acquired here while holding mutex M1 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0c7ce1) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0c7ce1)
        5 DB::Context::getPath() const build_docker/./src/Interpreters/Context.cpp:713:17 (clickhouse+0x1d0c7ce1)
        6 DB::loadDiskLocalConfig() build_docker/./src/Disks/DiskLocal.cpp:75:30 (clickhouse+0x1ce7ed8a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        7 DB::DiskLocal::applyNewSettings() build_docker/./src/Disks/DiskLocal.cpp:491:5 (clickhouse+0x1ce7e7ef) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        8 DB::DiskSelector::updateFromConfig() const build_docker/./src/Disks/DiskSelector.cpp:92:19 (clickhouse+0x1d14088e) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        9 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3388:49 (clickhouse+0x1d0ec002) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        ..
        17 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

      Mutex M1 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ebf25) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3384:21 (clickhouse+0x1d0ebf25)
        ..
        12 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

    SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) (/usr/bin/clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280) in pthread_mutex_lock
    ==================

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[6/6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 19:56:52 +02:00
Nikolai Kochetov
ba468eac45
Merge pull request #48485 from ClickHouse/read-step-for-system-zookeeper
Add reading step for system zookeeper. Analyze path from filter DAG.
2023-04-10 19:28:18 +02:00
Kseniia Sumarokova
65259d964b
Merge pull request #48167 from lzydmxy/add_columns_for_system_storage_policies
Add columns for table `system.storage_policies`
2023-04-10 18:32:13 +02:00
Igor Nikonov
e3b5072eb8
Merge pull request #48525 from ClickHouse/parallel-reading-from-file
Parallel processing right after reading `FROM file()`
2023-04-10 18:30:05 +02:00
Azat Khuzhin
79b83c4fd2 Remove superfluous includes of logger_userful.h from headers
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 17:59:30 +02:00
FriendLey
2a0de4bc16
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-10 21:14:49 +08:00
FriendLey
a67ea35875 format code and replace std function with Common utils. 2023-04-10 19:12:17 +08:00
Nikolai Kochetov
d564fe4e64 Fixing build 2023-04-10 10:54:37 +00:00
Nikolai Kochetov
28484cd762
Merge pull request #48522 from ClickHouse/many-mutations-memory-limit
Reduce memory usage for multiple alter delete mutations.
2023-04-10 12:50:42 +02:00
flynn
5a8d10c0e0 fix 2023-04-10 10:46:47 +00:00
Aleksei Filatov
e8bf96d126 Add unit tests 2023-04-10 13:02:43 +03:00
Aleksei Filatov
000c2b5b91 Correct FixupACL for auth scheme 2023-04-10 13:02:31 +03:00
FriendLey
9d5fc02c5e update code style. 2023-04-10 17:22:15 +08:00
FriendLey
890d4655a0 update code styl. 2023-04-10 17:06:31 +08:00
flynn
dfe9ce6ec4 fix 2023-04-10 08:27:55 +00:00
Raúl Marín
45ad555c39
Merge branch 'master' into zk_retry_timeout 2023-04-10 10:04:16 +02:00
Nikolay Degterinsky
8524f6958a
Update src/Interpreters/ReplaceQueryParameterVisitor.cpp
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2023-04-10 09:09:57 +02:00
flynn
feb1dce1e7
Merge branch 'master' into show-table 2023-04-10 14:55:16 +08:00
flynn
f87782b6b5 support show table 2023-04-10 06:37:47 +00:00
Alexey Milovidov
c279516ac1
Merge branch 'master' into parallel-reading-from-file 2023-04-10 08:02:50 +03:00
Nikolay Degterinsky
e71c7fe744
Fix 2023-04-10 03:48:58 +02:00
Nikolay Degterinsky
6b1c86c6ec
Don't use type conversion with String query parameters 2023-04-10 03:39:13 +02:00
Alexey Milovidov
dddca7d9a4
Merge pull request #48563 from ClickHouse/server-uuid-macro
Add support for `{server_uuid}` macro
2023-04-10 03:40:47 +03:00
Alexey Milovidov
1f6b9809dd Better exception messages for unparsed Bool 2023-04-10 02:32:04 +02:00
Igor Nikonov
1187534545 Simpler way to resize pipeline 2023-04-09 21:26:39 +00:00
Azat Khuzhin
211cea5e7c Fix uncaught exception in case of parallel loader for hashed dictionaries
Since ThreadPool::wait() rethrows the first exception (if any):

<details>

<summary>stacktrace</summary>

    2023.04.09 12:53:33.629333 [ 22361 ] {} <Fatal> BaseDaemon: (version 22.13.1.1, build id: 5FB01DCAAFFF19F0A9A61E253567F90685989D2F) (from thread 23032) Terminate called for uncaught exception:
    2023.04.09 12:53:33.630179 [ 23645 ] {} <Fatal> BaseDaemon:
    2023.04.09 12:53:33.630213 [ 23645 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f68b00baccc 0x7f68b006bef2 0x7f68b0056472 0x112a42fe 0x1c17f2a3 0x1c17f238 0xbf4bc3b 0x13961c6d 0x138ee529 0x138ed6bc 0x138dd2f0 0x138dd9c6 0x1571d0dd 0x16197c1f 0x161a231e 0x1619fc93 0x161a51b9 0x11151759 0x1115454e 0x7f68b00b8fd4 0x7f68b013966c
    2023.04.09 12:53:33.630247 [ 23645 ] {} <Fatal> BaseDaemon: 3. ? @ 0x7f68b00baccc in ?
    2023.04.09 12:53:33.630263 [ 23645 ] {} <Fatal> BaseDaemon: 4. gsignal @ 0x7f68b006bef2 in ?
    2023.04.09 12:53:33.630273 [ 23645 ] {} <Fatal> BaseDaemon: 5. abort @ 0x7f68b0056472 in ?
    2023.04.09 12:53:33.648815 [ 23645 ] {} <Fatal> BaseDaemon: 6. ./.build/./src/Daemon/BaseDaemon.cpp:456: terminate_handler() @ 0x112a42fe in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:33.651484 [ 23645 ] {} <Fatal> BaseDaemon: 7. ./.build/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x1c17f2a3 in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:33.654080 [ 23645 ] {} <Fatal> BaseDaemon: 8. ./.build/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:79: std::terminate() @ 0x1c17f238 in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:35.025565 [ 23645 ] {} <Fatal> BaseDaemon: 9. ? @ 0xbf4bc3b in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:36.495557 [ 23645 ] {} <Fatal> BaseDaemon: 10. DB::ParallelDictionaryLoader<(DB::DictionaryKeyType)0, true, true>::~ParallelDictionaryLoader() @ 0x13961c6d in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:37.833142 [ 23645 ] {} <Fatal> BaseDaemon: 11. DB::HashedDictionary<(DB::DictionaryKeyType)0, true, true>::loadData() @ 0x138ee529 in /usr/lib/debug/usr/bin/clickhouse.debug
    2023.04.09 12:53:39.124989 [ 23645 ] {} <Fatal> BaseDaemon: 12. DB::HashedDictionary<(DB::DictionaryKeyType)0, true, true>::HashedDictionary(DB::StorageID const&, DB::DictionaryStructure const&, std::__1::shared_ptr<DB::IDictionarySource>, DB::HashedDictionaryStorageConfiguration const&, std::__1::shared_ptr<DB::Block>) @ 0x138ed6bc in /usr/lib/debug/usr/bin/clickhouse.debug

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-09 22:52:51 +02:00
Alexey Milovidov
eda4a021a6
Merge branch 'master' into server-uuid-macro 2023-04-09 22:26:58 +03:00
Nikolay Degterinsky
10883d8af5 Allow commas with subqueries, add comments 2023-04-09 12:52:23 +00:00
Nikolay Degterinsky
6debaccd85 Fix build 2023-04-09 11:12:08 +00:00
FriendLey
fe21f301f0 update code style. 2023-04-09 17:24:54 +08:00
FriendLey
20527e03ac add soundex function. (#39880) 2023-04-09 16:41:11 +08:00
Alexey Milovidov
6292a08c9c Add a test 2023-04-09 03:25:38 +02:00
Alexey Milovidov
09ea79aaf7 Add support for {server_uuid} macro 2023-04-09 03:04:26 +02:00
Sergei Trifonov
b319271d59
Remove misleading comment
It is no longer "significant" after `NOEXCEPT_SCOPE` macro rework #39229
2023-04-08 22:50:24 +02:00
robot-clickhouse-ci-1
3302f1ff90
Merge pull request #48299 from CurtizJ/do-not-build-unnecessary-sets
Do not build sets for skip indexes if they are not used
2023-04-08 21:25:06 +02:00
Alexey Milovidov
5495cb2935
Merge pull request #48521 from ClibMouse/feature/tiny-improvement
Use std::string::starts_with instead of a roll your own variant
2023-04-08 22:19:48 +03:00
Alexey Milovidov
16fe18a7b6
Merge pull request #48520 from ClibMouse/feature/use-string-view-instead-of-strlen
Use std::string_view instead of strlen
2023-04-08 22:19:28 +03:00
Alexey Milovidov
c77acace86
Merge pull request #48528 from ClickHouse/bracketed
Fix bracketed-paste mode messing up password input in client reconnect
2023-04-08 22:16:02 +03:00
Alexey Milovidov
83dd5e0294
Merge pull request #48552 from ClickHouse/better-exception-message-zstd
Better exception message for ZSTD
2023-04-08 22:15:14 +03:00
Artem Pershin
2b00c8cb9b Fix typo in word acquired, in comment for lockForAlter method 2023-04-08 18:39:04 +03:00
Alexander Tokmakov
bf20e6bfc6
Merge pull request #48550 from ClickHouse/fix_sync_replica
Fix some tests
2023-04-08 14:41:10 +03:00
Nikolay Degterinsky
7161d3d380 Fixes 2023-04-08 00:49:53 +00:00
Alexey Milovidov
ec60a10694 Better exception message for ZSTD 2023-04-08 00:54:05 +02:00
Vitaly Baranov
62e9c419de
Merge pull request #48519 from azat/build/fwd-decl-threadpool
Use forward declaration of ThreadPool
2023-04-08 00:44:01 +02:00
Alexander Tokmakov
e39ee3f0af suppress a bug in filesystem cache 2023-04-07 22:54:49 +02:00
Nikolay Degterinsky
41891839a0
Merge pull request #48185 from evillique/add-kafka-murmur-hash-function
Add kafkaMurmurHash function
2023-04-07 22:06:56 +02:00
Alexander Tokmakov
9929185eab fix REPLACE_RANGE 2023-04-07 20:31:03 +02:00
Michael Kolupaev
6609004ca6
Merge branch 'master' into bracketed 2023-04-07 11:22:56 -07:00
Alexander Tokmakov
18a2eb355e fix a bug in sync replica 2023-04-07 20:16:25 +02:00
Michael Kolupaev
b6261104e7 Fix bracketed-paste mode messing up password input in client reconnect 2023-04-07 18:10:33 +00:00
Antonio Andelic
55a999d6a3
Merge branch 'master' into fix-topk-ubsan 2023-04-07 20:05:36 +02:00
Alexey Milovidov
e09e80b493
Merge pull request #48500 from CurtizJ/fix-sparse-column-query-cache
Fix query cache with sparse columns
2023-04-07 19:34:10 +03:00
kssenii
00282483c9 Address remaining review comments 2023-04-07 18:29:55 +02:00
Sergei Trifonov
396f6a6421
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-04-07 17:07:36 +02:00
Azat Khuzhin
44ae8485f1 Use one ThreadGroup while pushing to materialized views
Before this patch only the case when ThreadStatus (current_thread)
already has ThreadGroup works that way, after they will be identical in
this aspect.

But this should not affect anything, but it just make sense.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:37:35 +02:00
Azat Khuzhin
aacf2a0838 Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:32:08 +02:00
Azat Khuzhin
5b2b20a0b0 Rename ThreadGroupStatus to ThreadGroup
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:31:48 +02:00
Sema Checherinda
0503ed6fb8
Merge pull request #46668 from azat/fix-query_views_log-from-bg
Fix system.query_views_log for MVs that are pushed from background threads
2023-04-07 14:47:05 +02:00
Igor Nikonov
78038a3c2c Fix: do not resize pipeline when there is no files to process (globs expands to empty set) 2023-04-07 11:34:04 +00:00
MikhailBurdukov
54d7a412ec Fixed unit tests 2023-04-07 11:04:00 +00:00
Nikolay Degterinsky
a48655af39
Merge branch 'master' into add-kafka-murmur-hash-function 2023-04-07 12:21:16 +02:00
robot-ch-test-poll2
d13e8f8ddb
Merge pull request #48518 from ClibMouse/feature/remove-dead-code
Remove dead code and unused dependencies
2023-04-07 12:07:33 +02:00
alesapin
a0dd1c96bf
Merge pull request #48512 from ClickHouse/serxa-patch-3
Fix bytesSize() of zk SetRequest
2023-04-07 11:47:31 +02:00
Kseniia Sumarokova
d5889a47d6
Merge pull request #48311 from kssenii/rabbitmq-fix-cpu-usage
Fix cpu usage in rabbitmq (was worsened in 23.2 after #44404)
2023-04-07 11:44:48 +02:00
Azat Khuzhin
011480924a Use forward declaration of ThreadPool
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 11:25:35 +02:00
Antonio Andelic
67e6335250 Fix nullptr to memcpy 2023-04-07 08:32:01 +00:00
Sergei Trifonov
f0de79b21a
Merge branch 'master' into lost-part-count 2023-04-07 01:50:41 +02:00
Yakov Olkhovskiy
8d1924cc9a
Merge pull request #47962 from ClickHouse/imp-use-structure-from-insertion
Improvement and fix for use_structure_from_insertion_table_in_table_functions
2023-04-06 19:01:00 -04:00
serxa
343a071798 add lost_part_count column to system.replicas 2023-04-06 22:38:58 +00:00
Igor Nikonov
96213fa464 Fix header 2023-04-06 22:17:09 +00:00
Igor Nikonov
2e139c21d2 Parallel reading in FROM file() 2023-04-06 21:57:03 +00:00
robot-clickhouse-ci-2
2cb8252676
Merge pull request #48487 from azat/memory-tracker-fix-deadlock
Fix deadlock due to debug tracking of memory allocations
2023-04-06 23:50:44 +02:00
Dmitry Novik
a1552159e3 Fix style 2023-04-06 21:35:28 +00:00
ltrk2
4449e49e72 Mark a function inline 2023-04-06 13:28:30 -07:00
Nikolai Kochetov
57255eb56c Fix equals. 2023-04-06 19:22:10 +00:00
Dmitry Novik
a60c315b3e Support additional_result_filter 2023-04-06 19:18:26 +00:00
Nikolai Kochetov
e8fb135180 Reduce memory usage for multiple alter delete mutations. 2023-04-06 19:07:53 +00:00
ltrk2
790e570af6 Use std::string::starts_with instead of a roll your own variant 2023-04-06 11:57:44 -07:00
ltrk2
00c8e6e60d Use std::string_view instead of strlen 2023-04-06 11:39:33 -07:00
ltrk2
4544abc7d6 Remove dead code and unused dependencies 2023-04-06 11:37:12 -07:00
Anton Popov
8d1b535efb fix storage Memory with compression 2023-04-06 18:27:53 +00:00
Sergei Trifonov
b6975d36e9
Fix bytesSize() of zk SetRequest 2023-04-06 19:05:32 +02:00
Sema Checherinda
9d8d9e8ec9
Merge branch 'master' into fix-query_views_log-from-bg 2023-04-06 18:16:47 +02:00
Anton Popov
4757d76fbf fix query cache with sparse columns 2023-04-06 16:01:23 +00:00
MikhailBurdukov
5282a20aba Test and fix 2023-04-06 15:50:28 +00:00
Alexey Milovidov
4ab8b35b00
Merge pull request #48444 from ClickHouse/better-exception-messages-from-keeper-client
Better exception messages from Keeper client
2023-04-06 18:36:39 +03:00
Alexey Milovidov
3066d5df52
Merge pull request #48195 from ClickHouse/disable-compile-aggregations
Remove a feature
2023-04-06 18:09:48 +03:00
Anton Popov
b5a3723c88
Merge pull request #48395 from ClickHouse/with_fill_clarification
WITH FILL clarification and cleanup
2023-04-06 17:02:57 +02:00