Commit Graph

73 Commits

Author SHA1 Message Date
Alexander Kuzmenkov
6509f1eb39
Merge branch 'master' into minumum 2020-10-27 21:38:23 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell 2020-10-27 12:04:03 +01:00
Alexander Kuzmenkov
5cbf645de4 Merge remote-tracking branch 'origin/master' into tmp 2020-10-22 19:48:02 +03:00
Alexander Kuzmenkov
145e2b012f cleanup 2020-10-22 19:47:20 +03:00
alexey-milovidov
0b7430dda1
Merge pull request #16206 from ClickHouse/fix-memory-tracking
Fix multiple issues with memory tracking
2020-10-21 14:34:22 +03:00
Alexey Milovidov
2619efadc8 Fix multiple issues with memory tracking 2020-10-21 03:31:34 +03:00
Azat Khuzhin
e76066718d Fix query comments in query_log and server log (w/ enable_global_with_statement)
Plus, I guess that enable_global_with_statement will be enabled by
default someday, so it may become significant.

The enable_global_with_statement had been introduced in #15451

Cc: @amosbird
2020-10-20 21:10:36 +03:00
Alexander Kuzmenkov
6200433e12 Merge origin/master into tmp (using imerge) 2020-10-12 21:15:31 +03:00
Amos Bird
8e0862a0c3
BlockIO can be empty. 2020-10-10 23:25:50 +08:00
Amos Bird
dbc14655fc
Code refactoring. 2020-10-10 18:22:33 +08:00
Amos Bird
c9ab87ed17
Fix explain syntax 2020-10-08 17:06:04 +08:00
Alexander Kuzmenkov
244687bfc1 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 18:41:48 +03:00
Alexander Kuzmenkov
16ab4d59e6 don't shadow local var 2020-09-30 20:36:02 +03:00
Alexander Kuzmenkov
626c2a3e28 microsecond precision for start/finish time 2020-09-30 19:16:33 +03:00
bharatnc
b27579e3f7 Use std::chrono instead of clock_gettime 2020-09-25 10:39:37 -07:00
bharatnc
324a06145c EventTime - construct time in s and us from same timespec 2020-09-25 10:39:37 -07:00
bharatnc
f252523442 Query,QueryThread Logs - add event_time_microseconds field 2020-09-25 10:39:37 -07:00
Alexander Kuzmenkov
6217dd77b5 Merge remote-tracking branch 'origin/master' into tmp 2020-09-17 12:35:10 +03:00
tavplubix
28a6b7e622
Merge pull request #14831 from bharatnc/ncb/fix-timespec-construct
construct query_start_time & query_start_time_microseconds from the same timespec
2020-09-16 15:42:19 +03:00
bharatnc
dc765b77e7 Use std::chrono instead of clock_gettime 2020-09-15 09:37:32 -07:00
Nikolai Kochetov
6eac433c55 Review fixes. 2020-09-15 13:40:39 +03:00
bharatnc
e4e3105014 Construct query_start_time(_microseconds) from same timespec 2020-09-14 20:04:16 -07:00
Nikolai Kochetov
bcfc83022a Return query plan from storage. 2020-09-14 17:13:58 +03:00
Alexander Kuzmenkov
c62bf555d2 Merge origin/master into tmp (using imerge) 2020-09-08 16:26:38 +03:00
Alexander Kuzmenkov
d0a9926e7d fixes and some docs 2020-09-08 16:19:27 +03:00
bharatnc
44e168bea7 query_start_time_microseconds field in system.query_log
Add a new field called `query_start_time_microseconds`  that will add
`microseconds`. This new field will be of type `DateTime64`.
2020-09-04 09:42:18 -07:00
Alexander Kuzmenkov
c02f9e1dd1 remove some debug output to pass the tests 2020-08-29 01:48:48 +03:00
Alexander Kuzmenkov
063cc386a3 cosmetic fixes 2020-08-28 22:02:50 +03:00
Alexander Kuzmenkov
4612794678 opentelemetry context propagation 2020-08-28 04:21:08 +03:00
Alexander Kuzmenkov
54b3047d19 fixup 2020-08-27 21:44:20 +03:00
Alexander Kuzmenkov
05ad9b9fff opentelemetry wip 2020-08-20 23:59:58 +03:00
Azat Khuzhin
42dd661b6a Fix gcc10 build by reducing storage of the lambdas in executeQuery
There is no need to capture query AST for the status_info_to_query_log,
since callers already captured it anyway.

gcc10 reports:
    ../src/Interpreters/executeQuery.cpp: In member function ‘void std::__1::function<_Rp(_ArgTypes ...)>::swap(std::__1::function<_Rp(_ArgTypes ...)>&) [with _Rp = void; _ArgTypes = {DB::IBlockInputStream*, DB::IBlockOutputStream*, DB::QueryPipeline*}]’:
    ../src/Interpreters/executeQuery.cpp:490:49: error: array subscript 35 is outside array bounds of ‘std::__1::aligned_storage<32, 16>::type [1]’ [-Werror=array-bounds]
      490 |             auto status_info_to_query_log = [ast](QueryLogElement &element, const QueryStatusInfo &info) mutable
          |                                                 ^
    In file included from ../contrib/libcxx/include/algorithm:644,
                     from ../contrib/libcxx/include/__string:57,
                     from ../contrib/libcxx/include/string_view:175,
                     from ../contrib/libcxx/include/string:504,
                     from ../src/Common/formatReadable.h:3,                                                                                                  from ../src/Interpreters/executeQuery.cpp:1:
    ../contrib/libcxx/include/functional:1877:60: note: while referencing ‘__tempbuf’
     1877 |             typename aligned_storage<sizeof(__buf_)>::type __tempbuf;
          |                                                            ^~~~~~~~~
2020-08-19 21:25:28 +03:00
Azat Khuzhin
df359bd289 Fix logging Settings.Names/Values when log_queries_min_type > QUERY_START 2020-08-15 00:42:59 +03:00
Alexander Kuzmenkov
ddf0fe30b3
Merge pull request #13336 from ianton-ru/select_insert_time
Add QueryTimeMicroseconds, SelectQueryTimeMicroseconds and InsertQueryTimeMicroseconds
2020-08-08 01:05:46 +03:00
Anton Ivashkin
327090b7ea Add QueryTimeMicroseconds, SelectQueryTimeMicroseconds and InsertQueryTimeMicroseconds to system.events, second attempt 2020-08-04 19:38:13 +03:00
alexey-milovidov
65c755190e
Revert "Add QueryTimeMicroseconds, SelectQueryTimeMicroseconds and InsertQuer…" 2020-08-04 01:18:59 +03:00
Alexander Kuzmenkov
efb09d7ff5 Cleanup for #12999. NFC. 2020-07-31 17:53:41 +03:00
Anton Ivashkin
f4efe3c2fd Add QueryTimeMicroseconds, SelectQueryTimeMicroseconds and InsertQueryTimeMicroseconds to system.events 2020-07-29 13:32:18 +03:00
Amos Bird
63eebd7f6c
Add current_database to system.query_log 2020-07-22 12:00:16 +08:00
Nikolai Kochetov
57d727d078 Fix result_rows and result_bytes metrics for selects. 2020-07-02 17:51:10 +03:00
alesapin
2fac3290f0 Merge branch 'master' into atomic_metadata5 2020-06-17 11:14:03 +03:00
alesapin
1ddeb3d149 Buildable getSampleBlock in StorageInMemoryMetadata 2020-06-16 18:51:29 +03:00
Alexey Milovidov
511fa106af Better comment 2020-06-15 23:05:21 +03:00
Alexey Milovidov
1976b10ee0 Proper query formatting in logs #3853 2020-06-15 23:01:58 +03:00
Alexey Milovidov
25f941020b Remove namespace pollution 2020-05-31 00:57:37 +03:00
Alexey Milovidov
5aff138956 Preparation for structured logging 2020-05-31 00:35:52 +03:00
Nikolai Kochetov
1fa795988f Remove some code. 2020-05-28 11:24:59 +03:00
Nikolai Kochetov
2dcee3db5c Merge branch 'master' into remove-experimental-use-processors-flag-3 2020-05-27 21:25:34 +03:00
Nikolai Kochetov
e93882c977 Insert select using PipelineExecutor. 2020-05-27 21:20:26 +03:00
Alexey Milovidov
7e1813825b Return old names of macros 2020-05-24 01:24:01 +03:00