Commit Graph

19688 Commits

Author SHA1 Message Date
Alexey Milovidov
aa737b7a11 Allow to parse Date as YYYYMMDD 2021-10-30 00:23:03 +03:00
mergify[bot]
cf227c477a
Merge branch 'master' into alter_in_memory_db 2021-10-29 19:41:53 +00:00
Kseniia Sumarokova
6035e0498b
Merge pull request #30786 from kssenii/fix-filelog-test
Fix test 02022
2021-10-29 22:06:28 +03:00
Kseniia Sumarokova
bf290d0678
Merge pull request #30837 from kssenii/remove-redundant
Remove redundant from http buffer
2021-10-29 22:04:06 +03:00
Kseniia Sumarokova
2050d0a33d
Merge pull request #30793 from lingtaolf/feature/function_mapExtractKeyLike
Add  new function mapExtractKeyLike
2021-10-29 21:54:39 +03:00
tavplubix
a5901f2901
Update DatabasesCommon.cpp 2021-10-29 19:58:13 +03:00
Alexander Tokmakov
3933cd8259 support alter table for Memory database 2021-10-29 19:47:57 +03:00
Nikolai Kochetov
41c2c24b61 Fix protocol revision. 2021-10-29 19:18:36 +03:00
Nikolai Kochetov
73395e02be Fix UpgradableLock. 2021-10-29 18:08:01 +03:00
avogar
8213003422 Fix PVS check, mark tests as no-parallel 2021-10-29 16:51:57 +03:00
Kruglov Pavel
7d4f211d5b
Merge branch 'master' into tsv-csv 2021-10-29 16:38:06 +03:00
mergify[bot]
00b1024d75
Merge branch 'master' into map_combinator 2021-10-29 13:36:47 +00:00
kssenii
07bab5193f Delayed interactive 2021-10-29 16:23:53 +03:00
Kseniia Sumarokova
b49797ad51
Update ReadBufferFromS3.cpp 2021-10-29 15:54:40 +03:00
Nikolai Kochetov
a482ed3db3 Add custom ugradable lock. 2021-10-29 15:34:55 +03:00
feng lv
6f12348282 enable modify table comment of some table 2021-10-29 12:31:18 +00:00
Amos Bird
211c3d4d49
Better Projection IN 2021-10-29 20:24:36 +08:00
Amos Bird
0bf1efff97
Fix build 2021-10-29 19:51:34 +08:00
kssenii
12a27d445b Adjutments after merge with master 2021-10-29 09:29:35 +00:00
tavplubix
f50b2b651b
Merge pull request #30822 from ClickHouse/fix_29052
Fix ambiguity when extracting auxiliary ZooKeeper name
2021-10-29 12:15:29 +03:00
Filatenkov Artur
44b5dd1161
Refactoring in codec encrypted (#30564)
* refactoring

* remove mistake in docs
2021-10-29 11:44:28 +03:00
kssenii
b56c2f9499 Remove redundant lines from http buffer 2021-10-29 11:40:21 +03:00
kssenii
f17e321a73 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into retriable-http 2021-10-29 08:03:25 +00:00
kssenii
55f1ba857d Small fixes 2021-10-29 07:38:42 +00:00
alesapin
1869d094b2
Merge pull request #29205 from kssenii/disk-async-read
Try async read for remote fs disks
2021-10-29 10:17:17 +03:00
alesapin
8dfbb43059
Merge pull request #30800 from kitaisreal/dictionary-source-unknown-column-name-in-dictionary-fix
DictionarySource unknown column name fix
2021-10-29 10:14:26 +03:00
Kseniia Sumarokova
1cc1417ba4
Update StorageFileLog.cpp 2021-10-29 09:53:48 +03:00
凌涛
921bdbdd7d
Update src/Functions/map.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2021-10-29 14:51:34 +08:00
feng lv
13a305d648 filelog engine tests improve
fix
2021-10-29 06:25:21 +00:00
mergify[bot]
65df198e9b
Merge branch 'master' into conf-clickhouse 2021-10-28 22:19:42 +00:00
kssenii
4f3433b4e1 Some clean up before merging 2021-10-29 01:04:52 +03:00
kssenii
03d7476864 One more fix 2021-10-29 00:50:59 +03:00
Maksim Kita
08af73c8f4 DictionarySource fixed exception 2021-10-29 00:30:09 +03:00
Artur
89d8fb7622 correct test 2021-10-28 21:23:58 +00:00
Nickita Taranov
734bb5b026 support any serializable column 2021-10-28 23:17:45 +03:00
Artur
72685d0c78 refactoring and test improvement 2021-10-28 18:46:51 +00:00
Nikolai Kochetov
6914efe2db Fix build and pvs warning. 2021-10-28 20:41:20 +03:00
tavplubix
bb4a8e91f7
Create StorageReplicatedMergeTree.cpp 2021-10-28 20:25:31 +03:00
Alexander Tokmakov
c1310841d9 fix ambiguity when extracting auxiliary zk name 2021-10-28 19:19:41 +03:00
kssenii
7e2ea97e3c Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-28 18:46:21 +03:00
Maksim Kita
a8ef6cc3b6
Merge pull request #30734 from kitaisreal/sql-user-defined-functions-on-cluster-support
SQLUserDefinedFunctions support ON CLUSTER
2021-10-28 18:08:38 +03:00
Anton Ivashkin
6cda420b56 Cleanup after fail in localBackup 2021-10-28 17:50:59 +03:00
Kseniia Sumarokova
368cb74b4d
Merge pull request #30778 from ClickHouse/kssenii-remove-setting
Remove obsolete setting
2021-10-28 17:49:19 +03:00
alexey-milovidov
69bc2a8d2a
Merge pull request #30780 from ClickHouse/remove-cruft
Remove cruft
2021-10-28 17:42:18 +03:00
avogar
6e8c2ab28f Use small amount of memory on stack in PeekableReadBuffer 2021-10-28 17:02:07 +03:00
Kruglov Pavel
9b75ecd689
Merge pull request #28502 from azat/prewhere-column-fix
Fix "Column is not under aggregate function and not in GROUP BY" with PREWHERE
2021-10-28 16:18:02 +03:00
kssenii
d39840376f Review fixes 2021-10-28 15:44:12 +03:00
kssenii
8dd5c1b99d Remove http buffer update 2021-10-28 14:28:14 +03:00
Maksim Kita
b3598cd154 DictionarySource updated 2021-10-28 13:41:33 +03:00
kssenii
aeba8104d1 Some more fixes 2021-10-28 10:28:05 +00:00
tavplubix
33ffe11d03
Merge pull request #30346 from ClickHouse/fix_some_fetches_may_stuck
Try fix 'some fetches may stuck'
2021-10-28 13:10:15 +03:00
凌涛
39322cdbe2 add a new function mapExtractKeyLike 2021-10-28 17:15:32 +08:00
alexey-milovidov
c9a1cc53d3
Update Context.cpp 2021-10-28 11:48:59 +03:00
kssenii
3d01fbf603 Review fixes 2021-10-28 11:32:37 +03:00
kssenii
37cd91c0bf Fix 2021-10-28 07:59:57 +00:00
alexey-milovidov
b7b269b140
Merge pull request #30670 from jinjunzh/master
Improve filter bitmask generator function all in one with sse/avx2/avx512
2021-10-28 10:12:32 +03:00
Kseniia Sumarokova
acdcb53f18
Update Settings.h 2021-10-28 09:25:34 +03:00
Kseniia Sumarokova
fba0e11cff
Merge pull request #29471 from lingtaolf/feature/fucntion-mapContainsKeyLike
New function `mapContainsKeyLike`
2021-10-28 09:21:51 +03:00
Alexey Milovidov
8b4a6a2416 Remove cruft 2021-10-28 02:10:39 +03:00
Kseniia Sumarokova
afc0b2068c
Update Settings.h 2021-10-28 01:04:16 +03:00
alexey-milovidov
fab8da1c64
Merge pull request #30722 from ucasfl/filelog-engine
remove some unneeded header files
2021-10-27 23:35:03 +03:00
kssenii
82f3754b8a Slightly better 2021-10-27 20:20:15 +00:00
kssenii
9461e225bb Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-27 22:47:47 +03:00
kssenii
2647b88a66 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into retriable-http 2021-10-27 19:38:19 +00:00
kssenii
7024f51b55 Review fixes and add test 2021-10-27 19:37:36 +00:00
avogar
b4aae86fff Add comments, update docs 2021-10-27 22:16:48 +03:00
Vitaly Baranov
697776186a
Merge pull request #30725 from azat/fix-gtest_disk_encrypted
Fix gtest_disk_encrypted (for new readFile/createReadBufferFromFileBase() interfaces)
2021-10-27 19:49:23 +03:00
Maksim Kita
d6c0cde173 Updated UserDefinedSQLFunctionFactory 2021-10-27 18:49:18 +03:00
Maksim Kita
a332a4d15f
Merge pull request #30501 from kitaisreal/hashed-array-dictionary-optimize-read-multiple-attributes
HashedArrayDictionary optimize read multiple attributes
2021-10-27 18:45:07 +03:00
tavplubix
ac4a9bcf23
Fix 00975_move_partition_merge_tree (#30717)
* Revert "Fix race between MOVE PARTITION and merges/mutations for MergeTree"

This reverts commit e9ce859b02.

* fix

* Update StorageMergeTree.cpp

Co-authored-by: alesapin <alesapin@gmail.com>
2021-10-27 18:19:41 +03:00
Kruglov Pavel
0715566cc0
Merge branch 'master' into tsv-csv 2021-10-27 17:52:49 +03:00
avogar
d1ef96a5ef Add test, avoid unnecessary allocations, use PeekableReadBuffer only in corner case 2021-10-27 17:29:15 +03:00
Nikolai Kochetov
f7ef8bc373 Use upgradable_lock from boost. 2021-10-27 17:26:00 +03:00
tavplubix
d07d53f1b1
Merge pull request #29328 from aiven/kmichel-recover-replica-race
Fix hanging DDL queries on Replicated database
2021-10-27 16:43:21 +03:00
tavplubix
d7c69f6c02
Merge pull request #29202 from aiven/kmichel-replicated-database-alter-attach
Allow non-replicated ALTER TABLE FETCH/ATTACH in Replicated databases
2021-10-27 16:42:54 +03:00
Alexander Tokmakov
5e622d4c98 fix another issue 2021-10-27 15:59:26 +03:00
凌涛
996706101d optimized code 2021-10-27 19:53:53 +08:00
Maksim Kita
db18cb194c
Merge pull request #30736 from kitaisreal/dictionary-source-unknown-column-name-in-dictionary-fix
DictionarySource unknown column name in dictionary fix
2021-10-27 14:10:54 +03:00
Nikolai Kochetov
42d4aa5b4c Fix potrs order traverse. 2021-10-27 12:34:50 +03:00
alexey-milovidov
9f9b4968d7
Merge pull request #30663 from ClickHouse/fix_five_years_old_bug
Fix case-insensetive search in UTF8 strings
2021-10-27 12:10:12 +03:00
Maksim Kita
9e5337b5d4 DictionarySource unknown column name in dictionary fix 2021-10-27 11:51:47 +03:00
Maksim Kita
d523b28459 SQLUserDefinedFunctions support ON CLUSTER 2021-10-27 11:28:21 +03:00
Maksim Kita
fd002e327c Updated HashedArrayDictionary 2021-10-27 11:26:42 +03:00
alesapin
2af950d4d5
Merge pull request #30658 from ClickHouse/std_mutex_alter_lock
Change `alter_lock` from `RWLock` to `std::timed_mutex`
2021-10-27 11:14:11 +03:00
alesapin
a29711f1d0
Merge pull request #30651 from ClickHouse/fix_intersecting_parts_to_do
Fix intersecting parts in `parts_to_do`
2021-10-27 10:52:21 +03:00
alesapin
8749f4a31a
Merge pull request #29043 from nvartolomei/nv/parts-uuid-move-shard-kill
Part movements between shards improvements and cancel support
2021-10-27 10:46:00 +03:00
kssenii
20772fde04 For storage 2021-10-27 10:04:17 +03:00
Azat Khuzhin
9936ee5181 Update gtest_disk_encrypted for new readFile() interface 2021-10-27 09:37:26 +03:00
Azat Khuzhin
7ce01b328e Update gtest_disk_encrypted for new createReadBufferFromFileBase() interface 2021-10-27 09:37:26 +03:00
feng lv
4ac120b883 remove some unneeded header files 2021-10-27 04:13:12 +00:00
jasperzhu
49dd69c6c9 adjust header files 2021-10-27 05:22:05 +05:30
jasperzhu
0217ed09ac revise compile flag 2021-10-27 05:19:15 +05:30
jasperzhu
5ab55f7eaa fixed function defect 2021-10-27 04:21:46 +05:30
jasperzhu
27f30dab89 remove function due to extra latency 2021-10-27 03:44:28 +05:30
Azat Khuzhin
fbf98bea0b Fix "Column is not under aggregate function and not in GROUP BY" with PREWHERE
In 21.7 the function column type is unknown:

  (lldb) p tmp_actions_dag->dumpDAG()
  (std::string) $14 = "0 : INPUT () (no column) Int32 key\n1 : COLUMN () Const(UInt8) UInt8 1\n2 : FUNCTION (0) (no column) UInt8 ignore(key) [ignore]\n3 : FUNCTION (1, 2) (no column) UInt8 or(1, ignore(key)) [or]\nIndex: 0 1 2 3\n"
                                                                                                                                                                            ^^^^^^^^^^^

While in 21.8+ it is const:

  (lldb) p tmp_actions_dag->dumpDAG()
  (std::string) $22 = "0 : INPUT () (no column) Int32 key\n1 : COLUMN () Const(UInt8) UInt8 1\n2 : FUNCTION (0) (no column) UInt8 ignore(key) [ignore]\n3 : FUNCTION (1, 2) Const(UInt8) UInt8 or(1, ignore(key)) [or]\nIndex: 0 1 2 3\n"
                                                                                                                                                                            ^^^^^

This is after getRootActions() in SelectQueryExpressionAnalyzer::appendPrewhere()

v1: fix for SELECT only, but breaks virtual columns
v2: hacky fix, that also touches MergeTree code
v3: allow_remove_inputs=false
v4: allow_constant_folding=false instead
2021-10-26 22:57:48 +03:00
Azat Khuzhin
dd7bffcaf9 ActionsDAG: add allow_constant_folding flag for removeUnusedActions() 2021-10-26 22:56:44 +03:00
Azat Khuzhin
248b689067 ActionsDag: add allow_remove_inputs for other variants of removeUnusedActions() 2021-10-26 22:56:44 +03:00
Nikolai Kochetov
c7a07bafe0 Don't use a lot of stack for pipeline traverse. 2021-10-26 21:50:13 +03:00
jasperzhu
fb31410926 change to inline for bitmask generator 2021-10-27 00:05:47 +05:30
Nikita Mikhaylov
aae30a9e37
Fix fuzzer build (#30344) 2021-10-26 20:30:34 +03:00
Nikolai Kochetov
0f30513652
Revert "Revert "Improve usability of remote_url_allow_hosts"" 2021-10-26 20:17:02 +03:00
Nikolai Kochetov
403ff98baa
Revert "Improve usability of remote_url_allow_hosts" 2021-10-26 20:15:29 +03:00
jasperzhu
1caff8a81c fixed compile error 2021-10-26 22:12:21 +05:30
凌涛
d4d97d7b9a add new function mapContainsKeyLike
fixed error because of inconsistent offsets
2021-10-27 00:06:01 +08:00
Artur
20c5e9d321 refactoring, adding tests for local 2021-10-26 15:16:58 +00:00
Dmitry Novik
e971871a95
Merge pull request #30668 from azat/prewhere-always-true-where
Fix PREWHERE with WHERE in case of always true PREWHERE
2021-10-26 17:18:50 +03:00
Alexander Tokmakov
6be1e98342 fix 2021-10-26 17:06:48 +03:00
Maksim Kita
b58f819789
Merge pull request #30667 from kitaisreal/compiled-expression-cache-limit-elements-size
CompiledExpressionCache limit elements size
2021-10-26 16:43:49 +03:00
Nikolai Kochetov
b549bddc11
Merge pull request #29735 from ClickHouse/fix-backward-compatibility-after-21196
Fix backward compatibility after #21196.
2021-10-26 16:31:40 +03:00
Nikolai Kochetov
36c3b1d5b1
Merge pull request #30639 from ClickHouse/fix-30545
Fix argument types for now and now64
2021-10-26 16:29:18 +03:00
alexey-milovidov
329437abca
Merge pull request #30674 from ClickHouse/fix-indecency
Fix indecency #30337
2021-10-26 14:24:18 +03:00
mergify[bot]
ce88a84e88
Merge branch 'master' into nv/parts-uuid-move-shard-kill 2021-10-26 11:09:19 +00:00
alesapin
a679ece0fb Merge branch 'master' into fix_intersecting_parts_to_do 2021-10-26 14:02:05 +03:00
kssenii
2ba3ee830e Partitioned write part 2 2021-10-26 14:00:41 +03:00
Alexander Tokmakov
2e7e195e77 change alter_lock to std::timed_mutex 2021-10-26 13:37:00 +03:00
Alexander Tokmakov
a1cab43feb fix five years old bug in StingSearcher 2021-10-26 13:32:07 +03:00
Maksim Kita
dbf4811029 Updated documentation 2021-10-26 13:00:42 +03:00
Maksim Kita
6cf16862ab Fixed style check 2021-10-26 12:57:49 +03:00
Maksim Kita
73bbf7549a HashedArrayDictionary optimize read multiple attributes 2021-10-26 12:57:49 +03:00
Alexey Milovidov
da3e13b730 Fix indecency #30337 2021-10-26 10:00:19 +03:00
Alexey Milovidov
97bcceca44 Improve usability of remote_url_allow_hosts 2021-10-26 09:49:12 +03:00
alexey-milovidov
5434f1d149
Merge pull request #30337 from ClickHouse/fix-memory-indication
Fix consumed memory indication in clickhouse-client
2021-10-26 09:48:03 +03:00
alexey-milovidov
e7751c59f6
Merge pull request #30456 from CurtizJ/async-inserts-values
Support VALUES format in async inserts
2021-10-26 09:47:27 +03:00
alexey-milovidov
e528bfdb1a
Merge pull request #30565 from ClickHouse/try-to-fix-30397
Try to fix #30397
2021-10-26 09:45:45 +03:00
Azat Khuzhin
3a6f876abc gtest_getMultipleValuesFromConfig: switch <yandex> to <clickhouse> 2021-10-26 08:53:00 +03:00
jasperzhu
911b9c3973 Improve function defect 2021-10-26 06:02:57 +05:30
Azat Khuzhin
16cd70aee9 Fix PREWHERE with WHERE in case of always true PREWHERE 2021-10-26 00:02:41 +03:00
Maksim Kita
3810baf44c CompiledExpressionCache limit elements size 2021-10-26 00:00:57 +03:00
jasperzhu
3d115536f5 Improve filter bitmask generator function all in one with sse/avx2/avx512 2021-10-26 01:39:09 +05:30
Azat Khuzhin
f41cf281e4 Add QueryProfilerRuns profile event
This will help to investigate query latency spikes.
2021-10-25 21:14:16 +03:00
mergify[bot]
70097b5c4e
Merge branch 'master' into fix_intersecting_parts_to_do 2021-10-25 17:21:25 +00:00
kssenii
1d743b9259 Partitoned write 2021-10-25 19:23:44 +03:00
Alexander Tokmakov
5cdd9a4b99 fix intersecting parts in parts_to_do 2021-10-25 19:00:55 +03:00
Alexander Tokmakov
94088f8197 minor fixes 2021-10-25 17:01:36 +03:00
Dmitry Novik
8e680b068a Add comment with fix explanation 2021-10-25 16:53:23 +03:00
Kseniia Sumarokova
377b937aa5
Merge pull request #30244 from evillique/fix_like_function
Fix `LIKE` function
2021-10-25 16:35:37 +03:00
Anton Popov
b87c819c10
Merge pull request #30566 from nickitat/nickitat_nullable_4_arrayStringConcat
Support Nullable(String) type in arrayStringConcat
2021-10-25 16:04:20 +03:00
Maksim Kita
772c326f2d
Merge pull request #30500 from kitaisreal/dictionaries-read-multiple-threads
Dictionaries read support multiple threads
2021-10-25 15:31:50 +03:00
Alexander Tokmakov
075c3a37f4 Merge branch 'master' into fix_some_fetches_may_stuck 2021-10-25 15:28:54 +03:00
Nikolai Kochetov
05f42e2d07 Merge branch 'master' into refactor-pipeline-executor 2021-10-25 12:09:38 +03:00
Nikolai Kochetov
a0a5c1a21d Fix argument types for now and now64 2021-10-25 12:06:53 +03:00
alesapin
28bde879ed
Merge pull request #30455 from kssenii/deprecate-setting
Deprecate write_final_mark setting
2021-10-25 10:51:49 +03:00
alesapin
490ca93162
Merge pull request #30372 from ClickHouse/update_keeper_config
Updatable keeper configuration.
2021-10-25 10:37:03 +03:00
alesapin
aca3166a7c
Merge pull request #30550 from ClickHouse/fix_typo_update_nuraft
Fix typo and update NuRaft
2021-10-25 10:36:06 +03:00
kssenii
52296e8b04 Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-25 00:22:32 +03:00
alexey-milovidov
7200cb8bba
Merge pull request #30611 from azat/readbuffer-real-size
Replace estimated_size with optional<size> for readFile/createReadBufferFromFileBase
2021-10-24 23:37:30 +03:00
kssenii
13a2a3d307 Merge branch 'master' of github.com:ClickHouse/ClickHouse into deprecate-setting 2021-10-24 23:05:21 +03:00
Anton Popov
37de54937c fix use-after-free 2021-10-24 22:32:28 +03:00
Anton Popov
76cb191865
Merge pull request #30433 from kssenii/fix-positional
More full support of positional arguments
2021-10-24 21:48:17 +03:00
kssenii
658b33717f A little nicer 2021-10-24 20:43:34 +03:00
kssenii
5b15e2474c Checkout reading from local fs back to master version 2021-10-24 20:41:18 +03:00
kssenii
7de5fca075 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into retriable-http 2021-10-24 17:04:24 +00:00
Kruglov Pavel
855b10261c
Merge pull request #30285 from kssenii/fix-local-exceptions
Fix printing stacktraces for clickhouse-local
2021-10-24 19:54:59 +03:00
Kseniia Sumarokova
4667ea7883
Merge pull request #29774 from kssenii/remote-connection
Predefined configuration for table function remote
2021-10-24 19:38:01 +03:00
Azat Khuzhin
f9b27608f5 Fix reading of columns if offset_in_compressed_file is the same for mark range
Fixes: 00078_group_by_arrays
2021-10-24 18:58:22 +03:00
Azat Khuzhin
258b62d375 Remove one unused CompressedReadBufferFromFile ctor 2021-10-24 18:58:22 +03:00
Azat Khuzhin
34d8f78c33 Explictly pass size in DiskCacheWrapper::writeFile()
v0: Add explicit default value for DiskLocal::readFile()
v2: Explictly pass size in DiskCacheWrapper::writeFile()
    (since v0 not google-default-arguments compatible)
2021-10-24 18:58:22 +03:00
Azat Khuzhin
93c34824c0 Fix explicit 0 size for createReadBufferFromFileBase() 2021-10-24 18:58:22 +03:00
Azat Khuzhin
4599e9191b Fix explicit 0 size for readFile() 2021-10-24 18:58:22 +03:00
Azat Khuzhin
2b96433daf Replace estimated_size with optional<size> for IDisk::readFile()
v2: rebase to fix conflicts in DiskEncrypted.cpp
2021-10-24 18:58:11 +03:00
Vitaly Baranov
c0b01e7b0b
Merge pull request #30494 from vitlibar/fix-reading-from-empty-file-on-encrypted-disk
Fix reading from empty file on encrypted disk
2021-10-24 16:24:47 +03:00
Nickita Taranov
877e8b579b fix style 2021-10-24 14:45:12 +03:00
Kseniia Sumarokova
7383bdd5fa
Merge pull request #25969 from ucasfl/filelog-engine
Implementation of a table engine to consume application log files in ClickHouse
2021-10-24 10:14:05 +03:00
alexey-milovidov
f1e96ee9ac
Merge pull request #30594 from azat/fix-logical-error-on-connection-drain
Fix LOGICAL_ERROR on connection draining in case of ECONNRESET
2021-10-24 05:34:27 +03:00
alexey-milovidov
830b83218e
Merge pull request #30579 from azat/tsan-recursion
Fix tests that relies on checking stack size under TSan
2021-10-24 03:14:07 +03:00
alexey-milovidov
8c2413f6fe
Merge pull request #30562 from ClickHouse/fix-header-after-limit-push-down
Fix LimitStep header after limit push down optimization.
2021-10-24 00:19:02 +03:00
Azat Khuzhin
83d68246c3 Fix LOGICAL_ERROR on connection draining in case of ECONNRESET
In case of ECONNRESET (Connection reset by peer) the "cancelled" will
not be set, and so drain() will fail with LOGICAL_ERROR:

<details>

    2021.10.16 04:10:55.054771 [ 7635 ] {882164e0-ca26-4955-8759-708ba1f6e85c} <Error> PullingAsyncPipelineExecutor: Code: 210. DB::NetException: Connection reset by peer, while writing to socket (127.0.0.2:9000). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):

    ...
    4. ./obj-x86_64-linux-gnu/../src/Common/NetException.h:12: DB::NetException::NetException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x20db5749 in /usr/bin/clickhouse
    5. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:56: DB::WriteBufferFromPocoSocket::nextImpl() @ 0x211d56bb in /usr/bin/clickhouse
    6. ./obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:47: DB::WriteBuffer::next() @ 0x14e4c874 in /usr/bin/clickhouse
    7. ./obj-x86_64-linux-gnu/../src/Client/Connection.cpp:560: DB::Connection::sendCancel() @ 0x227c0c22 in /usr/bin/clickhouse
    8. ./obj-x86_64-linux-gnu/../src/Client/HedgedConnections.cpp:242: DB::HedgedConnections::sendCancel() @ 0x227f1b53 in /usr/bin/clickhouse
    ...
    2021.10.16 04:12:35.555530 [ 5575 ] {} <Fatal> : Logical error: 'Cannot drain connections: cancel first.'.

</details>

Found by stress tests on CI [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/d3cb99701d4aaec384fd183168d10e0f650ecc1d/stress_test_(debug).html#fail1
2021-10-23 22:44:32 +03:00
kssenii
1ecb6ad05d Better 2021-10-23 19:00:14 +00:00
Vitaly Baranov
26cb62de32 Add more tests for the "encrypted" disk type. 2021-10-23 20:58:37 +03:00
Kseniia Sumarokova
00d0665bf2
Merge pull request #30477 from kssenii/postgres-fix-query
More reliable fetch query in postgres database
2021-10-23 19:07:34 +03:00
kssenii
e04e37916e Review fixes 2021-10-23 18:20:31 +03:00
Anton Popov
cdfa36a181
Merge pull request #30266 from CurtizJ/aggregation-in-order-4
Improve performance of aggregation in order of primary key
2021-10-23 18:09:17 +03:00
kssenii
36d0f67b38 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remote-connection 2021-10-23 17:12:46 +03:00
Maksim Kita
4ccc619bd5 Added performance tests 2021-10-23 15:01:30 +03:00
Azat Khuzhin
b73092c169 Fix tests that relies on checking stack size under TSan
Under TSan using too much stack requires too much RSS for shadow memory,
and neither of this TSAN_OPTIONS helps:
- history_size=2
- flush_memory_ms=2000
- memory_limit_mb=50000

So instead, decrease allowed limit of the stack size in checkStackSize()
under TSan, to address exessive memory usage for the server compiled
with TSan.

Note, that before this patch 01763_max_distributed_depth test can
increase RSS of the server to 70GiB.
2021-10-23 14:09:19 +03:00
feng lv
235339d530 fix 2021-10-23 09:35:33 +00:00
Kseniia Sumarokova
05150f151c
Update ExpressionAnalyzer.cpp 2021-10-23 12:19:40 +03:00
Vladimir C
410624749e
Merge pull request #30492 from vdimir/fix-alter-scalar-deadlock 2021-10-23 12:01:00 +03:00
Kseniia Sumarokova
f362d420b8
Update fetchPostgreSQLTableStructure.cpp 2021-10-23 11:38:18 +03:00
kssenii
1fa123ee5c Properly done 2021-10-23 01:33:17 +03:00
Anton Popov
74cf57b4b0 fix for empty chunks 2021-10-22 21:48:03 +03:00
Nikolai Kochetov
ee6bc3883f Try to fix 30397 2021-10-22 19:25:48 +03:00
Nickita Taranov
2d23e3b17d support for ColumnString 2021-10-22 18:53:02 +03:00
Nickita Taranov
a211c9ecbc support nullable for ColumnConst 2021-10-22 18:52:59 +03:00
Anton Popov
7c458fbc4c fix style check 2021-10-22 18:04:11 +03:00
Nikolai Kochetov
e00d55c08d Try to fix 30397 2021-10-22 17:42:20 +03:00
Kseniia Sumarokova
153dd9a895
Update MergeTreeSettings.h 2021-10-22 16:27:01 +03:00
Nikolai Kochetov
54cc8e1d27 Fix LimitStep header after limit push down optimization. 2021-10-22 16:19:49 +03:00
kssenii
39b9e9c258 Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-22 15:40:41 +03:00
Filatenkov Artur
2384108ea5
remove trailing whitespaces 2021-10-22 15:32:24 +03:00
kssenii
a1a2e276ae Review fixes 2021-10-22 12:26:28 +00:00
Filatenkov Artur
328a605f7e
Merge branch 'ClickHouse:master' into add_parallel_reading_from_infile 2021-10-22 15:20:00 +03:00
Filatenkov Artur
1c72421e53
Add columns in columns.sql for INFORMATION_SCHEMA (#29637)
* add columns in columns.sql for INFORMATION_SCHEMA
2021-10-22 15:18:16 +03:00
Kseniia Sumarokova
5a60d9a3a3
Merge pull request #30521 from azat/local-fix
clickhouse-local: fix block lost in interactive mode
2021-10-22 14:49:39 +03:00
Maksim Kita
3a6f55607d Fixed IPAddressDictionary tests 2021-10-22 14:18:45 +03:00
Maksim Kita
243be5028a
Merge pull request #30014 from jinjunzh/master
add x86 feature avx2/avx512 support for accelerating filter operation
2021-10-22 14:16:47 +03:00
Anton Popov
151daf61c1
Merge pull request #30522 from azat/remove-check_columns
Remove check_columns argument from MergeTree code (false was never passed)
2021-10-22 14:06:49 +03:00
Maksim Kita
fc8a515b42
Merge pull request #30431 from vesslanjin/remove-branchy-code-in-ColumnDecimal
remove branch in ColumnDecimal, same as pull req #29881
2021-10-22 13:24:44 +03:00
Kseniia Sumarokova
057fe51ec8
Update TableFunctionPostgreSQL.cpp 2021-10-22 13:08:38 +03:00
kssenii
c95a29edac Fix quoting 2021-10-22 10:07:23 +00:00
vdimir
cfb98d381c
Do not use default scalars in MutationsInterpreter::prepareInterpreterSelectQuery 2021-10-22 12:47:28 +03:00
Nikolai Kochetov
1533f4af57
Merge pull request #30335 from ClickHouse/single-sorting-step
Single sorting step
2021-10-22 11:34:29 +03:00
Vladimir C
d60f00bab8
Merge pull request #30520 from azat/fix-unary-postfix-rewrite 2021-10-22 11:31:36 +03:00
alesapin
d849f56cd4 Fix typo and update NuRaft 2021-10-22 11:24:18 +03:00
Maksim Kita
6561f9bed2
Merge pull request #30483 from kitaisreal/sql-user-defined-functions-composition-fix
SQLUserDefinedFunctions composition fix
2021-10-22 10:16:31 +03:00
mergify[bot]
b043a04767
Merge branch 'master' into update_keeper_config 2021-10-22 07:12:42 +00:00
feng lv
54dc9693fb fix 2021-10-22 07:08:08 +00:00
feng lv
5cb783aed0 fix 2021-10-22 02:36:24 +00:00
kssenii
7f2c5dcaae Fix clang-tidy 2021-10-22 01:08:58 +03:00
Azat Khuzhin
b0984a3337 clickhouse-local: fix block lost in interactive mode
In case only one block in the query execution, LocalConnection can
return Progress packet instead of the block itself, after it will call
poll() again and the block will got lost.

Fix this by processing block before Progress packet.

And actually AFAICS Progress can be removed after pollImpl(), since
there is Progress handling before.

Fixes: #30282 (cc @kssenii)
2021-10-22 00:46:01 +03:00
Maksim Kita
117cb6c614 Fixed RangeHashedDictionary tests 2021-10-22 00:22:32 +03:00
Maksim Kita
adaa14f8aa
Merge pull request #30502 from kitaisreal/storage-dictionary-fix-potential-configuration-race
StorageDictionary fix potential configuration race
2021-10-22 00:14:11 +03:00
Azat Khuzhin
496aa43a9f Remove check_columns argument from MergeTree code (false was never passed) 2021-10-21 21:24:59 +03:00
Azat Khuzhin
e1b6acfa52 Add missing parenthesis for isNotNull/isNull rewrites to IS [NOT] NULL
After #29446 the following query was "broken":

    select isNotNull(1)+isNotNull(2) from remote('127.2', system.one)

This was also a problem for queries to external storages (i.e. mysql),
since it also uses query rewrite, like non-local distributed queries.

Fixes: #29446
2021-10-21 21:18:00 +03:00
kssenii
56f0560c46 Asserts and read till end option 2021-10-21 20:54:03 +03:00
Vitaly Baranov
5695ef55b3
Merge pull request #28125 from vitlibar/fix-writing-storage-log-marks
Fix writing marks in StorageLog
2021-10-21 20:10:01 +03:00
Vitaly Baranov
172a6f2e0d Fix reading from empty file on encrypted disk. 2021-10-21 19:31:29 +03:00
Maksim Kita
4ea969350b Fixed build 2021-10-21 18:43:33 +03:00
kssenii
120b01e089 Better 2021-10-21 18:22:17 +03:00
vdimir
039af96b61
Set execute_scalar_subqueries in MutationsInterpreter only for MergeTree and prepareInterpreterSelectQuery 2021-10-21 18:05:46 +03:00
avogar
8aad00818a Fix build 2021-10-21 18:01:23 +03:00
Dmitry Novik
58ee783be4
Merge pull request #30293 from amosbird/projection-fix19
Fix projections with JOIN alias columns
2021-10-21 17:49:21 +03:00
avogar
b50fff4e2b Fix style 2021-10-21 17:33:26 +03:00
Maksim Kita
8885748a6c StorageDictionary fix potential configuration race 2021-10-21 17:25:53 +03:00
Maksim Kita
a3a780bbf5 Dictionaries read support multiple threads 2021-10-21 17:17:53 +03:00
Anton Popov
b1a74af44d
Merge pull request #30180 from CurtizJ/remove-sample-by
Allow to remove `SAMPLE BY` expression
2021-10-21 17:09:53 +03:00
tavplubix
4c5104b30d
Merge pull request #30432 from ClickHouse/tavplubix-patch-3
Fix segfault on REPLACE PARTITION if session expired
2021-10-21 17:08:57 +03:00
avogar
7a37e24b52 Small fix in deserializeWholeText 2021-10-21 16:58:25 +03:00
avogar
d5c5a3213b Add custom null representation support for TSV/CSV input formats, fix bugs in deserializing NULLs in some cases 2021-10-21 16:52:27 +03:00
mergify[bot]
86e1bb6b55
Merge branch 'master' into fix_like_function 2021-10-21 12:24:28 +00:00
Ilya Golshtein
551a1065c1 output_format_avro_rows_in_file default is 1000000 2021-10-21 14:19:25 +03:00
vdimir
ed0bb2cec2
Fix deadlock on ALTER with scalar subquery to the same table 2021-10-21 14:02:51 +03:00
Kseniia Sumarokova
da0021c82f
Merge pull request #30412 from ClickHouse/kssenii-fix-test
Follow-up for #30282
2021-10-21 12:48:10 +03:00
Kruglov Pavel
27e8a83269
Merge pull request #30426 from amosbird/jsonextractstring3
JSONExtractString raw string support.
2021-10-21 12:29:11 +03:00
Vladimir C
388c3123f0
Merge pull request #30370 from Enmk/fix_session_log 2021-10-21 11:07:48 +03:00
mergify[bot]
aee446352a
Merge branch 'master' into update_keeper_config 2021-10-21 07:48:23 +00:00
Maksim Kita
650a79a907 SQLUserDefinedFunctions composition fix 2021-10-21 10:08:08 +03:00
Kseniia Sumarokova
feeb572219
Merge pull request #30474 from kssenii/sql-json-fix
sql json change order of arguments
2021-10-21 09:47:12 +03:00
Kseniia Sumarokova
5544e866f8
Merge pull request #30219 from lhuang09287750/master
make date32 type comparable with date/datetime/string
2021-10-21 09:38:55 +03:00
Ilya Golshtein
82f33151e7 output_format_avro_rows_in_file fixes per code review 2021-10-21 02:53:39 +03:00
kssenii
ec7c93728b Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-local-exceptions 2021-10-20 23:42:27 +00:00
kssenii
5a51d1c29b Merge branch 'fix-positional' of github.com:kssenii/ClickHouse into fix-positional 2021-10-20 23:40:52 +00:00
kssenii
bc4c2f2366 Fix clang-tidy 2021-10-20 23:40:21 +00:00
kssenii
a223526f45 Fix 2021-10-20 23:29:35 +00:00
kssenii
e4e157688d Review fixes 2021-10-21 01:57:43 +03:00
kssenii
c96b884951 Fix 2021-10-20 20:47:34 +00:00
alexey-milovidov
d3df1c02bc
Merge pull request #29672 from ClickHouse/clickhouse-obfuscator-2
More enhancements for query obfuscator
2021-10-20 23:06:29 +03:00
Maksim Kita
e550e0c22d
Merge pull request #30435 from kitaisreal/sql-user-defined-functions-support-lambdas
SQLUserDefinedFunctions support lambdas
2021-10-20 21:36:52 +03:00
Maksim Kita
1b4829d071
Merge pull request #30454 from kitaisreal/sql-user-defined-functions-create-or-replace-no-exists-support
SQLUserDefinedFunctions support CREATE OR REPLACE, CREATE IF NOT EXISTS
2021-10-20 21:36:42 +03:00
Kseniia Sumarokova
cae31437e8
Merge pull request #30336 from kssenii/fix-local-defaults
Send table columns in clickhouse-local
2021-10-20 21:18:02 +03:00