Commit Graph

6678 Commits

Author SHA1 Message Date
alesapin
be183027b3
Merge pull request #16516 from zlobober/remove_g0
Remove -g0 form Arcadia build settings.
2020-10-30 13:58:08 +03:00
alesapin
182f9fbdca Remove wrong assertion from SSDComplexKeyCacheDictionary 2020-10-30 12:36:46 +03:00
alesapin
15ba4dd851 Review fix 2020-10-30 11:52:11 +03:00
alesapin
b34960bffa Merge branch 'master' into system_fetches_table 2020-10-30 11:33:37 +03:00
alesapin
e06f65ee73
Merge pull request #16521 from myrrc/improvement/avro-format-lc
Fixing the inability to deserialize AVRO into table if it contains LowCardinality columns
2020-10-30 11:31:22 +03:00
Azat Khuzhin
3661769e1b Remove some absolute changes for errorCodeToName/system.errors 2020-10-30 09:04:22 +03:00
feng lv
f428675b6e fix parseDateTimeBestEffortOrNull with empty string 2020-10-30 05:42:10 +00:00
Amos Bird
18c5abc44e
Allow fetching duplicate parts to detach 2020-10-30 10:55:50 +08:00
Azat Khuzhin
ce9897bfd8 Fix readability-container-size-empty in StorageSystemErrors.cpp 2020-10-30 00:07:40 +03:00
Azat Khuzhin
0cd79de632 Eliminate extra strlen() in errorCodeToName() 2020-10-29 21:53:09 +03:00
Azat Khuzhin
cb50886ef1 Fix ErrorCodes increment on error 2020-10-29 21:24:52 +03:00
Azat Khuzhin
04bff595d3 Make check-style happy (by not using DB::ErrorCodes:: in comments) 2020-10-29 21:10:20 +03:00
Azat Khuzhin
7e79769ae4 Fix readability-inconsistent-declaration-parameter-name in ErrorCodes.h 2020-10-29 21:08:09 +03:00
myrrc
9564a7f6d1 simplified the cast 2020-10-29 20:30:24 +03:00
myrrc
68b47f5f61 removing LC in AVRO input format if needed 2020-10-29 20:24:54 +03:00
Pavel Kruglov
dbfef325e6 Rename NullSink to NullOutput 2020-10-29 20:22:48 +03:00
alexey-milovidov
434f6227cb
Merge pull request #16451 from ClickHouse/decimal-round-fuzz
Decimal round fuzz
2020-10-29 20:04:34 +03:00
Nikolai Kochetov
1c106691b5
Merge pull request #16423 from amosbird/jbodread
Balanced reading from JBOD
2020-10-29 19:22:45 +03:00
Maxim Akhmedov
3627fabfb9 Remove -g0 form Arcadia build settings. 2020-10-29 17:37:23 +03:00
tavplubix
2a66c17472
Update InterpreterDropQuery.cpp 2020-10-29 16:37:59 +03:00
alesapin
40fc512e79 Merge branch 'master' into no_background_pool_no_more 2020-10-29 12:53:34 +03:00
Azat Khuzhin
b42f77a791 Covert error codes list to lookup table and drop generation of them. 2020-10-29 10:55:41 +03:00
Azat Khuzhin
b7eac807f5 Fix readability-qualified-auto in errorCodeToName() 2020-10-29 10:55:41 +03:00
Azat Khuzhin
a81b0418ac Make errorCodeToName() return LowCardinality(String) 2020-10-29 10:55:41 +03:00
Azat Khuzhin
b2e2322895 Add system.errors table
Contains error codes with number of times they have been triggered.

Columns:

-   `name` ([String](../../sql-reference/data-types/string.md)) — name of the error (`errorCodeToName`).
-   `code` ([Int32](../../sql-reference/data-types/int-uint.md)) — code number of the error.
-   `value` ([UInt64](../../sql-reference/data-types/int-uint.md)) - number of times this error has been happened.

**Example**

``` sql
SELECT *
FROM system.errors
WHERE value > 0
ORDER BY code ASC
LIMIT 1

┌─name─────────────┬─code─┬─value─┐
│ CANNOT_OPEN_FILE │   76 │     1 │
└──────────────────┴──────┴───────┘
2020-10-29 10:55:38 +03:00
Azat Khuzhin
3fb8d08dd4 Add errorCodeToName() function
This patch adds errorCode() function that will return macro name by the
exception code, useful for analyzing query_log and similar.

Later some descriptions can be added.

v2: replace hana::map/fusion::vector with external script
v3:
- use binary cmake dir for .sh
- use jump table over suboptimal std::unordered_map (with very poor hash
  function for int -- std::hash)
- cleanup errorCodeToName (drop extra templates and headers)
- rename errorCode -> errorCodeToName
- fix arcadia build (by not providing those helpers there)
- fix build on CI, by using CMAKE_CXX_COMPILER for parsing the file
2020-10-29 10:55:00 +03:00
taichong
bb1ac2af82 Shrink sequence gtid set
when use MySQL Master -> MySQL Slave -> ClickHouse MaterializeMySQL
Engine

and MySQL Slave enable slave_parallel_worker the gtid in .metadata won't
shrink.

Like this:

https://github.com/ClickHouse/ClickHouse/issues/15951
2020-10-29 15:11:27 +08:00
Nikolai Kochetov
671d2b7f1b
Update MergeTreeReadPool.cpp
Fix comment
2020-10-29 10:04:23 +03:00
alexey-milovidov
0faf2bc7e3
Merge pull request #16332 from ClickHouse/fix-queue-processing-of-very-large-entries
Fix processing of very large entries in queue
2020-10-29 09:09:29 +03:00
Alexey Milovidov
1e99ce5f3a Merge branch 'master' into decimal-round-fuzz 2020-10-29 04:57:43 +03:00
alexey-milovidov
bf3acecf6f
Merge pull request #16032 from Avogar/mysql_bug
Don't touch MySQL database if it's unnecessary
2020-10-29 04:14:26 +03:00
Nikolai Kochetov
10bad32fb4 Refactor code a little bit. Add comment. 2020-10-29 00:52:26 +03:00
Amos Bird
f995ef9797
Balanced reading from JBOD 2020-10-29 04:05:07 +08:00
alesapin
57c3935a26
Merge pull request #16426 from kssenii/rabbit-optimize
Optimize rabbitmq engine
2020-10-28 22:24:22 +03:00
tavplubix
a1f1db753b
Update CompressedReadBufferBase.cpp 2020-10-28 18:23:10 +03:00
alesapin
9830ff1003
Merge pull request #16094 from nvartolomei/nv/wal-metadata-compatibility
RFC: Add metadata section to MergeTreeWriteAheadLog
2020-10-28 15:54:46 +03:00
alesapin
8e8bdeb5d7
Merge pull request #16434 from ClickHouse/fix_fake_race_on_merges_list
Fix fake race condition on system.merges merge_algorithm
2020-10-28 15:51:53 +03:00
tavplubix
cd70dc82cd
Merge pull request #16409 from azat/drop-distributed-fix
Fix DROP TABLE for Distributed (racy with INSERT)
2020-10-28 14:10:32 +03:00
alesapin
3c31a5134e Fix bug 2020-10-28 14:03:26 +03:00
tavplubix
4a63f1271b
Merge pull request #16244 from ClickHouse/fix_race_data_parts_exchange_endpoint
Fix race on StorageReplicatedMergeTree::data_parts_exchange_endpoint
2020-10-28 13:25:55 +03:00
tavplubix
22847613d1
Merge pull request #16437 from ClickHouse/addition_to_16127
Addition to #16127
2020-10-28 13:03:13 +03:00
alesapin
c10370f98d Merge branch 'master' into fix-queue-processing-of-very-large-entries 2020-10-28 11:19:34 +03:00
alesapin
8a6be1602b
Merge pull request #16364 from ClickHouse/fix_uuid_mapping_exists
Minor improvements in DatabaseCatalog
2020-10-28 10:54:39 +03:00
alesapin
617e42ddb4
Merge branch 'master' into rabbit-optimize 2020-10-28 10:24:05 +03:00
alesapin
1c9e24b5e2 Merge branch 'master' into system_fetches_table 2020-10-28 10:20:04 +03:00
alexey-milovidov
df828a6a6c
Merge pull request #16410 from ClickHouse/fix-quantile-deterministic
Fix debug assertion in quantileDeterministic function.
2020-10-28 09:24:46 +03:00
Alexander Kuzmenkov
ba34145817
Merge pull request #16425 from filimonov/minumum
Fix typos reported by codespell
2020-10-28 08:07:18 +03:00
Alexey Milovidov
7254f40ba8 Add range check for "scale" argument of decimal rounding function to prevent overflow 2020-10-28 04:16:52 +03:00
Alexey Milovidov
f573aeb97e Whitespace 2020-10-28 03:32:31 +03:00
Alexander Tokmakov
05099bebcf fix 2020-10-28 03:29:18 +03:00
alexey-milovidov
4911f334bf
Merge pull request #16429 from ClickHouse/dict-get-load-exception
Fix another double free for shared exception message in case of dictGet from not loaded dictionary
2020-10-28 02:07:03 +03:00
alexey-milovidov
948ac657dc
Merge pull request #16406 from ClickHouse/fix-tsan-lgamma
Fix TSan report in lgamma
2020-10-28 01:59:50 +03:00
Alexander Tokmakov
b5ccb5ed5b review suggestions 2020-10-27 23:52:49 +03:00
kssenii
4b59882c30 Remove redundant, add virt col 2020-10-27 20:34:31 +00:00
Alexander Tokmakov
dba8c85ae4 do not wait while holding lock 2020-10-27 22:56:54 +03:00
Alexander Kuzmenkov
6509f1eb39
Merge branch 'master' into minumum 2020-10-27 21:38:23 +03:00
Azat Khuzhin
fc14fde24a Fix DROP TABLE for Distributed (racy with INSERT)
<details>

```

drop() on T1275:

    0  DB::StorageDistributed::drop (this=0x7f9ed34f0000) at ../contrib/libcxx/include/__hash_table:966
    1  0x000000000d557242 in DB::DatabaseOnDisk::dropTable (this=0x7f9fc22706d8, context=..., table_name=...)
       at ../contrib/libcxx/include/new:340
    2  0x000000000d6fcf7c in DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7f9e42560dc0, query=...)
       at ../contrib/libcxx/include/memory:3826
    3  0x000000000d6ff5ee in DB::InterpreterDropQuery::execute (this=0x7f9e42560dc0) at ../src/Interpreters/InterpreterDropQuery.cpp:50
    4  0x000000000daa40c0 in DB::executeQueryImpl (begin=<optimized out>, end=<optimized out>, context=..., internal=<optimized out>,
       stage=DB::QueryProcessingStage::Complete, has_query_tail=false, istr=0x0) at ../src/Interpreters/executeQuery.cpp:420
    5  0x000000000daa59df in DB::executeQuery (query=..., context=..., internal=internal@entry=false, stage=<optimized out>,
       may_have_embedded_data=<optimized out>) at ../contrib/libcxx/include/string:1487
    6  0x000000000e1369e6 in DB::TCPHandler::runImpl (this=this@entry=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:254
    7  0x000000000e1379c9 in DB::TCPHandler::run (this=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:1326
    8  0x000000001086fac7 in Poco::Net::TCPServerConnection::start (this=this@entry=0x7f9ddf3a9000)
       at ../contrib/poco/Net/src/TCPServerConnection.cpp:43
    9  0x000000001086ff2b in Poco::Net::TCPServerDispatcher::run (this=0x7f9e4eba5c00)
       at ../contrib/poco/Net/src/TCPServerDispatcher.cpp:114
    10 0x00000000109dbe8e in Poco::PooledThread::run (this=0x7f9e4a2d2f80) at ../contrib/poco/Foundation/src/ThreadPool.cpp:199
    11 0x00000000109d78f9 in Poco::ThreadImpl::runnableEntry (pThread=<optimized out>)
       at ../contrib/poco/Foundation/include/Poco/SharedPtr.h:401
    12 0x00007f9fc3cccea7 in start_thread (arg=<optimized out>) at pthread_create.c:477
    13 0x00007f9fc3bebeaf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

StorageDistributedDirectoryMonitor on T166:

    0  DB::StorageDistributedDirectoryMonitor::StorageDistributedDirectoryMonitor (this=0x7f9ea7ab1400, storage_=..., path_=...,
       pool_=..., monitor_blocker_=..., bg_pool_=...) at ../src/Storages/Distributed/DirectoryMonitor.cpp:81
    1  0x000000000dbf684e in std::__1::make_unique<> () at ../contrib/libcxx/include/memory:3474
    2  DB::StorageDistributed::requireDirectoryMonitor (this=0x7f9ed34f0000, disk=..., name=...)
       at ../src/Storages/StorageDistributed.cpp:682
    3  0x000000000de3d5fa in DB::DistributedBlockOutputStream::writeToShard (this=this@entry=0x7f9ed39c7418, block=..., dir_names=...)
       at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:634
    4  0x000000000de3e214 in DB::DistributedBlockOutputStream::writeAsyncImpl (this=this@entry=0x7f9ed39c7418, block=...,
       shard_id=shard_id@entry=79) at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:539
    5  0x000000000de3e47b in DB::DistributedBlockOutputStream::writeSplitAsync (this=this@entry=0x7f9ed39c7418, block=...)
       at ../contrib/libcxx/include/vector:1546
    6  0x000000000de3eab0 in DB::DistributedBlockOutputStream::writeAsync (block=..., this=0x7f9ed39c7418)
       at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:141
    7  DB::DistributedBlockOutputStream::write (this=0x7f9ed39c7418, block=...)
       at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:135
    8  0x000000000d73b376 in DB::PushingToViewsBlockOutputStream::write (this=this@entry=0x7f9ea7a8cf58, block=...)
       at ../src/DataStreams/PushingToViewsBlockOutputStream.cpp:157
    9  0x000000000d7853eb in DB::AddingDefaultBlockOutputStream::write (this=0x7f9ed383d118, block=...)
       at ../contrib/libcxx/include/memory:3826
    10 0x000000000d740790 in DB::SquashingBlockOutputStream::write (this=0x7f9ed383de18, block=...)
       at ../contrib/libcxx/include/memory:3826
    11 0x000000000d68c308 in DB::CountingBlockOutputStream::write (this=0x7f9ea7ac6d60, block=...)
       at ../contrib/libcxx/include/memory:3826
    12 0x000000000ddab449 in DB::StorageBuffer::writeBlockToDestination (this=this@entry=0x7f9fbd56a000, block=..., table=...)
       at ../src/Storages/StorageBuffer.cpp:747
    13 0x000000000ddabfa6 in DB::StorageBuffer::flushBuffer (this=this@entry=0x7f9fbd56a000, buffer=...,
       check_thresholds=check_thresholds@entry=true, locked=locked@entry=false, reset_block_structure=reset_block_structure@entry=false)
       at ../src/Storages/StorageBuffer.cpp:661
    14 0x000000000ddac415 in DB::StorageBuffer::flushAllBuffers (reset_blocks_structure=false, check_thresholds=true, this=0x7f9fbd56a000)
        at ../src/Storages/StorageBuffer.cpp:605

shutdown() on T1275:

    0  DB::StorageDistributed::shutdown (this=0x7f9ed34f0000) at ../contrib/libcxx/include/atomic:1612
    1  0x000000000d6fd938 in DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7f98530c79a0, query=...)
       at ../src/Storages/TableLockHolder.h:12
    2  0x000000000d6ff5ee in DB::InterpreterDropQuery::execute (this=0x7f98530c79a0) at ../src/Interpreters/InterpreterDropQuery.cpp:50
    3  0x000000000daa40c0 in DB::executeQueryImpl (begin=<optimized out>, end=<optimized out>, context=..., internal=<optimized out>,
       stage=DB::QueryProcessingStage::Complete, has_query_tail=false, istr=0x0) at ../src/Interpreters/executeQuery.cpp:420
    4  0x000000000daa59df in DB::executeQuery (query=..., context=..., internal=internal@entry=false, stage=<optimized out>,
       may_have_embedded_data=<optimized out>) at ../contrib/libcxx/include/string:1487
    5  0x000000000e1369e6 in DB::TCPHandler::runImpl (this=this@entry=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:254
    6  0x000000000e1379c9 in DB::TCPHandler::run (this=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:1326
    7  0x000000001086fac7 in Poco::Net::TCPServerConnection::start (this=this@entry=0x7f9ddf3a9000)
       at ../contrib/poco/Net/src/TCPServerConnection.cpp:43
    8  0x000000001086ff2b in Poco::Net::TCPServerDispatcher::run (this=0x7f9e4eba5c00)
       at ../contrib/poco/Net/src/TCPServerDispatcher.cpp:114
    9  0x00000000109dbe8e in Poco::PooledThread::run (this=0x7f9e4a2d2f80) at ../contrib/poco/Foundation/src/ThreadPool.cpp:199
    10 0x00000000109d78f9 in Poco::ThreadImpl::runnableEntry (pThread=<optimized out>)
       at ../contrib/poco/Foundation/include/Poco/SharedPtr.h:401
    11 0x00007f9fc3cccea7 in start_thread (arg=<optimized out>) at pthread_create.c:477
    12 0x00007f9fc3bebeaf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

```

</details>
2020-10-27 21:19:36 +03:00
Nikolai Kochetov
c7236a9359 Try fix tests. 2020-10-27 19:12:53 +03:00
alesapin
3ec5fc7a4c Add explicit 2020-10-27 18:29:06 +03:00
alesapin
60f2d822d7 Fix fake race condition on system.merges merge_algorithm 2020-10-27 18:27:12 +03:00
alexey-milovidov
42eb784a26
Update AggregateFunctionWelchTTest.h 2020-10-27 17:55:19 +03:00
alexey-milovidov
382a6e62ec
Update AggregateFunctionStudentTTest.h 2020-10-27 17:55:03 +03:00
Nikolai Kochetov
71298ba496 Move fix to ExternalLoader::checkLoaded. 2020-10-27 17:21:51 +03:00
Alexander Kuzmenkov
60544ad46e
Merge pull request #16373 from ClickHouse/better-rethrow
Better exceptions rethrow
2020-10-27 16:38:32 +03:00
Alexander Kuzmenkov
e35be8eae3
Merge pull request #16407 from ClickHouse/agg-functions-case-sensitive
Some aggregate functions were erroneously marked as case-insensitive
2020-10-27 16:36:03 +03:00
Alexander Kuzmenkov
766560c138
Merge pull request #14195 from ClickHouse/aku/opentelemetry
[wip] add some opentelemetry support
2020-10-27 16:14:21 +03:00
alesapin
6253d1466a Fix comments 2020-10-27 16:09:14 +03:00
Nikolai Kochetov
afc28c84a0 Fix double free for shared exception message in case of dictGet from not loaded dictionary. 2020-10-27 16:07:58 +03:00
alesapin
3d3d246bdc Rename table 2020-10-27 16:07:50 +03:00
alesapin
e40c509392 More clear callback name 2020-10-27 16:00:40 +03:00
alesapin
f35edfb2a5 Remove some unused fields 2020-10-27 15:57:55 +03:00
alesapin
ee4e6caf70 Remove redundant metric increment 2020-10-27 15:52:49 +03:00
alesapin
db16942716 Better comment 2020-10-27 15:50:43 +03:00
alesapin
3824fcb076 Rename file and some tweaks 2020-10-27 15:47:42 +03:00
alesapin
31d63efdac Fix style 2020-10-27 15:26:10 +03:00
alesapin
dca35b1913 Add awesome test for fetch 2020-10-27 15:24:10 +03:00
kssenii
a48bc83763 Fix style 2020-10-27 12:04:07 +00:00
Pavel Kruglov
331545fe0d Fix typo 2020-10-27 14:29:36 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell 2020-10-27 12:04:03 +01:00
kssenii
db03cd7dd7 Much more optimal queues setup 2020-10-27 11:00:01 +00:00
kssenii
7beddceadd Fix bug that caused awful CPU usage 2020-10-27 10:02:27 +00:00
kssenii
cd0dbcb9d8 Minimize event loop lifetime 2020-10-27 10:01:39 +00:00
alesapin
d6130f13ef Add table to system tables 2020-10-27 10:21:49 +03:00
alexey-milovidov
30325689c4
Merge pull request #16397 from CurtizJ/fix-group-by-modifiers
Fix group by with modifiers.
2020-10-27 02:10:44 +03:00
Alexey Milovidov
59910991b6 Fix "Darwin" 2020-10-27 00:33:46 +03:00
alexey-milovidov
a34b0880c3
Update ReservoirSamplerDeterministic.h 2020-10-27 00:21:56 +03:00
Alexey Milovidov
73f3aac663 Fix assert error in quantileDeterministic #15683 2020-10-27 00:07:24 +03:00
Alexey Milovidov
cd597bf494 Merge branch 'master' into better-rethrow 2020-10-26 22:29:49 +03:00
Alexey Milovidov
740cf8ce82 Some aggregate functions were erroneously marked as case-insensitive 2020-10-26 22:20:40 +03:00
Alexey Milovidov
32ed8c9681 Fix trailing whitespace 2020-10-26 22:12:40 +03:00
Alexey Milovidov
e449266a16 Fix TSan report in lgamma 2020-10-26 22:06:30 +03:00
alesapin
880f4bbd05 System fetches 2020-10-26 19:38:35 +03:00
Alexander Kuzmenkov
5a70e26c70 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-26 19:21:13 +03:00
Alexander Kuzmenkov
6552613118
Merge pull request #16280 from filimonov/clickhouse-local-tmp-folder
clickhouse-local can work without tmp directory
2020-10-26 19:10:15 +03:00
Alexander Kuzmenkov
79a6be08d1
Update src/Interpreters/Context.cpp 2020-10-26 19:09:53 +03:00
Nikolai Kochetov
42836c86e2
Merge pull request #16386 from ClickHouse/more-introspection-for-exception-double-free
Check exception message is poisoned in ExpressionActions.
2020-10-26 18:08:54 +03:00
Anton Popov
ab4c43cb81 fix group by with totals/rollup/cube modifers and min/max functions over group by keys 2020-10-26 16:48:11 +03:00
Anton Popov
5fbca7d62d
Merge pull request #16337 from kitaisreal/uuid-safe-cast-functions-added
UUID safe cast functions added
2020-10-26 16:03:27 +03:00
alesapin
9ed4668dbb Refactor common part of background list 2020-10-26 15:40:55 +03:00
Nikolai Kochetov
4e8bea397b
Update ExpressionActions.cpp 2020-10-26 15:10:16 +03:00
Nikolai Kochetov
3151de1b4e Update ColumnConst include. 2020-10-26 13:26:52 +03:00
alesapin
d5d0819698 Merge branch 'master' into no_background_pool_no_more 2020-10-26 12:58:51 +03:00
Nikolai Kochetov
fe9db9866c Check exception message is poisoned in ExpressionActions. 2020-10-26 12:56:50 +03:00
Nikolai Kochetov
02bd35924e
Merge pull request #16242 from ClickHouse/another-one-untuple
Another one untuple implementation
2020-10-26 12:26:43 +03:00
alexey-milovidov
3aa49204d6
Update MergeTreeSettings.cpp 2020-10-26 07:39:20 +03:00
Alexey Milovidov
d5e277f080 Better exceptions rethrow 2020-10-26 06:35:57 +03:00
Alexey Milovidov
f8876fe989 Merge branch 'master' into fix-queue-processing-of-very-large-entries 2020-10-26 05:24:59 +03:00
alexey-milovidov
bfe17d7dca
Merge pull request #16358 from azat/dist-insert-fix
Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication
2020-10-26 05:07:35 +03:00
tavplubix
934f64a2fd
Update DatabaseCatalog.cpp 2020-10-26 00:51:30 +03:00
Alexander Tokmakov
f8f2d62d70 minor improvements in DatabaseCatalog 2020-10-25 20:27:21 +03:00
alesapin
f97e6beb70 Remove message broker pool from context 2020-10-25 15:34:18 +03:00
Azat Khuzhin
edc8d6e5e7 Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication 2020-10-25 14:27:06 +03:00
tavplubix
37de8727ea
Merge branch 'master' into fix/ISSUES-15883 2020-10-25 12:14:16 +03:00
Maksim Kita
440ae2bc57 UUID safe cast functions added
1. Added readUUIDTextImpl, readUUIDText, tryReadUUIDText functions in
ReadHelpers.
2. Added toUUIDOrNull, toUUIDOrZero functions based on ReadHelpers read
implementations.
3. Updated documentation.
2020-10-25 11:45:29 +03:00
Alexey Milovidov
22a89fca01 Fix processing very large entries in queue 2020-10-25 05:57:03 +03:00
Alexey Milovidov
a2d888f19f Fix processing very large entries in queue 2020-10-25 05:57:03 +03:00
Alexey Milovidov
79412bf0f5 Merge branch 'master' into https-sni 2020-10-25 04:45:42 +03:00
Alexey Milovidov
2613012fd1 Improve performance of FunctionsLogical a little by adding "restrict" 2020-10-25 04:43:06 +03:00
alexey-milovidov
abb9b25fa0
Merge pull request #16343 from ClickHouse/fix-perf-test-functions-logical
Fix performance test "functions logical" after move to clang
2020-10-25 04:04:24 +03:00
alexey-milovidov
c13ab94f91
Merge pull request #16344 from ClickHouse/exclamation-marks
Remove excessive exclamation marks
2020-10-25 03:13:57 +03:00
alexey-milovidov
74b37f37fb
Merge pull request #16329 from ClickHouse/better-diagnostics-when-client-dropped-connection
Better diagnostics when client has dropped connection
2020-10-25 01:01:12 +03:00
Alexey Milovidov
8b21ef5d4f Remove excessive exclamation marks 2020-10-25 00:50:52 +03:00
Alexey Milovidov
9d50921e52 Fix performance test "functions logical" after move to clang 2020-10-24 23:55:17 +03:00
Ivan
1d170f5745
ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name (#16149)
* Use only |name_parts| as primary name source

* Restore legacy logic for table restoration

* Fix build

* Fix tests

* Add pytest server config

* Fix tests

* Fixes due to review
2020-10-24 21:46:10 +03:00
Alexey Milovidov
8a98275a04 Merge branch 'master' of github.com:yandex/ClickHouse into https-sni 2020-10-24 21:43:48 +03:00
alexey-milovidov
70427bfa63
Merge pull request #16335 from kexianda/fix
minor fix.
2020-10-24 21:41:35 +03:00
alexey-milovidov
34b9d15b66
Update ThreadStatusExt.cpp 2020-10-24 21:34:54 +03:00
alexey-milovidov
e00f6c4a0d
Merge branch 'master' into total_memory_tracker-by-default 2020-10-24 21:17:53 +03:00
Nikita Mikhaylov
58b4342998
Merge pull request #15874 from nikitamikhaylov/welch-t-test
Student and Welch t-test
2020-10-24 15:13:12 +03:00
Xianda Ke
97d84dd855 minor fix.
redundant variable, duplicated defination of the variable aad_data
compiler error: variable ‘aad_value’ set but not used [-Werror=unused-but-set-variable]
2020-10-24 17:37:51 +08:00
alexey-milovidov
1a1a6350aa
Merge pull request #16285 from sundy-li/cmake-roaring
try use cmake version for croaring instead of amalgamation.sh
2020-10-24 11:07:32 +03:00
Alexey Milovidov
da6b4b29ff Merge branch 'master' into https-sni 2020-10-24 09:31:06 +03:00
alexey-milovidov
32e0de5121
Merge pull request #16071 from hczhcz/patch-1
Change error message in function if & ifNull
2020-10-24 07:40:22 +03:00
alexey-milovidov
7e4079dca1
Merge pull request #16286 from ClickHouse/aku/error-context
Add more context to error messages
2020-10-24 07:28:36 +03:00
alexey-milovidov
c579611420
Merge pull request #16306 from azat/Set-Join-total-rows-bytes
Add total_rows/total_bytes support for Set/Join
2020-10-24 07:26:32 +03:00
Alexey Milovidov
74558a4e27 Better diagnostics when client has dropped connection 2020-10-24 06:41:47 +03:00
alexey-milovidov
6037982343
Merge pull request #16284 from ClickHouse/primary_key_without_order_by
Add ability to specify PRIMARY KEY without ORDER BY
2020-10-24 06:05:04 +03:00
sundy-li
21315127a0 remove unused codes in AggregateFunctionGroupBitmapData 2020-10-24 10:05:54 +08:00
alexey-milovidov
91dc8d4cb3
Merge pull request #16264 from amosbird/ssmfix
Fix TwoLevelStringHashTable bug
2020-10-24 01:00:27 +03:00
Alexey Milovidov
13b8dce792 Update contributors 2020-10-24 00:26:22 +03:00
nikitamikhaylov
fe9440689a better 2020-10-24 00:05:24 +03:00
tavplubix
790950ea56
Merge pull request #15934 from ClickHouse/ddl_queries_fixes
Fixes for DDL queries
2020-10-23 23:52:13 +03:00
nikitamikhaylov
a949293f95 better 2020-10-23 23:27:38 +03:00
nikitamikhaylov
0064a75916 Merge branch 'master' of github.com:ClickHouse/ClickHouse into welch-t-test 2020-10-23 23:06:15 +03:00
nikitamikhaylov
d908cddb49 done 2020-10-23 22:09:02 +03:00
tavplubix
587f83b2ef
Merge branch 'master' into atomic-drop-database-sync 2020-10-23 21:54:26 +03:00
Azat Khuzhin
4d1385ef19 Add total_rows/total_bytes support for Set/Join 2020-10-23 21:11:55 +03:00
Azat Khuzhin
0cccf3049a Fix parent memory tracker during query detaching 2020-10-23 21:07:53 +03:00
Azat Khuzhin
114ea9b1eb Fix accounting for new/delete from different threads for VariableContext::Thread
MemoryTracker assumes that for VariableContext::Thread new/delete may be
called from different threads, hence the amount of memory can go
negative.

However the MemoryTracker is nested, so even if the negative amount is
allowed for VariableContext::Thread it does not allowed for anything
upper, and hence the MemoryTracking will not be decremented properly.

Fix this, by passing initial size to the parent free.

This should fix memory drift for HTTP queries.
2020-10-23 21:07:52 +03:00
Azat Khuzhin
72d7b6117e Use total_memory_tracker when there is no other MemoryTracker object.
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).

TL;DR;

To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.

Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.

NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00
alexey-milovidov
840d96255e
Merge pull request #16199 from azat/clang10-build-fix
Link dbms w/ atomic to fix undefined reference in unbundled build
2020-10-23 20:17:37 +03:00
Nikolai Kochetov
c808ab878b Review fixed. 2020-10-23 20:15:23 +03:00
Nikolai Kochetov
a2014378fe Remove has_untuple flag 2020-10-23 19:57:22 +03:00
Nikolai Kochetov
5c791edd43 Remove ColumnNameCache 2020-10-23 19:56:11 +03:00
alesapin
bc331a8029 Better set 2020-10-23 19:34:41 +03:00
alesapin
b28894c43b More compatible way 2020-10-23 19:31:51 +03:00
Mikhail Filimonov
f3a18864d5
After CR fixes - better & simpler. Issue in Context::shutdown fixed 2020-10-23 16:57:06 +02:00
Alexander Kuzmenkov
77654eeee8 fixup 2020-10-23 17:35:03 +03:00
Alexander Kuzmenkov
b0a14a41c3 fixup 2020-10-23 17:28:55 +03:00
tavplubix
84b453f4be
Update InterpreterDropQuery.cpp 2020-10-23 17:19:02 +03:00
Alexander Tokmakov
337fe7b81f add comment 2020-10-23 15:53:58 +03:00
Nikita Mikhaylov
cb4945d8b0
Merge pull request #16205 from azat/do-not-cache-dictGet
Do not cache dictionary for dictGet*/dictHas*
2020-10-23 15:47:11 +03:00
Alexander Kuzmenkov
d17a49f127 Add more context to error messages 2020-10-23 15:20:07 +03:00
Alexander Kuzmenkov
28c9e66dc1
Merge pull request #15978 from ucasFL/interval-op
INTERVAL operator support string literal
2020-10-23 14:44:05 +03:00
sundy-li
f407504a7a try use cmake version for croaring instead of amalgamation.sh 2020-10-23 19:42:21 +08:00
alesapin
59ca0d071c Fix comment 2020-10-23 14:17:37 +03:00
alesapin
69f2f9838e Add ability to specify PRIMARY KEY without ORDER BY 2020-10-23 14:16:27 +03:00
alesapin
39e47c5338 Less strange lambdas 2020-10-23 11:54:00 +03:00
alesapin
033525e27e
Merge pull request #16267 from den-crane/patch-6
Fix for incorrect error message
2020-10-23 10:43:34 +03:00
alesapin
6df68d6c80 Merge branch 'master' into no_background_pool_no_more 2020-10-23 10:28:23 +03:00
alexey-milovidov
121ebfdc81
Merge pull request #16249 from traceon/access-storage-added-log
Add a log message after an access storage is added
2020-10-23 09:17:10 +03:00
alexey-milovidov
6cd7d46f93
Update AccessControlManager.cpp 2020-10-23 09:13:26 +03:00
Denny Crane
b310d0abb4
Fix for incorrect error message
max_[table/partition]_size_to_drop can be changed without restart since https://github.com/ClickHouse/ClickHouse/pull/7779
2020-10-22 15:22:17 -03:00
Alexander Kuzmenkov
5cbf645de4 Merge remote-tracking branch 'origin/master' into tmp 2020-10-22 19:48:02 +03:00
Denis Glazachev
a6439aba44 More specific log messages for each access storage type 2020-10-22 20:47:52 +04:00
Alexander Kuzmenkov
145e2b012f cleanup 2020-10-22 19:47:20 +03:00
Amos Bird
ccf59c6412
Fix definitely wrong bug 2020-10-22 22:56:45 +08:00
alesapin
3c559c699f Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-22 17:16:46 +03:00
alesapin
1d07ece5d1 Fix clang tidy warning 2020-10-22 17:15:56 +03:00
alesapin
7a63b373f9 Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-22 15:47:11 +03:00
alesapin
4b65d5469f Fix some unrelated performance issues in select parts for merge 2020-10-22 15:41:01 +03:00
Nikolai Kochetov
0902bc96cf Fix build 2020-10-22 14:01:26 +03:00
Nikolai Kochetov
625af670da Fix tests. 2020-10-22 12:47:24 +03:00
Nikolai Kochetov
48142df26c Fix tests. 2020-10-22 11:25:24 +03:00
alesapin
945dd3aa59 Merge branch 'master' into blind_fix_of_read_in_order 2020-10-22 10:37:37 +03:00
Nikolai Kochetov
4a250ef9c6 Fix tests. 2020-10-22 09:58:20 +03:00
alexey-milovidov
f351b52851
Update AccessControlManager.cpp 2020-10-22 07:03:17 +03:00
alexey-milovidov
0433bc2034
Merge pull request #16248 from azat/nullptr_t-build-fix
Use std::nullptr_t over nullptr_t (build fix)
2020-10-22 07:02:38 +03:00
Alexey Milovidov
237384bad9 Fix "Arcadia" 2020-10-22 05:26:48 +03:00
Alexey Milovidov
eb0e3a83d0 Support SNI in https connections to remote resources 2020-10-22 05:02:26 +03:00
alexey-milovidov
adeba6bdd8
Merge pull request #15074 from amosbird/btc
Extend trivial count optimization.
2020-10-22 02:50:57 +03:00
Denis Glazachev
691b28e98b Add a log message after a storage is added 2020-10-22 02:43:02 +04:00
Azat Khuzhin
6f78243e32 Use std::nullptr_t over nullptr_t 2020-10-22 01:21:06 +03:00
alexey-milovidov
cfaf82ba0c
Merge pull request #16135 from hexiaoting/dev_rankCorr
Fix inconsistent behaviour of rankCorr function
2020-10-22 01:15:50 +03:00
alexey-milovidov
222a4d2e9b
Update AggregateFunctionRankCorrelation.h 2020-10-22 01:15:24 +03:00
alexey-milovidov
2ae32e3d5c
Merge pull request #16101 from azat/http-memory-tracking-fixes
Fix memory tracker settings (for HTTP queries)
2020-10-22 00:00:47 +03:00
Nikolai Kochetov
69279e6d76 Fix tests. 2020-10-21 23:05:10 +03:00
tavplubix
3c53d47840
Merge pull request #16189 from ClickHouse/fix_assertion_table_function_file
Fix assertion in table function file()
2020-10-21 22:38:24 +03:00
Azat Khuzhin
60aae56266 Link dbms w/ atomic to fix undefined reference in unbundled build
This will fix undefined reference for __atomic_load under clang10 and
unbundled build (libstdc++ shared linkage):

    clickhouse-server: symbol lookup error: /src/ch/clickhouse/.cmake/src/libclickhouse_disksd.so: undefined symbol: __atomic_load

From [1]:

  "libatomic (GNU)

   libgcc_s does not provide an implementation of an atomics library.
   Instead, GCC’s libatomic library can be used to supply these when using
   libgcc_s.

   Note

   Clang does not currently automatically link against libatomic when using
   libgcc_s. You may need to manually add -latomic to support this
   configuration when using non-native atomic operations (if you see link
   errors referring to __atomic_* functions)."

  [1]: https://clang.llvm.org/docs/Toolchain.html
2020-10-21 22:33:53 +03:00
Alexander Tokmakov
ac42199ae5 fix race on StorageReplicatedMergeTree::data_parts_exchange_endpoint 2020-10-21 22:25:22 +03:00