Commit Graph

1501 Commits

Author SHA1 Message Date
Kruglov Pavel
4989109e13
Merge pull request #63662 from v01dXYZ/63496-compression-from-file-descriptor
Compress STDOUT if redirected to file with a compression extension
2024-05-22 13:37:05 +00:00
Alexey Milovidov
fb4e1cef84
Merge pull request #64108 from rschu1ze/move-isallascii
Move `isAllASCII` from UTFHelper to StringUtils
2024-05-21 04:30:39 +02:00
Azat Khuzhin
1525ca4cf0 Disable pretty format restrictions when stdout is not TTY
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-20 10:19:11 +02:00
Alexey Milovidov
21ea31a374 Resolve conflicts 2024-05-20 09:18:38 +02:00
Robert Schulze
2909e6451b
Move StringUtils.h/cpp back to Common/ 2024-05-19 09:39:36 +00:00
Alexander Tokmakov
446cf9e95d Merge branch 'master' into signal_handlers_in_client 2024-05-16 15:56:18 +02:00
Anton Popov
a424efa348 fix fuzzer 2024-05-16 10:13:18 +00:00
Nikita Mikhaylov
3f6cf3f005 Better 2024-05-14 16:42:26 +00:00
Nikita Mikhaylov
b472c07ab2 Done 2024-05-14 17:58:05 +02:00
v01dxyz
8e63d2f795 Compress STDOUT if redirected to file with a compression extension
* Add a new member to ClientBase: default_output_compression_method
* Move the code to get file path from file descriptor to a separate
  Common function.

The stateless test is almost a copy-paste of 02001_compress_output_file.

Fixes https://github.com/ClickHouse/ClickHouse/issues/63496
2024-05-13 09:21:01 +02:00
Alexey Milovidov
2794a6635e Useless changes 2024-05-10 06:58:21 +02:00
Alexey Milovidov
426a51b624 Useless changes 2024-05-10 04:53:29 +02:00
Alexey Milovidov
1d69518c4d Useless changes 2024-05-09 02:07:04 +02:00
Alexey Milovidov
95f12ef274 Useless changes 2024-05-09 01:08:33 +02:00
Alexey Milovidov
ac7e6fc691 Properly send client info in Suggest 2024-05-06 23:00:05 +02:00
Igor Nikonov
e986619ce3
Merge pull request #61935 from ClickHouse/pr-receive-timeout-on-handshake
Parallel replicas: table check failover
2024-05-06 10:30:59 +00:00
Alexey Milovidov
6f21c34b5f Merge branch 'master' into tacit 2024-05-03 02:22:01 +02:00
Igor Nikonov
376c54c7f9 Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-05-02 19:15:14 +00:00
Kseniia Sumarokova
136262619f
Merge pull request #62964 from azat/client/external-tables-reuse-fix
Fix subsequent use of external tables in client
2024-05-02 11:10:16 +00:00
Alexey Milovidov
d7d38b14e8 Fix tests 2024-04-30 04:21:44 +02:00
Alexey Milovidov
34450ec87d Merge branch 'master' into tacit 2024-04-30 02:46:57 +02:00
Alexey Milovidov
cf9954035d Extend syntax highlight to 10 KB 2024-04-29 19:53:50 +02:00
Igor Nikonov
20884efdcc Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-29 13:36:13 +00:00
Azat Khuzhin
437621cbe5 Remove superfluous condition from ClientBase::sendExternalTables()
send_external_tables already checked by the callers.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-29 11:43:29 +02:00
Alexey Milovidov
fae8080130 Allow using clickhouse-local with a positional argument 2024-04-28 04:39:56 +02:00
Alexey Milovidov
8cc67f7c95
Merge pull request #62973 from yariks5s/reduce_help_messages
Reduce verbosity of `clickhouse client --help`
2024-04-27 03:43:33 +00:00
Yarik Briukhovetskyi
eee6fa4242
cosmetic fixes, comments for tests, user hints fixes 2024-04-26 13:19:22 +02:00
Nikita Mikhaylov
a3e746c438 Fix style 2024-04-25 20:17:20 +00:00
Nikita Mikhaylov
8e63946b6d Fix clang-tidy 2024-04-25 19:57:29 +00:00
Yarik Briukhovetskyi
64cb638717
add tests and changed implementation 2024-04-25 19:46:20 +02:00
Yarik Briukhovetskyi
5b4b4087e3
fixed build, moved verbose to help, fixed exception message 2024-04-25 18:51:17 +02:00
Yarik Briukhovetskyi
281fe68622
allow all settings if not --help 2024-04-25 18:28:09 +02:00
Yarik Briukhovetskyi
a36d86f63a
add --verbose for help and suggest to use system.settings 2024-04-25 17:01:34 +02:00
yariks5s
0cc404a74c init 2024-04-25 13:39:09 +00:00
Igor Nikonov
33b9e589c6 Add test_skip_replicas_without_table 2024-04-24 21:13:07 +00:00
Igor Nikonov
6db303cea3 Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-24 18:56:49 +00:00
Maksim Kita
f1660fa8bb Analyzer support QUALIFY clause 2024-04-22 12:12:02 +03:00
Igor Nikonov
043c62931d Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-17 16:48:40 +00:00
Igor Nikonov
1e43e3515e Check table status for parallel replicas 2024-04-17 16:47:52 +00:00
Nikita Mikhaylov
08c1901835 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keywords-2 2024-04-17 12:11:48 +00:00
Alexander Tokmakov
bfa5e55e8c
Merge pull request #62300 from ClickHouse/tavplubix-patch-10
Add local address to network exception messages
2024-04-12 12:26:35 +00:00
Alexey Milovidov
9664fb9249 Highlight only when necessary 2024-04-12 00:44:26 +02:00
Alexey Milovidov
da05238c8e Merge branch 'master' into revert-62508-revert-62123-full-syntax-highlight 2024-04-12 00:44:02 +02:00
Alexander Tokmakov
20e8b64cee fix 2024-04-11 21:40:39 +02:00
Konstantin Bogdanov
63351e2fbb
Merge branch 'master' into faster_01676_clickhouse_client_autocomplete 2024-04-11 01:34:05 +02:00
Alexander Tokmakov
dcd0831f4c fix 2024-04-11 00:12:52 +02:00
Yakov Olkhovskiy
d554dc61fb
Merge pull request #61923 from azat/local-input
Implement input() for clickhouse-local
2024-04-10 21:55:51 +00:00
Alexander Tokmakov
87476b8b98 Merge branch 'master' into tavplubix-patch-10 2024-04-10 23:37:22 +02:00
Alexey Milovidov
4f38bf4f6b
Revert "Revert "Rich syntax highlighting in the client"" 2024-04-10 21:39:02 +02:00
Igor Nikonov
912592ca78 Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-10 18:35:33 +00:00
Igor Nikonov
619d1b42e1 Increase timeout 2024-04-10 18:35:20 +00:00
Raúl Marín
033efd7204
Revert "Rich syntax highlighting in the client" 2024-04-10 20:25:20 +02:00
Konstantin Bogdanov
fd0f6418e2
Merge branch 'master' into faster_01676_clickhouse_client_autocomplete 2024-04-10 16:15:21 +02:00
Alexey Milovidov
a2154418ee
Merge pull request #62123 from ClickHouse/full-syntax-highlight
Rich syntax highlighting in the client
2024-04-10 14:58:32 +02:00
Alexey Milovidov
1bae493ef7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into full-syntax-highlight 2024-04-10 14:57:36 +02:00
Kruglov Pavel
8ef64b0581
Merge pull request #61476 from Avogar/better-stress-upgrade-checks
Ignore DROP queries in stress test with 1/2 probability and TRUNCATE Memory/JOIN table instead of ignoring DROP in upgrade check
2024-04-10 12:43:22 +00:00
Konstantin Bogdanov
c8598bdb54
Add a flag to load suggestion data synchronously 2024-04-10 13:08:38 +02:00
János Benjamin Antal
af6ded7382
Merge pull request #62221 from azat/pager-output_format_pretty_max_value_width
Unlimited output_format_pretty_max_value_width for --pager
2024-04-10 10:46:55 +00:00
Alexey Milovidov
0e06a52962 Merge branch 'master' of github.com:ClickHouse/ClickHouse into full-syntax-highlight 2024-04-10 01:58:49 +02:00
Alexey Milovidov
0e7d05e091 Fix UBSan 2024-04-10 01:58:30 +02:00
Alexander Tokmakov
dedc25fd34 fix 2024-04-09 23:43:40 +02:00
Robert Schulze
8167b774b5
Merge pull request #62307 from rschu1ze/cleanup-ssh
Cleanup SSH-based authentication code
2024-04-09 21:10:09 +00:00
pufit
6329dc8124 fix 2024-04-09 15:05:49 +02:00
pufit
4e1f98ee7b removed cout,cerr from src 2024-04-09 14:53:28 +02:00
Robert Schulze
4035334634
Merge remote-tracking branch 'rschu1ze/master' into static-instance2 2024-04-09 11:45:27 +00:00
Alexey Milovidov
9ebf091ae4 Documentation 2024-04-08 13:03:55 +02:00
Alexey Milovidov
537f045c1c Miscellaneous 2024-04-08 12:39:23 +02:00
Alexey Milovidov
0ff26d2d77 A little better 2024-04-08 12:39:23 +02:00
Alexey Milovidov
fb664fa99f Slightly better 2024-04-08 12:39:23 +02:00
Alexey Milovidov
c8d6dc47c3 Fix test 2024-04-08 12:39:23 +02:00
Alexey Milovidov
b9406f79d1 Better highlighting 2024-04-08 12:39:23 +02:00
Alexey Milovidov
b369291d47 Rich syntax highlighting in the client 2024-04-08 12:39:23 +02:00
Alexey Milovidov
f5e9a09d69 Remove support for INSERT WATCH query 2024-04-08 05:37:09 +02:00
Robert Schulze
97281203b8
Don't access static members through instance, pt. II
clang-tidy rightfully complains
(-readability-static-accessed-through-instance) that static member
functions are accessed through non-static members
2024-04-07 11:09:35 +00:00
Kruglov Pavel
589034c34c
Merge branch 'master' into better-stress-upgrade-checks 2024-04-05 15:27:02 +02:00
Robert Schulze
9d8f643f5b
Cleanup SSH-based authentication code 2024-04-05 08:43:23 +00:00
Alexander Tokmakov
5a897bc43e
Update Connection.cpp 2024-04-04 20:16:26 +02:00
Kruglov Pavel
3116650fa9
Merge pull request #61201 from ClickHouse/revert-61200-revert-60430-max-parallel-replicas-validate
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-04-03 17:05:59 +02:00
avogar
d87d5a9197 Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks 2024-04-03 12:07:22 +00:00
Azat Khuzhin
4b668d0990 Unlimited output_format_pretty_max_value_width for --pager
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-03 12:33:14 +02:00
pufit
1f85889f88 FuzzQuery table function 2024-03-29 18:53:03 -04:00
Alexey Milovidov
9da4ce29db Revert output Pretty in tty 2024-03-29 16:16:15 +01:00
Nikita Mikhaylov
d18aba1194 Done 2024-03-27 19:26:19 +00:00
Azat Khuzhin
469be8ee8a Implement input() for clickhouse-local
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 13:49:53 +01:00
Igor Nikonov
972af33400 Timeout injection 2024-03-26 12:30:16 +00:00
Azat Khuzhin
c7b919b19e Replace distributed_insert_replicas_preferences with distributed_insert_skip_read_only_replicas
v2: fix test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:57 +01:00
Azat Khuzhin
a19b27bd7c Revert extra changed lines
That was the changes that looks OK for the initial patchset version, but
not now, after all review comments.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:16 +01:00
Azat Khuzhin
dbdf080108 Remove insert argument for ConnectionPoolWithFailover
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:22:38 +01:00
Azat Khuzhin
d922bfb1b0 Introduce distributed_insert_prefer_non_readonly_replica setting
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
0e99781686 Move insert flag from ConnectionEstablisher to TryResult
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
b9469e2729 Do not try to INSERT into readonly replicas for Distributed engine
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.

But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.

Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).

v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
    It make sense only when the table name had passed --
    ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:38 +01:00
Azat Khuzhin
be2767b55c Make ClientBase::parseQuery() static
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 10:54:57 +01:00
Alexey Milovidov
9b052d059d No "please" 2024-03-26 09:00:20 +01:00
Kruglov Pavel
de1229ba60
Merge branch 'master' into better-stress-upgrade-checks 2024-03-25 19:18:35 +01:00
Alexey Milovidov
6f11f85801 Remove unused header 2024-03-24 21:40:47 +01:00
Alexey Milovidov
c5ad3ae1c9 Merge branch 'master' into detect-lexer-errors-early 2024-03-24 21:39:38 +01:00
Alexey Milovidov
38130ef5a3 Fix build 2024-03-24 21:39:31 +01:00
Alexey Milovidov
c7917f747d Remove garbage from KQL, part 3 2024-03-24 19:34:30 +01:00
Alexey Milovidov
4db69c36f9 Remove unused code 2024-03-24 17:15:47 +01:00
Alexey Milovidov
c0c8cdc185 Add modifications 2024-03-23 02:42:22 +01:00
Alexey Milovidov
7365f4e32b Add modifications 2024-03-23 01:43:28 +01:00
Alexey Milovidov
18c016caaa Support for --output-format in client 2024-03-22 21:06:36 +01:00
Alexey Milovidov
4d113c2190
Merge pull request #61508 from ClickHouse/generic-clickhouse-local-fuzzer
Generic fuzzer of query text in clickhouse-local
2024-03-21 21:17:28 +03:00
Alexey Milovidov
14f45bfa74
Merge pull request #61679 from evillique/fix-msan-issue
Fix use-of-uninitialized-value in HedgedConnections
2024-03-21 18:09:40 +03:00
Alexey Milovidov
784de2dca3 Merge branch 'master' into generic-clickhouse-local-fuzzer 2024-03-21 03:18:05 +01:00
Nikolay Degterinsky
93dd212f6f Fix use-of-uninitialized-value in HedgedConnections 2024-03-20 23:55:25 +00:00
Alexey Milovidov
6f4ce33f02 Change how fuzzer arguments are parsed 2024-03-20 22:12:57 +01:00
Alexander Tokmakov
d4d19c611b Merge branch 'master' into signal_handlers_in_client 2024-03-20 19:38:28 +01:00
Kruglov Pavel
e7e11d738b
Merge branch 'master' into revert-61200-revert-60430-max-parallel-replicas-validate 2024-03-20 13:59:38 +01:00
Alexey Milovidov
7b7e260585 Merge remote-tracking branch 'origin/master' into generic-clickhouse-local-fuzzer 2024-03-20 01:28:28 +01:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
avogar
dba72bf9c5 Fix 2024-03-19 10:02:35 +00:00
avogar
31d5049f80 Move logic of ignoring drop queries to server 2024-03-18 16:26:05 +00:00
avogar
aadc610739 Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks 2024-03-18 15:27:58 +00:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Alexey Milovidov
2eb7de859d Correct arguments parsing 2024-03-18 02:35:32 +01:00
Alexey Milovidov
1a61da1bae Replace getFuzzerData with query text fuzzer in clickhouse-local 2024-03-18 02:17:24 +01:00
Alexey Milovidov
01136bbc3b Limit backtracking in parser 2024-03-17 19:54:45 +01:00
avogar
2e9130ca1e Better 2024-03-15 20:30:44 +00:00
avogar
aadfc37dda Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks 2024-03-15 20:27:16 +00:00
avogar
fa9d9ea3f7 Ignore DROP queries in stress test with 1/2 probability, use TRUNCATE instead of ignoring DROP in upgrade check for Memory/JOIN tables 2024-03-15 20:23:39 +00:00
Raúl Marín
b21a5fec7b Fix broken list and thank clang tidy 2024-03-14 15:06:08 +01:00
Raúl Marín
617138cf48 Teach the fuzzer to use other numeric types 2024-03-13 16:54:28 +01:00
Nikita Mikhaylov
ec3f24e31b Merge branch 'master' of github.com:ClickHouse/ClickHouse into signal_handlers_in_client 2024-03-12 14:52:07 +01:00
avogar
a065231ca1 Remove unused error code 2024-03-12 12:07:36 +00:00
avogar
dd6599868a Better check for 0 setting value 2024-03-12 12:06:25 +00:00
Nikita Mikhaylov
9dbd380b50 Dont handle SIGTERM and others for client 2024-03-11 22:40:19 +00:00
Kruglov Pavel
5608005b34
Revert "Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense"" 2024-03-11 21:22:45 +01:00
Kruglov Pavel
a90a6e9a27
Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense" 2024-03-11 21:05:44 +01:00
Nikita Mikhaylov
ff4ae13d9a Print only fatals 2024-03-11 18:26:23 +00:00
Nikita Mikhaylov
37affa6a09 Merge branch 'master' of github.com:ClickHouse/ClickHouse into signal_handlers_in_client 2024-03-11 17:49:59 +00:00
Kruglov Pavel
1c1336bdc0
Merge pull request #60430 from Avogar/max-parallel-replicas-validate
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-03-11 18:04:54 +01:00
Sema Checherinda
80179e50e4
Merge pull request #58845 from ClickHouse/chesema-session-pool
HTTP connections pool
2024-03-10 14:06:59 +01:00
Sema Checherinda
4df406d3ad work with review notes 2024-03-10 10:00:18 +01:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
tomershafir
453eb25984 rm trailing whitespace 2024-03-10 08:42:54 +02:00
tomershafir
4af16043b8 improve randomness by erase buf elem when full 2024-03-09 21:27:28 +02:00
Alexander Tokmakov
72ac59f44f add signal handlers in client and local 2024-03-08 22:30:49 +01:00
tomershafir
46332f334c rm unused alias set/vector pair 2024-03-08 15:17:07 +02:00
Sema Checherinda
62f9a00da8 shuffle resolved IPs 2024-03-07 13:09:26 +01:00
avogar
595c75ec53 Merge branch 'master' of github.com:ClickHouse/ClickHouse into max-parallel-replicas-validate 2024-03-05 11:19:04 +00:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Alexey Milovidov
e1e66dc2b8
Merge pull request #60095 from ClickHouse/fix-inconsistent-formatting
Fix inconsistent formatting of queries
2024-02-29 00:41:40 +03:00
Alexey Milovidov
d93d5c2a00
Merge pull request #60470 from ClickHouse/ClibMouse-bugfix/kql-distributed-tables
Merging #59674.
2024-02-28 19:24:14 +03:00
Alexey Milovidov
acbcffea13 Fix error 2024-02-27 23:33:16 +01:00
Kruglov Pavel
58a53b42ac
Set max_entries to min(max_parallel_replicas, all available reolicas) 2024-02-27 14:31:35 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Kruglov Pavel
f264f0a036
Fix style 2024-02-26 22:06:10 +01:00
Kruglov Pavel
8aa9f36484
Fix style 2024-02-26 22:05:54 +01:00
avogar
ac4af6a4ad Don't allow to set max_parallel_replicas to 0 as it doesn't make sense 2024-02-26 19:58:49 +00:00