Commit Graph

65969 Commits

Author SHA1 Message Date
Amos Bird
8bf897b9c6
Add some comment 2021-06-15 18:37:22 +08:00
Amos Bird
aaac231c6a
Record expanded aliases for RBAC 2021-06-15 18:28:13 +08:00
Amos Bird
6795209ae4
Reuse local variable 2021-06-15 17:54:28 +08:00
Amos Bird
e3ae2f6e7a
Rewrite more alias columns 2021-06-15 17:54:28 +08:00
tavplubix
e2ecc51a1f
Merge pull request #25087 from ClickHouse/srmt_remove_copypaste
Remove copypaste from StorageReplicatedMergeTree
2021-06-15 12:43:55 +03:00
Vladimir
1f88cf3ccf
Merge pull request #25244 from otrazhenia/evgsudarikova-DOCSUP-10025 2021-06-15 12:01:38 +03:00
Vladimir
475945bdf7
Merge pull request #25287 from Slasat/patch-1
Fixed typos.
2021-06-15 12:00:47 +03:00
Владислав Тихонов
29f81b235f
Fixed typos. 2021-06-15 11:09:06 +03:00
Vladimir
a43c5c0a7f
Apply suggestions from code review 2021-06-15 10:27:38 +03:00
alexey-milovidov
7032998108
Merge pull request #25270 from gyuton/gyuton-DOCSUP-10298-Fix-and-update-documentation
DOCSUP-10298: Fixed and updated documentation
2021-06-15 03:04:24 +03:00
alexey-milovidov
65f9473317
Merge pull request #25274 from den-crane/tests/partition_by_multiply_by_zero
test for `PARTITION BY 0 * id`
2021-06-15 02:58:21 +03:00
alexey-milovidov
71135e8e45
Merge pull request #25266 from ClickHouse/add-test-20315
Add a test for #20315
2021-06-15 00:41:48 +03:00
alexey-milovidov
2370c8b3a1
Merge pull request #25260 from ClickHouse/fix-topk-memory-tracking
Fix memory tracking of aggregate function `topK`
2021-06-15 00:41:12 +03:00
alexey-milovidov
8a267775c2
Merge pull request #25253 from ClickHouse/add-test-9932
Add a test for #9932
2021-06-15 00:27:09 +03:00
alexey-milovidov
15f3ac9787
Merge pull request #25250 from ClickHouse/add-test-11535
Add test for #11535
2021-06-15 00:25:05 +03:00
alexey-milovidov
42a9f6b405
Merge pull request #25249 from ClickHouse/add-test-4113
Add test for #4113
2021-06-15 00:24:13 +03:00
Denis Zhuravlev
daf020347e test for PARTITION BY 0 * id 2021-06-14 18:11:46 -03:00
alexey-milovidov
e5f49477a6
Merge pull request #25264 from ClickHouse/copy-paste-some-code
Copy-paste some code
2021-06-14 21:25:15 +03:00
alexey-milovidov
b03ca2acab
Merge pull request #25267 from matwey/missed_include_optional
Add missed #include <optional>
2021-06-14 21:23:50 +03:00
alexey-milovidov
6a12f8781b
Merge pull request #25067 from azat/epoll-quirk-runtime
Detect linux version at runtime (for worked nested epoll)
2021-06-14 21:21:25 +03:00
gyuton
67b7b6fec9
Small fix 2021-06-14 20:36:28 +03:00
Kseniia Sumarokova
d2ad755ca5
Merge pull request #25269 from nickitat/nickitat_fix_docs
Fix a few typos in docs
2021-06-14 20:22:18 +03:00
George
77e048977b updated settings.md 2021-06-14 19:02:04 +03:00
George
39475e72dd updated quantiletdigestweighted.md 2021-06-14 18:50:27 +03:00
Nickita
ee7169e547 fix typos in docs 2021-06-14 16:29:07 +03:00
Evgeniia Sudarikova
9e11daa8c6 minor changes 2021-06-14 15:54:27 +03:00
Evgeniia Sudarikova
414bde9f2a edited after review and translated notes in RU examples 2021-06-14 15:39:53 +03:00
Matwey V. Kornilov
e8e7682a7d Add missed #include <optional>
std::optional<SearchParams> is used for user_dn_detection;

Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
2021-06-14 12:43:16 +03:00
Azat Khuzhin
92765a3595 Fix clang-tidy warnings in VersionNumber (use Int64 over long) 2021-06-14 10:42:50 +03:00
Azat Khuzhin
40abdaf24a Drop unnecessary qualified namespace 2021-06-14 10:38:26 +03:00
Azat Khuzhin
b5a2fad993 More generic VersionNumber 2021-06-14 10:38:26 +03:00
Azat Khuzhin
055e9d87f0 Use VersionNumber for detecting renameat2() 2021-06-14 10:38:26 +03:00
Azat Khuzhin
1b5ca07ff4 Convert VersionNumber::fromString() to constructor 2021-06-14 10:38:26 +03:00
Azat Khuzhin
ba05bf3977 Use LOGICAL_ERROR instead of introducing BAD_VERSION
But note, that tests with EXPECT_EXIT() does not work with --gtest_filter:

a) only this test is included into unit_tests_dbms

   $ src/unit_tests_dbms --gtest_filter=VersionNumber*
   Running main() from ../contrib/googletest/googletest/src/gtest_main.cc
   Note: Google Test filter = VersionNumber*
   [==========] Running 2 tests from 1 test suite.
   [----------] Global test environment set-up.
   [----------] 2 tests from VersionNumber
   [ RUN      ] VersionNumber.VersionNumber
   [       OK ] VersionNumber.VersionNumber (0 ms)
   [ RUN      ] VersionNumber.fromString
   Segmentation fault (core dumped)

   (gdb) bt
   0  0x00007fffda323d22 in raise () from /usr/lib/libc.so.6
   1  0x00007fffda30d862 in abort () from /usr/lib/libc.so.6
   2  0x00007fffdbe686f5 in DB::handle_error_code (msg=..., code=49, remote=false, trace=...) at Exception.cpp:49
   3  0x00007fffdbe68846 in DB::Exception::Exception (this=0x7fffd5c5a240, msg=..., code=49, remote_=false) at Exception.cpp:60
   4  0x00007fffe26b2cb3 in DB::Exception::Exception<unsigned long> (this=0x7fffd5c5a240, code=49, fmt=..., args=@0x7fffffffc7e8: 4) at Exception.h:40
   5  0x00007fffdbf4d201 in DB::VersionNumber::VersionNumber (this=0x7fffffffcc20, vec=...) at VersionNumber.cpp:17
   6  0x00007fffdbf4d650 in DB::VersionNumber::fromString (version=..., strict=true) at VersionNumber.cpp:57
   7  0x00005555555db53d in VersionNumber_fromString_Test::TestBody (this=0x7fffd5c12330) at gtest_version_number.cpp:24

b) regular build

   $ src/unit_tests_dbms --gtest_filter=VersionNumber*
   Running main() from ../contrib/googletest/googletest/src/gtest_main.cc
   Note: Google Test filter = VersionNumber*
   [==========] Running 2 tests from 1 test suite.
   [----------] Global test environment set-up.
   [----------] 2 tests from VersionNumber
   [ RUN      ] VersionNumber.VersionNumber
   [       OK ] VersionNumber.VersionNumber (0 ms)
   [ RUN      ] VersionNumber.fromString
   [       OK ] VersionNumber.fromString (495 ms)
   [----------] 2 tests from VersionNumber (495 ms total)

   [----------] Global test environment tear-down
   Segmentation fault (core dumped)

   (gdb) bt
   0  testing::TestInfo::should_run (this=0xe0) at gtest.h:760
   1  0x00007ffff7f6edd5 in testing::TestSuite::ShouldRunTest (test_info=0xe0) at gtest.h:1009
   2  0x00007ffff7f6ebb2 in testing::internal::CountIf<std::__1::vector<testing::TestInfo*, std::__1::allocator<testing::TestInfo*> >, bool (*)(testing::TestInfo const*)> (c=..., predicate=0x7ffff7f6edc0 <testing::TestSuite::ShouldRunTest(testing::TestInfo const*)>)
      at gtest-internal-inl.h:294
   3  0x00007ffff7f41ae5 in testing::TestSuite::test_to_run_count (this=0x7fffd5028500) at gtest.cc:2919
   4  0x00007ffff7f41719 in testing::internal::SumOverTestSuiteList (case_list=..., method=(int (testing::TestSuite::*)(const testing::TestSuite * const)) 0x7ffff7f41ac0 <testing::TestSuite::test_to_run_count() const>) at gtest.cc:377
   5  0x00007ffff7f41ab9 in testing::internal::UnitTestImpl::test_to_run_count (this=0x7fffd5d5c000) at gtest.cc:1012
   6  0x00007ffff7f4b59d in testing::UnitTest::test_to_run_count (this=0x7ffff7fbcb80 <testing::UnitTest::GetInstance()::instance>) at gtest.cc:5059
   7  0x00007ffff7f4c4ed in testing::internal::PrettyUnitTestResultPrinter::OnTestIterationEnd (this=0x7fffd5ca4a68, unit_test=...) at gtest.cc:3589
   8  0x00007ffff7f4daf9 in testing::internal::TestEventRepeater::OnTestIterationEnd (this=0x7fffd5c83770, unit_test=..., iteration=0) at gtest.cc:3852
   9  0x00007ffff7f57570 in testing::internal::UnitTestImpl::RunAllTests (this=0x7fffd5d5c000) at gtest.cc:5737
   10 0x00007ffff7fa3a84 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x7fffd5d5c000,
      method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x7ffff7f56f20 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x7ffff7f11d9b "auxiliary test code (environments or event listeners)") at gtest.cc:2589
   11 0x00007ffff7f71788 in testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=0x7fffd5d5c000,
      method=(bool (testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const)) 0x7ffff7f56f20 <testing::internal::UnitTestImpl::RunAllTests()>, location=0x7ffff7f11d9b "auxiliary test code (environments or event listeners)") at gtest.cc:2625
   12 0x00007ffff7f56ea3 in testing::UnitTest::Run (this=0x7ffff7fbcb80 <testing::UnitTest::GetInstance()::instance>) at gtest.cc:5291
2021-06-14 10:38:26 +03:00
Azat Khuzhin
5cc03535bf Set -Wno-covered-switch-default for unit_tests_dbms
Otherwise code that uses EXPECT_EXIT() fails with -Werror

v2: adjust only unit_tests_dbms, not googltest via
contrib/CMakeListst.txt itself.
2021-06-14 10:38:26 +03:00
Azat Khuzhin
c08daa3ca5 Detect linux version at runtime (for worked nested epoll)
The #22109 adds the check but at compilation time, which is pointless,
move the check into runtime.

Remember nested epoll is required for
async_socket_for_remote/use_hedged_requests, otherwise remote queries
may stuck.
2021-06-14 10:38:26 +03:00
Alexey Milovidov
f49463d1e5 Fix clang-tidy 2021-06-14 07:28:17 +03:00
alexey-milovidov
34d12063f8
Merge pull request #23349 from azat/dist-respect-insert_allow_materialized_columns
Respect insert_allow_materialized_columns for INSERT into Distributed()
2021-06-14 07:23:00 +03:00
Alexey Milovidov
6e8239d5d4 Add a test for #20315 2021-06-14 07:21:29 +03:00
Alexey Milovidov
2211ba53d4 Copy paste some code 2021-06-14 05:48:10 +03:00
Alexey Milovidov
dbff1edcd3 Fix memory tracking of aggregate function topK 2021-06-14 05:26:05 +03:00
Alexey Milovidov
39515083e4 Remove broken check for non-production feature 2021-06-14 04:14:38 +03:00
Alexey Milovidov
19f8f0241d Fix strange typo 2021-06-14 04:11:16 +03:00
Alexey Milovidov
01eaaace8b Add a test for #9932 2021-06-14 02:50:34 +03:00
alexey-milovidov
77721734ed
Merge pull request #21267 from filimonov/kafka-failover
Kafka failover issue fix
2021-06-14 01:42:42 +03:00
Alexey Milovidov
82502a8d7e Add test for #11535 2021-06-14 00:07:37 +03:00
Alexey Milovidov
d0aa387e64 Fixed the annoying Arcadia, it is bogging my weekend. 2021-06-13 23:53:49 +03:00
Alexey Milovidov
79b21caa28 Add test for #4113 2021-06-13 23:52:35 +03:00
alexey-milovidov
103ecf48e0
Merge pull request #25247 from ClickHouse/minor-changes-2
Minor change
2021-06-13 23:45:58 +03:00
Alexey Milovidov
b40f83cd21 Fixed the annoying Arcadia, it is bogging my weekend. 2021-06-13 22:59:45 +03:00