Commit Graph

154 Commits

Author SHA1 Message Date
Alexey Milovidov
ff13752d01 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:47:14 +03:00
Alexey Milovidov
fc27be314b Avoid temporary nullptr references [#CLICKHOUSE-2] 2018-09-02 06:00:04 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Alexey Milovidov
c99e717632 Fixed bad code #2571 2018-07-04 20:28:52 +03:00
Alexey Milovidov
6afec54f7a Addition to prev. revision #2571 2018-07-04 20:28:52 +03:00
Alexey Milovidov
e86f73e465 Fixed half of bad code #2571 2018-07-04 20:28:52 +03:00
Alexey Milovidov
fb91bba279 Miscellaneous [#CLICKHOUSE-2] 2018-05-16 03:34:56 +03:00
Nikolai Kochetov
6715b945d9 Allow using of function which returs tuple for IN. [#CLICKHOUSE-3730] 2018-05-15 18:38:04 +03:00
Alexey Milovidov
70be882b64 Renamed PK to Key where it's appropriate #2246 2018-04-20 03:27:25 +03:00
Alexey Milovidov
d71b3a95ef Renamed PK to Key where it's appropriate #2246 2018-04-20 03:20:50 +03:00
Alexey Milovidov
ce0ac3f8f8 Fixed error with Sets, part 2 #2246 2018-04-20 00:34:04 +03:00
Alexey Milovidov
3eff0184fa Added set size checking when set from subquery is used for index; removed harmful feature for special support of (a, b) IN (SELECT (a, b)) instead of (a, b) IN (SELECT a, b) [#CLICKHOUSE-2] 2018-04-18 22:38:40 +03:00
Alexey Milovidov
3bb2fa4702 Fixed bad code [#CLICKHOUSE-2] 2018-04-18 21:44:02 +03:00
Alexey Milovidov
6452a3bb76 Removed (obsolete) special handling for Arrays in the left hand side of IN [#CLICKHOUSE-2] 2018-04-05 23:52:01 +03:00
Alexey Milovidov
5ff433b670 Merged Limits to Settings [#CLICKHOUSE-2021] 2018-03-11 03:15:26 +03:00
Tsarkova Anastasia
d99d01ac3a Fix data types for key_ranges 2018-02-20 23:03:15 +03:00
Alexey Milovidov
953ab16cde Miscellaneous #1853 2018-02-08 18:31:37 +03:00
Alexey Milovidov
777b4404bd Fixed build #1853 2018-02-08 18:25:46 +03:00
Tsarkova Anastasia
5ecd50ff44 Adding comments. Reversing infinities. 2018-02-08 17:28:31 +03:00
Tsarkova Anastasia
c50ccabb0a Implement MergeTree index using for IN operator with tuple of columns. 2018-02-07 18:29:00 +03:00
Vlad Arkhipov
6738d6a995 Add comments. Improve method names. 2018-01-23 11:18:12 +03:00
alexey-milovidov
21274e80cc
Update Set.cpp 2018-01-22 21:07:55 +03:00
Vlad Arkhipov
be96cf5133 Replace subqueries and table expressions on the right side of the IN operator with their results in order to make MergeTree storage engines evaluate the corresponding conditions by using the index. 2018-01-21 11:22:52 +03:00
Alexey Milovidov
7284a64740 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-16 00:32:25 +03:00
Alexey Milovidov
9c9896c1a9 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:17:15 +03:00
Alexey Milovidov
b2aff7521b Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 06:47:43 +03:00
Alexey Milovidov
f3bb24a3bf Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-14 04:43:19 +03:00
Alexey Milovidov
819287b697 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-13 04:27:53 +03:00
Alexey Milovidov
6cf5c63f4e Fixed error [#CLICKHOUSE-2] 2017-12-09 19:17:37 +03:00
Alexey Milovidov
7f6c48d5de Cleanup semantics of data types [#CLICKHOUSE-2]. 2017-12-09 19:17:37 +03:00
Alexey Milovidov
16b06bd544 Simplification of Nullable [#CLICKHOUSE-2] 2017-12-08 11:25:28 +03:00
Alexey Milovidov
741a6e0066 Simplification of Nullable [#CLICKHOUSE-2] 2017-12-08 03:50:25 +03:00
Alexey Milovidov
f5ecb2db5d Better [#CLICKHOUSE-2]. 2017-12-01 20:49:12 +03:00
proller
0d3c4f4d67 Core/FieldVisitors.h -> Common/FieldVisitors.h
Core/Progress.h -> IO/Progress.h
    tests: sudo --non-interactive
    Fix freebsd link
2017-11-24 16:55:31 +03:00
proller
49f8080e52 Small debud improvement 2017-10-13 21:44:26 +03:00
Alexey Milovidov
d29c77adea Implemented some suggestions from clang-tidy (part 3) [#CLICKHOUSE-3301]. 2017-09-08 06:47:27 +03:00
Alexey Zatelepin
ce3e4676fa remove unnecessary calls to find() [#CLICKHOUSE-2171] 2017-08-19 21:35:01 +03:00
Alexey Milovidov
dd1f54bce2 Changed Poco::RWLock to std::shared_lock [#APRILDEV-91]. 2017-07-28 20:34:02 +03:00
Nikolai Kochetov
75be0b81d8 removed typeid_cast from IColumn.h 2017-07-13 23:58:19 +03:00
Alexey Milovidov
a782f81f8f Moved common code from Functions; fixed build after merge [#CLICKHOUSE-2]. 2017-06-13 07:45:30 +03:00
f1yegor
b4c23f122a Translated comments 2017-04-02 20:37:49 +03:00
Alexey Milovidov
310736cd7e Moved headers and sources to same place [#CLICKHOUSE-3]. 2017-04-01 12:22:42 +03:00
Alexey Milovidov
137ad95929 Changed tabs to spaces in code [#CLICKHOUSE-3]. 2017-04-01 11:35:09 +03:00
Alexey Milovidov
40ce6f86db Allowed JOIN to work with Nullable keys [#CLICKHOUSE-4]. 2017-03-30 17:09:24 +03:00
Alexey Milovidov
cc43f989bc Preparation [#CLICKHOUSE-4]. 2017-03-29 14:33:07 +03:00
Alexey Milovidov
a8f6a3127d Implemented limited support for NULLs in IN operator [#CLICKHOUSE-4]. 2017-03-28 06:00:33 +03:00
Alexey Milovidov
d3b22774c9 Comments [#CLICKHOUSE-2788]. 2017-03-04 00:15:46 +03:00
artpaul
be7c70da5c fix IN with nested tuples [#CLICKHOUSE-1999] 2017-03-01 19:48:21 +05:00
Vitaliy Lyudvichenko
8bcb1fe970 Add support of AggregateFunction constants in VALUES and Set. [#CLICKHOUSE-2845] 2017-02-18 00:36:31 +04:00
Alexey Milovidov
58e5dad1a1 Squashed commit of the following:
commit e712f469a5
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:59:13 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 2a00282308
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:58:30 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 9e06f407c8
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:55:14 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 9581620f1e
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:54:22 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 2a8564c68c
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:47:34 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit cf60632d78
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:40:09 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit ee3d1dc6e0
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:22:49 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 65592ef711
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:18:17 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 37972c2573
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:17:06 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit dd909d1499
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:16:28 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 3cf43266ca
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:15:42 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 6731a3df96
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:13:35 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 1b5727e0d5
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:11:18 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit bbcf726a55
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:09:04 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit c03b477d5e
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:06:30 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 2986e2fb04
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:05:44 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit 5d6cdef13d
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:04:53 2017 +0300

    Less dependencies [#CLICKHOUSE-2]

commit f2b819b25c
Author: Alexey Milovidov <milovidov@yandex-team.ru>
Date:   Sat Jan 14 11:01:47 2017 +0300

    Less dependencies [#CLICKHOUSE-2]
2017-01-14 12:00:19 +03:00