Commit Graph

89085 Commits

Author SHA1 Message Date
Robert Schulze
f99a3d9284
Enable clang-tidy cert-dcl58-cpp
Official docs:

  Modification of the std or posix namespace can result in undefined
  behavior. This check warns for such modifications.
2022-05-08 19:30:58 +02:00
Robert Schulze
97603321f5
Enable clang-tidy cert-dcl51-cpp
Official docs:

  Checks for usages of identifiers reserved for use by the
  implementation. The C and C++ standards both reserve the following
  names for such use: identifiers that begin with an underscore followed
  by an uppercase letter; identifiers in the global namespace that begin
  with an underscore.
2022-05-08 19:30:58 +02:00
Robert Schulze
447f2e1d5d
Enable clang-tidy cert-dcl37-c
Official docs:

  Checks for usages of identifiers reserved for use by the
  implementation. The C and C++ standards both reserve the following
  names for such use: identifiers that begin with an underscore followed
  by an uppercase letter; identifiers in the global namespace that begin
  with an underscore.
2022-05-08 19:30:58 +02:00
Robert Schulze
fb781dab3a
Enable clang-tidy bugprone-unhandled-exception-at-new
Official docs:

  Finds calls to new with missing exception handler for std::bad_alloc.
  Calls to new may throw exceptions of type std::bad_alloc that should
  be handled. Alternatively, the nonthrowing form of new can be used.
  The check verifies that the exception is handled in the function that
  calls new. If a nonthrowing version is used or the exception is
  allowed to propagate out of the function no warning is generated. The
  exception handler is checked if it catches a std::bad_alloc or
  std::exception exception type, or all exceptions (catch-all). The
  check assumes that any user-defined operator new is either noexcept or
  may throw an exception of type std::bad_alloc (or one derived from
  it). Other exception class types are not taken into account.
2022-05-08 19:30:58 +02:00
Robert Schulze
89dbbe9a6e
Enable clang-tidy bugprone-spuriously-wake-up-functions
Official docs:

  Finds cnd_wait, cnd_timedwait, wait, wait_for, or wait_until function
  calls when the function is not invoked from a loop that checks whether
  a condition predicate holds or the function has a condition parameter.
2022-05-08 19:30:58 +02:00
Robert Schulze
d0b2fa952c
Enable clang-tidy bugprone-signal-handler
Official docs:

  Finds functions registered as signal handlers that call non
  asynchronous-safe functions.
2022-05-08 19:30:58 +02:00
Robert Schulze
9f1116b385
Enable clang-tidy bugprone-no-escape
Official docs:

  Finds pointers with the noescape attribute that are captured by an
  asynchronously-executed block. The block arguments in dispatch_async()
  and dispatch_after() are guaranteed to escape, so it is an error if a
  pointer with the noescape attribute is captured by one of these
  blocks.
2022-05-08 19:30:55 +02:00
Robert Schulze
ee72bd832d
Enable clang-tidy bugprone-misplaced-widening-cast
Official docs:

  This check will warn when there is a cast of a calculation result to a
  bigger type. If the intention of the cast is to avoid loss of
  precision then the cast is misplaced, and there can be loss of
  precision. Otherwise the cast is ineffective.
2022-05-08 19:20:44 +02:00
Robert Schulze
a5ee67885d
Enable clang-tidy bugprone-forwarding-reference-overload
Official docs:

  The check looks for perfect forwarding constructors that can hide copy
  or move constructors. If a non const lvalue reference is passed to the
  constructor, the forwarding reference parameter will be a better match
  than the const reference parameter of the copy constructor, so the
  perfect forwarding constructor will be called, which can be confusing.
2022-05-08 19:20:14 +02:00
Robert Schulze
543fd7e1e0
Enable clang-tidy bugprone-dynamic-static-initializers
Official docs:

  Finds instances of static variables that are dynamically initialized in
  header files. This can pose problems in certain multithreaded contexts.
2022-05-08 19:19:36 +02:00
Robert Schulze
20513df733
Enable clang-tidy readability-qualified-auto
Official docs:

Adds pointer qualifications to auto-typed variables that are deduced to
pointers. This makes it obvious if a auto typed variable is a pointer.
This check will transform auto to auto * when the type is deduced to be
a pointer.
2022-05-08 19:17:15 +02:00
Robert Schulze
627cc1ccfa
Enable clang-tidy misc-static-assert
Official docs:

  Replaces assert() with static_assert() if the condition is evaluable
  at compile time. The condition of static_assert() is evaluated at
  compile time which is safer and more efficient.
2022-05-08 19:16:41 +02:00
Robert Schulze
7d3913f350
Enable clang-tidy bugprone-assert-side-effect
Official docs:

  Finds assert() with side effect. The condition of assert() is
  evaluated only in debug builds so a condition with side effect can
  cause different behavior in debug / release builds.
2022-05-08 19:15:55 +02:00
Robert Schulze
9c51657821
Enable clang-tidy modernize-replace-auto-ptr
Official docs:

  This check replaces the uses of the deprecated class std::auto_ptr by
  std::unique_ptr (introduced in C++11). The transfer of ownership, done
  by the copy-constructor and the assignment operator, is changed to
  match std::unique_ptr usage by using explicit calls to std::move().
2022-05-08 19:15:21 +02:00
Robert Schulze
7036bc4e99
Enable clang-tidy modernize-unary-static-assert
Official docs:

  The check diagnoses any static_assert declaration with an empty string
  literal and provides a fix-it to replace the declaration with a
  single-argument static_assert declaration.
2022-05-08 19:14:39 +02:00
Robert Schulze
7d1ac7fa7f
Enable clang-tidies clang-analyzer-core.DynamicTypePropagation and clang-analyzer-core.uninitialized.CapturedBlockVariable
Official docs:

  - Generate dynamic type information
  - Check for blocks that capture uninitialized values
2022-05-08 19:13:40 +02:00
Robert Schulze
f2b1748c48
Enable clang-tidy bugprone-suspicious-semicolon
Official docs:

  Finds most instances of stray semicolons that unexpectedly alter the
  meaning of the code.
2022-05-08 19:13:37 +02:00
Robert Schulze
61cbcbf073
Enable clang-tidy readability-misleading-indentation
Official docs:

  Correct indentation helps to understand code. Mismatch of the
  syntactical structure and the indentation of the code may hide serious
  problems.
2022-05-08 19:12:01 +02:00
fenglv
2cd0f2aaed remove useless code 2022-05-08 16:50:13 +00:00
Vxider
64e4c546bc add test for windowview populate 2022-05-08 16:47:22 +00:00
Alexey Milovidov
63483e1321
Merge pull request #36913 from ClickHouse/pair_tuple
Replace make_pair()/make_tuple() by pair()/tuple()
2022-05-08 19:08:27 +03:00
Alexey Milovidov
5bacfa2bae
Merge pull request #37016 from wuxiaobai24/fix_labels_check_ouput
fix output error in LabelsCheck
2022-05-08 18:43:15 +03:00
Vxider
34f1821eb9 function now support for windowview populate 2022-05-08 23:43:08 +08:00
Alexey Milovidov
b97e751891
Merge pull request #37010 from ClickHouse/nickitat-patch-2
Try fix flaky test
2022-05-08 18:41:40 +03:00
Alexey Milovidov
3fc95add7e
Merge pull request #36979 from Avogar/finalize-write-buffers
Finalize write buffers in case of exception
2022-05-08 18:41:20 +03:00
alesapin
aad246f833
Update StorageReplicatedMergeTree.cpp 2022-05-08 16:40:41 +02:00
Alexey Milovidov
3755466e8d
Merge pull request #34916 from nic11/pr/content-type
Support content_type in HTTP handler config
2022-05-08 16:36:21 +03:00
Vxider
1e9c1c0829 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into wv-populate 2022-05-08 13:35:08 +00:00
Alexey Milovidov
00680a7b65
Update Settings.h 2022-05-08 16:31:12 +03:00
Alexey Milovidov
333cbe4a3f
Merge pull request #34544 from danlark1/master
Inline threshold optimizations
2022-05-08 16:27:27 +03:00
kssenii
f43c09b53c Fix incorrect assetion 2022-05-08 14:18:43 +02:00
alesapin
d4e0127b0a Followup 2022-05-08 13:28:59 +02:00
alesapin
2f650366a6 Merge branch 'master' into better_delete_outdated_parts 2022-05-08 12:55:42 +02:00
Vxider
712d046d04 Merged with master 2022-05-08 18:18:52 +08:00
Vxider
e7c4eb2697 Merged with master 2022-05-08 18:15:31 +08:00
Kseniia Sumarokova
fac59dfd97
Merge pull request #36998 from Vxider/removing-replacing-wv-transform
Removing ReplacingWindowColumnTransform in WindowView
2022-05-08 12:11:44 +02:00
Kseniia Sumarokova
b201d6d684
Merge pull request #36967 from Vxider/wv-fix-stuck
Fix stuck when drop source table in WindowView
2022-05-08 12:00:10 +02:00
Vitaly Baranov
41a41d3a31 Set max_free_threads=0 for BackupsWorker. 2022-05-08 10:43:12 +02:00
Vitaly Baranov
1b2eb4fe27 Use more clear syntax for BACKUP/RESTORE. 2022-05-08 10:37:02 +02:00
Robert Schulze
7bef3843ce
Recommend syntactic sugar for better readability in code style 2022-05-08 08:44:22 +02:00
wuxiaobai24
d3dca101aa fix labels check output error 2022-05-08 14:41:03 +08:00
Robert Schulze
5d460b7f29
Merge remote-tracking branch 'origin/master' into pair_tuple 2022-05-08 08:39:16 +02:00
Robert Schulze
b3988cbdf7
Revert "Replace make_pair()/make_tuple() by pair()/tuple()"
This reverts commit 447a9b3331.
2022-05-08 08:38:10 +02:00
Robert Schulze
f18cb05574
Revert "More make_pair/tuple to pair/tuple"
This reverts commit 59086afc47.
2022-05-08 08:37:39 +02:00
Robert Schulze
e8809e9f86
Revert "Complain about std::make_pair/tuple (check-style)"
This reverts commit 3a4da94126.
2022-05-08 08:36:05 +02:00
Robert Schulze
a6e22c9379
Revert "Mention suppression in stylecheck error + document in style guide"
This reverts commit ef0d9ca468.
2022-05-08 08:35:10 +02:00
bharatnc
fc12d7bb4d add tests for h3Line 2022-05-07 22:33:04 -07:00
alesapin
46712f1d98 Fix forgotten parts in cleanup thread 2022-05-08 00:53:55 +02:00
Alexey Milovidov
8e8faa3180
Update DataTypesDecimal.h 2022-05-08 01:15:54 +03:00
Alexey Milovidov
9b5cc2e708
Merge pull request #37002 from ClickHouse/bigo-sg-remind_for_external_option
Merging #34765
2022-05-08 01:11:37 +03:00