Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Amos Bird
e73d7fea31
Rename narrowBlockInputStream to narrowPipe
2022-04-24 18:33:48 +08:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
...
Clang tidy fixes
2022-04-21 16:11:27 +02:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
...
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
...
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Alexey Milovidov
242919eddd
Remove abbreviation
2022-04-18 01:02:49 +02:00
Alexander Tokmakov
07d952b728
use snapshots for semistructured data, durability fixes
2022-03-17 18:26:18 +01:00
Anton Popov
df3b07fe7c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-03 22:25:28 +00:00
Maksim Kita
b1a956c5f1
clang-tidy check performance-move-const-arg fix
2022-03-02 18:15:27 +00:00
Anton Popov
18940b8637
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-09 23:38:38 +03:00
Amos Bird
98857de82b
Disable projection for high-order storages
2022-02-06 16:46:10 +08:00
Anton Popov
e8ce091e68
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-21 20:11:18 +03:00
Anton Popov
abcc48c1f6
Merge remote-tracking branch 'upstream/master' into support-prewhere-storage-merge
2021-12-29 21:07:35 +03:00
Anton Popov
7c6f7f6732
support 'optimize_move_to_prewhere' with storage 'Merge'
2021-12-29 20:49:10 +03:00
avogar
8112a71233
Implement schema inference for most input formats
2021-12-29 12:18:56 +03:00
Anton Popov
6f4d9a53b2
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-12-01 15:54:33 +03:00
Raúl Marín
b2cfa70541
Reduce dependencies on ASTFunction.h
...
481 -> 230
2021-11-26 18:21:54 +01:00
Anton Popov
ccd78e3838
Merge remote-tracking branch 'upstream/master' into HEAD
2021-11-22 17:19:35 +03:00
Anton Popov
4c6c80b9a2
Merge pull request #31044 from kssenii/fix-storage-merge-with-aliases-and-where
...
Fix StorageMerge with aliases and where
2021-11-11 21:46:02 +03:00
kssenii
d8ef39461f
Fix
2021-11-11 16:10:07 +03:00
kssenii
18b9a8f7fd
Fix build check
2021-11-11 02:03:56 +03:00
kssenii
a2326f5035
Fix
2021-11-10 19:03:54 +03:00
kssenii
f4f0bd8b5c
Fix
2021-11-10 13:16:39 +03:00
kssenii
60ed991c2c
Fix
2021-11-10 11:47:03 +03:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
kssenii
ee9ceaf7d4
Better
2021-11-09 14:27:17 +03:00
kssenii
38466cb76f
Storage merge fix aliases with where
2021-11-03 14:17:11 +03:00
feng lv
6f12348282
enable modify table comment of some table
2021-10-29 12:31:18 +00:00
Alexander Tokmakov
2e7e195e77
change alter_lock to std::timed_mutex
2021-10-26 13:37:00 +03:00
Nikolai Kochetov
fd14faeae2
Remove DataStreams folder.
2021-10-15 23:18:20 +03:00
Nikolai Kochetov
2957971ee3
Remove some last streams.
2021-10-13 21:22:02 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
Nikolai Kochetov
78a7665f43
Merge branch 'master' into rewrite-pushing-to-views
2021-09-27 10:56:50 +03:00
alexey-milovidov
9dac348893
Update StorageMerge.cpp
2021-09-25 19:41:50 +03:00
Alexey Milovidov
fe44be522e
Fix assert in table function merge with database regexp
2021-09-25 05:48:24 +03:00
Nikolai Kochetov
341553febd
Fix build.
2021-09-16 20:40:42 +03:00
Nikolai Kochetov
b997214620
Rename QueryPipeline to QueryPipelineBuilder.
2021-09-14 20:48:18 +03:00
Nikolai Kochetov
7fc830ae2b
Rename QueryPipeline to QueryPipelineBuilder.
2021-09-14 19:28:41 +03:00
Anton Popov
4c388e3d84
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-09-09 14:10:16 +03:00
Mike Kot
8e9aacadd1
Initial: replacing hardcoded toString for enums with magic_enum
2021-09-06 16:24:03 +02:00
Anton Popov
89e1d1f64a
fix order by for StorageMerge with optimize_read_in_order
2021-08-27 16:55:55 +03:00
Vitaly Baranov
ff1fad8521
Use setSetting() with implicit conversion true/false -> Field.
2021-08-23 08:57:00 +03:00
Anton Popov
61239343e3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-20 16:33:30 +03:00
Alexey Milovidov
24cef99065
Merge branch 'master' into fix-bad-cast
2021-08-08 04:00:29 +03:00
Anton Popov
e36736b50c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-02 22:52:02 +03:00
Alexander Tokmakov
63ab38ee09
rename MaterializeMySQL to MaterializedMySQL
2021-07-26 21:17:28 +03:00
Alexey Milovidov
a4b6181920
Fix weirdness
2021-07-24 05:07:37 +03:00
Anton Popov
f99374cca6
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-07-20 18:20:21 +03:00
mergify[bot]
39f71f4a08
Merge branch 'master' into fix_no_column_materialized_mysql
2021-07-19 12:27:38 +00:00
Alexey Milovidov
d984fc4301
Fix flaky integration test
2021-07-15 13:35:37 +03:00
Anton Popov
cd05df90f1
fix snapshot for storage Merge
2021-07-09 17:11:44 +03:00
Anton Popov
3ed7f5a6cc
dynamic subcolumns: add snapshot for storage
2021-07-09 06:15:41 +03:00
Alexander Tokmakov
0f377fc4d8
Merge branch 'master' into fix_no_column_materialized_mysql
2021-07-05 22:07:56 +03:00
feng lv
1bf7a175b7
fix style
2021-07-02 03:44:42 +00:00
feng lv
fe22563465
fix conflict
2021-07-01 13:09:33 +00:00
Alexander Tokmakov
fd914f3d97
fix 'Not found column' error in MaterializeMySQL
2021-06-29 20:47:41 +03:00
feng lv
06242f85e6
fix
2021-06-27 06:09:23 +00:00
feng lv
61550f91f2
fix and update test
2021-06-25 15:01:57 +00:00
kssenii
c2ac9b6027
Better
2021-06-25 14:31:56 +00:00
feng lv
07a47b4bd3
fix
2021-06-25 13:51:17 +00:00
feng lv
228e06628a
fix conflict
2021-06-25 08:06:06 +00:00
feng lv
b54287c8da
fix
2021-06-25 08:00:30 +00:00
kssenii
ded9007ca0
Fix
2021-06-25 07:49:38 +00:00
kssenii
ca1f336c46
Aliases for storageMerge fix
2021-06-25 05:28:44 +00:00
Vladimir
6af272891a
Merge pull request #24870 from azat/mv-dist-join-fix
2021-06-18 11:18:43 +03:00
Maksim Kita
67e9b85951
Merge ext into common
2021-06-16 23:28:41 +03:00
feng lv
1ffd380903
use full match for storageMerge
2021-06-13 08:03:19 +00:00
vdimir
26c59961ae
Minor style changes in StorageMaterializedView::read, StorageMerge::createSources
2021-06-12 12:27:05 +03:00
feng lv
41b518012f
fix and add test
2021-06-08 03:11:27 +00:00
feng lv
b40bb00b8d
merge support repr database
2021-06-07 09:14:29 +00:00
feng lv
32c45d14ab
a little
2021-06-04 14:48:48 +00:00
Azat Khuzhin
578ecc1645
removeJoin: remove joined columns
2021-06-03 21:07:47 +03:00
Nikolai Kochetov
afc1fe7f3d
Make ContextPtr const by default.
2021-05-31 17:49:02 +03:00
Maksim Kita
c50909468f
Updated ExpressionActionSettings
2021-05-19 17:32:07 +03:00
Maksim Kita
150a88d647
ExpressionActions compile only necessary places
2021-05-19 11:43:16 +03:00
feng lv
c6f8ab9826
fix
2021-05-13 02:05:53 +00:00
feng lv
9035e3a643
fix test and conflict
2021-05-11 16:22:24 +00:00
Nikolai Kochetov
3296c9292f
Try to merge projectons faster.
2021-05-11 18:12:26 +08:00
Amos Bird
cd6414639e
add metadata_snapshot to getQueryProcessingStage
2021-05-11 18:12:26 +08:00
Alexey Milovidov
e23a0d8f7e
Fix warnings by PVS-Studio
2021-05-08 23:57:08 +03:00
feng lv
39f68bf5ff
fix conflict
2021-05-02 16:33:45 +00:00
feng lv
aed2f337e9
Fix CLEAR COLUMN does not work after #21303
2021-04-30 05:02:32 +00:00
feng lv
4ffe199d39
Implement table comments
2021-04-23 12:18:23 +00:00
Alexander Tokmakov
ad414bab05
fix assertion when filtering tables in StorageMerge
2021-04-12 22:04:26 +03:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr ( #22297 )
...
* Replace all Context references with std::weak_ptr
* Fix shared context captured by value
* Fix build
* Fix Context with named sessions
* Fix copy context
* Fix gcc build
* Merge with master and fix build
* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
vdimir
735154c81a
Handle not plain where tree in StorageMerge modifySelect
2021-04-06 12:29:29 +03:00
vdimir
3f464595eb
Accurate removing 'join' part for queries to 'Merge' engine
2021-04-01 14:31:57 +03:00
vdimir
fff8043e55
Revert "Fix joined table access with Merge engine and aggregation"
...
This reverts commit 5476e68d6c
2021-04-01 14:31:46 +03:00
vdimir
5476e68d6c
Fix joined table access with Merge engine and aggregation
2021-04-01 14:26:28 +03:00
Alexey Milovidov
230b2930b7
Merge branch 'master' into virtualutil
2021-03-30 00:43:00 +03:00
Nikolai Kochetov
a669f7d641
Merge branch 'master' into refactor-actions-dag
2021-03-05 18:21:14 +03:00
Nikolai Kochetov
9a39459888
Refactor ActionsDAG
2021-03-04 20:38:12 +03:00
Amos Bird
909cb3c243
Fix again....
2021-03-04 22:27:07 +08:00
Amos Bird
9205fad8c7
Better
2021-03-04 19:43:03 +08:00
Nikolai Kochetov
15921fbfcb
Remove index by name from ActionsDAG
2021-03-03 23:01:07 +03:00
feng lv
a26c9e64a9
fix
...
fix
2021-03-02 03:20:03 +00:00
feng lv
51021c1164
forbid to drop a column if it's referenced by materialized view
2021-02-28 05:24:39 +00:00
Nikolai Kochetov
e3d6ffd9dc
Remove AddingConstColumn step and transform.
2021-02-04 17:25:11 +03:00
sundy-li
ad01534bd5
Merge branch 'master' into alias_column_partition_prune
2021-01-12 18:28:30 +08:00
Alexey Milovidov
dab4719aac
Remove some headers
2021-01-05 06:22:06 +03:00
