Commit Graph

39368 Commits

Author SHA1 Message Date
Azat Khuzhin
40c65f7bee IRowInputFormat: omit "Skipped 0 rows with errors while reading the input stream"
This will just pollute the output log.

And this is significant for kafka streaming, since it will print this
message for each message (due to how
ReadBufferFromKafkaConsumer/KafkaBlockInputStream works).

You can see this in the server log of the test_storage_kafka
(integration test), for the table with kafka_skip_broken_messages > 0,
it will have 52 lines of such message, 2 with "Skipped 1 rows" and 50
with "Skipped 0 rows" (since there are 52 messages in summary, 2
malformed and 50 correct).
2020-04-25 15:16:29 +03:00
Mikhail f. Shiryaev
97253eb4cf
Add link to clickhouse-plantuml 2020-04-25 12:05:59 +02:00
Eldar Zaitov
d7a037c26b split fuzzers and sanitizers 2020-04-25 10:12:38 +03:00
Azat Khuzhin
83ab91f1ad docs/kafka: use ATTACH TABLE over ATTACH MATERIALIZED VIEW (all langs)
Since later requires full specification (engine and so on).
2020-04-25 03:08:00 +03:00
Azat Khuzhin
747a74215f Avoid processing all batches before Distributed shutdown 2020-04-25 02:03:27 +03:00
Azat Khuzhin
8ad6b37913 Proper StorageDistributed shutdown to avoid UAF in DistributedMonitor
StorageDistributed::shutdown() does not acquire the lock, that controls
access to the cluster_nodes_data, thus it does not synced with the
requireDirectoryMonitor(), hence some monitors can be untracked that
will trigger UAF (use-after-free) after DROP TABLE dist:

This is for the SIGSEGV from the DirectoryMonitor (with already destroyed storage):
    0  0x0000000008e9f760 in std::__1::__cxx_atomic_load<int> (__order=std::__1::memory_order::seq_cst, __a=0x0)
    1  std::__1::__atomic_base<int, false>::load (__m=std::__1::memory_order::seq_cst, this=0x0) <-- this is nullptr
    2  std::__1::__atomic_base<int, false>::operator int (this=0x0)
    3  DB::ActionBlocker::isCancelled (this=0x7f85e31c9bb8) at ../src/Common/ActionBlocker.h:18
    4  DB::StorageDistributedDirectoryMonitor::run (this=0x7f85f93b2a00) at ../src/Storages/Distributed/DirectoryMonitor.cpp:140
2020-04-25 02:03:26 +03:00
alexey-milovidov
519751232e
Merge pull request #10490 from CurtizJ/fix-doc
Fix docs of 'generateRandom' function
2020-04-25 01:42:24 +03:00
Anton Popov
f937cf99a6 fix docs of 'generateRandom' function 2020-04-25 00:47:27 +03:00
Avogar
13f6981bb0 Update markdown test reference 2020-04-25 00:17:33 +03:00
Ivan Blinkov
77b9696193
Update README.md 2020-04-24 23:29:32 +03:00
Артем Стрельцов
6fa25f16f8 french documentation edited too 2020-04-24 22:35:23 +03:00
Артем Стрельцов
96de73fb37 documentation edit (previous had mistypes) 2020-04-24 22:30:14 +03:00
tavplubix
7928f2eaa1
Merge pull request #7512 from ClickHouse/database_atomic
DatabaseAtomic
2020-04-24 22:28:18 +03:00
Артем Стрельцов
091d631b72 documentation edit 2020-04-24 22:28:11 +03:00
Alexander Tokmakov
04d4130b0d update yamake 2020-04-24 20:14:10 +03:00
Ivan Blinkov
8201693efe
Remove remnants of old MkDocs theme 2020-04-24 19:50:13 +03:00
Артем Стрельцов
5423506393 sure this will exactly fix the fail with build check 2020-04-24 19:04:54 +03:00
Anton Popov
fa2385b26b
Merge pull request #10476 from ClickHouse/filimonov-docker-ca-certificates
add CA certificates to clickhouse-server docker image
2020-04-24 15:09:17 +03:00
Ivan Blinkov
886fb86ec2
Create 044_xeon_silver_4114.json (#10478) 2020-04-24 15:05:23 +03:00
Alexander Tokmakov
53dcce55e9 better diagnostic info in input formats 2020-04-24 15:03:48 +03:00
Avogar
778f1aa1e7 Merge branch 'markdown_format' of github.com:avogar/ClickHouse into markdown_format 2020-04-24 14:07:04 +03:00
Avogar
2458da802c Update MarkdownRowOutputFormat 2020-04-24 14:06:41 +03:00
alesapin
793f4b734a Remove obsolete comment 2020-04-24 13:31:03 +03:00
alesapin
b4425c2dc4 Remove getColumn and hasColumn methods from IStorage 2020-04-24 13:20:03 +03:00
Артем Стрельцов
26a6353284 tried to fix build fail & fixed codestyle 2020-04-24 12:59:49 +03:00
Ivan Blinkov
388bcffec9
Rearrange includes at docs+changelog and move description templates (#10472)
* temp commit

* rearrange includes
2020-04-24 12:50:22 +03:00
alesapin
0c622370c5 Better 2020-04-24 12:21:38 +03:00
alesapin
dc2dd77d2e Remove redundant overrides from IStorage 2020-04-24 12:20:09 +03:00
alesapin
2dfe2cfac9 Merge branch 'master' into refactor_istorage 2020-04-24 12:00:53 +03:00
filimonov
db689843e1
add CA certificates to clickhouse-docker image 2020-04-24 10:52:47 +02:00
alesapin
a2cb67c542
Merge pull request #10459 from ClickHouse/refactor_istorage
Remove virtuals from IStorage as separate column
2020-04-24 11:42:04 +03:00
hcz
541cd638ba Fix overflow in simpleLinearRegression 2020-04-24 16:33:09 +08:00
Ivan Blinkov
f645a5beca
some non-breaking spaces 2020-04-24 10:52:07 +03:00
Ivan Blinkov
86d9eae195
restore lost word 2020-04-24 10:50:05 +03:00
alexey-milovidov
dfe55fc35c
Merge pull request #10456 from CurtizJ/no-backport-tag
Support 'no-backport' tags in list_backports script
2020-04-24 10:40:41 +03:00
alexey-milovidov
79d531af87
Merge pull request #10466 from ClickHouse/aku/arena-infinite-loop
Work around a bug leading to an infinite loop in addressToLine
2020-04-24 10:38:07 +03:00
alexey-milovidov
378107cd3f
Update ansi.md 2020-04-24 10:30:31 +03:00
Alexander Kuzmenkov
93e49ae10f performance comparison 2020-04-24 10:19:50 +03:00
Ivan Blinkov
3e8fc9478b
remove excessive css class 2020-04-24 10:04:47 +03:00
Ivan Blinkov
54e09dc20a
Draft of ANSI SQL compatibility article (#10457) 2020-04-24 10:02:44 +03:00
Alexander Kuzmenkov
79c5b7cc9f performance comparison 2020-04-24 06:23:38 +03:00
Anton Popov
a415540019 skip pr with no-backport 2020-04-24 03:36:37 +03:00
Alexander Kuzmenkov
2bedc82c18 Work around a bug leading to an infinite loop in addressToLine.
Fixing this is hopeless and would entail rewriting the entire
WriteBuffer thing, and also this hack is something we can backport.
2020-04-24 02:42:04 +03:00
Артем Стрельцов
aab2e8f9c1 unsignificant change 2020-04-24 02:21:51 +03:00
Артем Стрельцов
69fef04a4b added test 2020-04-24 02:12:45 +03:00
tavplubix
7d6ab32eb6
Update DatabaseCatalog.cpp 2020-04-24 01:08:26 +03:00
Артем Стрельцов
d7e27d4326 added SETTINGS section to DDL-query for CREATE DICTIONARY 2020-04-24 00:57:40 +03:00
Артем Стрельцов
f39fdf7182 some progress in parsing settings (i did this commit for having something to backup to) 2020-04-23 23:50:01 +03:00
Alexander Kuzmenkov
1bf02d459c performance comparison 2020-04-23 23:19:04 +03:00
Alexander Tokmakov
8be4d51111 fix build 2020-04-23 22:50:05 +03:00