Alexander Gololobov
0788269c25
Merge pull request #44410 from ClickHouse/fix_unicode_bar
...
Fix buffer overrun in UnicodeBar::render
2022-12-23 13:17:24 +01:00
kssenii
8308177361
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-23 12:14:46 +01:00
kssenii
853f2ea123
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-23 11:49:02 +01:00
Alexander Gololobov
0ae7f03516
Merge branch 'master' into fix_unicode_bar
2022-12-22 14:53:33 +01:00
alesapin
fa467b3398
Minor code polishing
2022-12-22 14:31:42 +01:00
vdimir
88008726d8
Merge branch 'master' into vdimir/tmp-data-in-fs-cache-2
2022-12-22 10:58:39 +00:00
alesapin
380c6cebe4
Merge pull request #44393 from ClickHouse/small_improvement
...
Lock table for share during startup for database ordinary
2022-12-22 11:42:42 +01:00
vdimir
d30d25dbbe
Temporary files evict fs cache
2022-12-22 10:22:49 +00:00
Vladimir C
6a0210fb0f
Merge pull request #43785 from mo-avatar/binhexstringliterals
2022-12-22 10:56:18 +01:00
Yakov Olkhovskiy
a8cb29da4b
Merge branch 'master' into refactoring-ip-types
2022-12-21 23:56:24 -05:00
Alexander Gololobov
4b0cbdb4a4
Fixed unused value warning
2022-12-21 10:55:20 +01:00
Robert Schulze
f8378473c4
Fix call to wrong overload on Darwin
2022-12-21 09:00:44 +00:00
Zhiguo Zhou
823cb8a8f0
Call std::condition_variable::notify_one w/o lock in ThreadPool
...
Calling notify_one function with lock held would let the notified
thread immediately block again, and increase the lock contention.
This commit moves the calls of notify_one function out of critical
sections of ThreadPool, whose lock (ThreadPoolImpl::mutex) is most
extensively contended in some workloads.
2022-12-21 13:50:03 +08:00
kssenii
1d75f740d7
Fix tests
2022-12-20 22:33:54 +01:00
kssenii
6bd4f8c029
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-20 21:17:28 +01:00
alesapin
c902bca426
Remove races
2022-12-20 18:14:06 +01:00
Alexander Gololobov
424ae4686e
Cleaups based on code review comments
2022-12-20 17:02:30 +01:00
Robert Schulze
3f03b0b53d
Revert "Revert "Add function 'age'""
...
This reverts commit 4549b14027
2022-12-20 10:18:43 +00:00
Raúl Marín
45d27f461b
Merge branch 'master' into perf_experiment
2022-12-20 09:07:48 +00:00
Alexander Gololobov
2ab6b7d033
Check remaining space to avoid buffer overruns; some cleanups
2022-12-20 02:39:44 +01:00
alesapin
c8d9ccf3cd
Lock table for share during startup for database ordinary
2022-12-19 18:51:46 +01:00
Sergei Trifonov
6f7bba159f
Merge pull request #41840 from ClickHouse/io-scheduler
...
IO scheduling subsystem
2022-12-19 15:15:19 +01:00
Robert Schulze
b93c56323c
Merge remote-tracking branch 'origin/master' into query-result-cache
2022-12-19 09:18:36 +00:00
Alexey Milovidov
0511532305
Merge pull request #44256 from azat/hashtable-fix
...
Fix double-free in HashTable::clearAndShrink() with zero elements in it
2022-12-17 03:20:22 +03:00
Sergei Trifonov
bded03e035
Merge branch 'master' into io-scheduler
2022-12-17 00:39:54 +01:00
kssenii
30547d2dcd
Replace old named collections code for url
2022-12-17 00:24:05 +01:00
Alexey Milovidov
d3fd9a6c1e
Merge pull request #44239 from azat/builtin-skim-v2
...
Builtin skim for fuzzy search in clickhouse client/local history
2022-12-16 21:23:24 +03:00
Sergei Trifonov
f61a98b5dc
Merge branch 'master' into io-scheduler
2022-12-16 15:55:08 +01:00
Azat Khuzhin
81be20edfe
Fix double-free in HashTable::clearAndShrink() with zero elements in it
...
Before this patch HashTable::clearAndShrink() did this:
destroyElements();
clearHasZero();
While destroyElements() already destroys the zero element, so it leads
to double free, like here [1].
[1]: https://s3.amazonaws.com/clickhouse-test-reports/40003/f09e956ddf150c1aceb210348544bc28876a2d11/stateless_tests__asan__[2/4].html
The issue is only for complex types.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-16 15:22:00 +01:00
Robert Schulze
d1615ec283
Display metrics for query result cache
2022-12-16 10:49:15 +00:00
Nikolai Kochetov
e99849d031
Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log
...
Track allocation ptr in system.trace_log. Add aggregate function flamegraph
2022-12-15 18:16:05 +01:00
Alexander Tokmakov
ec36ce7bb3
Merge branch 'master' into threads-in-overcommit-tracker-metric
2022-12-15 19:18:03 +03:00
Robert Schulze
537c64aad2
Merge remote-tracking branch 'origin/master' into query-result-cache
...
Conflicts:
- tests/queries/0_stateless/02117_show_create_table_system.reference
2022-12-15 12:17:58 +00:00
Alexey Milovidov
d8bb74d68a
Revert "Add information about written rows in progress indicator"
2022-12-15 10:19:15 +03:00
Azat Khuzhin
82aaad61aa
Integrate skim into the client/local
...
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.
P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC. But anyway
this will be resolved in a different way, but separatelly.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:57:41 +01:00
Dmitry Novik
3ab294be82
Also count waiting on global mutext
2022-12-14 18:05:07 +00:00
Dmitry Novik
1e5fdbdef0
Add ThreadsInOvercommitTracker metric
2022-12-14 16:56:19 +00:00
Azat Khuzhin
67fa185611
Revert "Builtin skim"
2022-12-14 17:17:19 +03:00
Alexey Milovidov
c93b7741b3
Merge branch 'master' into builtin-skim
2022-12-14 02:30:21 +03:00
Alexey Milovidov
4549b14027
Revert "Add function 'age'"
2022-12-13 23:28:09 +03:00
Nikolay Degterinsky
9b6d31b95d
Merge branch 'master' into perf_experiment
2022-12-13 17:15:07 +01:00
Igor Nikonov
ca06fd02c1
Merge pull request #43860 from bigo-sg/podopt
...
A little improve performance of PODArray
2022-12-13 12:57:22 +01:00
Vladimir C
ef45590413
Merge pull request #43925 from jh0x/improve-number-separator
...
Fixes https://github.com/ClickHouse/ClickHouse/issues/28967
2022-12-13 12:37:32 +01:00
Robert Schulze
1f9b34f133
Merge pull request #44049 from HarryLeeIBM/hlee-s390x-string-htable
...
Fix endian issue in StringHashTable for s390x
2022-12-13 09:27:52 +01:00
Alexey Milovidov
df17d1b71b
Merge branch 'master' into builtin-skim
2022-12-13 03:33:42 +03:00
Nikolai Kochetov
e451137040
Add comments.
2022-12-12 18:26:07 +00:00
Suzy Wang
093dc95d0f
Merge branch 'master' into s390x_crc32
2022-12-12 09:39:29 -05:00
Robert Schulze
b78652e138
Query result cache
2022-12-12 10:37:10 +00:00
Azat Khuzhin
9ed6aa0be1
Fix -Wshorten-64-to-32 on FreeBSD
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-12 08:05:28 +01:00
Azat Khuzhin
de58e9c02d
Integrate skim into the client/local
...
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.
P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-11 15:52:00 +01:00
Alexey Milovidov
9a48cf0da8
Merge pull request #40422 from pkubaj/patch-1
...
Add FreeBSD/powerpc64le support
2022-12-11 09:38:04 +03:00
mo-avatar
e88b85178f
Support SQL standard binary and hex string literals
2022-12-11 13:05:40 +08:00
Yakov Olkhovskiy
38707238b5
fix parser
2022-12-10 06:22:49 +00:00
Yakov Olkhovskiy
79a26203fe
add variant parser and use it for toIPv6
2022-12-10 04:39:43 +00:00
Boris Kuschel
592c73e2c3
Merge branch 'master' into openssl_support
2022-12-09 20:21:22 -05:00
Yakov Olkhovskiy
8a923e72fa
parser fixed, some optimizations
2022-12-10 00:48:44 +00:00
Yakov Olkhovskiy
02b253cffc
fix style
2022-12-09 21:35:05 +00:00
Yakov Olkhovskiy
f7799c173b
adapt IPv4 and IPv6 parsers for ReadBuffer, update to fit last master's merge
2022-12-09 21:20:52 +00:00
Suzy Wang
802f633f39
Merge branch 'master' into s390x_crc32
2022-12-09 15:00:46 -05:00
Anton Popov
17c557648e
Merge pull request #44045 from CurtizJ/fix-tracing-of-profile-events
...
Fix tracing of profile events
2022-12-09 14:12:58 +01:00
HarryLeeIBM
c381eb1b8e
Fix endian issue in StringHashTable for s390x
2022-12-08 08:56:56 -08:00
Yakov Olkhovskiy
0641066183
Merge branch 'master' into refactoring-ip-types
2022-12-08 11:12:05 -05:00
Anton Popov
3d2e46dfed
fix tracing of profile events
2022-12-08 15:13:53 +00:00
Boris Kuschel
cc3314acbe
Merge branch 'master' into openssl_support
2022-12-08 07:40:43 -05:00
Nikita Taranov
b81ad6aaf7
Add google benchmark to contrib ( #43779 )
...
* add google benchmark to contrib
* rework integer_hash_tables_and_hashes
* update readme
* keep benchmarks near the benchmarked code
* fix fasttests build
* rm old target
* fix
2022-12-08 13:38:08 +01:00
Alexander Gololobov
b2042fee32
Merge pull request #44001 from ClickHouse/Avogar-patch-1
...
Remove test logging of signal "EINTR"
2022-12-08 12:18:04 +01:00
Robert Schulze
f998d0c16b
Merge pull request #43228 from HarryLeeIBM/hlee-s390x-wide-int-order
...
Fix byte order issue of wide integers for s390x
2022-12-08 09:50:54 +01:00
Yakov Olkhovskiy
bf9194f405
review suggestions
2022-12-07 21:29:17 +00:00
Boris Kuschel
f03f95044e
OpenSSL code changes
2022-12-07 13:22:46 -05:00
Joanna Hulboj
c5296db521
Addressed PR comments
2022-12-07 14:23:01 +00:00
Joanna Hulboj
5bb9f851e0
Support numeric literals with underscores
2022-12-07 12:50:51 +00:00
Kruglov Pavel
d042664f54
Remove logging from TimerDescriptor
2022-12-07 13:33:29 +01:00
Kruglov Pavel
1197d3fbe3
Remove test logging of signal "EINTR"
2022-12-07 13:32:43 +01:00
zhanglistar
974df885e0
Rollback reserveForNextSize change
2022-12-07 10:29:00 +08:00
zhanglistar
25e607cce8
Merge branch 'master' into podopt
2022-12-07 10:24:56 +08:00
Nikolai Kochetov
7d6d0676ce
Fix build.
2022-12-06 16:59:40 +00:00
Nikolai Kochetov
9a4b3493fd
Merge branch 'master' into add-allocation-ptr-to-trace-log
2022-12-06 17:09:54 +01:00
Robert Schulze
f2cad33f1b
Merge pull request #43123 from arenadata/ADQM-623
...
Add function 'age'
2022-12-05 15:53:28 +01:00
Robert Schulze
3c1a721da4
Merge branch 'master' into hlee-s390x-wide-int-order
2022-12-04 18:47:00 +01:00
Roman Vasin
bcb65eb420
Merge branch 'master' into ADQM-623
2022-12-04 20:21:27 +03:00
kssenii
dca3444283
Merge remote-tracking branch 'upstream/master' into named-collections-sql-commands
2022-12-04 15:56:02 +01:00
Kseniia Sumarokova
ec7649cd90
Merge pull request #43639 from CurtizJ/trace-profile-events
...
Allow to send profile events to `system.trace_log`
2022-12-04 15:50:07 +01:00
Vladimir C
7d6950d397
Revert "Temporary files evict fs cache"
2022-12-02 14:50:56 +01:00
Roman Vasin
59523864b9
Merge branch 'master' into ADQM-623
2022-12-02 15:00:09 +03:00
Suzy Wang
e34af8602c
Merge branch 'master' into s390x_crc32
2022-12-01 11:02:43 -05:00
Suzy Wang
be16e0bce7
Include crc32_s390x as a submodule library
2022-12-01 07:43:32 -08:00
Vladimir C
117d01f2ac
Merge pull request #43457 from ClickHouse/vdimir/tmp-data-in-fs-cache
2022-12-01 13:41:40 +01:00
Alexander Gololobov
6388bc5000
Followup fixes for XML helpers ( #43845 )
2022-12-01 13:36:40 +01:00
Roman Vasin
620df1ec6f
Merge branch 'master' into ADQM-623
2022-12-01 15:30:36 +03:00
vdimir
7a814d2854
wip: temporary files evict fs cache
2022-12-01 11:49:24 +00:00
vdimir
98fe3c6c02
Temporary files evict fs cache
2022-12-01 11:49:17 +00:00
Antonio Andelic
1f93183dc7
Merge pull request #43087 from ClickHouse/keeper-prometheus
...
Add support for embedded Prometheus endpoint in Keeper
2022-12-01 12:46:47 +01:00
zhanglistar
c3f6ba6b68
A little improve performance of PODArray
2022-12-01 19:26:58 +08:00
Nikolai Kochetov
7649a3c4d7
Merge branch 'master' into add-allocation-ptr-to-trace-log
2022-12-01 12:12:23 +01:00
alesapin
5b4a16cabb
Merge pull request #43835 from ClickHouse/increase-logging-level-for-keeper
...
Increase some logging level for keeper client.
2022-12-01 12:01:54 +01:00
Roman Vasin
96d7cf319b
Merge branch 'master' into ADQM-623
2022-11-30 19:25:53 +03:00
Nikolai Kochetov
ecc45e5b1f
Review fixes.
2022-11-30 16:15:40 +00:00
Vladimir C
53dc70a2d0
Merge pull request #38191 from BigRedEye/grace_hash_join
...
Closes https://github.com/ClickHouse/ClickHouse/issues/11596
2022-11-30 17:01:00 +01:00
Vitaly Baranov
f966bf61e0
Merge pull request #43627 from ClickHouse/faster_backup_config_loading
...
Speedup backup config loading
2022-11-30 16:33:54 +01:00
Nikolai Kochetov
5a67ba8598
Increase some logging level for keeper client.
2022-11-30 15:21:14 +00:00
Antonio Andelic
2f501d5327
Merge branch 'master' into keeper-prometheus
2022-11-30 13:24:37 +01:00
Antonio Andelic
4a145b6c96
Merge pull request #43686 from ClickHouse/more-aggresive-batching-keeper
...
Try batching requests in Keeper more aggressively
2022-11-30 12:56:25 +01:00
Yakov Olkhovskiy
77266ea754
cleanup
2022-11-29 17:34:16 +00:00
Alexander Gololobov
6f6114993f
Enable test with 1M entries after the fix
2022-11-29 15:43:00 +01:00
Alexander Gololobov
06d04a81f5
Merge branch 'master' into faster_backup_config_loading
2022-11-29 14:29:58 +01:00
Antonio Andelic
db46842c8a
Merge branch 'master' into more-aggresive-batching-keeper
2022-11-29 12:58:33 +00:00
Nikolai Kochetov
51439e2c19
Merge pull request #43260 from ClickHouse/read-from-mt-in-io-pool
...
Read from MergeTree in I/O pool
2022-11-29 12:09:03 +01:00
Alexander Gololobov
0a5491c1aa
Merge branch 'master' into faster_backup_config_loading
2022-11-29 09:43:47 +01:00
Alexander Gololobov
a0bd99c8a2
Merge pull request #43584 from ClickHouse/fix_config_child_list_iteration
...
Iterate list without index-based access
2022-11-29 09:39:46 +01:00
Yakov Olkhovskiy
4d7d9cbd0b
some comments and beautification
2022-11-29 01:07:25 +00:00
Alexander Gololobov
8f49c1ea16
Moved helpers to Common/XMLUtils.*
2022-11-28 22:14:18 +01:00
Yakov Olkhovskiy
770b520ded
Merge branch 'master' into refactoring-ip-types
2022-11-28 08:50:19 -05:00
Alexander Gololobov
351c9f7bd2
Descrease element count to 50K until XML key enumeration is fixed in Poco
2022-11-28 13:36:12 +01:00
Alexander Gololobov
d88e3dfe33
Check time elapsed by config loading and key enumeration
2022-11-28 13:24:25 +01:00
Antonio Andelic
2b6661f87c
Use lock_guard
2022-11-28 09:17:33 +00:00
Antonio Andelic
678958603b
Merge branch 'master' into keeper-prometheus
2022-11-28 09:48:57 +01:00
Robert Schulze
143637404e
Merge pull request #43078 from ClibMouse/s390x_ip_coding
...
s390x ip coding functions fixes
2022-11-28 09:11:42 +01:00
Alexander Gololobov
603ccf147b
Test ConfigProcessor on a config with many elements
2022-11-28 00:36:42 +01:00
Antonio Andelic
cade21b76e
Fix 4LW test
2022-11-26 19:24:10 +00:00
Antonio Andelic
76eca8bdfb
Merge branch 'master' into more-aggresive-batching-keeper
2022-11-26 18:28:11 +00:00
Antonio Andelic
cd471e9c61
Add setting for quick batch size
2022-11-26 17:33:40 +00:00
Yakov Olkhovskiy
0854825151
fix DefaultHash64 for IPv6
2022-11-26 17:21:06 +00:00
Suzy Wang
d57a8b502d
s390x crc32 fix
2022-11-25 13:12:11 -08:00
Alexey Milovidov
f9c3de5aa5
Update ConfigProcessor.cpp
2022-11-26 00:09:33 +03:00
Alexey Milovidov
69d1be50bc
Merge pull request #43446 from ClickHouse/fix-typo-3
...
Fix typo
2022-11-25 15:22:28 +01:00
Nikolai Kochetov
660c942258
Merge branch 'master' into read-from-mt-in-io-pool
2022-11-25 13:56:48 +00:00
Anton Popov
396ecf826b
fix tests
2022-11-25 13:05:38 +00:00
Alexander Gololobov
38ecdc0627
Save next pointer before doing changes to the current element
2022-11-25 13:42:43 +01:00
Anton Popov
312dd725b4
allow to send profile events to trace_log
2022-11-24 20:12:16 +00:00
Alexander Gololobov
70c821ea4b
Fix iteration in other similar places
2022-11-24 19:08:45 +01:00
Ilya Yatsishin
6fcee9df85
Merge pull request #43496 from qoega/progress-add-writtten-rows
2022-11-24 17:31:02 +01:00
Nikolai Kochetov
d53439390f
Review fixes.
2022-11-24 16:04:35 +00:00
Igor Nikonov
20e67b7140
Merge remote-tracking branch 'origin/master' into HEAD
2022-11-24 13:10:37 +00:00
Vladimir C
a2e1269ef2
Revert "Fix endian issue in integer hex string conversion"
2022-11-24 12:22:22 +01:00
Antonio Andelic
a6f38cb1cc
Merge branch 'master' into keeper-prometheus
2022-11-24 12:12:08 +01:00
Vladimir C
b784128c88
Merge pull request #41245 from HarryLeeIBM/hlee-s390x-lru-file-cache
2022-11-24 12:08:36 +01:00
Sergei Trifonov
8186a06c28
Merge branch 'master' into io-scheduler
2022-11-24 12:02:52 +01:00
Raúl Marín
4d3217cb18
Merge branch 'master' into perf_experiment
2022-11-24 10:32:12 +01:00
Alexander Gololobov
85b1fb96a5
Iterate list without index-based access
2022-11-23 17:49:17 +01:00
Nikolai Kochetov
f7d02fbe75
Fixing special build.
2022-11-23 14:05:26 +00:00
kssenii
6044a9257c
Merge remote-tracking branch 'upstream/master' into named-collections-sql-commands
2022-11-23 12:00:55 +01:00
Alexey Milovidov
8cb34913a1
Merge pull request #42461 from Enmk/ldap_fix_search_limit
...
fix LDAP in case of many roles on user
2022-11-22 20:05:14 +01:00
Alexey Milovidov
c23b8c69db
Merge pull request #42791 from azat/fix-pe-overflow
...
Fix incorrect UserTimeMicroseconds/SystemTimeMicroseconds accounting
2022-11-22 19:22:51 +01:00
Raúl Marín
4aa29b6a63
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-11-22 19:09:00 +01:00
Alexey Milovidov
b7e4547f53
Merge branch 'master' into fix-typo-3
2022-11-22 18:30:06 +01:00
Alexey Milovidov
c8b068b4ff
Merge pull request #43447 from ClickHouse/netlink-remove-noise
...
Remove noise from logs about NetLink in Docker
2022-11-22 18:29:43 +01:00
Yatsishin Ilya
37bebcbe20
Add information about written rows in progress indicator
2022-11-22 14:29:22 +00:00
Sergei Trifonov
59f422f10c
Merge branch 'master' into storage-system-moves
2022-11-22 14:46:00 +01:00
Sergei Trifonov
3177ed050f
Merge pull request #43307 from ClickHouse/cpu-progress-protocol-fix
...
fix CPU load indication on client
2022-11-22 14:09:55 +01:00
Dmitry Novik
e67bda65a0
Merge pull request #43453 from ClickHouse/fix-hard-limit-in-test
...
Do not reuse jemalloc memory in test_global_overcommit
2022-11-22 13:24:34 +01:00
Nikolai Kochetov
9e84a351c7
Fixing special build. Disable setting by default.
2022-11-22 11:24:24 +00:00
Raúl Marín
8776b2f566
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-11-22 11:45:36 +01:00
Vitaly Baranov
6c2b53f0ae
Merge pull request #42940 from filimonov/exceptions_with_masker
...
Add SensitiveDataMasker to exceptions messages
2022-11-21 23:20:15 +01:00
kssenii
155ddd5521
Fix review comments
2022-11-21 21:50:24 +01:00
kssenii
a279bac767
Merge remote-tracking branch 'upstream/master' into named-collections-sql-commands
2022-11-21 21:49:34 +01:00
Dmitry Novik
b17dc24a94
Do not reuse jemalloc memory in test
2022-11-21 16:10:47 +00:00
Alexey Milovidov
4ab6896ece
Remove noise from logs about NetLink in Docker
2022-11-21 15:16:27 +01:00
Alexey Milovidov
56f8c0b84b
Fix typo
2022-11-21 15:10:15 +01:00
Raúl Marín
ed0c174c0c
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-11-21 11:02:31 +01:00
Antonio Andelic
e78761b66c
Merge branch 'master' into keeper-prometheus
2022-11-21 09:10:10 +01:00
Yakov Olkhovskiy
ee3ce9de70
bugs fixed, some optimization, cleanup, test fixed
2022-11-21 07:45:42 +00:00
Nikolai Kochetov
5da1d893fd
Merge branch 'master' into read-from-mt-in-io-pool
2022-11-18 21:10:45 +01:00
Azat Khuzhin
ccde92f855
Fix incorrect UserTimeMicroseconds/SystemTimeMicroseconds accounting
...
After #40732 it became possible that getrusage() (from detachQuery(),
from buildPushingToViewsChain()) will be called for incorrect thread,
and so when the difference will be calculated it will be simply garbage.
But actually the root of this problem is #25714 , after which it became
possible to have multiple ThreadStatus for one thread, and this is very
tricky (sigh).
Here are some other thoughts about it:
- Make ThreadStatus nested - decided that complexity does not worth it,
at least only for this case
- Move some members into ThreadGroupStatus - will break per-thread
statistics (and hence query_thread_log, BTW does somebody uses it?)
- Move some members into a separate structure
But decided to fix the issue w/o any refactoring, to make easy for
backport.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-18 21:10:43 +01:00
Azat Khuzhin
2b936a59e4
Add sanity checks RUsageCounters::incrementProfileEvents()
...
Can be triggered with the 02380_insert_mv_race test now in
debug/sanitizers build.
2022-11-18 21:10:43 +01:00
Yakov Olkhovskiy
dbaeabcf38
fixed some bugs, some functions corrected, some tests corrected
2022-11-18 20:10:27 +00:00
Sergei Trifonov
77100896e3
Merge branch 'master' into storage-system-moves
2022-11-18 16:33:43 +01:00
Sergei Trifonov
35d37bc198
Merge branch 'master' into cpu-progress-protocol-fix
2022-11-18 16:30:40 +01:00
Sergei Trifonov
d05223e70b
Merge pull request #43335 from ClickHouse/revert-43306-revert-43014-disk-s3-throttler
...
Revert "Revert "S3 request per second rate throttling""
2022-11-18 16:22:30 +01:00
Vitaly Baranov
a348332eab
Merge pull request #43227 from vitlibar/improve-masking-sensitive-info
...
Improve masking sensitive info
2022-11-18 15:37:50 +01:00
Suzy Wang
8dc99e8d64
Merge branch 'master' into s390x_ip_coding
2022-11-17 23:35:06 -05:00
Alexey Milovidov
2c292e3866
Merge branch 'master' into ldap_fix_search_limit
2022-11-17 22:20:53 +01:00
Sergei Trifonov
f2f0676bcc
Revert "Revert "S3 request per second rate throttling""
2022-11-17 17:35:04 +01:00
serxa
1920c6267d
typo
2022-11-17 16:20:21 +00:00
serxa
c0d98aa749
do not reorder, ignore 4 readings, fix period
2022-11-17 15:53:47 +00:00
Nikita Taranov
7beb58b0cf
Optimize merge of uniqExact without_key ( #43072 )
...
* impl for uniqExact
* rm unused (read|write)Text methods
* fix style
* small fixes
* impl for variadic uniqExact
* refactor
* fix style
* more agressive inlining
* disable if max_threads=1
* small improvements
* review fixes
* Revert "rm unused (read|write)Text methods"
This reverts commit a7e7480584
2022-11-17 13:19:02 +01:00
Vladimir C
a29c5b9e3a
Merge pull request #43232 from ClickHouse/vdimir/max_map_null_totals_bug
2022-11-17 13:10:05 +01:00
Sema Checherinda
1ad48d091d
Merge pull request #43249 from Algunenano/i43247
...
Fix ubsan in AggregateFunctionMinMaxAny::read with high sizes
2022-11-17 12:21:05 +01:00
Raúl Marín
97d6fc3071
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-11-17 11:48:46 +01:00
Alexander Tokmakov
9011a18234
Revert "S3 request per second rate throttling"
2022-11-16 22:33:48 +03:00
Sergei Trifonov
159743edd6
Merge pull request #43014 from ClickHouse/disk-s3-throttler
...
S3 request per second rate throttling
2022-11-16 18:51:06 +01:00
Alexey Milovidov
923f2dd562
Merge branch 'master' into ldap_fix_search_limit
2022-11-16 06:13:07 +01:00
Alexey Milovidov
b4165f95a9
Merge branch 'master' into build/poco-leftovers
2022-11-16 06:09:58 +01:00
Alexey Milovidov
04687c0d69
Merge pull request #43206 from ClickHouse/miscellaneous-changes-parallel-replicas
...
Miscellaneous changes
2022-11-16 05:30:03 +01:00
Vitaly Baranov
ce81166c7e
Fix style.
2022-11-16 01:35:11 +01:00
Vitaly Baranov
8d72f75556
Make the password wiping an option of IAST::format().
2022-11-16 01:35:06 +01:00
Yakov Olkhovskiy
813cb7fb0d
merge master
2022-11-15 22:46:05 +00:00
Yakov Olkhovskiy
273abdb5b0
bug fixes, optimizations
2022-11-15 21:49:35 +00:00
Suzy Wang
97d76771a4
update format
2022-11-15 08:53:39 -08:00
kssenii
234f6ee54d
Add commands CREATE/ALTER/DROP NAMED COLLECTION
2022-11-15 15:51:56 +01:00
Raúl Marín
143b67d0be
Fix ubsan in AggregateFunctionMinMaxAny::read with high sizes
2022-11-15 15:40:06 +01:00
Antonio Andelic
96838f5be7
Merge branch 'master' into keeper-prometheus
2022-11-15 12:00:02 +00:00
Kseniia Sumarokova
59cf5def67
Merge branch 'master' into disk-s3-throttler
2022-11-15 12:13:37 +01:00
Vladimir C
0017416069
Update src/Common/FieldVisitorSum.cpp
2022-11-15 11:55:54 +01:00
filimonov
8369998286
Style
2022-11-14 22:06:22 +01:00
vdimir
28fec44ffc
Fix merging null values in AggregateFunctionSumMap
2022-11-14 20:56:36 +00:00
HarryLeeIBM
0133444433
Fix byte order issue of wide integer for s390x
2022-11-14 10:47:32 -08:00
Mikhail Filimonov
19d39d7881
Add SensitiveDataMasker to exceptions messages
2022-11-14 19:06:17 +01:00
Vitaly Baranov
8e99f5fea3
Move maskSensitiveInfoInQueryForLogging() to src/Parsers/
2022-11-14 18:55:19 +01:00
Yakov Olkhovskiy
9aeebf3bdf
Merge branch 'master' into refactoring-ip-types
2022-11-14 09:21:54 -05:00
Yakov Olkhovskiy
4d144be39c
replace domain IP types (IPv4, IPv6) with native
2022-11-14 14:17:17 +00:00
Raúl Marín
4988e387f2
Merge remote-tracking branch 'blessed/master' into over-read
2022-11-14 12:28:31 +01:00
Kseniia Sumarokova
e58a7140be
Merge pull request #43194 from ClickHouse/async-metrics-documentation
...
Add documentation for `system.asynchronous_metrics`.
2022-11-14 12:21:34 +01:00
Kseniia Sumarokova
79206c6eb0
Merge pull request #43147 from kssenii/named-collections-refactoring
...
Add generic implementation for arbitrary structured named collections, access type and system.named_collections
2022-11-14 11:57:17 +01:00
Roman Vasin
ee0baa679b
Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-623
2022-11-14 09:45:32 +00:00
Antonio Andelic
ee182776da
Merge branch 'master' into keeper-prometheus
2022-11-14 09:14:13 +01:00
Alexey Milovidov
8e87e141a4
Miscellaneous changes
2022-11-14 06:57:53 +01:00
Alexey Milovidov
a77032fafa
Miscellaneous changes
2022-11-14 06:54:58 +01:00
Alexey Milovidov
b8c877db29
Fix annoying messages in AsynchronousMetrics
2022-11-12 19:07:28 +01:00
Alexey Milovidov
127631ee47
Merge branch 'master' into perf_experiment
2022-11-12 18:58:25 +01:00
Nikolai Kochetov
9106910de8
Try read from MergeTree in background pool.
2022-11-11 20:47:11 +00:00
Igor Nikonov
ee5756b5b4
Merge pull request #43122 from ClickHouse/revert-43116-revert-42607-igor/insert_zk_retries_retry
...
Revert "Revert " Keeper retries during insert (clean)""
2022-11-11 18:22:38 +01:00
kssenii
616da1f695
Review fixed, style check fix
2022-11-11 16:50:02 +01:00
Antonio Andelic
cbe92bf8c8
Merge branch 'master' into keeper-prometheus
2022-11-11 13:56:27 +01:00
Raúl Marín
54db7c6520
Enforce checking read output
2022-11-11 10:56:18 +01:00
Roman Vasin
35a1c406ad
Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-623
2022-11-11 07:35:44 +00:00
Azat Khuzhin
953457de28
Remove POCO_CLICKHOUSE_PATCH
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-10 22:41:26 +01:00
Maksim Kita
a6d2069c2b
Added compound types typo corrections
2022-11-10 19:21:51 +01:00
Maksim Kita
e220906c9e
Analyzer added identifier typo corrections
2022-11-10 19:21:51 +01:00
kssenii
c4f522b414
Support arbintrary structure collections
2022-11-10 16:32:15 +01:00
Igor Nikonov
f8c907c463
Revert "Revert " Keeper retries during insert (clean)""
2022-11-10 13:14:04 +01:00
Antonio Andelic
94aab4276c
Bring back heavy metrics
2022-11-10 12:56:27 +01:00
Alexander Tokmakov
fb8c527a2f
Revert " Keeper retries during insert (clean)"
2022-11-10 14:12:24 +03:00
Igor Nikonov
1b9be27fdb
Merge pull request #42607 from ClickHouse/igor/insert_zk_retries_retry
...
Keeper retries during insert (clean)
2022-11-10 12:01:00 +01:00
Roman Vasin
8f3a7b5024
Change algorithm into more accurate
2022-11-10 10:27:18 +00:00
Antonio Andelic
f2a9b5933d
Merge branch 'master' into keeper-prometheus
2022-11-10 09:28:06 +01:00
Suzy Wang
6ae4843b6d
Update fixes as suggested
2022-11-09 13:54:32 -08:00
Antonio Andelic
1ed3930809
Add more metrics for Keeper
2022-11-09 15:51:41 +01:00
Yakov Olkhovskiy
a930ad25e1
fix ub type punning
2022-11-09 09:44:59 -05:00
Yakov Olkhovskiy
7f28a89273
fix ub type punning
2022-11-09 09:39:27 -05:00
kssenii
e94e087187
Add generic named collections class and factory
2022-11-09 14:08:16 +01:00
Igor Nikonov
379113f8f1
Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry
2022-11-09 13:03:32 +00:00
Antonio Andelic
c92ae5a385
Add suport for AsyncMetrics in standalone Keeper
2022-11-09 13:46:03 +01:00
Alexander Tokmakov
1c6a617207
Merge branch 'master' into fix_intersecting_parts2
2022-11-09 14:38:18 +03:00
Suzy Wang
90250ea6ec
s390x ip coding functions fixes
2022-11-08 21:12:47 -08:00
Igor Nikonov
345304abe0
Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry
2022-11-08 20:26:50 +00:00
Sergei Trifonov
8eedd1e046
Merge branch 'master' into disk-s3-throttler
2022-11-08 15:00:56 +01:00
Nikolay Degterinsky
2b286222f7
Merge branch 'master' into tuple-of-intervals
2022-11-08 00:15:35 +01:00
Nikolay Degterinsky
48cc1d8492
Update DateLUTImpl.h
2022-11-08 00:15:19 +01:00
Sergei Trifonov
6d3b96ee42
Merge branch 'master' into storage-system-moves
2022-11-07 21:31:27 +01:00
Alexander Tokmakov
9210e586d2
fix
2022-11-07 20:27:18 +01:00
Alexander Tokmakov
b8174a63a8
Merge branch 'master' into fix_intersecting_parts2
2022-11-07 20:26:36 +01:00
serxa
2daec0b45e
S3 request per second rate throttling + refactoring
2022-11-07 18:05:40 +00:00
Vasily Nemkov
68dce47e72
Merge branch 'master' into ldap_fix_search_limit
2022-11-07 12:14:10 +04:00
Igor Nikonov
503649a638
Merge branch 'master' into igor/insert_zk_retries_retry
2022-11-06 22:55:13 +01:00
Alexey Milovidov
641f8576c6
Merge pull request #42003 from ClickHouse/write-progress-to-tty
...
Write progress directly to terminal
2022-11-05 16:51:37 +01:00
Igor Nikonov
859022660e
Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry
2022-11-04 23:31:51 +00:00
Krzysztof Góralski
98cc4535f0
Failed queries metrics for Async Inserts
2022-11-03 22:26:24 +01:00
Nikolay Degterinsky
30ad1a6826
Merge branch 'master' into perf_experiment
2022-11-03 02:18:21 +03:00
Alexander Tokmakov
e67d05604c
Merge branch 'master' into fix_intersecting_parts2
2022-11-02 19:30:27 +01:00
Vasily Nemkov
2be86ef5a7
Merge branch 'master' into ldap_fix_search_limit
2022-11-02 20:46:33 +04:00
