Mikhail Filimonov
975a061896
whitespaces
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
5c0a14b78c
Revert "fix2"
...
This reverts commit 0d8dce9e7629848ea0705cdf54c093f17c3e8089.
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
dc9d09d741
fix2
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
86f222a9c0
fix
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
bf665a17b9
fix the datarace, joining the threads before modifing the threads list is crucial
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
d7fede84d8
bit better exception message and comment
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
c772f8fa46
add some assert, and explicit keyword for constructor
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
0f8ef5fb20
fix types
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
c14195c381
further improvements
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
7652188ef4
grammar
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
e9dffc7897
whitespaces, unneeded method
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
9b1bc5ec77
some fixes
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
e0d8634f47
now works. it seem like the issue was caused by zero in max_free_threads in some scenarios
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
3eaf17603d
non-working, debug
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
ebd3306a67
fix
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
fbc3df5ebf
better atomics
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
34521ec662
fixes, tmp
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
dec4f59876
fixes
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
bd40b6775e
another approach
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
b31a3ac6d5
safer new_job queueing, use iterator
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
6d0dd0cf9d
ThreadPool refactorings to move thread creation out of critical section.
...
Encapsulate thread management in the new subclass ThreadFromThreadPool
2024-10-04 16:08:33 +02:00
avogar
07868f91b0
Revert unneded changes
2024-10-04 13:12:44 +00:00
avogar
31c1720086
Fix crash during GROUP BY JSON sub-object subcolumn
2024-10-04 13:12:04 +00:00
Pavel Kruglov
9c7cf57dd1
Fix build
2024-10-04 14:37:13 +02:00
Raúl Marín
bb57261f5d
Merge pull request #70338 from Algunenano/with_fill_analyzer
...
Fix crash when using WITH FILL incorrectly
2024-10-04 12:24:09 +00:00
Pavel Kruglov
a4cd3b326a
Merge branch 'master' into native-json-as-string
2024-10-04 14:14:39 +02:00
Anton Popov
af989353e4
Merge pull request #70273 from ucasfl/fix-use-of-uninitialized-vaue
...
Fix use-of-uinitialized-value
2024-10-04 12:06:21 +00:00
Nikolai Kochetov
c6d5d616fe
Fix typo.
2024-10-04 11:38:58 +00:00
Nikolai Kochetov
cccdd22f95
Add comments. Set proper setting.
2024-10-04 11:24:10 +00:00
Daniil Ivanik
2fdf802c93
Merge pull request #70101 from rschu1ze/vec-search-adaptive-granularity
...
Make vector similarity indexes work with adaptive granularity
2024-10-04 11:05:45 +00:00
Nikolai Kochetov
28bf90d6c1
Merge branch 'master' into add-compatibility-for-merge-tree-settings
2024-10-04 10:44:30 +00:00
Nikolai Kochetov
0cc5940fba
Merge pull request #70327 from jsc0218/IgnoreInDeduplicateMergeProjectionMode
...
Add Ignore Option In DeduplicateMergeProjectionMode
2024-10-04 10:25:43 +00:00
Azat Khuzhin
b74c8c60ac
Update comments in VectorSimilarityCondition (WHERE is not supported)
...
Follow-up for: 40bed3e20f
2024-10-04 11:14:00 +02:00
flynn
c7514a7912
Merge branch 'master' of github.com:ClickHouse/ClickHouse into iceberg-hdfs
2024-10-04 05:33:54 +00:00
pufit
213e08bfc8
Fix MODIFY COLUMN MODIFY SETTINGS crash for special columns
2024-10-04 01:13:52 -04:00
Julia Kartseva
53879083a9
Merge remote-tracking branch 'upstream/master' into interactive-metrics-table
2024-10-04 03:02:02 +00:00
Julia Kartseva
63d134692a
fix profile events units
2024-10-04 03:01:45 +00:00
pufit
1250251b4d
add FINAL modifier
2024-10-03 22:59:05 -04:00
pufit
dcbccc6f00
Merge branch 'master' into pufit/fix-implicit-grants
2024-10-03 22:58:44 -04:00
Shichao
0077924cee
use safeGet
2024-10-03 21:41:35 -04:00
Jiebin Sun
8e00adeaa8
Change the default threshold to enable hyper threading
...
Based on the testing data from PR#69548, we will change the
default threshold to enable hyper threading.
Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
2024-10-04 06:58:40 +08:00
avogar
377d6eef6a
Fix tests
2024-10-03 20:40:12 +00:00
avogar
7f32eb6b17
Fix tests, add docs and ramdomize new setting
2024-10-03 20:12:46 +00:00
jsc0218
40e2682c9e
reproduce inconsistent results with ignore option
2024-10-03 19:30:05 +00:00
jsc0218
6f3cf49229
add test and change doc
2024-10-03 17:44:35 +00:00
Raúl Marín
2dbef825b4
Fix crash when using WITH FILL incorrectly
2024-10-03 19:32:17 +02:00
Michael Kolupaev
9c95c47449
Merge remote-tracking branch 'origin/master' into mvrere
2024-10-03 17:13:44 +00:00
avogar
0110d3f540
Don't mutate variants
2024-10-03 15:12:37 +00:00
avogar
7790b0ee4a
Fix ALTER of Dynamic type with reducing max_types parameter
2024-10-03 15:07:13 +00:00
jsc0218
b59bd4d28d
don't change default
2024-10-03 15:06:50 +00:00
jsc0218
d25678fc21
add ignore option
2024-10-03 15:00:27 +00:00
Alexey Milovidov
164158af78
Sync with private
2024-10-03 16:34:25 +02:00
Alexey Milovidov
4c0c69f6df
Merge branch 'master' of github.com:ClickHouse/ClickHouse into sync-settings
2024-10-03 16:17:25 +02:00
Alexey Milovidov
6c94578f86
Sync with private
2024-10-03 16:16:48 +02:00
alesapin
eb984db51e
Merge pull request #70145 from ClickHouse/more_retryable_errors
...
Add more retryable errors to MergeTree data parts check and Filesystem cache
2024-10-03 13:59:22 +00:00
Alexey Milovidov
1efa73ad47
Apply modifications
2024-10-03 15:35:30 +02:00
Nikolai Kochetov
1d4e70c9b3
Add anotehr test.
2024-10-03 13:33:47 +00:00
Alexey Milovidov
d606e6b020
Synchronize settings with private
2024-10-03 15:32:48 +02:00
vdimir
a3ee8a8a0e
Merge pull request #69067 from ClickHouse/vdimir/full_text_index_packed_1
...
Better exception for unsupported full_text index with non-full parts
2024-10-03 13:29:39 +00:00
Konstantin Bogdanov
1d97c86539
Merge pull request #70264 from ClickHouse/fix-matview-intersect-segfault
...
Fix segfault on creating materialized view with intersect
2024-10-03 13:27:04 +00:00
Nikolai Kochetov
74de91f864
Add compatibility options for MergeTree settings.
2024-10-03 13:09:19 +00:00
Alexey Milovidov
1a5c05330d
Synchronize settings with private
2024-10-03 15:01:18 +02:00
avogar
ab04f21a9b
Fix flaky test, fix tidy build
2024-10-03 12:03:18 +00:00
avogar
766458aa0f
Allow to serialize JSON column as single String column in Native format
2024-10-03 11:44:47 +00:00
Pavel Kruglov
c8448c6a20
Fix tidy build
2024-10-03 12:35:52 +02:00
Kseniia Sumarokova
cea52cc76f
Merge pull request #70257 from ClickHouse/fix-cannot-schedule-task
...
Avoid `Cannot schedule a task` error when loading parts
2024-10-03 10:17:55 +00:00
Raúl Marín
3a19332744
Merge pull request #70207 from Algunenano/arrayMin_fix
...
Fix multiple issues with arrayMin and arrayMax
2024-10-03 10:17:04 +00:00
Kseniia Sumarokova
752a1ec466
Merge pull request #70141 from ClickHouse/refactor-object-storage-read
...
Refactor reading from object storage
2024-10-03 10:14:28 +00:00
Konstantin Bogdanov
89e1fbdfcf
Fix
2024-10-03 10:06:00 +02:00
pufit
2a107e3429
Add WITH IMPLICIT, fix error with implicit grants
2024-10-02 23:20:33 -04:00
Alexey Milovidov
8236c9049d
Merge pull request #69739 from sakulali/create_as_copy_sorting
...
CREATE TABLE AS copy PRIMARY KEY, ORDER BY, and similar clauses.
2024-10-03 02:31:20 +00:00
Alexey Milovidov
0ddcddc277
Merge pull request #70086 from alsugiliazova/remove-unused-placeholder
...
Remove unused placeholder from exception message string
2024-10-03 02:29:52 +00:00
Alexey Milovidov
6aaadf130c
Merge pull request #69845 from ClickHouse/fix-nan-with-fill
...
Fix WITH FILL with NaN keys
2024-10-03 02:12:59 +00:00
Pavel Kruglov
f0194a7fde
Merge branch 'master' into json-as-string-row-binary
2024-10-03 00:02:31 +02:00
Michael Kolupaev
f5dc38dad4
Merge remote-tracking branch 'origin/master' into mvrere
2024-10-02 21:25:40 +00:00
avogar
4fc9750ac7
Add docs, update settings changes history
2024-10-02 19:59:04 +00:00
avogar
b218e7e853
Allow to read/write JSON type as binary string in RowBinary format
2024-10-02 19:50:47 +00:00
kssenii
67fc9f9db8
Update LocalObjectStorage
2024-10-02 20:13:52 +02:00
Antonio Andelic
368c06c5cb
Merge pull request #70275 from ClickHouse/keeper-less-blocking-cluster-changes
...
Keeper improvement: less blocking during cluster changes
2024-10-02 17:41:23 +00:00
Antonio Andelic
39685473e3
Merge pull request #70175 from ClickHouse/debug-perf
...
Fix performance checks
2024-10-02 17:41:01 +00:00
Michael Kolupaev
1df357aab0
Merge remote-tracking branch 'origin/master' into mvrere
2024-10-02 16:57:22 +00:00
Michael Kolupaev
091f9cb711
Merge remote-tracking branch 'origin/master' into maxmap
2024-10-02 16:34:50 +00:00
avogar
3cd9793dba
Fix builds and comments
2024-10-02 16:25:34 +00:00
kssenii
4c82e8b3b0
Fix LocalObjectStorage
2024-10-02 17:43:43 +02:00
kssenii
45cff0443c
Add blocker inside runner as well because it is thread_local
2024-10-02 17:26:50 +02:00
avogar
278c88b580
Merge branch 'master' of github.com:ClickHouse/ClickHouse into default-implementation-for-dynamic
2024-10-02 15:21:45 +00:00
Antonio Andelic
80b355007e
Merge branch 'master' into debug-perf
2024-10-02 16:28:41 +02:00
Anton Popov
e389858f2c
Merge pull request #69875 from CurtizJ/perf-missing-defaults
...
Better performance of parsing with a lot of missing values
2024-10-02 14:18:06 +00:00
Yarik Briukhovetskyi
3198aafac5
Merge pull request #69755 from marco-vb/marco-vb/setting-stop-insert-on-full-disk
...
Add user-level settings min_free_diskspace_bytes_to_throw_insert and min_free_diskspace_ratio_to_throw_insert
2024-10-02 14:06:02 +00:00
flynn
3566ccbb8d
Fix use-of-uinitialized-value
2024-10-02 13:45:50 +00:00
Antonio Andelic
e980e24c45
Keeper improvement: less blocking during cluster changes
2024-10-02 15:12:47 +02:00
Raúl Marín
937348ec75
Merge pull request #69780 from Algunenano/readAndMerge
...
Remove unused buggy code
2024-10-02 12:38:24 +00:00
Antonio Andelic
d9f15cb062
Fix
2024-10-02 13:44:24 +02:00
kssenii
0c00272d3f
Fix tests
2024-10-02 13:34:25 +02:00
flynn
7900c37335
style
2024-10-02 11:18:41 +00:00
flynn
3332d59584
Support reading iceberg tables on HDFS
2024-10-02 11:15:16 +00:00
Raúl Marín
4421b8938e
Make clang-tidy happier and the code cleaner
2024-10-02 13:12:56 +02:00
Antonio Andelic
9349b1674c
Always use new binary
2024-10-02 13:05:40 +02:00
alesapin
ca2b6aeb26
Update src/Storages/MergeTree/checkDataPart.cpp
2024-10-02 12:30:42 +02:00
Pavel Kruglov
321980f650
Merge pull request #70218 from Avogar/respect-simdjson-setting
...
Respect setting allow_simdjson in JSON type parser
2024-10-02 09:48:42 +00:00
Yarik Briukhovetskyi
b0c19141e0
Merge branch 'master' into marco-vb/setting-stop-insert-on-full-disk
2024-10-02 11:40:37 +02:00
Robert Schulze
68cf49c653
Incorporate review feedback
2024-10-02 09:27:31 +00:00
kssenii
445e38bfe1
Fix page cache usage without cached disk, fix s3 file size if it is unknown
2024-10-02 10:55:53 +02:00
kssenii
9682ebc961
Avoid Cannot schedule a task error when loading parts
2024-10-02 10:46:23 +02:00
Kseniia Sumarokova
0ed1520c3e
Merge pull request #70114 from 1on/master
...
Fixed MaterializedPostgreSQL for subset of columns for several similar table names
2024-10-02 08:38:12 +00:00
Antonio Andelic
9bbe004150
Merge branch 'master' into debug-perf
2024-10-02 09:29:50 +02:00
tuanpach
856a367d2d
Merge pull request #69411 from tuanpach/add-enable-secure-identifiers-setting
...
Add enable_secure_identifiers setting
2024-10-02 04:57:47 +00:00
Anton Popov
6d2f9cab3a
Merge remote-tracking branch 'upstream/master' into HEAD
2024-10-02 01:20:37 +00:00
Michael Kolupaev
d5053605ab
Merge pull request #70149 from ClickHouse/loopsbro
...
Fix 'QueryPlan was not initialized' in 'loop' with empty MergeTree
2024-10-01 22:59:51 +00:00
Alexey Milovidov
229ead5f91
Merge pull request #70144 from Avogar/fix-dynamic-alter-hung
...
Fix possible hung in ALTER COLUMN with Dynamic type
2024-10-01 20:55:34 +00:00
Raúl Marín
d90336fdd8
Clean code
2024-10-01 22:51:28 +02:00
kssenii
087f1367fc
Fix file_size passing to ReadBufferFromS3
2024-10-01 22:19:47 +02:00
kssenii
e51b074614
Fix error seek is allowed only before first read attempt
2024-10-01 22:10:30 +02:00
Michael Kolupaev
574bb72824
Merge remote-tracking branch 'origin/master' into maxmap
2024-10-01 18:47:07 +00:00
Michael Kolupaev
88a3408522
Merge remote-tracking branch 'origin/master' into HEAD
2024-10-01 18:38:43 +00:00
Michael Kolupaev
ab4eee3b6d
Fix test flakiness
2024-10-01 18:16:42 +00:00
Pavel Kruglov
6f17263b0a
Merge pull request #70123 from Avogar/fix-nullable-nothing-type-in-table
...
Check for Nullable(Nothing) type during ALTER TABLE MODIFY COLUMN/QUERY
2024-10-01 17:59:56 +00:00
Pavel Kruglov
3c2dfb651a
Merge pull request #70147 from Avogar/fix-json-subcolumn-type
...
Fix Dynamic type creation of JSON subcolumn
2024-10-01 17:58:50 +00:00
Raúl Marín
6ba4f61df8
Merge remote-tracking branch 'blessed/master' into readAndMerge
2024-10-01 19:14:28 +02:00
avogar
b40af9c460
Respect setting allow_simdjson in JSON type parser
2024-10-01 17:13:18 +00:00
János Benjamin Antal
7a5f5342f0
Fix build
2024-10-01 16:22:37 +00:00
Nikolay Degterinsky
fbc020a8d8
Merge pull request #70148 from evillique/fix-bcrypt-query-log
...
Fix bcrypt password being displayed in system.query_log
2024-10-01 16:19:35 +00:00
Raúl Marín
a2c79e0690
Fix multiple issues with arrayMin and arrayMax
2024-10-01 18:12:53 +02:00
Antonio Andelic
84d57ca7bc
Merge branch 'master' into debug-perf
2024-10-01 17:44:00 +02:00
János Benjamin Antal
a614c405d9
Merge branch 'master' into validate-create-query-after-alter
2024-10-01 17:33:49 +02:00
kssenii
91622fbb72
Fix hdfs
2024-10-01 17:13:12 +02:00
Raúl Marín
c6225da019
Merge pull request #70127 from Algunenano/skip_bad_result
...
Fix wrong result with skipping index
2024-10-01 15:02:00 +00:00
Alexey Milovidov
3af8d9e100
Merge pull request #70142 from ClickHouse/of
...
Silence UBSAN for integer overflows in some datetime functions
2024-10-01 14:41:40 +00:00
Antonio Andelic
00b8fa3bfa
Debug performance checks
2024-10-01 16:35:48 +02:00
Pavel Kruglov
9ccfb1235b
Merge pull request #70137 from Avogar/fix-compress-data-race
...
Fix data race in ColumnObject/ColumnTuple decompress method
2024-10-01 14:24:00 +00:00
avogar
6a1e328d38
Fix crash in JSON column
2024-10-01 14:21:37 +00:00
Yakov Olkhovskiy
a1910161a5
Merge pull request #70153 from ClickHouse/fix-InterfaceNativeSendBytes
...
Fix: WriteBufferFromPocoSocket does not properly register all write events.
2024-10-01 13:25:28 +00:00
kssenii
a421c1ec30
Fix remote_filesystem_read_method=read
2024-10-01 15:17:18 +02:00
avogar
2033e1ee31
Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-postgresql-fixed-string-issue
2024-10-01 12:21:26 +00:00
Han Fei
5257422c5b
Merge pull request #69676 from ClickHouse/hanfei/fix-create-as-with-recursive
...
fix bug about `CREATE ... AS WITH RECURSIVE`
2024-10-01 12:03:04 +00:00
Robert Schulze
c6db85f1cd
Merge remote-tracking branch 'ClickHouse/master' into vec-search-adaptive-granularity
2024-10-01 11:57:30 +00:00
avogar
08fc2113f5
Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-nullable-nothing-type-in-table
2024-10-01 11:54:47 +00:00
Pablo Marcos
963d3f4f2c
Merge pull request #70122 from ClickHouse/remove-wrong-logical-error-for-range-literals
...
Fix wrong LOGICAL_ERROR when replacing literals in ranges
2024-10-01 11:36:40 +00:00
Dmitry Novik
edfaae0fea
Merge pull request #70124 from ClickHouse/vdimir/fix-68650
...
Better check for join expression type in JoinNode
2024-10-01 11:21:26 +00:00
Yarik Briukhovetskyi
82614d2c00
Merge pull request #70036 from yariks5s/to_start_of_interval_timezone_bug
...
Fix timezone bug with a date arguments in the `toStartOfInterval`
2024-10-01 11:12:10 +00:00
Nikita Taranov
3d2beccab9
Merge pull request #70130 from ClickHouse/fix_getNumberOfPhysicalCPUCores
...
Rename `getNumberOfPhysicalCPUCores` and fix its decription
2024-10-01 10:56:21 +00:00
Yarik Briukhovetskyi
f62c2ea4d8
enhance SettingsChangesHistory
2024-10-01 12:50:20 +02:00
kssenii
fd2e1ebf0c
Fix ObjectStorageSource::createReadBuffer
2024-10-01 12:17:06 +02:00
alesapin
71c1f44a0c
Add comment and reset read methods
...
(cherry picked from commit 2e912f320a396233865c4591af0e0c19885b4108)
2024-10-01 12:04:45 +02:00
kssenii
08cecb368a
Page cache prefix fix
2024-10-01 12:01:21 +02:00
alsu
ca4da4f964
revert
2024-10-01 11:59:18 +02:00
kssenii
fa557cfd73
Fix azure
2024-10-01 11:53:28 +02:00
alsu
c6d40fc839
remove extra dot from exception message
2024-10-01 11:20:06 +02:00
sakulali
f64f5ace2d
Merge branch 'master' into create_as_copy_sorting
2024-10-01 12:28:13 +08:00
Yakov Olkhovskiy
6eee7a1c83
increment profile event in WriteBufferFromPocoSocket::nextImpl()
2024-10-01 02:48:50 +00:00
