Commit Graph

1513 Commits

Author SHA1 Message Date
Igor Nikonov
1e43e3515e Check table status for parallel replicas 2024-04-17 16:47:52 +00:00
Nikita Mikhaylov
08c1901835 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keywords-2 2024-04-17 12:11:48 +00:00
Alexander Tokmakov
bfa5e55e8c
Merge pull request #62300 from ClickHouse/tavplubix-patch-10
Add local address to network exception messages
2024-04-12 12:26:35 +00:00
Alexey Milovidov
9664fb9249 Highlight only when necessary 2024-04-12 00:44:26 +02:00
Alexey Milovidov
da05238c8e Merge branch 'master' into revert-62508-revert-62123-full-syntax-highlight 2024-04-12 00:44:02 +02:00
Alexander Tokmakov
20e8b64cee fix 2024-04-11 21:40:39 +02:00
Konstantin Bogdanov
63351e2fbb
Merge branch 'master' into faster_01676_clickhouse_client_autocomplete 2024-04-11 01:34:05 +02:00
Alexander Tokmakov
dcd0831f4c fix 2024-04-11 00:12:52 +02:00
Yakov Olkhovskiy
d554dc61fb
Merge pull request #61923 from azat/local-input
Implement input() for clickhouse-local
2024-04-10 21:55:51 +00:00
Alexander Tokmakov
87476b8b98 Merge branch 'master' into tavplubix-patch-10 2024-04-10 23:37:22 +02:00
Alexey Milovidov
4f38bf4f6b
Revert "Revert "Rich syntax highlighting in the client"" 2024-04-10 21:39:02 +02:00
Igor Nikonov
912592ca78 Merge remote-tracking branch 'origin/master' into pr-receive-timeout-on-handshake 2024-04-10 18:35:33 +00:00
Igor Nikonov
619d1b42e1 Increase timeout 2024-04-10 18:35:20 +00:00
Raúl Marín
033efd7204
Revert "Rich syntax highlighting in the client" 2024-04-10 20:25:20 +02:00
Konstantin Bogdanov
fd0f6418e2
Merge branch 'master' into faster_01676_clickhouse_client_autocomplete 2024-04-10 16:15:21 +02:00
Alexey Milovidov
a2154418ee
Merge pull request #62123 from ClickHouse/full-syntax-highlight
Rich syntax highlighting in the client
2024-04-10 14:58:32 +02:00
Alexey Milovidov
1bae493ef7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into full-syntax-highlight 2024-04-10 14:57:36 +02:00
Kruglov Pavel
8ef64b0581
Merge pull request #61476 from Avogar/better-stress-upgrade-checks
Ignore DROP queries in stress test with 1/2 probability and TRUNCATE Memory/JOIN table instead of ignoring DROP in upgrade check
2024-04-10 12:43:22 +00:00
Konstantin Bogdanov
c8598bdb54
Add a flag to load suggestion data synchronously 2024-04-10 13:08:38 +02:00
János Benjamin Antal
af6ded7382
Merge pull request #62221 from azat/pager-output_format_pretty_max_value_width
Unlimited output_format_pretty_max_value_width for --pager
2024-04-10 10:46:55 +00:00
Alexey Milovidov
0e06a52962 Merge branch 'master' of github.com:ClickHouse/ClickHouse into full-syntax-highlight 2024-04-10 01:58:49 +02:00
Alexey Milovidov
0e7d05e091 Fix UBSan 2024-04-10 01:58:30 +02:00
Alexander Tokmakov
dedc25fd34 fix 2024-04-09 23:43:40 +02:00
Robert Schulze
8167b774b5
Merge pull request #62307 from rschu1ze/cleanup-ssh
Cleanup SSH-based authentication code
2024-04-09 21:10:09 +00:00
pufit
6329dc8124 fix 2024-04-09 15:05:49 +02:00
pufit
4e1f98ee7b removed cout,cerr from src 2024-04-09 14:53:28 +02:00
Robert Schulze
4035334634
Merge remote-tracking branch 'rschu1ze/master' into static-instance2 2024-04-09 11:45:27 +00:00
Alexey Milovidov
9ebf091ae4 Documentation 2024-04-08 13:03:55 +02:00
Alexey Milovidov
537f045c1c Miscellaneous 2024-04-08 12:39:23 +02:00
Alexey Milovidov
0ff26d2d77 A little better 2024-04-08 12:39:23 +02:00
Alexey Milovidov
fb664fa99f Slightly better 2024-04-08 12:39:23 +02:00
Alexey Milovidov
c8d6dc47c3 Fix test 2024-04-08 12:39:23 +02:00
Alexey Milovidov
b9406f79d1 Better highlighting 2024-04-08 12:39:23 +02:00
Alexey Milovidov
b369291d47 Rich syntax highlighting in the client 2024-04-08 12:39:23 +02:00
Alexey Milovidov
f5e9a09d69 Remove support for INSERT WATCH query 2024-04-08 05:37:09 +02:00
Robert Schulze
97281203b8
Don't access static members through instance, pt. II
clang-tidy rightfully complains
(-readability-static-accessed-through-instance) that static member
functions are accessed through non-static members
2024-04-07 11:09:35 +00:00
Kruglov Pavel
589034c34c
Merge branch 'master' into better-stress-upgrade-checks 2024-04-05 15:27:02 +02:00
Robert Schulze
9d8f643f5b
Cleanup SSH-based authentication code 2024-04-05 08:43:23 +00:00
Alexander Tokmakov
5a897bc43e
Update Connection.cpp 2024-04-04 20:16:26 +02:00
Kruglov Pavel
3116650fa9
Merge pull request #61201 from ClickHouse/revert-61200-revert-60430-max-parallel-replicas-validate
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-04-03 17:05:59 +02:00
avogar
d87d5a9197 Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks 2024-04-03 12:07:22 +00:00
Azat Khuzhin
4b668d0990 Unlimited output_format_pretty_max_value_width for --pager
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-03 12:33:14 +02:00
pufit
1f85889f88 FuzzQuery table function 2024-03-29 18:53:03 -04:00
Alexey Milovidov
9da4ce29db Revert output Pretty in tty 2024-03-29 16:16:15 +01:00
Nikita Mikhaylov
d18aba1194 Done 2024-03-27 19:26:19 +00:00
Azat Khuzhin
469be8ee8a Implement input() for clickhouse-local
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 13:49:53 +01:00
Igor Nikonov
972af33400 Timeout injection 2024-03-26 12:30:16 +00:00
Azat Khuzhin
c7b919b19e Replace distributed_insert_replicas_preferences with distributed_insert_skip_read_only_replicas
v2: fix test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:57 +01:00
Azat Khuzhin
a19b27bd7c Revert extra changed lines
That was the changes that looks OK for the initial patchset version, but
not now, after all review comments.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:16 +01:00
Azat Khuzhin
dbdf080108 Remove insert argument for ConnectionPoolWithFailover
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:22:38 +01:00
Azat Khuzhin
d922bfb1b0 Introduce distributed_insert_prefer_non_readonly_replica setting
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
0e99781686 Move insert flag from ConnectionEstablisher to TryResult
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
b9469e2729 Do not try to INSERT into readonly replicas for Distributed engine
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.

But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.

Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).

v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
    It make sense only when the table name had passed --
    ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:38 +01:00
Azat Khuzhin
be2767b55c Make ClientBase::parseQuery() static
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 10:54:57 +01:00
Alexey Milovidov
9b052d059d No "please" 2024-03-26 09:00:20 +01:00
Kruglov Pavel
de1229ba60
Merge branch 'master' into better-stress-upgrade-checks 2024-03-25 19:18:35 +01:00
Alexey Milovidov
6f11f85801 Remove unused header 2024-03-24 21:40:47 +01:00
Alexey Milovidov
c5ad3ae1c9 Merge branch 'master' into detect-lexer-errors-early 2024-03-24 21:39:38 +01:00
Alexey Milovidov
38130ef5a3 Fix build 2024-03-24 21:39:31 +01:00
Alexey Milovidov
c7917f747d Remove garbage from KQL, part 3 2024-03-24 19:34:30 +01:00
Alexey Milovidov
4db69c36f9 Remove unused code 2024-03-24 17:15:47 +01:00
Alexey Milovidov
c0c8cdc185 Add modifications 2024-03-23 02:42:22 +01:00
Alexey Milovidov
7365f4e32b Add modifications 2024-03-23 01:43:28 +01:00
Alexey Milovidov
18c016caaa Support for --output-format in client 2024-03-22 21:06:36 +01:00
Alexey Milovidov
4d113c2190
Merge pull request #61508 from ClickHouse/generic-clickhouse-local-fuzzer
Generic fuzzer of query text in clickhouse-local
2024-03-21 21:17:28 +03:00
Alexey Milovidov
14f45bfa74
Merge pull request #61679 from evillique/fix-msan-issue
Fix use-of-uninitialized-value in HedgedConnections
2024-03-21 18:09:40 +03:00
Alexey Milovidov
784de2dca3 Merge branch 'master' into generic-clickhouse-local-fuzzer 2024-03-21 03:18:05 +01:00
Nikolay Degterinsky
93dd212f6f Fix use-of-uninitialized-value in HedgedConnections 2024-03-20 23:55:25 +00:00
Alexey Milovidov
6f4ce33f02 Change how fuzzer arguments are parsed 2024-03-20 22:12:57 +01:00
Alexander Tokmakov
d4d19c611b Merge branch 'master' into signal_handlers_in_client 2024-03-20 19:38:28 +01:00
Kruglov Pavel
e7e11d738b
Merge branch 'master' into revert-61200-revert-60430-max-parallel-replicas-validate 2024-03-20 13:59:38 +01:00
Alexey Milovidov
7b7e260585 Merge remote-tracking branch 'origin/master' into generic-clickhouse-local-fuzzer 2024-03-20 01:28:28 +01:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
avogar
dba72bf9c5 Fix 2024-03-19 10:02:35 +00:00
avogar
31d5049f80 Move logic of ignoring drop queries to server 2024-03-18 16:26:05 +00:00
avogar
aadc610739 Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks 2024-03-18 15:27:58 +00:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Alexey Milovidov
2eb7de859d Correct arguments parsing 2024-03-18 02:35:32 +01:00
Alexey Milovidov
1a61da1bae Replace getFuzzerData with query text fuzzer in clickhouse-local 2024-03-18 02:17:24 +01:00
Alexey Milovidov
01136bbc3b Limit backtracking in parser 2024-03-17 19:54:45 +01:00
avogar
2e9130ca1e Better 2024-03-15 20:30:44 +00:00
avogar
aadfc37dda Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks 2024-03-15 20:27:16 +00:00
avogar
fa9d9ea3f7 Ignore DROP queries in stress test with 1/2 probability, use TRUNCATE instead of ignoring DROP in upgrade check for Memory/JOIN tables 2024-03-15 20:23:39 +00:00
Raúl Marín
b21a5fec7b Fix broken list and thank clang tidy 2024-03-14 15:06:08 +01:00
Raúl Marín
617138cf48 Teach the fuzzer to use other numeric types 2024-03-13 16:54:28 +01:00
Nikita Mikhaylov
ec3f24e31b Merge branch 'master' of github.com:ClickHouse/ClickHouse into signal_handlers_in_client 2024-03-12 14:52:07 +01:00
avogar
a065231ca1 Remove unused error code 2024-03-12 12:07:36 +00:00
avogar
dd6599868a Better check for 0 setting value 2024-03-12 12:06:25 +00:00
Nikita Mikhaylov
9dbd380b50 Dont handle SIGTERM and others for client 2024-03-11 22:40:19 +00:00
Kruglov Pavel
5608005b34
Revert "Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense"" 2024-03-11 21:22:45 +01:00
Kruglov Pavel
a90a6e9a27
Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense" 2024-03-11 21:05:44 +01:00
Nikita Mikhaylov
ff4ae13d9a Print only fatals 2024-03-11 18:26:23 +00:00
Nikita Mikhaylov
37affa6a09 Merge branch 'master' of github.com:ClickHouse/ClickHouse into signal_handlers_in_client 2024-03-11 17:49:59 +00:00
Kruglov Pavel
1c1336bdc0
Merge pull request #60430 from Avogar/max-parallel-replicas-validate
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-03-11 18:04:54 +01:00
Sema Checherinda
80179e50e4
Merge pull request #58845 from ClickHouse/chesema-session-pool
HTTP connections pool
2024-03-10 14:06:59 +01:00
Sema Checherinda
4df406d3ad work with review notes 2024-03-10 10:00:18 +01:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
tomershafir
453eb25984 rm trailing whitespace 2024-03-10 08:42:54 +02:00
tomershafir
4af16043b8 improve randomness by erase buf elem when full 2024-03-09 21:27:28 +02:00
Alexander Tokmakov
72ac59f44f add signal handlers in client and local 2024-03-08 22:30:49 +01:00
tomershafir
46332f334c rm unused alias set/vector pair 2024-03-08 15:17:07 +02:00
Sema Checherinda
62f9a00da8 shuffle resolved IPs 2024-03-07 13:09:26 +01:00
avogar
595c75ec53 Merge branch 'master' of github.com:ClickHouse/ClickHouse into max-parallel-replicas-validate 2024-03-05 11:19:04 +00:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Alexey Milovidov
e1e66dc2b8
Merge pull request #60095 from ClickHouse/fix-inconsistent-formatting
Fix inconsistent formatting of queries
2024-02-29 00:41:40 +03:00
Alexey Milovidov
d93d5c2a00
Merge pull request #60470 from ClickHouse/ClibMouse-bugfix/kql-distributed-tables
Merging #59674.
2024-02-28 19:24:14 +03:00
Alexey Milovidov
acbcffea13 Fix error 2024-02-27 23:33:16 +01:00
Kruglov Pavel
58a53b42ac
Set max_entries to min(max_parallel_replicas, all available reolicas) 2024-02-27 14:31:35 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Kruglov Pavel
f264f0a036
Fix style 2024-02-26 22:06:10 +01:00
Kruglov Pavel
8aa9f36484
Fix style 2024-02-26 22:05:54 +01:00
avogar
ac4af6a4ad Don't allow to set max_parallel_replicas to 0 as it doesn't make sense 2024-02-26 19:58:49 +00:00
Alexey Milovidov
6c6376de0a
Fix compatibility 2024-02-26 12:58:02 -05:00
Alexey Milovidov
3613464d46
Fix the code 2024-02-26 12:58:02 -05:00
Austin Kothig
f5ba7fde9f
Only set dialect if KQL or PRQL. 2024-02-26 12:58:01 -05:00
kothiga
70248639e8
Include PRQL. Added functional test that tests both KQL and PRQL. 2024-02-26 12:58:01 -05:00
kothiga
90a18326a5
Fix KQL distributed tables queries. 2024-02-26 12:58:01 -05:00
Alexey Milovidov
979cd2937b Fix inconsistent formatting of SET param_... 2024-02-26 02:11:51 +01:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
Igor Nikonov
0ead912127
Merge pull request #60158 from ClickHouse/fix-slowdown-count-side-effect
Fix: custom key failover test flakiness
2024-02-21 12:55:46 +01:00
Antonio Andelic
fee1565780
Revert "Check stack size in Parser" 2024-02-21 11:33:08 +01:00
Igor Nikonov
a8e4627663 Fix: can't guarantee query distribution with enabled hedged requests 2024-02-20 12:09:54 +00:00
Igor Nikonov
bb5a6dd8d3 Fix: custom key failover test flakyness
slowdown_count used only by hedge connections
but it's stored inside connection pool and was used for pool shuffling
always. So, query execution which used hedged connections could affect
connection load balancing for queries w/o hedged connections by updating
slowdown_count
2024-02-19 20:44:55 +00:00
Igor Nikonov
f06e15ce5f Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-19 11:33:55 +00:00
Alexey Milovidov
ad26b6fc8d Remove useless headers 2024-02-19 07:08:24 +01:00
Alexey Milovidov
6fd563df52 Miscellaneous 2024-02-19 02:58:51 +01:00
Alexey Milovidov
73ab7a5556 Merge branch 'master' of github.com:ClickHouse/ClickHouse into implement-todo 2024-02-18 09:24:22 +01:00
Alexey Milovidov
d10b18afeb I found TODO in the code, that can be implemented 2024-02-17 02:21:55 +01:00
Alexey Milovidov
2f315e0eb5 Style check for abbreviations 2024-02-17 02:14:15 +01:00
Igor Nikonov
b85a68790a Cleanup: connection pool priority -> config priority
- names were creating confusion between config priority and balancing priority for a reader
2024-02-16 14:39:41 +00:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection 2024-02-13 19:08:33 +01:00
Igor Nikonov
3fb30a23d9 Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2 2024-02-08 09:09:11 +00:00
Igor Nikonov
10082399d5 Minor review fixes 2024-02-07 00:52:25 +00:00
Igor Nikonov
b9848dbd2c Remove unused is_finished 2024-02-06 14:30:19 +00:00
Igor Nikonov
576cfdbf5c Includes cleanup 2024-02-05 14:27:07 +00:00
Raúl Marín
08c1799f9c
Merge pull request #59383 from Algunenano/fuzz_literal
Add some fuzzing to ASTLiterals
2024-02-05 12:27:43 +01:00
Igor Nikonov
7123a27f30
Merge pull request #59380 from ClickHouse/cleanup-connection-pool-surroundings
Cleanup connection pool surroundings
2024-02-04 22:34:07 +01:00
Igor Nikonov
c7499b7395 Use ConnectionPoolPtr instead of raw pointer 2024-02-02 18:43:09 +00:00
Raúl Marín
7be91e66dd Add reverse step 2024-02-02 18:11:56 +01:00
Igor Nikonov
c93a2cd2dd Remove unused header 2024-02-01 17:31:14 +00:00
Igor Nikonov
03249f3efa Fixes & comments
staleness -> delay (double -> UInt32)
2024-02-01 12:24:24 +00:00
Raúl Marín
4b5e992565 Fix problems 2024-01-30 19:34:01 +01:00
Raúl Marín
299c390d2b Add some fuzzing to ASTLiterals 2024-01-30 19:34:01 +01:00
avogar
377937d415 Merge branch 'master' of github.com:ClickHouse/ClickHouse into auto-format-detection 2024-01-29 15:45:18 +00:00
Alexey Milovidov
a7483ec10b
Merge pull request #59242 from rschu1ze/dont-force-libssh-on-me
Make libssh build dependent on `-DENABLE_LIBRARIES`
2024-01-29 00:02:03 +01:00
Robert Schulze
caeb31940c
Allow to build without libssl 2024-01-25 21:14:03 +00:00
Kruglov Pavel
46a6b84a5a
Merge branch 'master' into auto-format-detection 2024-01-25 22:11:07 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
avogar
1bff525666 Fix tests and docs 2024-01-23 18:59:40 +00:00
avogar
617cc514b7 Try to detect file format automatically during schema inference if it's unknown 2024-01-23 18:59:39 +00:00
Alexander Tokmakov
2f1d4f094b
Add a parameter for testing purposes (#59027)
* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp
2024-01-22 15:48:44 +01:00
Sema Checherinda
9adab57771
Correct initialization of ConnectionTimeouts (#59000) 2024-01-22 12:03:36 +01:00
Igor Nikonov
131f71b50a
Revert "Revert flaky" 2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover"
This reverts commit 8ba9b4a7ef, reversing
changes made to 0f39245cb8.
2024-01-19 12:46:05 +00:00
Igor Nikonov
8d4a395afa Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2024-01-10 20:28:04 +00:00
Igor Nikonov
e9fc869254 Fix test flakiness with hedge connections enabled 2024-01-10 15:59:48 +00:00
Robert Schulze
ced9e93ac6
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main 2024-01-09 20:36:02 +00:00
Alexey Milovidov
2c61015578 Do not load database engines in suggest 2024-01-07 23:06:36 +01:00
Robert Schulze
53965bb9f1
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main 2024-01-07 14:11:22 +00:00
Bharat Nallan Chakravarthy
3e8439a78b add to context access and suggest 2023-12-30 20:38:35 -08:00
Igor Nikonov
4fe54c213b Fix: round-robin load balancing for custom key queries
+ even subqueries distribution over available nodes for custom key query
+ creating load balancing instance for each custom key query separately
2023-12-27 15:06:41 +00:00
Igor Nikonov
bee15325fc Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-26 21:56:46 +00:00
Azat Khuzhin
3be3b0a280 Fix incorrect Exceptions
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-24 21:26:32 +01:00
jinjunzh
aaf98f0ed7 refine setting with enable_zstd_qat_codec 2023-12-22 14:24:15 -05:00
Igor Nikonov
db87ea0b86 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-20 20:48:51 +00:00
Yarik Briukhovetskyi
6e816d45ae
Merge branch 'master' into paste_join 2023-12-19 20:02:24 +01:00
yariks5s
4e418a89d9 fixed suggestions 2023-12-19 19:00:37 +00:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Igor Nikonov
f7e6a17052 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-10 20:21:47 +00:00
Igor Nikonov
87e47bdbee
Merge pull request #57467 from ClickHouse/rm-select
Remove select() usage
2023-12-09 22:27:28 +01:00
Igor Nikonov
94fb23af0b Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-07 11:52:40 +00:00
Azat Khuzhin
477b782f86 Handle editor exit code correctly
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-06 20:21:15 +01:00
Azat Khuzhin
028c01c458 Do not abort the client if temporary file for query editor cannot be created
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-06 20:21:15 +01:00
Igor Nikonov
60ba1abc17 Fix build 2023-12-05 12:58:29 +00:00
Igor Nikonov
71204c2a82 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-12-05 12:00:45 +00:00
Igor Nikonov
b3d3887f2c Fix test 2023-12-05 11:58:25 +00:00
Igor Nikonov
73ff984755 Remove select() usage 2023-12-04 09:33:34 +00:00
Azat Khuzhin
699d11628a Fix adjusting log_comment in case of multiple files passed
Previously, due to adjusting global_context and checking it as well, in
case of multiple files the log_comment will be adjusted only the first
time. Fix this by caching does user passed the log_comment explicitly or
not.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-04 10:02:24 +01:00
Raúl Marín
46acd8736c
Merge pull request #57189 from Algunenano/fix_respect_nulls
Fix RESPECT NULLS
2023-11-30 20:21:42 +01:00
Igor Nikonov
b4bf611d5d Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2023-11-30 14:09:26 +00:00
Raúl Marín
9432061652 Add RESPECT/IGNORE NULLS to the fuzzer 2023-11-29 12:41:15 +01:00
Raúl Marín
f1bbccd7dd Add suggestions about window functions 2023-11-29 12:14:37 +01:00
Igor Nikonov
961236a70b Change log level to avoid test failure 2023-11-29 00:05:28 +00:00
Yarik Briukhovetskyi
c4d157fe84
Update ClientBase.cpp 2023-11-28 15:38:20 +01:00
Yarik Briukhovetskyi
0b15efeb51
Update ClientBase.cpp 2023-11-28 14:41:55 +01:00
yariks5s
1ed776abfb consistency fix 2023-11-28 13:29:44 +00:00
yariks5s
ab0be2f236 init 2023-11-27 18:21:49 +00:00
Alexey Milovidov
fde14f0daf
Merge pull request #57191 from azat/client-log_comment-file
[RFC] Set log_comment to the file name while processing files in client
2023-11-26 03:44:40 +01:00
Alexey Milovidov
c50f096200
Merge pull request #57227 from azat/client-INS-cursor
Change cursor style for overwrite mode (INS) to blinking in client
2023-11-25 22:53:09 +01:00
Azat Khuzhin
ced0bbd932 Change cursor style for overwrite mode (INS) to blinking in client
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-25 22:00:56 +01:00
Azat Khuzhin
740cc3c053 Set log_comment to the file name while processing files in client
This will be useful for fuzzer, to know which file had been processed to
trigger the crash, since right now you need to find unique parts of the
query that had not been added by fuzzer to reproduce.

But I guess this will be useful not only for fuzzing, but for general
introspection as well.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-24 14:45:34 +01:00
Alexey Milovidov
98cddf5312
Merge pull request #57153 from ClickHouse/better-server-exit-code
Better server exit code
2023-11-23 23:55:28 +01:00
Alexey Milovidov
b62e9d3a1a Address review comments 2023-11-23 18:13:12 +01:00
Igor Nikonov
7c0198a26c Fix clang-tidy warning 2023-11-22 09:48:18 +00:00
Igor Nikonov
63a1625b77 Merge remote-tracking branch 'origin/master' into pr-cleanup-narrow-dependency 2023-11-21 16:05:48 +00:00
Igor Nikonov
ce98dfb251 Settings pointer to reference 2023-11-21 16:04:54 +00:00
Igor Nikonov
66f6a6575f Cleanup iteration: settings usage 2023-11-21 13:29:04 +00:00
Nikolay Degterinsky
fd26fab07f Merge remote-tracking branch 'upstream/master' into local-send-fatal-log 2023-11-19 17:59:51 +00:00
Nikolay Degterinsky
cf46214440 Always send fatal level logs 2023-11-19 15:09:52 +00:00
Kruglov Pavel
413c3d1ee3
Merge pull request #55994 from Avogar/fix-bad-logs-level-in-local
Fix clickhouse-local exit on bad send_logs_level setting
2023-11-16 14:49:23 +01:00