Commit Graph

4240 Commits

Author SHA1 Message Date
Alexander Tokmakov
4d03c23166
Merge pull request #51851 from ClickHouse/add_delay_for_replicated
Make shutdown of `ReplicatedMergeTree` tables more soft
2023-07-26 12:59:37 +03:00
Kruglov Pavel
93e10077ba
Fix attaching gdb in stress tests (#51445)
* Fix attaching gdb in stress tests

* Fix

* Update run.sh

* Try remove run_with_retry

* Return run_with_retry

* Don't set -e in run_with_retry if it was't set before

* Update tests/ci/utils.lib

* Fix bash

---------

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-07-26 12:53:19 +03:00
Alexander Tokmakov
6bbed6262e
Merge branch 'master' into add_delay_for_replicated 2023-07-26 12:48:48 +03:00
Alexey Milovidov
34ff0e0ea9
Merge pull request #52184 from azat/tests/randomize-timezone
Randomize timezone in tests across non-deterministic around 1970 and default
2023-07-24 22:47:52 +03:00
Alexander Tokmakov
faca49a905 Merge branch 'master' into add_delay_for_replicated 2023-07-24 16:07:38 +02:00
Azat Khuzhin
2389e0f0b6 Randomize timezone in tests across non-deterministic around 1970 and default
There was some cases when some patches to the datetime code leads to
flaky tests, due to the tests itself had been runned using regular
timezone (TZ).

But if you will this tests with something "specific" (that is not
strictly defined around 1970 year), those tests will fail.

So to catch such issues in the PRs itself, let's randomize
session_timezone as well.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-24 06:13:12 +02:00
Alexey Milovidov
a17652a422 Merge branch 'master' into incbin 2023-07-24 05:33:52 +02:00
Alexey Milovidov
63659c55a1 Merge branch 'incbin' into no-export-dynamic 2023-07-23 21:34:12 +02:00
Alexey Milovidov
0f66d161d6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into no-export-dynamic 2023-07-23 21:33:51 +02:00
Ilya Yatsishin
7a24ed195d
Merge branch 'master' into create-index-unique-noop 2023-07-23 20:47:11 +02:00
Alexey Milovidov
4c1f8f38cd Fix CI 2023-07-23 17:30:23 +02:00
Alexey Milovidov
43cf31a98e
Merge branch 'master' into no-export-dynamic 2023-07-23 07:26:33 +03:00
alesapin
d1fa105d60
Merge branch 'master' into add_delay_for_replicated 2023-07-23 00:12:29 +02:00
Azat Khuzhin
0b258dda4e Reproducible builds for Rust
From now on cargo will not download anything from the internet during
builds. This step had been moved for docker image builds (via cargo
vendor).

And now cargo inside docker.io/clickhouse/binary-builder will not use
any crates from the internet, so we don't need to add --offline for
cargo commands in cmake (corrosion_import_crate()).

Also the docker build command had been adjusted to allow following
symlinks inside build context, by using tar, this is required for Rust
packages.

Note, that to make proper Cargo.lock that could be vendored I did the
following:
- per-project locks had been removed (since there is no automatic way to
  sync the workspace Cargo.lock with per-project Cargo.lock, since cargo
  update/generate-lockfile will use only per-project Cargo.toml files
  apparently, -Z minimal-versions does not helps either)
- and to generate Cargo.lock with less changes I've pinned version in
  the Cargo.toml strictly, i.e. not 'foo = "0.1"' but 'foo = "=0.1"'
  then the Cargo.lock for workspace had been generated and afterwards
  I've reverted this part.

Plus I have to update the dependencies afterwards, since otherwise there
are conflicts with dependencies for std library. Non trivial.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-22 22:46:22 +02:00
Mikhail f. Shiryaev
cf01800a63 Sort DOCKER_*_TAG stuff 2023-07-22 15:45:47 +02:00
Mikhail f. Shiryaev
c6e9f621f1 Replace kssenii/nginx-test:1.1 by clickhouse/nginx-dav 2023-07-22 15:45:47 +02:00
Mikhail f. Shiryaev
8c0113e02b Sanitize compose files in integration-tests-runner 2023-07-22 15:45:47 +02:00
alesapin
6416fb6eed
Merge branch 'master' into add_delay_for_replicated 2023-07-22 12:11:39 +02:00
Alexey Milovidov
de2016261e Get rid of it 2023-07-22 05:08:27 +02:00
Alexey Milovidov
e5797b7fea
Merge pull request #51514 from azat/tests/fix-integration-tests
Fix running integration tests with spaces in it's names
2023-07-22 03:38:51 +03:00
Yatsishin Ilya
bb4924ab63 Multiple sqllogictest improvements 2023-07-19 12:24:31 +00:00
Ilya Golshtein
4259176f24 test_for_basic_auth_registry - original zk configuration restored 2023-07-19 08:32:45 +00:00
Ilya Golshtein
aa2b7e248d test_for_basic_auth_registry - fix port in test_kafka_formats 2023-07-19 08:32:45 +00:00
Ilya Golshtein
83569688cb test_for_basic_auth_registry - UnknownTopicOrPartitionException 2023-07-19 08:32:45 +00:00
Ilya Golshtein
66581d091a test_for_basic_auth_registry - both tests works, simplifications 2023-07-19 08:32:45 +00:00
Ilya Golshtein
db8e96147a test_for_basic_auth_registry - started, but only auth test works 2023-07-19 08:32:45 +00:00
Ilya Golshtein
fb3a860d7f test_for_basic_auth_registry - one kafka instance again 2023-07-19 08:32:45 +00:00
Ilya Golshtein
e3523cb1a4 test_for_basic_auth_registry - attempt to have two kafka instances 2023-07-19 08:32:45 +00:00
Ilya Golshtein
8b0fc82834 test_for_basic_auth_registry - mock up 2023-07-19 08:32:44 +00:00
Antonio Andelic
3c2507ad7d
Merge branch 'master' into fix-packager 2023-07-18 09:18:03 +02:00
Nikita Mikhaylov
11cc8b4adf
Merge branch 'master' into add_delay_for_replicated 2023-07-17 19:04:29 +02:00
Azat Khuzhin
6f6562c96b Fix running integration tests with spaces in it's names
Previously they were simply ignored, and not only them, but all the
tests in that group, here is an example [1]

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/51448/4ed462ac7834a8180f92ca7d7d3c076e687bfca9/integration_tests__asan__[4_6].html

Note, that I've replaced PYTEST_OPTS with handled by pytest itself
PYTEST_ADDOPTS, since "sh -c $PYTEST_OPTS" does not allows you to
preserve the arguments correctly.

v5: use double quotes for PYTEST_ADDOPTS value
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-17 17:17:21 +02:00
Azat Khuzhin
2720e9177d Fix flakiness of test_keeper_s3_snapshot
This is part of "Why my PR is not merged?" patch set series.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-13 14:25:24 +02:00
John Spurlock
7c7a447fd2
Fix a few typos in docker readme. 2023-07-11 12:16:55 -05:00
robot-clickhouse-ci-1
4666838a5d
Merge pull request #49438 from azat/build/unwind
Force libunwind usage (removes gcc_eh support)
2023-07-09 05:38:34 +02:00
robot-clickhouse
45d36b736a Update version_date.tsv and changelogs after v23.6.2.18-stable 2023-07-08 23:14:02 +00:00
Azat Khuzhin
a10aa9ad50 Force libunwind usage (removes gcc_eh support)
libunwind is reentrant and signal safe, and works faster then then
gcc_eh (plus it has some custom patches for problems that have been
found during it's usage in ClickHouse).

gcc_eh may be missing in the system (if gcc was not installed), and
even if it exists clickhouse uses -nodefaultlibs, so some care should be
made to make it work.

Also this library is tiny and there shouln't be any problem to require
it always (there is already tendency to require some contrib libraries,
i.e. poco).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-08 20:55:50 +02:00
Alexey Milovidov
c828db5720 Allow OOM in AST Fuzzer with Sanitizers 2023-07-08 05:57:23 +02:00
Alexey Milovidov
d15723997b
Merge pull request #51863 from ClickHouse/remove-useless-packages
Remove useless packages
2023-07-08 02:21:07 +03:00
Alexey Milovidov
f8eaa3e8e6
Merge pull request #51903 from azat/build/pin-rust
Pin rust nightly (to make it stable)
2023-07-07 20:28:57 +03:00
Alexey Milovidov
cf66be571f
Merge branch 'master' into remove-useless-packages 2023-07-07 13:44:13 +03:00
Alexey Milovidov
6cfeef00d7
Merge pull request #31398 from ClickHouse/riscv-in-ci
Add Linux RISC-V 64 build to CI
2023-07-06 22:49:16 +03:00
Azat Khuzhin
ec5e26a017 Pin rust nightly (to make it stable)
Because of using Rust nightly, and without #49601 the Rust toolchain is
very unstable, and can be frequently failed.

So let's ping particular version.

Also I've looked and it seems that Rust archives stores this archive
without any TTL, since there is even a version for 2015 year.

Follow-up for: #50541
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-06 21:17:50 +02:00
Antonio Andelic
c390c900c5
Merge branch 'master' into upgrade-check-fix-2 2023-07-06 21:10:41 +02:00
Alexander Sapin
9ae0dc730c Review fixes + enable in ci 2023-07-06 17:15:26 +02:00
Mikhail f. Shiryaev
6bbaade4a6
Update sccache, do not fail on connection error 2023-07-06 16:09:52 +02:00
Antonio Andelic
f825c85c72
Merge branch 'master' into fix-packager 2023-07-06 08:36:43 +02:00
Antonio Andelic
085f7caccf Move config changes after configure 2023-07-06 06:30:47 +00:00
Alexey Milovidov
75d051dd55 Remove useless packages 2023-07-06 01:49:53 +02:00
Alexey Milovidov
70bcf28f4a
Merge pull request #51839 from ClickHouse/fix-upgrade-test-disks
Fix disk config for upgrade tests
2023-07-06 00:35:18 +03:00
Antonio Andelic
1124c7ae8b Correctly move config 2023-07-05 12:42:36 +00:00
Mikhail f. Shiryaev
bcc569b9e3
Add temporary pin for docker-ce 2023-07-05 10:28:57 +02:00
Alexey Milovidov
1eaa2e9d30
Merge branch 'master' into no-export-dynamic 2023-07-04 22:37:46 +03:00
Alexey Milovidov
1eafba60d2 Merge branch 'master' into riscv-in-ci 2023-07-04 21:28:05 +02:00
Antonio Andelic
5b31c714a0
Merge branch 'master' into fix-packager 2023-07-04 15:48:31 +02:00
Alexey Milovidov
aa2b8aa893
Merge pull request #51769 from ClickHouse/mypy-1.4.0
Version mypy=1.4.1 falsly reports unused ignore comment
2023-07-04 16:45:57 +03:00
Antonio Andelic
3277e4b5bd Fix build type in packager 2023-07-04 11:22:19 +00:00
Antonio Andelic
6d3dbae8aa Merge remote-tracking branch 'origin/docs-packaging' into fix-packager 2023-07-04 11:21:53 +00:00
Alexey Milovidov
463c2ba5ce
Revert "Add documentation for building in docker" 2023-07-04 14:07:10 +03:00
Mikhail f. Shiryaev
35c1321952
Version mypy=1.4.1 falsly reports unused ignore comment 2023-07-04 13:05:41 +02:00
Mikhail f. Shiryaev
c715ee5cef
Replace --build-type=debug by --debug-build 2023-07-03 19:58:47 +02:00
Mikhail f. Shiryaev
469da1831a
Replace --build-type=debug by --debug-build 2023-07-03 17:42:15 +02:00
Mikhail f. Shiryaev
d0c3847427
Fix source image for sqllogic 2023-07-03 12:29:12 +02:00
Alexander Tokmakov
ce5ca7d2a5
Merge pull request #51502 from ClickHouse/fix_logical_error_on_mutation
Fix a logical error on mutation
2023-07-03 12:52:59 +03:00
Antonio Andelic
aeea3dc824 Add odbcinst dep to sqllogic docker 2023-07-03 07:40:05 +00:00
Alexander Tokmakov
43dba76cbf
Merge branch 'master' into fix_logical_error_on_mutation 2023-07-02 19:30:00 +03:00
Antonio Andelic
c06afc53b4 Make scripts backwards compatible 2023-07-02 09:57:06 +00:00
Antonio Andelic
d8238086c6
Merge branch 'master' into better-gdb-wait 2023-07-01 10:39:49 +02:00
robot-clickhouse
8ed1ec49d1 Update version_date.tsv and changelogs after v23.6.1.1524-stable 2023-06-30 15:21:13 +00:00
Antonio Andelic
00aeb407e5 Wait with retries 2023-06-30 14:52:21 +00:00
Alexander Tokmakov
d572eff106
Merge branch 'master' into fix_logical_error_on_mutation 2023-06-30 15:12:35 +03:00
Alexey Milovidov
1e6f6b522c
Merge pull request #51180 from ClickHouse/update-tests-docker
Update tests' docker containers
2023-06-30 11:24:59 +03:00
Antonio Andelic
447a4e7b2a
Merge branch 'master' into add-retries-for-zk-create 2023-06-29 20:38:37 +02:00
Antonio Andelic
d1bb8f24c0 Retry chroot creation in ZK 2023-06-29 15:18:32 +00:00
Mikhail f. Shiryaev
ef55e4e94d
Merge pull request #51561 from ClickHouse/ci-for-backports
Decoupled commits from #51180 for backports
2023-06-29 16:04:43 +02:00
robot-clickhouse
5656d18690 Update version_date.tsv and changelogs after v23.5.4.25-stable 2023-06-29 13:36:55 +00:00
Mikhail f. Shiryaev
340262814a
Avoid additional maven requests for spark tests 2023-06-29 12:24:19 +02:00
Mikhail f. Shiryaev
92d7b067b0
Bring back lost /tmp cleanup in clickhouse-server docker image 2023-06-28 23:39:08 +02:00
Alexander Tokmakov
296f9968c0 fix 2023-06-28 23:20:02 +02:00
Mikhail f. Shiryaev
406896f9a9
Create cgroupsv2 subtree for docker-in-docker 2023-06-28 22:19:41 +02:00
Mikhail f. Shiryaev
91dc6dfe34
Update mysql-php-client to the recent rolling version 2023-06-28 22:19:39 +02:00
Mikhail f. Shiryaev
ead81879b4
Update integration tests runner too 2023-06-28 22:19:32 +02:00
Mikhail f. Shiryaev
edcf981c48
Update mysql odbc connector 2023-06-28 22:19:31 +02:00
Mikhail f. Shiryaev
5a8ce1f2fe
Do not upload the binaries for fast-tests to tests-reports 2023-06-28 22:19:30 +02:00
Mikhail f. Shiryaev
b68d8fa76e
Update the OS version for builder and testers docker images 2023-06-28 22:19:30 +02:00
Mikhail f. Shiryaev
7b4e6faece
Speedup the submodules cloning 2023-06-28 22:19:28 +02:00
Mikhail f. Shiryaev
45cd7f35cd
Use clickhouse/integration-helper from changed images 2023-06-28 22:11:48 +02:00
Mikhail f. Shiryaev
67a7bdbb3a
Rollback note about 22.04 in #50958 2023-06-28 10:45:07 +02:00
Mikhail f. Shiryaev
1cd5ae36bd
Get rid of deprecated apt-key 2023-06-28 10:32:21 +02:00
Mikhail f. Shiryaev
6d2b5166b9
Update golang version in builder 2023-06-28 10:32:20 +02:00
Mikhail f. Shiryaev
a2c4546c00
Downgrade the base image to address issues on old dockerd 2023-06-28 10:32:19 +02:00
Mikhail f. Shiryaev
6145baade8
Upgrade OS only once
The ubuntu images are updated twice a month, it makes sense to do
upgrade
https://github.com/docker-library/official-images/commits/master/library/ubuntu
2023-06-28 10:32:19 +02:00
Mikhail f. Shiryaev
04a08b47f3
Reorganize installation of clickhouse to have separated layers 2023-06-28 10:32:18 +02:00
Alexey Milovidov
de58339c3b Merge branch 'fix-perf-tests-jemalloc' of github.com:azat/ClickHouse into many-fixes 2023-06-27 05:35:26 +02:00
Alexey Milovidov
4ee74ec213 Two tests are twice longer in average with Analyzer and sometimes failing 2023-06-26 02:19:52 +02:00
Azat Khuzhin
5871ca0836 Fix performance tests due to warnings from jemalloc about Per-CPU arena disabled
jemalloc can show the following warning:

    Number of CPUs detected is not deterministic. Per-CPU arena disabled

It will be shown if one of the following returns different number of
CPUs:
- _SC_NPROCESSORS_ONLN
- _SC_NPROCESSORS_CONF
- sched_getaffinity()

And actually for my CPU linux returns different numbers, because there
are more possible CPUs then online, from dmesg:

    smpboot: Allowing 128 CPUs, 64 hotplug CPUs

And from sysfs:

    # grep . /sys/devices/system/cpu/{possible,online,offline}
    /sys/devices/system/cpu/possible:0-127
    /sys/devices/system/cpu/online:0-63
    /sys/devices/system/cpu/offline:64-127

From ACPI:

    # acpidump -o acpi
    # acpixtract -a acpi
    # iasl -d *.dat
    # grep -e 'Processor Enabled' apic.dsl | sort | uniq -c
        64                            Processor Enabled : 0
        64                            Processor Enabled : 1

So I guess this is the same as what happened in this perf run [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/51360/5d43a64112711b339b82b1c0e8df7882546a1a3c/performance_comparison_[4_4]/report.html

P.S. personally I, just use cmdline=possible_cpus=64 to fix this for my
setup.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-25 09:37:37 +02:00
Alexander Tokmakov
f973bd7516 suppress check for covered parts in zk 2023-06-20 23:53:32 +02:00
Alexander Tokmakov
bca0d76cbf
Merge pull request #50107 from ClickHouse/rmt_better_background_tasks_scheduling
Improve scheduling of background tasks in ReplicatedMergeTree
2023-06-20 16:25:19 +03:00
Alexander Tokmakov
5dd9b10c8e fix 2023-06-19 20:14:28 +02:00
Yatsishin Ilya
b472480d48 Fix branch name 2023-06-19 10:06:56 +00:00