Robert Schulze
b3f4f3459b
Bump curl to v8.9.1
2024-09-06 12:03:53 +00:00
Robert Schulze
1b6fa8ef53
Bump curl to v8.9.0
2024-09-06 12:03:08 +00:00
Robert Schulze
66bd32bd18
Bump curl to v8.8.0
2024-09-06 12:02:29 +00:00
Robert Schulze
6f03c51368
Update
2024-09-04 09:40:45 +00:00
Robert Schulze
1c6e960719
Sort
2024-09-04 09:35:06 +00:00
Robert Schulze
e047c7c419
Update sources
2024-09-04 09:33:26 +00:00
Robert Schulze
e28066645b
Sort
2024-09-04 09:31:06 +00:00
Michael Kolupaev
ac861768bc
Final submodule commit
2024-09-04 07:53:41 +00:00
Michael Kolupaev
e955b2fc71
Merge remote-tracking branch 'origin/master' into musysroot
2024-08-31 19:48:19 +00:00
Raúl Marín
837daf0fd0
Merge remote-tracking branch 'blessed/master' into faster_debug_startup
2024-08-30 17:01:26 +02:00
Han Fei
8fbfc61c55
Merge pull request #69018 from hanfei1991/hanfei/fix-false-leak-in-fiu
...
fix false leak detect in libfiu
2024-08-30 00:31:10 +00:00
Han Fei
a842994af1
fix false leak detect in libfiu
2024-08-28 15:21:49 +02:00
Robert Schulze
9fb4c23c06
Merge pull request #68678 from rschu1ze/usearch-2.14
...
Vector similarity index: make `bf16` the default quantization
2024-08-28 08:45:02 +00:00
Raúl Marín
49ee8d4109
Don't enable JEMALLOC_DEBUG on debug builds
2024-08-27 19:29:42 +02:00
Raúl Marín
08f5ecbf60
Build boost::options always with max optimizations
2024-08-27 19:29:22 +02:00
Nikita Mikhaylov
01523cce2a
Bump replxx
2024-08-24 16:01:03 +02:00
Nikita Mikhaylov
78c175225b
Done
2024-08-24 16:01:03 +02:00
Kirill Nikiforov
40462bc716
Merge remote-tracking branch 'origin' into mongodb_refactoring
2024-08-23 22:10:06 +04:00
Robert Schulze
1dc7d37ff7
Bump usearch to v2.14.0
2024-08-23 07:32:34 +00:00
Michael Kolupaev
f6edaeaade
Merge remote-tracking branch 'origin/master' into musysroot
2024-08-22 01:49:41 +00:00
János Benjamin Antal
860bd66d7a
Merge pull request #68267 from azat/build/COMMAND_ERROR_IS_FATAL
...
Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY)
2024-08-20 11:55:20 +00:00
Robert Schulze
67344be073
Merge pull request #68523 from rschu1ze/improve_upper_lower-2
...
Improve compatibility of `upper/lowerUTF8` with Spark
2024-08-20 10:30:06 +00:00
Michael Kolupaev
11658c07b6
Merge remote-tracking branch 'origin/master' into musysroot
2024-08-19 21:52:41 +00:00
taiyang-li
db1ba8d538
add submodule contrib/icu from clickhouse
2024-08-19 07:13:57 +00:00
taiyang-li
ef624e9b22
remote icu contrib
2024-08-19 07:12:48 +00:00
Robert Schulze
f5308635d1
Revert "Improve compatibility of upper/lowerUTF8
with Spark"
2024-08-18 15:25:07 +02:00
Robert Schulze
6cf5a7f7f8
Merge pull request #65761 from bigo-sg/improve_upper_lower
...
Improve compatibility of `upper/lowerUTF8` with Spark
2024-08-18 12:14:43 +00:00
Alexey Milovidov
487c6a097e
Merge branch 'master' into revert-65361-revert-65164-ecs
2024-08-18 06:19:27 +02:00
Michael Kolupaev
52c5619a92
Merge remote-tracking branch 'origin/master' into musysroot
2024-08-17 03:28:31 +00:00
Michael Kolupaev
76960eff80
This should work
2024-08-16 18:38:03 +00:00
taiyang-li
3ee741bd5e
add submodule contrib/icu from clickhouse
2024-08-16 18:04:15 +08:00
taiyang-li
4600b270da
remote icu contrib
2024-08-16 17:58:54 +08:00
Michael Kolupaev
b3a3d1e720
another rebase
2024-08-16 05:53:17 +00:00
Michael Kolupaev
b1963738bd
Rebase
2024-08-15 21:41:40 +00:00
Michael Kolupaev
82fc6bfa9e
Merge remote-tracking branch 'origin/master' into musysroot
2024-08-15 21:39:38 +00:00
Robert Schulze
ebe9f6de99
Enable fp16, don't enable simsimd
2024-08-15 10:47:54 +00:00
Alexey Milovidov
dbbd2c7875
Merge pull request #68248 from rschu1ze/update-usearch
...
Bump usearch to v2.13.2
2024-08-15 01:24:17 +00:00
Robert Schulze
6170a8663f
Bump usearch to 2.13.2
2024-08-14 08:04:00 +00:00
Michael Kolupaev
c869b06519
Remove getpwuid() calls in Poco::PathImpl
2024-08-14 03:43:48 +00:00
Michael Kolupaev
0dc7cd7eb4
Update musl to have unwind info
2024-08-14 01:12:11 +00:00
Michael Kolupaev
f6f79e188d
Apply libunwind changes needed for musl
2024-08-14 00:23:18 +00:00
Robert Schulze
58d76fabf6
Bump usearch to 2.12.0
2024-08-13 15:53:41 +00:00
Robert Schulze
72efc8308c
Bump usearch to 2.11.7
2024-08-13 15:53:38 +00:00
Robert Schulze
92aed17e7c
Bump usearch to 2.10.5
2024-08-13 15:53:35 +00:00
Robert Schulze
bd09e948ba
Bump usearch to 2.9.2
2024-08-13 15:53:32 +00:00
Robert Schulze
fe7da4e7d1
Bump usearch to 2.8.16
2024-08-13 15:53:28 +00:00
Robert Schulze
88f2d2e67d
Bump usearch to v2.7.8
2024-08-13 15:53:21 +00:00
Robert Schulze
383d2816e6
Bump usearch to 2.6.1
2024-08-13 15:53:18 +00:00
Robert Schulze
dbe66e6092
Bump usearch to 2.5.1
2024-08-13 15:53:15 +00:00
Robert Schulze
98c18eb341
Bump usearch to 2.4.1
2024-08-13 15:53:11 +00:00
Robert Schulze
5ca85674e6
Bump usearch to 2.3.2
2024-08-13 15:53:08 +00:00
Robert Schulze
94cc37a39f
Remove robin-map submodule
...
At some point, usearch stopped to use robin-map.
2024-08-13 15:53:04 +00:00
Robert Schulze
2ffcc97af2
Merge pull request #63675 from rschu1ze/vector-search
...
Initial implementation of vector similarity index
2024-08-13 15:06:20 +00:00
vdimir
6358dac156
upd mongo-c-driver
2024-08-13 10:25:18 +00:00
Azat Khuzhin
4c043301e6
Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY)
...
This will fix with issues like this [1]:
Aug 12 09:58:44 '/usr/bin/cmake' '--build' '/build/build_docker/native' '--target' 'pre_compressor'
Aug 12 09:58:44 sccache: error: Server startup failed: cache storage failed to read: Unexpected (temporary) at stat
Aug 12 09:58:45 ninja: build stopped: subcommand failed.
Aug 12 09:58:45 -- Configuring done (77.7s)
Aug 12 09:58:47 -- Generating done (1.8s)
Aug 12 09:58:47 -- Build files have been written to: /build/build_docker
So as you can see even if ninja fails it still wrote build files, while
it should fail.
[1]: https://s3.amazonaws.com/clickhouse-test-reports/64955/0af41e32a5822d25ac3760f1ebb2313557474701/builds/report.html
[2]: 0af41e32a5/binary_darwin_aarch64/build_log.log
Note, COMMAND_ERROR_IS_FATAL is 3.19+, and the requirement for now is
3.20
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-13 10:35:54 +02:00
vdimir
b84e285917
contrib/mongo-c-driver
2024-08-12 16:46:33 +00:00
vdimir
5195bc9060
Merge branch 'master' into pr/allmazz/63279
2024-08-12 16:45:58 +00:00
Robert Schulze
218421c255
Remove Annoy indexes
...
Annoy indexes fell out of favor in the community, at least when it comes
to vector databases. Such indexes work okay-ish low dimensions but they
suffers badly from a curse of dimensionality which makes them inapt for
a high number of dimensions.
Now that Annoy is gone, issue (*) also disappears and we can drop
'no-ubsan', 'no-cpu-aarch64', and 'no-asan' from tests.
(*) spotify/annoy#456
2024-08-12 15:24:49 +00:00
Robert Schulze
d7211f9d12
Fix CMake integration of usearch and annoy
...
Registers usearch and annoy properly via configure_config.cmake and
config.h.in like all other 3rd party libs, instead of (mis)using
target_compile_definitions.
2024-08-12 15:24:18 +00:00
Robert Schulze
a39b9cf643
Un-screw usearch's build description
...
No directory 'SimSIMD-map' exists, the build only worked because SimSIMD
support in usearch was (accidentally?) disabled. This commit corrects
the build description. SimSIMD support in usearch will be enabled by a
later commit.
2024-08-12 15:24:14 +00:00
Robert Schulze
037a1006fd
Merge remote-tracking branch 'ClickHouse/master' into ci-fuzzer-enable
2024-08-12 12:28:32 +00:00
Robert Schulze
4502862033
Fix no-SSE3 build
2024-08-11 08:35:47 +00:00
Kirill Nikiforov
9fa2773586
fix build
2024-08-09 20:32:54 +03:00
Robert Schulze
eec5fe087c
Fix CMake for QATlib
2024-08-09 08:50:52 +00:00
Robert Schulze
a497a23914
Fix CMake for QPL
2024-08-09 08:44:22 +00:00
Robert Schulze
47f429a524
Proper CMake for libfiu
2024-08-09 08:04:24 +00:00
Kirill Nikiforov
954cd7e95a
fix mongo-c-driver submodule
2024-08-09 03:27:30 +03:00
Kirill Nikiforov
65c82885b9
fix submodule
2024-08-09 03:02:20 +03:00
Kirill Nikiforov
e426a9085d
fix build
2024-08-09 00:57:43 +03:00
Kirill Nikiforov
f90f2d715e
upd mongo-c-driver to my fork for fix freebsd build
2024-08-08 23:07:11 +03:00
Kirill Nikiforov
ea58b8062e
Merge remote-tracking branch 'origin' into mongodb_refactoring
2024-08-08 22:44:32 +03:00
Kirill Nikiforov
1b749b4a26
upd mongo-c-driver to my fork for fix freebsd build
2024-08-08 22:36:10 +03:00
Alexey Milovidov
2e6ecf6913
Merge pull request #66311 from azat/rdkafka-fix-data-race
...
Fix possible data-race StorageKafka with statistics_interval_ms>0
2024-08-08 18:56:22 +02:00
Robert Schulze
5a17d93bf3
Fix freebsd build
2024-08-08 07:29:20 +00:00
Robert Schulze
5c97205742
Reapply "Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing"
...
This reverts commit ff8ce505d7
.
2024-08-08 07:23:10 +00:00
Azat Khuzhin
301ac5dab7
Fix possible data-race StorageKafka with statistics_interval_ms>0
...
The problem here is that ignorelist did not work by some reason, if I
will look at the ignored functions it should not contain any TSan
interseption code, while it does:
$ lldb-13 clickhouse
(lldb) target create "clickhouse"
disas -n rd_avg_rollover
Current executable set to '/home/azat/ch/tmp/tsan-test/clickhouse' (x86_64).
(lldb) disas -n rd_avg_rollover
clickhouse`rd_kafka_stats_emit_avg:
clickhouse[0x1cbf84a7] <+39>: leaq 0x30(%r15), %r12
clickhouse[0x1cbf84ab] <+43>: movq %r12, %rdi
clickhouse[0x1cbf84ae] <+46>: callq 0x1ccdad40 ; rdk_thread_mutex_lock at tinycthread.c:111
clickhouse[0x1cbf84b3] <+51>: leaq 0x58(%r15), %rdi
clickhouse[0x1cbf84b7] <+55>: callq 0x71b5390 ; __tsan_read4
clickhouse[0x1cbf84bc] <+60>: cmpl $0x0, 0x58(%r15)
clickhouse[0x1cbf84c1] <+65>: je 0x1cbf8595 ; <+277> [inlined] rd_avg_rollover + 238 at rdavg.h
clickhouse[0x1cbf84c7] <+71>: leaq -0xc8(%rbp), %rdi
clickhouse[0x1cbf84ce] <+78>: xorl %esi, %esi
clickhouse[0x1cbf84d0] <+80>: callq 0x1ccdac80 ; rdk_thread_mutex_init at tinycthread.c:62
clickhouse[0x1cbf84d5] <+85>: leaq 0x5c(%r15), %rdi
clickhouse[0x1cbf84d9] <+89>: callq 0x71b5390 ; __tsan_read4
(lldb) disas -n rd_avg_calc
clickhouse`rd_kafka_broker_ops_io_serve:
clickhouse[0x1cbdf086] <+1990>: leaq 0x5a4(%rbx), %rdi
clickhouse[0x1cbdf08d] <+1997>: callq 0x71b5390 ; __tsan_read4
clickhouse[0x1cbdf092] <+2002>: cmpl $0x0, 0x5a4(%rbx)
clickhouse[0x1cbdf099] <+2009>: je 0x1cbdf12b ; <+2155> [inlined] rd_kafka_broker_timeout_scan + 719 at rdkafka_broker.c
I guess the reason is that they had been inlined
So now rd_avg_calc() guarded with a mutex.
Refs: https://github.com/ClickHouse/librdkafka/pull/11
Fixes: https://github.com/ClickHouse/ClickHouse/issues/60939
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-08 07:43:29 +02:00
Nikita Mikhaylov
ff8ce505d7
Revert "Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing"
2024-08-08 00:20:16 +02:00
Yakov Olkhovskiy
b246f7c17c
merge master
2024-08-07 16:25:31 +00:00
Robert Schulze
681014d99d
Merge pull request #67904 from rschu1ze/bump-rocksdb3
...
Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing
2024-08-07 14:34:48 +00:00
Robert Schulze
e07f8b4807
Merge pull request #67933 from mzhukova/dev/mzhukova/upd-qpl-1.6.0
...
Upgrade QPL to v1.6.0
2024-08-07 09:40:49 +00:00
Robert Schulze
7af334bd46
Merge pull request #67942 from rschu1ze/fix-memoverflow-in-usearch
...
Fix memory corruption in usearch
2024-08-07 08:38:14 +00:00
Robert Schulze
26b622540f
Merge pull request #64489 from ClickHouse/zup
...
Update zlib-ng from 2.0.2 to 2.1.7
2024-08-06 19:23:05 +00:00
Zhukova, Maria
36b6adbb30
qpl-cmake: Better wording on ISA-L copy and removed non-required linking
2024-08-06 12:15:23 -07:00
Robert Schulze
9594a9baff
Fix memory corruption in usearch
2024-08-06 18:43:44 +00:00
Robert Schulze
7a5b30d955
Re-add forked usearch repo
2024-08-06 18:39:18 +00:00
Robert Schulze
302bd5fdc6
Remove usearch submodule
2024-08-06 18:37:26 +00:00
Kirill Nikiforov
9fa22fe5a3
fix musl build
2024-08-06 18:59:45 +03:00
Robert Schulze
df0dac2f5b
Enable jemalloc and liburing in rocksdb
2024-08-06 11:17:41 +00:00
Robert Schulze
2a2ba4e685
Bump rocksdb to 9.4.0
2024-08-06 10:49:22 +00:00
Robert Schulze
e7110be48c
Bump rocksdb to v9.3.1
2024-08-06 10:43:21 +00:00
Robert Schulze
b3f5ddcd65
Bump rocksdb to 9.2.1
2024-08-06 10:40:54 +00:00
Robert Schulze
f0a6ae2205
Bump rocksdb to v9.1.1
2024-08-06 10:35:33 +00:00
Robert Schulze
7e87650a00
Bump rocksdb to v9.0.1
2024-08-06 10:32:12 +00:00
Robert Schulze
4a8be15ca8
Bump rocksdb to v8.11.4
2024-08-06 10:26:37 +00:00
Michael Kolupaev
8703941a0f
Apply https://github.com/ClickHouse/zlib-ng/pull/18
2024-08-05 22:36:30 +00:00
Kirill Nikiforov
a28a82d344
Merge remote-tracking branch 'origin' into mongodb_refactoring
2024-08-05 20:57:15 +03:00
Kirill Nikiforov
c834b94145
fix test and freebsd
2024-08-05 19:58:46 +03:00
Robert Schulze
d0bc728d52
Bump rocksdb to v8.9.1
2024-08-05 08:11:40 +00:00
Robert Schulze
cebdc5ecf6
Bump rocksdb to v8.0.0
2024-08-05 08:11:23 +00:00
Alexey Milovidov
ce58549592
Merge pull request #67557 from rschu1ze/icu-s390x
...
Re-enable ICU on s390/x
2024-08-04 17:51:41 +00:00
Robert Schulze
ee8079b039
Merge remote-tracking branch 'ClickHouse/master' into icu-s390x
2024-08-04 09:38:36 +00:00
Kirill Nikiforov
e5119ce61f
fix joins and rename ENABLE_MONGODB -> USE_MONGODB
2024-08-04 00:51:27 +03:00
Azat Khuzhin
9d0e066cda
Bump NuRaft (to properly catch thread exceptions)
...
Refs: https://github.com/ClickHouse/NuRaft/pull/75
Refs: https://github.com/eBay/NuRaft/pull/525
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-08-03 23:41:50 +02:00
Kirill Nikiforov
49befa714f
Merge remote-tracking branch 'origin' into mongodb_refactoring
2024-08-01 22:38:28 +03:00
Nikita Taranov
453ee52f86
Merge pull request #67235 from ClickHouse/fix_oss_fuzz_build
...
Fix oss-fuzz build
2024-08-01 10:50:12 +00:00
Robert Schulze
dde274f6fa
Re-enable ICU on s390/x
2024-07-31 18:08:45 +00:00
Kirill Nikiforov
cb9c1afdf8
fix
2024-07-31 18:42:31 +03:00
vdimir
90d2d36209
Merge branch 'master' into pr/allmazz/63279
2024-07-31 12:09:46 +00:00
vdimir
175f0696d5
fix
2024-07-31 09:36:56 +00:00
Robert Schulze
4b40e948c7
Merge pull request #66475 from rschu1ze/bump-rocksdb
...
Bump RocksDB from v6.29.5 to v7.10.2
2024-07-31 09:14:42 +00:00
vdimir
beeacc9279
update contrib mongo driver
2024-07-30 11:59:03 +00:00
vdimir
7eddb93935
Merge branch 'master' into pr/allmazz/63279
2024-07-30 10:54:45 +00:00
Robert Schulze
72d6467fd2
Bump Azure to 1.13
2024-07-30 10:43:21 +00:00
Antonio Andelic
2ea4bfe04d
Merge pull request #67098 from ClickHouse/add-numactl
...
Try calculating available memory if ClickHouse is bound to subset of NUMA nodes
2024-07-30 08:30:58 +00:00
Robert Schulze
07507e0cec
Merge remote-tracking branch 'ClickHouse/master' into bump-rocksdb
2024-07-29 13:41:55 +00:00
Robert Schulze
294fa1dea6
Merge remote-tracking branch 'ClickHouse/master' into bump-icu
2024-07-29 10:32:37 +00:00
Kirill Nikiforov
c23e3d8663
Merge branch 'master' into mongodb_refactoring
2024-07-27 15:33:46 +03:00
Kirill Nikiforov
610ac0adf4
WHERE over QueryTree, JSON fix, code clean-up
2024-07-27 15:20:24 +03:00
Nikita Taranov
109bd52296
impl
2024-07-26 23:05:56 +01:00
Antonio Andelic
2519f9ed42
Only support archs
2024-07-26 12:08:16 +02:00
Antonio Andelic
287cce7d21
Fixes
2024-07-26 09:20:15 +02:00
Antonio Andelic
6557387148
Try calcualting memory with numactl if membind used
2024-07-25 11:49:02 +02:00
Michael Kolupaev
1b2fd51e09
Merge pull request #66977 from ClickHouse/uwo
...
Apply libunwind fix
2024-07-25 03:40:19 +00:00
Michael Kolupaev
36e59a1b70
Final commit hash
2024-07-25 01:58:27 +00:00
Alexey Milovidov
1914b37058
Merge pull request #65521 from JackyWoo/add_statistics_cmsketch
...
Add count-min sketches as statistics type
2024-07-24 00:46:23 +00:00
Michael Kolupaev
1cbbbd1077
Apply libunwind fix
2024-07-23 17:35:12 +00:00
Michael Kolupaev
51ebbff79e
Merge remote-tracking branch 'origin/master' into zup
2024-07-22 20:52:54 +00:00
Antonio Andelic
1be54641c1
Revert libunwind patch
2024-07-22 11:03:19 +02:00
Robert Schulze
2a68867a20
Merge remote-tracking branch 'ClickHouse/master' into bump-icu
2024-07-22 08:19:07 +00:00
Zhukova, Maria
1347bc3218
update qpl-cmake to reflect changes in QPL 1.5.0-1.6.0
2024-07-19 14:20:19 -07:00
Zhukova, Maria
277dbfa057
update QPL to 1.6.0 + missing header fix
2024-07-19 14:20:18 -07:00
Robert Schulze
25a22d6201
Merge remote-tracking branch 'ClickHouse/master' into bump-icu
2024-07-19 12:43:11 +00:00
Yong Wang
3ef2cbdec5
openssl-dynamic-build-ppc64le : fix openssl dynamic build for ppc64le
2024-07-18 11:21:52 -07:00
Alexey Milovidov
ec87bfc956
Merge branch 'update-tidy-for-clang-19' into clickhouse-fix-msan-report-in-epoll
2024-07-17 05:49:49 +02:00
Yakov Olkhovskiy
f07a395bf1
Merge branch 'master' into ci-fuzzer-enable
2024-07-17 03:43:57 +00:00
Alexey Milovidov
4d88abfcfa
Merge branch 'master' into uwu
2024-07-16 06:04:58 +02:00
JackyWoo
245359e536
Merge branch 'master' into add_statistics_cmsketch
2024-07-16 09:45:31 +08:00
Yakov Olkhovskiy
7de367d692
Merge branch 'master' into ci-fuzzer-enable
2024-07-15 20:58:42 +00:00
Alexey Milovidov
6d617e4c4d
Merge branch 'master' of github.com:ClickHouse/ClickHouse into clickhouse-fix-msan-report-in-epoll
2024-07-15 18:30:30 +02:00
Robert Schulze
2083c65005
Merge remote-tracking branch 'ClickHouse/master' into bump-icu
2024-07-15 15:31:07 +00:00
Robert Schulze
e7becedb03
Merge remote-tracking branch 'ClickHouse/master' into bump-rocksdb
2024-07-15 06:54:16 +00:00
Robert Schulze
2132ce52e0
Bump ICU to 75
2024-07-15 06:49:02 +00:00
Antonio Andelic
7d62a19f4c
Merge pull request #66439 from azat/jemalloc-clock-assertion
...
[RFC] Fix jemalloc assertion due to non-monotonic CLOCK_MONOTONIC_COARSE
2024-07-15 06:45:29 +00:00
Alexey Milovidov
41327260ba
Fix MSan report in GRPC
2024-07-15 03:47:35 +02:00
Alexey Milovidov
cae3f63545
Merge branch 'master' into uwu
2024-07-15 01:22:38 +02:00
Robert Schulze
5b6956ea23
Bump rocksdb to v7.10.2
2024-07-14 12:38:28 +00:00
Robert Schulze
b5cb264b01
Bump ICU to 71
2024-07-14 12:17:25 +00:00
Robert Schulze
ad86e3060a
OpenSSL: Follow-up to #66064
...
More commits were added to the upstream fix after #66064 has been merged
in ClickHouse. This PR adds these commits to keep things in-sync.
2024-07-14 11:48:13 +00:00
Azat Khuzhin
669ce7cd40
Enable jemalloc heap profiler by default for debug builds as well
...
Since the issue with jemalloc assertion is clear, let's revert that
workaround
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-14 08:21:13 +02:00
Azat Khuzhin
22611781b0
Fix jemalloc assertion due to non-monotonic CLOCK_MONOTONIC_COARSE
...
Recently one tricky assertion of jemalloc had been discovered [1]:
Failed assertion: "nstime_compare(&decay->epoch, new_time) <= 0"
[1]: https://github.com/ClickHouse/ClickHouse/issues/66193
And as it turns out it is really possible for CLOCK_MONOTONIC_COARSE to
go backwards, in a nutshell it can be done with ADJ_FREQUENCY, you can
find example here [2]. And I can't trigger this issue for non-coarse
clocks.
[2]: https://gist.github.com/azat/7ea7f50ed75591b1af2d675a240ea94c?permalink_comment_id=5119222#gistcomment-5119222
But, jemalloc do not call clock_gettime() that frequently (I've verified
it), so it can use non-coarse version - CLOCK_MONOTONIC
I've also measured the latency of CLOCK_MONOTONIC and
CLOCK_MONOTONIC_COARSE, and it is 20ns vs 4ns per call [3], so make this
change affect performance you need really frequently calls of
clock_gettime.
[3]: https://gist.github.com/azat/622fa1f9a5d8e7d546ee9d294501961d?permalink_comment_id=5119245#gistcomment-5119245
Interesting, that this bug started to appears only after jemalloc heap
profiler had been enabled by default [4], no clue why (I would believe
more in a more frequent calls to clock_adjtime(ADJ_FREQUENCY), but I
can't verify this)
[4]: https://github.com/ClickHouse/ClickHouse/pull/65702
To be continued...
Fixes: https://github.com/ClickHouse/ClickHouse/issues/66193
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-14 08:21:13 +02:00