Commit Graph

23376 Commits

Author SHA1 Message Date
Vladimir Chebotarev
b3427af0c1 Fixed typos in a test. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
108e2b33eb Fixed a bug with erasing columns with same name. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
0da7234d99 Added few FIXMEs to not forget. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
b3e261800d Fixes of tests for extended TTL syntax. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
ce851fc782 Fixed MergeTreeData::hasTableTTL() method according to extended TTLs. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
e163ebb7f0 Fixed more typos in test_ttl_move test. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
cc70f717ed Fixed typos in test_ttl_move test. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
617bf4214f Added first version of tests for extended TTL expressions (still need refactoring). 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
cb777f6c50 Removed redundant template from updateTTL() method. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
62016feab0 Renamed TTLDestinationType to PartDestinationType. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
cc0c21604f Fixed Clang build one more time. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
ce066d3bb0 Style fixes. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
88c7220256 Fixed Clang build. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
07c4fa3cc0 Correct merge of background move pool. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
3e3e9ac56f Moved settings for BackgroundProcessingPool to configuration. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
e519c04bbe Minor fix of JSON handling in MergeTreeDataPartTTLInfo. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
342ea5c30a Removed TODO comments. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
773bf7b35c Removed 'DELETE' keyword from default TTL syntax description. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
58e824b6a1 Refactored, added move enforcement on merges, fixed a bug with wrong disk selection in ReplicatedMergeTree. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
dfe0edc03f Style fix. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
76c4ac9f60 Fixed ttl move logic in background move task and added ttl enforcement on inserts. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
4cd75f926b Fixed 00933 ttl tests. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
575de5ada6 Attempt to add background moves by TTL expressions. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
893e0de37a Minor fix. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
33ded274a3 First attempt to store min/max for move ttl expressions. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
5a12986159 Updated ttl test according to new TTL syntax. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
3e984609fb Fixed ClickHouse after changing syntax. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
7a37c4f6a9 Parser for extended TTL expressions. 2019-12-11 13:24:20 +03:00
Vasily Nemkov
c781908e6d Post-PR fixes
* More precise overflow check in readIntTextImpl
* writeDateTimeText now always writes sub-second part for DateTime64
* comment for validateFunctionArgumentTypes
* DateTime64-related fixes for FunctionConvertFromString
* other minoe fixes: comments, removed commented out code, variable
  renamings, etc.
2019-12-11 12:20:05 +03:00
Vladimir Chebotarev
1ca9cefa1d
Fixed typo. 2019-12-11 11:58:53 +03:00
Vladimir Chebotarev
f5d162c5ed
Fixed test_multiple_disks::test_kill_while_insert a little. 2019-12-11 07:59:37 +03:00
Vasily Nemkov
f56b2b64f2 Post-review refactoring and tests for DateTime64 and Decimal.
* put functions in DecimalFunctions into DecimalUtils namespace
* fixed possible buffer overflow in parseDateTimeBestEffortImpl
* fixed readDateTimeTextImpl not to require fractional part separator
  (if fractional part is missing)
* Tests for code from DecimalFunctions.h
* Fixed serializing DateTime64 to string with writeDateTimeText(), fixed tests
2019-12-11 06:58:49 +03:00
Alexey Milovidov
4f9cd8a3c8 Update contributors 2019-12-11 06:13:33 +03:00
alexey-milovidov
3540dd5c53
Update ClusterCopier.cpp 2019-12-11 04:53:29 +03:00
Zhichang Yu
ff1b8d46e2 fixed part mutation, added test_backup_restore integration test case 2019-12-11 09:31:37 +08:00
alexey-milovidov
e73e19dc97
Merge pull request #8111 from azat/dictionary-reload-test-hotfix
Fix async nature of reload in 01036_no_superfluous_dict_reload_on_create_database*
2019-12-11 04:20:17 +03:00
alexey-milovidov
aecd5a5493
Merge pull request #8123 from ClickHouse/aku/field-prepare
Prepare for stricter type checking in Field.
2019-12-11 02:21:34 +03:00
alexey-milovidov
309653f60d
Merge pull request #7182 from ClickHouse/aku/zlib-msan
Update zlib-ng to fix MemorySanitizer problems.
2019-12-11 02:15:16 +03:00
alexey-milovidov
85d668ebf4
Update S3Common.cpp 2019-12-11 02:03:45 +03:00
Pavel Kovalenko
c4b3cce847 AWS SDK integration - move s3 storage syntax tests to integration. 2019-12-10 19:11:13 +03:00
alesapin
67f1ff1c8b
Merge pull request #8104 from excitoon-favorites/test_move_after_merge
FIxed behavior with ALTER MOVE ran immediately after merge finish moves superpart of specified
2019-12-10 17:15:08 +03:00
Alexander Kuzmenkov
50a8a7197f Prepare for stricter type checking in Field. 2019-12-10 16:40:45 +03:00
Alexander Kuzmenkov
3df94283b3 Remove a workaround for zlib-ng MemorySanitizer problems. 2019-12-10 13:15:18 +03:00
alesapin
397a3fc2e7
Merge pull request #8098 from ClickHouse/fix_dictionary_properties
Fix dictionary properties
2019-12-10 12:55:29 +03:00
Vladimir Chebotarev
269a0246aa Added explicit check for existence of part and pair of log messages. 2019-12-10 12:47:23 +03:00
Vladimir Chebotarev
ed719f38b2 Added test_multiple_disks::test_move_after_merge. 2019-12-10 12:47:23 +03:00
Azat Khuzhin
65572a23fe Fix async nature of reload in 01036_no_superfluous_dict_reload_on_create_database*
Due to the async nature of SYSTEM RELOAD DICTIONARY/DICTIONARIES the
test can fail, if the reload will happen after the dictGet*():

    .862801 [ 36 ] {61df55ee-4a17-4bf3-8cfb-9478490393c3} <Debug> executeQuery: (from [::1]:37422) SYSTEM RELOAD DICTIONARY `foo 1234.dict`
    .863681 [ 36 ] {cd55d9f9-d176-4b19-bc97-d25575da2d15} <Debug> executeQuery: (from [::1]:37422) SELECT query_count FROM system.dictionaries WHERE (database = 'foo 1234') AND ...
    .863678 [ 54 ] {} <Debug> executeQuery: (internal) SELECT `key`, `val` FROM `foo 1234`.`dict_data`;

This is just a hotfix, long-term solution will be to make SYSTEM RELOAD
DICTIONARY syncronous (by adding another command or making already
existing).

Refs: #7916
2019-12-10 08:31:51 +03:00
Ding Xiang Fei
0f22f90ee5
refine zxid definition: it has two warping uint32 counters 2019-12-10 09:44:06 +08:00
Vladimir Chebotarev
ea44510b44 Minor fix of test. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
6afd8d7805 Added test_multiple_disk::test_kill_while_insert, reworked log message and fixed logic of treating stale copies. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
a2f238d8da Added more logging and switched to detaching stale part instead of removing. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
9cf7ef03af Fixed handling of MergeTreeData::DataPartPtr's in MergeTreeData::swapActivePart(). 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
374e0f7bb5 Finally fixed tests. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
c283776e84 Really fixed tests. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
89659a9129 Fixed a typo. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
fe3e89fb38 Fixed tests. 2019-12-09 23:29:44 +03:00
filimonov
f545da40e6 style 2019-12-09 23:29:44 +03:00
filimonov
0ab67c7b1f Log when part is removed after move 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
efa73608b8 Separated constant path to DeleteOnDestroy marker. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
13c5c621c1 Attempt to ignore redundant copies of parts after move and restart. 2019-12-09 23:29:44 +03:00
alexey-milovidov
cce78ef018
Merge pull request #8036 from yurriy/mysql
Compatibility with MySQL clients which don't support sha2_password auth plugin
2019-12-09 23:11:31 +03:00
Alexey Milovidov
285139585c Updated test 2019-12-09 23:08:19 +03:00
Alexey Milovidov
da72203ceb Added a comment 2019-12-09 22:53:40 +03:00
Alexey Milovidov
2fe7472a63 Added function "greatCircleAngle"; changed earth radius 2019-12-09 22:35:25 +03:00
Alexey Milovidov
67fd108848 Added a test for "greatCircleAngle" 2019-12-09 22:34:00 +03:00
Alexey Milovidov
1e3b9af66f Added clarifications 2019-12-09 20:25:16 +03:00
Alexey Milovidov
2db25df706 Merge branch 'master' into geodist-less-wrong 2019-12-09 18:42:37 +03:00
Nikolai Kochetov
fd62c09a8b Update FunctionCapture and FunctionExpression. 2019-12-09 17:36:47 +03:00
Alexander Burmak
5a93441445 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-12-09 17:18:47 +03:00
alesapin
85aac386aa Missed commit 2019-12-09 17:06:28 +03:00
alesapin
642ce2d751 Fix escaping and add string expressions support 2019-12-09 17:05:58 +03:00
Nikolai Kochetov
18bfa684a2 Rename IFunction.h to IFunctionImpl.h in functions implementations. 2019-12-09 16:12:54 +03:00
Pavel Kovalenko
ba59991912 AWS SDK integration - added new lines at the end of files. 2019-12-09 15:36:06 +03:00
Pavel Kovalenko
971c48e1cf AWS SDK integration - fixed test with remote host filter. 2019-12-09 15:05:16 +03:00
Pavel Kovalenko
94e9638006 AWS SDK integration added url checking. 2019-12-09 13:58:57 +03:00
alexey-milovidov
9106b2854a
Merge pull request #8084 from azat/read-temporary-tables-on-failure
Read temporary tables on failure to avoid interpreting that bits as query
2019-12-09 13:49:09 +03:00
Alexander Burmak
f27d462986 Minor amendments 2019-12-09 08:47:12 +03:00
alexey-milovidov
d051a03794
Merge pull request #8042 from excitoon-favorites/gmtime
Removed `localtime` from `HTTPDictionarySource::getUpdateFieldAndDate…
2019-12-09 04:57:18 +03:00
alexey-milovidov
79215bd029
Merge pull request #8025 from excitoon/patch-2
Added `-D LINKER_NAME=lld` to instruction to sanitizers.
2019-12-09 04:56:17 +03:00
alexey-milovidov
4aa6b61859
Update sanitizers.md 2019-12-09 04:55:58 +03:00
alexey-milovidov
624be3679b
Merge branch 'master' into mysql 2019-12-09 04:53:30 +03:00
alexey-milovidov
0d278b414c
Merge pull request #8046 from amosbird/interpose
Interpose malloc symbols entirely.
2019-12-09 04:33:49 +03:00
alexey-milovidov
abb823af7f
Merge pull request #8079 from yurriy/mysql-types-test
Fixed Float64 conversion in MySQL protocol
2019-12-09 04:32:22 +03:00
alexey-milovidov
a3c6402e8b
Added perf test for collations (#8087) 2019-12-09 04:23:58 +03:00
Alexey Milovidov
b5e05d761b Whitespace 2019-12-09 04:15:42 +03:00
Alexey Milovidov
9399b39070 Fixes 2019-12-09 04:09:03 +03:00
Alexey Milovidov
41a6eedadc Added comment 2019-12-09 04:02:09 +03:00
Alexey Milovidov
c6cc5770cc Merge branch 'geodist-less-wrong' of github.com:yandex/ClickHouse into geodist-less-wrong 2019-12-09 03:20:45 +03:00
Alexey Milovidov
2afdb4f6a8 Added a test 2019-12-09 03:20:34 +03:00
Alexey Milovidov
fb908eae0a Fixed comments 2019-12-09 03:02:50 +03:00
Alexey Milovidov
b977aa3cdf Fixed error 2019-12-09 02:59:25 +03:00
Alexey Milovidov
c738d92411 Maybe better memory layout 2019-12-09 02:55:56 +03:00
Alexey Milovidov
171bb14614 Addition to prev. revision 2019-12-09 02:41:34 +03:00
Alexey Milovidov
1835087291 Added function geoDistance and returned the old behaviour of greatCircleDistance 2019-12-09 02:40:53 +03:00
Alexey Milovidov
109542c445 Small improvements 2019-12-09 02:09:05 +03:00
Alexey Milovidov
09df6a0c00 Small improvements 2019-12-09 02:02:44 +03:00
Alexey Milovidov
f7320e50b7 Renamed variables 2019-12-09 02:00:34 +03:00
Alexey Milovidov
a04ed4883d Added comments 2019-12-09 01:44:17 +03:00
Alexey Milovidov
4f3e7427e8 Fixed error in perf test 2019-12-09 01:41:45 +03:00
Alexey Milovidov
19f05c4594 Removed too strict type check 2019-12-09 01:09:32 +03:00
Alexey Milovidov
3d71cb0596 Make the code of greatCircleDistance less wrong 2019-12-09 00:59:41 +03:00
Alexey Milovidov
eca601239f Removed a test with typo in its name 2019-12-09 00:37:04 +03:00
Nikolai Kochetov
a73eb4292b Functions refactor part 1. 2019-12-09 00:06:37 +03:00
alexey-milovidov
7e8b177a3b
Merge pull request #8077 from nvartolomei/nv/system-query-parser
Fix SYSTEM query parser suggestions
2019-12-09 00:04:14 +03:00
alexey-milovidov
cf194edfaf
Merge pull request #8016 from filimonov/kafka_fixes
Kafka fixes
2019-12-09 00:03:36 +03:00
alexey-milovidov
ee7d675f86
Update KafkaBlockInputStream.cpp 2019-12-09 00:03:09 +03:00
alexey-milovidov
a7f5ac7099
Merge pull request #8081 from errx/master
Added new function JSONExtractArrayRaw
2019-12-08 23:52:56 +03:00
alexey-milovidov
21a7a53491
Update FunctionsJSON.h 2019-12-08 23:48:34 +03:00
alexey-milovidov
16754bfff5
Merge pull request #8043 from excitoon-favorites/systemmergespaths
Added information about paths to `system.merges`.
2019-12-08 23:30:39 +03:00
Azat Khuzhin
7b4fcc5fc5 Read temporary tables on failure to avoid interpreting that bits as query
Before this patch if the query failes (due to "Too many simultaneous
queries" for example) it will not read external tables info, and the
next request will interpret them as the query beginning at got:

  DB::Exception: Unknown packet 11861 from client

v2: reordering in the executeQuery() is not enough, since the query
    can fail in other places, before, i.e. quotas
v3: I cannot make non-intergration test (since there is no ability to
    receive "Unknown packet" via client, only from the server log),
    hence added one
2019-12-08 23:26:43 +03:00
Alexander Burmak
edd11abad1 Addressed code review comments 2019-12-08 19:47:51 +03:00
Oleg Matrokhin
8ea7cab7e4 simplify expression 2019-12-08 18:07:06 +03:00
Oleg Matrokhin
2cab90b9f4 fmt 2019-12-08 17:36:31 +03:00
Oleg Matrokhin
36303a82f7 add tests 2019-12-08 17:24:37 +03:00
Alexander Burmak
8104395dd2 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-12-08 11:45:18 +03:00
alesapin
af7b8f9274
Merge pull request #8051 from ClickHouse/fix_collations_behaviour
Fix several bugs with collations.
2019-12-08 11:10:23 +03:00
Yuriy
e0796261aa mysql protocol: fixed Float32 conversion and added types test 2019-12-08 08:40:08 +03:00
Oleg Matrokhin
10cf9e5b9f implement new function 2019-12-08 03:18:24 +03:00
Nicolae Vartolomei
f5e764eba1 Fix SYSTEM query parser suggestions 2019-12-07 23:05:57 +00:00
Vladimir Chebotarev
984e81876a Fixed Clang build. 2019-12-07 22:30:37 +03:00
Vladimir Chebotarev
bb0de2509a Fixed test_system_merges/test.py::test_mutation_simple[replicated] test. 2019-12-07 22:23:25 +03:00
Vladimir Chebotarev
c60493fe72 Fixed test_system_merges/test.py::test_merge_simple[replicated] test. 2019-12-07 22:02:01 +03:00
alesapin
2fffe2802f Review fixes 2019-12-07 16:13:14 +03:00
Vladimir Chebotarev
ed2ec2d15d Fixed test_system_merges to correctly check replicated node set. 2019-12-07 13:35:13 +03:00
Vladimir Chebotarev
1513e5a854 Added replicated tests for system.merges. 2019-12-07 13:15:01 +03:00
Vladimir Chebotarev
1fbfb50fba Fixed updating result_part_path while merging and mutating. 2019-12-07 12:54:05 +03:00
Vladimir Chebotarev
b64b2cff09 Added simple non-replicated tests for system.merges. 2019-12-07 11:40:49 +03:00
alesapin
b9591a8bb4 Fix variable scope 2019-12-07 11:17:01 +03:00
Vladimir Chebotarev
05a05b5fb6 Fixed result_part_part of a mutation. 2019-12-07 11:10:08 +03:00
alesapin
5b828a6cbf Better test 2019-12-07 01:25:14 +03:00
alesapin
3881a85c39 Review fixes 2019-12-07 01:22:12 +03:00
alexey-milovidov
56b2ec8b4a
Merge pull request #7693 from millb/hashes_from_values_of_UUID_type
Created cityHash for decimal and UUID types.
2019-12-07 00:30:28 +03:00
alexey-milovidov
113ddb2588
Update FunctionsHashing.h 2019-12-06 22:21:22 +03:00
alexey-milovidov
1c1351d644
Update FunctionsHashing.h 2019-12-06 22:19:19 +03:00
alexey-milovidov
e0aa12717b
Update FunctionsHashing.h 2019-12-06 22:18:47 +03:00
alexey-milovidov
bef3a0d2d2
Merge pull request #8071 from azat/Connection-sendCancel-SIGSEGV
Avoid null dereference after "Unknown packet X from server"
2019-12-06 22:15:18 +03:00
alexey-milovidov
36203721de
Update Connection.cpp 2019-12-06 22:14:27 +03:00
millb
6799feaba6 Merge branch 'hashes_from_values_of_UUID_type' of github.com:millb/ClickHouse into hashes_from_values_of_UUID_type 2019-12-06 22:08:40 +03:00
millb
b13cd85613 Applied the required changes 2019-12-06 22:08:21 +03:00
Azat Khuzhin
e4209d6a3f Avoid null dereference after "Unknown packet X from server"
stracktrace:
  ...
  2  DB::WriteBuffer::nextIfAtEnd (this=0x0) at ../dbms/src/IO/WriteBuffer.h:66
  3  DB::writeVarUInt (ostr=..., x=3) at ../dbms/src/IO/VarInt.h:191
  4  DB::Connection::sendCancel (this=0x7f0b7f5e5610) at ../dbms/src/Client/Connection.cpp:444
  5  0x0000561738d0b565 in DB::MultiplexedConnections::sendCancel (this=0x7f0c9b0173e0) at ../dbms/src/Client/MultiplexedConnections.cpp:174
  6  0x00005617387d22df in DB::RemoteBlockInputStream::tryCancel (this=0x7f0cc45f9810, reason=<optimized out>) at /usr/include/c++/9/bits/unique_ptr.h:352
  7  0x00005617387d2a37 in DB::RemoteBlockInputStream::cancel (this=<optimized out>, kill=false) at ../dbms/src/DataStreams/RemoteBlockInputStream.cpp:121
  8  0x000056173891f10c in DB::ParallelInputsProcessor<DB::UnionBlockInputStream::Handler>::cancel (this=0x7f0c370ec168, kill=kill@entry=false)
  9  0x000056173892cfce in DB::UnionBlockInputStream::cancel (kill=false, this=<optimized out>) at ../dbms/src/DataStreams/UnionBlockInputStream.h:99
  10 DB::UnionBlockInputStream::Handler::onException (this=0x7f0c370ec160, exception=...) at ../dbms/src/DataStreams/UnionBlockInputStream.h:240
  11 DB::ParallelInputsProcessor<DB::UnionBlockInputStream::Handler>::thread (this=0x7f0c370ec168, thread_group=..., thread_num=<optimized out>)
      at ../dbms/src/DataStreams/ParallelInputsProcessor.h:217

And in onException frame there is:
  (gdb) p ((DB::Exception *)exception._M_exception_object)._msg._M_dataplus._M_p
  $6 = (...) 0x7f0c9b1e7a40 "Unknown packet 9 from server HOSTNAME:PORT"

And on "Unknown packet" there is disconnect() before, see default in
switch statement at Connection::receivePacket().
2019-12-06 21:55:17 +03:00
Mikhail Korotov
688ca7bfde performance test added 2019-12-06 21:10:03 +03:00
Mikhail Korotov
f63fe65e53 Simple tests added 2019-12-06 20:23:41 +03:00
Mikhail Korotov
3528555174
Update FunctionsHashing.h 2019-12-06 19:33:37 +03:00
Amos Bird
971770a040
Interpose malloc symbols entirely. 2019-12-07 00:32:00 +08:00
Mikhail Korotov
5a1ad17736
Update FunctionsHashing.h 2019-12-06 19:30:46 +03:00
millb
c801845185 Applied the required changes 2019-12-06 19:27:45 +03:00
millb
e3426e39e8 Fixed bugs 2019-12-06 18:43:50 +03:00
Pavel Kovalenko
6b8d599956 AWS SDK integration formatting issues. 2019-12-06 18:42:55 +03:00
Vxider
47f8d9713a build fix 2019-12-06 23:35:23 +08:00
millb
41008c9cca Merge branch 'master' into hashes_from_values_of_UUID_type 2019-12-06 18:22:06 +03:00