Commit Graph

25732 Commits

Author SHA1 Message Date
Nikolai Kochetov
350881a3da Copy block info in ConvertingBlockInputStream. 2020-02-21 19:57:22 +03:00
CurtizJ
14daa51cec add comments 2020-02-21 19:53:33 +03:00
Alexander Tokmakov
0201b485a7 enable secure ports for tests 2020-02-21 19:07:18 +03:00
Alexey Milovidov
396e9c57d0 Fixed OptimizedRegularExpression in case of empty regexp 2020-02-21 18:55:36 +03:00
Alexander Tokmakov
db669cef63 Merge branch 'master' into fix_expressions_in_metadata 2020-02-21 18:22:52 +03:00
alexey-milovidov
ee710dd1f7
Merge pull request #9235 from zhang2014/fix/ISSUES-9230
ISSUES-9230 pushed SelectQueryOption into join expression
2020-02-21 17:55:57 +03:00
alexey-milovidov
1e8389eceb
Merge pull request #8929 from ClickHouse/more-processors-for-storages
More processors for storage::read
2020-02-21 17:39:12 +03:00
alexey-milovidov
abe8315861
Merge pull request #9258 from Jokser/disk-s3-read-write-buffers-refactoring
Disk->writeFile() returns WriteBufferFromFileBase.
2020-02-21 17:28:49 +03:00
alexey-milovidov
bc910d3489
Trigger CI 2020-02-21 17:05:57 +03:00
Alexander Tokmakov
e117e5838e fixes 2020-02-21 16:44:44 +03:00
chertus
759d137162 add negative test for partial_merge_join variants 2020-02-21 16:16:59 +03:00
alesapin
2f6e22b4fd Fix failed integration tests 2020-02-21 11:53:29 +03:00
Nikolai Kochetov
30d41b34ba Merged with master 2020-02-21 11:47:56 +03:00
Vitaly Baranov
cf25d225c6 Add tests for roles. 2020-02-21 06:03:09 +03:00
Vitaly Baranov
e017bacc48 Implement SQL queries for creating and controlling roles. 2020-02-21 06:03:09 +03:00
Vitaly Baranov
6671ca67eb Add access type ROLE_ADMIN. 2020-02-21 06:03:09 +03:00
Vitaly Baranov
ae18d443c8 Introduce roles. 2020-02-21 06:03:03 +03:00
Vitaly Baranov
fc8aa5efe7 Separate access-controlling access types. 2020-02-21 03:27:29 +03:00
Vitaly Baranov
543587fc46 Remove ATTACH and DETACH access types, check CREATE and DROP access types instead of them. 2020-02-21 03:27:29 +03:00
Vitaly Baranov
4f85c148b5 Move event handling away from Context. 2020-02-21 03:27:23 +03:00
alexey-milovidov
0f72781b1e
Trigger CI 2020-02-21 02:02:52 +03:00
alexey-milovidov
d1e26f5b35
Merge pull request #9163 from ClickHouse/match-zero-byte-fix
Fixed `match` and `extract` when haystack has zero bytes.
2020-02-21 02:01:50 +03:00
alexey-milovidov
219f94ca97
Merge pull request #9082 from 4ertus2/joins
Switch JOIN algo on the fly
2020-02-21 02:01:23 +03:00
Vitaly Baranov
6cac4a919b Improve behaviour of row policies, now it applies for a table always when defined for that table (even for another user). 2020-02-21 00:57:42 +03:00
Vitaly Baranov
5849dd2236 Slightly better solution for checking row policy for distributed tables,
now it checks both current user's and initial user's filters.
2020-02-21 00:57:42 +03:00
Vitaly Baranov
244c9d5325 Add class GenericRoleSet to represent a set of IDs of users and roles. 2020-02-21 00:57:42 +03:00
Vitaly Baranov
ed2061db8a Better pointers: std::shared_ptr<const QuotaContext> instead of std::shared_ptr<QuotaContext>, boost::atomic_shared_ptr instead of std::atomic_load/store. 2020-02-21 00:57:42 +03:00
Vitaly Baranov
9edea08b6d Improve parsers of access managing SQL. 2020-02-21 00:57:42 +03:00
Alexander Tokmakov
e1f5a620b5 more complex test and some fixes 2020-02-20 23:24:04 +03:00
Alexey Milovidov
2c8a6a2885 Fixed bad code 2020-02-20 22:38:18 +03:00
chertus
aeefb78157 add comments to JoinSwitcher 2020-02-20 22:13:12 +03:00
Alexey Milovidov
d87e25aeab Merge branch 'master' of github.com:yandex/ClickHouse into match-zero-byte-fix 2020-02-20 21:52:50 +03:00
alexey-milovidov
d4381d7976
Merge pull request #9217 from ClickHouse/fix_mutations_finalization_one_more_time
Fix remove parts from mutations
2020-02-20 21:47:27 +03:00
alexey-milovidov
4433947670
Merge pull request #9227 from ClickHouse/simplier_alter_prepare
Simplier alter prepare
2020-02-20 21:45:27 +03:00
alexey-milovidov
5c097f842f
Merge pull request #9247 from ClickHouse/aku/logical-error-message
Log error message before aborting on LOGICAL_ERROR.
2020-02-20 21:45:01 +03:00
alexey-milovidov
f4124d3522
Merge pull request #9251 from 4ertus2/ast
Fix bug with comma JOIN and IN
2020-02-20 21:41:08 +03:00
alexey-milovidov
81f52614fd
Merge pull request #9255 from abyss7/log-alias
Don't use refs on vanishing objects
2020-02-20 21:16:32 +03:00
alexey-milovidov
79d194119b
Merge pull request #9254 from ClickHouse/fix-ndebuf-in-pipeline-executor
Fix NDEBUG in PipelineExecutor.
2020-02-20 21:16:11 +03:00
chertus
f683437a8c remove dangerous optimisation 2020-02-20 20:19:16 +03:00
Pavel Kovalenko
e593003be7 Formatting issues. 2020-02-20 19:48:52 +03:00
Pavel Kovalenko
e5b81aefe3 WriteBufferFromFileBase interface refactoring.
Disk->writeFile() returns WriteBufferFromFileBase.
DiskMemory read/write buffers refactoring.
2020-02-20 19:39:32 +03:00
millb
cf53160221 fixed bug 2020-02-20 19:21:28 +03:00
alexey-milovidov
a1193cbbf8
Merge pull request #9128 from Jokser/storage-stripe-log-s3
Storage Stripe Log S3 support.
2020-02-20 19:01:36 +03:00
Ivan Lezhankin
d211b1a482 Don't use refs on vanishing objects 2020-02-20 18:40:23 +03:00
Nikolai Kochetov
9191e5f17f Fix NDEBUG in PipelineExecutor. 2020-02-20 18:26:20 +03:00
Nikolai Kochetov
b4cda92e64 Added test from #9151. 2020-02-20 17:57:50 +03:00
Nikolai Kochetov
cca4d4e296 More comments and remove spaces. 2020-02-20 17:40:58 +03:00
Alexander Tokmakov
c492ee93d9 fold constant expressions in storage engine arguments 2020-02-20 17:13:43 +03:00
chertus
9748f8dcf6 fix bug with comma join and in 2020-02-20 16:33:14 +03:00
alexey-milovidov
5d4a85488e
Merge pull request #9231 from abyss7/log-alias
Get marks from first non-alias column in Log storage
2020-02-20 16:20:21 +03:00
alesapin
737a650824 Fix one more test 2020-02-20 16:02:58 +03:00
Ivan Lezhankin
ee2cb00aa1 Use getAllPhysical() 2020-02-20 15:46:27 +03:00
CurtizJ
3f7f13ce05 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-20 15:36:55 +03:00
Alexander Kuzmenkov
642e21e8e1 Log error message before aborting on LOGICAL_ERROR. 2020-02-20 15:29:53 +03:00
Nikolai Kochetov
84af9677be Try fix external tables for RemoteBlockInputStream 2020-02-20 14:29:12 +03:00
chertus
56fa3cc1eb correct fallback for PREFER_PARTIAL_MERGE: HashJoin -> MergeJoin instead of HashJoin -> JoinSwitcher 2020-02-20 14:26:00 +03:00
Nikita Mikhaylov
39f2e6b835
Merge pull request #9198 from nikitamikhaylov/copier-refactoring
clustercopier.cpp file splitting
2020-02-20 13:55:31 +03:00
alesapin
cbd8b697c4 Better error codes and exception messages, remove duplicated headers 2020-02-20 13:04:15 +03:00
alexey-milovidov
64fe250eff
Merge pull request #9211 from ClickHouse/remove-useless-code-in-compression
Remove useless code
2020-02-20 13:02:20 +03:00
alexey-milovidov
eceabbfc3f
Merge pull request #9221 from nvartolomei/nv/advertise-a-stack-trace-will-follow
Improve stack trace formatting for Poco and std exceptions
2020-02-20 12:59:58 +03:00
alexey-milovidov
63aa168a8c
Merge pull request #9229 from 4ertus2/ast
Fix CROSS to INNER JOIN rewrite with [NOT] LIKE
2020-02-20 12:54:57 +03:00
Alexander Kazakov
5a67c02a5d
In KeyCondition: Fixed execution of inversed predicates for non-strictly monotinic functional index (#9223)
* Tests for functional index

* Fixed execution of inversed predicates in functional index

When non-strictly monotonic functional index is used inverted predicated
may be executed incorrectly, which leads to multiple problems: #8821,
#9034
2020-02-20 12:53:02 +03:00
alesapin
5282f8b59c Fix tests and small bug 2020-02-20 12:22:17 +03:00
Nikita Mikhaylov
23ceddebbc codestyle final 2 2020-02-20 12:06:00 +03:00
alesapin
2561e27ead Add settings to storage in test 2020-02-20 11:50:00 +03:00
zhang2014
130e76d5c0 ISSUES-9230 pushed SelectQueryOption into join expression 2020-02-20 11:15:59 +08:00
CurtizJ
2f30a1350b pass proper time for TTL 2020-02-20 03:24:05 +03:00
nikitamikhaylov
3c1f2b6124 style check final 2020-02-19 23:50:27 +03:00
alesapin
e69fd2ac0d Fix test 2020-02-19 23:44:36 +03:00
nikitamikhaylov
6ca0776a61 Merge branch 'master' of github.com:ClickHouse/ClickHouse into copier-refactoring 2020-02-19 23:41:35 +03:00
alexey-milovidov
1f42d03bf8
Update SeekableReadBuffer.h 2020-02-19 22:26:33 +03:00
chertus
3d7959d2e8 fix join_algorithm and partial_merge_join settings check 2020-02-19 22:11:23 +03:00
Ivan Lezhankin
894c451cf0 Get marks from first non-alias column in Log storage 2020-02-19 21:06:18 +03:00
chertus
732c50408a disable crazy push down for test 2020-02-19 20:29:57 +03:00
chertus
fa8f07374b fix CROSS to INNER JOIN rewrite with [NOT] LIKE 2020-02-19 20:22:16 +03:00
CurtizJ
803d9da496 add test for mutations with TTL 2020-02-19 20:18:12 +03:00
Nikolai Kochetov
39916dd01a Remove readWithProcessors from IStorage. 2020-02-19 19:09:31 +03:00
Nikolai Kochetov
a3c4b2e922 Remove readWithProcessors from IStorage. 2020-02-19 19:07:28 +03:00
Nikolai Kochetov
e0c30259fb Remove readWithProcessors from IStorage. 2020-02-19 19:02:37 +03:00
Nikita Mikhaylov
caa4810c5c more codestyle 2020-02-19 18:59:47 +03:00
Nikita Mikhaylov
819a4ad6da codestyle 2020-02-19 18:45:49 +03:00
Nikolai Kochetov
76a21b3364 Use processors for sending external tables. 2020-02-19 18:12:21 +03:00
Nikolai Kochetov
bf18eeda95 Use processors for sending external tables. 2020-02-19 18:09:32 +03:00
alesapin
c4972b3799 Better 2020-02-19 18:07:02 +03:00
Nikita Mikhaylov
24cbd0d6d1 squashed commits 2020-02-19 18:01:08 +03:00
alesapin
1914b1dab7 Add missed headers 2020-02-19 17:58:06 +03:00
CurtizJ
6bc5d988d5 tests for compact parts 2020-02-19 17:55:03 +03:00
Pavel Kovalenko
d4fa60f52d Rename disk_name -> disk. 2020-02-19 17:50:39 +03:00
alesapin
6020f2fd4a Remove redundant function 2020-02-19 17:50:11 +03:00
alesapin
d5b4ddf6d8 Simplier alter modify logic 2020-02-19 17:49:59 +03:00
alesapin
28b2a03b08 First version 2020-02-19 17:49:45 +03:00
chertus
9f43fa87c3 make switched flag atomic 2020-02-19 17:23:21 +03:00
CurtizJ
23592991e6 comments and refactoring 2020-02-19 17:07:36 +03:00
Nikolai Kochetov
3bfbd26901 Use processors for sending external tables. 2020-02-19 17:00:49 +03:00
Alexey Milovidov
add281dfe3 Enable metric_log by default 2020-02-19 16:39:20 +03:00
Nicolae Vartolomei
811197558c Improve stack trace formatting for Poco and std exceptions
Before:

```
<Error> Application: Caught exception while loading metadata: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Access to file denied: boo0. /home/nv/clickhouse-master-clion/contrib/poco/Foundation/src/Exception.cpp:27: Poco::FileAccessDeniedException::FileAccessDeniedException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0xbb598cc in /state/home/nv/clickhouse-builds/clickhouse-master-clion-gcc/dbms/programs/clickhous
```

After:

```
<Error> Application: Caught exception while loading metadata: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Access to file denied: boo, Stack trace (when copying this message, always include the lines below):

0. /home/nv/clickhouse-master-clion/contrib/poco/Foundation/src/Exception.cpp:27: Poco::FileAccessDeniedException::FileAccessDeniedException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0xbb5987c in /state/home/nv/clickhouse-builds/clickhouse-master-clion-gcc/dbms/programs/clickhous
```
2020-02-19 13:33:31 +00:00
chertus
1c297412d4 fix test 2020-02-19 16:10:03 +03:00
alesapin
3b4c27b0de Fix remove parts from mutations 2020-02-19 15:55:23 +03:00
chertus
3348697128 fix storage join 2020-02-19 15:37:56 +03:00
Nikolai Kochetov
75af5414d9 Try fix test_delayed_replica_failover 2020-02-19 15:30:56 +03:00
chertus
48ac7d35ae Merge branch 'master' into joins 2020-02-19 14:21:40 +03:00
chertus
f748427ffd minor fix (remove logic dependent on partial_merge_join setting) 2020-02-19 14:20:35 +03:00
Pavel Kovalenko
d662c1e006 Merge branch 'master' into storage-stripe-log-s3 2020-02-19 13:24:23 +03:00
Nikolai Kochetov
4fa6c86114 Fix StorageHDFS. 2020-02-19 13:22:44 +03:00
Nikolai Kochetov
70a7ddc172 Fix StorageURL 2020-02-19 13:17:49 +03:00
alexey-milovidov
b063dbeaf2
Merge pull request #8598 from excitoon-favorites/passttlsoverhttp
Pass TTL rule info with block to other replicas
2020-02-19 12:09:25 +03:00
alexey-milovidov
c5d5c9c11e
Merge pull request #9192 from nvartolomei/nv/format-version-file-typo
Fix typo in file name when reporting version file duplicates
2020-02-19 11:59:22 +03:00
alexey-milovidov
1c66c2f383
Merge pull request #9201 from CurtizJ/fix-range-reader
Fix mistake introduced in #9050.
2020-02-19 11:58:21 +03:00
alexey-milovidov
ebf4f98a0c
Merge pull request #9210 from Felixoid/profiling_docs
Add description for some profiling events
2020-02-19 11:55:52 +03:00
alexey-milovidov
77f9a358ff
Update ProfileEvents.cpp 2020-02-19 11:55:29 +03:00
alexey-milovidov
e90124dc24
Update ProfileEvents.cpp 2020-02-19 11:54:23 +03:00
Mikhail f. Shiryaev
fdc00e3562
Add description for some profiling events 2020-02-19 09:50:58 +01:00
Alexey Milovidov
b2a52a2d69 Remove useless code #9210 2020-02-19 11:49:26 +03:00
alexey-milovidov
9037a5d29a
Suggestion from Azat 2020-02-19 11:27:57 +03:00
CurtizJ
dea444b69c fix mistake in MergeTreeDataSelectExecutor 2020-02-19 00:00:51 +03:00
Pavel Kovalenko
ff50a51757 Formatting issues. 2020-02-18 22:13:37 +03:00
CurtizJ
b0f7905567 better TTL calculations with mutations 2020-02-18 22:03:40 +03:00
chertus
74a5227ac4 add join_algorithm setting 2020-02-18 20:31:22 +03:00
Nikolai Kochetov
69a38958b4 fix PVS warning. 2020-02-18 19:23:29 +03:00
Pavel Kovalenko
05ceef4ef8 Log family storages disk support via 'SETTINGS' clause. 2020-02-18 17:41:30 +03:00
Nikolai Kochetov
3f55e6a499 Processors support for StorageFromMergeTreeDataPart reading. 2020-02-18 17:24:33 +03:00
chertus
fbecd0c155 use default_max_bytes_in_join in JoinSwitcher if no join limits 2020-02-18 17:19:13 +03:00
Nikolai Kochetov
5d0d2b25e1 Update MergingSortedTransform 2020-02-18 17:15:50 +03:00
Nikolai Kochetov
41851b62e9 Fix TreeExecutorBlockInputStream 2020-02-18 16:29:40 +03:00
Nikolai Kochetov
49926098d3 Update BlockStreamProfileInfo 2020-02-18 16:16:30 +03:00
chertus
f1673e1344 fix JoinSwitcher logic 2020-02-18 15:41:23 +03:00
Pavel Kovalenko
0040ad3289 Fixed includes. 2020-02-18 15:24:20 +03:00
Nicolae Vartolomei
b612cbf7d8 Fix typo in file name when reporting version file duplicates 2020-02-18 11:44:16 +00:00
Nikolai Kochetov
145cb6e12f Update TreeExecutorBlockInputStream. 2020-02-18 13:39:08 +03:00
Nikolai Kochetov
b6b4a87206 Update TreeExecutorBlockInputStream. 2020-02-18 13:37:57 +03:00
alexey-milovidov
9e4b29fe6c
Merge pull request #9156 from azat/SPLIT_SHARED_LIBRARIES-OFF_robust-build
Make SPLIT_SHARED_LIBRARIES=OFF more robust
2020-02-18 12:51:32 +03:00
Pavel Kovalenko
a8cffd55aa Formatting issues. 2020-02-18 12:51:22 +03:00
alexey-milovidov
b688fc5895
Merge pull request #9174 from azat/O_CLOEXEC
[RFC] Set O_CLOEXEC
2020-02-18 12:50:19 +03:00
Nikolai Kochetov
9b8fa9f306 Update TreeExecutor. 2020-02-18 12:05:49 +03:00
Nikolai Kochetov
426a8fd6a2 Update TreeExecutor. 2020-02-18 12:03:17 +03:00
CurtizJ
49c80c88ef Merge remote-tracking branch 'upstream/master' into alter-ttl 2020-02-18 10:58:07 +03:00
Nikolai Kochetov
e6a30feed0 Fix build. 2020-02-18 10:53:16 +03:00
Azat Khuzhin
3bccd81752 Use -undefined,dynamic_lookup over --unresolved-symbols=ignore-all on OSX
Since OSX does not have later [1]:

    ld: unknown option: --unresolved-symbols=ignore-all
    clang: error: linker command failed with exit code 1 (use -v to see invocation)

  [1]: https://clickhouse-builds.s3.yandex.net/9156/eb89764d9dd631a9227ad9c36ad7d6f3ac8d0a4e/build_log_611498641_1581938330.txt
2020-02-18 07:09:24 +03:00
Azat Khuzhin
1313ec7d1b Make SPLIT_SHARED_LIBRARIES=OFF more robust
Refs: #6915
Closes: #9006
Fixes: #9005
2020-02-18 07:09:03 +03:00
Pavel Kovalenko
33443c4bea Merge branch 'master' into storage-stripe-log-s3
# Conflicts:
#	dbms/src/Compression/CompressedReadBufferFromFile.h
#	dbms/src/IO/ReadBufferFromFileBase.h
2020-02-18 00:29:09 +03:00
Azat Khuzhin
aa252e48b8 Set O_CLOEXEC
Since clickhouse allows to execute user-specified command (i.e.
for dictionary loading), it is better not to expose them.

But there is something left for now:
- 10 -> socket:[14422712]
- 11 -> socket:[14422714]
- 12 -> anon_inode:[eventpoll]
- 13 -> anon_inode:[eventpoll]
- 14 -> anon_inode:[eventpoll]
- 15 -> socket:[14426310]
- 16 -> anon_inode:[eventpoll]
- 3 -> /proc/2739071/fd
- 6 -> socket:[14422708]
- 9 -> socket:[14422710]

And most of these (eventpoll) went from poco, for which O_CLOEXEC cannot
be passed.
2020-02-18 00:28:11 +03:00
alexey-milovidov
3fcf2d4e78
Merge pull request #9155 from ClickHouse/obfuscator-overgenerate-data
clickhouse-obfuscator: allow to generate more data than was in source
2020-02-17 23:51:57 +03:00
CurtizJ
7022376a2a remove debug prints 2020-02-17 23:45:16 +03:00
CurtizJ
2ff030be35 recalculate TTL expressions during mutations 2020-02-17 23:39:24 +03:00
Pavel Kovalenko
e849654628 Reworked ReadIndirectBuffer for DiskMemory. 2020-02-17 23:08:35 +03:00
alexey-milovidov
146109fe27
Merge pull request #9161 from abyss7/arcadia
Reorganize layout of repository (part 1)
2020-02-17 21:58:20 +03:00
Alexey Milovidov
a1ccd14032 Fixed error with zero bytes in haystack for constant case #9160 2020-02-17 21:53:59 +03:00
Alexey Milovidov
808e27bf30 Added a test #9160 2020-02-17 21:52:10 +03:00
chertus
a9e743d8bd minor JoinSwitcher optimisation 2020-02-17 20:41:38 +03:00
chertus
5717d48333 better includes 2020-02-17 20:21:03 +03:00