Maksim Kita
96d9782439
Temporary table already exists exception message fix
2024-02-16 19:16:02 +03:00
Dmitry Novik
a3c34a7cc2
Merge pull request #54211 from ClickHouse/Support_parameterized_view_with_analyzer
...
Refactor parameterized view & add support for new analyzer
2024-02-16 16:13:49 +01:00
Alexander Tokmakov
228a29b93f
fix
2024-02-16 14:05:22 +01:00
Alexey Milovidov
25f2501c7f
Merge pull request #60013 from ClickHouse/verify-parser-on-server-side
...
Verify formatting consistency on the server-side
2024-02-16 13:48:10 +01:00
Igor Nikonov
118263d8e8
Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http
2024-02-16 12:40:10 +00:00
Alexey Milovidov
00c28d97ed
Merge branch 'master' into verify-parser-on-server-side
2024-02-16 01:29:08 +01:00
Alexey Milovidov
15683ae6a0
Revert wrong modification
2024-02-15 22:58:07 +01:00
Alexander Tokmakov
22c97be2a4
ability to detect undead ZooKeeper sessions
2024-02-15 22:17:31 +01:00
Robert Schulze
058461e786
Merge remote-tracking branch 'rschu1ze/master' into order-by-all-ambiguities
2024-02-15 16:21:16 +00:00
Robert Schulze
1edf3b2254
Replace ORDER BY ALL by ORDER BY * to get rid of ambiguities
2024-02-15 16:19:56 +00:00
Dmitry Novik
a11b9553ca
Fix implementation in new analyzer
2024-02-15 17:16:27 +01:00
avogar
efa823400b
Add IDataType::forEachChild and use it in nested types validation
2024-02-15 13:19:02 +00:00
Raúl Marín
5baae9326c
Fix optimize_uniq_to_count removing the column alias
2024-02-15 14:10:55 +01:00
Igor Nikonov
1464830791
Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http
2024-02-15 12:56:32 +00:00
Igor Nikonov
c580cdb96e
Fix review comment
2024-02-15 12:55:43 +00:00
avogar
109720d162
Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-bad-types-check
2024-02-15 12:10:49 +00:00
Alexey Milovidov
a86d31a005
Merge pull request #59998 from ClickHouse/revert-59699-disable_async_inserts_for_dependent_mv_dedup
...
Revert "Insert synchronously if dependent MV deduplication is enabled"
2024-02-15 07:52:13 +01:00
Alexey Milovidov
0258aba5c0
Verify formatting consistency on the server-side
2024-02-15 07:49:13 +01:00
Alexey Milovidov
47d8248b9d
Merge pull request #60005 from ClickHouse/non-significant-changes-3
...
Fix obviously wrong (but non significant) error in dictionaries
2024-02-15 05:59:07 +01:00
Alexey Milovidov
0b58f16938
Merge pull request #59964 from ClickHouse/cleanups
...
Cleanups
2024-02-15 02:59:54 +01:00
Alexey Milovidov
5e5528a890
Merge pull request #59972 from jrdi/fix-max-num-to-warn
...
Fix max num to warn message
2024-02-15 02:59:29 +01:00
Alexey Milovidov
46fb01c4f6
Fix trash
2024-02-15 02:31:46 +01:00
Vitaly Baranov
5591d74076
Add new config setting "backups.remove_backup_files_after_failure".
2024-02-14 23:19:21 +01:00
Julia Kartseva
b1b58ef9a3
Revert "Insert synchronously if dependent MV deduplication is enabled"
2024-02-14 12:54:42 -08:00
Nikolai Kochetov
9c626f9c36
Merge pull request #59899 from ClickHouse/refactor-squashing-for-inserts
...
Refactor Squashing for inserts.
2024-02-14 19:29:11 +01:00
Raúl Marín
11519f949b
Merge pull request #59731 from kitaisreal/asof-join-try-sort-with-radix-sort
...
ASOF JOIN use trySort with RadixSort
2024-02-14 15:54:22 +01:00
Igor Nikonov
fd5b572225
Fix
2024-02-14 13:00:22 +00:00
Nikolai Kochetov
3d86e87f7f
Fixing tests.
2024-02-14 12:28:54 +00:00
Jordi Villar
83a184d928
Fix max num to warn message
2024-02-14 10:11:21 +01:00
Alexey Milovidov
2b4949bd18
Cleanups
2024-02-14 00:21:13 +01:00
Alexey Milovidov
b9d3ae3b0a
Merge pull request #58195 from Unalian/feat-58127
...
Add InitialQuery event
2024-02-13 23:51:03 +01:00
Igor Nikonov
3d91b12a2f
Fix typo
2024-02-13 22:34:10 +00:00
Igor Nikonov
e9dcc751ac
Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http
2024-02-13 22:08:44 +00:00
Igor Nikonov
a27639a7f9
Fix: call first exception callback on exception
...
it'll update query_log
2024-02-13 22:06:00 +00:00
Kruglov Pavel
48a3b8e675
Merge pull request #58292 from ucasfl/negtive-position
...
Resubmit: Support negtive position arguments
2024-02-13 18:35:28 +01:00
Nikolai Kochetov
134837d6fb
Fixing tests.
2024-02-13 16:16:53 +00:00
Nikolai Kochetov
253abd1643
Refactor Squashing for inserts.
2024-02-13 16:16:53 +00:00
Maksim Kita
4577975923
Fixed code review issues
2024-02-13 15:41:17 +03:00
Maksim Kita
bfa7938df9
Fixed tests
2024-02-13 15:41:17 +03:00
Maksim Kita
a359ceecb5
ASOF JOIN use trySort with RadixSort
2024-02-13 15:41:17 +03:00
Smita Kulkarni
3526d7982c
Merge branch 'master' into Support_parameterized_view_with_analyzer
2024-02-13 13:08:35 +01:00
Igor Nikonov
d1167d0b04
Fix: corrupted source + fail point
2024-02-12 20:56:13 +00:00
Igor Nikonov
eb44faf867
Test to reproduce absence of closing record in query_log
2024-02-12 20:41:46 +00:00
Nikolai Kochetov
fd2ee19f65
Follow up for #58554 . Cleanup.
2024-02-12 13:37:25 +00:00
Nikolai Kochetov
09d3b3c0d0
Merge pull request #58554 from ClickHouse/try-to-always-push-down-prewhere-from-query-plan
...
Simplify optimize-push-to-prewhere from query plan
2024-02-12 12:52:39 +01:00
Igor Nikonov
cb812d84cf
Fix: check if std::function is set before calling it
2024-02-11 22:31:33 +00:00
Alexey Milovidov
c36397100b
Merge pull request #59662 from Algunenano/shard_query_start_time
...
Fix query start time on non initial queries
2024-02-10 03:09:06 +01:00
Nikolai Kochetov
862c6cd79c
Merge pull request #57430 from ClickHouse/non-ready-set-ttl
...
Non ready set in TTL WHERE.
2024-02-09 16:31:26 +01:00
Igor Nikonov
effaaceb26
Merge pull request #59501 from ClickHouse/pr-better-replicas-failover-2
...
Parallel replicas: better initial replicas failover (2)
2024-02-09 15:50:56 +01:00
Nikolai Kochetov
1063d9ca50
Use opd prewhere optimizaer for old analyzer.
2024-02-09 14:47:24 +00:00
Michael Kolupaev
359dda5693
Fix DB type check - now it'll refuse to create in Replicated databases ( #59743 )
...
Fix DB type check - now it'll refuse to create in Replicated databases
2024-02-08 22:38:53 -08:00
Julia Kartseva
93bcf0b09c
Merge pull request #59781 from jkartseva/adaptive-async-timeout-better-logging
...
Better logging for adaptive async timeouts
2024-02-08 20:32:42 -08:00
Julia Kartseva
2286184885
Merge pull request #59699 from jkartseva/disable_async_inserts_for_dependent_mv_dedup
...
Insert synchronously if dependent MV deduplication is enabled
2024-02-08 19:23:51 -08:00
Ilya Yatsishin
1c58cafcf3
Merge pull request #59741 from vitlibar/fix-skipping-unused-shards-with_analyzer
...
Fix skipping unused shards with analyzer
2024-02-09 02:44:59 +04:00
Julia Kartseva
e598ad9157
Better logging for adaptive async timeouts
...
Log the adaptive async timeout value after normalization.
2024-02-08 21:42:44 +00:00
Raúl Marín
74dbb06d3f
Merge remote-tracking branch 'blessed/master' into shard_query_start_time
2024-02-08 19:43:20 +01:00
Vitaly Baranov
1b9620001b
Move ColumnArray-specific code out of the ActionsDAG.
2024-02-08 15:31:32 +01:00
Igor Nikonov
3fb30a23d9
Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2
2024-02-08 09:09:11 +00:00
Julia Kartseva
ece4febe32
Insert synchronously if dependent MV deduplication is enabled
2024-02-08 08:42:04 +00:00
Alexander Tokmakov
510f90edf8
Merge pull request #59688 from ClickHouse/revert_39507_again
...
Temporarily remove a feature that doesn't work
2024-02-08 02:27:55 +01:00
Vitaly Baranov
12a71375b8
Fix skipping unused shards with analyzer.
2024-02-08 00:44:59 +01:00
Nikolai Kochetov
41d6243170
Fix PreparedSets
2024-02-07 12:43:26 +00:00
Nikolai Kochetov
d1902cdba0
Fix some tests.
2024-02-07 12:36:24 +01:00
Nikolai Kochetov
06d112135e
Simplify prewhere push down from query plan. Try to always use it.
2024-02-07 12:36:20 +01:00
Nikolai Kochetov
a3d1b3f502
Merge branch 'master' into non-ready-set-ttl
2024-02-07 11:29:04 +00:00
Alexander Tokmakov
77e4b0c8d9
Revert "Merge pull request #59122 from arthurpassos/bring_back_attach_partition_pr"
...
This reverts commit ac90637170
, reversing
changes made to fe2b5cde05
.
2024-02-07 02:52:43 +01:00
Raúl Marín
b43f90fce2
Fix query start time on non initial queries
2024-02-06 19:55:50 +01:00
Raúl Marín
5c68f9cabd
Maintain function alias in RewriteSumFunctionWithSumAndCountVisitor
2024-02-06 19:09:28 +01:00
Igor Nikonov
8748d8c537
UNEXPECTED_CLUSTER error for cluster with more than 1 shard
2024-02-05 15:10:51 +00:00
Robert Schulze
e414384727
Merge remote-tracking branch 'rschu1ze/master' into order-by-all-ambiguities
2024-02-05 13:17:02 +00:00
Igor Nikonov
92a36109c3
Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2
2024-02-05 12:07:44 +00:00
Nikita Mikhaylov
6ba35b5459
Make comments for system tables also available in local mode and enforce comments not to be empty ( #59493 )
...
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2024-02-05 11:17:58 +01:00
Igor Nikonov
df4bc398fb
Merge remote-tracking branch 'origin/master' into fix-messed-up-progress
2024-02-03 10:25:10 +00:00
Julia Kartseva
f41f4e4bd0
Merge pull request #58486 from jkartseva/adjustable-async-timeouts
...
Adjustable asynchronous insert timeouts
2024-02-02 08:53:58 -08:00
Igor Nikonov
74e04e1819
Merge remote-tracking branch 'origin/master' into fix-messed-up-progress
2024-02-02 13:11:07 +00:00
Alexander Gololobov
095648d7bc
Merge pull request #59388 from ClickHouse/system_zookeeper_retries
...
Retry disconnects and expired sessions when reading system.zookeeper
2024-02-02 11:52:15 +01:00
serxa
1d31ac2a0c
add FORGET PARTITION
query to remove old parition nodes from ZooKeeper
2024-02-02 10:03:31 +00:00
Robert Schulze
dd484fc312
Simplify what happens in SELECT all, ... [...] ORDER BY ALL
...
Previously setting `enable_order_by_all` distinguished for ORDER BY ALL
whether we should sort by column 'all' (if given in the SELECT clause)
or by all columns. The actual behavior was not always intuitive.
Now, we throw unconditionally an exception which also simplifies the
handling a bit. Only an edge case is affected and if users really want
to run ORDER BY ALL on a column names 'all', they can alias it.
2024-02-02 09:53:35 +00:00
Julia Kartseva
689c368b76
Adaptive async timeouts: consider queue flush history
...
In addition to the time since the most recent insert,
consider the elapsed time between the two recent queue
flushes when decreasing the timeout or processing an
entry synchronously.
2024-02-01 22:45:10 +00:00
Julia Kartseva
4ef02a1895
Log timeout for entries processed asynchronously
2024-02-01 22:45:09 +00:00
Julia Kartseva
c04e5a4f35
Asynchronous insert queue size and bytes metrics
...
Add AsynchronousInsertQueueSize and AsynchronousInsertQueueBytes
metrics to improve observability of asynchronous inserts.
The metrics do not account for tasks dispatched for immediate processing
(as opposed to, e.g., PendingAsyncInsert).
```
SELECT value
FROM system.metrics
WHERE metric IN ('AsynchronousInsertQueueSize', 'PendingAsyncInsert')
Query id: a711dd83-b48d-4ad5-8031-fa59b21a7c38
┌─value─┐
│ 18 │
│ 23 │
└───────┘
```
```
SELECT value
FROM system.metrics
WHERE metric IN ('AsynchronousInsertQueueSize', 'AsynchronousInsertQueueBytes')
Query id: b35a7ceb-2bb5-46ad-b301-e6cf03508699
┌─value─┐
│ 28 │
│ 1372 │
└───────┘
```
2024-02-01 22:45:09 +00:00
Julia Kartseva
04c8bd1be5
Adaptive asynchronous insert timeouts
...
Implement the algorithm described in #56783 for adaptive asynchronous
insert timeouts.
- The adaptive async insert timeout can take values within
[async_insert_busy_timeout_min_ms, async_insert_busy_timeout_max_ms].
- The initial value is set to async_insert_busy_timeout_min_ms.
- If the elapsed time since the most recent queue insert was
greater than the maximum timeout, process the queue content immediately,
and reduce the timeout.
- If the elapsed time was long enough (longer than a would-be decreased
timeout), decrease the timeout.
- The adaptive timeout is changes exponentially based on the
async_insert_busy_timeout_{increase|decrease}_rate.
Fixes: https://github.com/ClickHouse/ClickHouse/issues/56783
2024-02-01 22:45:06 +00:00
Igor Nikonov
82d7b22144
Parallel replicas: better replicas failover
2024-02-01 21:06:29 +00:00
Kruglov Pavel
d485e36f20
Fix style
2024-02-01 16:57:46 +01:00
Raúl Marín
18386f7fb9
Merge remote-tracking branch 'blessed/master' into parallel_replicas_cte_fix
2024-02-01 12:04:46 +01:00
Raúl Marín
b93f003b3e
Merge pull request #58216 from bigo-sg/fix_quantiles_gk_state
...
Fix quantilesGK bug
2024-02-01 11:58:02 +01:00
Raúl Marín
a0222c0479
Fix problem detected by UBSAN
2024-02-01 11:46:59 +01:00
Julia Kartseva
bbaa08199a
Introduce polling timeout for asynchronous queue
...
The current timeout for checking updates in the asynchronous queue is
equal to the timeout used for queue entry
(async_insert_busy_timeout_ms).
That means that, in the worst case, an entry spends twice the time of the
asynchronous timeout in the queue.
2024-02-01 08:27:41 +00:00
Vitaly Baranov
a193e01c8f
Merge pull request #54737 from arenadata/ADQM-1150
...
Added maximum sequential login failures to the quota.
2024-01-31 16:06:17 +01:00
Raúl Marín
dad6ea0930
Merge pull request #59239 from Algunenano/parallel_replicas_cte
...
Disable parallel replicas JOIN with CTE (not analyzer)
2024-01-31 14:45:13 +01:00
avogar
aaed835415
Validate variants, use new validation on create queries
2024-01-31 12:59:26 +00:00
Raúl Marín
f875151b97
Merge pull request #59379 from Algunenano/fix_translate_asserts
...
Add sanity checks for function return types
2024-01-31 11:56:11 +01:00
taiyang-li
a89890babe
fix bug of quantileGK
2024-01-31 12:14:04 +08:00
Igor Nikonov
d8a6e53d0b
Use FQDN as host name by default for TCP
...
- instead of display_name setting value
2024-01-30 20:27:30 +00:00
Alexander Gololobov
c348c4e828
Move ZooKeeperRetries.h to Common
2024-01-30 19:02:17 +01:00
avogar
7a1458c922
Fix validating suspicious/experimental types in nested types
2024-01-30 15:21:58 +00:00
Raúl Marín
f79a402e6d
Add sanity checks for function return types
2024-01-30 14:10:20 +01:00
Kseniia Sumarokova
e16aaa8d81
Merge branch 'master' into broken-projections-better-handling
2024-01-30 10:54:22 +01:00
flynn
4f12ca249d
Fix typo
2024-01-30 07:01:07 +00:00
flynn
9858c41849
Merge branch 'master' of github.com:ClickHouse/ClickHouse into negtive-position
2024-01-30 04:03:35 +00:00