Commit Graph

3868 Commits

Author SHA1 Message Date
Sema Checherinda
96a6462059 fix CascadeWriteBuffer 2024-06-24 21:12:06 +02:00
Anton Popov
867a5650fc Merge remote-tracking branch 'upstream/master' into HEAD 2024-06-24 19:06:28 +00:00
Sema Checherinda
8f81dc49d3 fix d-tor in WriteBufferFromS3 2024-06-24 16:50:45 +02:00
Sema Checherinda
8bdbb8c383 fix WriteBufferFromFile 2024-06-24 13:54:37 +02:00
skyoct
531a7e3592 fix etag init 2024-06-24 18:26:40 +08:00
Alexander Tokmakov
5673446d9c fix build 2024-06-23 02:47:44 +02:00
Alexander Tokmakov
dbdf4e1880 improve ZooKeeper load balancing 2024-06-23 01:58:28 +02:00
Sema Checherinda
90231e302e fix WriteBufferFromFileDecorator cancelation 2024-06-21 20:12:34 +02:00
Sema Checherinda
33e01a7ac0 Merge branch 'master' into chesema-less-backoff-timeout-try-2 2024-06-20 19:06:10 +02:00
Sema Checherinda
19bafb5063 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-20 18:10:53 +02:00
Robert Schulze
466aec959a
Revert "Suppress false positives in leaksan"
This reverts commit 2418d673f1.
2024-06-19 08:30:44 +00:00
skyoct
8ca47905ef fix get tag 2024-06-19 14:06:36 +08:00
skyoct
766130bc98 feat: add etag for object storage 2024-06-18 19:16:32 +08:00
Alexey Milovidov
66e07e4f91 Merge branch 'master' into bad-error-message 2024-06-18 11:10:09 +02:00
Alexander Tokmakov
b150b0f5fa
Revert "Fix AWS ECS" 2024-06-17 23:11:59 +02:00
Kruglov Pavel
903b09b46d
Merge pull request #65164 from ClickHouse/ecs
Fix AWS ECS
2024-06-17 18:31:18 +00:00
Sema Checherinda
2d16ab0c07 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-17 17:15:29 +02:00
Sema Checherinda
a7e1703b6d
Merge branch 'master' into chesema-less-backoff-timeout-try-2 2024-06-17 14:32:53 +02:00
Kruglov Pavel
bd4e76b1b8
Merge pull request #65063 from Avogar/avoid-write-to-finalized-buffer
Avoid writing to finalized buffer in File-like storages
2024-06-17 12:22:07 +00:00
Kruglov Pavel
10faefb266
Merge pull request #64206 from Avogar/fix-uncaught-exception
Fix abort on uncaught exception in ~WriteBufferFromFileDescriptor in StatusFile
2024-06-17 12:20:16 +00:00
Alexey Milovidov
8b1f1947f7 Slightly better user-agent 2024-06-16 17:39:36 +02:00
Alexey Milovidov
35ce8c6e72 Version in User-Agent 2024-06-16 17:32:41 +02:00
Alexey Milovidov
0ff8d0ce32 Merge branch 'master' into bad-error-message 2024-06-16 14:40:42 +02:00
Alexey Milovidov
c3bd1bebfc Merge branch 'master' into ecs 2024-06-16 09:00:36 +02:00
Sergei Trifonov
1778bcfc0b
Merge pull request #65050 from ClickHouse/s3-throttler-metrics
Add metrics for PutObject and GetObject throttlers of ObjectStorage
2024-06-14 16:33:35 +00:00
Sema Checherinda
ef4afa5f40 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-14 18:32:24 +02:00
Raúl Marín
0d8bd133e6
Merge pull request #64959 from canhld94/bump_fmt_9
Update fmtlib version to 9.1.0
2024-06-14 14:05:04 +00:00
Alexey Milovidov
6068d355f6 Merge branch 'master' into bad-error-message 2024-06-14 12:59:09 +02:00
Sema Checherinda
bb995c74cc Revert "Revert "S3: reduce retires time for queries, increase retries count for backups""
This reverts commit 7683f06188.
2024-06-13 16:30:38 +02:00
Kseniia Sumarokova
ef8810a60d
Merge branch 'master' into unite-storages3-and-disks3-settings 2024-06-13 14:24:04 +02:00
kssenii
64f8fedc7a Fix test 2024-06-13 14:23:32 +02:00
avogar
5829ab41db Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-uncaught-exception 2024-06-12 12:33:35 +00:00
Alexey Milovidov
89d2de2872 Fix AWS ECS 2024-06-12 14:08:52 +02:00
Kruglov Pavel
085c406f1f
Merge pull request #64641 from azat/fix-float-inference
Fix type inference for float (in case of small buffer)
2024-06-12 11:38:54 +00:00
Raúl Marín
7683f06188
Revert "S3: reduce retires time for queries, increase retries count for backups" 2024-06-12 11:26:21 +02:00
Alexey Milovidov
603176ef7f Fix bad error message 2024-06-12 01:23:48 +02:00
Sema Checherinda
e4050334bb fix StorageURLSink 2024-06-11 13:59:22 +02:00
Sema Checherinda
b35ee73b15 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-11 13:27:39 +02:00
avogar
d9ff40851e Don't use finalize in release() method 2024-06-11 10:55:27 +00:00
Duc Canh Le
79a660c018 Merge branch 'master' into bump_fmt_9
Fix CI
2024-06-11 03:39:03 +00:00
Sema Checherinda
f52ca21db0
Merge pull request #63857 from ClickHouse/chesema-less-backoff-timeout
S3: reduce retires time for queries, increase retries count for backups
2024-06-11 00:25:46 +00:00
kssenii
26ac82dd5c Merge remote-tracking branch 'origin' into unite-storages3-and-disks3-settings 2024-06-10 18:05:52 +02:00
kssenii
8904880480 Try fix test 2024-06-10 18:03:26 +02:00
serxa
a50019c6ca Add metrics for PutObject and GetObject throttlers of ObjectStorage 2024-06-10 11:49:41 +00:00
Duc Canh Le
de5258128e update fmtlib version to 9.1.0
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-06-07 06:44:36 +00:00
Kseniia Sumarokova
1e75f8ea26
Merge branch 'master' into unite-storages3-and-disks3-settings 2024-06-06 18:30:11 +02:00
Ilya Golshtein
aefe7ffc31 time_virtual_col: slightly works 2024-06-06 09:48:32 +00:00
vdimir
5251febf03
Merge pull request #64393 from ClickHouse/vdimir/blob_storage_log_fix_recursion
Prevent recursive logging in blob_storage_log
2024-06-05 14:28:01 +00:00
kssenii
f0974f02ee Merge remote-tracking branch 'origin/master' into unite-storages3-and-disks3-settings 2024-06-05 13:11:20 +02:00
Sema Checherinda
dd6ae2f77c
Merge pull request #63427 from arthurpassos/fix_wrong_request_protocol_proxy
Several minor fixes to proxy support in ClickHouse
2024-06-04 16:35:03 +00:00
kssenii
00c352a31c Fix clang-tidy 2024-06-04 12:28:07 +02:00
vdimir
37fa4f5dd6
Revert "Fix build BlobStorageLogWriter with CLICKHOUSE_KEEPER_STANDALONE_BUILD"
This reverts commit dfcc36ee2d02c036126007dcdc1ffc1946a3e9f2.
2024-06-04 07:52:49 +00:00
vdimir
72e7a266e7
Revert "Move BlobStorageLogWriter to Interpreters"
This reverts commit ca3d80102365e76d931be016638b1ca506dffb86.
2024-06-04 07:52:49 +00:00
vdimir
6d9b2c8f5a
Move BlobStorageLogWriter to Interpreters 2024-06-04 07:52:48 +00:00
vdimir
5d1b33612c
Fix build BlobStorageLogWriter with CLICKHOUSE_KEEPER_STANDALONE_BUILD 2024-06-04 07:52:48 +00:00
vdimir
03fa9c32ee
Update BlobStorageLog and SystemLog to add settings for query 2024-06-04 07:52:47 +00:00
vdimir
55512d4a61
Prevent recursive logging in blob_storage_log 2024-06-04 07:52:44 +00:00
kssenii
642e2fdd72 Fix clang-tidy 2024-06-03 18:17:13 +02:00
kssenii
cd3d99a0eb Merge remote-tracking branch 'origin/master' into unite-storages3-and-disks3-settings 2024-06-03 17:37:33 +02:00
kssenii
a035e4ed69 Fix tests 2024-06-03 11:59:48 +02:00
Michael Kolupaev
1cb3961f9d Call GetResult() once 2024-06-01 18:12:30 +00:00
Azat Khuzhin
5246c56a2a Fix type inference for float (in case of small buffer)
In case of small buffer (i.e. --max_read_buffer_size 1) the pos() will
be always point to this one byte, so, comparing pos() will be always
evaluated to true.

And we cannot use count() as well, since in case of big buffer it will
be the same, plus, in case of reading extra byte for checking for '.'
the count() will be different, but it does not mean that the byte had
been interpreted (and allowing 1 byte of difference will not work almost
always, since it will read max_read_buffer_size bytes).

So instead, expose the has_fractional flag from the read helpers for
float, via two new methods:
- tryReadFloatTextExt
- tryReadFloatTextExtNoExponent

Where "ext" stands for "extended", which means expose extra information.

v2: consider number as float if it has '.' or 'e' (previously only if it
has some signs after those two it had been considered as float)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-06-01 16:34:55 +02:00
Michael Kolupaev
d21a5b2f0c Check for missing Upload ID in CreateMultipartUpload reply 2024-06-01 07:00:20 +00:00
kssenii
779eaa01ec Fix tests 2024-05-31 17:53:09 +02:00
Sema Checherinda
99ce2985d4 work with tests 2024-05-30 17:01:28 +02:00
kssenii
74c59fa92a Merge remote-tracking branch 'origin/master' into unite-storages3-and-disks3-settings 2024-05-30 16:55:22 +02:00
kssenii
dd34d316c5 Fix tests 2024-05-30 16:54:11 +02:00
Arthur Passos
dba8c98e5f minor changes 2024-05-30 09:33:59 -03:00
Sema Checherinda
2df9ab60a4 Merge branch 'master' into chesema-less-backoff-timeout 2024-05-30 13:16:12 +02:00
Arthur Passos
313db20b74 fix poco proxy configuration being resolved outside try-catch block 2024-05-29 14:46:45 -03:00
Sema Checherinda
ef3a2fef01 work with tests 2024-05-29 16:45:32 +02:00
Robert Schulze
18d432f44c
Reapply "Remove some unnecessary UNREACHABLEs"
This reverts commit 5a868304c0.
2024-05-29 13:37:47 +00:00
kssenii
f85030f481 Better 2024-05-29 12:35:37 +02:00
Arthur Passos
5d37777b2d wrap get region for bucket in try catch and retry any net exception instead of only connection reset 2024-05-28 15:59:11 -03:00
Sema Checherinda
6771737c23 rm d-tor CompressedWriteBuffer, adjust WriteBufferFromFile 2024-05-28 16:54:18 +02:00
Sema Checherinda
0fad110d9e fix typo 2024-05-28 15:20:45 +02:00
Antonio Andelic
9f242391b4
Merge pull request #64153 from ClickHouse/fix-backup-without-native-copy
Correctly fallback during backup copy
2024-05-28 13:11:06 +00:00
kssenii
9e1cd7e898 Unify part of the code 2024-05-28 14:03:51 +02:00
kssenii
9d961d1936 Better 2024-05-28 13:54:34 +02:00
kssenii
73e9719768 Fix build 2024-05-28 12:51:58 +02:00
Sema Checherinda
86089a3a10 make write buffers cancelable 2024-05-28 00:09:39 +02:00
kssenii
56c7301d46 Use BaseSettings for auth settings 2024-05-27 18:28:37 +02:00
kssenii
5abebeca63 Use BaseSettings 2024-05-27 16:08:55 +02:00
Antonio Andelic
8f775037bf Address PR review 2024-05-27 13:02:45 +00:00
kssenii
80f195d2b9 Refactor s3 settings 2024-05-27 12:11:04 +02:00
Alexander Tokmakov
5a868304c0
Revert "Remove some unnecessary UNREACHABLEs" 2024-05-27 11:38:22 +02:00
Antonio Andelic
4f165733a4 Merge branch 'master' into fix-backup-without-native-copy 2024-05-27 07:40:55 +00:00
Robert Schulze
7a552f5b06
Merge pull request #64035 from rschu1ze/unreachable-unreachable
Remove some unnecessary `UNREACHABLE`s
2024-05-26 20:37:17 +00:00
Robert Schulze
f182920c98
Merge remote-tracking branch 'ClickHouse/master' into redundant-inline 2024-05-26 14:21:47 +00:00
Arthur Passos
a814f2445f fix cache ttl 2024-05-24 17:46:05 -03:00
Sema Checherinda
942dc971ce
Merge branch 'master' into chesema-less-backoff-timeout 2024-05-23 16:58:57 +02:00
kssenii
3004f0b63d Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-23 16:51:46 +02:00
Robert Schulze
f792a602da
Merge remote-tracking branch 'rschu1ze/master' into unreachable-unreachable 2024-05-22 21:08:27 +00:00
Robert Schulze
f584807359
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-22 21:05:27 +00:00
Sema Checherinda
1d0b4eb976
Merge branch 'master' into chesema-less-backoff-timeout 2024-05-22 15:50:49 +02:00
Kruglov Pavel
fddedee9a9
Merge pull request #59747 from Blargian/56257_parse_crlf_with_TSV_files
Parse CRLF with TSV files
2024-05-22 13:45:07 +00:00
kssenii
1059b51177 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-22 14:13:27 +02:00
Kseniia Sumarokova
fda0b33061
Merge pull request #64117 from ClickHouse/fix-azure-multipart-upload-in-backup
Fix azure backup writing multipart blocks by 1mb (read buffer size) instead of `max_upload_part_size` (in non-native copy case)
2024-05-22 11:41:18 +00:00
Robert Schulze
0d3aeddc93
Merge remote-tracking branch 'rschu1ze/master' into unreachable-unreachable 2024-05-22 07:25:00 +00:00
Antonio Andelic
ef8faeffc0 Merge branch 'master' into fix-backup-without-native-copy 2024-05-22 09:00:07 +02:00
avogar
06a131d751 Fix abort on uncaught exception in ~WriteBufferFromFileDescriptor in StatusFile 2024-05-21 18:46:21 +00:00
Sema Checherinda
103966534a Merge branch 'master' into chesema-less-backoff-timeout 2024-05-21 18:02:03 +02:00
kssenii
7b225ab59c Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-21 16:58:25 +02:00
alesapin
e3ac5f4d12
Merge pull request #64182 from ClickHouse/fix_azure_native_copy
One attempt to fix native copy for azure
2024-05-21 13:49:47 +00:00
Antonio Andelic
b80d878b4c Add test 2024-05-21 13:28:12 +02:00
alesapin
ef182b0356 Fix 2024-05-21 12:54:46 +02:00
alesapin
0b3102576e One attempt to fix native copy for azure 2024-05-21 11:43:16 +02:00
kssenii
c1fde88e6a Better error case handling 2024-05-21 11:06:24 +02:00
Antonio Andelic
d66f0d6420 Properly fallback when native copy fails 2024-05-21 10:36:19 +02:00
Robert Schulze
a14e58ab88
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-21 05:15:35 +00:00
Robert Schulze
70637b2ecf
Merge remote-tracking branch 'rschu1ze/master' into move-isallascii 2024-05-20 13:01:53 +00:00
Robert Schulze
7887ab3848
Merge remote-tracking branch 'rschu1ze/master' into unreachable-unreachable 2024-05-20 12:58:39 +00:00
Robert Schulze
2ceb8b9c8f
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-20 12:56:38 +00:00
kssenii
ba325b6250 Merge remote-tracking branch 'origin/master' into fix-azure-multipart-upload-in-backup 2024-05-20 12:34:04 +02:00
alesapin
23e87ef80e Review fix 2024-05-20 11:56:44 +02:00
kssenii
357ec69677 Fix style check 2024-05-19 23:33:24 +02:00
kssenii
c2a613e94d Better 2024-05-19 22:08:36 +02:00
kssenii
93b11c57a0 Fix azure backup uploaded block size 2024-05-19 21:14:06 +02:00
alesapin
2765fd951c Properly support native copy for azure 2024-05-19 21:02:12 +02:00
Robert Schulze
113bb00005
Fix clang-tidy "-readability-redundant-inline-specifier" 2024-05-19 10:23:58 +00:00
Robert Schulze
2909e6451b
Move StringUtils.h/cpp back to Common/ 2024-05-19 09:39:36 +00:00
Robert Schulze
53e992af4f
Remove some unnecessary UNREACHABLEs 2024-05-17 11:46:07 +00:00
Sema Checherinda
af3e9c9295
Merge branch 'master' into chesema-less-backoff-timeout 2024-05-17 13:27:47 +02:00
kssenii
b53e9eec7b Support for archives (unfinished) 2024-05-17 11:09:59 +02:00
Han Fei
2e76275124
Merge pull request #63202 from hanfei1991/hanfei/fix-intersection
fix intersect parts when restart after drop range
2024-05-16 14:27:25 +00:00
kssenii
af6f124df0 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-16 16:02:35 +02:00
Sema Checherinda
6b8a1b5f80 Merge branch 'master' into chesema-less-backoff-timeout 2024-05-16 13:18:43 +02:00
Daniil Ivanik
9b09550176
Merge pull request #62259 from divanik/divanik/fix_archieve_support_in_s3
Add support of reading from archives in S3
2024-05-16 10:41:33 +00:00
Sema Checherinda
ff01ca80b4 reduce retires time for queries, increase retries count for backups 2024-05-15 16:37:42 +02:00
Han Fei
171bf4f201 Merge branch 'master' into hanfei/fix-intersection 2024-05-15 13:59:52 +02:00
kssenii
5ede316ec5 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-15 12:52:25 +02:00
Antonio Andelic
9744feb95e Fix deadlock in parallel read buffer 2024-05-15 11:02:10 +02:00
avogar
a7e87e22ad Merge branch 'master' of github.com:ClickHouse/ClickHouse into 56257_parse_crlf_with_TSV_files 2024-05-14 11:56:43 +00:00
kssenii
9ce465bb88 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-13 16:14:58 +02:00
Antonio Andelic
449aacb3d0
Correct 2024-05-13 15:08:52 +02:00
Antonio Andelic
2b38b8a97b
Correct byte count 2024-05-13 14:49:26 +02:00
Anton Popov
47d0eadb6f Merge remote-tracking branch 'upstream/master' into HEAD 2024-05-13 12:12:31 +00:00
divanik
faef8807d2 Resolve conflicts 2024-05-13 12:04:06 +00:00
divanik
d468a0a577 Add archives reading support to s3 2024-05-13 12:00:15 +00:00
Antonio Andelic
e65dd3d939 Cancel S3 reads properly when parallel reads are used 2024-05-13 12:36:29 +02:00
Alexey Milovidov
23cf6d0d8b Useless changes 2024-05-11 22:51:57 +02:00
Anton Popov
9ed3acce82 refactoring near azure blob storage 2024-05-10 18:22:23 +00:00
Alexey Milovidov
224e1940ae Useless changes 2024-05-09 03:58:34 +02:00
Alexey Milovidov
0d14a2c67e Useless changes 2024-05-09 03:11:02 +02:00
Alexey Milovidov
1d69518c4d Useless changes 2024-05-09 02:07:04 +02:00
Alexey Milovidov
95f12ef274 Useless changes 2024-05-09 01:08:33 +02:00
Han Fei
116055b532 refine load part logic 2024-05-08 15:04:16 +02:00
Han Fei
746e96eddd Merge branch 'master' into hanfei/fix-intersection 2024-05-07 23:54:54 +02:00
Han Fei
13b312092c rewrite load part logic 2024-05-07 23:54:49 +02:00
kssenii
cd093ca793 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-07 12:50:48 +02:00