Commit Graph

5144 Commits

Author SHA1 Message Date
Nikolai Kochetov
98765cc20b Disable delayed streams for Vertical merges for non-remote disks. 2023-02-09 19:39:34 +00:00
alesapin
859f528fe1
Merge pull request #45648 from ClickHouse/45508_Update_strategy_for_system_sync_replica
Updated checking of SYSTEM SYNC REPLICA
2023-02-09 11:51:05 +01:00
Smita Kulkarni
87ec32f235 Updated to use znode_name instead of log_entry_id - Updated checking of SYSTEM SYNC REPLICA 2023-02-08 14:07:06 +01:00
Azat Khuzhin
151ba92a2e Fix reading of non existing nested columns with multiple level in compact parts
Consider the following example:

    CREATE TABLE data (root.array_str Array(UInt8)) ENGINE = MergeTree() ORDER BY tuple();
    INSERT INTO data VALUES ([]);
    ALTER TABLE data ADD COLUMN root.nested_array Array(Array(UInt8));

In this case the first part will not have data for root.nested_array,
and thanks to #37152 it will simply read offsets column from
root.array_str, however since root.nested_array is a nested array, it
will try to read elements from the same offsets stream and if you are
lucky enough you will get one of the following errors:

- Cannot read all data. Bytes read: 1. Bytes expected: 8.: (while reading column root.nested_array): While executing MergeTreeInOrder. (CANNOT_READ_ALL_DATA)
- DB::Exception: Array size is too large: 8233460228287709730: (while reading column serp.serp_features): While executing MergeTreeInOrder.

So to address this, findColumnForOffsets() had been changed to return
the level of the column too, to allow to read only up to this level.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 10:21:40 +01:00
Smita Kulkarni
8c9d994fd7 Extended scope of state_mutex while adding subscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 22:04:17 +01:00
Smita Kulkarni
ecea28a832 Fixed style check - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 17:27:34 +01:00
Nikolai Kochetov
3912f5a333
Merge pull request #45681 from CurtizJ/compact-parts-vertical-merge
Allow vertical merges from compact to wide parts
2023-02-07 17:09:17 +01:00
Smita Kulkarni
34341ddabe Updated locks and removed getLogEntryIds function - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 16:57:58 +01:00
Sema Checherinda
52d4e78b7f
Merge pull request #45907 from CheSema/forbid-wal-on-s3
do not run wal on remote disks
2023-02-07 14:48:00 +01:00
Yakov Olkhovskiy
4e7dffafe4
Merge pull request #46087 from ClickHouse/fix-ip-bloom
Allow bloom filter for IPv4 and IPv6
2023-02-07 08:29:28 -05:00
Smita Kulkarni
fb765696b6 Removed state_mutex lock from addSubscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 12:19:58 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Smita Kulkarni
ef29b61786 Updated callback to return log entry ids - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:02:38 +01:00
Anton Popov
7dfea59267 remove an assertion 2023-02-07 00:50:41 +00:00
Yakov Olkhovskiy
e433c26cf9 allow bloom filter for IPv4 and IPv6 2023-02-06 16:30:18 +00:00
Alexander Tokmakov
e9f770d89d fix 2023-02-06 14:03:14 +01:00
alesapin
b94f9f8006
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica 2023-02-06 12:38:39 +01:00
Sema Checherinda
734d3a318b
const auto ref in the loop 2023-02-06 12:09:33 +01:00
Vitaly Baranov
a3423ce196 Remove unnecessary execute() while evaluating a constant expression. 2023-02-05 20:26:34 +01:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log 2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] (#43772) 2023-02-03 14:34:18 +01:00
Alexey Milovidov
3e3df376c0
Merge pull request #45995 from CurtizJ/check-dynamic-columns
Check dynamic columns of part before its commit
2023-02-03 15:39:54 +03:00
Smita Kulkarni
123f3cfe1f Used unordered_set for log entries and fixed the callback function - Updated checking of SYSTEM SYNC REPLICA 2023-02-03 08:48:16 +01:00
Frank Chen
d38adfab30 Merge two overridden functions as one 2023-02-03 15:27:45 +08:00
flynn
d119367d7d fix 2023-02-03 07:06:58 +00:00
Frank Chen
d3a05a11da Merge remote-tracking branch 'remotes/github/master' into stack_trace_in_part_log 2023-02-03 11:39:43 +08:00
Frank Chen
7af5ae7f2e
Merge branch 'master' into better_postpone_reason 2023-02-03 11:20:37 +08:00
Anton Popov
8ca602a148 check dynamic columns of part before its commit 2023-02-03 02:58:28 +00:00
flynn
bc38ebaf52 use LowCardnality for _part and _partition_id virtual column
fix
2023-02-02 16:20:29 +00:00
Alexander Gololobov
ec3bb0c04e
Merge pull request #45794 from ClickHouse/parallelize_is_storage_touched_by_mutations
Do not restrict count() query to 1 thread in isStorageTouchedByMutations()
2023-02-02 16:44:11 +01:00
Sema Checherinda
7c416477ac do not run wal on remote disks 2023-02-01 20:03:45 +01:00
Sema Checherinda
3e1b17e4cf
fix build 2023-02-01 17:09:43 +01:00
Anton Popov
9f26e16963 loose the assertion 2023-02-01 15:31:06 +00:00
Sema Checherinda
41a1dddc7a
Merge branch 'master' into better_postpone_reason 2023-02-01 15:16:34 +01:00
Anton Popov
1c4174750d fix mistake after refactoring 2023-01-31 15:48:14 +00:00
Alexander Tokmakov
51b0f66e6b
Merge pull request #45793 from ClickHouse/fix_part_check_cancellation
Fix race condition on a part check cancellation
2023-01-31 14:15:17 +03:00
Alexander Gololobov
4eea3de654 Do not restrict count() query to 1 thread in isStorageTouchedByMutations() 2023-01-30 22:29:28 +01:00
Alexander Tokmakov
e42cd3163f fix race condition on a part check cancellation 2023-01-30 18:48:20 +01:00
alesapin
be58d5d1af Fix bug in tables drop which can lead to potential query hung 2023-01-30 17:00:28 +01:00
Smita Kulkarni
6cf2498609 Fixed clang-tidy build for comparing strings and updated to notify after adding subscriber if queue is already empty- Updated checking of SYSTEM SYNC REPLICA 2023-01-30 08:18:20 +01:00
SmitaRKulkarni
809354dc30
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica 2023-01-29 11:28:21 +01:00
Alexey Milovidov
49a59ff9bd Fix bad comment 2023-01-29 03:57:59 +01:00
Smita Kulkarni
9b457a57a9 Fixed clang-tidy build - Updated checking of SYSTEM SYNC REPLICA 2023-01-28 21:43:41 +01:00
Smita Kulkarni
2bbe08ce8b Updated destructor to notify even when queue empty - Updated checking of SYSTEM SYNC REPLICA 2023-01-27 22:37:42 +01:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings 2023-01-27 16:03:00 +01:00
Anton Popov
3f1db52d51 Merge remote-tracking branch 'upstream/master' into compact-parts-vertical-merge 2023-01-27 14:38:37 +00:00
Nikolai Kochetov
313947e0b0
Merge branch 'master' into issue_45590 2023-01-27 15:08:28 +01:00