Commit Graph

75218 Commits

Author SHA1 Message Date
Azat Khuzhin
0e34a9d550 Add MSan instrumentation for preadv2
MSan report [1]:

    ==10672==WARNING: MemorySanitizer: use-of-uninitialized-value
        3 0x30dd6005 in DB::CompressionCodecFactory::get(unsigned char) const obj-x86_64-linux-gnu/../src/Compression/CompressionFactory.cpp:105:65
        4 0x30dab4d5 in DB::CompressedReadBufferBase::readCompressedData(unsigned long&, unsigned long&, bool) obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferBase.cpp:127:53
        5 0x30db54af in DB::CompressedReadBufferFromFile::readBig(char*, unsigned long) obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferFromFile.cpp:119:38

      Uninitialized value was stored to memory at
        0 0x9ef4e99 in __msan_memcpy (/src/ch/tmp/30191/clickhouse-msan+0x9ef4e99)
        1 0xa0c1999 in DB::ReadBuffer::read() obj-x86_64-linux-gnu/../src/IO/ReadBuffer.h:173:13
        2 0xa0c1999 in DB::ReadBuffer::readStrict() obj-x86_64-linux-gnu/../src/IO/ReadBuffer.h:184:27
        3 0x30daafd1 in DB::CompressedReadBufferBase::readCompressedData() obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferBase.cpp:120:20
        4 0x30db54af in DB::CompressedReadBufferFromFile::readBig() obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferFromFile.cpp:119:38

      Uninitialized value was created by a heap allocation
        0 0x9ef5285 in posix_memalign (/src/ch/tmp/30191/clickhouse-msan+0x9ef5285)
        1 0xa0cb98d in Allocator<false, false>::allocNoTrack(unsigned long, unsigned long) obj-x86_64-linux-gnu/../src/Common/Allocator.h:235:27
        2 0xa0caf0d in Allocator<false, false>::alloc(unsigned long, unsigned long) obj-x86_64-linux-gnu/../src/Common/Allocator.h:96:16
        3 0xa0caf0d in DB::Memory<Allocator<false, false> >::alloc() obj-x86_64-linux-gnu/../src/IO/BufferWithOwnMemory.h:126:49
        4 0xa0ca4a1 in DB::Memory<Allocator<false, false> >::Memory() obj-x86_64-linux-gnu/../src/IO/BufferWithOwnMemory.h:43:9
        5 0xa0ca4a1 in DB::BufferWithOwnMemory<DB::SeekableReadBuffer>::BufferWithOwnMemory(unsigned long, char*, unsigned long) obj-x86_64-linux-gnu/../src/IO/BufferWithOwnMemory.h:153:29
        6 0xa0ca4a1 in DB::ReadBufferFromFileBase::ReadBufferFromFileBase() obj-x86_64-linux-gnu/../src/IO/ReadBufferFromFileBase.cpp:11:7
        7 0xa59d980 in DB::AsynchronousReadBufferFromFileDescriptor::AsynchronousReadBufferFromFileDescriptor() obj-x86_64-linux-gnu/../src/IO/AsynchronousReadBufferFromFileDescriptor.h:40:11

    SUMMARY: MemorySanitizer: use-of-uninitialized-value obj-x86_64-linux-gnu/../contrib/libcxx/include/__hash_table:116:10 in std::__1::__constrain_hash(unsigned long, unsigned long)

  [1]: https://clickhouse-test-reports.s3.yandex.net/30191/18bb0e7d8d47dd694390f3f7b2ecc921a167afac/fuzzer_msan/report.html#fail1
2021-10-17 23:54:58 +03:00
Azat Khuzhin
14baed927f Add extensive test for various read settings
The following settings had been covered:
- min_bytes_to_use_direct_io
- local_filesystem_read_method
- local_filesystem_read_prefetch
- read_priority
- max_read_buffer_size
2021-10-17 23:54:58 +03:00
Azat Khuzhin
fb54d6b6e0 BufferWithOwnMemory: take reallocs into account 2021-10-17 23:54:58 +03:00
Azat Khuzhin
348033d8bd BufferWithOwnMemory: make size aligned not capacity
This will fix pread_fake_async/pread_threadpool with min_bytes_to_use_direct_io
2021-10-17 23:54:58 +03:00
Azat Khuzhin
9cc1178ebc BufferWithOwnMemory: do not try to align if buffer already aligned 2021-10-17 23:54:57 +03:00
Azat Khuzhin
34810456e1 Fix alignment for prefetch in AsynchronousReadBufferFromFileDescriptor 2021-10-17 23:54:57 +03:00
Denis Glazachev
9de534f96c Revert special contribs and set folder manually for them until fixed 2021-10-17 23:10:01 +03:00
Denny Crane
084938fa8c
Update external-dicts-dict-layout.md 2021-10-17 16:28:22 -03:00
Denny Crane
eb66442feb
Update external-dicts-dict-layout.md 2021-10-17 16:21:21 -03:00
Kseniia Sumarokova
a8a7ba9005
Update 02051_symlinks_to_user_files.sh 2021-10-17 22:09:17 +03:00
Denis Glazachev
68a08ffed9
Merge branch 'master' into reorganiza-contrib-ide-folders 2021-10-17 22:13:11 +04:00
alexey-milovidov
8defd0ab89
Merge pull request #30298 from ClickHouse/riscv
Add RISC-V build
2021-10-17 21:03:55 +03:00
alexey-milovidov
7beffb04ad
Merge pull request #29495 from ClickHouse/improvement_for_strange_mutations
Minor improvement for strange mutations
2021-10-17 20:57:06 +03:00
alexey-milovidov
0ce1462f1c
Merge pull request #30295 from traceon/misc-install-fixes
Various fixes to install procedure
2021-10-17 20:55:08 +03:00
alexey-milovidov
f4bfed9d3a
Merge pull request #29586 from evillique/log_levels_update
Add log levels updates
2021-10-17 20:54:46 +03:00
Alexey Milovidov
301caa8091 Update test 2021-10-17 20:52:21 +03:00
alexey-milovidov
00bb647c3a
Merge pull request #29836 from FedericoCeratto/patch-1
Link FAQ from Debian installation
2021-10-17 20:49:26 +03:00
Kseniia Sumarokova
5dab184d8b
Update 02051_symlinks_to_user_files.sh 2021-10-17 18:21:43 +03:00
Kseniia Sumarokova
5633865df1
Update src/Storages/StorageFile.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2021-10-17 14:16:40 +03:00
Nikolai Kochetov
2a95d7fc87
Merge pull request #29918 from amosbird/projection-improve5
Add primary key to minmax_count_projection
2021-10-17 14:04:18 +03:00
Nikolai Kochetov
8ab5270ded
Merge pull request #30247 from ClickHouse/removing-data-streams-folder
Removing data streams folder
2021-10-17 13:55:11 +03:00
Kseniia Sumarokova
07b44713b6
Ping CI 2021-10-17 13:45:32 +03:00
Kseniia Sumarokova
cd22ca6167
Update filesystemHelpers.h 2021-10-17 13:13:47 +03:00
Kseniia Sumarokova
e1969e2693
Merge pull request #30288 from kssenii/fix-local-syntax-exception
Fix throwing syntax exception in clickhouse-local
2021-10-17 12:16:40 +03:00
kssenii
059fc1de69 Allow symlinks in file storage 2021-10-17 09:11:06 +00:00
Nikolai Kochetov
bfcbf5abe0 Merge branch 'master' into removing-data-streams-folder 2021-10-17 10:42:37 +03:00
alexey-milovidov
57f548dfb0
Merge pull request #30297 from kssenii/fix-local-break-on-timeout
Fix clickhouse-local break on timeout
2021-10-17 07:36:59 +03:00
Alexey Milovidov
c2faf450d1 Fix error 2021-10-17 06:37:51 +03:00
WangZengrui
131aa77017 fix style 2021-10-17 11:21:58 +08:00
alexey-milovidov
3e9cf0b5ba
Merge pull request #30243 from Algunenano/multiIf_shortcircuit_fix
Fix crash with shortcircuit and LowCardinality in multiIf
2021-10-17 06:16:09 +03:00
Alexey Milovidov
04d8f611d2 Merge branch 'master' into clickhouse-obfuscator-2 2021-10-17 05:52:13 +03:00
Alexey Milovidov
0285a15aec Minor changes to install script 2021-10-17 05:52:00 +03:00
Amos Bird
b034c913db
update 2021-10-17 10:41:51 +08:00
alexey-milovidov
4f11cfa59d
Merge pull request #28760 from azat/mutator-forbid-cleaner
Forbid cleaning of tmp directories that can be used by an active mutation/merge.
2021-10-17 03:18:01 +03:00
alexey-milovidov
b253f6122a
Merge pull request #30218 from azat/clickhouse-test-fix-hung-check
Fix --hung-check in clickhouse-test
2021-10-17 03:15:51 +03:00
Denis Glazachev
ceb98cf42f
Add comments 2021-10-17 03:04:53 +04:00
alexey-milovidov
e3b612ada5
Merge pull request #30294 from den-crane/patch-33
Doc. ArgMax/Min are not supported anymore by SimpleAggregateFunction
2021-10-17 01:32:31 +03:00
Alexey Milovidov
5fc2279adf Add RISC-V build 2021-10-17 01:23:55 +03:00
Maksim Kita
0dd8c70d28
Merge pull request #30242 from kitaisreal/added-hashed-array-dictionary
Added HashedArray dictionary
2021-10-17 01:18:43 +03:00
Maksim Kita
36beb89857
Merge pull request #30296 from den-crane/patch-34
Doc. Fix quota_key naming
2021-10-17 01:18:32 +03:00
kssenii
4390dde76c Fix local break on timeout 2021-10-16 19:50:05 +00:00
Denny Crane
5e0e0a3946
Update quotas.md 2021-10-16 16:22:19 -03:00
Denny Crane
443efe8f5c
Update quotas.md 2021-10-16 16:21:18 -03:00
kssenii
8b0359584a Update test 2021-10-16 19:08:37 +00:00
kssenii
d34d752688 Fix tests 2021-10-16 18:37:46 +00:00
Raúl Marín
662b5d40e9 Adjust the tests to do less work 2021-10-16 20:35:41 +02:00
Denis Glazachev
329d81a0ef Various fixes to install procedure 2021-10-16 20:03:45 +03:00
WangZengrui
bd2c016cf3 fix bug 2021-10-17 00:33:57 +08:00
Maksim Kita
de36038733
Merge pull request #30276 from azat/buffer-fwd-decl
Use forward declaration for Buffer<> in generic headers
2021-10-16 19:21:38 +03:00
Denny Crane
434de66a2b
Doc. ArgMax/Min are not supported anymore by SimpleAggregateFunction 2021-10-16 12:59:01 -03:00