Commit Graph

107364 Commits

Author SHA1 Message Date
kssenii
40deaf1661 Fix clang-tidy 2023-02-07 16:30:04 +01:00
MeenaRenganathan22
2445a391fb Updating the libhdfs3 to reflect the revert of PR#21 2023-02-07 09:05:12 -05:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan 2023-02-07 14:55:55 +01:00
Sema Checherinda
52d4e78b7f
Merge pull request #45907 from CheSema/forbid-wal-on-s3
do not run wal on remote disks
2023-02-07 14:48:00 +01:00
Yakov Olkhovskiy
4e7dffafe4
Merge pull request #46087 from ClickHouse/fix-ip-bloom
Allow bloom filter for IPv4 and IPv6
2023-02-07 08:29:28 -05:00
Yakov Olkhovskiy
909a772701
Merge pull request #45375 from ClibMouse/window_view_fix
Window view functional test failed on platform s390x
2023-02-07 08:23:50 -05:00
Sema Checherinda
750e7bfcb9
allow_drop_detached requires an argument 2023-02-07 13:46:00 +01:00
Vitaly Baranov
6555b48132 Disable evaluating the right part of IN operator while analyzing dependencies. 2023-02-07 13:21:30 +01:00
Han Fei
021e6e90cc
Merge pull request #45631 from hanfei1991/hanfei/regexp-refine
RegExpTreeDict use re2 engines when processing heavy regexps
2023-02-07 13:21:22 +01:00
Vitaly Baranov
324b0b6896 Fix DDLDependencyVisitor for an empty table name. 2023-02-07 13:21:18 +01:00
Azat Khuzhin
ec171c1732 Improve abortOnFailedAssertion() usage from chassert()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 13:03:47 +01:00
kssenii
022d4308ce Address review comments 2023-02-07 13:01:55 +01:00
Azat Khuzhin
bca85c6852 Fix test_merge_tree_azure_blob_storage::test_zero_copy_replication test
Here is an example of an error [1]:

    2023.02.06 21:59:09.076849 [ 200 ] {} <Information> DiskObjectStorage(DiskAzureBlobStorage): Starting up disk blob_storage_disk
    2023.02.06 21:59:09.076897 [ 200 ] {} <Information> DiskObjectStorage(DiskAzureBlobStorage): Disk blob_storage_disk started up
    2023.02.06 21:59:09.077263 [ 200 ] {} <Trace> StoragePolicy (blob_storage_policy): Storage policy blob_storage_policy created, total volumes 1
    2023.02.06 21:59:09.077318 [ 200 ] {} <Information> StoragePolicySelector: Storage policy `blob_storage_policy` loaded
    ...
    2023.02.06 21:59:09.227326 [ 1 ] {} <Error> Application: std::exception. Code: 1001, type: Azure::Storage::StorageException, e.what() = 409 The specified container already exists.
    The specified container already exists.
    RequestId:73d54dcf-0c66-489c-b9b8-2b5398df9384
    Time:2023-02-06T21:59:08.225Z
    Request ID: 73d54dcf-0c66-489c-b9b8-2b5398df9384, Stack trace (when copying this message, always include the lines below):

    0. ./build_docker/../contrib/llvm-project/libcxx/include/exception:134: std::runtime_error::runtime_error() @ 0x44297b8d in /usr/bin/clickhouse
    ...
    5. ./build_docker/../contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714: DB::getAzureBlobContainerClient() @ 0x2f5b225f in /usr/bin/clickhouse
    6. ./build_docker/../src/Disks/ObjectStorages/AzureBlobStorage/registerDiskAzureBlobStorage.cpp:0:
    10. ./build_docker/../src/Interpreters/Context.cpp:0: DB::Context::getDisksMap() const @ 0x2f95af47 in /usr/bin/clickhouse
    ...
    13. ./build_docker/../contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714: DB::AsynchronousMetrics::start() @ 0x1f4d6161 in /usr/bin/clickhouse
    14. ./build_docker/../programs/server/Server.cpp:0: DB::Server::main() @ 0x1f3a5bfb in /usr/bin/clickhouse
    15. ./build_docker/../contrib/poco/Util/src/Application.cpp:0: Poco::Util::Application::run() @ 0x3c7546bf in /usr/bin/clickhouse
    16. ./build_docker/../programs/server/Server.cpp:476: DB::Server::run() @ 0x1f381f7b in /usr/bin/clickhouse
    17. ./build_docker/../contrib/poco/Util/src/ServerApplication.cpp:612: Poco::Util::ServerApplication::run(int, char**) @ 0x3c797ee0 in /usr/bin/clickhouse
    18. ./build_docker/../programs/server/Server.cpp:0: mainEntryClickHouseServer(int, char**) @ 0x1f37a262 in /usr/bin/clickhouse
    19. ./build_docker/../programs/main.cpp:0: main @ 0xe9d21ae in /usr/bin/clickhouse
    20. __libc_start_main @ 0x7f58271a1083 in ?
    21. _start @ 0xe90ef6e in /usr/bin/clickhouse
     (version 23.2.1.1)
    2023.02.06 21:59:09.227971 [ 1 ] {} <Error> Application: 409 The specified container already exists.
    The specified container already exists.
    RequestId:73d54dcf-0c66-489c-b9b8-2b5398df9384
    Time:2023-02-06T21:59:08.225Z
    Request ID: 73d54dcf-0c66-489c-b9b8-2b5398df9384

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/46045/bd4170e03c6af583a51d12d2c39fa775dcb9997b/integration_tests__asan__[6/6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 12:52:36 +01:00
Azat Khuzhin
fe832c4418 Fix TOCTOU while checking for container existence in azure_blob_storage
This is a simple time-of-check vs time-of-use, since between checking
does such container exist and creating one, there is a time window.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 12:51:06 +01:00
kssenii
9485873a2f Fix integration test 2023-02-07 12:45:23 +01:00
kssenii
427f2d0257 Try fix rabbit test 2023-02-07 12:36:25 +01:00
Smita Kulkarni
fb765696b6 Removed state_mutex lock from addSubscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 12:19:58 +01:00
Robert Schulze
690d873126
Merge pull request #46088 from ClickHouse/rs/fix-liburing-build
Fix build with `-DENABLE_LIBURING=0` (or `-DENABLE_LIBRARIES=0`)
2023-02-07 12:16:14 +01:00
Sergei Trifonov
950c04cb0e
Merge pull request #44907 from azat/dist/async-INSERT-error-message-fix
Fix error message for a broken distributed batches ("While sending batch")
2023-02-07 12:14:52 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Robert Schulze
f9b6c10700
Merge pull request #46072 from ClickHouse/rs/follow-up-to-46057
Smallish follow-up to #46057
2023-02-07 11:52:51 +01:00
Azat Khuzhin
6587d11885 Check return value of close() in self-extracting-executable
And also add description into perror() over callign simply
perror(nullptr).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
taiyang-li
f41f41c78c fix doc; enable int type for pad 2023-02-07 18:25:36 +08:00
Kseniia Sumarokova
e6e482201c
Merge pull request #46078 from ClickHouse/kssenii-patch-6
Disable temporarily rabbitmq tests which use channel.startConsuming()
2023-02-07 11:17:27 +01:00
taiyang-li
59d4136142 fix fast tests 2023-02-07 17:29:13 +08:00
Smita Kulkarni
135615cda6 Removed unwanted check from before callback - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:27:45 +01:00
Smita Kulkarni
ef29b61786 Updated callback to return log entry ids - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:02:38 +01:00
Smita Kulkarni
f34ef86332 Moved background task trigger before getting log entries to wait - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 08:49:41 +01:00
Vitaly Baranov
1fc82fbeec Fix test 01114_database_atomic (more rows to fit to execution time expected in test). 2023-02-07 02:31:58 +01:00
Vitaly Baranov
bc63042723 Fix test "00626_in_syntax" (elements of set after IN must be const). 2023-02-07 02:31:58 +01:00
Vitaly Baranov
d27a83ee21 Fix error code in test "01934_constexpr_aggregate_function_parameters" (parameter of groupArray must be const). 2023-02-07 02:31:58 +01:00
Vitaly Baranov
db500b856f Fix test "01834_alias_columns_laziness_filimonov" (no more sleeping in ExpressionAnalyzer). 2023-02-07 02:31:58 +01:00
Anton Popov
7dfea59267 remove an assertion 2023-02-07 00:50:41 +00:00
Alexander Tokmakov
bd68612f10
Merge pull request #46077 from ClickHouse/fix_test_00002
Fix 00002_log_and_exception_messages_formatting
2023-02-07 03:27:07 +03:00
Alexander Tokmakov
13da43ead8
Merge branch 'master' into fix_test_00002 2023-02-07 03:25:42 +03:00
Anton Popov
e1581a0d63 remove test 2023-02-06 22:22:48 +00:00
Anton Popov
3ad5a085da
Merge pull request #45987 from CurtizJ/fix-sparse-columns-crash
Fix `INTERSECT` and `EXCEPT` with sparse columns
2023-02-06 23:01:02 +01:00
Alexey Milovidov
6a389eef32
Add a comment 2023-02-06 22:27:46 +03:00
Azat Khuzhin
0ab351c82e Add close() return value check in check-style
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:20:15 +01:00
Azat Khuzhin
fc48f89b76 Improve chassert() macro to suppress warning in release builds
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:17 +01:00
Azat Khuzhin
e83163e25f Add sanity check of evtimer_del() in QueryProfiler
Saw this one time on CI with EINVAL [1], while this was EINVAL this
time, next time it can be completelly different fd and break something
in a different place.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:05 +01:00
Azat Khuzhin
ad3b4da488 Add also last messages from stdout/stderr/debuglog in clickhouse-test
First lines not very helpful usually, since the problem usually happens
at the end [1], though some tricky stuff may happens at the beginning,
so let's output both.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 19:47:44 +01:00
Rich Raposa
07545d7386
Merge pull request #46048 from ClickHouse/add-executable-engine
Add docs for Executable and ExecutablePool table engines
2023-02-06 12:36:57 -06:00
rfraposa
f3136e3f25 Resolve feedback 2023-02-06 10:48:54 -07:00
Han Fei
d1d893275a fix 2023-02-06 18:46:23 +01:00
Robert Schulze
8840aa9242
Fix build with -DENABLE_LIBURING=0 (or -DENABLE_LIBRARIES=0)
Follow-up to #38456

The problem was that code which uses liburing was conditionally build
depending on define OS_LINUX and not based on whether liburing was
enabled/disabled at build time.
2023-02-06 16:57:42 +00:00
Yakov Olkhovskiy
e433c26cf9 allow bloom filter for IPv4 and IPv6 2023-02-06 16:30:18 +00:00
Han Fei
eb76041312 address comments and add one more test 2023-02-06 17:26:20 +01:00
Alexander Tokmakov
af655eb7dc
Merge pull request #45889 from CheSema/release-merge-blocker-drop-part
do not block merges when old parts are droping in drop queries
2023-02-06 19:09:09 +03:00