Commit Graph

82 Commits

Author SHA1 Message Date
Sergei Trifonov
376e556474
Merge pull request #36861 from Vxider/fix-fire-hop-window
Fix fire in window view with hop window
2022-05-10 09:25:24 +02:00
Kseniia Sumarokova
fac59dfd97
Merge pull request #36998 from Vxider/removing-replacing-wv-transform
Removing ReplacingWindowColumnTransform in WindowView
2022-05-08 12:11:44 +02:00
Vxider
aab6b1e8b5 update code style 2022-05-07 17:33:42 +00:00
Vxider
72a634b5c6 removing-replacing-window-column-transform 2022-05-07 08:41:51 +00:00
Vxider
1966bb6504 fix stuck when drop source table in windowview 2022-05-06 12:34:00 +00:00
mergify[bot]
eba26ec956
Merge branch 'master' into fix-fire-hop-window 2022-05-05 13:11:34 +00:00
Vxider
407c14251a simplify code 2022-05-04 20:56:09 +08:00
vxider
0617ce01c9
simplify code
Co-authored-by: Sergei Trifonov <svtrifonov@gmail.com>
2022-05-04 20:51:12 +08:00
Vxider
ecca2f23f7 simplify code 2022-05-04 04:02:13 +00:00
Vxider
afbdb8fccc fix fire in hop window 2022-05-03 12:42:42 +08:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
   previously allowed.

Hence, this change

- removes shared_ptr_helper and as a result all inherited create() methods,

- instead, Storage objects are now created using make_shared<>() by the
  caller (for that to work, many constructors had to be made public), and

- all Storage classes were marked as noncopyable using boost::noncopyable.

In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"

About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.

About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.

Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
fenglv
cac2df914b fix 2022-04-10 17:28:17 +00:00
fenglv
24e86f81cb Fix window view when is proc time and window kind larger than day
fix
2022-04-10 17:26:09 +00:00
fenglv
97523a3329 Try remove unneed variable 2022-04-01 09:58:23 +00:00
mergify[bot]
e11ef05c2b
Merge branch 'master' into issue_33147 2022-03-21 13:40:17 +00:00
Vxider
06469eb793 remove blank row 2022-02-24 14:16:24 +08:00
Vxider
43475f79bf windowview_multi_column_groupby 2022-02-24 14:06:37 +08:00
zvonand
dcc0f53f8e updated Interval definitions 2022-02-13 17:54:03 +03:00
zvonand
9456d89fad Move current work from old laptop
skip-checks: true
2022-02-07 21:44:14 +03:00
Vxider
13cee6c184 update code style 2022-01-19 02:24:27 +00:00
mergify[bot]
f2da296990
Merge branch 'master' into windowview-stream-table-join 2022-01-19 02:08:52 +00:00
Vxider
ba0a702807 enable stream to table join in windowview 2022-01-18 09:20:15 +00:00
Vxider
f526ff2a51 remove unused variable 2022-01-18 09:03:16 +00:00
Azat Khuzhin
aee034a597 Use explicit template instantiation for SystemLog
- Move some code into module part to avoid dependency from IStorage in SystemLog
- Remove extra headers from SystemLog.h
- Rewrite some code that was relying on headers that was included by SystemLog.h

v2: rebase
v3: squash move into module part with explicit template instantiation
    (to make each commit self compilable after rebase)
2022-01-10 22:01:41 +03:00
Kseniia Sumarokova
0a1300d32a
Merge pull request #33340 from Vxider/fix-windowview-inner-table-parser
Fix inner table parser in window view
2022-01-10 09:45:17 +03:00
Vxider
ab593d24f3 update code style 2022-01-10 02:16:07 +00:00
feng lv
90a61b84e5 fix misleading log message 2022-01-06 12:48:38 +00:00
Vxider
3761994f68 fix inner table parser in window view 2021-12-31 07:07:01 +00:00
Vxider
f6dceb53a5 small update 2021-12-13 02:38:16 +00:00
Vxider
7eb18ea21e watch events support for window view 2021-12-12 07:45:55 +00:00
Kseniia Sumarokova
f5e949b88e
Ping CI 2021-12-10 18:12:27 +03:00
vxider
52fa82b4d4 rename window-view function to time window function 2021-12-10 09:43:44 +00:00
vxider
c4c517bb8a rename window functions 2021-12-07 08:14:00 +00:00
vxider
b68136d1e4 small code style update 2021-12-06 07:12:21 +00:00
vxider
78ceb5c883 add illegal arg check 2021-12-04 14:18:10 +00:00
vxider
c522c06755 fix windowview parser 2021-12-04 12:30:04 +00:00
kssenii
adaa32b41b Fix inner table name 2021-12-03 15:52:57 +03:00
kssenii
0470525ea3 Fix 2021-12-03 13:39:27 +03:00
kssenii
f658a8c181 Small simplification, some comments 2021-11-30 11:16:24 +03:00
kssenii
b0415b6482 Fix tests under Replicated database engine 2021-11-29 23:34:52 +03:00
vxider
e27a158b92 fix typo 2021-11-27 17:53:07 +00:00
kssenii
29579962cb Update test, tiny changes 2021-11-24 12:55:36 +03:00
kssenii
4c41e719ed Add comments 2021-11-22 18:09:45 +03:00
kssenii
05c548035f Some fixes 2021-11-22 11:04:04 +03:00
kssenii
fda66adf52 Correct merge with master 2021-11-20 13:47:55 +03:00
kssenii
5c9509d68b Fix attach 2021-11-20 12:03:39 +03:00
kssenii
9bdad8ab64 Rewrite from DataStreams to Processors 2021-11-19 16:09:12 +03:00
Vxider
3a5b0632c9 Merged with master 2021-06-01 07:39:42 +00:00