Commit Graph

5631 Commits

Author SHA1 Message Date
Sema Checherinda
bc107c70fa merge and mutation make thread group for setting memory trackers right 2023-03-24 19:53:16 +01:00
kssenii
16ebfcc3f8 Better delegate disks handle mutual path 2023-03-24 16:21:19 +01:00
Nikolai Kochetov
a2182f2659
Merge pull request #47874 from amosbird/correct_exact_rows_before_limit
Correct `exact_rows_before_limit` in some scenarios
2023-03-24 15:09:42 +01:00
Alexander Tokmakov
4dde73c3eb
Merge pull request #47917 from ClickHouse/fix_terminate_in_check_thread
Fix terminate in parts check thread
2023-03-24 04:22:00 +03:00
Nikolai Kochetov
73e98de46d Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-03-23 21:28:36 +01:00
ltrk2
f46970671d Implement tokenbf_v1 index utilization for hasTokenCaseInsensitive 2023-03-23 12:24:13 -07:00
Maksim Kita
24b9e5103f
Merge pull request #47748 from ClickHouse/revert-47721-revert-47622-analyzer-planner-fixes-before-enable-by-default
Revert "Revert "Analyzer planner fixes before enable by default""
2023-03-23 22:20:34 +03:00
Alexander Tokmakov
5b263b9ffe fix 2023-03-23 15:36:17 +01:00
Maksim Kita
7da53bf7e8 Fixed tests 2023-03-23 12:34:23 +01:00
robot-ch-test-poll3
a31c0d8eee
Merge pull request #47883 from ClickHouse/drop-column-with-projections
Fix DROP COLUMN with ReplicatedMergeTree containing projections
2023-03-22 23:55:16 +01:00
Alexander Tokmakov
e3c798bae5 fix terminate in parts check thread 2023-03-22 23:46:15 +01:00
Maksim Kita
f45dac99c2 Revert "Revert "Analyzer planner fixes before enable by default"" 2023-03-22 17:19:32 +01:00
Nikolai Kochetov
d7d3722b76 Revert analyzer till later. 2023-03-22 15:41:54 +00:00
Amos Bird
02c5d1f364
Correct exact_rows_before_limit in all senarios 2023-03-22 23:26:31 +08:00
Antonio Andelic
b832840cf3 Recalculate always projections on mutations in ReplicatedMergeTree 2023-03-22 11:21:23 +00:00
Alexander Tokmakov
c114361879
Update MergeTreeData.h 2023-03-21 23:15:59 +03:00
Alexander Tokmakov
8a71e42f08
Merge pull request #47769 from HarryLeeIBM/hlee-s390x-partid
Fix partition ID byte order for s390x
2023-03-21 23:01:36 +03:00
Alexander Tokmakov
0989dd837a
Merge pull request #47802 from ClickHouse/fix_some_tests
Fix 993 and two other tests
2023-03-21 22:20:06 +03:00
Nikolai Kochetov
b432fa1122 Attempt to use new analyzer. 2023-03-21 17:56:58 +00:00
Antonio Andelic
ed3f51d9b3 Merge branch 'master' into avoid-merging-partition 2023-03-21 10:46:03 +00:00
Vladimir C
5add1e1b2e
Merge pull request #47684 from ClickHouse/vdimir/improve_log_queries_cut 2023-03-21 11:17:54 +01:00
Alexander Tokmakov
d5a561a2ef fix 993 and two other tests 2023-03-20 22:51:32 +01:00
Robert Schulze
595796e63d
Merge branch 'master' into rs/more-llvm-16-preparation 2023-03-20 21:16:27 +01:00
HarryLeeIBM
ed1ff02114 Fix partition ID byte order for s390x 2023-03-20 14:19:27 -04:00
vdimir
bb7a8ed862
Apply log_queries_cut_to_length in MergeTreeWhereOptimizer 2023-03-20 15:38:09 +00:00
Igor Nikonov
1073c7f3c9 Revert "Actually stop retries in case of storage shutdown"
This was unnecessary since, as for exceptions, retries done only on
zkutil::KeeperException

This reverts commit 795a1c84e1.
2023-03-20 13:54:25 +00:00
Igor Nikonov
795a1c84e1 Actually stop retries in case of storage shutdown 2023-03-20 13:48:04 +00:00
Igor Nikonov
1098055409 Stop wait for quorum retries on shutdown 2023-03-20 13:21:10 +00:00
Robert Schulze
5b036a1a3b
More preparation for libcxx(abi), llvm, clang-tidy 16 (follow-up to #47722) 2023-03-20 12:55:03 +00:00
Raúl Marín
fb6ce35ea2 Fix ZK exception error message 2023-03-20 13:00:24 +01:00
Alexey Milovidov
ddf29b69f9
Merge branch 'master' into fuzzer-of-data-formats 2023-03-20 03:26:51 +03:00
Alexey Milovidov
e788bf0712
Merge pull request #47721 from ClickHouse/revert-47622-analyzer-planner-fixes-before-enable-by-default
Revert "Analyzer planner fixes before enable by default"
2023-03-20 03:24:03 +03:00
Robert Schulze
0e01e912fe
Preparation for libcxx(abi), llvm, clang-tidy 16 2023-03-19 17:25:41 +00:00
Alexey Milovidov
ef5e8462da
Revert "Analyzer planner fixes before enable by default" 2023-03-19 19:25:37 +03:00
Alexey Milovidov
a99f10e16f Better error messages 2023-03-19 05:34:44 +01:00
Alexander Tokmakov
f1df91cd09
Merge pull request #47659 from ClickHouse/fix_993
Fixes for 993 and friends
2023-03-18 14:46:43 +03:00
Maksim Kita
5187138510
Merge pull request #47622 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
Analyzer planner fixes before enable by default
2023-03-18 13:11:40 +03:00
Sema Checherinda
0b641fcead
Merge pull request #47564 from CheSema/remove-redundant
remove counters for threads, fix negative counters
2023-03-18 02:23:52 +01:00
Han Fei
722e6bb2e8
Merge pull request #47680 from ClickHouse/rs/uncruftify-build
CMake: Remove further cruft from build
2023-03-17 22:58:46 +01:00
Alexander Tokmakov
d11aee2b0c
Merge branch 'master' into fix_993 2023-03-17 21:28:23 +03:00
alesapin
e45b558a86
Merge pull request #47676 from ClickHouse/fix_zero_copy_lock_check
Fix zero copy lock check
2023-03-17 17:51:14 +01:00
alesapin
1022c47421 Review fixes 2023-03-17 17:45:02 +01:00
Antonio Andelic
79cff0a14b Merge branch 'master' into cnf-new-analyzer 2023-03-17 14:37:40 +00:00
Robert Schulze
f72a337074
Remove cruft from build
No need to check compiler flags, clang >= 15 supports all of them.
2023-03-17 13:44:04 +00:00
Antonio Andelic
0fb9f9ffe6 Add support for substitute column 2023-03-17 13:38:01 +00:00
Maksim Kita
2d2696bc20 Fixed code review issues 2023-03-17 14:34:23 +01:00
alesapin
e44fca8bb9 Add test 2023-03-17 12:56:31 +01:00
Sergei Trifonov
1a84203c7f
Merge pull request #47656 from ClickHouse/background_pool_limit_metric
Add background pools size metrics
2023-03-17 11:49:53 +01:00
alesapin
4a80197f16 Merge branch 'master' into fix_zero_copy_lock_check 2023-03-17 11:18:51 +01:00
alesapin
efa0622a84
Merge pull request #47631 from ClickHouse/fix_wait_for_zero_copy_lock
Fix wait for zero copy lock during move
2023-03-17 11:15:55 +01:00
Sergei Trifonov
2cbd91b852
Merge branch 'master' into background_pool_limit_metric 2023-03-16 23:23:42 +01:00
alesapin
3731567b6a Bad code 2023-03-16 21:48:47 +01:00
Robert Schulze
02a2c73bae
Merge pull request #47607 from save-my-heart/inverted_index
checksum: do not check inverted index files
2023-03-16 21:34:17 +01:00
Alexander Tokmakov
d621b2c4ad fix intersecting parts, better fault injections 2023-03-16 21:28:07 +01:00
alesapin
92eb6685c6 Fix lock check 2023-03-16 20:17:29 +01:00
Sema Checherinda
3c6deddd1d work with comments on PR 2023-03-16 19:55:58 +01:00
serxa
3ad7194e31 add pool size metrics 2023-03-16 17:31:41 +00:00
Antonio Andelic
985a0285c7 Merge branch 'master' into cnf-new-analyzer 2023-03-16 16:00:51 +00:00
Alexander Tokmakov
8b8215f91a fix some other tests, add logs for further debugging 2023-03-16 16:40:08 +01:00
Antonio Andelic
0f6e4d3934 Start implementing constraint optimizer 2023-03-16 09:30:55 +00:00
alesapin
fc913649cf Check only for interactive moves 2023-03-15 22:51:53 +01:00
alesapin
ef7508469c Fix wait for zero-copy replication move during manual move 2023-03-15 22:29:24 +01:00
Maksim Kita
c102adb728 Analyzer added PREWHERE support 2023-03-15 15:21:49 +01:00
save-my-heart
b7d9d721fb add test 2023-03-15 21:01:12 +08:00
Vitaly Baranov
00c05f7f8b
Merge pull request #47546 from vitlibar/use-server-side-copy-for-restore
Use server-side copy for restore from S3 to S3.
2023-03-15 11:28:29 +01:00
save-my-heart
d70c352313 checksum: do not check inverted index files 2023-03-15 16:43:59 +08:00
Alexander Tokmakov
5a1ee881f8
Merge pull request #47547 from ClickHouse/filter_too_frequent_logs
Hide too noisy log messages, fix some tests
2023-03-14 13:53:21 +03:00
Michael Kolupaev
d3a514d221 Compress marks in memory 2023-03-13 16:29:00 -07:00
Alexander Tokmakov
ba6c6255a3 hide too noisy log messages, fix some tests 2023-03-14 00:23:36 +01:00
Vitaly Baranov
1cf1ce07fe Use server-side copy during restore from S3 to S3. 2023-03-13 23:50:13 +01:00
Nikolai Kochetov
669a92bae0 Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-03-13 19:55:49 +01:00
alesapin
8db0d26519
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang 2023-03-13 14:48:20 +01:00
Alexey Milovidov
218ac10425 More detailed error messages on too many parts 2023-03-11 21:44:38 +01:00
Maksim Kita
114d30d2bb
Merge pull request #47383 from kitaisreal/analyzer-planner-fixes-before-enable-by-default
Analyzer planner fixes before enable by default
2023-03-11 22:09:04 +03:00
Maksim Kita
3d34247998 Fixed tests 2023-03-11 11:51:54 +01:00
Maksim Kita
0358cb36d8 Fixed tests 2023-03-11 11:51:54 +01:00
Alexander Tokmakov
6e7ffd9a7b
Update ReplicatedMergeTreeAttachThread.cpp 2023-03-11 00:45:09 +03:00
Dmitry Novik
4f24a7bd11 Merge remote-tracking branch 'origin/master' into background-memory-tracker 2023-03-10 18:57:45 +00:00
Anton Popov
66a113ca61
Merge pull request #47384 from CurtizJ/fix-clear-column-with-sparse
Fix `ALTER CLEAR COLUMN` with sparse columns
2023-03-09 16:57:23 +01:00
alesapin
588cc0f159
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang 2023-03-09 14:54:10 +01:00
Anton Popov
c3b9af96c4 fix ALTER CLEAR COLUMN with sparse columns 2023-03-08 17:19:04 +00:00
Antonio Andelic
a04b38db90
Merge pull request #45108 from ClickHouse/custom-key-parallel-replicas
Add support for custom key in parallel replicas
2023-03-08 17:46:11 +01:00
Alexander Tokmakov
38f9f08e1a
Merge pull request #47268 from myrrc/improvement/more-to-base-3
use std::lerp, constexpr hex.h
2023-03-08 19:07:34 +03:00
alesapin
4423be8332
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang 2023-03-08 12:59:07 +01:00
Antonio Andelic
816a9c1099
Merge branch 'master' into custom-key-parallel-replicas 2023-03-08 11:06:30 +01:00
Alexey Milovidov
e8cdb0c8b1
Merge pull request #46839 from CurtizJ/fix-crash-in-skip-index
Do not allow const and non-deterministic secondary indexes
2023-03-08 03:03:09 +03:00
Alexey Milovidov
e2aff59a2d
Merge pull request #47106 from kssenii/allow-nested-disks-in-custom-disks
Allow nested custom disks
2023-03-08 03:00:55 +03:00
Mike Kot
9920a52c51 use std::lerp, constexpr hex.h 2023-03-07 22:50:17 +00:00
Antonio Andelic
d098891185 Skip merges if no need 2023-03-07 13:08:56 +00:00
Antonio Andelic
35c15e6ef8 Merge branch 'master' into custom-key-parallel-replicas 2023-03-07 09:37:38 +00:00
Vladimir C
1455e7602d
Merge pull request #47154 from azat/prewhere-columns-fix 2023-03-06 10:03:31 +01:00
Anton Popov
6f3e4d4137
Merge pull request #46118 from CurtizJ/fix-issues-with-sparse
Randomize setting `ratio_of_defaults_for_sparse_serialization`
2023-03-05 22:28:18 +01:00
Robert Schulze
10753481f9
Merge pull request #47242 from ClickHouse/rs/docs-index-support-has-hasall-hasany
Docs: Update index support of has(), hasAny(), hasAll()
2023-03-04 18:49:24 +01:00
Robert Schulze
11930ad685
Docs: Update index support of has(), hasAny(), hasAll() 2023-03-04 17:27:47 +00:00
Anton Popov
9389cc29da better mutations of sparse columns 2023-03-03 16:52:01 +00:00
Antonio Andelic
737cf8e149 Better 2023-03-03 15:14:49 +00:00
Sema Checherinda
7a9f4aab8e do not call adjustWithUntrackedMemory when untracked_memory is 0 2023-03-02 19:21:03 +01:00
alesapin
63f615cdcd Fix metadata version 2023-03-02 19:17:18 +01:00
Azat Khuzhin
167e4903a8 Fix concrete columns PREWHERE support
This is the fix for the IStorage::supportedPrewhereColumns() API.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-02 18:51:23 +01:00
Anton Popov
fdf8a418f5 better interface 2023-03-02 14:46:26 +00:00
Antonio Andelic
01cf9c94f4 Merge branch 'master' into custom-key-parallel-replicas 2023-03-02 14:28:42 +00:00
Robert Schulze
740aeaba1f
Apply some CTAD 2023-03-02 13:36:47 +00:00
kssenii
2883861795 Merge remote-tracking branch 'upstream/master' into allow-nested-disks-in-custom-disks 2023-03-02 14:30:58 +01:00
alesapin
915b4ea56a
Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang 2023-03-02 14:29:21 +01:00
alesapin
db0f9b6578 Fix one more bug 2023-03-02 14:26:07 +01:00
alesapin
189836307c Merge branch 'revert-46909-revert-45911-mutations_rename_hang' of github.com:ClickHouse/ClickHouse into revert-46909-revert-45911-mutations_rename_hang 2023-03-02 12:49:06 +01:00
Alexey Milovidov
97c0f8a0e0
Merge pull request #47027 from amosbird/clang16
Prepare to build with clang 16
2023-03-02 02:10:03 +03:00
Anton Popov
c4a999ce29 Merge remote-tracking branch 'upstream/master' into HEAD 2023-03-01 19:33:16 +00:00
alesapin
46f25d53b3 Merge branch 'master' into revert-46909-revert-45911-mutations_rename_hang 2023-03-01 20:09:12 +01:00
kssenii
f3e3b916c9 Allow nested custom disks 2023-03-01 19:55:59 +01:00
alesapin
ebba37b18f
Merge pull request #47010 from ClickHouse/zero_copy_fetch
Fix bug in zero-copy replication disk choice during fetch
2023-03-01 15:55:00 +01:00
alesapin
b7370865a7
Merge pull request #47032 from ClickHouse/fix_message_for_zero_copy
Better exception message when move was unseccessful
2023-03-01 15:26:53 +01:00
alesapin
d72c310faa
Update src/Storages/MergeTree/MergeTreeData.cpp
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:54:22 +01:00
alesapin
8ff77c89eb
Update src/Storages/MergeTree/MergeTreeData.cpp
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:35 +01:00
alesapin
be5ef666ba
Update src/Storages/MergeTree/MergeTreeData.cpp
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:29 +01:00
alesapin
5de8a8e776
Update src/Storages/MergeTree/MergeTreeData.cpp
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-03-01 11:50:23 +01:00
Alexey Milovidov
fe446afb7d Increase max_replicated_merges_in_queue 2023-03-01 06:02:59 +01:00
Amos Bird
c0fb4ddc3e
Make thread analyzer happy 2023-03-01 11:07:36 +08:00
alesapin
c0f28ace51 Better 2023-02-28 17:52:21 +01:00
alesapin
abd6500ee3 Better exception message when move was unseccessful 2023-02-28 17:49:16 +01:00
alesapin
bb7571427b Fix bug in zero-copy replica disk choice during fetch 2023-02-28 14:48:46 +01:00
alesapin
967a47d870 Fix bug with readonly storages 2023-02-28 12:17:43 +01:00
Alexey Milovidov
29da7fc965 Decrease log level in "disks" 2023-02-27 17:48:38 +01:00
Anton Popov
caa1d22759
Merge branch 'master' into fix-issues-with-sparse 2023-02-27 15:25:19 +01:00
alesapin
7adbe93105 Remove strange part 2023-02-27 14:48:47 +01:00
Robert Schulze
6f0709032d
Merge pull request #46921 from ClickHouse/rs/inv-idx-checksum
A better alternative to #46344
2023-02-27 14:44:44 +01:00
alesapin
9dec64c94c Choose correct version for mutation 2023-02-27 14:35:26 +01:00
Nikolai Kochetov
3392b96cc3
Merge branch 'master' into aggregate-projections-analysis-query-plan 2023-02-27 14:07:04 +01:00
alesapin
e3961c118a
Revert "Revert "Fix several RENAME COLUMN bugs."" 2023-02-27 12:27:57 +01:00
Robert Schulze
4c9b9b362c
Replace dynamic_cast by typeid_cast 2023-02-27 10:01:21 +00:00
Robert Schulze
cc0c0c6133
A better alternative to #46344
The (experimental) inverted index writes/reads files different from the
standard files written by the other skip indexes. The original problem
was that with database engine "ordinary", DROP TABLE of a table with
inverted index finds unknown files in persistence and complains. The
same will happen with engine "atomic" but deferred. As a hotfix, the
error was silenced by explicitly adding the four files created in a
specific test to the deletion code.

This PR tries a cleaner solution where all needed files are provided via
the normal checksum structure. One drawback remains which is that the
affected files were written earlier and we don't have their checksums
available. Therefore, the inverted index is currently excluded from
CHECK TABLE.

Minimal repro:
  SET allow_experimental_inverted_index = 1;
  DROP TABLE IF EXISTS tab;
  CREATE TABLE tab(s String, INDEX af(s) TYPE inverted(2)) ENGINE = MergeTree() ORDER BY s;
  INSERT INTO tab VALUES ('Alick a01');
  CHECK TABLE tab;
  DROP TABLE IF EXISTS tab;

  run ./clickhouse-test with --db-engine Ordinary
2023-02-26 21:06:38 +00:00
Alexey Milovidov
73aec86f5a Change exception message 2023-02-26 21:36:26 +01:00
Alexey Milovidov
8f40bbd5b4
Revert "Fix several RENAME COLUMN bugs." 2023-02-26 05:47:05 +03:00
Alexey Milovidov
eb89ab471f
Merge pull request #45911 from ClickHouse/mutations_rename_hang
Fix several `RENAME COLUMN` bugs.
2023-02-26 01:56:40 +03:00
Alexey Milovidov
656af55831
Merge pull request #46384 from ClickHouse/fixes_for_993
Fixes for 993
2023-02-26 01:55:20 +03:00
Anton Popov
3a947ecddc do not allow const and non-deterministic secondary indexes 2023-02-24 19:17:44 +00:00
Alexander Tokmakov
ca1c793cac
Merge pull request #46820 from Algunenano/avoid_KeeperMultiException_system_errors
Don't report ZK node exists to system.errors when a block was created concurrently by a different replica
2023-02-24 19:42:32 +03:00
Alexander Gololobov
b43b98f7c0
Merge pull request #46785 from ClickHouse/fix_combined_prewhere_column
Fix combined PREWHERE column accumulated from multiple steps
2023-02-24 14:00:17 +01:00
Raúl Marín
7ff8d2d3d5 Don't report ZK node exists to system.errors 2023-02-24 12:36:29 +01:00
Anton Popov
d926713cf5 Merge remote-tracking branch 'upstream/master' into HEAD 2023-02-23 23:04:22 +00:00
Anton Popov
5e5e802348 return back optimization for ALTER MODIFY Nullable 2023-02-23 22:55:47 +00:00
Alexander Gololobov
47f51fe187
Merge pull request #46771 from ClickHouse/fix_prewhere_logging
More concise logging at trace level for PREWHERE steps
2023-02-23 20:20:30 +01:00
Alexander Gololobov
8b22373488 Apply filter at last step if it has been accumulated from multiple steps 2023-02-23 16:58:28 +01:00
Alexander Gololobov
cbcb1a7852 More concise logging at trace level 2023-02-23 13:31:56 +01:00
Kseniia Sumarokova
30a8eb0c2f
Merge pull request #46670 from kssenii/hide-disk-setting
Hide arguments of custom disk merge tree setting
2023-02-23 11:42:53 +01:00
Alexey Milovidov
c0bc549e77
Merge pull request #46709 from azat/bg-pool-no-query
BackgroundSchedulePool should not have any query context
2023-02-23 10:24:46 +03:00
Alexander Gololobov
67dcd9694c Remove unused MergeTreeReadTask::remove_prewhere_column 2023-02-22 17:49:22 +01:00
kssenii
c4761d6cc6 Fix checks 2023-02-22 14:27:43 +01:00
Azat Khuzhin
2ca47a6eb6 BackgroundSchedulePool should not have any query context
BackgroundSchedulePool is used for some peridic jobs, not from the query
context, i.e. flush of Buffer table.

And for such jobs there cannot be any query context, and more
importantly it will not work correctly since that query_context will
eventually expires.

And this is the reason of this failures [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/46668/015991bc5e20c787851050c2eaa13f0fef3aac00/stateless_tests_flaky_check__asan_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-22 10:50:51 +01:00
Alexander Gololobov
b61bb56a5a
Merge pull request #46611 from ClickHouse/prewhere_progress
Fix reporting progress when rows are filtered in PREWHERE
2023-02-21 21:27:56 +01:00