thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-29 21:20:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
18,074 Commits 8,956 Branches 1,767 Tags 1.8 GiB
9becb21e52
Commit Graph

18074 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
alexey-milovidov
3328fb456a
Merge pull request #2966 from amosbird/nrvo 
Get rid of useless std::move to get NRVO
 2018-08-27 19:56:03 +03:00
alexey-milovidov
0b9044fbf5
Merge pull request #2968 from yandex/addition-to-2954 
Suggested changes by Amos Bird #2954
 2018-08-27 19:51:39 +03:00
chertus
9dbaa5f4a9 remove strange code CLICKHOUSE-3765 2018-08-27 19:46:42 +03:00
Vadim
2d8bffafa3
Update MergeTreeSettings.h 2018-08-27 19:38:54 +03:00
Vadim
4d9d80b271
Update MergeTreeSettings.h 2018-08-27 19:38:36 +03:00
alesapin
4ecf3ce8ef
Merge pull request #2969 from alesapin/master 
CLICKHOUSE-3894: Fix Kafka test
 2018-08-27 19:24:39 +03:00
VadimPE
418375aa1d Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into CLICKHOUSE-3847 2018-08-27 19:23:08 +03:00
VadimPE
70ebb6a47d CLICKHOUSE-3847 fix code-style 2018-08-27 19:22:39 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
alesapin
1f0f1ecad3 CLICKHOUSE-3894: Fix Kafka test 2018-08-27 19:15:39 +03:00
Vadim
64a27e592b
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 19:00:40 +03:00
VadimPE
4d198f2bfe CLICKHOUSE-3847 fix build 2018-08-27 18:54:07 +03:00
VadimPE
0281678c3e CLICKHOUSE-3847 fix code style 2018-08-27 18:44:51 +03:00
Alexey Milovidov
00774ad8c6 Suggested changes by Amos Bird #2954 2018-08-27 18:27:23 +03:00
Alexey Milovidov
303cc7242f Addition to prev. revision #2956 2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030 Removed code with duplicate semantics [#CLICKHOUSE-2] 2018-08-27 18:01:33 +03:00
alexey-milovidov
7de0549879
Update ReadHelpers.h 2018-08-27 18:00:08 +03:00
alexey-milovidov
01f01b1ee1
Update ReadHelpers.cpp 2018-08-27 17:54:58 +03:00
alesapin
a2a623d228
Merge pull request #2967 from alesapin/master 
Small fixes in testing framework
 2018-08-27 17:53:56 +03:00
alesapin
716c8016d7 CLICKHOUSE-3894: Print stack trace 2018-08-27 17:45:37 +03:00
alesapin
06d091580d CLICKHOUSE-3894: Increase MySQL timeout and add logging 2018-08-27 17:43:59 +03:00
proller
3acce3bff9 Build fix (#2944) 
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
 2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO 
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
 2018-08-27 22:15:48 +08:00
VadimPE
a8974f8786 CLICKHOUSE-3847 add Coordinator 2018-08-27 16:51:22 +03:00
alesapin
3913a6ef4e
Merge pull request #2965 from alesapin/master 
CLICKHOUSE-3894: Wait zookeeper before clickhouse start
 2018-08-27 16:51:05 +03:00
alesapin
570343fdb3 CLICKHOUSE-3894: Wait zookeeper before clickhouse start 2018-08-27 16:42:39 +03:00
alexey-milovidov
806316511f
Merge pull request #2960 from zhang2014/fix/on_cluster_crash 
ISSUES-2482 fix crash when on cluster
 2018-08-27 16:25:26 +03:00
alexey-milovidov
2a99560f17
Merge pull request #2964 from yandex/zookeeper-tweak-error-codes 
Tweak error code in ZooKeeper library for correct expectations from t…
 2018-08-27 16:24:07 +03:00
alexey-milovidov
eb5f571935
Merge pull request #2959 from VadimPE/CLICKHOUSE-3914 
CLICKHOUSE-3914 add doc for CASE without ELSE
 2018-08-27 15:36:06 +03:00
VadimPE
5c0039f124 CLICKHOUSE-3914 fix 2018-08-27 15:31:17 +03:00
Vadim
be2d821669
Merge branch 'master' into CLICKHOUSE-3847 2018-08-27 15:26:41 +03:00
Alexey Milovidov
eb165a0616 Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916] 2018-08-27 15:19:29 +03:00
Vadim
c4e90d89f0
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 15:16:52 +03:00
VadimPE
22aa521884 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:14:48 +03:00
VadimPE
cf0a7c1529 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:09:22 +03:00
alesapin
9b358e037e
Merge pull request #2962 from alesapin/master 
CLICKHOUSE-3894: Fix test_config_substs test
 2018-08-27 14:51:09 +03:00
alesapin
d5dd32f4fe CLICKHOUSE-3894: Fix test_config_substs test 2018-08-27 14:40:01 +03:00
zhang2014
f8d7cf17a7 ISSUES-2482 fix crash when on cluster 2018-08-27 19:03:22 +08:00
VadimPE
83ff0d2721 CLICKHOUSE-3914 add doc for CASE without ELSE 2018-08-27 12:21:40 +03:00
BlahGeek
739119d355 skip object fields on json input 2018-08-27 12:01:47 +08:00
alexey-milovidov
3be0b6ca6d
Merge pull request #2950 from yandex/generalize-zookeeper 
Generalize zookeeper library
 2018-08-26 03:33:11 +03:00
Alexey Milovidov
c193d15ef2 Merge branch 'master' into generalize-zookeeper 2018-08-26 03:32:15 +03:00
alexey-milovidov
f92bae33f8
Merge pull request #2949 from yandex/distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper 
ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed.
 2018-08-26 03:12:20 +03:00
Alexey Milovidov
74b0d9b6a7 Little better; added comment #2954 2018-08-26 02:59:53 +03:00
Alexey Milovidov
2ce783e016 Merge branch 'read' of https://github.com/amosbird/ClickHouse into amosbird-read 2018-08-26 02:55:22 +03:00
alexey-milovidov
35806a4d27
Merge pull request #2955 from amosbird/varint 
Fast path for varint read.
 2018-08-26 02:47:04 +03:00
alexey-milovidov
00404a911c
Update VarInt.h 2018-08-26 02:46:18 +03:00
Amos Bird
a589230249 Faster path for varint read. 
clickhouse-benchmark <<< 'select count() from s where not ignore(s);'

before this patch:

```

QPS: 0.732, RPS: 2346562049.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000.
0.000%  1.310 sec.
10.000% 1.321 sec.
20.000% 1.327 sec.
30.000% 1.337 sec.
40.000% 1.343 sec.
50.000% 1.359 sec.
60.000% 1.366 sec.
70.000% 1.381 sec.
80.000% 1.400 sec.
90.000% 1.434 sec.
95.000% 1.448 sec.
99.000% 1.489 sec.
99.900% 1.499 sec.
99.990% 1.500 sec.

```

after this patch:

```
QPS: 0.787, RPS: 2524560389.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000.
0.000%  1.228 sec.
10.000% 1.232 sec.
20.000% 1.235 sec.
30.000% 1.241 sec.
40.000% 1.246 sec.
50.000% 1.256 sec.
60.000% 1.265 sec.
70.000% 1.278 sec.
80.000% 1.296 sec.
90.000% 1.321 sec.
95.000% 1.354 sec.
99.000% 1.421 sec.
99.900% 1.453 sec.
99.990% 1.456 sec.
```

I also tried a SSE2 implementation and it's much slower (50%)
 2018-08-26 02:23:26 +08:00
alexey-milovidov
732afd27cf
Merge pull request #2953 from yandex/max-block-size-in-system-tables-columns 
Support for max_block_size in system.tables and system.columns tables
 2018-08-25 20:36:54 +03:00