Commit Graph

63280 Commits

Author SHA1 Message Date
Alexey Milovidov
78a2df5900 Fix low quality code in Qualtile (found by PVS-Studio) 2021-05-08 19:10:38 +03:00
Alexey Milovidov
125b2ab214 Suppressions for PVS-Studio 2021-05-08 19:10:23 +03:00
Azat Khuzhin
69e395bede Round floats in AggregatingTransform log messages 2021-05-08 18:01:57 +03:00
Azat Khuzhin
6b11319cdf Round floats in Aggregator log messages 2021-05-08 18:01:24 +03:00
Azat Khuzhin
21f08a1aa9 Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary 2021-05-08 17:51:22 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
Azat Khuzhin
bdb5dad3a3 Cover system.dictionaries.found_count
v2: fix for ANTRL
v3: add all dictionaries layouts
2021-05-08 17:09:01 +03:00
Azat Khuzhin
763597001b Count found keys for RangeHashedDictionary 2021-05-08 17:09:01 +03:00
Azat Khuzhin
d115a6842d Count found keys for PolygonDictionary 2021-05-08 17:09:01 +03:00
Azat Khuzhin
97dc954add Count found keys for IPAddressDictionary 2021-05-08 17:09:01 +03:00
Azat Khuzhin
d07581d82d Count found keys for CacheDictionary 2021-05-08 17:09:01 +03:00
Azat Khuzhin
b767d9faac Count found keys for DirectDictionary (plus utils changes) 2021-05-08 17:09:01 +03:00
Azat Khuzhin
a6a1bf2847 Count found keys for FlatDictionary 2021-05-08 17:09:01 +03:00
Azat Khuzhin
c80a06def3 Count found keys for HashedDictionary (plus utils changes for descendants) 2021-05-08 17:09:01 +03:00
Azat Khuzhin
e08389b2d2 Add interface for rate of found elements in the dictionaries
- IDictionary abstraction
- skeleton implementation into each dictionary
- system.dictionaries.found_rate
- documentation changes
2021-05-08 17:09:01 +03:00
Maksim Kita
108c2022d9 Function arrayDifference decimal math overflow 2021-05-08 17:01:30 +03:00
alexey-milovidov
680860aae7
Merge pull request #23912 from azat/CU
Cleanup IDatabase.h from extra headers
2021-05-08 16:42:56 +03:00
Alexey Milovidov
b64f5b0419 Disable unreliable TestFlows 2021-05-08 16:40:54 +03:00
tavplubix
f8c7725ef5
Merge pull request #23742 from ClickHouse/update_metadata_on_replica_recovery
Update metadata on replica recovery
2021-05-08 16:34:03 +03:00
Maksim Kita
80dbb7ca4f
Merge pull request #23948 from azat/dict-range-min-max-check
Check MIN/MAX attributes in the list of dictionary attributes
2021-05-08 16:07:26 +03:00
divanorama
b6ea00cf29
Update glibc_compatibility check: ARCH_ARM -> ARCH_AARCH64 2021-05-08 14:24:04 +02:00
divanorama
3c2d1d1c17
Don't try GLIBC_COMPATIBILITY for i686 Linux
```
CMake Error at base/glibc-compatibility/CMakeLists.txt:22 (message):
  glibc_compatibility can only be used on x86_64 or aarch64.
```
2021-05-08 14:22:29 +02:00
Maksim Kita
e361bc6401
Merge pull request #23952 from mapleFU/mwish/typo-fix-in-compression-codec
typo: fix a typo in Compression/CodecT64
2021-05-08 13:15:00 +03:00
mwish
9328ec9c50 [Init] initialize commit 2021-05-08 18:07:39 +08:00
Maksim Kita
c4be98566a
Merge pull request #23928 from kreuzerkrieg/DropUnnecessaryPorts
Drop unnecessary ports where applicable
2021-05-08 12:03:09 +03:00
Maksim Kita
b617c57ce8
Merge pull request #23929 from azat/dict-cache-source-dups-fix
Fix keys metrics accounting for CACHE() dictionary with duplicates in the source
2021-05-08 11:56:20 +03:00
Maksim Kita
dadecc7604
Merge pull request #23947 from zhicwu/patch-1
Add JDBC bridge configuration and instructions for installation
2021-05-08 11:40:41 +03:00
Azat Khuzhin
8e9655d513 Check MIN/MAX attributes in the list of dictionary attributes
This way there will be proper exception instead of std::out_of_range
2021-05-08 08:59:47 +03:00
alexey-milovidov
98091a0434
Update config.xml 2021-05-08 03:43:06 +03:00
Zhichun Wu
ff305b2b1e
Add JDBC bridge instructions
Add JDBC bridge configuration and instructions for installation.
2021-05-08 07:56:20 +08:00
Azat Khuzhin
c1b213b96e Fix 01863_dictionary_cache_duplicates under ANTLR parser
By do not start name of table/dict from number.
2021-05-08 00:59:55 +03:00
Kseniia Sumarokova
e6ac136c32
Merge pull request #23909 from kssenii/postgres-fixes
Fix postgres connections issue
2021-05-08 00:07:21 +03:00
alexey-milovidov
7f441e0e01
Merge pull request #23939 from excitoon/patch-3
Added solution for host network mode in Ubuntu 20.10+
2021-05-07 23:42:21 +03:00
Vladimir Chebotarev
a39314949e
Added solution for host network mode in Ubuntu 20.10+. 2021-05-07 23:36:15 +03:00
Alexander Tokmakov
11124f7015 fix 2021-05-07 20:09:39 +03:00
Alexander Tokmakov
24bcd9f7c6 better comments, fix pvs warnings 2021-05-07 16:39:21 +03:00
Anton Popov
01e99ab72e
Merge pull request #23871 from CurtizJ/cast-operator
Add postgres-like cast operator
2021-05-07 16:29:22 +03:00
Anton Popov
576728829d fix perf test 2021-05-07 16:23:46 +03:00
alexey-milovidov
fd56e0a984
Merge pull request #23919 from ucasFL/hint-enum
Add hints for enum names
2021-05-07 16:12:16 +03:00
Maksim Kita
2b87656c66
Merge pull request #23910 from javainthinking/master
Update cloud document with ClickHousing releasing on Alibaba Cloud.
2021-05-07 15:17:06 +03:00
Maksim Kita
af740ba61d
Update cloud.md 2021-05-07 15:16:40 +03:00
Maksim Kita
01f66eb58c
Update cloud.md 2021-05-07 15:15:29 +03:00
Maksim Kita
8451c8cf26
Merge branch 'master' into master 2021-05-07 15:14:48 +03:00
kssenii
912878ad7f Review fixes 2021-05-07 12:05:34 +00:00
kssenii
93dce29a0a Correct odbc 2021-05-07 10:37:11 +00:00
kssenii
8662078b35 Review fixes 2021-05-07 09:55:18 +00:00
Azat Khuzhin
e398635cb3 Make StorageS3.cpp self compilable (missing AbstractConfiguration.h) 2021-05-07 10:07:44 +03:00
alexey-milovidov
617e71b3f2
Merge pull request #23704 from vzakaznikov/testflows_window_functions_tests
TestFlows window functions tests
2021-05-07 03:57:05 +03:00
Anton Popov
efd64c6d57 add test to skip list 2021-05-07 02:52:51 +03:00
Vitaliy Zakaznikov
f067237fdd Fixing range frame tests for distributed tables. 2021-05-06 18:16:24 -04:00