Commit Graph

2669 Commits

Author SHA1 Message Date
vxider
2f4f2d9d5e Merge branch 'master' of https://github.com/ClickHouse/ClickHouse 2021-12-06 14:06:00 +00:00
vxider
c522c06755 fix windowview parser 2021-12-04 12:30:04 +00:00
Maksim Kita
2d3f773147 Function accurateCastOrDefault remove separate branch 2021-12-03 13:25:55 +03:00
Azat Khuzhin
344298f403 Fix CAST from Nullable with cast_keep_nullable
UBsan report [1]:

    SELECT toUInt32OrDefault(toNullable(0)) SETTINGS cast_keep_nullable = 1

    ../src/Common/assert_cast.h:50:12: runtime error: downcast of address 0x000029461170 which does not point to an object of type 'const DB::ColumnNullable'
    0x000029461170: note: object is of type 'DB::ColumnVector<unsigned int>'
     00 00 00 00  a0 51 3d 09 00 00 00 00  01 00 00 00 00 00 00 00  a0 3f 4e 29 00 00 00 00  a4 3f 4e 29
                  ^~~~~~~~~~~~~~~~~~~~~~~
                  vptr for 'DB::ColumnVector<unsigned int>'
        0 0x1e3e279d in DB::ColumnNullable const& assert_cast<DB::ColumnNullable const&, DB::IColumn const&>(DB::IColumn const&) obj-x86_64-linux-gnu/../src/Common/assert_cast.h:50:12
        1 0x1e3e279d in DB::ColumnNullable::insertRangeFrom(DB::IColumn const&, unsigned long, unsigned long) obj-x86_64-linux-gnu/../src/Columns/ColumnNullable.cpp:167:43
        2 0x12db4507 in DB::FunctionCastOrDefault::executeImpl() const (/src/ch/tmp/32019/clickhouse-ubsan+0x12db4507)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/32019/9e1222a50b1805f696f4205e451365f8acdbc8a5/fuzzer_astfuzzerubsan,actions//report.html

And w/o -fsanitize=undefined:

    SELECT toUInt32OrDefault(toNullable(1), toNullable(toUInt32(1))) SETTINGS cast_keep_nullable = 1

    Received exception:
    Code: 12. DB::Exception: Parameters start = 0, length = 1 are out of bound in ColumnVector<T>::insertRangeFrom method (data.size() = 0).: While processing toUInt32OrDefault(toNullable(1), toNullable(toUInt32(1))). (PARAMETER_OUT_OF_BOUND)
2021-12-03 02:02:42 +03:00
Maksim Kita
2d359a5e79
Merge pull request #32110 from bharatnc/ncb/h3-func-looping
make looping in H3 funcs uniform
2021-12-02 13:15:36 +03:00
Maksim Kita
a426ed0a5a
Merge pull request #31800 from kitaisreal/dict-get-with-type-nullable-fix
Function dictGet with type Nullable fix
2021-12-02 12:27:47 +03:00
bharatnc
5614be28ef make looping in H3 funcs uniform
Some of the H3 funcs use `collections::range(0, input_rows_count)`
and some just use simple for loop for iterating over the rows.

In my recent PR reviews, I've been requested to use for loop in favor of
collections in the H3 functions and have been wanting to make the switch
for other functions too to make them uniform

This PR replaces `collections::range` with a simple for loop for this
kind of iteration in the remaining H3 funcs.
2021-12-01 18:14:08 -08:00
Kruglov Pavel
cbfd77a394
Merge pull request #31839 from loneylee/master
Fix a bug about function transform with decimal args
2021-12-01 12:56:41 +03:00
Kseniia Sumarokova
3c348a2998
Merge pull request #8331 from Vxider/window-view
Support for Stream Processing
2021-11-30 18:20:12 +03:00
loneylee
496c3acd1c
Merge branch 'ClickHouse:master' into master 2021-11-29 15:15:23 +08:00
loneylee
fb159c0227 fix pr's bug @31839 2021-11-29 15:14:27 +08:00
Alexey Milovidov
0e07fe1002 Fix error 2021-11-28 07:18:00 +03:00
Alexey Milovidov
e865b49293 Merge branch 'master' into fix-decrypt-nullable 2021-11-28 06:12:06 +03:00
vxider
98740eec2e fix AST Fuzzer 2021-11-27 17:53:43 +00:00
vxider
d3a68c1498 update code style 2021-11-27 14:46:43 +00:00
vxider
f9a0b1aa13 fix AST Fuzzer 2021-11-27 08:38:53 +00:00
alexey-milovidov
d9292395e8
Merge pull request #31832 from ClickHouse/strange-code-typelist
Fix the issue that LowCardinality of Int256 cannot be created.
2021-11-27 00:36:56 +03:00
alexey-milovidov
75ac0f72bc
Merge pull request #31883 from CurtizJ/fix-empty-uuid
Fix function `empty` with `UUID` type
2021-11-27 00:23:47 +03:00
vxider
d95d181cbe fix code style 2021-11-26 18:30:22 +00:00
Vxider
71d9d80275 timezone support for Tumble/Hop Start/End 2021-11-26 18:03:41 +00:00
Raúl Marín
051dddd8df Reduce dependencies on ASTIdentifier.h
Goes from rebuilding 483 objects to 165 when it's modified
2021-11-26 16:49:40 +01:00
Anton Popov
7237343fd6 fix function 'empty' with uuid type 2021-11-26 17:39:29 +03:00
loneylee
56307bb2fa issue #29730 2021-11-26 10:05:31 +08:00
kssenii
223048d395 Merge branch 'master' of github.com:ClickHouse/ClickHouse into vxider-window-view 2021-11-26 01:06:06 +03:00
Alexey Milovidov
85cec911be Fix strange code in TypeList 2021-11-25 23:55:02 +03:00
Maksim Kita
1fa57c96b2 FunctionsExternalDictionaries removed areTypesEqual 2021-11-25 19:06:37 +03:00
Maksim Kita
a480eb89ef Function dictGet with type Nullable fix 2021-11-25 17:06:35 +03:00
Alexey Milovidov
a4e57228cf Add a test from #31662 2021-11-24 23:09:50 +03:00
Alexey Milovidov
bd1964a2eb Fix exception on some of the applications of "decrypt" function on Nullable columns 2021-11-24 16:46:20 +03:00
yandd
7b43608e1f
Fixed function ngrams 2021-11-24 21:18:38 +08:00
Kruglov Pavel
b63b47f0f0
Merge pull request #31265 from Avogar/fix-write-buffers
Fix and refactor WriteBiffer-s a little
2021-11-23 16:46:09 +03:00
Alexey Milovidov
c5fcef03c3 Remove trash 2021-11-21 18:12:05 +03:00
Kruglov Pavel
d9c1a0c8ec
Merge branch 'master' into fix-write-buffers 2021-11-20 17:48:24 +03:00
kssenii
29978f9707 Merge branch 'master' of github.com:ClickHouse/ClickHouse into vxider-window-view 2021-11-20 12:13:39 +03:00
kssenii
9bdad8ab64 Rewrite from DataStreams to Processors 2021-11-19 16:09:12 +03:00
kssenii
6a39d871b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into vxider-window-view 2021-11-18 17:29:11 +03:00
kssenii
11ab1f1ae5 Fix 2021-11-18 08:46:31 +00:00
kssenii
4016530b99 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into sql-json-fix-2 2021-11-18 08:33:50 +00:00
Kruglov Pavel
f27fcf8372
Merge pull request #31004 from Avogar/output-formats
Small refactoring in formats
2021-11-17 20:44:46 +03:00
avogar
c521a9131a Small refactoring of WriteBiffer-s 2021-11-11 02:11:18 +03:00
Dmitry Novik
406bb4d997
Merge pull request #28965 from nicelulu/issues_28774
128bit hash-functions accepting arbitrary list of arguments
2021-11-09 14:40:25 +03:00
kssenii
ab44123f49 Fix 2021-11-08 13:00:42 +03:00
kssenii
9cfa2c4578 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sql-json-fix-2 2021-11-04 13:04:00 +03:00
avogar
2dd4393ca1 Small refactoring in formats 2021-11-03 20:07:05 +03:00
kssenii
ae8a451cef Merge branch 'master' of github.com:ClickHouse/ClickHouse into sql-json-fix-2 2021-11-03 14:37:50 +03:00
Vitaly Baranov
1f217aeb5a
Merge pull request #30998 from vitlibar/rename-access-control-manager
Rename AccessControlManager
2021-11-03 12:20:17 +03:00
Anton Popov
2a617e6a5a
Merge pull request #31003 from kssenii/sql-json-fix
Allow spaces in JSONPath.
2021-11-03 00:59:54 +03:00
kssenii
79bb4fdba4 Fix 2021-11-02 21:57:36 +03:00
kssenii
01684ad05a Fix 2021-11-02 16:53:47 +03:00
avogar
62c5951dd7 Fix segfault in formatRow function 2021-11-02 16:26:14 +03:00