Commit Graph

8530 Commits

Author SHA1 Message Date
Robert Schulze
e23e7e6b73
Merge pull request #53710 from rschu1ze/system-reload-asynchronous-metrics
Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`
2024-01-23 11:56:25 +01:00
kssenii
b76630c955 Merge remote-tracking branch 'origin/master' into broken-projections-better-handling 2024-01-23 11:34:58 +01:00
Robert Schulze
8fc918b272
Fix style, pt. III 2024-01-23 06:23:34 +00:00
Robert Schulze
e72b44a0bf
Fix style, pt. II 2024-01-23 05:58:24 +00:00
Nikita Taranov
09e24ed6c5
Merge pull request #58068 from zhongyuankai/limit_materialized_view_size
A limit on the number of materialized views attached to a table.
2024-01-22 22:50:56 +01:00
Arthur Passos
24b8bbe9fa
Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition (#39507)
* temp commit

* temp commit

* draft impl for feedback

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* aa

* aa

* Add integ tests and remove partition key restriction

* fix small incosistency in partition id

* style fix

* style fix

* style fix

* use existing DataPartStorageBuilder instead of new one

* Refactor part clone to make it more readable and maintainable

* Add MergeTreeDataPartCloner docs

* define ErrorCodes::BAD_ARGUMENTS

* Rebase

* camel case methods

* address some comments

* yet another rebase?

* Move from integ tests to stateless tests

* address more comments

* add finalize on min_max_idx files

* Add sync option to DistinctPartitionExpCloner

* just a temp test

* revert temp change

* Use echoOn to distinguish test queries

* remove comment

* fix build issue during rebase

* atempt to fix build after rebase

* finally fix build

* clear minmaxidx hyperrectangle before loading it

* Fix error on min_max files deletion where it was being assumed that partition expression contained all columns

* get it to the state it was previously

* add missing include

* getting functional?

* refactoring and renaming

* some more refactoring

* extern bad arguments

* try to fix style

* improvements and docs

* remove duplicate includes

* fix crash

* make tests more stable by ordering

* rebase once again..

* fix

* make ci happy?

* fix rebase issues

* docs

* rebase, but prolly needs to be improved

* refactor out from nasty inheritance to static methods

* fix style

* work around optional

* refactor & integrate some changes

* update column_type

* add tests by dencrane

* set utc

* fix ref file

* fix tests

* use MergeTree instead of SummingMergeTree

* mark MergeTreeDataPart::getBlock as const

* address a few comments

* compute module function name size at compile time

* simplify branching in getPartitionAstFieldsCount

* remove column_indexes argument

* merge getBlock with buildBlock

* add some const specifiers

* small adjustments

* remove no longer needed isNull check

* use std::min and max to update global min max idx

* add some assertions

* forward declare some symbols

* fix grammar

* forward decl

* try to fix build..

* remove IFunction forward decl

* Revert "use std::min and max to update global min max idx"

This reverts commit b2fe79dda7.

* Revert "remove no longer needed isNull check"

This reverts commit 129db2610f.

* Revert "Revert "remove no longer needed isNull check""

This reverts commit 9416087dd8.

* Revert "Revert "use std::min and max to update global min max idx""

This reverts commit 20246d4416.

* remove some comments

* partial use of MonotonicityCheckMatcher

* ranges

* remove KeyDescriptionMonotonicityChecker

* remove duplication of applyfunction

* move functions to anonymous namespace

* move functions to cpp

* Relax partition compatibility requirements by accepting subset, add tests from partitioned to unpartitioned

* updte reference file

* Support for partition by a, b, c to partition by a, b

* refactoring part 1

* refactoring part 2, use hyperrectangle, still not complete

* refactoring part 3, build hyperrectangle with intersection of source & destination min max columns

* Support attaching to table with partition expression of multiple expressions

* add tests

* rename method

* remove some code duplication

* draft impl for replicatedmergetree, need to dive deeper

* ship ref file

* fix impl for replicatedmergetree..

* forbid attach empty partition replicatedmergetree

* Add replicated merge tree integration tests

* add test missing files

* fix black

* do not check for monotonicity of empty partition

* add empty tests & fix replicated

* remove no longer needed buildBlockWithMinMaxINdexes

* remove column logic in buildHyperrectangle

* simplify implementation by using existing methods

* further simplify implementation

* move all MergeTreeDataPartClone private methods to .cpp file

* decrease decomposition

* use different namespaces

* reduce code duplication

* fix style

* address a few comments

* add chassert to assert arguments size on MonotonicityCheckVisitor

* remove deleteMinMaxFiles method

* remove useless checks from sanitycheck

* add tests for attach partition (not id)

* Remove sanityCheckASTPartition and bring back conditional getPartitionIDFromQuery

* remove empty block comment

* small fixes

* fix formatting

* add missing include

* remove duplicate iuncludes

* trigger ci

* reduce some code duplication

* use updated partition id on replicatedmergetree

* fix build

* fix build

* small refactor

* do not use insert increment on fetch part

* remove duplicate includes

* add one more integ test

* black

* black

* rely on partition exp instead of partition id on replicated part fetch to decide if it is a different partition exp

* add one more integ test

* add order by clause

* fix black

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2024-01-22 21:00:04 +01:00
robot-clickhouse
48f0580512 Automatic style fix 2024-01-22 17:39:44 +00:00
Robert Schulze
d739a7230a
Fix style 2024-01-22 17:37:16 +00:00
kssenii
1aa8e62bb7 Fix 2024-01-22 18:26:44 +01:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Nikita Taranov
704e5ac883
Fix test_parallel_replicas_invisible_parts 2024-01-22 17:52:13 +01:00
kssenii
15e3a5b396 Try fix flaky test 2024-01-22 14:57:10 +01:00
Kseniia Sumarokova
aec76d6653
Merge pull request #58877 from ClickHouse/multiple-read-file-log-storage-in-mv
Multiple read file log storage in mv
2024-01-22 12:02:41 +01:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups
Allow KILL QUERY for backups
2024-01-20 23:48:18 +01:00
Igor Nikonov
4be068c73b
Merge pull request #58993 from ClickHouse/revert-58992-revert_flaky
Revive: Parallel replicas custom key: skip unavailable replicas
2024-01-20 19:44:56 +01:00
Kseniia Sumarokova
e5c3b67f37
Update test.py 2024-01-20 16:10:09 +01:00
Kseniia Sumarokova
caf9d8df6d
Update test.py 2024-01-20 14:59:13 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
Alexey Milovidov
587295aca1
Merge pull request #58981 from azat/prom-handler
Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive)
2024-01-20 09:42:05 +01:00
Igor Nikonov
3d8be9d588 Comment for disabled assert 2024-01-19 14:54:20 +00:00
robot-clickhouse
522cce991a Automatic style fix 2024-01-19 14:37:53 +00:00
Igor Nikonov
a4d0260fa7 Update tests
+ setting max_replica_delay_for_distributed_queries to avoid replica lag
  affecting load balancing
+ disable flaky assert for asan/tsan builds (will investigated
  separately)
2024-01-19 14:23:15 +00:00
zhongyuankai
cbb51659f6
Merge branch 'master' into limit_materialized_view_size 2024-01-19 22:00:12 +08:00
Igor Nikonov
17c7fdfed9 Disable check which is flaky atm 2024-01-19 12:58:21 +00:00
Igor Nikonov
131f71b50a
Revert "Revert flaky" 2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover"
This reverts commit 8ba9b4a7ef, reversing
changes made to 0f39245cb8.
2024-01-19 12:46:05 +00:00
Raúl Marín
44b621fb48 Revert "Merge pull request #58909 from ClickHouse/fix-test-custom-key-failover"
This reverts commit deeb09ff37, reversing
changes made to a4cab68a06.
2024-01-19 12:44:55 +00:00
robot-clickhouse
7c66141e08 Automatic style fix 2024-01-19 11:11:13 +00:00
kssenii
a196d04a1c Update test 2024-01-19 12:04:16 +01:00
Azat Khuzhin
38ad4ef493 Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive)
Before:

    $ time curl -s --http1.1 127.1:9363/metrics > /dev/null
    real    0m10.018s # default keep_alive_timeout is 10 seconds
    user    0m0.005s
    sys     0m0.001s

After

    $ time curl -s --http1.1 127.1:9363/metrics > /dev/null
    real    0m0.008s
    user    0m0.006s
    sys     0m0.000s

And if you will look at the test_prometheus_endpoint, you will see that
it takes > 30 seconds (it obtains metrics 3 times), after this patch it
should be finished more or less instantly.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-19 13:29:17 +03:00
kssenii
48e489682b Merge remote-tracking branch 'origin/master' into broken-projections-better-handling 2024-01-19 10:49:27 +01:00
Kseniia Sumarokova
25be226c05
Merge pull request #58951 from ClickHouse/fix-materialized-pg-test
Fix flaky test_postgresql_replica_database_engine_2/test.py::test_dependent_loading
2024-01-19 10:27:18 +01:00
Nikita Taranov
9d36fe4a48
Merge pull request #58923 from nickitat/add_test
Add regression test for parallel replicas (follow up #58722, #58844)
2024-01-18 21:54:18 +01:00
Kseniia Sumarokova
7f92bf6f0b
Merge pull request #58921 from ClickHouse/add-a-test-for-azure
Fix and test for azure #58697
2024-01-18 21:41:54 +01:00
kssenii
10a47ef185 Fix 2024-01-18 16:56:17 +01:00
Tim Liou
483bbaf14d Run black locally to format the code 2024-01-18 23:42:10 +08:00
Tim Liou
61826cf21a Validate log level values 2024-01-18 21:40:23 +08:00
Vitaly Baranov
4c6d3e7efa Add server settings "shutdown_wait_backups_and_restores" (default=true)
to set whether shutdown should wait for running backups to finish or just cancel them.
2024-01-18 13:27:14 +01:00
Kseniia Sumarokova
7092948d53
Update test.py 2024-01-18 11:02:13 +01:00
Igor Nikonov
fa664a3656 Merge remote-tracking branch 'origin/master' into fix-test-custom-key-failover 2024-01-17 19:36:04 +00:00
Igor Nikonov
265bfa0af8 Using current database in cluster 2024-01-17 19:35:35 +00:00
Igor Nikonov
3b8ce04392 Add test for load balancing 2024-01-17 18:57:08 +00:00
Nikita Taranov
06a3a81b24 fix 2024-01-17 19:42:23 +01:00
Nikita Taranov
4fddf60f05 impl 2024-01-17 19:41:12 +01:00
kssenii
ef48b90bca Fix and test 2024-01-17 18:44:09 +01:00
Alexey Milovidov
1161dbbd54
Merge pull request #57993 from mkmkme/mkmkme/reload-config-again
Update `query_masking_rules` when reloading the config, attempt 2
2024-01-17 17:09:36 +01:00
robot-clickhouse
c2ccfba8ef Automatic style fix 2024-01-17 15:02:37 +00:00
kssenii
dc5d09fc55 Fix tests 2024-01-17 15:52:07 +01:00
kssenii
1e9de73bf5 Fix style check 2024-01-17 15:40:46 +01:00
kssenii
4d9c173008 Merge remote-tracking branch 'origin/broken-projections-better-handling' into broken-projections-better-handling 2024-01-17 15:40:27 +01:00
kssenii
dea8b10ae9 Fix test 2024-01-17 15:39:57 +01:00
Igor Nikonov
9e17877da5 Fix: use cluster() instead of defining distributed table 2024-01-17 14:11:09 +00:00
Kruglov Pavel
6d064512e1
Merge pull request #58614 from Blargian/58363_disable_ansi_pretty_automatically
58363 Automatically disable ANSI escape sequences in Pretty formats if the output is not a terminal
2024-01-17 13:45:41 +01:00
kssenii
1f384dd8a8 Fix 2024-01-17 10:32:56 +01:00
Mikhail Koviazin
6e6197019c
Reintroduce commit 3067ca6
Update `query_masking_rules` when reloading the config

This reverts commit 7e55eab1c3.
2024-01-17 08:10:49 +02:00
Alexander Tokmakov
38b85e6409
Merge pull request #58649 from azat/tests/test_replicated_database
Fix test_replicated_database::test_startup_without_zk flakiness
2024-01-16 21:08:33 +01:00
robot-clickhouse
216769f43e Automatic style fix 2024-01-16 18:55:23 +00:00
kssenii
7bc6a858c7 Rewrite bash test to integration test 2024-01-16 19:44:55 +01:00
Blargian
1b81efc337 fix failing 02421 stateless and (hopefully) fix failing integration tests 2024-01-16 19:48:23 +02:00
robot-clickhouse
7262e93a27 Automatic style fix 2024-01-16 16:26:28 +00:00
János Benjamin Antal
5a178ce1ef Add proper cleanup to kafka test 2024-01-16 16:03:44 +00:00
Vitaly Baranov
085833aaae Use special statuses BACKUP_CANCELLED and RESTORE_CANCELLED in system.backups 2024-01-16 15:07:24 +01:00
Vitaly Baranov
185f6cc37c Add tests for cancelling backup/restore queries. 2024-01-16 15:07:20 +01:00
kssenii
8decf5039a Fix for custom cached disk 2024-01-16 14:41:12 +01:00
vdimir
54a79c1f3d
Merge pull request #58123 from ClickHouse/vdimir/cluster_discovery_password
ClusterDiscovery supports setting username and password
2024-01-16 11:05:54 +01:00
zhongyuankai
cca2fa6976 fix test 2024-01-16 15:39:33 +08:00
Alexander Tokmakov
8bdd6542ce
Merge pull request #58647 from ClickHouse/tavplubix-patch-10
Update test_replicated_database/test.py
2024-01-16 00:32:08 +01:00
János Benjamin Antal
3e1d7bf685
Merge pull request #58477 from ClickHouse/multiple-read-kafka-storage-in-mv
Delay reading from StorageKafka to allow multiple reads in materialized views
2024-01-15 12:31:59 +01:00
vdimir
1f0a29cf10
Fix test_cluster_discovery/test_password.py 2024-01-15 11:31:22 +00:00
vdimir
53e2a97d33
Add missing configs to test_cluster_discovery 2024-01-15 11:22:54 +00:00
vdimir
8dc1756532
Support <secret> in cluster discovery 2024-01-15 11:22:53 +00:00
vdimir
6ab507e722
Add test case for cluster discovery with wrong password 2024-01-15 11:22:52 +00:00
vdimir
012713fc31
ClusterDiscovery supports setting username and password 2024-01-15 11:22:48 +00:00
zhongyuankai
826b29ef4d Max materialized views size for table 2024-01-15 10:02:57 +08:00
Kseniia Sumarokova
77f4cd8dd3
Merge pull request #58721 from ClickHouse/support-point-datatype-for-mysql
Support Point data type for MySQL
2024-01-12 17:02:01 +01:00
kssenii
8b1d2805ae Add one more test case to the test 2024-01-12 10:41:04 +01:00
Dmitry Novik
e3aed6ba4e
Fix integration test 2024-01-12 09:40:15 +01:00
kssenii
fada92173b Support Point data type for MySQL 2024-01-11 19:19:08 +01:00
Yakov Olkhovskiy
84809b36c3
Merge pull request #58475 from ClickHouse/revert-58450-revert-56064-feature-server-iface-metrics
Second attempt: Use CH Buffer for HTTP out stream, add metrics for interfaces
2024-01-11 12:06:59 -05:00
Igor Nikonov
8ba9b4a7ef
Merge pull request #57235 from ClickHouse/pr-custom-key-failover
Parallel replicas custom key: skip unavailable replicas
2024-01-11 12:22:32 +01:00
Konstantin Bogdanov
7f4ccebea4
Merge pull request #58550 from danipozo/hide-credentials-in-base-backup-name
Hide credentials in system.backup_log base_backup_name column
2024-01-11 03:42:17 +03:00
Igor Nikonov
8d4a395afa Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2024-01-10 20:28:04 +00:00
Igor Nikonov
e9fc869254 Fix test flakiness with hedge connections enabled 2024-01-10 15:59:48 +00:00
Yakov Olkhovskiy
2e124b19b8
Merge branch 'master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-10 09:05:18 -05:00
Azat Khuzhin
2cf74aea5c Fix test_replicated_database::test_startup_without_zk flakiness
CI founds [1]

    E           assert 'ZooKeeper' in "Received exception from server (version 24.1.1):\nCode: 999. DB::Exception: Received from 172.16.1.6:9000. Coordination::Exception. Coordination::Exception: Coordination error: Connection loss, path /clickhouse/databases/startup. Stack trace:\n\n0. ? @ 0x000000000c734f1b in /usr/bin/clickhouse\n1. ? @ 0x000000000fbef3f4 in /usr/bin/clickhouse\n2. ? @ 0x000000000fbeebc8 in /usr/bin/clickhouse\n3. ? @ 0x0000000012ded0f9 in /usr/bin/clickhouse\n4. ? @ 0x0000000012deaa71 in /usr/bin/clickhouse\n5. ? @ 0x00000000107e51e8 in /usr/bin/clickhouse\n6. ? @ 0x00000000107eb87a in /usr/bin/clickhouse\n7. ? @ 0x0000000011213ec3 in /usr/bin/clickhouse\n8. ? @ 0x00000000111e9acf in /usr/bin/clickhouse\n9. ? @ 0x000000001120e85e in /usr/bin/clickhouse\n10. ? @ 0x000000001174f0a2 in /usr/bin/clickhouse\n11. ? @ 0x0000000011748c9a in /usr/bin/clickhouse\n12. ? @ 0x00000000126fb5a9 in /usr/bin/clickhouse\n13. ? @ 0x00000000127130f9 in /usr/bin/clickhouse\n14. ? @ 0x000000001517bf12 in /usr/bin/clickhouse\n15. ? @ 0x000000001517cd11 in /usr/bin/clickhouse\n16. ? @ 0x00000000152740c7 in /usr/bin/clickhouse\n17. ? @ 0x00000000152726bc in /usr/bin/clickhouse\n18. ? @ 0x00007f7f36485ac3\n19. ? @ 0x00007f7f36517660\n. (KEEPER_EXCEPTION)\n(query: CREATE DATABASE startup ENGINE = Replicated('/clickhouse/databases/startup', 'shard1', 'replica1');)\n"

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/58610/441a3fbb9b1c088f528841727f013b829f63fc8a/integration_tests__release__[3_4]/integration_run_test_replicated_database_test_py_0.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-10 14:44:29 +03:00
Alexander Tokmakov
b954667ae9
Update test.py 2024-01-10 11:07:13 +01:00
Robert Schulze
4cacfa6b43
Merge pull request #57509 from jinjunzh/qatzstd_main
Add Intel-QAT-based `ZSTD_QAT` compression codec
2024-01-10 10:31:39 +01:00
Kseniia Sumarokova
1b517105db
Merge pull request #57323 from valbok/mysql-binlog-client
MaterializedMySQL: Introduce MySQL Binlog Client
2024-01-10 09:08:13 +01:00
Robert Schulze
ced9e93ac6
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main 2024-01-09 20:36:02 +00:00
Sema Checherinda
7c7e72c4b7
Merge pull request #58573 from ClickHouse/chesema-s3-client-creation
fix and test that S3Clients are reused
2024-01-09 13:28:20 +01:00
Sema Checherinda
6dbf7c967c
Merge pull request #57663 from ClickHouse/CheSema-remote-blobs-naming-2
generate object storage key by template
2024-01-09 13:26:56 +01:00
Igor Nikonov
7fd851b4e9 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2024-01-08 20:43:20 +00:00
Dani Pozo
d8f4b5fd13 Fix black formatting 2024-01-08 12:47:58 +01:00
Dani Pozo
b42eaf6c62 Add test for hiding credentials in system.backups table 2024-01-08 12:20:32 +01:00
robot-clickhouse
29173a602e Automatic style fix 2024-01-08 02:39:19 +00:00
Yakov Olkhovskiy
45ac4d2b67 Merge remote-tracking branch 'origin/master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-07 15:23:46 +00:00
Robert Schulze
53965bb9f1
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main 2024-01-07 14:11:22 +00:00
Sema Checherinda
d5f86f671d fix and test that S3Clients reused 2024-01-07 02:19:06 +01:00
robot-clickhouse
4a473c37ec Automatic style fix 2024-01-06 15:55:20 +00:00
Alexey Milovidov
2751b351cb Fix test 2024-01-06 16:44:38 +01:00