Commit Graph

156101 Commits

Author SHA1 Message Date
robot-clickhouse
f920f957d6 Update version_date.tsv and changelogs after v24.3.12.75-lts 2024-10-08 15:03:12 +00:00
Alexander Gololobov
a261c0a77e
Merge pull request #70453 from ClickHouse/fix_flaky_03249_dynamic_alter_consistency
Fix order in 03249_dynamic_alter_consistency
2024-10-08 14:36:42 +00:00
Sharath K S
15a86aeaf6 Add prefix "clickhouse.setting." to query setting names in span log
Updated relevant documentation and setting descriptions to reflect this change.
2024-10-08 07:33:33 -07:00
Alexey Milovidov
3ab6b8b621
Merge pull request #70473 from azat/tests/00913_many_threads
Decrease probability of "Server died" due to 00913_many_threads
2024-10-08 14:28:54 +00:00
Blargian
78e57ebe04 update aspell-ignore 2024-10-08 16:25:26 +02:00
Blargian
fce6df5e93 review changes 2024-10-08 16:17:26 +02:00
Arthur Passos
514fa6febf add new test file 2024-10-08 10:55:43 -03:00
Arthur Passos
e5188d4212 rmv ssh key 2024-10-08 10:55:19 -03:00
Arthur Passos
73cba7fbdc add test for ipv6 2024-10-08 10:54:17 -03:00
Antonio Andelic
2e6bd082a6
Merge pull request #70452 from ClickHouse/fix-vertical-merge-prefetch
Don't prefetch parts with no rows
2024-10-08 13:28:31 +00:00
Arthur Passos
2b5eef39a9 move setting to 24.10 2024-10-08 09:09:04 -03:00
Azat Khuzhin
5e33f2d714 tests/clickhouse-test: fix pylint warning about unused vars in signal handler
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:57:29 +02:00
Azat Khuzhin
9fd9ed40bb Ignore ESRCH while obtaining process group
Should fix the following [1]:

    2024-10-07 21:13:38 02784_connection_string:                                                [ OK ] 9.69 sec.
    2024-10-07 21:13:38 Process Process-5:
    2024-10-07 21:13:38 Traceback (most recent call last):
    2024-10-07 21:13:38   File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    2024-10-07 21:13:38     self.run()
    2024-10-07 21:13:38   File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
    2024-10-07 21:13:38     self._target(*self._args, **self._kwargs)
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 2609, in run_tests_process
    2024-10-07 21:13:38     return run_tests_array(*args, **kwargs)
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 2327, in run_tests_array
    2024-10-07 21:13:38     stop_tests()
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 445, in stop_tests
    2024-10-07 21:13:38     cleanup_child_processes(os.getpid())
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 433, in cleanup_child_processes
    2024-10-07 21:13:38     child_pgid = os.getpgid(child)
    2024-10-07 21:13:38 ProcessLookupError: [Errno 3] No such process

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:40:50 +02:00
Azat Khuzhin
95f3d2e4e9 Kill tests leftovers in case of timeout
Though now there are oddities with multiprocessing_manager.list():

    Having 1 errors! 0 tests passed. 0 tests skipped. 2.20 s elapsed (MainProcess).
    Won't run stateful tests because test data wasn't loaded.
    Traceback (most recent call last):
      File "/usr/lib/python3.12/multiprocessing/managers.py", line 813, in _callmethod
        conn = self._tls.connection
               ^^^^^^^^^^^^^^^^^^^^
    AttributeError: 'ForkAwareLocal' object has no attribute 'connection'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/src/ch/clickhouse/.cmake/../tests/clickhouse-test", line 3707, in <module>
        main(args)
      File "/src/ch/clickhouse/.cmake/../tests/clickhouse-test", line 3126, in main
        if len(restarted_tests) > 0:
           ^^^^^^^^^^^^^^^^^^^^
      File "<string>", line 2, in __len__
      File "/usr/lib/python3.12/multiprocessing/managers.py", line 817, in _callmethod
        self._connect()
      File "/usr/lib/python3.12/multiprocessing/managers.py", line 804, in _connect
        conn = self._Client(self._token.address, authkey=self._authkey)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.12/multiprocessing/connection.py", line 519, in Client
        c = SocketClient(address)
            ^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.12/multiprocessing/connection.py", line 647, in SocketClient
        s.connect(address)
    ConnectionRefusedError: [Errno 111] Connection refused

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:35:07 +02:00
Azat Khuzhin
94df71fdc2 Add exception message into "Hung check failed" message
Here [1] the hung query failed:

    2024.10.07 21:13:29.044675 [ 16750 ] {484a1200-d576-4c03-a82b-2d389b8e773f} <Debug> executeQuery: (from [::1]:43374) SELECT 1 /*hung check*/
      (stage: Complete)
    2024.10.07 21:13:29.047252 [ 16750 ] {484a1200-d576-4c03-a82b-2d389b8e773f} <Error> executeQuery: Code: 210. DB::Exception: I/O error: Broken pipe, while writing to socket ([::1]:8123 -> [::1]:43374): While executing TabSeparatedRowOutputFormat. (NETWORK_ERROR) (version 24.10.1.1368) (from [::1]:43374) (in query: SELECT 1 /*hung check*/

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

But I don't see any possible reasons for this, only if the client closes
the connection, but I bet that the query had been sent long time ago,
but due to VM stall (#70473) it was not accepted.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:22:08 +02:00
Azat Khuzhin
8d4036760c Decrease probability of "Server died" due to 00913_many_threads
This test creates too much threads (1500), and sometimes there are some
stalls on arm64 [1]:

    2024.10.07 21:06:38.768974 [ 4479 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Debug> executeQuery: (from [::1]:52210) (comment: 00913_many_threads.sql) SELECT count() FROM t; (stage: Complete)
    ...
    2024.10.07 21:07:37.028725 [ 15271 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Trace> AggregatingTransform: Aggregated. 1 to 1 rows (from 0.00 B) in 58.247881431 sec. (0.017 rows/sec., 0.00 B/sec.)
    2024.10.07 21:11:20.662232 [ 15270 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Trace> AggregatingTransform: Aggregating
    ...

As you can see there are zero logs for almost 4 minutes, and trace_log
contains zero records for the interval event_time between '2024.10.07
21:07:37' and '2024.10.07 21:11:20'.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

At first I thought about adding some new metrics like
GlobalThreadPoolThreadSlowCreationMicroseconds, but it will unlikely
help with understading the root cause.

Then I thought about exposing CPU steal metric, but the problem is that
AWS uses Nitro instead of Xen for this instances (r6g.2xlarge), and
Nitro does not expose this metric.

So let's just disable parallel execution of this test to stabilize the
CI.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:20:57 +02:00
Robert Schulze
6f88ada7a9
Merge pull request #70467 from rschu1ze/docs-grammar
[Docs] Fix grammar and consistency
2024-10-08 10:11:49 +00:00
kssenii
250e8c6119 Fix setting description 2024-10-08 10:43:44 +02:00
Raúl Marín
d57f0a9d37 More consistent error codes 2024-10-08 16:35:08 +08:00
Pavel Kruglov
30991f29ac
Merge pull request #69691 from Avogar/default-implementation-for-dynamic
Support Dynamic type in most functions
2024-10-08 08:22:26 +00:00
Michael Kolupaev
53f78b2e49
Merge pull request #70462 from ClickHouse/waitwice
Fix flaky test_refreshable_mv_in_replicated_db
2024-10-08 08:11:20 +00:00
Robert Schulze
c9fdeb5174
[Docs] Fix grammar and consistency
Cf. #70219, #70220, #70221, #70255, #70279
2024-10-08 08:05:41 +00:00
Michael Kolupaev
dfd74322b1 Make the test work when ran multiple times with the same fixture 2024-10-08 07:44:03 +00:00
Antonio Andelic
9a3f76a9a5 Add test 2024-10-08 09:38:15 +02:00
János Benjamin Antal
f3071fb01c Fix build 2024-10-08 06:49:57 +00:00
pufit
c901c74a2e
Merge pull request #70293 from ClickHouse/pufit/fix-implicit-grants
`SHOW GRANTS WITH IMPLICIT`, fix error with implicit grants
2024-10-08 06:29:41 +00:00
Raúl Marín
6824b31c4f Fix crash in WHERE with lambda functions 2024-10-08 14:14:55 +08:00
robot-clickhouse
1d70ca4848
Merge pull request #70463 from ClickHouse/auto/v24.8.5.115-lts
Update version_date.tsv and changelog after v24.8.5.115-lts
2024-10-08 05:49:02 +00:00
János Benjamin Antal
2bd0d0cf11
Merge branch 'master' into validate-create-query-after-alter 2024-10-08 07:45:55 +02:00
Robert Schulze
1337f66cd0
Merge pull request #70360 from azat/vector-similarity-comments
Update comments in VectorSimilarityCondition (WHERE is not supported)
2024-10-08 05:30:14 +00:00
robot-clickhouse
9966eea716 Automatic style fix 2024-10-08 05:05:51 +00:00
robot-clickhouse
e54eabde84 Update version_date.tsv and changelogs after v24.8.5.115-lts 2024-10-08 05:00:26 +00:00
Michael Kolupaev
f78b298f61 Fix flaky test_refreshable_mv_in_replicated_db 2024-10-08 04:56:53 +00:00
David Tsukernik
2b94fba674 Style fixes 2024-10-08 04:15:38 +00:00
David Tsukernik
5ecd654ec0 Fix tests 2024-10-08 04:12:14 +00:00
robot-clickhouse
518be41439 Automatic style fix 2024-10-08 04:09:53 +00:00
kssenii
b2184ed6bd Merge remote-tracking branch 'origin' into cache-for-object-storage-table-engines 2024-10-08 06:07:48 +02:00
Michael Kolupaev
f7d9c3a9b1 Fix refreshable MV in system database breaking server startup 2024-10-08 04:00:19 +00:00
liuneng
a1e38decc2 Merge remote-tracking branch 'origin/master' into parquet-prefetch
# Conflicts:
#	src/Core/FormatFactorySettingsDeclaration.h
2024-10-08 11:35:02 +08:00
taiyang-li
af89ec5b82 solve conflicts 2024-10-08 11:34:37 +08:00
zhanglistar
46dffdb58d fix tests 2024-10-08 10:25:54 +08:00
David Tsukernik
c876b17702 Add ad test 2024-10-08 02:24:24 +00:00
zhanglistar
def91f1bb3
Merge branch 'ClickHouse:master' into regReplace-empty-needle 2024-10-08 09:56:52 +08:00
David Tsukernik
34fe797e02 Use an implicit true value for bool settings 2024-10-08 01:56:06 +00:00
pufit
a89b81852c
Merge branch 'master' into pufit/fix-implicit-grants 2024-10-08 09:45:02 +08:00
Shichao
e78ad9d5e6
Merge pull request #70456 from kylhuk/fix-documentation-reference-to-users-config
fix: fixed filename reference in documentation
2024-10-07 23:08:03 +00:00
kylhuk
97b596123d fix: fixed filename reference in documentation 2024-10-07 23:19:47 +02:00
johnnyfish
92d7b11eef Update gui.md 2024-10-08 00:09:22 +03:00
Arthur Passos
37206d8c9a add setting lost during merge 2024-10-07 16:59:29 -03:00
Arthur Passos
ce74e317a2 Merge branch 'master' into add_parquet_bloom_filters_support 2024-10-07 16:56:37 -03:00