Commit Graph

6030 Commits

Author SHA1 Message Date
MeenaRenganathan22
dc1e125b31 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into KRB_CVE_Fix 2023-03-13 06:54:47 -07:00
Smita Kulkarni
f76b97cb51 Set num of nodes to 4 for backup restore disallow concurrency test 2023-03-13 10:42:43 +01:00
SmitaRKulkarni
9a35a434f8
Merge branch 'master' into Backup_Restore_concurrency_check_node 2023-03-13 10:04:32 +01:00
Alexander Tokmakov
7b1b238d0b Revert "Merge pull request #25674 from amosbird/distributedreturnconnection"
This reverts commit 5ffd99dfd4, reversing
changes made to 2796aa333f.
2023-03-11 19:09:47 +01:00
Alexander Tokmakov
0359b3e336 Revert "Merge pull request #46622 from ClickHouse/async-insert-memory-fix"
This reverts commit 67469ad46b, reversing
changes made to 678e4250cd.
2023-03-11 17:01:10 +01:00
MeenaRenganathan22
f4f7336fd0 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into KRB_CVE_Fix 2023-03-10 09:08:02 -08:00
MeenaRenganathan22
ed5b19f5f8 Fixed the integration test failures related with HDFS and KAFKA 2023-03-08 06:11:17 -08:00
Antonio Andelic
816a9c1099
Merge branch 'master' into custom-key-parallel-replicas 2023-03-08 11:06:30 +01:00
Igor Nikonov
cc5b97b624
Merge pull request #46997 from AndyBys/log-level-change
Change level log in executeQuery
2023-03-08 10:36:21 +01:00
Alexey Milovidov
e2aff59a2d
Merge pull request #47106 from kssenii/allow-nested-disks-in-custom-disks
Allow nested custom disks
2023-03-08 03:00:55 +03:00
Alexander Tokmakov
ffd55d951d
Merge branch 'master' into followup_46681 2023-03-07 23:38:06 +03:00
Robert Schulze
5b91631722
Merge pull request #47138 from AVMusorin/disallow-default-columns-kafka-engine
Prohibit DEFAULT/EPHEMERAL/ALIAS/MATERIALIZED columns in KafkaEngine
2023-03-07 20:36:46 +01:00
Alexander Tokmakov
7ce20f5cd2 fix tests 2023-03-07 14:25:28 +01:00
Antonio Andelic
35c15e6ef8 Merge branch 'master' into custom-key-parallel-replicas 2023-03-07 09:37:38 +00:00
Alexey Milovidov
7d48eae0f6
Merge pull request #47256 from ClickHouse/keeper-4lw-clean-resources
Add Keeper 4LW for cleaning resources
2023-03-07 04:23:15 +03:00
Igor Nikonov
838ff88abe
Merge branch 'master' into log-level-change 2023-03-06 18:00:49 +01:00
Antonio Andelic
9e3794f7d7 Skip for sanitizer builds 2023-03-06 14:36:53 +00:00
kssenii
cb3dd3c200 Fix flaky test 2023-03-06 13:06:31 +01:00
Han Fei
b7eef62458
Merge pull request #45491 from azat/dist/async-send-refactoring
[RFC] Rewrite distributed sends to avoid using filesystem as a queue, use in-memory queue instead
2023-03-06 12:32:33 +01:00
Antonio Andelic
3a184880c6 Add test for clrs 2023-03-05 17:18:53 +00:00
kssenii
b8d33f4d38 Fix test 2023-03-05 13:46:23 +01:00
kssenii
d9e75e5c0a Fix test 2023-03-05 13:13:32 +01:00
kssenii
8f2d75cef8 Fix tests 2023-03-05 12:56:00 +01:00
Alexey Milovidov
41c79b0c42
Merge pull request #46086 from ClickHouse/fix-data-size
Fix data size calculation in Keeper
2023-03-05 14:11:36 +03:00
Sema Checherinda
85178c9609
Merge pull request #47102 from CheSema/merge-mutate-do-thread-group
do flushUntrackedMemory when context switches
2023-03-03 20:23:25 +01:00
robot-clickhouse
cebe323bef Automatic style fix 2023-03-03 15:56:11 +00:00
Smita Kulkarni
d2dbd5f293 Updated to use tryGet instead of get for checking stage of backups/restores in concurrency check and updated tests by increasing data size to have a longer backup/restore to ensure the overlap and increased timeout correspondingly. 2023-03-03 16:48:14 +01:00
AVMusorin
0f2ae72141
prohibit DEFAULT/EPHEMERAL/ALIAS in KafkaEngine 2023-03-03 16:25:42 +01:00
robot-clickhouse
46667d43d8 Automatic style fix 2023-03-03 15:25:25 +00:00
Antonio Andelic
737cf8e149 Better 2023-03-03 15:14:49 +00:00
Antonio Andelic
cd4100cb19
Merge branch 'master' into fix-data-size 2023-03-03 15:33:43 +01:00
Alexander Tokmakov
5be681c5f6
Merge pull request #47152 from ClickHouse/fix_flaky_test_replicated_database
Use unique names and paths in `test_replicated_database`
2023-03-03 17:15:27 +03:00
Alexander Tokmakov
cadaf06829
Merge pull request #46681 from ClickHouse/fix_insert_cancellation_in_native_protocol
Fix queries cancellation when a client dies
2023-03-03 16:27:20 +03:00
kssenii
0fa3fb3592 Fix show grants for user which has all grants 2023-03-03 14:04:32 +01:00
Konstantin Bogdanov
1bbf5acd47
Pass headers from StorageURL to WriteBufferFromHTTP (#46996)
* Pass headers from StorageURL to WriteBufferFromHTTP

* Add a test

* Lint

* `time.sleep(1)`

* Start echo server earlier

* Add proper handling for mock server start

* Automatic style fix

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2023-03-03 13:55:52 +01:00
Sema Checherinda
bc8b34f74b adjust test test_seekable_formats 2023-03-03 13:16:46 +01:00
Kseniia Sumarokova
386663953c
Merge branch 'master' into named-collections-finish 2023-03-03 12:23:38 +01:00
Antonio Andelic
a6da64aac0
Merge pull request #46824 from ClickHouse/fix-single-thread-parquet
Use initial range for fetching file size in HTTP read buffer
2023-03-03 09:23:22 +01:00
kssenii
cd7cd0526b Fix tests 2023-03-02 21:21:04 +01:00
kssenii
0c4bb3c80f Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-03-02 19:08:29 +01:00
robot-clickhouse
fdcbec4fee Automatic style fix 2023-03-02 17:35:56 +00:00
Alexander Tokmakov
c518f3690e Merge branch 'master' into fix_insert_cancellation_in_native_protocol 2023-03-02 18:24:08 +01:00
Alexander Tokmakov
fc8ea01c2b use unique names and paths in test_replicated_database 2023-03-02 18:23:31 +01:00
AndyB
cf245538b9 checker fix 2023-03-02 14:31:38 +00:00
Antonio Andelic
01cf9c94f4 Merge branch 'master' into custom-key-parallel-replicas 2023-03-02 14:28:42 +00:00
Antonio Andelic
5328a0777b Merge branch 'master' into fix-single-thread-parquet 2023-03-02 13:45:27 +00:00
kssenii
2883861795 Merge remote-tracking branch 'upstream/master' into allow-nested-disks-in-custom-disks 2023-03-02 14:30:58 +01:00
Constantine Peresypkin
c4ae17e495
fix black 2023-03-02 14:23:22 +01:00
Kseniia Sumarokova
e95c4b6379
Merge pull request #47011 from kssenii/fix-azure-test
Fix flaky azure test
2023-03-02 13:59:43 +01:00
Constantine Peresypkin
fdc6de2a27 use http request body in predefined http handlers
adds a new "virtual" parameter `__request_body`
which can be used in http rules, see below

tremendously helps in producing arbitrary REST interfaces

for example:

```xml
<http_handlers>
  <rule>
    <methods>POST</methods>
    <url>/ingest</url>
    <handler>
      <type>predefined_query_handler</type>
      <query>INSERT INTO events(id, data) SELECT {id:UInt32}, {__request_body:String}</query>
    </handler>
  </rule>
</http_handlers>
```
2023-03-02 12:51:48 +01:00
Kruglov Pavel
ce8e49a9a0
Merge pull request #45693 from Avogar/fix-kafka-protobuf
Fix formats parser resetting, test processing bad messages in kafka
2023-03-02 11:50:45 +01:00
AndyB
657afa849e logger level in test 2023-03-01 23:35:09 +00:00
robot-clickhouse
54336f7c98 Automatic style fix 2023-03-01 20:12:00 +00:00
kssenii
f3e3b916c9 Allow nested custom disks 2023-03-01 19:55:59 +01:00
Alexander Gololobov
f64d08bd5c Enable lightweight delete support by default 2023-03-01 19:35:55 +01:00
alesapin
ebba37b18f
Merge pull request #47010 from ClickHouse/zero_copy_fetch
Fix bug in zero-copy replication disk choice during fetch
2023-03-01 15:55:00 +01:00
Alexander Tokmakov
a97e15e36f Merge branch 'master' into fix_insert_cancellation_in_native_protocol 2023-03-01 14:26:41 +01:00
Kseniia Sumarokova
b9bb7bcce3
Update test.py 2023-03-01 13:14:53 +01:00
Kseniia Sumarokova
adf2d56a2d
Update test.py 2023-03-01 12:35:01 +01:00
AVMusorin
99329d8682 Improve tests for Distributed INSERT
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 23:17:37 +01:00
Antonio Andelic
6e28406751 Merge branch 'master' into fix-data-size 2023-02-28 20:09:29 +00:00
pufit
29296cb004
Merge pull request #46550 from ClickHouse/46231-systerm-server-settings
Implement `system.server_settings`
2023-02-28 11:23:15 -05:00
robot-clickhouse
38d026ca6e Automatic style fix 2023-02-28 14:29:24 +00:00
Antonio Andelic
919122948f More fixes and add tests 2023-02-28 14:22:44 +00:00
robot-clickhouse
82be8eb468 Automatic style fix 2023-02-28 13:56:14 +00:00
kssenii
ef58249115 Fix 2023-02-28 14:52:11 +01:00
alesapin
bb7571427b Fix bug in zero-copy replica disk choice during fetch 2023-02-28 14:48:46 +01:00
kssenii
de81a5f92d Fix integration tests 2023-02-28 13:36:52 +01:00
kssenii
f43e00c3ca Add order by to test to fix flakyness 2023-02-28 11:32:33 +01:00
kssenii
69cdf401a4 Add test for materialized view with materialized postgresql 2023-02-27 22:29:16 +01:00
kssenii
03c9eeb106 Fix tests 2023-02-27 14:29:20 +01:00
avogar
0ef83b10ce Fix style 2023-02-27 13:01:07 +00:00
robot-clickhouse
5f7220e498 Automatic style fix 2023-02-26 18:15:55 +00:00
Smita Kulkarni
4c5d39725c Updated node to check BACKUP_CREATED to node1 in test_concurrent_backups_on_different_nodes 2023-02-26 19:08:26 +01:00
Smita Kulkarni
10c92b6cb0 Increased ddl timeout during DROP of table and updated node for concurrent backups on different node 2023-02-26 19:06:31 +01:00
Alexey Milovidov
9ac48dddb8
Merge pull request #46888 from vitlibar/fix-test_async_backups_to_same_destination
Fix test test_async_backups_to_same_destination.
2023-02-26 11:36:18 +03:00
Robert Schulze
5e68d50b39
Merge pull request #46752 from ClickHouse/rs/periods-in-kafka-topics
Allow configuration of Kafka topics with periods
2023-02-26 07:49:28 +01:00
Alexey Milovidov
8f40bbd5b4
Revert "Fix several RENAME COLUMN bugs." 2023-02-26 05:47:05 +03:00
Alexey Milovidov
936f57e7b2
Merge pull request #46887 from ClickHouse/fix-flaky-test-12
Fix flaky `test_concurrent_queries_restriction_by_query_kind`
2023-02-26 04:30:51 +03:00
Alexey Milovidov
eb89ab471f
Merge pull request #45911 from ClickHouse/mutations_rename_hang
Fix several `RENAME COLUMN` bugs.
2023-02-26 01:56:40 +03:00
Alexey Milovidov
656af55831
Merge pull request #46384 from ClickHouse/fixes_for_993
Fixes for 993
2023-02-26 01:55:20 +03:00
Vitaly Baranov
2d38c89e2a Fix test test_async_backups_to_same_destination. 2023-02-25 23:38:40 +01:00
Alexey Milovidov
88704c4d9f Fix flaky test_concurrent_queries_restriction_by_query_kind 2023-02-25 22:23:29 +01:00
Robert Schulze
fbba9e319d
Merge branch 'master' into rs/periods-in-kafka-topics 2023-02-25 21:45:20 +01:00
SmitaRKulkarni
4109fbd7cf
Merge pull request #46517 from azat/tests/fix-backup-restore-flakiness
Fix flakiness of test_backup_restore_on_cluster/test_disallow_concurrency
2023-02-25 19:54:21 +01:00
Alexander Tokmakov
cad1e0b768 fix 2023-02-25 01:18:34 +01:00
kssenii
6224ca9cd6 Fix 2023-02-24 17:08:05 +01:00
kssenii
357ffcb61f More review fixes 2023-02-24 16:53:16 +01:00
kssenii
8b40723fed Better fix 2023-02-24 16:19:36 +01:00
kssenii
f2a9109fe1 Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-02-24 15:20:46 +01:00
kssenii
0555ca2724 Review fixes 2023-02-24 14:44:47 +01:00
avogar
c6a30d23aa Add separate test 2023-02-24 12:31:09 +00:00
Kruglov Pavel
2150b836b1
Merge branch 'master' into fix-kafka-protobuf 2023-02-24 12:48:07 +01:00
Robert Schulze
6906cafa99
Change to S3 cfg syntax 2023-02-23 20:04:41 +00:00
Alexander Tokmakov
f76c42348b
Merge pull request #46402 from lzydmxy/apply_move_partition_to_all_replicas
Apply `ALTER TABLE ON CLUSTER MOVE PARTITION TO DISK|VOLUME` to all replicas.
2023-02-23 19:42:54 +03:00
Kruglov Pavel
bda1ce7367
Update test.py 2023-02-23 14:47:29 +01:00
Kseniia Sumarokova
7e064ccbd4
Merge pull request #46667 from kssenii/hide-named-collections-under-setting
Allow to hide only values from system.named_collections while making collection visible
2023-02-23 11:44:50 +01:00
Kseniia Sumarokova
30a8eb0c2f
Merge pull request #46670 from kssenii/hide-disk-setting
Hide arguments of custom disk merge tree setting
2023-02-23 11:42:53 +01:00
Alexey Milovidov
0db943e596
Merge pull request #46687 from ClickHouse/tavplubix-patch-5
Disable flaky test_ttl_move_memory_usage.py
2023-02-23 10:27:25 +03:00
Robert Schulze
81bf43157f
Allow configuration of Kafka topics with periods
The Kafka table engine allows global configuration and per-Kafka-topic
configuration. The latter uses syntax <kafka_TOPIC>, e.g. for topic
"football":

  <kafka_football>
      <retry_backoff_ms>250</retry_backoff_ms>
      <fetch_min_bytes>100000</fetch_min_bytes>
  </kafka_football>

Some users had to find out the hard way that such configuration doesn't
take effect if the topic name contains a period, e.g. "sports.football".
The reason is that ClickHouse configuration framework already uses
periods as level separators to descend the configuration hierarchy.
(Besides that, per-topic configuration at the same level as global
configuration could be considered ugly.)

Note that Kafka topics may contain characters "a-zA-Z0-9._-" (*) and
a tree-like topic organization using periods is quite common in
practice.

This PR deprecates the existing per-topic configuration syntax (but
continues to support it for backward compat) and introduces a new
per-topic configuration syntax below the global Kafka configuration of
the form:

<kafka>
   <topic name="football">
       <retry_backoff_ms>250</retry_backoff_ms>
       <fetch_min_bytes>100000</fetch_min_bytes>
   </topic>
</kafka>

The period restriction doesn't apply to XML attributes, so <topic
name="sports.football"> will work. Also, everything Kafka-related is
below <kafka>.

Considered but rejected alternatives:
- Extending Poco ConfigurationView with custom separators (e.g."/"
  instead of "."). Won't work easily because ConfigurationView only
  builds a path but defers descending the configuration tree to the
  normal configuration classes.
- Reloading the configuration file in StorageKafka (instead of reading
  the loaded file) but with a custom separator. This mode is supported
  by XML configuration. Too ugly and error-prone since the true
  configuration is composed from multiple configuration files.

(*) https://stackoverflow.com/a/37067544
2023-02-22 20:35:09 +00:00