Commit Graph

826 Commits

Author SHA1 Message Date
Kruglov Pavel
3a0cf5bf5b
Merge pull request #43311 from Avogar/proper-fix-lc-with-if
Fix bad cast from LowCardinality column when using short circuit function execution
2022-11-30 16:06:43 +01:00
Azat Khuzhin
eea32a3beb
Make insertRangeFrom() more exception safe (#43338)
* Make ColumnArray::insertRangeFrom() more safe

This should avoid possible out of sync and LOGICAL_ERROR exception
'offsets_column has data inconsistent with nested_column.'

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Make ColumnString::insertRangeFrom() more exception safe

Otherwise it is possible for offsets and chars go out of sync and
eventually you will get LOGICAL_ERROR exception
'String offsets has data inconsistent with chars array'

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-23 23:41:14 +01:00
Kruglov Pavel
975a59af7a
Fix build 2022-11-21 13:51:17 +01:00
Anton Popov
c67f5e2600
Update gtest_column_dump_structure.cpp 2022-11-17 04:40:09 +01:00
avogar
69d4381a3e Add comments 2022-11-16 22:42:50 +00:00
avogar
e98ac04678 Fix bad cast from LowCardinality column when using short circuit function execution 2022-11-16 22:34:24 +00:00
Anton Popov
bc19d35009 fix clang-tidy 2022-11-16 15:34:36 +00:00
Anton Popov
11c28abbed fix race in IColumn::dumpStructure 2022-11-16 00:57:22 +00:00
Robert Schulze
8ec4c77352
Merge pull request #42855 from GoGoWen/fix_typo
Fix typo
2022-11-02 12:54:52 +01:00
GoGoWen2021
2b0cde9ef9 fix typo 2022-11-01 17:46:44 +08:00
Anton Popov
2ae3cfa9e0
Merge branch 'master' into dynamic-columns-14 2022-10-31 16:15:19 +01:00
Nikita Taranov
49f6692a2e
Adapt internal data structures to 512-bit era (#42564)
* impl

* update tests

* fix tests
2022-10-25 13:56:28 +02:00
Robert Schulze
efd47c9eff
Merge pull request #42476 from ClickHouse/add-datetime-typedefs
Add convenience typedefs for Date/Date32/DateTime/DateTime64 columns
2022-10-25 08:45:57 +02:00
Anton Popov
e30d425869 fix build 2022-10-25 01:55:02 +00:00
Guo Wangyang
4e294b9bfc
ColumnVector: re-enable AVX512_VBMI/AVX512_VBMI2 optimized filter and index (#41765)
* Revert "Merge pull request #41752 from ClickHouse/revert-revert-revert"

This reverts commit 7bb245720a, reversing
changes made to 78002dc248.

* Revert "Merge pull request #41797 from ClickHouse/revert-41247"

This reverts commit 69b13d9f31, reversing
changes made to 1719e000ea.

* AVX512VBMI::vectorIndexImpl: Fix heap buffer overflow when limit == 0

* use SIMD_ELEMENTS instead of SIMD_BYTES to avoid confusing
2022-10-24 23:11:46 +02:00
Robert Schulze
655233e1c5
Add convenience typedefs for Date/Date32/DateTime/DateTime64 columns 2022-10-24 16:55:41 +00:00
Azat Khuzhin
bbcdedb945 Revert changes of hash functions signatures and fix callers
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 22:40:17 +02:00
Azat Khuzhin
905a95e166 Review fixes
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 22:40:13 +02:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Alexey Milovidov
8cd9878c83
Merge pull request #41921 from ucasfl/remove
remove unused code
2022-10-09 03:13:50 +03:00
Robert Schulze
78be400ac0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup 2022-10-06 12:22:43 +00:00
Robert Schulze
da5a2e2db0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup
Physical merge conflicts:
- src/Common/ZooKeeper/ZooKeeperImpl.cpp
- src/Core/config_core.h.in
- src/Functions/FunctionsAES.h
- src/Functions/config_functions.h.in
- src/configure_config.cmake

Logical merge conflicts:
- Functions/tryDecrypt.cpp
2022-10-06 08:43:25 +00:00
flynn
772aec360b remove unused virtual keyword 2022-10-04 15:33:29 +00:00
Anton Popov
6e61cf92f5 Merge remote-tracking branch 'upstream/master' into HEAD 2022-10-03 13:16:57 +00:00
flynn
ea06e20cae remove unused code 2022-10-03 21:03:41 +08:00
Anton Popov
2054582a06
Merge pull request #41960 from ucasfl/insert-from-optimize
optimize insertFrom of ColumnAggregateFunction to share Aggregate State in some cases
2022-10-03 14:57:39 +02:00
Robert Schulze
db5ef7b3cb
Merge branch 'master' into generated-file-cleanup 2022-10-02 23:13:18 +02:00
Robert Schulze
fe2dde0c89
Merge pull request #41702 from ClibMouse/resolve-findings-from-clang-tidy
Resolve findings from clang-tidy
2022-10-02 20:36:24 +02:00
ltrk2
0505040e50 Resolve finding from clang-tidy 2022-09-30 10:31:44 -07:00
flynn
d666951cb1 optimize insertFrom of ColumnAggregateFunction to share Aggregate State in some cases 2022-09-30 18:04:51 +08:00
Robert Schulze
fd86829824
Consolidate config_core.h into config.h
Less duplication, less confusion ...
2022-09-28 13:31:57 +00:00
Alexey Milovidov
5407291191 Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
This reverts commit 8de524cb73.
2022-09-26 22:36:12 +02:00
Alexey Milovidov
e3a6f2381b Revert "Merge pull request #40033 from ClickHouse/reenable-avx512-vbmi-columnvector-filter"
This reverts commit 70f63d2aae, reversing
changes made to a0693c3a84.
2022-09-25 17:03:52 +02:00
Robert Schulze
2b2b058693
Fix build
Fallout of #41186
2022-09-23 13:26:15 +00:00
Guo Wangyang
8de524cb73
ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)
* ColumnVector: optimize UInt8 index with AVX512VBMI

* ColumnVector: coding style fix

* ColumnVector: add index test

* ColumnVector: refactory to use default impl for index

* ColumnVector: add more comments

* ColumnVector: more precise and simple type declaration

* Fix style check failure

Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2022-09-23 01:59:49 +02:00
Alexey Milovidov
45bd3cfc30 Merge branch 'master' into fix-three-fourth-of-trash 2022-09-20 21:27:41 +02:00
Alexey Milovidov
6a473d8998 Merge 2022-09-19 08:53:20 +02:00
Alexey Milovidov
91baedf03a Fix 6/7 of trash 2022-09-19 08:53:20 +02:00
Alexey Milovidov
3c0961c48b
Merge branch 'master' into fix-map-combinator 2022-09-19 09:32:16 +03:00
Alexey Milovidov
7f68f2c7df Remove trash from LowCardinality 2022-09-18 04:13:21 +02:00
Alexey Milovidov
f4a48cd4d6 Remove cruft 2022-09-17 22:16:31 +02:00
Anton Popov
07cfb0cba4
Merge branch 'master' into dynamic-columns-21 2022-09-17 19:02:58 +02:00
Alexey Milovidov
ada7a44ae4 Remove -WithTerminatingZero methods 2022-09-17 05:34:18 +02:00
Alexey Milovidov
0c3835240b Fix error with multidimensional arrays 2022-09-17 04:16:24 +02:00
Alexey Milovidov
701fdd77b4 Fix wrong implementation of getDataAt for multidimensional arrays 2022-09-16 08:12:28 +02:00
Anton Popov
66667737f0 fix writing of empty columns of type Object 2022-09-15 03:38:22 +00:00
avogar
f1a0501eb2 Fix memory leaks and segfaults in combinators 2022-09-14 18:01:49 +00:00
Alexey Milovidov
2aedd41023
Remove strange code (#40195)
* Remove strange code

* Even more code removal

* Fix style

* Remove even more code

* Simplify code by making it slower

* Attempt to do something

* Attempt to do something

* Well do something with this horrible trash

* Add a test
2022-09-12 16:29:23 +02:00
Alexey Milovidov
9a0892c40c
Merge pull request #41171 from ClickHouse/fix-half-of-trash
Fix half of trash
2022-09-11 21:40:22 +03:00
Alexey Milovidov
0896e6b9b6
Merge pull request #41183 from ClickHouse/fix-parallel-hash-join-for-floats
Better parallel hash JOIN for floats
2022-09-11 09:13:57 +03:00